dri-devel March 2021

dri-devel@lists.freedesktop.org

326 participants
867 discussions

Re: remove the nvlink2 pci_vfio subdriver
by Greg Kroah-Hartman 22 Mar '21

22 Mar '21

On Mon, Mar 22, 2021 at 04:01:53PM +0100, Christoph Hellwig wrote: > Hi all, > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > feature without any open source component - what would normally be > the normal open source userspace that we require for kernel drivers, > although in this particular case user space could of course be a > kernel driver in a VM. It also happens to be a complete mess that > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > and also pulles in over 1000 lines of code always build into powerpc > kernels that have Power NV support enabled. Because of all these > issues and the lack of breaking userspace when it is removed I think > the best idea is to simply kill. > > Diffstat: > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > b/arch/powerpc/include/asm/opal.h | 3 > b/arch/powerpc/include/asm/pci-bridge.h | 1 > b/arch/powerpc/include/asm/pci.h | 7 > b/arch/powerpc/platforms/powernv/Makefile | 2 > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > b/arch/powerpc/platforms/powernv/pci.c | 11 > b/arch/powerpc/platforms/powernv/pci.h | 17 > b/arch/powerpc/platforms/pseries/pci.c | 23 > b/drivers/vfio/pci/Kconfig | 6 > b/drivers/vfio/pci/Makefile | 1 > b/drivers/vfio/pci/vfio_pci.c | 18 > b/drivers/vfio/pci/vfio_pci_private.h | 14 > b/include/uapi/linux/vfio.h | 40 - > drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ > 16 files changed, 8 insertions(+), 1517 deletions(-) I thought this was supposed to be removed a few years ago! Anyway, no objection from me: Acked-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>

1 0

[PATCH v4, 00/10] soc: mediatek: mmsys: Use function call for setting the routing registers
by Yongqiang Niu 22 Mar '21

22 Mar '21

The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base 5.11-rc1 change since v3: - move register operation into mmsys path select function Yongqiang Niu (10): soc: mediatek: mmsys: create mmsys folder soc: mediatek: mmsys: Create struct mtk_mmsys to store context data soc: mediatek: mmsys: move register operation into mmsys path select function soc: mediatek: mmsys: Use function call for setting the routing registers soc: mediatek: mmsys: add mt8183 function call for setting the routing registers soc: mediatek: mmsys: add component OVL_2L2 soc: mediatek: mmsys: add component POSTMASK soc: mediatek: mmsys: add component RDMA4 soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register soc: mediatek: mmsys: add mt8192 mmsys support drivers/soc/mediatek/Makefile | 2 +- drivers/soc/mediatek/mmsys/Makefile | 5 + drivers/soc/mediatek/mmsys/mt2701-mmsys.c | 254 ++++++++++++++++++++ drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 110 +++++++++ drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 149 ++++++++++++ drivers/soc/mediatek/mmsys/mtk-mmsys.c | 180 ++++++++++++++ drivers/soc/mediatek/mtk-mmsys.c | 373 ------------------------------ include/linux/soc/mediatek/mtk-mmsys.h | 25 ++ 8 files changed, 724 insertions(+), 374 deletions(-) create mode 100644 drivers/soc/mediatek/mmsys/Makefile create mode 100644 drivers/soc/mediatek/mmsys/mt2701-mmsys.c create mode 100644 drivers/soc/mediatek/mmsys/mt8183-mmsys.c create mode 100644 drivers/soc/mediatek/mmsys/mt8192-mmsys.c create mode 100644 drivers/soc/mediatek/mmsys/mtk-mmsys.c delete mode 100644 drivers/soc/mediatek/mtk-mmsys.c -- 1.8.1.1.dirty

6 18

soc: mediatek: Prepare MMSYS for DDP routing using function call
by Yongqiang Niu 22 Mar '21

22 Mar '21

The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base change: https://patchwork.kernel.org/project/linux-mediatek/patch/20201006193320.40… Change since v2: - fix review issue in v2 - add 8183 mmsys function call - add 8192 new component - add 8192 mmsys function call

3 17

[PATCH 1/2] fbdev: omapfb: avoid -Wempty-body warning
by Arnd Bergmann 22 Mar '21

22 Mar '21

From: Arnd Bergmann <arnd(a)arndb.de> Building with 'make W=1' shows a few harmless warnings: drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_calc_addr': drivers/video/fbdev/omap2/omapfb/omapfb-main.c:823:56: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 823 | var->xoffset, var->yoffset, offset); | ^ drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c: In function 'omapfb_ioctl': drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c:911:45: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 911 | DBG("ioctl failed: %d\n", r); Avoid these by using no_printk(), which adds format string checking as well. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/video/fbdev/omap2/omapfb/omapfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb.h b/drivers/video/fbdev/omap2/omapfb/omapfb.h index d27abccb37bc..1c1b5201c8b6 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb.h +++ b/drivers/video/fbdev/omap2/omapfb/omapfb.h @@ -29,7 +29,7 @@ extern bool omapfb_debug; printk(KERN_DEBUG "OMAPFB: " format, ## __VA_ARGS__); \ } while (0) #else -#define DBG(format, ...) +#define DBG(format, ...) no_printk(format, ## __VA_ARGS__) #endif #define FB2OFB(fb_info) ((struct omapfb_info *)(fb_info->par)) -- 2.29.2

3 3

[PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0
by Evan Benn 22 Mar '21

22 Mar '21

AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 to ensure no display backlight will flicker at low user brightness settings. However this value is quite bright, so for devices that do not implement the ACPI ATIF ATIF_FUNCTION_QUERY_BRIGHTNESS_TRANSFER_CHARACTERISTICS functionality the user cannot set the brightness to a low level even if the display would support such a low PWM. This ATIF feature is not implemented on for example AMD grunt chromebooks. Signed-off-by: Evan Benn <evanbenn(a)chromium.org> --- I could not find a justification for the reason for the value. It has caused some noticable regression for users: https://bugzilla.kernel.org/show_bug.cgi?id=203439 Maybe this can be either user controlled or userspace configured, but preventing users from turning their backlight dim seems wrong. Also reviewed here: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/… drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 573cf17262da..0129bd69b94e 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3151,7 +3151,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev) return 0; } -#define AMDGPU_DM_DEFAULT_MIN_BACKLIGHT 12 +#define AMDGPU_DM_DEFAULT_MIN_BACKLIGHT 0 #define AMDGPU_DM_DEFAULT_MAX_BACKLIGHT 255 #define AUX_BL_DEFAULT_TRANSITION_TIME_MS 50 -- 2.31.0.291.g576ba9dcdaf-goog

4 6

[PATCH 1/2] dt-bindings: backlight: Add Kinetic KTD259 bindings
by Linus Walleij 22 Mar '21

22 Mar '21

The KTD259 is just a newer version of the KTD253 and works all the same. Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- .../bindings/leds/backlight/kinetic,ktd253.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml index 7a6ec1f8c0f3..73fa59e62181 100644 --- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml @@ -4,13 +4,13 @@ $id: http://devicetree.org/schemas/leds/backlight/kinetic,ktd253.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Kinetic Technologies KTD253 one-wire backlight +title: Kinetic Technologies KTD253 and KTD259 one-wire backlight maintainers: - Linus Walleij <linus.walleij(a)linaro.org> description: | - The Kinetic Technologies KTD253 is a white LED backlight that is + The Kinetic Technologies KTD253 and KTD259 are white LED backlights controlled by a single GPIO line. If you just turn on the backlight it goes to maximum backlight then you can set the level of backlight using pulses on the enable wire. This is sometimes referred to as @@ -21,7 +21,10 @@ allOf: properties: compatible: - const: kinetic,ktd253 + items: + - enum: + - kinetic,ktd253 + - kinetic,ktd259 enable-gpios: description: GPIO to use to enable/disable and dim the backlight. -- 2.29.2

3 5

[PATCH V2] drm/amdgpu: Fix a typo
by Bhaskar Chowdhury 22 Mar '21

22 Mar '21

s/traing/training/ ...Plus the entire sentence construction for better readability. Signed-off-by: Bhaskar Chowdhury <unixbhaskar(a)gmail.com> --- Changes from V1: Alex and Randy's suggestions incorporated. drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c index c325d6f53a71..bf3857867f51 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops) if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) { /* - * Long traing will encroach certain mount of bottom VRAM, - * saving the content of this bottom VRAM to system memory - * before training, and restoring it after training to avoid - * VRAM corruption. + * Long training will encroach a certain amount on the bottom of VRAM; + * save the content from the bottom VRAM to system memory + * before training, and restore it after training to avoid + * VRAM corruption. */ sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE; -- 2.26.2

3 2

[PATCH] drm/sysfs: Convert sysfs sprintf/snprintf family to sysfs_emit
by Tian Tao 22 Mar '21

22 Mar '21

Fix the following coccicheck warning: drivers/gpu/drm/drm_sysfs.c:172:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/drm_sysfs.c:185:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/drm_sysfs.c:159:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/drm_sysfs.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index f0336c8..968a956 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -156,8 +156,8 @@ static ssize_t status_show(struct device *device, status = READ_ONCE(connector->status); - return snprintf(buf, PAGE_SIZE, "%s\n", - drm_get_connector_status_name(status)); + return sysfs_emit(buf, "%s\n", + drm_get_connector_status_name(status)); } static ssize_t dpms_show(struct device *device, @@ -169,8 +169,7 @@ static ssize_t dpms_show(struct device *device, dpms = READ_ONCE(connector->dpms); - return snprintf(buf, PAGE_SIZE, "%s\n", - drm_get_dpms_name(dpms)); + return sysfs_emit(buf, "%s\n", drm_get_dpms_name(dpms)); } static ssize_t enabled_show(struct device *device, @@ -182,7 +181,7 @@ static ssize_t enabled_show(struct device *device, enabled = READ_ONCE(connector->encoder); - return snprintf(buf, PAGE_SIZE, enabled ? "enabled\n" : "disabled\n"); + return sysfs_emit(buf, enabled ? "enabled\n" : "disabled\n"); } static ssize_t edid_show(struct file *filp, struct kobject *kobj, -- 2.7.4

2 1

Re: ✗ Fi.CI.IGT: failure for Default request/fence expiry + watchdog (rev3)
by Tvrtko Ursulin 22 Mar '21

22 Mar '21

On 19/03/2021 01:17, Patchwork wrote: Okay with 20s default expiration the hangcheck tests on Tigerlake pass and we are left with these failures: > IGT changes > > > Possible regressions > > * > > igt@gem_ctx_ringsize@idle@bcs0: > > o shard-skl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl10/igt@gem_ct…> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19806/shard-skl7/igt@gem…> Too many runnable requests on a slow Skylake SKU with command parsing active. Too many to finish withing the 20s default expiration that is. This is actually the same root cause as the below tests tries to explicitly demonstrate: > * > > {igt@gem_watchdog@far-fence@bcs0} (NEW): > > o shard-glk: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19806/shard-glk7/igt@gem…> > * > > {igt@gem_watchdog@far-fence@vcs0} (NEW): > > o shard-apl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19806/shard-apl1/igt@gem…> > +2 similar issues > * > > {igt@gem_watchdog@far-fence@vecs0} (NEW): > > o shard-kbl: NOTRUN -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19806/shard-kbl7/igt@gem…> > +2 similar issues The vulnerability default expiration adds compared to the current state is applicable to heaviliy loaded systems where GPU is shared between multiple clients. Otherwise series seems to work. Failing tests can be blacklisted going forward. Ack to merge and merge itself, after review, I leave to maintainers since personally I am not supportive of this mechanism. Regards, Tvrtko

2 1

[PATCH] drm/ttm: stop warning on TT shrinker failure v2
by Christian König 22 Mar '21

22 Mar '21

Don't print a warning when we fail to allocate a page for swapping things out. v2: only stop the warning Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 2f0833c98d2c..48b9a650630b 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -369,7 +369,7 @@ static unsigned long ttm_tt_shrinker_scan(struct shrinker *shrink, }; int ret; - ret = ttm_bo_swapout(&ctx, GFP_NOFS); + ret = ttm_bo_swapout(&ctx, GFP_NOFS | __GFP_NOWARN); return ret < 0 ? SHRINK_EMPTY : ret; } -- 2.25.1

2 1

← Newer
1
...
41
42
43
44
45
46
47
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2021