dri-devel May 2021

dri-devel@lists.freedesktop.org

348 participants
807 discussions

[PATCH v2 0/1] drm/dp_mst: Use kHz as link rate units when settig source max link caps at init
by Nikola Cornij 13 May '21

13 May '21

Change log: v2: - Added 'Acked-by' to comment v1: - Initial Nikola Cornij (1): drm/dp_mst: Use kHz as link rate units when settig source max link caps at init .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++-- drivers/gpu/drm/drm_dp_mst_topology.c | 8 ++++---- drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++-- drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 +++-- drivers/gpu/drm/radeon/radeon_dp_mst.c … [View More]

2 2

[PATCH][next] drm: simpledrm: Fix use after free issues
by Colin King 13 May '21

13 May '21

From: Colin Ian King <colin.king(a)canonical.com> There are two occurrances where objects are being free'd via a put call and yet they are being referenced after this. Fix these by adding in the missing continue statement so that the put on the end of the loop is skipped over. Addresses-Coverity: ("Use after free") Fixes: 11e8f5fd223b ("drm: Add simpledrm driver") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/tiny/simpledrm.c | 2 ++ 1 file … [View More]

2 1

[PATCH] component: Move host device to end of device lists on binding
by Stephen Boyd 13 May '21

13 May '21

The device lists are poorly ordered when the component device code is used. This is because component_master_add_with_match() returns 0 regardless of component devices calling component_add() first. It can really only fail if an allocation fails, in which case everything is going bad and we're out of memory. The host device (called master_dev in the code), can succeed at probe and be put on the device lists before any of the component devices are probed and put on the lists. Within the … [View More]component device framework this usually isn't that bad because the real driver work is done at bind time via component{,master}_ops::bind(). It becomes a problem when the driver core, or host driver, wants to operate on the component device outside of the bind/unbind functions, e.g. via 'remove' or 'shutdown'. The driver core doesn't understand the relationship between the host device and the component devices and could possibly try to operate on component devices when they're already removed from the system or shut down. Normally, device links or probe defer would reorder the lists and put devices that depend on other devices in the lists at the correct location, but with component devices this doesn't happen because this information isn't expressed anywhere. Drivers simply succeed at registering their component or host with the component framework and wait for their bind() callback to be called once the other components are ready. We could make various device links between 'master_dev' and 'component->dev' but it's not necessary. Let's simply move the hosting device to the end of the device lists when the component device fully binds. This way we know that all components are present and have probed properly and now the host device has really probed so it's safe to assume the host driver ops can operate on any component device. This fixes the msm display driver shutdown path when the DSI controller is connected to a DSI bridge that is controlled via i2c. In this case, the msm display driver wants to tear down the display pipeline on shutdown at msm_pdev_shutdown() by calling drm_atomic_helper_shutdown(), and it can't do that unless the whole display chain is still probed and active in the system. When a display bridge is on i2c, the i2c device for the bridge will be created whenever the i2c controller probes, which could be before or after the msm display driver probes. If the i2c controller probes after the display driver, then the i2c controller will be shutdown before the display controller during system wide shutdown and thus i2c transactions will stop working before the display pipeline is shut down. This means we'll have the display bridge trying to access an i2c bus that's shut down because drm_atomic_helper_shutdown() is trying to disable the bridge after the bridge is off. Moving the host device to the end of the lists at bind time moves the drm_atomic_helper_shutdown() call before the i2c bus is shutdown. This fixes the immediate problem, but we could improve it a bit by modeling device links from the component devices to the host device indicating that they supply something, although it is slightly different because the consumer doesn't need the suppliers to probe to succeed. Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> Cc: Rob Clark <robdclark(a)gmail.com> Cc: <dri-devel(a)lists.freedesktop.org> Signed-off-by: Stephen Boyd <swboyd(a)chromium.org> --- drivers/base/component.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/component.c b/drivers/base/component.c index dcfbe7251dc4..de645420bae2 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -15,6 +15,8 @@ #include <linux/slab.h> #include <linux/debugfs.h> +#include "base.h" + /** * DOC: overview * @@ -657,6 +659,14 @@ int component_bind_all(struct device *master_dev, void *data) c = master->match->compare[i - 1].component; component_unbind(c, master, data); } + } else { + /* + * Move to the tail of the list so that master_dev driver ops + * like 'shutdown' or 'remove' are called before any of the + * dependencies that the components have are shutdown or + * removed. + */ + device_pm_move_to_tail(master_dev); } return ret; base-commit: 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 -- https://chromeos.dev [View Less]

5 16

[PULL] drm-misc-fixes
by Maxime Ripard 13 May '21

13 May '21

Hi Dave, Daniel, Here's the first round of drm-misc-fixes for 5.13 Maxime drm-misc-fixes-2021-05-13: A BO list maintainance fix for TTM, removing an unused function and a MAINTAINERS update. The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-05-13 for you to fetch changes up to … [View More]

1 0

[PATCH -next] drm/aperture: Fix missing unlock on error in devm_aperture_acquire()
by Zou Wei 13 May '21

13 May '21

Add the missing unlock before return from function devm_aperture_acquire() in the error handling case. Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Zou Wei <zou_wei(a)huawei.com> --- drivers/gpu/drm/drm_aperture.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_aperture.c b/drivers/gpu/drm/drm_aperture.c index 33bf018..9335d9d 100644 --- a/drivers/gpu/drm/drm_aperture.c +++ b/drivers/gpu/drm/drm_aperture.c @@ -164,13 +… [View More]

2 1

[PATCH -next] drm: simpledrm: print resource info using '%pr'
by Randy Dunlap 13 May '21

13 May '21

struct resource start and end fields are not always long long, so using %llx to print them can cause build warnings (below). Fix these by using the special "%pr" for printing struct resource info. ../drivers/gpu/drm/tiny/simpledrm.c: In function ‘simpledrm_device_init_mm’: ../include/drm/drm_print.h:412:32: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘resource_size_t {aka unsigned int}’ [-Wformat=] ../drivers/gpu/drm/tiny/simpledrm.c:533:54:… [View More]

2 1

Re: [PATCH] video/logo: protect against divide by zero when reading image
by Geert Uytterhoeven 13 May '21

13 May '21

Hi Yiyuan, CC dri-devel, linux-fbdev On Wed, 12 May 2021, Yiyuan GUO wrote: > In video/logo/pnmtologo.c, the function read_image can read from the > image file an integer 0 and pass it to function get_number255, leading > to a divide by zero problem. > > Signed-off-by: Yiyuan GUO <yguoaz(a)gmail.com> Thanks for your patch! > --- a/drivers/video/logo/pnmtologo.c > +++ b/drivers/video/logo/pnmtologo.c > @@ -118,7 +118,12 @@ static unsigned int get_number(FILE *fp)… [View More]

2 1

[PATCH v2 0/3] VT_RESIZEX fixes
by Maciej W. Rozycki 13 May '21

13 May '21

Hi, This is a minor update to the previous version of the series, adding a clarification to 3/3 as to the problem the original fix to which caused the functional regression the removal of extra VT_RESIZEX parameter handling caused. No change to actual code. See individual change descriptions for details. Please apply. Maciej

1 3

[PATCH -next 0/4] drm/radeon: fix some doc-warnings
by Yang Yingliang 13 May '21

13 May '21

Yang Yingliang (4): drm/radeon/cik: correct function name cik_irq_suspend() drm/radeon: correct function name radeon_cs_parser_fini() drm/radeon/r100: correct function name r100_cs_packet_parse_vline() drm/radeon/radeon_vm: correct function names in radeon_vm.c drivers/gpu/drm/radeon/cik.c | 2 +- drivers/gpu/drm/radeon/r100.c | 2 +- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_vm.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) -- 2.25.1

1 4

[PATCH V3 RESEND] drm/i915: Fix "mitigations" parsing if i915 is builtin
by Jisheng Zhang 13 May '21

13 May '21

I met below error during boot with i915 builtin if pass "i915.mitigations=off": [ 0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' The reason is slab subsystem isn't ready at that time, so kstrdup() returns NULL. Fix this issue by using stack var instead of kstrdup(). Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security mitigations") Signed-off-by: Jisheng Zhang <Jisheng.Zhang(a)synaptics.com> --- Since v2: - Use strscpy() per Ville's … [View More]

1 0

← Newer
1
...
53
54
55
56
57
58
59
...
81
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2021