dri-devel May 2021

dri-devel@lists.freedesktop.org

348 participants
807 discussions

[PATCH 5.11 308/601] drm/stm: Fix bus_flags handling
by Greg Kroah-Hartman 12 May '21

12 May '21

From: Marek Vasut <marex(a)denx.de> [ Upstream commit 99e360442f223dd40fc23ae07c7a263836fd27e6 ] The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these flags are never set, and thus the LTDC GCR_DEPOL and GCR_PCPOL bits are never set and the LTDC behaves as if both DISPLAY_FLAGS_PIXDATA_POSEDGE and DISPLAY_FLAGS_DE_HIGH were always set. The fix for this problem is taken almost verbatim from MXSFB driver. In case there is a bridge attached to the LTDC, the bridge might have extra polarity requirements, so extract bus_flags from the bridge and use them for LTDC configuration. Otherwise, extract bus_flags from the connector, which is the display. Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") Signed-off-by: Marek Vasut <marex(a)denx.de> Signed-off-by: Yannick Fertre <yannick.fertre(a)st.com> Cc: Alexandre Torgue <alexandre.torgue(a)st.com> Cc: Antonio Borneo <antonio.borneo(a)st.com> Cc: Benjamin Gaignard <benjamin.gaignard(a)st.com> Cc: Maxime Coquelin <mcoquelin.stm32(a)gmail.com> Cc: Philippe Cornu <philippe.cornu(a)st.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vincent Abriou <vincent.abriou(a)st.com> Cc: Yannick Fertre <yannick.fertre(a)st.com> Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-stm32(a)st-md-mailman.stormreply.com To: dri-devel(a)lists.freedesktop.org Tested-by: Yannick Fertre <yannick.fertre(a)foss.st.com> Signed-off-by: Philippe Cornu <philippe.cornu(a)foss.st.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210127110756.125570-1-marex… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/stm/ltdc.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 3980677435cb..949511a0a24f 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -525,13 +525,42 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) { struct ltdc_device *ldev = crtc_to_ltdc(crtc); struct drm_device *ddev = crtc->dev; + struct drm_connector_list_iter iter; + struct drm_connector *connector = NULL; + struct drm_encoder *encoder = NULL; + struct drm_bridge *bridge = NULL; struct drm_display_mode *mode = &crtc->state->adjusted_mode; struct videomode vm; u32 hsync, vsync, accum_hbp, accum_vbp, accum_act_w, accum_act_h; u32 total_width, total_height; + u32 bus_flags = 0; u32 val; int ret; + /* get encoder from crtc */ + drm_for_each_encoder(encoder, ddev) + if (encoder->crtc == crtc) + break; + + if (encoder) { + /* get bridge from encoder */ + list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) + if (bridge->encoder == encoder) + break; + + /* Get the connector from encoder */ + drm_connector_list_iter_begin(ddev, &iter); + drm_for_each_connector_iter(connector, &iter) + if (connector->encoder == encoder) + break; + drm_connector_list_iter_end(&iter); + } + + if (bridge && bridge->timings) + bus_flags = bridge->timings->input_bus_flags; + else if (connector) + bus_flags = connector->display_info.bus_flags; + if (!pm_runtime_active(ddev->dev)) { ret = pm_runtime_get_sync(ddev->dev); if (ret) { @@ -567,10 +596,10 @@ static void ltdc_crtc_mode_set_nofb(struct drm_crtc *crtc) if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) val |= GCR_VSPOL; - if (vm.flags & DISPLAY_FLAGS_DE_LOW) + if (bus_flags & DRM_BUS_FLAG_DE_LOW) val |= GCR_DEPOL; - if (vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) + if (bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE) val |= GCR_PCPOL; reg_update_bits(ldev->regs, LTDC_GCR, -- 2.30.2

1 0

[PATCH 5.11 069/601] drm: bridge: fix ANX7625 use of mipi_dsi_() functions
by Greg Kroah-Hartman 12 May '21

12 May '21

From: Randy Dunlap <rdunlap(a)infradead.org> commit ed01fca38717169fcb61bd45ad1c3750d9c40d59 upstream. The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function interfaces so it should select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reviewed-by: Robert Foss <robert.foss(a)linaro.org> Cc: Xin Ji <xji(a)analogixsemi.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: dri-devel(a)lists.freedesktop.org Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: stable(a)vger.kernel.org Signed-off-by: Robert Foss <robert.foss(a)linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210415183619.1431-1-rdunlap… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/bridge/analogix/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/bridge/analogix/Kconfig +++ b/drivers/gpu/drm/bridge/analogix/Kconfig @@ -30,6 +30,7 @@ config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support" depends on DRM depends on OF + select DRM_MIPI_DSI help ANX7625 is an ultra-low power 4K mobile HD transmitter designed for portable devices. It converts MIPI/DPI to

1 0

[PATCH 5.10 015/530] drm: bridge: fix LONTIUM use of mipi_dsi_() functions
by Greg Kroah-Hartman 12 May '21

12 May '21

From: Randy Dunlap <rdunlap(a)infradead.org> commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! WARNING: modpost: suppressed 5 unresolved symbol warnings because there were too many) Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reviewed-by: Adren Grassein <adrien.grassein(a)gmail.com> Cc: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vinod Koul <vkoul(a)kernel.org> Cc: Bjorn Andersson <bjorn.andersson(a)linaro.org> Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: Adrien Grassein <adrien.grassein(a)gmail.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: dri-devel(a)lists.freedesktop.org Cc: stable(a)vger.kernel.org Signed-off-by: Robert Foss <robert.foss(a)linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210415183639.1487-1-rdunlap… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/bridge/Kconfig | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -54,6 +54,7 @@ config DRM_LONTIUM_LT9611 depends on OF select DRM_PANEL_BRIDGE select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C help Driver for Lontium LT9611 DSI to HDMI bridge @@ -138,6 +139,7 @@ config DRM_SII902X tristate "Silicon Image sii902x RGB/HDMI bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select I2C_MUX select SND_SOC_HDMI_CODEC if SND_SOC @@ -187,6 +189,7 @@ config DRM_TOSHIBA_TC358767 tristate "Toshiba TC358767 eDP bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select DRM_PANEL help

1 0

[PATCH 5.12 078/677] drm: bridge: fix ANX7625 use of mipi_dsi_() functions
by Greg Kroah-Hartman 12 May '21

12 May '21

1 0

[PATCH 5.11 015/601] drm: bridge: fix LONTIUM use of mipi_dsi_() functions
by Greg Kroah-Hartman 12 May '21

12 May '21

From: Randy Dunlap <rdunlap(a)infradead.org> commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! WARNING: modpost: suppressed 5 unresolved symbol warnings because there were too many) Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reviewed-by: Adren Grassein <adrien.grassein(a)gmail.com> Cc: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vinod Koul <vkoul(a)kernel.org> Cc: Bjorn Andersson <bjorn.andersson(a)linaro.org> Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: Adrien Grassein <adrien.grassein(a)gmail.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: dri-devel(a)lists.freedesktop.org Cc: stable(a)vger.kernel.org Signed-off-by: Robert Foss <robert.foss(a)linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210415183639.1487-1-rdunlap… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/bridge/Kconfig | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -67,6 +67,7 @@ config DRM_LONTIUM_LT9611UXC depends on OF select DRM_PANEL_BRIDGE select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C help Driver for Lontium LT9611UXC DSI to HDMI bridge @@ -151,6 +152,7 @@ config DRM_SII902X tristate "Silicon Image sii902x RGB/HDMI bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select I2C_MUX select SND_SOC_HDMI_CODEC if SND_SOC @@ -200,6 +202,7 @@ config DRM_TOSHIBA_TC358767 tristate "Toshiba TC358767 eDP bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select DRM_PANEL help

1 0

[PATCH 5.12 019/677] drm: bridge: fix LONTIUM use of mipi_dsi_() functions
by Greg Kroah-Hartman 12 May '21

12 May '21

From: Randy Dunlap <rdunlap(a)infradead.org> commit ad085b3a712a89e4a48472121b231add7a8362e4 upstream. The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so they need to select DRM_MIPI_DSI to prevent build errors. ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined! ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined! WARNING: modpost: suppressed 5 unresolved symbol warnings because there were too many) Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Reviewed-by: Adren Grassein <adrien.grassein(a)gmail.com> Cc: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Vinod Koul <vkoul(a)kernel.org> Cc: Bjorn Andersson <bjorn.andersson(a)linaro.org> Cc: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> Cc: Adrien Grassein <adrien.grassein(a)gmail.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: dri-devel(a)lists.freedesktop.org Cc: stable(a)vger.kernel.org Signed-off-by: Robert Foss <robert.foss(a)linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210415183639.1487-1-rdunlap… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/bridge/Kconfig | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -67,6 +67,7 @@ config DRM_LONTIUM_LT9611UXC depends on OF select DRM_PANEL_BRIDGE select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C help Driver for Lontium LT9611UXC DSI to HDMI bridge @@ -151,6 +152,7 @@ config DRM_SII902X tristate "Silicon Image sii902x RGB/HDMI bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select I2C_MUX select SND_SOC_HDMI_CODEC if SND_SOC @@ -200,6 +202,7 @@ config DRM_TOSHIBA_TC358767 tristate "Toshiba TC358767 eDP bridge" depends on OF select DRM_KMS_HELPER + select DRM_MIPI_DSI select REGMAP_I2C select DRM_PANEL help

1 0

[PULL] drm-misc-next
by Thomas Zimmermann 12 May '21

12 May '21

Hi Dave and Daniel, here's the first PR for drm-misc-next for what will go into v5.14. Some noteable changes are * consistency between the plane formats and allow_fb_modifiers in UAPI, * overlay support in vkms, * proper HDR support in vc4, * SVGA3 support in vmwgfx, * many TTM fixes and a debugfs file to trigger TTM's shrinker, * the core's AGP code and ioctl are now behind CONFIG_DRM_LEGACY, * a generic DRM driver that can pick up the firmware-provided framebuffer, * plus the related ownership management of framebuffer apertures, * and the usual round of cleanups throughout the tree. Best regards Thomas drm-misc-next-2021-05-12: drm-misc-next for 5.14: UAPI Changes: * drm: Disable connector force-probing for non-master clients * drm: Enforce consistency between IN_FORMATS property and cap + related driver cleanups * drm/amdgpu: Track devices, process info and fence info via /proc/<pid>/fdinfo * drm/ioctl: Mark AGP-related ioctls as legacy * drm/ttm: Provide tt_shrink file to trigger shrinker via debugfs; Cross-subsystem Changes: * fbdev/efifb: Special handling of non-PCI devices * fbdev/imxfb: Fix error message Core Changes: * drm: Add connector helper to attach HDR-metadata property and convert drivers * drm: Add connector helper to compare HDR-metadata and convert drivers * drm: Add conenctor helper to attach colorspace property * drm: Signal colorimetry in HDMI infoframe * drm: Support pitch for destination buffers; Add blitter function with generic format conversion * drm: Remove struct drm_device.pdev and update legacy drivers * drm: Remove obsolete DRM_KMS_FB_HELPER config option in core and drivers * drm: Remove obsolete drm_pci_alloc/drm_pci_free * drm/aperture: Add helpers for aperture ownership and convert drivers, replaces rsp fbdev helpers * drm/agp: Mark DRM AGP code as legacy and convert legacy drivers * drm/atomic-helpers: Cleanups * drm/dp: Handle downstream port counts of 0 correctly; AUX channel fixes; Use drm_err_*/drm_dbg_*(); Cleanups * drm/dp_dual_mode: Use drm_err_*/drm_dbg_*() * drm/dp_mst: Use drm_err_*/drm_dbg_*(); Use Extended Base Receiver Capability DPCD space * drm/gem-ttm-helper: Provide helper for dumb_map_offset and convert drivers * drm/panel: Use sysfs_emit; panel-simple: Use runtime PM, Power up panel when reading EDID, Cache EDID, Cleanups; Lms397KF04: DT bindings * drm/pci: Mark AGP helpers as legacy * drm/print: Handle NULL for DRM devices gracefully * drm/scheduler: Change scheduled fence track * drm/ttm: Don't count SG BOs against pages_limit; Warn about freeing pinned BOs; Fix error handling if no BO can be swapped out; Move special handling of non-GEM drivers into vmwgfx; Move page_alignment into the BO; Set drm-misc as TTM tree in MAINTAINERS; Cleanup ttm_agp_backend; Add ttm_sys_manager for system domain; Cleanups Driver Changes: * drm: Don't set allow_fb_modifiers explictly in drivers * drm/amdgpu: Pin/unpin fixes wrt to TTM; Use bo->base.size instead of mem->num_pages * drm/ast: Use managed pcim_iomap(); Fix EDID retrieval with DP501 * drm/bridge: MHDP8546: HDCP support + DT bindings, Register DP AUX channel with userspace; Sil8620: Fix module dependencies; dw-hdmi: Add option to not load CEC driver; Fix stopping in drm_bridge_chain_pre_enable(); Ti-sn65dsi86: Fix refclk handling, Break GPIO and MIPI-to-eDP into subdrivers, Use pm_runtime autosuspend, cleanups; It66121: Add driver + DT bindings; Adv7511: Support I2S IEC958 encoding; Anx7625: fix power-on delay; Nwi-dsi: Modesetting fixes; Cleanups * drm/bochs: Support screen blanking * drm/gma500: Cleanups * drm/gud: Cleanups * drm/i915: Use correct max source link rate for MST * drm/kmb: Cleanups * drm/meson: Disable dw-hdmi CEC driver * drm/nouveau: Pin/unpin fixes wrt to TTM; Use bo->base.size instead of mem->num_pages; Register AUX adapters after their connectors * drm/qxl: Fix shadow BO unpin * drm/radeon: Duplicate some DRM AGP code to uncouple from legacy drivers * drm/simpledrm: Add a generic DRM driver for simple-framebuffer devices * drm/tiny: Fix log spam if probe function gets deferred * drm/vc4: Add support for HDR-metadata property; Cleanups * drm/virtio: Create dumb BOs as guest blobs; * drm/vkms: Use managed drmm_universal_plane_alloc(); Add XRGB plane composition; Add overlay support * drm/vmwgfx: Enable console with DRM_FBDEV_EMULATION; Fix CPU updates of coherent multisample surfaces; Remove reservation semaphore; Add initial SVGA3 support; Support amd64; Use 1-based IDR; Use min_t(); Cleanups The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2021-05-12 for you to fetch changes up to 66079522883603d08a1b7f4153400d8c60705dcf: MAINTAINERS: Add Xinhui Pan as another AMDGPU contact (2021-05-12 14:52:57 +0200) ---------------------------------------------------------------- drm-misc-next for 5.14: UAPI Changes: * drm: Disable connector force-probing for non-master clients * drm: Enforce consistency between IN_FORMATS property and cap + related driver cleanups * drm/amdgpu: Track devices, process info and fence info via /proc/<pid>/fdinfo * drm/ioctl: Mark AGP-related ioctls as legacy * drm/ttm: Provide tt_shrink file to trigger shrinker via debugfs; Cross-subsystem Changes: * fbdev/efifb: Special handling of non-PCI devices * fbdev/imxfb: Fix error message Core Changes: * drm: Add connector helper to attach HDR-metadata property and convert drivers * drm: Add connector helper to compare HDR-metadata and convert drivers * drm: Add conenctor helper to attach colorspace property * drm: Signal colorimetry in HDMI infoframe * drm: Support pitch for destination buffers; Add blitter function with generic format conversion * drm: Remove struct drm_device.pdev and update legacy drivers * drm: Remove obsolete DRM_KMS_FB_HELPER config option in core and drivers * drm: Remove obsolete drm_pci_alloc/drm_pci_free * drm/aperture: Add helpers for aperture ownership and convert drivers, replaces rsp fbdev helpers * drm/agp: Mark DRM AGP code as legacy and convert legacy drivers * drm/atomic-helpers: Cleanups * drm/dp: Handle downstream port counts of 0 correctly; AUX channel fixes; Use drm_err_*/drm_dbg_*(); Cleanups * drm/dp_dual_mode: Use drm_err_*/drm_dbg_*() * drm/dp_mst: Use drm_err_*/drm_dbg_*(); Use Extended Base Receiver Capability DPCD space * drm/gem-ttm-helper: Provide helper for dumb_map_offset and convert drivers * drm/panel: Use sysfs_emit; panel-simple: Use runtime PM, Power up panel when reading EDID, Cache EDID, Cleanups; Lms397KF04: DT bindings * drm/pci: Mark AGP helpers as legacy * drm/print: Handle NULL for DRM devices gracefully * drm/scheduler: Change scheduled fence track * drm/ttm: Don't count SG BOs against pages_limit; Warn about freeing pinned BOs; Fix error handling if no BO can be swapped out; Move special handling of non-GEM drivers into vmwgfx; Move page_alignment into the BO; Set drm-misc as TTM tree in MAINTAINERS; Cleanup ttm_agp_backend; Add ttm_sys_manager for system domain; Cleanups Driver Changes: * drm: Don't set allow_fb_modifiers explictly in drivers * drm/amdgpu: Pin/unpin fixes wrt to TTM; Use bo->base.size instead of mem->num_pages * drm/ast: Use managed pcim_iomap(); Fix EDID retrieval with DP501 * drm/bridge: MHDP8546: HDCP support + DT bindings, Register DP AUX channel with userspace; Sil8620: Fix module dependencies; dw-hdmi: Add option to not load CEC driver; Fix stopping in drm_bridge_chain_pre_enable(); Ti-sn65dsi86: Fix refclk handling, Break GPIO and MIPI-to-eDP into subdrivers, Use pm_runtime autosuspend, cleanups; It66121: Add driver + DT bindings; Adv7511: Support I2S IEC958 encoding; Anx7625: fix power-on delay; Nwi-dsi: Modesetting fixes; Cleanups * drm/bochs: Support screen blanking * drm/gma500: Cleanups * drm/gud: Cleanups * drm/i915: Use correct max source link rate for MST * drm/kmb: Cleanups * drm/meson: Disable dw-hdmi CEC driver * drm/nouveau: Pin/unpin fixes wrt to TTM; Use bo->base.size instead of mem->num_pages; Register AUX adapters after their connectors * drm/qxl: Fix shadow BO unpin * drm/radeon: Duplicate some DRM AGP code to uncouple from legacy drivers * drm/simpledrm: Add a generic DRM driver for simple-framebuffer devices * drm/tiny: Fix log spam if probe function gets deferred * drm/vc4: Add support for HDR-metadata property; Cleanups * drm/virtio: Create dumb BOs as guest blobs; * drm/vkms: Use managed drmm_universal_plane_alloc(); Add XRGB plane composition; Add overlay support * drm/vmwgfx: Enable console with DRM_FBDEV_EMULATION; Fix CPU updates of coherent multisample surfaces; Remove reservation semaphore; Add initial SVGA3 support; Support amd64; Use 1-based IDR; Use min_t(); Cleanups ---------------------------------------------------------------- Adrien Grassein (1): drm/bridge: fix LONTIUM_LT8912B dependencies Alex Deucher (1): MAINTAINERS: Fix TTM tree Andy Shevchenko (7): drm/st7735r: Avoid spamming logs if probe is deferred drm/st7586: Avoid spamming logs if probe is deferred drm/mi0283qt: Avoid spamming logs if probe is deferred drm/ili9486: Avoid spamming logs if probe is deferred drm/ili9341: Avoid spamming logs if probe is deferred drm/ili9225: Avoid spamming logs if probe is deferred drm/hx8357d: Avoid spamming logs if probe is deferred Beatriz Martins de Carvalho (8): drm: drm_atomic.c: Adjust end of block comment drm: drm_auth.c: Adjust end of block comment drm: drm_bufs.c: Adjust end of block comment drm: drm_connector.c: Adjust end of block comment drm: drm_context.c: Adjust end of block comment drm: drm_atomic_uapi.c: Use tabs for code indents drm: drm_blend.c: Use tabs for code indents drm: drm_connector.c: Use tabs for code indents Bernard Zhao (2): drm/gud: cleanup coding style a bit drm/vmwgfx: use min_t to replace min Bhaskar Chowdhury (1): drm/vmwgfx: Fix a typo Christian König (17): drm/ttm: make global mutex and use count static drm/ttm: fix return value check drm/ttm: re-add debugfs tt_shrink file drm/amdgpu: make sure we unpin the UVD BO drm/amdgpu: freeing pinned objects is illegal now drm/ttm: warn stricter about freeing pinned BOs drm/nouveau: use bo->base.size instead of mem->num_pages drm/amdgpu: check base size instead of mem.num_pages drm/ttm: remove special handling for non GEM drivers drm/ttm: minor range manager coding style clean ups drm/ttm: move the page_alignment into the BO v2 drm/ttm: cleanup ttm_agp_backend drm/ttm: add ttm_sys_manager v3 drm/ttm: always initialize the full ttm_resource v2 drm/ttm: properly allocate sys resource during swapout drm/ttm: fix warning in new sys man MAINTAINERS: Add Xinhui Pan as another AMDGPU contact Christophe JAILLET (1): video: fbdev: imxfb: Fix an error message Dan Carpenter (1): drm/vc4: fix argument ordering in vc4_crtc_get_margins() Daniel Vetter (13): drm/tegra: Don't set allow_fb_modifiers explicitly drm/vc4: Don't set allow_fb_modifiers explicitly drm/imx: Don't set allow_fb_modifiers explicitly drm/exynos: Don't set allow_fb_modifiers explicitly drm/todo: Add link to old debugfs RFC drm/arm: Don't set allow_fb_modifiers explicitly drm/arm/malidp: Always list modifiers drm/stm: Don't set allow_fb_modifiers explicitly drm/i915: Don't set allow_fb_modifiers explicitly drm/msm/dpu1: Don't set allow_fb_modifiers explicitly drm/msm/mdp4: Fix modifier support enabling drm/nouveau: Don't set allow_fb_modifiers explicitly drm/modifiers: Enforce consistency between the cap an IN_FORMATS Dave Stevenson (1): drm/vc4: Add HDR metadata property to the VC5 HDMI connectors Deepak R Varma (1): drm/vmwgfx: replace idr_init() by idr_init_base() Douglas Anderson (24): drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable() drm/bridge: ti-sn65dsi86: Simplify refclk handling drm/bridge: ti-sn65dsi86: Remove incorrectly tagged kerneldoc comment drm/bridge: ti-sn65dsi86: Reorder remove() drm/bridge: ti-sn65dsi86: Move drm_panel_unprepare() to post_disable() drm/bridge: ti-sn65dsi86: Get rid of the useless detect() function drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare drm/panel: panel-simple: Add missing pm_runtime_disable() calls drm/bridge: ti-sn65dsi86: Rename the main driver data structure drm/bridge: ti-sn65dsi86: More renames in prep for sub-devices drm/bridge: ti-sn65dsi86: Use devm to do our runtime_disable drm/bridge: ti-sn65dsi86: Clean debugfs code drm/bridge: ti-sn65dsi86: Add local var for "dev" to simplify probe drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata drm/bridge: ti-sn65dsi86: Move all the chip-related init to the start drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers drm/panel: panel-simple: Get rid of hacky HPD chicken-and-egg code drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend drm/bridge: ti-sn65dsi86: Code motion of refclk management functions drm/bridge: ti-sn65dsi86: If refclk, DP AUX can happen w/out pre-enable drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() drm/panel: panel-simple: Power the panel when reading the EDID drm/panel: panel-simple: Cache the EDID as long as we retain power drm/bridge: ti-sn65dsi86: Remove __exit from GPIO sub-driver remove helper Fabio M. De Francesco (5): gpu: drm: Replace bare "unsigned" with "unsigned int" drm: drm_atomic_helper.c: Replace "unsigned" with "unsigned int" drm: drm_atomic_helper.c: Correct comments format drm/drm_bufs.c: In switch, add break in default case drm/drm_file.c: Define drm_send_event_helper() as 'static' Felix Kuehling (1): drm/ttm: Don't count pages in SG BOs against pages_limit Gerd Hoffmann (2): drm/qxl: drop redundant code drm/qxl: balance dumb_shadow_bo pin Hsin-Yi Wang (1): drm/bridge: anx7625: Fix power on delay Jernej Skrabec (1): drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver Joseph Kogut (2): drm: remove usage of drm_pci_alloc/free drm: remove legacy drm_pci_alloc/free abstraction Kai-Heng Feng (1): efifb: Check efifb_pci_dev before using it Krzysztof Kozlowski (2): drm/gma500: correct kerneldoc drm/gma500: remove trailing whitespaces KuoHsiang Chou (1): drm/ast: Fixed CVE for DP501 Lee Jones (3): drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs' drm/scheduler/sched_entity: Fix some function name disparity drm/ttm/ttm_device: Demote kernel-doc abuses Linus Walleij (1): drm/panel: Add DT bindings for Samsung LMS397KF04 Liu Ying (3): drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true drm/bridge: nwl-dsi: Remove a check on unchanged HS clock rate from ->mode_set() drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set() Lyude Paul (20): drm/bridge/cdns-mhdp8546: Register DP aux channel with userspace drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late register/early unregister drm/dp: Add backpointer to drm_device in drm_dp_aux drm/dp: Clarify DP AUX registration time drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay() drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay() drm/dp: Always print aux channel name in logs drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_detect() drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_set_tmds_output() drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_max_tmds_clock() drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_get_tmds_output() drm/dp_dual_mode: Pass drm_device to drm_lspcon_(get|set)_mode() drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw() drm/print: Handle potentially NULL drm_devices in drm_dbg_* drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*() drm/dp_dual_mode: Convert drm_dp_dual_mode_helper.c to using drm_err/drm_dbg_kms() drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*() drm/dp: Handle zeroed port counts in drm_dp_read_downstream_info() drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info() drm/dp: Fix bogus DPCD version check in drm_dp_read_downstream_info() Maxime Ripard (5): Merge drm/drm-next into drm-misc-next drm/connector: Create a helper to attach the hdr_output_metadata property drm/connector: Add helper to compare HDR metadata drm/connector: Add a helper to attach the colorspace property drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe Melissa Wen (4): drm/vkms: init plane using drmm_universal_plane_alloc drm/vkms: rename cursor to plane on ops of planes composition drm/vkms: add XRGB planes composition drm/vkms: add overlay support Neil Armstrong (1): drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver Nikola Cornij (2): drm/dp_mst: Use Extended Base Receiver Capability DPCD space drm/i915: Use the correct max source link rate for MST Parshuram Thombare (2): dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP drm: bridge: cdns-mhdp8546: Enable HDCP Phong LE (3): dt-bindings: display: bridge: add it66121 bindings drm: bridge: add it66121 driver MAINTAINERS: add it66121 HDMI bridge driver entry Randy Dunlap (1): drm: bridge: add missing word in Analogix help text Robert Foss (1): drm/bridge/sii8620: fix dependency on extcon Roy Sun (2): drm/scheduler: Change scheduled fence track v2 drm/amdgpu: Add show_fdinfo() interface Shiwu Zhang (1): drm/ttm: fix error handling if no BO can be swapped out v4 Sia Jee Heng (1): drm: bridge: adv7511: Support I2S IEC958 encoded PCM format Simon Ser (1): drm/connector: demote connector force-probes for non-master clients Takashi Iwai (2): drm/ast: Fix missing conversions to managed API drm/bochs: Add screen blanking support Thomas Hellstrom (2): drm/vmwgfx: Mark a surface gpu-dirty after the SVGA3dCmdDXGenMips command drm/vmwgfx: Fix cpu updates of coherent multisample surfaces Thomas Zimmermann (34): drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset drm/vram-helper: Use drm_gem_ttm_dumb_map_offset() drm/nouveau: Use drm_gem_ttm_dumb_map_offset() drm/qxl: Use drm_gem_ttm_dumb_map_offset() drm/aperture: Add infrastructure for aperture ownership drm/aperture: Convert drivers to aperture interfaces drm/aperture: Inline fbdev conflict helpers into aperture helpers drm/vmwgfx: Make console emulation depend on DRM_FBDEV_EMULATION drm/mxsfb: Don't select DRM_KMS_FB_HELPER drm/zte: Don't select DRM_KMS_FB_HELPER drm: Remove DRM_KMS_FB_HELPER Kconfig option drm/ast: Remove reference to struct drm_device.pdev drm/i915/gt: Remove reference to struct drm_device.pdev drm/i915: Remove reference to struct drm_device.pdev drm/i915: Don't assign to struct drm_device.pdev drm: Move struct drm_device.pdev to legacy section drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip() drm/format-helper: Add blitter functions drm/aperture: Add infrastructure for aperture ownership drm: Add simpledrm driver drm/simpledrm: Acquire memory aperture for framebuffer drm/i810: Remove references to struct drm_device.pdev drm/mga: Remove references to struct drm_device.pdev drm/r128: Remove references to struct drm_device.pdev drm/savage: Remove references to struct drm_device.pdev drm/sis: Remove references to struct drm_device.pdev drm/via: Remove references to drm_device.pdev drm: Remove pdev field from struct drm_device drm/radeon: Move AGP helpers into radeon driver drm/radeon: Move AGP data structures into radeon drm: Mark PCI AGP helpers as legacy drm: Mark AGP implementation and ioctls as legacy drm: Include <asm/agp.h> iff CONFIG_AGP is set Merge drm/drm-next into drm-misc-next Ville Syrjälä (1): drm: Use drm_mode_is_420_only() instead of open coding it Vivek Kasireddy (1): drm/virtio: Create Dumb BOs as guest Blobs (v3) Wan Jiabing (1): drm/gma500: update comment of psb_spank() Zack Rusin (4): drm/vmwgfx: Fix incorrect enum usage drm/vmwgfx: Remove the reservation semaphore drm/vmwgfx: Add basic support for SVGA3 drm/vmwgfx: Port vmwgfx to arm64 Zhen Lei (1): drm/vc4: Remove redundant error printing in vc4_ioremap_regs() Zheng Yongjun (1): gpu: drm: vmwgfx: convert comma to semicolon Zou Wei (1): drm/vmwgfx/vmwgfx_validation: Use flexible-array member instead of zero-length array kernel test robot (1): drm: fix semicolon.cocci warnings .../bindings/display/bridge/cdns,mhdp8546.yaml | 15 +- .../bindings/display/bridge/ite,it66121.yaml | 124 +++ .../bindings/display/panel/samsung,lms397kf04.yaml | 74 ++ Documentation/gpu/drm-internals.rst | 12 + Documentation/gpu/todo.rst | 2 + MAINTAINERS | 18 +- drivers/gpu/drm/Kconfig | 28 +- drivers/gpu/drm/Makefile | 8 +- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 61 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 104 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 43 + drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 63 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 45 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 5 +- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 6 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 27 +- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 + drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 18 + drivers/gpu/drm/amd/display/dc/dc_link.h | 2 + drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 1 - drivers/gpu/drm/arm/malidp_drv.c | 1 - drivers/gpu/drm/arm/malidp_planes.c | 9 +- drivers/gpu/drm/armada/armada_drv.c | 5 +- drivers/gpu/drm/ast/ast_dp501.c | 139 ++- drivers/gpu/drm/ast/ast_drv.c | 23 +- drivers/gpu/drm/ast/ast_drv.h | 12 + drivers/gpu/drm/ast/ast_main.c | 14 +- drivers/gpu/drm/bochs/bochs.h | 1 + drivers/gpu/drm/bochs/bochs_drv.c | 3 +- drivers/gpu/drm/bochs/bochs_hw.c | 25 +- drivers/gpu/drm/bochs/bochs_kms.c | 8 + drivers/gpu/drm/bridge/Kconfig | 12 +- drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 + drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 + drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 1 + drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- drivers/gpu/drm/bridge/cadence/Makefile | 2 +- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 140 ++- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.h | 22 + .../gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 570 +++++++++++ .../gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h | 92 ++ drivers/gpu/drm/bridge/ite-it66121.c | 1021 ++++++++++++++++++++ drivers/gpu/drm/bridge/nwl-dsi.c | 86 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 +- drivers/gpu/drm/bridge/tc358767.c | 1 + drivers/gpu/drm/bridge/ti-sn65dsi86.c | 719 +++++++++----- drivers/gpu/drm/drm_agpsupport.c | 101 +- drivers/gpu/drm/drm_aperture.c | 344 +++++++ drivers/gpu/drm/drm_atomic.c | 7 +- drivers/gpu/drm/drm_atomic_helper.c | 40 +- drivers/gpu/drm/drm_atomic_uapi.c | 6 +- drivers/gpu/drm/drm_auth.c | 3 +- drivers/gpu/drm/drm_blend.c | 4 +- drivers/gpu/drm/drm_bridge.c | 3 + drivers/gpu/drm/drm_bufs.c | 25 +- drivers/gpu/drm/drm_connector.c | 127 ++- drivers/gpu/drm/drm_context.c | 3 +- drivers/gpu/drm/drm_dma.c | 8 +- drivers/gpu/drm/drm_dp_aux_dev.c | 6 + drivers/gpu/drm/drm_dp_dual_mode_helper.c | 68 +- drivers/gpu/drm/drm_dp_helper.c | 195 ++-- drivers/gpu/drm/drm_dp_mst_topology.c | 405 ++++---- drivers/gpu/drm/drm_drv.c | 4 +- drivers/gpu/drm/drm_file.c | 14 +- drivers/gpu/drm/drm_format_helper.c | 96 +- drivers/gpu/drm/drm_gem_ttm_helper.c | 33 + drivers/gpu/drm/drm_gem_vram_helper.c | 48 - drivers/gpu/drm/drm_internal.h | 5 - drivers/gpu/drm/drm_ioc32.c | 19 +- drivers/gpu/drm/drm_ioctl.c | 24 +- drivers/gpu/drm/drm_legacy.h | 30 + drivers/gpu/drm/drm_legacy_misc.c | 1 - drivers/gpu/drm/drm_memory.c | 1 - drivers/gpu/drm/drm_modes.c | 13 +- drivers/gpu/drm/drm_pci.c | 82 +- drivers/gpu/drm/drm_plane.c | 18 +- drivers/gpu/drm/drm_vm.c | 2 - drivers/gpu/drm/exynos/exynos_drm_fb.c | 2 - drivers/gpu/drm/gma500/backlight.c | 4 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 50 +- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/intel_gmbus.c | 2 +- drivers/gpu/drm/gma500/psb_drv.h | 2 +- drivers/gpu/drm/gud/gud_internal.h | 4 +- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +- drivers/gpu/drm/i810/i810_dma.c | 11 +- drivers/gpu/drm/i915/display/intel_atomic.c | 13 +- drivers/gpu/drm/i915/display/intel_connector.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 2 - drivers/gpu/drm/i915/display/intel_dp_aux.c | 1 + .../gpu/drm/i915/display/intel_dp_link_training.c | 6 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 - drivers/gpu/drm/imx/imx-drm-core.c | 1 - drivers/gpu/drm/kmb/kmb_dsi.c | 10 +- drivers/gpu/drm/meson/meson_drv.c | 27 +- drivers/gpu/drm/meson/meson_dw_hdmi.c | 1 + drivers/gpu/drm/mga/mga_dma.c | 29 +- drivers/gpu/drm/mga/mga_drv.h | 1 - drivers/gpu/drm/mga/mga_state.c | 3 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 5 +- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 - drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 - drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 8 +- drivers/gpu/drm/msm/dp/dp_ctrl.c | 6 +- drivers/gpu/drm/msm/edp/edp.h | 3 +- drivers/gpu/drm/msm/edp/edp_aux.c | 5 +- drivers/gpu/drm/msm/edp/edp_ctrl.c | 8 +- drivers/gpu/drm/msm/msm_fbdev.c | 5 +- drivers/gpu/drm/mxsfb/Kconfig | 1 - drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +- drivers/gpu/drm/nouveau/nouveau_bo.c | 9 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 26 +- drivers/gpu/drm/nouveau/nouveau_display.c | 19 - drivers/gpu/drm/nouveau/nouveau_display.h | 2 - drivers/gpu/drm/nouveau/nouveau_drm.c | 6 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +- drivers/gpu/drm/panel/Kconfig | 1 + drivers/gpu/drm/panel/panel-simple.c | 140 ++- drivers/gpu/drm/qxl/qxl_display.c | 5 +- drivers/gpu/drm/qxl/qxl_drv.c | 8 +- drivers/gpu/drm/qxl/qxl_drv.h | 3 - drivers/gpu/drm/qxl/qxl_dumb.c | 17 - drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +- drivers/gpu/drm/qxl/qxl_object.h | 5 - drivers/gpu/drm/r128/ati_pcigart.c | 33 +- drivers/gpu/drm/r128/r128_cce.c | 2 +- drivers/gpu/drm/r128/r128_drv.c | 4 +- drivers/gpu/drm/r128/r128_state.c | 3 +- drivers/gpu/drm/radeon/atombios_dp.c | 5 +- drivers/gpu/drm/radeon/radeon.h | 42 + drivers/gpu/drm/radeon/radeon_agp.c | 118 ++- drivers/gpu/drm/radeon/radeon_dp_mst.c | 7 + drivers/gpu/drm/radeon/radeon_drv.c | 16 +- drivers/gpu/drm/radeon/radeon_kms.c | 18 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c | 6 +- drivers/gpu/drm/savage/savage_bci.c | 26 +- drivers/gpu/drm/scheduler/sched_entity.c | 6 +- drivers/gpu/drm/scheduler/sched_main.c | 9 +- drivers/gpu/drm/sis/sis_drv.c | 3 +- drivers/gpu/drm/stm/ltdc.c | 2 - drivers/gpu/drm/sun4i/sun4i_drv.c | 5 +- drivers/gpu/drm/tegra/dc.c | 10 +- drivers/gpu/drm/tegra/dpaux.c | 1 + drivers/gpu/drm/tegra/drm.c | 6 +- drivers/gpu/drm/tiny/Kconfig | 16 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/cirrus.c | 5 +- drivers/gpu/drm/tiny/hx8357d.c | 6 +- drivers/gpu/drm/tiny/ili9225.c | 12 +- drivers/gpu/drm/tiny/ili9341.c | 12 +- drivers/gpu/drm/tiny/ili9486.c | 12 +- drivers/gpu/drm/tiny/mi0283qt.c | 12 +- drivers/gpu/drm/tiny/simpledrm.c | 896 +++++++++++++++++ drivers/gpu/drm/tiny/st7586.c | 12 +- drivers/gpu/drm/tiny/st7735r.c | 12 +- drivers/gpu/drm/ttm/Makefile | 2 +- drivers/gpu/drm/ttm/ttm_agp_backend.c | 8 +- drivers/gpu/drm/ttm/ttm_bo.c | 58 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 4 +- drivers/gpu/drm/ttm/ttm_device.c | 25 +- drivers/gpu/drm/ttm/ttm_module.h | 3 + drivers/gpu/drm/ttm/ttm_range_manager.c | 40 +- drivers/gpu/drm/ttm/ttm_resource.c | 20 +- drivers/gpu/drm/ttm/ttm_sys_manager.c | 41 + drivers/gpu/drm/ttm/ttm_tt.c | 20 + drivers/gpu/drm/vboxvideo/vbox_drv.c | 3 +- drivers/gpu/drm/vc4/vc4_drv.c | 9 +- drivers/gpu/drm/vc4/vc4_drv.h | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 61 +- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 + drivers/gpu/drm/vc4/vc4_kms.c | 1 - drivers/gpu/drm/via/via_dma.c | 1 - drivers/gpu/drm/via/via_dmablit.c | 15 +- drivers/gpu/drm/via/via_map.c | 3 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 10 +- drivers/gpu/drm/virtio/virtgpu_gem.c | 8 + drivers/gpu/drm/virtio/virtgpu_object.c | 3 + drivers/gpu/drm/vkms/vkms_composer.c | 104 +- drivers/gpu/drm/vkms/vkms_drv.c | 5 + drivers/gpu/drm/vkms/vkms_drv.h | 9 +- drivers/gpu/drm/vkms/vkms_output.c | 28 +- drivers/gpu/drm/vkms/vkms_plane.c | 51 +- drivers/gpu/drm/vmwgfx/Kconfig | 10 +- drivers/gpu/drm/vmwgfx/Makefile | 6 +- .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 8 +- drivers/gpu/drm/vmwgfx/device_include/svga_reg.h | 55 +- drivers/gpu/drm/vmwgfx/ttm_lock.c | 194 ---- drivers/gpu/drm/vmwgfx/ttm_lock.h | 218 ----- drivers/gpu/drm/vmwgfx/ttm_object.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 43 +- drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c | 118 ++- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 13 +- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 169 +++- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 147 ++- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 41 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 8 - drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 18 +- drivers/gpu/drm/vmwgfx/vmwgfx_fence.h | 2 - drivers/gpu/drm/vmwgfx/vmwgfx_gmr.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 60 +- drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 77 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 36 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 36 +- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 31 +- drivers/gpu/drm/vmwgfx/vmwgfx_msg.h | 214 ---- drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h | 130 +++ drivers/gpu/drm/vmwgfx/vmwgfx_msg_x86.h | 219 +++++ drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_reg.h | 4 - drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 6 - drivers/gpu/drm/vmwgfx/vmwgfx_simple_resource.c | 5 - drivers/gpu/drm/vmwgfx/vmwgfx_so.c | 4 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 40 +- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 15 +- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 +- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 4 +- drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 +- drivers/gpu/drm/zte/Kconfig | 1 - drivers/video/fbdev/Kconfig | 2 +- drivers/video/fbdev/imxfb.c | 2 +- include/drm/bridge/dw_hdmi.h | 2 + include/drm/drm_agpsupport.h | 117 --- include/drm/drm_aperture.h | 35 + include/drm/drm_connector.h | 4 + include/drm/drm_device.h | 9 +- include/drm/drm_dp_dual_mode_helper.h | 14 +- include/drm/drm_dp_helper.h | 19 +- include/drm/drm_dp_mst_helper.h | 15 +- include/drm/drm_fb_helper.h | 51 - include/drm/drm_format_helper.h | 10 +- include/drm/drm_gem_ttm_helper.h | 5 +- include/drm/drm_gem_vram_helper.h | 7 +- include/drm/drm_legacy.h | 86 +- include/drm/drm_mode_config.h | 2 + include/drm/drm_print.h | 20 +- include/drm/ttm/ttm_bo_api.h | 21 +- include/drm/ttm/ttm_resource.h | 2 - include/uapi/drm/drm_mode.h | 7 +- 269 files changed, 7169 insertions(+), 3006 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.h create mode 100644 drivers/gpu/drm/bridge/ite-it66121.c create mode 100644 drivers/gpu/drm/drm_aperture.c create mode 100644 drivers/gpu/drm/tiny/simpledrm.c create mode 100644 drivers/gpu/drm/ttm/ttm_sys_manager.c delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.c delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.h delete mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_msg.h create mode 100755 drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_msg_x86.h delete mode 100644 include/drm/drm_agpsupport.h create mode 100644 include/drm/drm_aperture.h -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer

1 0

[PATCH v6 00/16] RFC Support hot device unplug in amdgpu
by Andrey Grodzovsky 12 May '21

12 May '21

Until now extracting a card either by physical extraction (e.g. eGPU with thunderbolt connection or by emulation through sysfs -> /sys/bus/pci/devices/device_id/remove) would cause random crashes in user apps. The random crashes in apps were mostly due to the app having mapped a device backed BO into its address space and was still trying to access the BO while the backing device was gone. To answer this first problem Christian suggested fixing the handling of mapped memory in the clients when the device goes away by forcibly unmapping all buffers the user processes have by clearing their respective VMAs mapping the device BOs. Then when the VMAs try to fill in the page tables again we check in the fault handler if the device is removed and if so, return an error. This will generate a SIGBUS to the application which can then cleanly terminate. This indeed was done but this in turn created a problem of kernel OOPs where the OOPSes were due to the fact that while the app was terminating because of the SIGBUS it would trigger use after free in the driver by calling to access device structures that were already released from the pci remove sequence. This was handled by introducing a 'flush' sequence during device removal where we wait for drm file reference to drop to 0 meaning all user clients directly using this device terminated. v2: Based on discussions in the mailing list with Daniel and Pekka [1] and based on the document produced by Pekka from those discussions [2] the whole approach with returning SIGBUS and waiting for all user clients having CPU mapping of device BOs to die was dropped. Instead as per the document suggestion the device structures are kept alive until the last reference to the device is dropped by user client and in the meanwhile all existing and new CPU mappings of the BOs belonging to the device directly or by dma-buf import are rerouted to per user process dummy rw page.Also, I skipped the 'Requirements for KMS UAPI' section of [2] since i am trying to get the minimal set of requirements that still give useful solution to work and this is the'Requirements for Render and Cross-Device UAPI' section and so my test case is removing a secondary device, which is render only and is not involved in KMS. v3: More updates following comments from v2 such as removing loop to find DRM file when rerouting page faults to dummy page,getting rid of unnecessary sysfs handling refactoring and moving prevention of GPU recovery post device unplug from amdgpu to scheduler layer. On top of that added unplug support for the IOMMU enabled system. v4: Drop last sysfs hack and use sysfs default attribute. Guard against write accesses after device removal to avoid modifying released memory. Update dummy pages handling to on demand allocation and release through drm managed framework. Add return value to scheduler job TO handler (by Luben Tuikov) and use this in amdgpu for prevention of GPU recovery post device unplug Also rebase on top of drm-misc-mext instead of amd-staging-drm-next v5: The most significant in this series is the improved protection from kernel driver accessing MMIO ranges that were allocated for the device once the device is gone. To do this, first a patch 'drm/amdgpu: Unmap all MMIO mappings' is introduced. This patch unamps all MMIO mapped into the kernel address space in the form of BARs and kernel BOs with CPU visible VRAM mappings. This way it helped to discover multiple such access points because a page fault would be immediately generated on access. Most of them were solved by moving HW fini code into pci_remove stage (patch drm/amdgpu: Add early fini callback) and for some who were harder to unwind drm_dev_enter/exit scoping was used. In addition all the IOCTLs and all background work and timers are now protected with drm_dev_enter/exit at their root in an attempt that after drm_dev_unplug is finished none of them run anymore and the pci_remove thread is the only thread executing which might touch the HW. To prevent deadlocks in such case against threads stuck on various HW or SW fences patches 'drm/amdgpu: Finalise device fences on device remove' and drm/amdgpu: Add rw_sem to pushing job into sched queue' take care of force signaling all such existing fences and rejecting any newly added ones. v6: Drop using drm_dev_enter/exit in conjunction with signalling HW fences before setting drm_dev_unplug. We need to devise a more robust cros DRM approach to the problem of dma fence waits falling inside drm_dev_enter/exit scopes -> move to TODO. With these patches I am able to gracefully remove the secondary card using sysfs remove hook while glxgears is running off of secondary card (DRI_PRIME=1) without kernel oopses or hangs and keep working with the primary card or soft reset the device without hangs or oopses. Also as per Daniel's comment I added 3 tests to IGT [4] to core_hotunplug test suite - remove device while commands are submitted, exported BO and exported fence (not pushed yet). Also now it's possible to plug back the device after unplug Also some users now can successfully use those patches with eGPU boxes[3]. TODOs for followup work: Convert AMDGPU code to use devm (for hw stuff) and drmm (for sw stuff and allocations) (Daniel) Add support for 'Requirements for KMS UAPI' section of [2] - unplugging primary, display connected card. Annotate drm_dev_enter/exit against dma_fence_waits as first in deciding where to use drm_dev_enter/exit in code for device unplug. [1] - Discussions during v5 of the patchset https://lore.kernel.org/amd-gfx/20210428151207.1212258-1-andrey.grodzovsky@… [2] - drm/doc: device hot-unplug for userspace https://www.spinics.net/lists/dri-devel/msg259755.html [3] - Related gitlab ticket https://gitlab.freedesktop.org/drm/amd/-/issues/1081 [4] - Related IGT tests https://gitlab.freedesktop.org/agrodzov/igt-gpu-tools/-/commits/master Andrey Grodzovsky (16): drm/ttm: Remap all page faults to per process dummy page. drm/ttm: Expose ttm_tt_unpopulate for driver use drm/amdgpu: Split amdgpu_device_fini into early and late drm/amdkfd: Split kfd suspend from devie exit drm/amdgpu: Add early fini callback drm/amdgpu: Handle IOMMU enabled case. drm/amdgpu: Remap all page faults to per process dummy page. PCI: Add support for dev_groups to struct pci_device_driver drm/amdgpu: Convert driver sysfs attributes to static attributes drm/amdgpu: Guard against write accesses after device removal drm/sched: Make timeout timer rearm conditional. drm/amdgpu: Prevent any job recoveries after device is unplugged. drm/amdgpu: Fix hang on device removal. drm/scheduler: Fix hang when sched_entity released drm/amd/display: Remove superflous drm_mode_config_cleanup drm/amdgpu: Verify DMA opearations from device are done drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 17 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 98 +++++++++++++------ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 26 ++++- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 31 ++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 9 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 25 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 17 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 35 +++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 19 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 12 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 63 +++++++----- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 70 +++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 52 ++-------- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 31 ++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 11 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 22 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 14 +-- drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +- drivers/gpu/drm/amd/amdgpu/cz_ih.c | 3 +- drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 3 +- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 5 +- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 44 ++++----- drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 8 +- drivers/gpu/drm/amd/amdgpu/si_ih.c | 3 +- drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 26 +++-- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 22 +++-- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 5 +- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 ++- drivers/gpu/drm/amd/include/amd_shared.h | 2 + .../drm/amd/pm/powerplay/smumgr/smu7_smumgr.c | 2 + drivers/gpu/drm/scheduler/sched_entity.c | 3 +- drivers/gpu/drm/scheduler/sched_main.c | 35 ++++++- drivers/gpu/drm/ttm/ttm_bo_vm.c | 57 ++++++++++- drivers/gpu/drm/ttm/ttm_tt.c | 1 + drivers/pci/pci-driver.c | 1 + include/drm/ttm/ttm_bo_api.h | 2 + include/linux/pci.h | 3 + 51 files changed, 585 insertions(+), 272 deletions(-) -- 2.25.1

8 41

[PATCH 0/2] drm: panel-orientation-quirks: Update / Add 2 quirks
by Hans de Goede 12 May '21

12 May '21

Hi All, The first patch in this series is a resend of one which I submitted a couple of days ago, the other patch is new. These are pretty simple/straightforward patches if someone can give me a quick ack for these then I can push them to drm-misc-next. Regards, Hans Hans de Goede (2): drm: panel-orientation-quirks: Update the Lenovo Ideapad D330 quirk (v2) drm: panel-orientation-quirks: Add quirk for KD Kurio Smart C15200 2-in-1 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- 2.31.1

1 2

Re: dri-devel Digest, Vol 134, Issue 309
by chatzem 12 May '21

12 May '21

Sent from ProtonMail mobile -------- Original Message -------- On May 12, 2021, 08:57, wrote: > Send dri-devel mailing list submissions to > dri-devel(a)lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freedesktop.org/mailman/listinfo/dri-devel > or, via email, send a message with subject or body 'help' to > dri-devel-request(a)lists.freedesktop.org > > You can reach the person managing the list at > dri-devel-owner(a)lists.freedesktop.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of dri-devel digest..." > > Today's Topics: > > 1. Re: [RFC PATCH 00/97] Basic GuC submission support in the > i915 (Martin Peres) > 2. [PATCH -next] drm/bridge: lt9611: Add missing > MODULE_DEVICE_TABLE (Zou Wei) > 3. Re: [Nouveau] [PATCH v2 2/2] drm/nouveau: Fix error return > code in nouveau_backlight_init() (Pierre Moreau) > 4. Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak > (Pierre Moreau) > 5. Re: [PATCH 1/3] virtio-gpu uapi: Add > VIRTIO_GPU_F_EXPLICIT_FLUSH feature (Gerd Hoffmann) > 6. Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak > (Leizhen (ThunderTown)) > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 12 May 2021 09:26:14 +0300 > From: Martin Peres <martin.peres(a)free.fr> > To: Matthew Brost <matthew.brost(a)intel.com>, "Bloomfield, Jon" > <jon.bloomfield(a)intel.com> > Cc: Daniel Vetter <daniel(a)ffwll.ch>, Jason Ekstrand > <jason(a)jlekstrand.net>, intel-gfx <intel-gfx(a)lists.freedesktop.org>, > dri-devel <dri-devel(a)lists.freedesktop.org>, "Ursulin, Tvrtko" > <tvrtko.ursulin(a)intel.com>, "Ekstrand, Jason" > <jason.ekstrand(a)intel.com>, "Ceraolo Spurio, Daniele" > <daniele.ceraolospurio(a)intel.com>, "Vetter, Daniel" > <daniel.vetter(a)intel.com>, "Harrison, John C" > <john.c.harrison(a)intel.com> > Subject: Re: [RFC PATCH 00/97] Basic GuC submission support in the > i915 > Message-ID: <bb701cab-a68e-08ed-80e3-61be160bdc02(a)free.fr> > Content-Type: text/plain; charset=utf-8; format=flowed > > On 11/05/2021 19:39, Matthew Brost wrote: >> On Tue, May 11, 2021 at 08:26:59AM -0700, Bloomfield, Jon wrote: >>>> -----Original Message----- >>>> From: Martin Peres <martin.peres(a)free.fr> >>>> Sent: Tuesday, May 11, 2021 1:06 AM >>>> To: Daniel Vetter <daniel(a)ffwll.ch> >>>> Cc: Jason Ekstrand <jason(a)jlekstrand.net>; Brost, Matthew >>>> <matthew.brost(a)intel.com>; intel-gfx <intel-gfx(a)lists.freedesktop.org>; >>>> dri-devel <dri-devel(a)lists.freedesktop.org>; Ursulin, Tvrtko >>>> <tvrtko.ursulin(a)intel.com>; Ekstrand, Jason <jason.ekstrand(a)intel.com>; >>>> Ceraolo Spurio, Daniele <daniele.ceraolospurio(a)intel.com>; Bloomfield, Jon >>>> <jon.bloomfield(a)intel.com>; Vetter, Daniel <daniel.vetter(a)intel.com>; >>>> Harrison, John C <john.c.harrison(a)intel.com> >>>> Subject: Re: [RFC PATCH 00/97] Basic GuC submission support in the i915 >>>> >>>> On 10/05/2021 19:33, Daniel Vetter wrote: >>>>> On Mon, May 10, 2021 at 3:55 PM Martin Peres <martin.peres(a)free.fr> >>>> wrote: >>>>>> >>>>>> On 10/05/2021 02:11, Jason Ekstrand wrote: >>>>>>> On May 9, 2021 12:12:36 Martin Peres <martin.peres(a)free.fr> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> On 06/05/2021 22:13, Matthew Brost wrote: >>>>>>>>> Basic GuC submission support. This is the first bullet point in the >>>>>>>>> upstreaming plan covered in the following RFC [1]. >>>>>>>>> >>>>>>>>> At a very high level the GuC is a piece of firmware which sits between >>>>>>>>> the i915 and the GPU. It offloads some of the scheduling of contexts >>>>>>>>> from the i915 and programs the GPU to submit contexts. The i915 >>>>>>>>> communicates with the GuC and the GuC communicates with the >>>> GPU. >>>>>>>> >>>>>>>> May I ask what will GuC command submission do that execlist >>>> won't/can't >>>>>>>> do? And what would be the impact on users? Even forgetting the >>>> troubled >>>>>>>> history of GuC (instability, performance regression, poor level of user >>>>>>>> support, 6+ years of trying to upstream it...), adding this much code >>>>>>>> and doubling the amount of validation needed should come with a >>>>>>>> rationale making it feel worth it... and I am not seeing here. Would you >>>>>>>> mind providing the rationale behind this work? >>>>>>>> >>>>>>>>> >>>>>>>>> GuC submission will be disabled by default on all current upstream >>>>>>>>> platforms behind a module parameter - enable_guc. A value of 3 will >>>>>>>>> enable submission and HuC loading via the GuC. GuC submission >>>> should >>>>>>>>> work on all gen11+ platforms assuming the GuC firmware is present. >>>>>>>> >>>>>>>> What is the plan here when it comes to keeping support for execlist? I >>>>>>>> am afraid that landing GuC support in Linux is the first step towards >>>>>>>> killing the execlist, which would force users to use proprietary >>>>>>>> firmwares that even most Intel engineers have little influence over. >>>>>>>> Indeed, if "drm/i915/guc: Disable semaphores when using GuC >>>> scheduling" >>>>>>>> which states "Disable semaphores when using GuC scheduling as >>>> semaphores >>>>>>>> are broken in the current GuC firmware." is anything to go by, it means >>>>>>>> that even Intel developers seem to prefer working around the GuC >>>>>>>> firmware, rather than fixing it. >>>>>>> >>>>>>> Yes, landing GuC support may be the first step in removing execlist >>>>>>> support. The inevitable reality is that GPU scheduling is coming and >>>>>>> likely to be there only path in the not-too-distant future. (See also >>>>>>> the ongoing thread with AMD about fences.) I'm not going to pass >>>>>>> judgement on whether or not this is a good thing. I'm just reading the >>>>>>> winds and, in my view, this is where things are headed for good or ill. >>>>>>> >>>>>>> In answer to the question above, the answer to "what do we gain from >>>>>>> GuC?" may soon be, "you get to use your GPU." We're not there yet >>>> and, >>>>>>> again, I'm not necessarily advocating for it, but that is likely where >>>>>>> things are headed. >>>>>> >>>>>> This will be a sad day, especially since it seems fundamentally opposed >>>>>> with any long-term support, on top of taking away user freedom to >>>>>> fix/tweak their system when Intel won't. >>>>>> >>>>>>> A firmware-based submission model isn't a bad design IMO and, aside >>>> from >>>>>>> the firmware freedom issues, I think there are actual advantages to the >>>>>>> model. Immediately, it'll unlock a few features like parallel submission >>>>>>> (more on that in a bit) and long-running compute because they're >>>>>>> implemented in GuC and the work to implement them properly in the >>>>>>> execlist scheduler is highly non-trivial. Longer term, it may (no >>>>>>> guarantees) unlock some performance by getting the kernel out of the >>>> way. >>>>>> >>>>>> Oh, I definitely agree with firmware-based submission model not being a >>>>>> bad design. I was even cheering for it in 2015. Experience with it made >>>>>> me regret that deeply since :s >>>>>> >>>>>> But with the DRM scheduler being responsible for most things, I fail to >>>>>> see what we could offload in the GuC except context switching (like >>>>>> every other manufacturer). The problem is, the GuC does way more than >>>>>> just switching registers in bulk, and if the number of revisions of the >>>>>> GuC is anything to go by, it is way too complex for me to feel >>>>>> comfortable with it. >>>>> >>>>> We need to flesh out that part of the plan more, but we're not going >>>>> to use drm scheduler for everything. It's only to handle the dma-fence >>>>> legacy side of things, which means: >>>>> - timeout handling for batches that take too long >>>>> - dma_fence dependency sorting/handling >>>>> - boosting of context from display flips (currently missing, needs to >>>>> be ported from drm/i915) >>>>> >>>>> The actual round-robin/preempt/priority handling is still left to the >>>>> backend, in this case here the fw. So there's large chunks of >>>>> code/functionality where drm/scheduler wont be involved in, and like >>>>> Jason says: The hw direction winds definitely blow in the direction >>>>> that this is all handled in hw. >>>> >>>> The plan makes sense for a SRIOV-enable GPU, yes. >>>> >>>> However, if the GuC is actually helping i915, then why not open source >>>> it and drop all the issues related to its stability? Wouldn't it be the >>>> perfect solution, as it would allow dropping execlist support for newer >>>> HW, and it would eliminate the concerns about maintenance of stable >>>> releases of Linux? >>> >>> That the major version of the FW is high is not due to bugs - Bugs don't trigger major version bumps anyway. > > Of course, where did I say they would? > >> Only interface changes increment the major version, and we do add features, to keep it relevant to the evolving hardware and OS landscape. When only Windows used GuC there was no reason not to minimize interface creep - GuC and KMD are released as an atomic bundle on Windows. With Linux, this is no longer the case, and has not been for some time. > > AFAIK, Intel has been shipping GuC to customers since gen9, and upstream > has been supporting command submission (albeit in a broken form) for > years... until Michal finally disabled it after I asked for it to a bit > over 2 years ago[1], when GuC was at major version 32. > > So... not sure I would trust your word so blindly here. > > [1] > https://patchwork.freedesktop.org/patch/297997/?series=58760&rev=2#comment_… >>> >> >> Jon hit the nail on head here - there hasn't been any reason not to bump the GuC >> version / change the interface until there is code upstream using the GuC. Once >> we push something that totally changes. Once SRIOV lands we literally can't the >> interface without breaking the world. Our goal is to this right before >> somethings lands, hence the high version number. > > Good to hear! But Intel will continue to change the interface as new > generations are made, so what is the support model for older GPUs / > kernels which will be stuck on older major revisions? > >> >> Matt >> >>> We have been using GuC as the sole mechanism for submission on Windows since Gen8, and it has proven very reliable. This is in large part because it is simple, and designed from day 1 as a cohesive solution alongside the hardware. > > Exactly, the GuC was designed with Windows' GPU model... which is not > directly applicable to Linux. Also, Windows does not care as much about > submission latency, whereas most Linux users still depend on glamor for > 2D acceleration which is pretty much the biggest stress test for command > submission latency. Also, features not used by the Windows driver or > used in a different way are/will get broken (see the semaphore patch > that works around it). > >>> >>> Will there be bugs in the future? Of course. It's a new i915 backend. There are bugs in the execlist backend too, and the runlist backend, and the majority of real-world software ever written. But the i915 GuC backend is way simpler than execlist, much easier to understand, and therefore much easier to maintain. It's a net win for i915 and Linux. > > I am more than willing to accept the fact that the interface would be > easier to work with, and I welcome anything that will simplify the > driver... but not at the expense of regressing the user experience. One > has to prove more than *just* code maintainability. > > Feel free to iterate/land the code, but enabling guc-based command > submission is waaaaayyyy too early, no matter how much you want it. This > patch will remain a NACK from me until I see more of the plan to support > *users* who are willing to use a proprietary firmware, performance > analysis, what's the plan for users who will not want to use it, and > what are the capabilities of GuC which could be used for privilege > escalation and what is done to mitigate that. > > Thanks, > Martin > >>> >>> Jon > > ------------------------------ > > Message: 2 > Date: Wed, 12 May 2021 14:45:55 +0800 > From: Zou Wei <zou_wei(a)huawei.com> > To: <a.hajda(a)samsung.com>, <narmstrong(a)baylibre.com>, > <robert.foss(a)linaro.org>, <Laurent.pinchart(a)ideasonboard.com>, > <jonas(a)kwiboo.se>, <jernej.skrabec(a)siol.net>, <airlied(a)linux.ie>, > <daniel(a)ffwll.ch> > Cc: <dri-devel(a)lists.freedesktop.org>, <linux-kernel(a)vger.kernel.org>, > Zou Wei <zou_wei(a)huawei.com> > Subject: [PATCH -next] drm/bridge: lt9611: Add missing > MODULE_DEVICE_TABLE > Message-ID: <1620801955-19188-1-git-send-email-zou_wei(a)huawei.com> > Content-Type: text/plain > > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot <hulkci(a)huawei.com> > Signed-off-by: Zou Wei <zou_wei(a)huawei.com> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index e8eb8de..29b1ce2 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -1215,6 +1215,7 @@ static struct i2c_device_id lt9611_id[] = { > { "lontium,lt9611", 0 }, > {} > }; > +MODULE_DEVICE_TABLE(i2c, lt9611_id); > > static const struct of_device_id lt9611_match_table[] = { > { .compatible = "lontium,lt9611" }, > -- > 2.6.2 > > ------------------------------ > > Message: 3 > Date: Wed, 12 May 2021 08:34:18 +0200 > From: Pierre Moreau <pierre.morrow(a)free.fr> > To: Zhen Lei <thunder.leizhen(a)huawei.com> > Cc: Ben Skeggs <bskeggs(a)redhat.com>, David Airlie <airlied(a)linux.ie>, > Daniel Vetter <daniel(a)ffwll.ch>, dri-devel > <dri-devel(a)lists.freedesktop.org>, nouveau > <nouveau(a)lists.freedesktop.org> > Subject: Re: [Nouveau] [PATCH v2 2/2] drm/nouveau: Fix error return > code in nouveau_backlight_init() > Message-ID: <20210512063418.mgec2b5x73n6iwr6(a)Normandy.localdomain> > Content-Type: text/plain; charset=utf-8 > > Reviewed-by: Pierre Moreau <pierre.morrow(a)free.fr> > > On 2021-05-11 ? 16:28, Zhen Lei wrote: >> Fix to return a negative error code from the error handling case instead >> of 0, as done elsewhere in this function. >> >> Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") >> Suggested-by: Pierre Moreau <pierre.morrow(a)free.fr> >> Signed-off-by: Zhen Lei <thunder.leizhen(a)huawei.com> >> --- >> drivers/gpu/drm/nouveau/nouveau_backlight.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c >> index d1c998e645fb4b6..f0856adbe775624 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c >> @@ -47,20 +47,20 @@ struct nouveau_backlight { >> int id; >> }; >> >> -static bool >> +static int >> nouveau_get_backlight_name(char backlight_name[BL_NAME_SIZE], >> struct nouveau_backlight *bl) >> { >> int nb = ida_simple_get(&bl_ida, 0, 100, GFP_KERNEL); >> >> if (nb < 0) >> - return false; >> + return nb; >> if (nb > 0) >> snprintf(backlight_name, BL_NAME_SIZE, "nv_backlight%d", nb); >> else >> snprintf(backlight_name, BL_NAME_SIZE, "nv_backlight"); >> bl->id = nb; >> - return true; >> + return 0; >> } >> >> static int >> @@ -273,7 +273,8 @@ nouveau_backlight_init(struct drm_connector *connector) >> if (!bl) >> return -ENOMEM; >> >> - if (!nouveau_get_backlight_name(backlight_name, bl)) { >> + ret = nouveau_get_backlight_name(backlight_name, bl); >> + if (ret) { >> NV_ERROR(drm, "Failed to retrieve a unique name for the backlight interface\n"); >> goto fail_alloc; >> } >> -- >> 2.26.0.106.g9fadedd >> >> >> _______________________________________________ >> Nouveau mailing list >> Nouveau(a)lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau > > ------------------------------ > > Message: 4 > Date: Wed, 12 May 2021 08:39:52 +0200 > From: Pierre Moreau <pierre.morrow(a)free.fr> > To: Zhen Lei <thunder.leizhen(a)huawei.com> > Cc: Ben Skeggs <bskeggs(a)redhat.com>, David Airlie <airlied(a)linux.ie>, > Daniel Vetter <daniel(a)ffwll.ch>, dri-devel > <dri-devel(a)lists.freedesktop.org>, nouveau > <nouveau(a)lists.freedesktop.org> > Subject: Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak > Message-ID: <20210512063952.5kwdrq2yzbmgmn4x(a)Normandy.localdomain> > Content-Type: text/plain; charset=utf-8 > > Why remove the const modifier on `nb`? > > On 2021-05-11 ? 16:28, Zhen Lei wrote: >> When the 'nb' value allocated from 'bl_ida' is greater than or equal to >> 100, it will not be released. In fact, we can simplify operations by >> limiting the range of idas that can be applied for. >> >> By the way, delete the const modifier of the local variable 'nb'. >> >> Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") >> Signed-off-by: Zhen Lei <thunder.leizhen(a)huawei.com> >> --- >> drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c >> index 72f35a2babcb20e..d1c998e645fb4b6 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c >> @@ -51,8 +51,9 @@ static bool >> nouveau_get_backlight_name(char backlight_name[BL_NAME_SIZE], >> struct nouveau_backlight *bl) >> { >> - const int nb = ida_simple_get(&bl_ida, 0, 0, GFP_KERNEL); >> - if (nb < 0 || nb >= 100) >> + int nb = ida_simple_get(&bl_ida, 0, 100, GFP_KERNEL); >> + >> + if (nb < 0) >> return false; >> if (nb > 0) >> snprintf(backlight_name, BL_NAME_SIZE, "nv_backlight%d", nb); >> -- >> 2.26.0.106.g9fadedd >> >> >> _______________________________________________ >> Nouveau mailing list >> Nouveau(a)lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau > > ------------------------------ > > Message: 5 > Date: Wed, 12 May 2021 08:44:10 +0200 > From: Gerd Hoffmann <kraxel(a)redhat.com> > To: "Kasireddy, Vivek" <vivek.kasireddy(a)intel.com> > Cc: "dri-devel(a)lists.freedesktop.org" > <dri-devel(a)lists.freedesktop.org> > Subject: Re: [PATCH 1/3] virtio-gpu uapi: Add > VIRTIO_GPU_F_EXPLICIT_FLUSH feature > Message-ID: <20210512064410.infyhtac2bc35xr4(a)sirius.home.kraxel.org> > Content-Type: text/plain; charset=us-ascii > > Hi, > >> However, as part of this feature (explicit flush), I'd like to make the Guest wait until >> the current resource (as specified by resource_flush or set_scanout) is flushed or >> synchronized. But for a different feature I am thinking of (explicit sync), I'd like to >> make the Guest wait for the previous buffer/resource submitted (available via >> old_state->fb). > > For page-flipping I guess? i.e. you want submit a new framebuffer, then > wait until the host doesn't need the previous one? That is likewise > linked to a command, although it is set_scanout this time. > > So, right now qemu simply queues the request and completes the command > when a guest sends a resource_flush our set_scanout command. You want > be notified when the host is actually done processing the request. > > I still think it makes sense extend the resource_flush and set_scanout > commands for that, for example by adding a flag for the flags field in > the request header. That way it is clear what exactly you are waiting > for. You can also attach a fence to the request which you can later > wait on. > > take care, > Gerd > > ------------------------------ > > Message: 6 > Date: Wed, 12 May 2021 14:57:23 +0800 > From: "Leizhen (ThunderTown)" <thunder.leizhen(a)huawei.com> > To: Ben Skeggs <bskeggs(a)redhat.com>, David Airlie <airlied(a)linux.ie>, > "Daniel Vetter" <daniel(a)ffwll.ch>, dri-devel > <dri-devel(a)lists.freedesktop.org>, nouveau > <nouveau(a)lists.freedesktop.org> > Subject: Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak > Message-ID: <0800f5b6-ff18-94eb-a4a0-113800a9b14d(a)huawei.com> > Content-Type: text/plain; charset="utf-8" > > On 2021/5/12 14:39, Pierre Moreau wrote: >> Why remove the const modifier on `nb`? > > A non-pointer local variable, I don't think it's necessary to > add const modifier to make the syntax too complicated. > >> >> On 2021-05-11 ? 16:28, Zhen Lei wrote: >>> When the 'nb' value allocated from 'bl_ida' is greater than or equal to >>> 100, it will not be released. In fact, we can simplify operations by >>> limiting the range of idas that can be applied for. >>> >>> By the way, delete the const modifier of the local variable 'nb'. >>> >>> Fixes: db1a0ae21461 ("drm/nouveau/bl: Assign different names to interfaces") >>> Signed-off-by: Zhen Lei <thunder.leizhen(a)huawei.com> >>> --- >>> drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c >>> index 72f35a2babcb20e..d1c998e645fb4b6 100644 >>> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c >>> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c >>> @@ -51,8 +51,9 @@ static bool >>> nouveau_get_backlight_name(char backlight_name[BL_NAME_SIZE], >>> struct nouveau_backlight *bl) >>> { >>> - const int nb = ida_simple_get(&bl_ida, 0, 0, GFP_KERNEL); >>> - if (nb < 0 || nb >= 100) >>> + int nb = ida_simple_get(&bl_ida, 0, 100, GFP_KERNEL); >>> + >>> + if (nb < 0) >>> return false; >>> if (nb > 0) >>> snprintf(backlight_name, BL_NAME_SIZE, "nv_backlight%d", nb); >>> -- >>> 2.26.0.106.g9fadedd >>> >>> >>> _______________________________________________ >>> Nouveau mailing list >>> Nouveau(a)lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/nouveau >> >> . >> > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > ------------------------------ > > End of dri-devel Digest, Vol 134, Issue 309 > *******************************************

1 0

← Newer
1
...
56
57
58
59
60
61
62
...
81
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2021