dri-devel January 2022

dri-devel@lists.freedesktop.org

373 participants
842 discussions

[PATCH] drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
by Miaoqian Lin 07 Jan '22

07 Jan '22

Since drm_prime_pages_to_sg() function return error pointers. The drm_gem_shmem_get_sg_table() function returns error pointers too. Using IS_ERR() to check the return value to fix this. Fixes: f651c8b05542("drm/virtio: factor out the sg_table from virtio_gpu_object") Signed-off-by: Miaoqian Lin <linmq006(a)gmail.com> --- drivers/gpu/drm/virtio/virtgpu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index f648b0e24447..8bb80289672c 100644 --- a/drivers/gpu/drm/virtio/virtgpu_object.c +++ b/drivers/gpu/drm/virtio/virtgpu_object.c @@ -168,9 +168,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev, * since virtio_gpu doesn't support dma-buf import from other devices. */ shmem->pages = drm_gem_shmem_get_sg_table(&bo->base.base); - if (!shmem->pages) { + if (IS_ERR(shmem->pages)) { drm_gem_shmem_unpin(&bo->base.base); - return -EINVAL; + return PTR_ERR(shmem->pages); } if (use_dma_api) { -- 2.17.1

2 1

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption
by bugzilla-daemon＠bugzilla.kernel.org 07 Jan '22

07 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=215001 --- Comment #10 from Kris Karas (bugs-a21(a)moonlit-rail.com) --- Hi Thorsten - Thanks for the helpful pointer on bug reporting (comment 9). I've been so used to dealing with LKML and Bugzilla (since 1993) that I'd rather forgotten about Lore. :-) I didn't know whether the regression trackers were a real "bot" sort of thing, or just folks pitching in to try to keep track by hand. Good to know that it's still human-powered. I've got another bug to file now, multiple flavors of OOPSen showing up on boot in _kmalloc due to creation/manipulation of network devices (bridges, veth), perhaps as a result of the "igb" patches in 5.15 as it seems hardware-specific. I'll try to cc those lists when I have it bisected or narrowed down a bit... Kris -- You may reply to this email to add a comment. You are receiving this mail because: You are on the CC list for the bug.

1 0

[PATCH 0/2]
by Zhenneng Li 07 Jan '22

07 Jan '22

For adapting radeon rx6600 xt on arm64 platform, there report some compile errors. Zhenneng Li (2): drm/amdgpu: fix compile error for dcn on arm64 drm/amdgpu: enable dcn support on arm64 drivers/gpu/drm/amd/display/Kconfig | 2 +- drivers/gpu/drm/amd/display/dc/calcs/Makefile | 6 +++++ .../gpu/drm/amd/display/dc/clk_mgr/Makefile | 7 ++++++ drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 4 +++ drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 4 +++ .../gpu/drm/amd/display/dc/dcn201/Makefile | 6 +++++ drivers/gpu/drm/amd/display/dc/dcn21/Makefile | 4 +++ drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 6 +++++ .../gpu/drm/amd/display/dc/dcn302/Makefile | 6 +++++ .../gpu/drm/amd/display/dc/dcn303/Makefile | 6 +++++ drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 6 +++++ drivers/gpu/drm/amd/display/dc/dml/Makefile | 25 +++++++++++++++++++ drivers/gpu/drm/amd/display/dc/dsc/Makefile | 7 ++++++ 13 files changed, 88 insertions(+), 1 deletion(-) -- 2.25.1 No virus found Checked by Hillstone Network AntiVirus

2 3

[PATCH] drm/amdkfd: use default_groups in kobj_type
by Greg Kroah-Hartman 07 Jan '22

07 Jan '22

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdkfd sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field. Cc: Felix Kuehling <Felix.Kuehling(a)amd.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index b993011cfa64..1f4a07f984eb 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -462,6 +462,7 @@ static struct attribute *procfs_queue_attrs[] = { &attr_queue_gpuid, NULL }; +ATTRIBUTE_GROUPS(procfs_queue); static const struct sysfs_ops procfs_queue_ops = { .show = kfd_procfs_queue_show, @@ -469,7 +470,7 @@ static const struct sysfs_ops procfs_queue_ops = { static struct kobj_type procfs_queue_type = { .sysfs_ops = &procfs_queue_ops, - .default_attrs = procfs_queue_attrs, + .default_groups = procfs_queue_groups, }; static const struct sysfs_ops procfs_stats_ops = { -- 2.34.1

2 1

[PATCH] drm/amdgpu: use default_groups in kobj_type
by Greg Kroah-Hartman 07 Jan '22

07 Jan '22

There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdgpu sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field. Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Hawking Zhang <Hawking.Zhang(a)amd.com> Cc: John Clements <john.clements(a)amd.com> Cc: Felix Kuehling <Felix.Kuehling(a)amd.com> Cc: Jonathan Kim <jonathan.kim(a)amd.com> Cc: Kevin Wang <kevin1.wang(a)amd.com> Cc: shaoyunl <shaoyun.liu(a)amd.com> Cc: Tao Zhou <tao.zhou1(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index 567df2db23ac..94dcb004988d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c @@ -208,6 +208,7 @@ static struct attribute *amdgpu_xgmi_hive_attrs[] = { &amdgpu_xgmi_hive_id, NULL }; +ATTRIBUTE_GROUPS(amdgpu_xgmi_hive); static ssize_t amdgpu_xgmi_show_attrs(struct kobject *kobj, struct attribute *attr, char *buf) @@ -237,7 +238,7 @@ static const struct sysfs_ops amdgpu_xgmi_hive_ops = { struct kobj_type amdgpu_xgmi_hive_type = { .release = amdgpu_xgmi_hive_release, .sysfs_ops = &amdgpu_xgmi_hive_ops, - .default_attrs = amdgpu_xgmi_hive_attrs, + .default_groups = amdgpu_xgmi_hive_groups, }; static ssize_t amdgpu_xgmi_show_device_id(struct device *dev, -- 2.34.1

2 1

[PATCH v4 1/3] drm/privacy_screen: Add drvdata in drm_privacy_screen
by Rajat Jain 07 Jan '22

07 Jan '22

Allow a privacy screen provider to stash its private data pointer in the drm_privacy_screen, and update the drm_privacy_screen_register() call to accept that. Also introduce a *_get_drvdata() so that it can retrieved back when needed. This also touches the IBM Thinkpad platform driver, the only user of privacy screen today, to pass NULL for now to the updated API. Signed-off-by: Rajat Jain <rajatja(a)google.com> Reviewed-by: Hans de Goede <hdegoede(a)redhat.com> --- v4: Added "Reviewed-by" from Hans v3: Initial version. Came up due to review comments on v2 of other patches. v2: No v2 v1: No v1 drivers/gpu/drm/drm_privacy_screen.c | 5 ++++- drivers/platform/x86/thinkpad_acpi.c | 2 +- include/drm/drm_privacy_screen_driver.h | 13 ++++++++++++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_privacy_screen.c b/drivers/gpu/drm/drm_privacy_screen.c index beaf99e9120a..03b149cc455b 100644 --- a/drivers/gpu/drm/drm_privacy_screen.c +++ b/drivers/gpu/drm/drm_privacy_screen.c @@ -387,7 +387,8 @@ static void drm_privacy_screen_device_release(struct device *dev) * * An ERR_PTR(errno) on failure. */ struct drm_privacy_screen *drm_privacy_screen_register( - struct device *parent, const struct drm_privacy_screen_ops *ops) + struct device *parent, const struct drm_privacy_screen_ops *ops, + void *data) { struct drm_privacy_screen *priv; int ret; @@ -404,6 +405,7 @@ struct drm_privacy_screen *drm_privacy_screen_register( priv->dev.parent = parent; priv->dev.release = drm_privacy_screen_device_release; dev_set_name(&priv->dev, "privacy_screen-%s", dev_name(parent)); + priv->drvdata = data; priv->ops = ops; priv->ops->get_hw_state(priv); @@ -439,6 +441,7 @@ void drm_privacy_screen_unregister(struct drm_privacy_screen *priv) mutex_unlock(&drm_privacy_screen_devs_lock); mutex_lock(&priv->lock); + priv->drvdata = NULL; priv->ops = NULL; mutex_unlock(&priv->lock); diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 341655d711ce..ccbfda2b0095 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -9782,7 +9782,7 @@ static int tpacpi_lcdshadow_init(struct ibm_init_struct *iibm) return 0; lcdshadow_dev = drm_privacy_screen_register(&tpacpi_pdev->dev, - &lcdshadow_ops); + &lcdshadow_ops, NULL); if (IS_ERR(lcdshadow_dev)) return PTR_ERR(lcdshadow_dev); diff --git a/include/drm/drm_privacy_screen_driver.h b/include/drm/drm_privacy_screen_driver.h index 24591b607675..4ef246d5706f 100644 --- a/include/drm/drm_privacy_screen_driver.h +++ b/include/drm/drm_privacy_screen_driver.h @@ -73,10 +73,21 @@ struct drm_privacy_screen { * for more info. */ enum drm_privacy_screen_status hw_state; + /** + * @drvdata: Private data owned by the privacy screen provider + */ + void *drvdata; }; +static inline +void *drm_privacy_screen_get_drvdata(struct drm_privacy_screen *priv) +{ + return priv->drvdata; +} + struct drm_privacy_screen *drm_privacy_screen_register( - struct device *parent, const struct drm_privacy_screen_ops *ops); + struct device *parent, const struct drm_privacy_screen_ops *ops, + void *data); void drm_privacy_screen_unregister(struct drm_privacy_screen *priv); void drm_privacy_screen_call_notifier_chain(struct drm_privacy_screen *priv); -- 2.34.1.307.g9b7440fafd-goog

3 5

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI
by Bjorn Helgaas 07 Jan '22

07 Jan '22

On Thu, Jan 06, 2022 at 05:41:00PM +0000, John Garry wrote: > On 05/01/2022 19:47, Bjorn Helgaas wrote: > > IMO inb() should > > be present but do something innocuous like return ~0, as it would if > > I/O port space is supported but there's no device at that address. > > > > [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/d… > > > > That driver would prob not be used on systems which does not support PIO, > and so could have a HAS_IOPORT dependency. But it is not strictly necessary. I don't want the path of "this driver isn't needed because the device is unlikely to be used on this arch." Maybe it's not _always_ possible, but if the device can be plugged into the platform, I think we should be able to build the driver for it. If the device requires I/O port space and the platform doesn't support it, the PCI core or the driver should detect that and give a useful diagnostic. Bjorn

2 1

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption
by bugzilla-daemon＠bugzilla.kernel.org 07 Jan '22

07 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=215001 --- Comment #9 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressions(a)leemhuis.info) --- (In reply to Kris Karas from comment #7) > > ... I filed this bug nearly 2 months ago with the "Regression = Y" metadata > clearly set; but the various kernel regression trackers Which trackers? Humans or software? I'm running a bot, but that is still in the early stages -- and has no bugzilla integration as of now (but it's on the todo list, but only in the middle), as the kernel's docs discourage from using it most of the time. See https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html (written by yours truly). See also the last section of that document. > What's the best way to get a bugzilla report > for a regression tracked so that it doesn't get forgotten or lost in the > shuffle? Docs on that are in the work: https://lore.kernel.org/linux-doc/cover.1641203216.git.linux@leemhuis.info/ > For example, bug 199533 was filed back in 2018, with a proper > bisect even, but hasn't garnered even so much as a single comment. > (Probably ought to be closed as I no longer have the hardware to test a fix > :-) There are many things wrt kernel bug/regression reporting that IMHO need to be fixed or improved. I'm working on this, but I'm mostly doing it in my spare time (except for the regzbot, for which I found external funding). -- You may reply to this email to add a comment. You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 215001] Regression in 5.15, Firmware-initialized graphics console selects FB_VGA16, screen corruption
by bugzilla-daemon＠bugzilla.kernel.org 07 Jan '22

07 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=215001 --- Comment #8 from Javier Martinez Canillas (javier(a)dowhile0.org) --- Hello Kris, (In reply to Kris Karas from comment #7) > Hi Javier - I tested the (updated) patch from comment 6 on three different > systems, two servers with a character-graphic BIOS (expected to use VGA16), > and my development system with a graphical UEFI boot (expected to use > EFIFB). I am happy to report that in all cases, the patch worked perfectly. > > Thanks for having whipped up this patch! > > Feel free to submit upstream to Linus, and also to Greg for inclusion in > 5.15.y. > Tested-By: Kris Karas <bugs-a21(a)moonlit-rail.com> > Thanks for testing the patch! I've just posted it along with another fix for a bug I noticed by reading the code (EGA is never used and the driver always assume to be VGA): https://lkml.org/lkml/2022/1/7/270 -- You may reply to this email to add a comment. You are receiving this mail because: You are on the CC list for the bug.

1 0

[PATCH] drm: Fix gem obj imbalance due to calling drm_gem_object_put() twice
by Roberto Sassu 07 Jan '22

07 Jan '22

After commit 9786b65bc61ac ("drm/ttm: fix mmap refcounting"), drm_gem_mmap_obj() takes a reference of the passed drm_gem_object at the beginning of the function to safely dereference the mmap offset pointer, and releases it at the end, if an error occurred. However, the cma and shmem helpers are also releasing that reference in case of an error, which causes the imbalance of the reference counter and the panic reported by syzbot. Don't release the reference in drm_gem_mmap_obj() if the mmap method was called and it returned an error, and uniformly apply the same behavior of the cma and shmem helpers to the ttm helper (release the reference in the helper, not in the caller, when an error occurs). Cc: stable(a)vger.kernel.org Signed-off-by: Roberto Sassu <roberto.sassu(a)huawei.com> Reported-by: syzbot+c8ae65286134dd1b800d(a)syzkaller.appspotmail.com Fixes: 9786b65bc61ac ("drm/ttm: fix mmap refcounting") --- drivers/gpu/drm/drm_gem.c | 3 ++- drivers/gpu/drm/drm_gem_ttm_helper.c | 4 +--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 4dcdec6487bb..7264a1a7a8d2 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -1049,8 +1049,9 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size, if (obj->funcs->mmap) { ret = obj->funcs->mmap(obj, vma); + /* All helpers call drm_gem_object_put() */ if (ret) - goto err_drm_gem_object_put; + return ret; WARN_ON(!(vma->vm_flags & VM_DONTEXPAND)); } else { if (!vma->vm_ops) { diff --git a/drivers/gpu/drm/drm_gem_ttm_helper.c b/drivers/gpu/drm/drm_gem_ttm_helper.c index ecf3d2a54a98..c44bfdbb722d 100644 --- a/drivers/gpu/drm/drm_gem_ttm_helper.c +++ b/drivers/gpu/drm/drm_gem_ttm_helper.c @@ -101,8 +101,6 @@ int drm_gem_ttm_mmap(struct drm_gem_object *gem, int ret; ret = ttm_bo_mmap_obj(vma, bo); - if (ret < 0) - return ret; /* * ttm has its own object refcounting, so drop gem reference @@ -110,7 +108,7 @@ int drm_gem_ttm_mmap(struct drm_gem_object *gem, */ drm_gem_object_put(gem); - return 0; + return ret; } EXPORT_SYMBOL(drm_gem_ttm_mmap); -- 2.32.0

1 1

← Newer
1
...
71
72
73
74
75
76
77
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2022