dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[PATCH v4 0/5] fbdev: Decouple deferred I/O from struct page
by Thomas Zimmermann 29 Apr '22

29 Apr '22

Rework the fbdev deferred-I/O to not interfere with fields of struct page. All references from deferred-I/O code to fields in struct page are gone. The rsp state is held in a separate pageref structure. v4: * fix locking in fb_mmap() (Dan) * fix commit-message style (Javier) v3: * rename pagelist to pagereflist (Sam) * use pageref->offset over page->index (Javier) v2: * split off from a larger patchset [1] [1] https://lore.kernel.org/dri-devel/20220303205839.28484-1-tzimmermann@suse.d… Thomas Zimmermann (5): fbdev: Put mmap for deferred I/O into drivers fbdev: Track deferred-I/O pages in pageref struct fbdev: Refactor implementation of page_mkwrite fbdev: Rename pagelist to pagereflist for deferred I/O fbdev: Use pageref offset for deferred-I/O writeback drivers/gpu/drm/drm_fb_helper.c | 15 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 10 +- drivers/hid/hid-picolcd_fb.c | 3 +- drivers/staging/fbtft/fbtft-core.c | 21 ++- drivers/video/fbdev/broadsheetfb.c | 27 ++-- drivers/video/fbdev/core/fb_defio.c | 212 +++++++++++++++++-------- drivers/video/fbdev/core/fbmem.c | 22 +-- drivers/video/fbdev/hecubafb.c | 4 +- drivers/video/fbdev/hyperv_fb.c | 10 +- drivers/video/fbdev/metronomefb.c | 23 ++- drivers/video/fbdev/sh_mobile_lcdcfb.c | 27 ++-- drivers/video/fbdev/smscufx.c | 13 +- drivers/video/fbdev/ssd1307fb.c | 4 +- drivers/video/fbdev/udlfb.c | 18 +-- drivers/video/fbdev/xen-fbfront.c | 10 +- include/drm/drm_fb_helper.h | 3 +- include/linux/fb.h | 17 +- 17 files changed, 265 insertions(+), 174 deletions(-) base-commit: 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129 -- 2.36.0

1 5

[PATCH v5 0/5] drm/msm: rework clock handling
by Dmitry Baryshkov 29 Apr '22

29 Apr '22

msm_dss_clk_*() functions significantly duplicate clk_bulk_* family of functions. Drop custom code and use bulk clocks directly. This also removes dependency of DP driver on the DPU driver internals. Note that DP changes were compile-only tested. Changes since v4: - Use size_t for num_clocks in dpu_kms/dpu_mdss - Use min() in dpu_core_perf_crtc_update() - Drop overcomplicated clock rate setting wrappers inside DP code. We were setting the opp for one clock and setting a rate for a single clock! Call dev_pm_opp_set_rate() and clk_set_rate() directly. Changes since v3: - Switched to devm_clk_bulk_get_all() per Stephen's suggestion. - Removed a call to of_clk_set_defaults() (per Stephen's suggestion again). It duplicates a call in platform_probe(). - Split the first patch (moving helpers to msm_io_utils.c), it's unused now. Changes since v2: - Retain conditional code/prints in DP code to ease debugging - Rebase on top of msm-next and [1] - Split helper functions to msm_io_utils.c as suggested by Jessica Changes since v1: - Rebase on top of current tree to fix conflicts Dmitry Baryshkov (5): drm/msm/dpu: simplify clocks handling drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link") drm/msm/dp: set stream_pixel rate directly drm/msm/dp: inline dp_power_clk_set_rate() drm/msm/dp: rewrite dss_module_power to use bulk clock functions drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 23 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 +- drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 187 ------------------ drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 40 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 46 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 26 +-- drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +- drivers/gpu/drm/msm/dp/dp_parser.c | 43 ++-- drivers/gpu/drm/msm/dp/dp_parser.h | 6 +- drivers/gpu/drm/msm/dp/dp_power.c | 105 ++-------- 12 files changed, 74 insertions(+), 426 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h -- 2.34.1

2 19

[PATCH] drm: of: fix a potential double put bug
by Ziyang Xuan 29 Apr '22

29 Apr '22

Execute the following coccinelle rule: $make coccicheck COCCI=scripts/coccinelle/iterators/device_node_continue.cocci Get an error report as following: ./drivers/gpu/drm/drm_of.c:292:2-13: ERROR: probable double put. Device node iterators put the previous value of the index variable, when find_panel_or_bridge() return non-zero, it will causes a double put. Fixes: 67bae5f28c89 ("drm: of: Properly try all possible cases for bridge/panel detection") Signed-off-by: Ziyang Xuan <william.xuanziyang(a)huawei.com> --- drivers/gpu/drm/drm_of.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index f4df344509a8..8c3c0bca1af1 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -289,11 +289,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, continue; ret = find_panel_or_bridge(node, panel, bridge); - of_node_put(node); /* Stop at the first found occurrence. */ - if (!ret) + if (!ret) { + of_node_put(node); return 0; + } } return -EPROBE_DEFER; -- 2.25.1

1 1

[PATCH v4] drm/bridge: tc358767: Fix (e)DP bridge endpoint parsing in dedicated function
by Marek Vasut 29 Apr '22

29 Apr '22

Per toshiba,tc358767.yaml DT binding document, port@2 the output (e)DP port is optional. In case this port is not described in DT, the bridge driver operates in DPI-to-DP mode. The drm_of_find_panel_or_bridge() call in tc_probe_edp_bridge_endpoint() returns -ENODEV in case port@2 is not present in DT and this specific return value is incorrectly propagated outside of tc_probe_edp_bridge_endpoint() function. All other error values must be propagated and are propagated correctly. Return 0 in case the port@2 is missing instead, that reinstates the original behavior before the commit this patch fixes. Fixes: 8478095a8c4b ("drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function") Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Jonas Karlman <jonas(a)kwiboo.se> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: Marek Vasut <marex(a)denx.de> Cc: Maxime Ripard <maxime(a)cerno.tech> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0336b14d9e94..ad1d6e383966 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1955,7 +1955,7 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc) tc->bridge.ops |= DRM_BRIDGE_OP_DETECT; tc->bridge.ops |= DRM_BRIDGE_OP_EDID; - return ret; + return 0; } static int tc_probe_bridge_endpoint(struct tc_data *tc) -- 2.35.1

2 2

[PATCH] drm: omapdrm: simplify the return expression of dss_setup_default_clock()
by cgel.zte＠gmail.com 29 Apr '22

29 Apr '22

From: Minghao Chi <chi.minghao(a)zte.com.cn> Simplify the return expression. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: Minghao Chi <chi.minghao(a)zte.com.cn> --- drivers/gpu/drm/omapdrm/dss/dss.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index 0399f3390a0a..2f13805d85ba 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -672,7 +672,6 @@ static int dss_setup_default_clock(struct dss_device *dss) unsigned long max_dss_fck, prate; unsigned long fck; unsigned int fck_div; - int r; max_dss_fck = dss->feat->fck_freq_max; @@ -687,11 +686,7 @@ static int dss_setup_default_clock(struct dss_device *dss) * dss->feat->dss_fck_multiplier; } - r = dss_set_fck_rate(dss, fck); - if (r) - return r; - - return 0; + return dss_set_fck_rate(dss, fck); } void dss_set_venc_output(struct dss_device *dss, enum omap_dss_venc_type type) -- 2.25.1

1 0

[PATCH] drm/radeon: fix reference count leak in cik_sdma_ib_test()
by Xin Xiong 29 Apr '22

29 Apr '22

The issue takes place in several error handling paths in cik_sdma_ib_test(). For example, when radeon_fence_wait_timeout() returns a value no greater than zero, the function simply returns an error code, forgetting to decrease the reference count of the object "ib", which is incremented by radeon_ib_get() earlier. This may result in memory leaks. Fix it by decrementing the reference count of "ib" in those paths. Fixes: 04db4caf5c83 ("drm/radeon: Avoid double gpu reset by adding a timeout on IB ring tests.") Signed-off-by: Xin Xiong <xiongx18(a)fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf(a)gmail.com> --- drivers/gpu/drm/radeon/cik_sdma.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik_sdma.c b/drivers/gpu/drm/radeon/cik_sdma.c index 919b14845c3c..d0e7323cdd42 100644 --- a/drivers/gpu/drm/radeon/cik_sdma.c +++ b/drivers/gpu/drm/radeon/cik_sdma.c @@ -732,18 +732,18 @@ int cik_sdma_ib_test(struct radeon_device *rdev, struct radeon_ring *ring) r = radeon_ib_schedule(rdev, &ib, NULL, false); if (r) { - radeon_ib_free(rdev, &ib); DRM_ERROR("radeon: failed to schedule ib (%d).\n", r); - return r; + goto out; } r = radeon_fence_wait_timeout(ib.fence, false, usecs_to_jiffies( RADEON_USEC_IB_TEST_TIMEOUT)); if (r < 0) { DRM_ERROR("radeon: fence wait failed (%d).\n", r); - return r; + goto out; } else if (r == 0) { DRM_ERROR("radeon: fence wait timed out.\n"); - return -ETIMEDOUT; + r = -ETIMEDOUT; + goto out; } r = 0; for (i = 0; i < rdev->usec_timeout; i++) { @@ -758,6 +758,7 @@ int cik_sdma_ib_test(struct radeon_device *rdev, struct radeon_ring *ring) DRM_ERROR("radeon: ib test failed (0x%08X)\n", tmp); r = -EINVAL; } +out: radeon_ib_free(rdev, &ib); return r; } -- 2.25.1

1 0

[PATCH v3 0/5] Fix some race conditions that exists between fbmem and sysfb
by Javier Martinez Canillas 29 Apr '22

29 Apr '22

Hello, The patches in this series are mostly changes suggested by Daniel Vetter to fix some race conditions that exists between the fbdev core (fbmem) and sysfb with regard to device registration and removal. For example, it is currently possible for sysfb to register a platform device after a real DRM driver was registered and requested to remove the conflicting framebuffers. A symptom of this issue, was worked around with by commit fb561bf9abde ("fbdev: Prevent probing generic drivers if a FB is already registered") but that's really a hack and should be reverted. This series attempt to fix it more properly and revert the mentioned hack. That will also unblock a pending patch to not make the num_registered_fb variable visible to drivers anymore, since that's internal to fbdev core. Patch #1 is just a trivial preparatory change. Patch #2 add sysfb_disable() and sysfb_try_unregister() helpers for fbmem to use them. Patch #3 changes how is dealt with conflicting framebuffers unregistering, rather than having a variable to determine if a lock should be take, it just drops the lock before unregistering the platform device. Patch #4 fixes the mentioned race conditions and finally patch #5 is the revert patch that was posted by Daniel before but he dropped from his set. The patches were tested on a rpi4 using different video configurations: (simpledrm -> vc4 both builtin, only vc4 builtin, only simpledrm builtin and simpledrm builtin with vc4 built as a module). Best regards, Javier Changes in v3: - Rebase on top of latest drm-misc-next branch. Changes in v2: - Rebase on top of latest drm-misc-next and fix conflicts (Daniel Vetter). - Add kernel-doc comments and include in other_interfaces.rst (Daniel Vetter). - Explain in the commit message that fbmem has to unregister the device as fallback if a driver registered the device itself (Daniel Vetter). - Also explain that fallback in a comment in the code (Daniel Vetter). - Don't encode in fbmem the assumption that sysfb will always register platform devices (Daniel Vetter). - Add a FIXME comment about drivers registering devices (Daniel Vetter). - Drop RFC prefix since patches were already reviewed by Daniel Vetter. - Add Daniel Reviewed-by tags to the patches. Daniel Vetter (1): Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Javier Martinez Canillas (4): firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer firmware: sysfb: Add helpers to unregister a pdev and disable registration fbdev: Restart conflicting fb removal loop when unregistering devices fbdev: Fix some race conditions between fbmem and sysfb .../driver-api/firmware/other_interfaces.rst | 6 ++ drivers/firmware/sysfb.c | 77 +++++++++++++++++-- drivers/firmware/sysfb_simplefb.c | 16 ++-- drivers/video/fbdev/core/fbmem.c | 62 ++++++++++++--- drivers/video/fbdev/efifb.c | 11 --- drivers/video/fbdev/simplefb.c | 11 --- include/linux/fb.h | 1 - include/linux/sysfb.h | 29 +++++-- 8 files changed, 158 insertions(+), 55 deletions(-) -- 2.35.1

4 15

[PATCH v3 0/5] fbdev: Decouple deferred I/O from struct page
by Thomas Zimmermann 29 Apr '22

29 Apr '22

Rework the fbdev deferred-I/O to not interfere with fields of struct page. All references from deferred-I/O code to fields in struct page are gone. The rsp state is help in a separate pageref structure. v3: * rename pagelist to pagereflist (Sam) * use pageref->offset over page->index (Javier) v2: * split off from a larger patchset [1] [1] https://lore.kernel.org/dri-devel/20220303205839.28484-1-tzimmermann@suse.d… Thomas Zimmermann (5): fbdev: Put mmap for deferred I/O into drivers fbdev: Track deferred-I/O pages in pageref struct fbdev: Refactor implementation of page_mkwrite fbdev: Rename pagelist to pagereflist for deferred I/O fbdev: Use pageref offset for deferred-I/O writeback drivers/gpu/drm/drm_fb_helper.c | 15 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 10 +- drivers/hid/hid-picolcd_fb.c | 3 +- drivers/staging/fbtft/fbtft-core.c | 21 ++- drivers/video/fbdev/broadsheetfb.c | 27 ++-- drivers/video/fbdev/core/fb_defio.c | 212 +++++++++++++++++-------- drivers/video/fbdev/core/fbmem.c | 21 +-- drivers/video/fbdev/hecubafb.c | 4 +- drivers/video/fbdev/hyperv_fb.c | 10 +- drivers/video/fbdev/metronomefb.c | 23 ++- drivers/video/fbdev/sh_mobile_lcdcfb.c | 27 ++-- drivers/video/fbdev/smscufx.c | 13 +- drivers/video/fbdev/ssd1307fb.c | 4 +- drivers/video/fbdev/udlfb.c | 18 +-- drivers/video/fbdev/xen-fbfront.c | 10 +- include/drm/drm_fb_helper.h | 3 +- include/linux/fb.h | 17 +- 17 files changed, 264 insertions(+), 174 deletions(-) base-commit: 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129 -- 2.36.0

3 11

[PATCH v4, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence
by xinlei.lee＠mediatek.com 29 Apr '22

29 Apr '22

From: Xinlei Lee <xinlei.lee(a)mediatek.com> In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order to ensure the timing of dsi_power_on/off and the timing of pulling up/down the MIPI signal, the modification of v5.9 is synchronized in this series of patches. Changes since v3: 1. Rebase kernel-5.18-rc1. 2. Added dsi_enable protection. 3. Encapsulates the dsi_lane_ready function. Changes since v2: 1. Rebase linux-next. Changes since v1: 1. Dsi sequence marked with patch adjustment. 2. Fixes: mtk_dsi: Use the drm_panel_bridge. Jitao Shi (3): drm/mediatek: Adjust the timing of mipi signal from LP00 to LP11 drm/mediatek: Separate poweron/poweroff from enable/disable and define new funcs drm/mediatek: keep dsi as LP00 before dcs cmds transfer Xinlei Lee (1): drm/mediatek: Add pull-down MIPI operation in mtk_dsi_poweroff function drivers/gpu/drm/mediatek/mtk_dsi.c | 81 ++++++++++++++++++++---------- 1 file changed, 55 insertions(+), 26 deletions(-) -- 2.18.0

5 21

[PATCH] drm/dp_mst: Lower down debug info level when receive NAK
by Wayne Lin 29 Apr '22

29 Apr '22

[Why] It's reasonable that we receive NAK while doing DP_REMOTE_DPCD_READ. Downstream device might reply NAK with the reason and source should react accordingly. e.g. 1. When downstream device can't handle corresponding message in time, it then replies NAK as reason been set as DEFER. 2. When multi-function branch-sink device doesn't enumerate virtual DP peer devices for those multi-function down facing ports. Without virtual DPCD, branch device might reply NAK with reason as BAD_PARAM indicating this port can't do aux DPCD read. It's expected result. Not an error. [How] Use drm_dbg_kms() to replace drm_err() when receive NAK. Changes since v1: * drm_dp_mst_topology.c file path changed. Folder was rename from 'dp' to 'display' Signed-off-by: Wayne Lin <Wayne.Lin(a)amd.com> Reviewed-by: Harry Wentland <harry.wentland(a)amd.com> --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c index 8526aae75c6d..f27aa0b95bea 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -3557,9 +3557,8 @@ static int drm_dp_send_dpcd_read(struct drm_dp_mst_topology_mgr *mgr, if (ret < 0) goto fail_free; - /* DPCD read should never be NACKed */ if (txmsg->reply.reply_type == 1) { - drm_err(mgr->dev, "mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n", + drm_dbg_kms(mgr->dev, "mstb %p port %d: DPCD read on addr 0x%x for %d bytes NAKed\n", mstb, port->port_num, offset, size); ret = -EIO; goto fail_free; -- 2.36.0

3 2

← Newer
1
...
17
18
19
20
21
22
23
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022