dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[RFC v5 0/6] Proposal for a GPU cgroup controller
by T.J. Mercier 22 Apr '22

22 Apr '22

This patch series revisits the proposal for a GPU cgroup controller to track and limit memory allocations by various device/allocator subsystems. The patch series also contains a simple prototype to illustrate how Android intends to implement DMA-BUF allocator attribution using the GPU cgroup controller. The prototype does not include resource limit enforcements. Changelog: v5: Rebase on top of v5.18-rc3 Drop the global GPU cgroup "total" (sum of all device totals) portion of the design since there is no currently known use for this per Tejun Heo. Fix commit message which still contained the old name for dma_buf_transfer_charge per Michal Koutný. Remove all GPU cgroup code except what's necessary to support charge transfer from dma_buf. Previously charging was done in export, but for non-Android graphics use-cases this is not ideal since there may be a delay between allocation and export, during which time there is no accounting. Merge dmabuf: Use the GPU cgroup charge/uncharge APIs patch into dmabuf: heaps: export system_heap buffers with GPU cgroup charging as a result of above. Put the charge and uncharge code in the same file (system_heap_allocate, system_heap_dma_buf_release) instead of splitting them between the heap and the dma_buf_release. This avoids asymmetric management of the gpucg charges. Modify the dma_buf_transfer_charge API to accept a task_struct instead of a gpucg. This avoids requiring the caller to manage the refcount of the gpucg upon failure and confusing ownership transfer logic. Support all strings for gpucg_register_bucket instead of just string literals. Enforce globally unique gpucg_bucket names. Constrain gpucg_bucket name lengths to 64 bytes. Append "-heap" to gpucg_bucket names from dmabuf-heaps. Drop patch 7 from the series, which changed the types of binder_transaction_data's sender_pid and sender_euid fields. This was done in another commit here: https://lore.kernel.org/all/20220210021129.3386083-4-masahiroy@kernel.org/ Rename: gpucg_try_charge -> gpucg_charge find_cg_rpool_locked -> cg_rpool_find_locked init_cg_rpool -> cg_rpool_init get_cg_rpool_locked -> cg_rpool_get_locked "gpu cgroup controller" -> "GPU controller" gpucg_device -> gpucg_bucket usage -> size Tests: Support both binder_fd_array_object and binder_fd_object. This is necessary because new versions of Android will use binder_fd_object instead of binder_fd_array_object, and we need to support both. Tests for both binder_fd_array_object and binder_fd_object. For binder_utils return error codes instead of struct binder{fs}_ctx. Use ifdef __ANDROID__ to choose platform-dependent temp path instead of a runtime fallback. Ensure binderfs_mntpt ends with a trailing '/' character instead of prepending it where used. v4: Skip test if not run as root per Shuah Khan Add better test logging for abnormal child termination per Shuah Khan Adjust ordering of charge/uncharge during transfer to avoid potentially hitting cgroup limit per Michal Koutný Adjust gpucg_try_charge critical section for charge transfer functionality Fix uninitialized return code error for dmabuf_try_charge error case v3: Remove Upstreaming Plan from gpu-cgroup.rst per John Stultz Use more common dual author commit message format per John Stultz Remove android from binder changes title per Todd Kjos Add a kselftest for this new behavior per Greg Kroah-Hartman Include details on behavior for all combinations of kernel/userspace versions in changelog (thanks Suren Baghdasaryan) per Greg Kroah-Hartman. Fix pid and uid types in binder UAPI header v2: See the previous revision of this change submitted by Hridya Valsaraju at: https://lore.kernel.org/all/20220115010622.3185921-1-hridya@google.com/ Move dma-buf cgroup charge transfer from a dma_buf_op defined by every heap to a single dma-buf function for all heaps per Daniel Vetter and Christian König. Pointers to struct gpucg and struct gpucg_device tracking the current associations were added to the dma_buf struct to achieve this. Fix incorrect Kconfig help section indentation per Randy Dunlap. History of the GPU cgroup controller ==================================== The GPU/DRM cgroup controller came into being when a consensus[1] was reached that the resources it tracked were unsuitable to be integrated into memcg. Originally, the proposed controller was specific to the DRM subsystem and was intended to track GEM buffers and GPU-specific resources[2]. In order to help establish a unified memory accounting model for all GPU and all related subsystems, Daniel Vetter put forth a suggestion to move it out of the DRM subsystem so that it can be used by other DMA-BUF exporters as well[3]. This RFC proposes an interface that does the same. [1]: https://patchwork.kernel.org/project/dri-devel/cover/20190501140438.9506-1-… [2]: https://lore.kernel.org/amd-gfx/20210126214626.16260-1-brian.welty@intel.co… [3]: https://lore.kernel.org/amd-gfx/YCVOl8%2F87bqRSQei@phenom.ffwll.local/ Hridya Valsaraju (3): gpu: rfc: Proposal for a GPU cgroup controller cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory binder: Add flags to relinquish ownership of fds T.J. Mercier (3): dmabuf: heaps: export system_heap buffers with GPU cgroup charging dmabuf: Add gpu cgroup charge transfer function selftests: Add binder cgroup gpu memory transfer tests Documentation/gpu/rfc/gpu-cgroup.rst | 190 +++++++ Documentation/gpu/rfc/index.rst | 4 + drivers/android/binder.c | 27 +- drivers/dma-buf/dma-buf.c | 80 ++- drivers/dma-buf/dma-heap.c | 39 ++ drivers/dma-buf/heaps/system_heap.c | 28 +- include/linux/cgroup_gpu.h | 137 +++++ include/linux/cgroup_subsys.h | 4 + include/linux/dma-buf.h | 49 +- include/linux/dma-heap.h | 15 + include/uapi/linux/android/binder.h | 23 +- init/Kconfig | 7 + kernel/cgroup/Makefile | 1 + kernel/cgroup/gpu.c | 386 +++++++++++++ .../selftests/drivers/android/binder/Makefile | 8 + .../drivers/android/binder/binder_util.c | 250 +++++++++ .../drivers/android/binder/binder_util.h | 32 ++ .../selftests/drivers/android/binder/config | 4 + .../binder/test_dmabuf_cgroup_transfer.c | 526 ++++++++++++++++++ 19 files changed, 1787 insertions(+), 23 deletions(-) create mode 100644 Documentation/gpu/rfc/gpu-cgroup.rst create mode 100644 include/linux/cgroup_gpu.h create mode 100644 kernel/cgroup/gpu.c create mode 100644 tools/testing/selftests/drivers/android/binder/Makefile create mode 100644 tools/testing/selftests/drivers/android/binder/binder_util.c create mode 100644 tools/testing/selftests/drivers/android/binder/binder_util.h create mode 100644 tools/testing/selftests/drivers/android/binder/config create mode 100644 tools/testing/selftests/drivers/android/binder/test_dmabuf_cgroup_transfer.c -- 2.36.0.rc0.470.gd361397f0d-goog

4 10

[PATCH v7 0/5] Update mdp clk to max supported value to support higher refresh rates
by Vinod Polimera 22 Apr '22

22 Apr '22

Drop the assigned clock rate property and vote on the mdp clock to max frequency during bind/probe sequence. Changes in v2: - Remove assigned-clock-rate property and set mdp clk during resume sequence. - Add fixes tag. Changes in v3: - Remove extra line after fixes tag.(Stephen Boyd) - Add similar changes for sc7180, sdm845 which uses opp table for voting mdp clk.(Stephen Boyd) - Drop patch: "drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table" Changes in v4: - Add similar change for sm8250.(Dmitry) Changes in v5: - Add change to set mdp clk to max frequency in opp table during mdp probe/bind. Changes in v6: - Remove change log in dt patch. - Fix the leak reference for opp by adding dev_pm_opp_put. (Dmitry) Changes in v7: - Update commit message and fix tag. (Stephen/Doug) Vinod Polimera (5): drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe arm64: dts: qcom: sm7280: remove assigned-clock-rate property for mdp clk arm64: dts: qcom: sm7180: remove assigned-clock-rate property for mdp clk arm64: dts: qcom: sdm845: remove assigned-clock-rate property for mdp clk arm64: dts: qcom: sm8250: remove assigned-clock-rate property for mdp clk arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sm8250.dtsi | 9 ++------- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++ 5 files changed, 16 insertions(+), 28 deletions(-) -- 2.7.4

2 6

[pull] amdgpu, amdkfd, radeon drm-next-5.19
by Alex Deucher 22 Apr '22

22 Apr '22

Hi Dave, Daniel, More stuff for 5.19. The following changes since commit d68cf992ded575928cf4ddf7c64faff0d8dcce14: drm/amd/amdgpu: Remove static from variable in RLCG Reg RW (2022-04-14 15:29:20 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.19-2022-04-22 for you to fetch changes up to e15c9d06e9ad70df41285ca41d535de6215e0b21: drm/amd/amdgpu: Update PF2VF header (2022-04-21 16:00:14 -0400) ---------------------------------------------------------------- amd-drm-next-5.19-2022-04-22: amdgpu: - SMU message documentation update - Misc code cleanups - Documenation updates - PSP TA updates - Runtime PM regression fix - SR-IOV header cleanup - Misc fixes amdkfd: - TLB flush fixes - GWS fixes - CRIU GWS support radeon: - Misc code cleanups ---------------------------------------------------------------- Alex Deucher (2): drm/amdgpu: don't runtime suspend if there are displays attached (v3) drm/amdgpu/display: make hubp31_program_extended_blank static Bokun Zhang (3): drm/amd/amdgpu: Update MIT license in SRIOV msg header drm/amd/amdgpu: Properly indent PF2VF header drm/amd/amdgpu: Update PF2VF header Candice Li (2): drm/amdgpu: Use indirect buffer and save response status for TA load/invoke drm/amdgpu: Add debugfs TA load/unload/invoke support Darren Powell (1): amdgpu/pm: Clarify documentation of error handling in send_smc_mesg David Yat Sin (2): drm/amdkfd: Fix GWS queue count drm/amdkfd: CRIU add support for GWS queues Haowen Bai (1): drm/amd/display: Remove useless code Huang Rui (1): drm/amdgpu/pm: fix the null pointer while the smu is disabled Keita Suzuki (1): drm/amd/pm: fix double free in si_parse_power_table() Lang Yu (3): drm/amdkfd: move kfd_flush_tlb_after_unmap into kfd_priv.h drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too Revert "drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too" Miaoqian Lin (1): drm/amd/display: Fix memory leak in dcn21_clock_source_create Tales Lelo da Aparecida (3): drm/amd/display: make hubp1_wait_pipe_read_start() static Documentation/gpu: Add entries to amdgpu glossary MAINTAINERS: add docs entry to AMDGPU Tom Rix (2): drm/amd/display: add virtual_setup_stream_attribute decl to header drm/radeon/kms: change evergreen_default_state table from global to static Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 + MAINTAINERS | 1 + drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 105 ++++--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 54 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 26 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 308 +++++++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.h | 30 ++ drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 99 ++++--- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 - .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 83 +++--- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 10 +- .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 10 +- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 - drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 1 - .../gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c | 3 +- .../drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 + drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 2 +- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 +- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 8 +- drivers/gpu/drm/radeon/Makefile | 2 +- drivers/gpu/drm/radeon/evergreen_blit_shaders.c | 303 -------------------- drivers/gpu/drm/radeon/evergreen_blit_shaders.h | 278 ++++++++++++++++++- 27 files changed, 887 insertions(+), 477 deletions(-) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.h delete mode 100644 drivers/gpu/drm/radeon/evergreen_blit_shaders.c

1 0

[PATCH 0/2] drm: bridge: adv7511: CEC support for ADV7535
by Alvin Šipraga 22 Apr '22

22 Apr '22

From: Alvin Šipraga <alsi(a)bang-olufsen.dk> We have an ADV7535 which is nominally supported by this driver. These two patches fix up the driver to get CEC working too. The first adds the basic support by correcting some register offsets. The second addresses an issue we saw with CEC RX on the ADV7535. It hasn't been tested with the other chips (e.g. ADV7533), although it should be compatible. I'm sending it against drm-misc-next because the issue wasn't reported for other chips, and ADV7535 didn't have CEC support before. But feel free to take it into -fixes instead. Alvin Šipraga (2): drm: bridge: adv7511: enable CEC support for ADV7535 drm: bridge: adv7511: use non-legacy mode for CEC RX drivers/gpu/drm/bridge/adv7511/adv7511.h | 27 ++++- drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------ drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 22 +++- 3 files changed, 119 insertions(+), 46 deletions(-) -- 2.35.1

2 4

[PATCH V2 0/3] Update MediaTek disp_aal dt-binding
by Rex-BC Chen 22 Apr '22

22 Apr '22

V2: 1. Change to a proper subject. 2. Update dt-binding for MT8195. The disp_aal dt-binding needs to be updated for MT8183, MT8192 and MT8195. 1. Update dt-binding and dts for MT8183. 2. Update dt-binding for MT8192 and MT8195. This series is based on this series: "add display support for MediaTek SoC MT8186": Message id: 20220406030009.2357-1-rex-bc.chen(a)mediatek.com Rex-BC Chen (3): dt-bindings: display: mediatek: Update disp_aal binding for MT8183 arm64: dts: mt8183: Update disp_aal node compatible dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195 .../bindings/display/mediatek/mediatek,aal.yaml | 10 +++++----- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-- 2 files changed, 6 insertions(+), 7 deletions(-) -- 2.18.0

4 8

[PATCH v1] drm/bridge: Fix it6505 Kconfig DRM_DP_AUX_BUS dependency
by Robert Foss 22 Apr '22

22 Apr '22

it6505 depends on DRM_DP_AUX_BUS, the kconfig for it6505 should reflect this dependency using 'select'. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Reported-by: kernel test robot <lkp(a)intel.com> Suggested-by: Randy Dunlap <rdunlap(a)infradead.org> Signed-off-by: Robert Foss <robert.foss(a)linaro.org> --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index c08ccb4b332b..4cff9206045b 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -78,6 +78,7 @@ config DRM_DISPLAY_CONNECTOR config DRM_ITE_IT6505 tristate "ITE IT6505 DisplayPort bridge" depends on OF + select DRM_DP_AUX_BUS select DRM_DP_HELPER select DRM_KMS_HELPER select EXTCON -- 2.32.0

2 2

[PATCH 0/3] drm/format-helper: Support conversion to XRGB8888
by Thomas Zimmermann 22 Apr '22

22 Apr '22

(resending with dri-devel in cc) Support conversion from RGB565 and RGB888 to XRGB8888. This enables simpledrm to work with framebuffers of such formats. UEFI and/or Grub will usually set 32-bit output in XRGB8888 format. The issue can be reproduced by enabling simpledrm and requesting a console framebuffer of different format on the kernel command line; for example nomodeset video=1024x768-16 or nomodeset video=1024x768-24 Conversion helpers will do nothing in this case. Make this work by implementing the rsp conversion helpers. Also add a warning about unsupported format conversions. The patchset should also enable odd userspace configurations, such as running Xorg with 16- or 24-bit color depth. Thomas Zimmermann (3): drm/format-helper: Print warning on missing format conversion drm/format-helper: Add RGB888-to-XRGB8888 conversion drm/format-helper: Add RGB565-to-XRGB8888 conversion drivers/gpu/drm/drm_format_helper.c | 95 +++++++++++++++++++++++++++++ 1 file changed, 95 insertions(+) base-commit: d97978df553d768e457cb68c637b2b0a6188b87c -- 2.35.1

2 6

[PATCH] drm/msm/hdmi: check return value after calling platform_get_resource_byname()
by Yang Yingliang 22 Apr '22

22 Apr '22

It will cause null-ptr-deref if platform_get_resource_byname() returns NULL, we need check the return value. Fixes: c6a57a50ad56 ("drm/msm/hdmi: add hdmi hdcp support (V3)") Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- drivers/gpu/drm/msm/hdmi/hdmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index ec324352e862..07e2ad527af9 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -142,6 +142,10 @@ static struct hdmi *msm_hdmi_init(struct platform_device *pdev) /* HDCP needs physical address of hdmi register */ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, config->mmio_name); + if (!res) { + ret = -EINVAL; + goto fail; + } hdmi->mmio_phy_addr = res->start; hdmi->qfprom_mmio = msm_ioremap(pdev, config->qfprom_mmio_name); -- 2.25.1

3 2

Re: FG040346DSSWBG04 patch review
by Thomas Zimmermann 22 Apr '22

22 Apr '22

Hi Am 21.04.22 um 23:59 schrieb Marek Vasut: > Hello all, > > could either of you please have a look at these two panel patches ? > It is yet another DPI panel, but I would like to get some AB/RB on it > before applying. > > https://patchwork.freedesktop.org/patch/482306/ > https://patchwork.freedesktop.org/patch/482307/ Acked-by: Thomas Zimmermann <tzimmermann(a)suse.de> for both of them. Best regards Thomas > > Thank you > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev

2 1

[PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings
by kernel test robot 22 Apr '22

22 Apr '22

From: kernel test robot <lkp(a)intel.com> drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Sandor Yu <Sandor.yu(a)nxp.com> Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: kernel test robot <lkp(a)intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver :::::: branch date: 8 hours ago :::::: commit date: 2 days ago drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c @@ -77,7 +77,6 @@ static int audio_hw_params(struct device struct hdmi_codec_params *params) { struct snd_dw_hdmi *dw = dev_get_drvdata(dev); - int ret = 0; u8 ca; dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate); @@ -91,7 +90,7 @@ static int audio_hw_params(struct device params->iec.status[0] & IEC958_AES0_NONAUDIO); dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width); - return ret; + return 0; } static void audio_shutdown(struct device *dev, void *data) @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi bool enable, int direction) { struct snd_dw_hdmi *dw = dev_get_drvdata(dev); - int ret = 0; if (!enable) dw_hdmi_audio_enable(dw->data.hdmi); else dw_hdmi_audio_disable(dw->data.hdmi); - return ret; + return 0; } static int audio_get_eld(struct device *dev, void *data,

3 3

← Newer
1
...
34
35
36
37
38
39
40
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022