dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[PULL] drm-misc-fixes
by Maxime Ripard 22 Apr '22

22 Apr '22

Hi Daniel, Dave, Here's this week drm-misc-fixes PR. The two reverts for devm_drm_of_get_bridge are likely to bring more reverts in the future. Indeed, it introduced some code to fetch the panel automatically on device tree child nodes as well, but that broke any driver with a child node that wasn't a panel. The reversion seems to be the best course of action right now, but it was later pointed out that a number of drivers had been converted to rely on the new behaviour, so those are likely to be broken now. I'm not sure if it would be acceptable to merge them at this point, or delay the merge drm-misc-fixes until those drivers are fixed? Maxime drm-misc-fixes-2022-04-22: Two fixes for the raspberrypi panel initialisation, one fix for a logic inversion in radeon, a build and pm refcounting fix for vc4, two reverts for drm_of_get_bridge that caused a number of regression and a locking regression for amdgpu. The following changes since commit 1ecc0c09f19f8e10a2c52676f8ca47c28c9f73c7: dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory (2022-04-07 03:28:10 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2022-04-22 for you to fetch changes up to 94f4c4965e5513ba624488f4b601d6b385635aec: drm/amdgpu: partial revert "remove ctx->lock" v2 (2022-04-21 11:26:20 +0200) ---------------------------------------------------------------- Two fixes for the raspberrypi panel initialisation, one fix for a logic inversion in radeon, a build and pm refcounting fix for vc4, two reverts for drm_of_get_bridge that caused a number of regression and a locking regression for amdgpu. ---------------------------------------------------------------- Bjorn Andersson (2): Revert "drm: of: Properly try all possible cases for bridge/panel detection" Revert "drm: of: Lookup if child node has panel or bridge" Christian König (2): drm/radeon: fix logic inversion in radeon_sync_resv drm/amdgpu: partial revert "remove ctx->lock" v2 Dave Stevenson (2): drm/panel/raspberrypi-touchscreen: Avoid NULL deref if not initialised drm/panel/raspberrypi-touchscreen: Initialise the bridge in prepare Karol Herbst (1): dma-buf-map: remove renamed header file Miaoqian Lin (1): drm/vc4: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage Zack Rusin (1): drm/vmwgfx: Fix gem refcounting and memory evictions Zheng Bin (1): drm/vc4: Fix build error when CONFIG_DRM_VC4=y && CONFIG_RASPBERRYPI_FIRMWARE=m drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 1 + drivers/gpu/drm/drm_of.c | 86 +++---- .../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 13 +- drivers/gpu/drm/radeon/radeon_sync.c | 2 +- drivers/gpu/drm/vc4/Kconfig | 3 + drivers/gpu/drm/vc4/vc4_dsi.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 43 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 +- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 7 +- include/linux/dma-buf-map.h | 266 --------------------- 12 files changed, 95 insertions(+), 359 deletions(-) delete mode 100644 include/linux/dma-buf-map.h

1 0

[PATCH 0/4] Flat-CCS eviction enhancements
by Ramalingam C 22 Apr '22

22 Apr '22

Flat-CCS eviction enhancements. Ramalingam C (4): drm/i915/gt: GEM_BUG_ON unexpected NULL at scatterlist walking drm/i915/gt: optimize the ccs_sz calculation per chunk drm/i915/gt: Extend doc on Flat-CCS obj eviction uapi/drm/i915: Update the placement list impact on obj residency drivers/gpu/drm/i915/gt/intel_migrate.c | 78 ++++++++++++++----------- include/uapi/drm/i915_drm.h | 14 +++++ 2 files changed, 59 insertions(+), 33 deletions(-) -- 2.20.1

2 9

[PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)
by Xin Ji 22 Apr '22

22 Apr '22

Change bus-type define for DPI. Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") Signed-off-by: Xin Ji <xji(a)analogixsemi.com> --- .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index 0d38d6fe3983..4590186c4a0b 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -106,7 +106,7 @@ properties: remote-endpoint: true bus-type: - enum: [1, 5] + enum: [7] default: 1 data-lanes: true @@ -158,7 +158,7 @@ examples: reg = <0>; anx7625_in: endpoint { remote-endpoint = <&mipi_dsi>; - bus-type = <5>; + bus-type = <7>; data-lanes = <0 1 2 3>; }; }; -- 2.25.1

4 6

[RFC 0/2] Attach and Set vrr_enabled property
by Bhanuprakash Modem 22 Apr '22

22 Apr '22

This series will add a support to attach & set the vrr_enabled property for crtc based on the platform support and the request from userspace. And userspace can also query to get the status of "vrr_enabled". Test-with: 20220422075223.2792586-2-bhanuprakash.modem(a)intel.com Bhanuprakash Modem (2): drm/vrr: Attach vrr_enabled property to the drm crtc drm/i915/vrr: Attach and set drm crtc vrr_enabled property drivers/gpu/drm/drm_crtc.c | 44 +++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_crtc.c | 3 ++ drivers/gpu/drm/i915/display/intel_vrr.c | 7 +++- include/drm/drm_crtc.h | 4 +++ 4 files changed, 57 insertions(+), 1 deletion(-) -- 2.35.1

1 2

DMA-resv usage
by Christian König 22 Apr '22

22 Apr '22

Hi Daniel, only patch #2 had some significant changes. The rest ist pretty much the same except for the dropped exynos change and the added cleanup for the seqlock. Thanks, Christian.

8 40

[Bug 214991] New: VC4 DRM waiting for flip down makes UI freeze a while with kernel 5.15
by bugzilla-daemon＠bugzilla.kernel.org 22 Apr '22

22 Apr '22

https://bugzilla.kernel.org/show_bug.cgi?id=214991 Bug ID: 214991 Summary: VC4 DRM waiting for flip down makes UI freeze a while with kernel 5.15 Product: Drivers Version: 2.5 Kernel Version: 5.15 Hardware: ARM OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: jhp(a)endlessos.org Regression: No Created attachment 299547 --> https://bugzilla.kernel.org/attachment.cgi?id=299547&action=edit Full dmesg log I tested Linux mainline kernel 5.15 (aarch64) with enabled VC4 on RPi 4B. I notice UI freezes a while (about 10 seconds) some times. The kernel shows the error message during the time: [drm:drm_crtc_commit_wait] *ERROR* flip_done timed out [drm:drm_atomic_helper_wait_for_flip_done] *ERROR* [CRTC:68:crtc-3] flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:68:crtc-3] commit wait timed out [drm:drm_crtc_commit_wait] *ERROR* flip_done timed out vc4-drm gpu: [drm] *ERROR* Timed out waiting for commit It is easy to reproduce this issue by invoking GL related things, for example es2gears. After detail test, I found it is related to these commits: f3c420fe19f8 ("drm/vc4: kms: Convert to atomic helpers") 82faa3276012 ("drm/vc4: kms: Remove async modeset semaphore") This issue cannot be reproduced after I revert the commits. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

2 3

[git pull] drm fixes for 5.18-rc4
by Dave Airlie 22 Apr '22

22 Apr '22

Hi Linus, Extra quiet after Easter, only have minor i915 and msm pulls. However I haven't seen a PR from our misc tree in a little while, I've cc'ed all the suspects. Once that unblocks I expect a bit larger bunch of patches to arrive. Otherwise as I said, one msm revert and two i915 fixes. Regards, Dave. drm-fixes-2022-04-22: drm-fixes for 5.18-rc4 msm: - revert iommu change that broke some platforms. i915: - Unset enable_psr2_sel_fetch if PSR2 detection fails - Fix to detect when VRR is turned off from panel settings The following changes since commit b2d229d4ddb17db541098b83524d901257e93845: Linux 5.18-rc3 (2022-04-17 13:57:31 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-04-22 for you to fetch changes up to 70da382e1c5b9b2049c10abfd4489a40c1b60df0: Merge tag 'drm-msm-fixes-2022-04-20' of https://gitlab.freedesktop.org/drm/msm into drm-fixes (2022-04-22 09:25:47 +1000) ---------------------------------------------------------------- drm-fixes for 5.18-rc4 msm: - revert iommu change that broke some platforms. i915: - Unset enable_psr2_sel_fetch if PSR2 detection fails - Fix to detect when VRR is turned off from panel settings ---------------------------------------------------------------- Dave Airlie (2): Merge tag 'drm-intel-fixes-2022-04-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes Merge tag 'drm-msm-fixes-2022-04-20' of https://gitlab.freedesktop.org/drm/msm into drm-fixes Dmitry Baryshkov (1): drm/msm: Revert "drm/msm: Stop using iommu_present()" José Roberto de Souza (1): drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails Manasi Navare (1): drm/i915/display/vrr: Reset VRR capable property on a long hpd drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++----- drivers/gpu/drm/i915/display/intel_psr.c | 38 ++++++++++++++++++-------------- drivers/gpu/drm/msm/msm_drv.c | 2 +- 3 files changed, 33 insertions(+), 24 deletions(-)

2 1

[PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
by Nícolas F. R. A. Prado 22 Apr '22

22 Apr '22

The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external displays unable to show the image. Fix the issue by correcting the output format for mt8192 to be the same as for mt8183, fixing the usage of external displays for mt8192. Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data") Signed-off-by: Nícolas F. R. A. Prado <nfraprado(a)collabora.com> --- Changes in v2: - Added Fixes tag drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 4554e2de1430..e61cd67b978f 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), }; static int mtk_dpi_probe(struct platform_device *pdev) -- 2.35.1

4 3

[PATCH 1/2] drm/modes: Make width-mm/height-mm check in of_get_drm_panel_display_mode() mandatory
by Marek Vasut 21 Apr '22

21 Apr '22

All users of this function require width-mm/height-mm DT property to be present per their DT bindings, make width-mm/height-mm check mandatory. It is generally a good idea to specify panel dimensions, so userspace can configure e.g. scaling accordingly. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Christoph Niedermaier <cniedermaier(a)dh-electronics.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Dmitry Osipenko <digetx(a)gmail.com> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Noralf Trønnes <noralf(a)tronnes.org> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Thomas Zimmermann <tzimmermann(a)suse.de> To: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/drm_modes.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 6e7e10f16ec03..f0b000ddaddb5 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -735,8 +735,8 @@ EXPORT_SYMBOL_GPL(of_get_drm_display_mode); * @dmode: will be set to the return value * @bus_flags: information about pixelclk, sync and DE polarity * - * The Device Tree properties width-mm and height-mm will be read and set on - * the display mode if they are present. + * The mandatory Device Tree properties width-mm and height-mm + * are read and set on the display mode. * * Returns: * Zero on success, negative error code on failure. @@ -761,11 +761,11 @@ int of_get_drm_panel_display_mode(struct device_node *np, drm_bus_flags_from_videomode(&vm, bus_flags); ret = of_property_read_u32(np, "width-mm", &width_mm); - if (ret && ret != -EINVAL) + if (ret) return ret; ret = of_property_read_u32(np, "height-mm", &height_mm); - if (ret && ret != -EINVAL) + if (ret) return ret; dmode->width_mm = width_mm; -- 2.35.1

2 4

[PATCH] drm/msm: Fix null pointer dereferences without iommu
by Luca Weiss 21 Apr '22

21 Apr '22

Check if 'aspace' is set before using it as it will stay null without IOMMU, such as on msm8974. Fixes: bc2112583a0b ("drm/msm/gpu: Track global faults per address-space") Signed-off-by: Luca Weiss <luca(a)z3ntu.xyz> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ++++- drivers/gpu/drm/msm/msm_gpu.c | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 9efc84929be0..1219f71629a5 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -272,7 +272,10 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx, *value = 0; return 0; case MSM_PARAM_FAULTS: - *value = gpu->global_faults + ctx->aspace->faults; + if (ctx->aspace) + *value = gpu->global_faults + ctx->aspace->faults; + else + *value = gpu->global_faults; return 0; case MSM_PARAM_SUSPENDS: *value = gpu->suspend_count; diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index faf0c242874e..58eb3e1662cb 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -371,7 +371,8 @@ static void recover_worker(struct kthread_work *work) /* Increment the fault counts */ submit->queue->faults++; - submit->aspace->faults++; + if (submit->aspace) + submit->aspace->faults++; task = get_pid_task(submit->pid, PIDTYPE_PID); if (task) { -- 2.36.0

1 0

← Newer
1
...
35
36
37
38
39
40
41
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022