dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[PATCH v2, 0/3] add h264 decoder driver for mt8186
by Yunfei Dong 13 Apr '22

13 Apr '22

Firstly, add mt8186 compatible and private data, then add document for compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core architecture, need to add new interface for h264 hardware decoder. Patche 1 add mt8186 compatible and private data. Patche 2 add mt8186 compatible document. Patche 3 add h264 single core driver. --- This patch depends on "support for MT8192 decoder"[1] [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20220408120240.29… --- changed with v1: - rebase driver to the latest media_stage. --- Yunfei Dong (3): dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for mt8186 media: mediatek: vcodec: Support MT8186 media: mediatek: vcodec: add h264 decoder driver for mt8186 .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +++++++++++++++++- 5 files changed, 203 insertions(+), 2 deletions(-) -- 2.18.0

1 3

linux-next: build warnings after merge of the drm-misc tree
by Stephen Rothwell 13 Apr '22

13 Apr '22

Hi all, After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) produced these warnings: drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member '_edid' not described in 'drm_edid_header_is_valid' drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter 'raw_edid' description in 'drm_edid_header_is_valid' drivers/gpu/drm/drm_edid.c:1737: warning: Function parameter or member '_block' not described in 'drm_edid_block_valid' drivers/gpu/drm/drm_edid.c:1737: warning: Excess function parameter 'raw_edid' description in 'drm_edid_block_valid' Introduced by commits 6d987ddd6843 ("drm/edid: make drm_edid_header_is_valid() accept void pointer") 1f221284ab63 ("drm/edid: split drm_edid_block_valid() to check and act parts") -- Cheers, Stephen Rothwell

1 2

Re: [Bug 215807] Bad page state in process systemd-udevd
by Andrew Morton 12 Apr '22

12 Apr '22

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). hm, that's my third `bad page' report in three emails. But I'm not seeing a pattern - this one might be a DRM thing. On Tue, 12 Apr 2022 20:52:18 +0000 bugzilla-daemon(a)kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=215807 > > paragw (parag.lkml(a)gmail.com) changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |parag.lkml(a)gmail.com > > --- Comment #1 from paragw (parag.lkml(a)gmail.com) --- > Same issue on different hardware - multiple occurrences of below on 5.18.0-rc2+ > boot - > > [ 8.453363] amdgpu: Topology: Add CPU node > [ 8.467169] BUG: Bad page state in process systemd-udevd pfn:11b403 > [ 8.467180] fbcon: Taking over console > [ 8.467188] page:000000002cc06944 refcount:0 mapcount:0 > mapping:0000000000000000 index:0x3 pfn:0x11b403 > [ 8.467195] head:00000000aa25e58e order:9 compound_mapcount:0 > compound_pincount:0 > [ 8.467198] flags: 0x17ffffc0010000(head|node=0|zone=2|lastcpupid=0x1fffff) > [ 8.467205] raw: 0017ffffc0000000 fffff2da846d0001 fffff2da846d00c8 > 0000000000000000 > [ 8.467208] raw: 0000000000000000 0000000000000000 00000000ffffffff > 0000000000000000 > [ 8.467210] head: 0017ffffc0010000 0000000000000000 dead000000000122 > 0000000000000000 > [ 8.467212] head: 0000000000000000 0000000000000000 00000000ffffffff > 0000000000000000 > [ 8.467214] page dumped because: corrupted mapping in tail page > [ 8.467215] Modules linked in: amdgpu(+) rtsx_usb_sdmmc mmc_core > drm_ttm_helper ttm rtsx_usb hid_sensor_hub > iommu_v2 nvme crct10dif_pclmul crc32_pclmul gpu_sched crc32c_intel nvme_core > uas ccp drm_dp_helper usb_storag > e ghash_clmulni_intel amd_sfh ucsi_acpi sp5100_tco typec_ucsi typec > i2c_hid_acpi i2c_hid fuse ipmi_devintf ipm > i_msghandler > [ 8.467249] CPU: 2 PID: 416 Comm: systemd-udevd Not tainted 5.18.0-rc2+ #1 > [ 8.467254] Hardware name: ASUSTeK COMPUTER INC. MINIPC PN50/PN50, BIOS 0623 > 05/13/2021 > [ 8.467256] Call Trace: > [ 8.467260] <TASK> > [ 8.467265] dump_stack_lvl+0x48/0x5d > [ 8.467274] bad_page.cold+0x63/0x8f > [ 8.467280] free_tail_pages_check+0x144/0x180 > [ 8.467287] free_pcp_prepare+0x2e8/0x410 > [ 8.467292] free_unref_page+0x20/0x150 > [ 8.467298] __vunmap+0x217/0x2c0 > [ 8.467303] drm_fbdev_cleanup+0x5f/0xb0 > [ 8.467310] drm_fbdev_fb_destroy+0x19/0x30 > [ 8.467315] unregister_framebuffer+0x30/0x40 > [ 8.467321] drm_client_dev_unregister+0x6e/0xe0 > [ 8.467327] drm_dev_unregister+0x32/0x80 > [ 8.467332] drm_dev_unplug+0x25/0x40 > [ 8.467335] simpledrm_remove+0x15/0x20 > [ 8.467339] platform_remove+0x23/0x40 > [ 8.467344] device_release_driver_internal+0x1b3/0x210 > [ 8.467349] bus_remove_device+0xdc/0x150 > [ 8.467353] device_del+0x18f/0x3f0 > [ 8.467359] platform_device_del.part.0+0x13/0x70 > [ 8.467364] platform_device_unregister+0x20/0x30 > [ 8.467369] drm_aperture_detach_drivers+0xa1/0xd0 > [ 8.467376] drm_aperture_remove_conflicting_pci_framebuffers+0x43/0x80 > [ 8.467382] amdgpu_pci_probe+0x12a/0x3c0 [amdgpu] > [ 8.467833] local_pci_probe+0x45/0x80 > [ 8.467840] pci_device_probe+0xaf/0x200 > [ 8.467846] really_probe+0x1a1/0x370 > [ 8.467850] __driver_probe_device+0xfc/0x170 > [ 8.467854] driver_probe_device+0x1f/0x90 > [ 8.467858] __driver_attach+0xbf/0x1a0 > [ 8.467862] ? __device_attach_driver+0xe0/0xe0 > [ 8.467866] bus_for_each_dev+0x66/0x90 > [ 8.467870] bus_add_driver+0x152/0x1f0 > [ 8.467873] driver_register+0x8d/0xe0 > [ 8.467877] ? 0xffffffffc0518000 > [ 8.467880] do_one_initcall+0x48/0x200 > [ 8.467887] ? do_init_module+0x22/0x250 > [ 8.467892] ? kmem_cache_alloc_trace+0x165/0x2c0 > [ 8.467898] do_init_module+0x4a/0x250 > [ 8.467902] __do_sys_finit_module+0x93/0xf0 > [ 8.467911] do_syscall_64+0x3e/0x90 > [ 8.467917] entry_SYSCALL_64_after_hwframe+0x44/0xae > [ 8.467923] RIP: 0033:0x7fb9b13cd59d > [ 8.467928] Code: 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 > f8 48 89 f7 48 89 d6 48 89 ca 4d > 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 4b > 78 0e 00 f7 d8 64 89 01 48 > [ 8.467931] RSP: 002b:00007ffc90f5b558 EFLAGS: 00000246 ORIG_RAX: > 0000000000000139 > [ 8.467936] RAX: ffffffffffffffda RBX: 0000562a33e1bcd0 RCX: > 00007fb9b13cd59d > [ 8.467938] RDX: 0000000000000000 RSI: 00007fb9b152f43c RDI: > 0000000000000011 > [ 8.467940] RBP: 00007fb9b152f43c R08: 0000000000000000 R09: > 0000562a33e1bf90 > [ 8.467943] R10: 0000000000000011 R11: 0000000000000246 R12: > 0000000000020000 > [ 8.467945] R13: 0000562a33df8f90 R14: 0000000000000000 R15: > 0000562a33e1d540 > [ 8.467950] </TASK> > > -- > You may reply to this email to add a comment. > > You are receiving this mail because: > You are the assignee for the bug.

2 1

[PATCH v2 00/14] drm/sun4i: Allwinner D1 Display Engine 2.0 Support
by Samuel Holland 12 Apr '22

12 Apr '22

This series adds binding and driver support for Display Engine 2.0 variant found in the Allwinner D1. So far it has only been tested with HDMI. I will be sending the HDMI support series separately, because the hardware comes with a brand new custom HDMI PHY, which requires some refactoring to support cleanly. This series was tested on A33, D1 and H3. Changes in v2: - New patch: I/O helper portability - Use Jernej's patches for mixer mode setting. - Use an enumeration for the ccsc value. Jernej Skrabec (3): sun4i/drm: engine: Add mode_set callback sun4i/drm: backend: use mode_set engine callback sun4i/drm: sun8i: use mode_set engine callback Samuel Holland (11): dt-bindings: display: Separate clock item lists by compatible dt-bindings: display: Add D1 display engine compatibles drm/sun4i: Remove obsolete references to PHYS_OFFSET drm/sun4i: hdmi: Use more portable I/O helpers drm/sun4i: Allow building the driver on RISC-V drm/sun4i: Allow VI layers to be primary planes drm/sun4i: csc: Add support for the new MMIO layout drm/sun4i: Add support for D1 mixers drm/sun4i: Add support for D1 TCON TOP drm/sun4i: Add support for D1 TCONs drm/sun4i: Add compatible for D1 display engine .../allwinner,sun4i-a10-display-engine.yaml | 1 + .../display/allwinner,sun4i-a10-tcon.yaml | 2 + .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 + .../display/allwinner,sun8i-r40-tcon-top.yaml | 145 ++++++++++++------ drivers/gpu/drm/sun4i/Kconfig | 2 +- drivers/gpu/drm/sun4i/sun4i_backend.c | 40 ++--- drivers/gpu/drm/sun4i/sun4i_crtc.c | 1 + drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + drivers/gpu/drm/sun4i/sun4i_frontend.c | 3 - drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 4 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 + drivers/gpu/drm/sun4i/sun8i_csc.c | 7 +- drivers/gpu/drm/sun4i/sun8i_csc.h | 1 + drivers/gpu/drm/sun4i/sun8i_mixer.c | 74 +++++++-- drivers/gpu/drm/sun4i/sun8i_mixer.h | 14 +- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 15 +- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 30 ---- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 6 +- drivers/gpu/drm/sun4i/sunxi_engine.h | 27 ++++ 19 files changed, 263 insertions(+), 120 deletions(-) -- 2.35.1

2 15

Re: [PATCH 34/34] vfio/mdev: Remove mdev drvdata
by Kirti Wankhede 12 Apr '22

12 Apr '22

On 4/11/2022 7:44 PM, Christoph Hellwig wrote: > From: Jason Gunthorpe <jgg(a)nvidia.com> > > This is no longer used, remove it. > > All usages were moved over to either use container_of() from a vfio_device > or to use dev_drvdata() directly on the mdev. > > Signed-off-by: Jason Gunthorpe <jgg(a)nvidia.com> > Signed-off-by: Christoph Hellwig <hch(a)lst.de> > --- > include/linux/mdev.h | 9 --------- > 1 file changed, 9 deletions(-) > Reviewed-by: Kirti Wankhede <kwankhede(a)nvidia.com>

1 0

Re: [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file
by Kirti Wankhede 12 Apr '22

12 Apr '22

On 4/11/2022 7:44 PM, Christoph Hellwig wrote: > From: Jason Gunthorpe <jgg(a)nvidia.com> > > The device creator is supposed to use the dev.groups value to add sysfs > files before device_add is called, not call sysfs_create_files() after > device_add() returns. This creates a race with uevent delivery where the > extra attribute will not be visible. > > This was being done because the groups had been co-opted by the mdev > driver, now that prior patches have moved the driver's groups to the > struct device_driver the dev.group is properly free for use here. > > Signed-off-by: Jason Gunthorpe <jgg(a)nvidia.com> > Signed-off-by: Christoph Hellwig <hch(a)lst.de> > --- > drivers/vfio/mdev/mdev_core.c | 1 + > drivers/vfio/mdev/mdev_private.h | 2 ++ > drivers/vfio/mdev/mdev_sysfs.c | 19 ++++++++++--------- > 3 files changed, 13 insertions(+), 9 deletions(-) > Reviewed-by: Kirti Wankhede <kwankhede(a)nvidia.com>

1 0

Re: [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops
by Kirti Wankhede 12 Apr '22

12 Apr '22

On 4/11/2022 7:44 PM, Christoph Hellwig wrote: > From: Jason Gunthorpe <jgg(a)nvidia.com> > > The last useful member in this struct is the supported_type_groups, move > it to the mdev_driver and delete mdev_parent_ops. > > Replace it with mdev_driver as an argument to mdev_register_device() > > Signed-off-by: Jason Gunthorpe <jgg(a)nvidia.com> > Signed-off-by: Christoph Hellwig <hch(a)lst.de> > --- > .../driver-api/vfio-mediated-device.rst | 24 ++++-------------- > drivers/gpu/drm/i915/gvt/kvmgt.c | 7 +----- > drivers/s390/cio/vfio_ccw_ops.c | 7 +----- > drivers/s390/crypto/vfio_ap_ops.c | 9 ++----- > drivers/vfio/mdev/mdev_core.c | 13 ++++------ > drivers/vfio/mdev/mdev_private.h | 2 +- > drivers/vfio/mdev/mdev_sysfs.c | 6 ++--- > include/linux/mdev.h | 25 +++---------------- > samples/vfio-mdev/mbochs.c | 9 ++----- > samples/vfio-mdev/mdpy.c | 9 ++----- > samples/vfio-mdev/mtty.c | 9 ++----- > 11 files changed, 28 insertions(+), 92 deletions(-) > Reviewed-by: Kirti Wankhede <kwankhede(a)nvidia.com>

1 0

Re: [PATCH 31/34] vfio/mdev: Remove mdev_parent_ops dev_attr_groups
by Kirti Wankhede 12 Apr '22

12 Apr '22

On 4/11/2022 7:44 PM, Christoph Hellwig wrote: > From: Jason Gunthorpe <jgg(a)nvidia.com> > > This is only used by one sample to print a fixed string that is pointless. > > In general, having a device driver attach sysfs attributes to the parent > is horrific. This should never happen, and always leads to some kind of > liftime bug as it become very difficult for the sysfs attribute to go back > to any data owned by the device driver. > > Remove the general mechanism to create this abuse. > > Signed-off-by: Jason Gunthorpe <jgg(a)nvidia.com> > Signed-off-by: Christoph Hellwig <hch(a)lst.de> > --- > drivers/vfio/mdev/mdev_sysfs.c | 12 ++---------- > include/linux/mdev.h | 2 -- > samples/vfio-mdev/mtty.c | 30 +----------------------------- > 3 files changed, 3 insertions(+), 41 deletions(-) > Update Documentation/driver-api/vfio-mediated-device.rst where mtty sample code explained. Tree command output should be updated, i.e remove below 2 lines. |-- mtty_dev | `-- sample_mtty_dev Rest looks good to me. Thanks, Kirti

1 0

Re: [PATCH 30/34] vfio/mdev: Remove vfio_mdev.c
by Kirti Wankhede 12 Apr '22

12 Apr '22

On 4/11/2022 7:43 PM, Christoph Hellwig wrote: > From: Jason Gunthorpe <jgg(a)nvidia.com> > > Now that all mdev drivers directly create their own mdev_device driver and > directly register with the vfio core's vfio_device_ops this is all dead > code. > > Delete vfio_mdev.c and the mdev_parent_ops members that are connected to > it. > > Signed-off-by: Jason Gunthorpe <jgg(a)nvidia.com> > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Kirti Wankhede <kwankhede(a)nvidia.com>

1 0

[PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable
by Jakob Koschel 12 Apr '22

12 Apr '22

To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cW… [1] Signed-off-by: Jakob Koschel <jakobkoschel(a)gmail.com> --- drivers/video/fbdev/mmp/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c index 154127256a2c..03707461eced 100644 --- a/drivers/video/fbdev/mmp/core.c +++ b/drivers/video/fbdev/mmp/core.c @@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel); */ struct mmp_path *mmp_get_path(const char *name) { - struct mmp_path *path; - int found = 0; + struct mmp_path *path = NULL, *iter; mutex_lock(&disp_lock); - list_for_each_entry(path, &path_list, node) { - if (!strcmp(name, path->name)) { - found = 1; + list_for_each_entry(iter, &path_list, node) { + if (!strcmp(name, iter->name)) { + path = iter; break; } } mutex_unlock(&disp_lock); - return found ? path : NULL; + return path; } EXPORT_SYMBOL_GPL(mmp_get_path); base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275 -- 2.25.1

2 1

← Newer
1
...
56
57
58
59
60
61
62
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022