dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 06:06:01PM +0200, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 08:39:52AM -0300, Jason Gunthorpe wrote: > > I already looked into that for a while, it is a real mess too because > > of how the notifiers are used by the current drivers, eg gvt assumes > > the notifier is called during its open_device callback to setup its > > kvm. > > gvt very much expects kvm to be set before open and thus get the > cachup notifier, yes. And given that this is how qemu uses > the ioctl I think we can actually simplify this further and require > vfio_group_set_kvm to be called before open for s390/ap as well and > do away with this whole mess. Yeah, I was thinking about that too, but on the other hand I think it is completely wrong that gvt requires kvm at all. A vfio_device is not supposed to be tightly linked to KVM - the only exception possibly being s390.. Jason

1 0

[PULL] drm-intel-next
by Jani Nikula 13 Apr '22

13 Apr '22

Hi Dave & Daniel - The first drm/i915 pull for v5.19. BR, Jani. drm-intel-next-2022-04-13-1: drm/i915 feature pull for v5.19: Features and functionality: - Add support for new Tile 4 format on DG2 (Stan) - Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka) - Add support for new render and media compression formats on DG2 (Matt) - Support multiple eDP and LVDS native mode refresh rates (Ville) - Support static DRRS (Ville) - ATS-M platform info (Matt) - RPL-S PCI IDs (Tejas) - Extend DP HDR support to HSW+ (Uma) - Bump ADL-P DMC version to v2.16 (Madhumitha) - Let users disable PSR2 while enabling PSR1 (José) Refactoring and cleanups: - Massive DRRS and panel fixed mode refactoring and cleanups (Ville) - Power well refactoring and cleanup (Imre) - Clean up and refactor crtc readout and compute config (Ville) - Use kernel string helpers (Lucas) - Refactor gmbus pin lookups and allocation (Jani) - PCH display cleanups (Ville) - DPLL and DPLL manager refactoring (Ville) - Include and header refactoring (Jani, Tvrtko) - DMC abstractions (Jani) - Non-x86 build refactoring (Casey) - VBT parsing refactoring (Ville) - Bigjoiner refactoring (Ville) - Optimize plane, pfit, scaler, etc. programming using unlocked writes (Ville) - Split several register writes in commit to noarm+arm pairs (Ville) - Clean up SAGV handling (Ville) - Clean up bandwidth and ddb allocation (Ville) - FBC cleanups (Ville) Fixes: - Fix native HDMI and DP HDMI DFP clock limits on deep color/4:2:0 (Ville) - Fix DMC firmware platform check (Lucas) - Fix cursor coordinates on bigjoiner secondary (Ville) - Fix MSO vs. bigjoiner timing confusion (Ville) - Fix ADL-P eDP voltage swing (José) - Fix VRR capability property update (Manasi) - Log DG2 SNPS PHY calibration errors (Matt, Lucas) - Fix PCODE request status checks (Stan) - Fix uncore unclaimed access warnings (Lucas) - Fix VBT new max TMDS clock parsing (Shawn) - Fix ADL-P non-existent underrun recovery (Swathi Dhanavanthri) - Fix ADL-N stepping info (Tejas) - Fix DPT mapping flags to contiguous (Stan) - Fix DG2 max display bandwidth (Vinod) - Fix DP low voltage SKU checks (Ankit) - Fix RPL-S VT-d translation enable via quirk (Tejas) - Fixes to PSR2 (José) - Fix PIPE_MBUS_DBOX_CTL programming (José) - Fix LTTPR capability read/check on DP 1.2 (Imre) - Fix ADL-P register corruption after DDI clock enabling (Imre) - Fix ADL-P MBUS DBOX BW and B credits (Caz) Merges: - Backmerge drm-next (Rodrigo, Jani) The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17: Linux 5.18-rc1 (2022-04-03 14:08:21 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2022-04-13-1 for you to fetch changes up to b39d2c6202426b560641e5800c5523851b5db586: drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush (2022-04-13 17:20:49 +0300) ---------------------------------------------------------------- drm/i915 feature pull for v5.19: Features and functionality: - Add support for new Tile 4 format on DG2 (Stan) - Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka) - Add support for new render and media compression formats on DG2 (Matt) - Support multiple eDP and LVDS native mode refresh rates (Ville) - Support static DRRS (Ville) - ATS-M platform info (Matt) - RPL-S PCI IDs (Tejas) - Extend DP HDR support to HSW+ (Uma) - Bump ADL-P DMC version to v2.16 (Madhumitha) - Let users disable PSR2 while enabling PSR1 (José) Refactoring and cleanups: - Massive DRRS and panel fixed mode refactoring and cleanups (Ville) - Power well refactoring and cleanup (Imre) - Clean up and refactor crtc readout and compute config (Ville) - Use kernel string helpers (Lucas) - Refactor gmbus pin lookups and allocation (Jani) - PCH display cleanups (Ville) - DPLL and DPLL manager refactoring (Ville) - Include and header refactoring (Jani, Tvrtko) - DMC abstractions (Jani) - Non-x86 build refactoring (Casey) - VBT parsing refactoring (Ville) - Bigjoiner refactoring (Ville) - Optimize plane, pfit, scaler, etc. programming using unlocked writes (Ville) - Split several register writes in commit to noarm+arm pairs (Ville) - Clean up SAGV handling (Ville) - Clean up bandwidth and ddb allocation (Ville) - FBC cleanups (Ville) Fixes: - Fix native HDMI and DP HDMI DFP clock limits on deep color/4:2:0 (Ville) - Fix DMC firmware platform check (Lucas) - Fix cursor coordinates on bigjoiner secondary (Ville) - Fix MSO vs. bigjoiner timing confusion (Ville) - Fix ADL-P eDP voltage swing (José) - Fix VRR capability property update (Manasi) - Log DG2 SNPS PHY calibration errors (Matt, Lucas) - Fix PCODE request status checks (Stan) - Fix uncore unclaimed access warnings (Lucas) - Fix VBT new max TMDS clock parsing (Shawn) - Fix ADL-P non-existent underrun recovery (Swathi Dhanavanthri) - Fix ADL-N stepping info (Tejas) - Fix DPT mapping flags to contiguous (Stan) - Fix DG2 max display bandwidth (Vinod) - Fix DP low voltage SKU checks (Ankit) - Fix RPL-S VT-d translation enable via quirk (Tejas) - Fixes to PSR2 (José) - Fix PIPE_MBUS_DBOX_CTL programming (José) - Fix LTTPR capability read/check on DP 1.2 (Imre) - Fix ADL-P register corruption after DDI clock enabling (Imre) - Fix ADL-P MBUS DBOX BW and B credits (Caz) Merges: - Backmerge drm-next (Rodrigo, Jani) ---------------------------------------------------------------- Animesh Manna (1): drm/i915/dsb: modified to drm_info in dsb_prepare() Ankit Nautiyal (2): drm/i915/display: Remove check for low voltage sku for max dp source rate drm/i915/intel_combo_phy: Print I/O voltage info Ashutosh Dixit (1): drm/i915/pmu: Drop redundant IS_VALLEYVIEW check in __get_rc6() Casey Bowman (1): drm/i915: Split i915_run_as_guest into x86 and non-x86 Caz Yokoyama (1): drm/i915/display/adlp: Adjust MBUS DBOX BW and B credits Changcheng Deng (1): drm/i915/dsi: use min_t() to make code cleaner Colin Ian King (1): drm/i915: make a handful of read-only arrays static const Imre Deak (10): drm/i915: Fix the VDSC_PW2 power domain enum value drm/i915: Sanitize open-coded power well enable()/disable() calls drm/i915: Remove redundant state verification during TypeC AUX power well disabling drm/i915: Move i915_power_well_regs struct into i915_power_well_ops drm/i915: Move power well get/put/enable/disable functions to a new file drm/i915: Add function to call a power well's sync_hw() hook drm/i915: Add functions to get a power well's state/name/domains/mask/refcount drm/i915: Move intel_display_power_well_is_enabled() to intel_display_power_well.c drm/i915: Add a DP1.2 compatible way to read LTTPR capabilities drm/i915/adlp: Fix register corruption after DDI clock enabling Jani Nikula (23): drm/i915/wm: use REG_FIELD_{PREP,GET} for PLANE_WM_BLOCKS_MASK drm/i915/gmbus: combine gmbus pin lookups to one function drm/i915/gmbus: reduce gmbus pin lookups in gmbus setup drm/i915/gmbus: pass gpio reg to intel_gpio_setup() drm/i915/gmbus: alloc intel_gmbus dynamically drm/i915: include linux/highmem.h and linux/swap.h where needed drm/i915/gmbus: move some local bus variables within loops drm/i915/gmbus: use to_intel_gmbus() instead of open coding x86/gpu: include drm/i915_pciids.h directly in early quirks drm/i915: move i915_gem_object_needs_bit17_swizzle() to i915_gem_tiling.[ch] drm/i915: include uapi/drm/i915_drm.h directly where needed drm/i915/sdvo: prefer __packed over __attribute__((packed)) drm/i915/dmc: simplify intel_dmc_load_program() conditions drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c drm/i915/dmc: move dmc debugfs to intel_dmc.c drm/i915/dmc: fix i915_reg_t usage drm/i915/audio: unify audio codec enable/disable debug logging drm/i915/audio: move has_audio checks to within codec enable/disable drm/i915/dp: make DSC usage logging actually useful drm/i915/dmc: abstract GPU error state dump drm/i915/dmc: hide DMC version macros drm/i915/dmc: split out dmc registers to a separate file Merge drm/drm-next into drm-intel-next José Roberto de Souza (13): drm/i915/display: Allow users to disable PSR2 drm/i915/display/adlp: Update eDP voltage swing table drm/i915/display: Fix HPD short pulse handling for eDP drm/i915/display: Do not re-enable PSR after it was marked as not reliable drm/i915/display/adlp: More voltage swing table updates docs: gpu: i915.rst: Fix DRRS documentation drm/i915/display/tgl+: Set default values for all registers in PIPE_MBUS_DBOX_CTL drm/i915/display/adlp: Fix programing of PIPE_MBUS_DBOX_CTL drm/i915/display: Add HAS_MBUS_JOINING drm/i915/display/psr: Set partial frame enable when forcing full frame fetch drm/i915/display/psr: Lock and unlock PSR around pipe updates drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations drm/i915/display: Fix warnings about PSR lock not held Jouni Högander (1): drm/i915/psr: Set "SF Partial Frame Enable" also on full update Juha-Pekka Heikkilä (1): drm/i915/dg2: Add support for DG2 clear color compression Lee Shawn C (1): drm/i915: update new TMDS clock setting defined by VBT Lucas De Marchi (8): drm/i915/dmc: Do not try loading wrong DMC version drm/i915: Use str_yes_no() drm/i915: Use str_enable_disable() drm/i915: Use str_enabled_disabled() drm/i915: Use str_on_off() drm/i915/uncore: Warn on previous unclaimed accesses drm/i915/uncore: Warn only if unclaimed access remains flagged drm/i915/dg2: Do not explode on phy calibration error Madhumitha Tolakanahalli Pradeep (1): drm/i915/dmc: Update DMC to v2.16 on ADL-P Manasi Navare (1): drm/i915/display/vrr: Reset VRR capable property on a long hpd Matt Roper (4): drm/i915/dg2: Skip output init on PHY calibration failure drm/i915/ats-m: add ATS-M platform info drm/fourcc: Introduce format modifiers for DG2 render and media compression drm/i915/dg2: Add support for DG2 render and media compression Mika Kahola (1): drm/fourcc: Introduce format modifier for DG2 clear color Rodrigo Vivi (1): Merge drm/drm-next into drm-intel-next Stanislav Lisovskiy (5): drm/i915: Introduce new Tile 4 format drm/i915/dg2: Tile 4 plane format support drm/i915/dg2: Use I915_BO_ALLOC_CONTIGUOUS flag for DPT drm/i915: Fix skl_pcode_try_request function drm/i915: Swap ret and status returned from skl_pcode_request Swathi Dhanavanthri (1): drm/i915/display/adlp: Remove code related to underrun recovery Tejas Upadhyay (3): iommu/vt-d: Add RPLS to quirk list to skip TE disabling drm/i915/adl-n: Add stepping info drm/i915: Add RPL-S PCI IDs Tvrtko Ursulin (1): drm/i915: Move intel_vtd_active and run_as_guest to i915_utils Uma Shankar (1): drm/i915/display: Extend DP HDR support to hsw+ Ville Syrjälä (144): drm/i915: Optimize icl+ universal plane programming drm/i915: Make skl+ universal plane registers unlocked drm/i915: Make cursor plane registers unlocked drm/i915: Make most pre-skl primary plane registers unlocked drm/i915: Make pre-skl sprite plane registers unlocked drm/i915: s/JSP2/ICP2/ PCH drm/i915: Avoid negative shift due to bigjoiner_pipes==0 drm/i915: Fix cursor coordinates on bigjoiner slave drm/i915: Remove nop bigjoiner state copy drm/i915: Rename variables in intel_crtc_compute_config() drm/i915: Extract intel_splitter_adjust_timings() drm/i915: Extract intel_bigjoiner_adjust_timings() drm/i915: Extract intel_crtc_compute_pipe_src() drm/i915: Extract intel_crtc_compute_pipe_mode() drm/i915: Fix MSO vs. bigjoiner timings confusion drm/i915: Don't skip ddb allocation if data_rate==0 drm/i915: Check async flip capability early on drm/i915: Fix the async flip wm0/ddb optimization drm/i915: Pimp async flip debugs drm/i915: Move framestart_delay to crtc_state drm/i915: Remove framestart_delay sanitation drm/i915: Relocate ibx pch port sanitation code drm/i915: Relocate a few more pch transcoder bits drm/i915: Nuke skl_wrpll_context_init() drm/i915: Move a bunch of stuff into rodata from the stack drm/i915: Clean up some struct/array initializers drm/i915: Remove bxt m2_frac_en drm/i915: Use designated initializers for bxt_dp_clk_val[] drm/i915: Start tracking PIPESRC as a drm_rect drm/i915: Eliminate bigjoiner boolean drm/i915: Use bigjoiner_pipes more drm/i915: Remove leftover cnl SAGV block time drm/i915: Make the PIPESRC rect relative to the entire bigjoiner area drm/i915: Store the /5 target clock in struct dpll on vlv/chv drm/i915: Remove redundant/wrong comments drm/i915: Clean up bxt/glk PLL registers drm/i915: Store the m2 divider as a whole in bxt_clk_div drm/i915: Replace bxt_clk_div with struct dpll drm/i915: Replace hand rolled bxt vco calculation with chv_calc_dpll_params() drm/i915: Populate bxt/glk DPLL clock limits a bit more drm/i915: Remove struct dp_link_dpll drm/i915: Fix up some DRRS type checks drm/i915: Constify intel_drrs_init() args drm/i915: Pimp DRRS debugs drm/i915: Read DRRS MSA timing delay from VBT drm/i915: Program MSA timing delay on ilk/snb/ivb drm/i915: Polish drrs type enum drm/i915: Clean up DRRS refresh rate enum drm/i915: Rename PIPECONF refresh select bits drm/i915/dsi: Pass fixed_mode to *_dsi_add_properties() drm/i915/sdvo: Pass the requesed mode to intel_sdvo_create_preferred_input_timing() drm/i915/lvds: Pass fixed_mode to compute_is_dual_link_lvds() drm/i915: Simplify intel_panel_info() drm/i915: Nuke dev_priv->drrs.type drm/i915: Introduce intel_panel_{fixed,downclock}_mode() drm/i915: Introduce intel_panel_get_modes() drm/i915: Introduce intel_panel_preferred_fixed_mode() drm/i915: Introduce intel_panel_drrs_type() drm/i915: Introduce intel_drrs_type_str() drm/i915: Eliminate the intel_dp dependency from DRRS drm/i915: Stash DRRS state under intel_crtc drm/i915: Move DRRS enable/disable higher up drm/i915: Enable eDP DRRS on ilk/snb port A drm/i915: Implement static DRRS drm/i915: Convert fixed_mode/downclock_mode into a list drm/i915: Use drm_mode_copy() drm/i915: Put the downclock_mode check back into can_enable_drrs() drm/i915: Add missing tab to DRRS debugfs drm/i915: Fix DRRS frontbuffer_bits handling drm/i915: Determine DRRS frontbuffer_bits ahead of time drm/i915: Don't cancel/schedule drrs work if the pipe wasn't affected drm/i915: Schedule DRRS work from intel_drrs_enable() drm/i915: Do DRRS disable/enable during pre/post_plane_update() drm/i915: Deal with bigjoiner vs. DRRS drm/i915: Reject unsupported TMDS rates on ICL+ drm/i915: Treat SAGV block time 0 as SAGV disabled drm/i915: Rework SAGV block time probing drm/i915: Probe whether SAGV works on pre-icl drm/i915: Reject excessive SAGV block time drm/i915: Rename pre-icl SAGV enable/disable functions drm/i915: Fix PSF GV point mask when SAGV is not possible drm/i915: Unconfuses QGV vs. PSF point masks drm/i915: Rename QGV request/response bits drm/i915: Tweak plane ddb allocation tracking drm/i915: Split plane data_rate into data_rate+data_rate_y drm/i915: Pre-calculate plane relative data rate drm/i915: Remove total[] and uv_total[] from ddb allocation drm/i915: Nuke intel_bw_calc_min_cdclk() drm/i915: Round up when calculating display bandwidth requirements drm/i915: Properly write lock bw_state when it changes drm/i915: Fix DBUF bandwidth vs. cdclk handling drm/i915: Add "maximum pipe read bandwidth" checks drm/i915: s/enable/active/ for DRRS drm/i915: Remove locks around skl+ scaler programming drm/i915: Make ilk+ pfit regiser unlocked drm/i915: Split color_commit() into noarm+arm pair drm/i915: Split pipe+output CSC programming to noarm+arm pair drm/i915: Pass intel_connector to intel_panel_{init,fini}() drm/i915: Use DRM_MODE_FMT+DRM_MODE_ARG() drm/i915: Extract intel_edp_add_properties() drm/i915: Use intel_panel_preferred_fixed_mode() more drm/i915: Rename intel_panel_vbt_fixed_mode() drm/i915: Extract intel_panel_vbt_sdvo_fixed_mode() drm/i915: Extract intel_panel_encoder_fixed_mode() drm/i915: Use intel_panel_edid_fixed_mode() for sdvo drm/i915: Change SDVO fixed mode handling drm/i915: Extract intel_edp_has_drrs() drm/i915: Put fixed modes directly onto the panel's fixed_modes list drm/i915: Refactor non-EDID fixed mode duplication drm/i915: Nuke intel_drrs_init() drm/i915: Combine the EDID fixed_mode+downclock_mode lookup into one drm/i915: Stop duplicating the EDID fixed/downclock modes drm/i915: Allow an arbitrary number of downclock modes drm/i915: Allow higher refresh rate alternate fixed modes drm/i915: Move intel_drrs_compute_config() into intel_dp.c drm/i915: Allow static DRRS on all eDP ports drm/i915: Allow static DRRS on LVDS drm/i915: Use drm_connector_attach_hdr_output_metadata_property() drm/i915: Remove dead members from dev_priv drm/i915/bios: Extract struct lvds_lfp_data_ptr_table drm/i915/dp: Extract intel_dp_tmds_clock_valid() drm/i915/dp: Respect the sink's max TMDS clock when dealing with DP->HDMI DFPs drm/i915/dp: Extract intel_dp_has_audio() drm/i915/dp: s/intel_dp_hdmi_ycbcr420/intel_dp_is_ycbcr420/ drm/i915/dp: Reorder intel_dp_compute_config() a bit drm/i915/dp: Pass around intel_connector rather than drm_connector drm/i915/dp: Make intel_dp_output_format() usable for "4:2:0 also" modes drm/i915/dp: Rework HDMI DFP TMDS clock handling drm/i915/dp: Add support for "4:2:0 also" modes for DP drm/i915/dp: Duplicate native HDMI TMDS clock limit handling for DP HDMI DFPs drm/i915/dp: Fix DFP rgb->ycbcr conversion matrix drm/i915/bios: Use the cached BDB version drm/i915/bios: Make copies of VBT data blocks drm/i915/bios: Use the copy of the LFP data table always drm/i915/bios: Validate LFP data table pointers drm/i915/bios: Trust the LFP data pointers drm/i915/bios: Validate the panel_name table drm/i915/fbc: Eliminate possible_framebuffer_bits drm/i915/fbc: Streamline frontbuffer busy bits handling drm/i915/fbc: Skip nuke when flip is pending drm/i915: Remove remaining locks from i9xx plane udpates drm/i915/fbc: Remove intel_fbc_global_disable() drm/i915/fbc: Introduce intel_fbc_sanitize() drm/i915/fbc: Call intel_fbc_activate() directly from frontbuffer flush Vinod Govindapillai (1): drm/i915: Handle the DG2 max bw properly Documentation/gpu/i915.rst | 14 +- arch/x86/kernel/early-quirks.c | 1 + drivers/gpu/drm/dp/drm_dp.c | 58 +- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/g4x_dp.c | 73 +- drivers/gpu/drm/i915/display/g4x_hdmi.c | 36 +- drivers/gpu/drm/i915/display/i9xx_plane.c | 24 +- drivers/gpu/drm/i915/display/icl_dsi.c | 16 +- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 140 ++-- drivers/gpu/drm/i915/display/intel_atomic_plane.h | 3 +- drivers/gpu/drm/i915/display/intel_audio.c | 45 +- drivers/gpu/drm/i915/display/intel_backlight.c | 3 +- drivers/gpu/drm/i915/display/intel_bios.c | 506 +++++++++---- drivers/gpu/drm/i915/display/intel_bw.c | 312 +++++--- drivers/gpu/drm/i915/display/intel_bw.h | 12 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 96 +-- drivers/gpu/drm/i915/display/intel_cdclk.h | 2 + drivers/gpu/drm/i915/display/intel_color.c | 95 ++- drivers/gpu/drm/i915/display/intel_color.h | 3 +- drivers/gpu/drm/i915/display/intel_combo_phy.c | 35 +- drivers/gpu/drm/i915/display/intel_connector.c | 4 +- drivers/gpu/drm/i915/display/intel_crtc.c | 8 +- drivers/gpu/drm/i915/display/intel_cursor.c | 27 +- drivers/gpu/drm/i915/display/intel_ddi.c | 32 +- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 40 +- drivers/gpu/drm/i915/display/intel_display.c | 784 ++++++++++----------- drivers/gpu/drm/i915/display/intel_display.h | 3 +- .../gpu/drm/i915/display/intel_display_debugfs.c | 302 +++----- drivers/gpu/drm/i915/display/intel_display_power.c | 541 +++----------- drivers/gpu/drm/i915/display/intel_display_power.h | 37 +- .../drm/i915/display/intel_display_power_well.c | 113 +++ .../drm/i915/display/intel_display_power_well.h | 153 ++++ drivers/gpu/drm/i915/display/intel_display_trace.h | 9 +- drivers/gpu/drm/i915/display/intel_display_types.h | 43 +- drivers/gpu/drm/i915/display/intel_dmc.c | 131 +++- drivers/gpu/drm/i915/display/intel_dmc.h | 10 +- drivers/gpu/drm/i915/display/intel_dmc_regs.h | 30 + drivers/gpu/drm/i915/display/intel_dp.c | 581 +++++++++------ .../gpu/drm/i915/display/intel_dp_link_training.c | 31 +- drivers/gpu/drm/i915/display/intel_dp_mst.c | 8 +- drivers/gpu/drm/i915/display/intel_dpll.c | 44 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 144 ++-- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/display/intel_drrs.c | 406 ++++------- drivers/gpu/drm/i915/display/intel_drrs.h | 20 +- drivers/gpu/drm/i915/display/intel_dsb.c | 7 +- drivers/gpu/drm/i915/display/intel_dsi.c | 24 +- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 7 +- drivers/gpu/drm/i915/display/intel_dvo.c | 49 +- drivers/gpu/drm/i915/display/intel_fb.c | 68 +- drivers/gpu/drm/i915/display/intel_fb.h | 1 + drivers/gpu/drm/i915/display/intel_fbc.c | 96 ++- drivers/gpu/drm/i915/display/intel_fbc.h | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 142 ++-- drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + drivers/gpu/drm/i915/display/intel_hdmi.c | 3 +- drivers/gpu/drm/i915/display/intel_lvds.c | 57 +- drivers/gpu/drm/i915/display/intel_overlay.c | 22 +- drivers/gpu/drm/i915/display/intel_panel.c | 359 ++++++---- drivers/gpu/drm/i915/display/intel_panel.h | 33 +- drivers/gpu/drm/i915/display/intel_pch_display.c | 99 ++- drivers/gpu/drm/i915/display/intel_pch_display.h | 10 + drivers/gpu/drm/i915/display/intel_plane_initial.c | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 183 ++++- drivers/gpu/drm/i915/display/intel_psr.h | 5 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 88 +-- drivers/gpu/drm/i915/display/intel_snps_phy.c | 8 +- drivers/gpu/drm/i915/display/intel_sprite.c | 51 +- drivers/gpu/drm/i915/display/intel_tv.c | 12 +- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 21 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 24 +- drivers/gpu/drm/i915/display/intel_vrr.c | 4 +- drivers/gpu/drm/i915/display/skl_scaler.c | 22 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 266 +++++-- drivers/gpu/drm/i915/display/vlv_dsi.c | 15 +- drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 8 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 2 + drivers/gpu/drm/i915/gem/i915_gem_object.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_phys.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_region.c | 2 + drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 8 + drivers/gpu/drm/i915/gem/i915_gem_tiling.h | 2 + drivers/gpu/drm/i915/gem/i915_gemfs.c | 3 +- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 10 +- .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 7 +- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 1 + drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 11 +- .../gpu/drm/i915/gt/intel_execlists_submission.c | 7 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 5 +- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 3 +- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 54 +- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 - drivers/gpu/drm/i915/gt/intel_gtt.c | 12 + drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +- drivers/gpu/drm/i915/gt/intel_reset.c | 3 +- drivers/gpu/drm/i915/gt/intel_rps.c | 13 +- drivers/gpu/drm/i915/gt/intel_sseu.c | 9 +- drivers/gpu/drm/i915/gt/intel_sseu_debugfs.c | 10 +- drivers/gpu/drm/i915/gt/selftest_timeline.c | 3 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 5 +- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 +- drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 6 +- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 3 +- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 14 +- drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 20 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + drivers/gpu/drm/i915/gvt/handlers.c | 20 +- drivers/gpu/drm/i915/i915_cmd_parser.c | 2 + drivers/gpu/drm/i915/i915_debugfs.c | 18 +- drivers/gpu/drm/i915/i915_driver.c | 5 +- drivers/gpu/drm/i915/i915_driver.h | 4 + drivers/gpu/drm/i915/i915_drv.h | 122 +--- drivers/gpu/drm/i915/i915_gpu_error.c | 21 +- drivers/gpu/drm/i915/i915_gpu_error.h | 6 + drivers/gpu/drm/i915/i915_params.c | 7 +- drivers/gpu/drm/i915/i915_pci.c | 39 +- drivers/gpu/drm/i915/i915_pmu.c | 5 +- drivers/gpu/drm/i915/i915_reg.h | 133 ++-- drivers/gpu/drm/i915/i915_suspend.c | 4 - drivers/gpu/drm/i915/i915_utils.c | 11 + drivers/gpu/drm/i915/i915_utils.h | 37 +- drivers/gpu/drm/i915/intel_device_info.c | 11 +- drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_dram.c | 10 +- drivers/gpu/drm/i915/intel_memory_region.c | 2 + drivers/gpu/drm/i915/intel_memory_region.h | 2 +- drivers/gpu/drm/i915/intel_pch.c | 3 +- drivers/gpu/drm/i915/intel_pcode.c | 4 +- drivers/gpu/drm/i915/intel_pm.c | 526 +++++++------- drivers/gpu/drm/i915/intel_pm.h | 1 + drivers/gpu/drm/i915/intel_step.c | 7 + drivers/gpu/drm/i915/intel_uncore.c | 27 +- drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 4 +- drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 - drivers/gpu/drm/i915/selftests/i915_active.c | 3 +- drivers/gpu/drm/i915/vlv_suspend.c | 3 +- drivers/iommu/intel/iommu.c | 2 +- include/drm/dp/drm_dp_helper.h | 2 + include/drm/i915_drm.h | 3 +- include/drm/i915_pciids.h | 4 +- include/uapi/drm/drm_fourcc.h | 47 ++ 149 files changed, 4340 insertions(+), 3676 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_well.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_well.h create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_regs.h -- Jani Nikula, Intel Open Source Graphics Center

1 0

[PATCH] fbcon: Fix delayed takeover locking
by Daniel Vetter 13 Apr '22

13 Apr '22

I messed up the delayed takover path in the locking conversion in 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). Fix it by re-extracting the lockless function and using it in the delayed takeover path, where we need to hold the lock already to iterate over the list of already registered fb. Well the current code still is broken in there (since the list is protected by a registration_lock, which we can't take here because it nests the other way round with console_lock), but in the future this will be a list protected by console_lock when this is all sorted out. Reported-by: Nathan Chancellor <nathan(a)kernel.org> Cc: Nathan Chancellor <nathan(a)kernel.org> Fixes: 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister") Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Thomas Zimmermann <tzimmermann(a)suse.de> Cc: Du Cheng <ducheng2(a)gmail.com> Cc: Claudio Suarez <cssk(a)net-c.es> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: Zheyu Ma <zheyuma97(a)gmail.com> Cc: Guenter Roeck <linux(a)roeck-us.net> Cc: Helge Deller <deller(a)gmx.de> Cc: Geert Uytterhoeven <geert(a)linux-m68k.org> Cc: Javier Martinez Canillas <javierm(a)redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/video/fbdev/core/fbcon.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 6a7d470beec7..b4e43b39d9a8 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -2772,7 +2772,6 @@ static void fbcon_unbind(void) static inline void fbcon_unbind(void) {} #endif /* CONFIG_VT_HW_CONSOLE_BINDING */ -/* called with console_lock held */ void fbcon_fb_unbind(struct fb_info *info) { int i, new_idx = -1; @@ -2822,7 +2821,6 @@ void fbcon_fb_unbind(struct fb_info *info) console_unlock(); } -/* called with console_lock held */ void fbcon_fb_unregistered(struct fb_info *info) { int i, idx; @@ -2928,14 +2926,11 @@ MODULE_PARM_DESC(lockless_register_fb, "Lockless framebuffer registration for debugging [default=off]"); /* called with console_lock held */ -int fbcon_fb_registered(struct fb_info *info) +static int do_fb_registered(struct fb_info *info) { int ret = 0, i, idx; - if (!lockless_register_fb) - console_lock(); - else - atomic_inc(&ignore_console_lock_warning); + WARN_CONSOLE_UNLOCKED(); fbcon_registered_fb[info->node] = info; fbcon_num_registered_fb++; @@ -2945,7 +2940,7 @@ int fbcon_fb_registered(struct fb_info *info) if (deferred_takeover) { pr_info("fbcon: Deferring console take-over\n"); - goto out; + return 0; } if (info_idx == -1) { @@ -2965,7 +2960,20 @@ int fbcon_fb_registered(struct fb_info *info) } } -out: + return ret; +} + +int fbcon_fb_registered(struct fb_info *info) +{ + int ret; + + if (!lockless_register_fb) + console_lock(); + else + atomic_inc(&ignore_console_lock_warning); + + ret = do_fb_registered(info); + if (!lockless_register_fb) console_unlock(); else @@ -3280,7 +3288,7 @@ static void fbcon_register_existing_fbs(struct work_struct *work) logo_shown = FBCON_LOGO_DONTSHOW; fbcon_for_each_registered_fb(i) - fbcon_fb_registered(fbcon_registered_fb[i]); + do_fb_registered(fbcon_registered_fb[i]); console_unlock(); } -- 2.34.1

4 5

Re: [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote: > > + if (WARN_ON(!READ_ONCE(vdev->open_count))) > > + return -EINVAL; > > I think all the WARN_ON()s in this patch need to be WARN_ON_ONCE, > otherwise there will be too many backtraces to be useful if a driver > ever gets the API wrong. Sure, I added a wrapper to make that have less overhead and merged it with the other 'driver is calling this correctly' checks: @@ -1330,6 +1330,12 @@ static int vfio_group_add_container_user(struct vfio_group *group) static const struct file_operations vfio_device_fops; +/* true if the vfio_device has open_device() called but not close_device() */ +static bool vfio_assert_device_open(struct vfio_device *device) +{ + return !WARN_ON_ONCE(!READ_ONCE(device->open_count)); +} + static int vfio_group_get_device_fd(struct vfio_group *group, char *buf) { struct vfio_device *device; @@ -1544,6 +1550,7 @@ static int vfio_device_fops_release(struct inode *inode, struct file *filep) struct vfio_device *device = filep->private_data; mutex_lock(&device->dev_set->lock); + vfio_assert_device_open(device); if (!--device->open_count && device->ops->close_device) device->ops->close_device(device); mutex_unlock(&device->dev_set->lock); @@ -2112,7 +2119,7 @@ int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn, int npage, struct vfio_iommu_driver *driver; int ret; - if (!user_pfn || !phys_pfn || !npage) + if (!user_pfn || !phys_pfn || !npage || !vfio_assert_device_open(vdev)) return -EINVAL; if (npage > VFIO_PIN_PAGES_MAX_ENTRIES) @@ -2121,9 +2128,6 @@ int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn, int npage, if (group->dev_counter > 1) return -EINVAL; - if (WARN_ON(!READ_ONCE(vdev->open_count))) - return -EINVAL; - container = group->container; driver = container->iommu_driver; if (likely(driver && driver->ops->pin_pages)) @@ -2153,15 +2157,12 @@ int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn, struct vfio_iommu_driver *driver; int ret; - if (!user_pfn || !npage) + if (!user_pfn || !npage || !vfio_assert_device_open(vdev)) return -EINVAL; if (npage > VFIO_PIN_PAGES_MAX_ENTRIES) return -E2BIG; - if (WARN_ON(!READ_ONCE(vdev->open_count))) - return -EINVAL; - container = vdev->group->container; driver = container->iommu_driver; if (likely(driver && driver->ops->unpin_pages)) @@ -2198,10 +2199,7 @@ int vfio_dma_rw(struct vfio_device *vdev, dma_addr_t user_iova, struct vfio_iommu_driver *driver; int ret = 0; - if (!data || len <= 0) - return -EINVAL; - - if (WARN_ON(!READ_ONCE(vdev->open_count))) + if (!data || len <= 0 || !vfio_assert_device_open(vdev)) return -EINVAL; container = vdev->group->container; @@ -2294,10 +2292,7 @@ int vfio_register_notifier(struct vfio_device *dev, enum vfio_notify_type type, struct vfio_group *group = dev->group; int ret; - if (!nb || !events || (*events == 0)) - return -EINVAL; - - if (WARN_ON(!READ_ONCE(dev->open_count))) + if (!nb || !events || (*events == 0) || !vfio_assert_device_open(dev)) return -EINVAL; switch (type) { @@ -2321,10 +2316,7 @@ int vfio_unregister_notifier(struct vfio_device *dev, struct vfio_group *group = dev->group; int ret; - if (!nb) - return -EINVAL; - - if (WARN_ON(!READ_ONCE(dev->open_count))) + if (!nb || !vfio_assert_device_open(dev)) return -EINVAL; switch (type) { Thanks, Jason

1 0

Re: refactor the i915 GVT support and move to the modern mdev API v3
by Wang, Zhi A 13 Apr '22

13 Apr '22

On 4/11/22 2:13 PM, Christoph Hellwig wrote: > Hi all, > > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code moves out of the main i915 driver and into the kvmgt > module. Hi Christoph: Do you want me to merge the GVT-g patches in this series? Or you want them to get merged from your side? Thanks, Zhi. > > Tested on my Thinkpad with a Kaby Lake CPU and integrated graphics. > > Git tree: > > git://git.infradead.org/users/hch/misc.git i915-gvt > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/i915-gvt > > Changes since v2: > - rebased on top of Linx 5.18-rc + > "Refactor GVT-g MMIO tracking table and handlers" > - don't fold the gvt Makefile into the main Makefile > - add the mdev patches to remove the legacy interface that is now > unused to the end of the series > > Changes since v1: > - rebased on Linux 5.15 > - allow the kvmgvt module to be loaded at any time and thus solve > the deadlock when both i915 amd kvmgvt are modular > - include the conversion to the modern mdev API > > Note that I do expect to rebased this again against 5.16-rc1 once > released, but I'd like to get this out for review ASAP. > > Diffstat: > b/drivers/gpu/drm/i915/Kconfig | 33 > b/drivers/gpu/drm/i915/Makefile | 31 > b/drivers/gpu/drm/i915/gvt/cfg_space.c | 89 -- > b/drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 > b/drivers/gpu/drm/i915/gvt/dmabuf.c | 36 - > b/drivers/gpu/drm/i915/gvt/execlist.c | 12 > b/drivers/gpu/drm/i915/gvt/gtt.c | 55 + > b/drivers/gpu/drm/i915/gvt/gvt.h | 125 ++- > b/drivers/gpu/drm/i915/gvt/interrupt.c | 38 + > b/drivers/gpu/drm/i915/gvt/kvmgt.c | 1099 +++++++++++++++----------------- > b/drivers/gpu/drm/i915/gvt/mmio.c | 4 > b/drivers/gpu/drm/i915/gvt/opregion.c | 148 ---- > b/drivers/gpu/drm/i915/gvt/page_track.c | 8 > b/drivers/gpu/drm/i915/gvt/scheduler.c | 37 - > b/drivers/gpu/drm/i915/gvt/trace.h | 2 > b/drivers/gpu/drm/i915/gvt/vgpu.c | 22 > b/drivers/gpu/drm/i915/i915_drv.c | 7 > b/drivers/gpu/drm/i915/i915_drv.h | 1 > b/drivers/gpu/drm/i915/i915_trace.h | 1 > b/drivers/gpu/drm/i915/intel_gvt.c | 162 +++- > b/drivers/gpu/drm/i915/intel_gvt.h | 17 > drivers/gpu/drm/i915/gvt/Makefile | 9 > drivers/gpu/drm/i915/gvt/gvt.c | 340 --------- > drivers/gpu/drm/i915/gvt/hypercall.h | 82 -- > drivers/gpu/drm/i915/gvt/mpt.h | 400 ----------- > 25 files changed, 929 insertions(+), 1833 deletions(-) >

1 0

Re: [PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 08:01:10AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:31PM -0300, Jason Gunthorpe wrote: > > Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no > > reason to use a group interface here, kvmgt has easy access to a > > vfio_device. > > Once this is moved after the vfio_dma_rw, this is the last user of > the vfio_group, and I think it owuld make sense to merge it with the > patch to remove the vfio_group instead of leaving that around once > unused. Done Thanks, Jason

1 0

Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 08:00:08AM +0200, Christoph Hellwig wrote: > This looks good execept the extern nitpick: > > Reviewed-by: Christoph Hellwig <hch(a)lst.de> > > However I'd move this before the previous patch. More of the explanation > there. Yes, that looks good, done Thanks, Jason

1 0

[bug report] drm/ttm: Add a generic TTM memcpy move for page-based iomem
by Dan Carpenter 13 Apr '22

13 Apr '22

Hello Thomas Hellström, The patch 3bf3710e3718: "drm/ttm: Add a generic TTM memcpy move for page-based iomem" from Jun 2, 2021, leads to the following Smatch static checker warning: ./include/drm/ttm/ttm_bo_driver.h:259 ttm_bo_move_sync_cleanup() error: NULL dereference inside function 'ttm_bo_move_accel_cleanup()' ./include/drm/ttm/ttm_bo_driver.h 256 static inline void ttm_bo_move_sync_cleanup(struct ttm_buffer_object *bo, 257 struct ttm_resource *new_mem) 258 { --> 259 int ret = ttm_bo_move_accel_cleanup(bo, NULL, true, false, new_mem); ^^^^ Passing a NULL for "fence" will crash. The first place where it will crash is in dma_resv_add_fence() where it does: WARN_ON(dma_fence_is_container(fence)); 260 261 WARN_ON(ret); 262 } regards, dan carpenter

2 1

Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 07:57:17AM +0200, Christoph Hellwig wrote: > > - extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn, > > + extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn, > > int npage, int prot, unsigned long *phys_pfn); > > > > - extern int vfio_unpin_pages(struct device *dev, unsigned long *user_pfn, > > + extern int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn, > > Please drop the externs when you touch this (also for the actual > header). Alex has been asking to keep them in the H files for consistency Removing from the docs should be fine though Thanks, Jason

1 0

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device
by Jason Gunthorpe 13 Apr '22

13 Apr '22

On Wed, Apr 13, 2022 at 07:55:24AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:28PM -0300, Jason Gunthorpe wrote: > > All callers have a struct vfio_device trivially available, pass it in > > directly and avoid calling the expensive vfio_group_get_from_dev(). > > Instead of bothering the drivers with the notifiers at all, the two > notifier_blocks should move into struct vfio_device, and the > vfio_ops should just grow two new dma_unmap and set_kvm methods. > > This will isolate the drives from the whole notifiers mess and it's > boilerplate code. I already looked into that for a while, it is a real mess too because of how the notifiers are used by the current drivers, eg gvt assumes the notifier is called during its open_device callback to setup its kvm. The unmap is less convoluted and I might still try to do that.. For this series I prefer to leave it alone Jason

1 0

← Newer
1
...
53
54
55
56
57
58
59
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022