dri-devel May 2022

dri-devel@lists.freedesktop.org

344 participants
736 discussions

[PATCH v2] drm/msm/dpu: handle pm_runtime_get_sync() errors in bind path
by Abhinav Kumar 19 May '22

19 May '22

If there are errors while trying to enable the pm in the bind path, it will lead to unclocked access of hw revision register thereby crashing the device. This will not address why the pm_runtime_get_sync() fails but at the very least we should be able to prevent the crash by handling the error and bailing out earlier. changes in v2: - use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() Signed-off-by: Abhinav Kumar <quic_abhinavk(a)quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 2b9d931474e0..bce47647d891 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -1089,7 +1089,9 @@ static int dpu_kms_hw_init(struct msm_kms *kms) dpu_kms_parse_data_bus_icc_path(dpu_kms); - pm_runtime_get_sync(&dpu_kms->pdev->dev); + rc = pm_runtime_resume_and_get(&dpu_kms->pdev->dev); + if (rc < 0) + goto error; dpu_kms->core_rev = readl_relaxed(dpu_kms->mmio + 0x0); -- 2.35.1

3 3

[PATCH v0.5 0/9] i.MX8MP HDMI support
by Lucas Stach 19 May '22

19 May '22

Hi all, second round of the i.MX8MP HDMI work. Still not split up into proper parts for merging through the various trees this needs to go into, but should make it easy for people to test. I've worked in the feedback I got from the last round, including fixing the system hang that could happen when the drivers were built as modules. Series is based on linux-next/master, as there are some prerequisite patches in both the drm and imx tree already. The last patch from [1] and the patches from [2] need to be applied. Please note that this series expects the sync polarity from the LCDIF to be set according to the comments I made in [2]. Please test and provide feedback. Regards, Lucas [1] https://lore.kernel.org/all/20220406153402.1265474-1-l.stach@pengutronix.de/ [2] https://lore.kernel.org/all/20220322142853.125880-1-marex@denx.de/ Lucas Stach (9): dt-bindings: display: imx: add binding for i.MX8MP HDMI TX drm/imx: add bridge wrapper driver for i.MX8MP DWC HDMI dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI drm/imx: add driver for HDMI TX Parallel Video Interface dt-bindings: phy: add binding for the i.MX8MP HDMI PHY phy: freescale: add Samsung HDMI PHY arm64: dts: imx8mp: add HDMI irqsteer arm64: dts: imx8mp: add HDMI display pipeline arm64: dts: imx8mp-evk: enable HDMI .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 83 ++ .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 73 ++ .../bindings/phy/fsl,imx8mp-hdmi-phy.yaml | 62 + arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 19 + arch/arm64/boot/dts/freescale/imx8mp.dtsi | 94 ++ drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 2 + drivers/gpu/drm/imx/bridge/Kconfig | 18 + drivers/gpu/drm/imx/bridge/Makefile | 4 + drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c | 201 +++ drivers/gpu/drm/imx/bridge/imx-hdmi.c | 141 +++ drivers/phy/freescale/Kconfig | 6 + drivers/phy/freescale/Makefile | 1 + drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 1078 +++++++++++++++++ 14 files changed, 1783 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml create mode 100644 drivers/gpu/drm/imx/bridge/Kconfig create mode 100644 drivers/gpu/drm/imx/bridge/Makefile create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi-pvi.c create mode 100644 drivers/gpu/drm/imx/bridge/imx-hdmi.c create mode 100644 drivers/phy/freescale/phy-fsl-samsung-hdmi.c -- 2.30.2

5 19

[Bug 201497] New: [amdgpu]: '*ERROR* No EDID read' is back in 4.19
by bugzilla-daemon＠bugzilla.kernel.org 19 May '22

19 May '22

https://bugzilla.kernel.org/show_bug.cgi?id=201497 Bug ID: 201497 Summary: [amdgpu]: '*ERROR* No EDID read' is back in 4.19 Product: Drivers Version: 2.5 Kernel Version: 4.19 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: engywook(a)gmail.com Regression: No Hey, I have this EDID bug again, see https://lists.freedesktop.org/archives/amd-gfx/2018-July/023923.html 018d82e5f02ef3583411bcaa4e00c69786f46f19 seems to have gotten back in through: # first bad commit: [d98c71dadc2d0debdb80beb5a478baf1e6f98758] Merge drm-upstream/drm-next into drm-misc-next / Daniel -- You are receiving this mail because: You are watching the assignee of the bug.

2 26

[PATCH v3 0/3] eDP/DP Phy vdda realted function
by Kuogee Hsieh 18 May '22

18 May '22

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy/qualcomm: add regulator_set_load to edp phy phy/qualcomm: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related functions from eDP/DP controller drivers/gpu/drm/msm/dp/dp_parser.c | 14 ------ drivers/gpu/drm/msm/dp/dp_parser.h | 6 --- drivers/gpu/drm/msm/dp/dp_power.c | 95 +------------------------------------ drivers/phy/qualcomm/phy-qcom-edp.c | 10 +++- drivers/phy/qualcomm/phy-qcom-qmp.c | 12 +++++ 5 files changed, 23 insertions(+), 114 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 6

[pull] amdgpu, amdkfd drm-next-5.19
by Alex Deucher 18 May '22

18 May '22

Hi Dave, Daniel, Stuff for 5.19. A bit late for new stuff, but it's just additional enablement for new IPs so they shouldn't affect existing parts. The rest is just the usual fixes. The following changes since commit 81c5495910e81c2cadcb9118ca0c8803ab3bde61: drm/amdgpu: Remove duplicated argument in vcn_v4_0 (2022-05-10 17:53:13 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.19-2022-05-18 for you to fetch changes up to 0223e516470aa0589da6c03e6d177c10594cabbd: drm/amd: Don't reset dGPUs if the system is going to s2idle (2022-05-18 15:20:18 -0400) ---------------------------------------------------------------- amd-drm-next-5.19-2022-05-18: amdgpu: - Misc code cleanups - Additional SMU 13.x enablement - Smartshift fixes - GFX11 fixes - Support for SMU 13.0.4 - SMU mutex fix - Suspend/resume fix amdkfd: - static checker fix - Doorbell/MMIO resource handling fix ---------------------------------------------------------------- Alex Deucher (1): drm/amdgpu/ctx: only reset stable pstate if the user changed it (v2) Graham Sider (1): drm/amdkfd: Fix static checker warning on MES queue type Hans de Goede (1): drm/amdgpu: Move mutex_init(&smu->message_lock) to smu_early_init() Haohui Mai (1): drm/amdgpu: Ensure the DMA engine is deactivated during set ups Huang Rui (1): drm/amdgpu/pm: add smu v13.0.4 driver SMU if headers Jack Xiao (2): drm/amdgpu/gfx11: fix me field handling in map_queue packet drm/amdgpu/gfx11: fix mes mqd settings Jiapeng Chong (2): drm/amdgpu: clean up some inconsistent indenting drm/amd/display: clean up some inconsistent indenting Lang Yu (1): drm/amdkfd: allocate MMIO/DOORBELL BOs with AMDGPU_GEM_CREATE_PREEMPTIBLE Luben Tuikov (1): drm/amdgpu: Unmap legacy queue when MES is enabled Mario Limonciello (1): drm/amd: Don't reset dGPUs if the system is going to s2idle Sathishkumar S (4): drm/amd/pm: support ss metrics read for smu11 drm/amd/pm: update smartshift powerboost calc for smu12 drm/amd/pm: update smartshift powerboost calc for smu13 drm/amd/pm: consistent approach for smartshift Tim Huang (5): drm/amdgpu/pm: add EnableGfxImu message dummy map for SMU IP v13.0.4 drm/amdgpu/pm: add some common ppt functions for SMU IP v13.0.x drm/amdgpu/pm: add swsmu ppt implementation for SMU IP v13.0.4 drm/amdgpu/pm: enable swsmu for SMU IP v13.0.4 drm/amdgpu/pm: add GFXOFF control IP version check for SMU IP v13.0.4 Xiaojian Du (1): drm/amdgpu/discovery: add SMU v13.0.4 into the IP discovery list Yang Wang (4): drm/amd/pm: add smu pp_feature_mask callback for smu_v13_0_7 drm/amd/pm: add smu feature map support for smu_v13_0_7 drm/amd/pm: add smu feature map support for smu_v13_0_0 drm/amd/pm: add smu power_limit callback for smu_v13_0_7 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 14 + drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 32 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 +- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 20 +- drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 17 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 109 +- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 7 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 130 ++- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 8 +- .../inc/pmfw_if/smu11_driver_if_sienna_cichlid.h | 63 ++ .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h | 267 +++++ .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_4_pmfw.h | 137 +++ .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_4_ppsmc.h | 138 +++ drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 26 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 9 +- .../drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 161 ++- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 60 +- drivers/gpu/drm/amd/pm/swsmu/smu13/Makefile | 3 +- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 107 +- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 69 +- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 1044 ++++++++++++++++++++ .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.h | 28 + .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 99 +- .../gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 62 +- 30 files changed, 2364 insertions(+), 274 deletions(-) create mode 100644 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h create mode 100644 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_4_pmfw.h create mode 100644 drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_4_ppsmc.h create mode 100644 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c create mode 100644 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.h

1 0

[pull] amdgpu drm-fixes-5.18
by Alex Deucher 18 May '22

18 May '22

Hi Dave, Daniel, Just one suspend/resume regression fix. The following changes since commit 42226c989789d8da4af1de0c31070c96726d990c: Linux 5.18-rc7 (2022-05-15 18:08:58 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.18-2022-05-18 for you to fetch changes up to 7123d39dc24dcd21ff23d75f46f926b15269b9da: drm/amd: Don't reset dGPUs if the system is going to s2idle (2022-05-18 15:24:35 -0400) ---------------------------------------------------------------- amd-drm-fixes-5.18-2022-05-18: amdgpu: - Suspend/resume regression fix ---------------------------------------------------------------- Mario Limonciello (1): drm/amd: Don't reset dGPUs if the system is going to s2idle drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 14 ++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 3 files changed, 17 insertions(+), 1 deletion(-)

1 0

[PATCH v2 0/2] eDP/DP Phy vdda realted function
by Kuogee Hsieh 18 May '22

18 May '22

1) add regulator_set_load() to eDP/DP phy 2) remove vdda related function out of eDP/DP controller Kuogee Hsieh (2): phy/qcom: add regulator_set_load to edp/dp phy drm/msm/dp: delete vdda regulator related functions from eDP/DP controller drivers/gpu/drm/msm/dp/dp_parser.c | 14 ------ drivers/gpu/drm/msm/dp/dp_parser.h | 6 --- drivers/gpu/drm/msm/dp/dp_power.c | 95 +------------------------------------ drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++-- drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++ 5 files changed, 36 insertions(+), 117 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 11

[PATCH] drm/msm/dpu: handle pm_runtime_get_sync() errors in bind path
by Abhinav Kumar 18 May '22

18 May '22

If there are errors while trying to enable the pm in the bind path, it will lead to unclocked access of hw revision register thereby crashing the device. This will not address why the pm_runtime_get_sync() fails but at the very least we should be able to prevent the crash by handling the error and bailing out earlier. Signed-off-by: Abhinav Kumar <quic_abhinavk(a)quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 2b9d931474e0..2fd1f5b70a06 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -1089,7 +1089,11 @@ static int dpu_kms_hw_init(struct msm_kms *kms) dpu_kms_parse_data_bus_icc_path(dpu_kms); - pm_runtime_get_sync(&dpu_kms->pdev->dev); + rc = pm_runtime_get_sync(&dpu_kms->pdev->dev); + if (rc < 0) { + pm_runtime_put_autosuspend(&dpu_kms->pdev->dev); + goto error; + } dpu_kms->core_rev = readl_relaxed(dpu_kms->mmio + 0x0); -- 2.35.1

2 1

[PATCH] drm/msm/dpu: limit writeback modes according to max_linewidth
by Abhinav Kumar 18 May '22

18 May '22

Writeback modes were being added according to mode_config.max_width but this is assigned to double of max_mixer_width. For compositors/clients using a single SSPP, this will fail the dpu_plane's atomic check as it checks for max_linewidth. Limit writeback modes according to max_linewidth to allow even compositors/clients which use only a single SSPP to use writeback. Fixes: 77b001acdcfeb ("drm/msm/dpu: add the writeback connector layer") Reported-by: Jessica Zhang <quic_jesszhan(a)quicinc.com> Signed-off-by: Abhinav Kumar <quic_abhinavk(a)quicinc.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c index 7620ffe55779..399115e4e217 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -8,8 +8,10 @@ static int dpu_wb_conn_get_modes(struct drm_connector *connector) { struct drm_device *dev = connector->dev; + struct msm_drm_private *priv = dev->dev_private; + struct dpu_kms *dpu_kms = to_dpu_kms(priv->kms); - return drm_add_modes_noedid(connector, dev->mode_config.max_width, + return drm_add_modes_noedid(connector, dpu_kms->catalog->caps->max_linewidth, dev->mode_config.max_height); } -- 2.35.1

3 2

[PATCH v3] uapi/drm/i915: Document memory residency and Flat-CCS capability of obj
by Ramalingam C 18 May '22

18 May '22

Capture the impact of memory region preference list of the objects, on their memory residency and Flat-CCS capability. v2: Fix the Flat-CCS capability of an obj with {lmem, smem} preference list [Thomas] v3: Reworded the doc [Matt] Signed-off-by: Ramalingam C <ramalingam.c(a)intel.com> cc: Matthew Auld <matthew.auld(a)intel.com> cc: Thomas Hellstrom <thomas.hellstrom(a)linux.intel.com> cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> cc: Jon Bloomfield <jon.bloomfield(a)intel.com> cc: Lionel Landwerlin <lionel.g.landwerlin(a)intel.com> cc: Kenneth Graunke <kenneth(a)whitecape.org> cc: mesa-dev(a)lists.freedesktop.org cc: Jordan Justen <jordan.l.justen(a)intel.com> cc: Tony Ye <tony.ye(a)intel.com> Reviewed-by: Matthew Auld <matthew.auld(a)intel.com> --- include/uapi/drm/i915_drm.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index a2def7b27009..b7e1c2fe08dc 100644 --- a/include/uapi/drm/i915_drm.h +++ b/include/uapi/drm/i915_drm.h @@ -3443,6 +3443,22 @@ struct drm_i915_gem_create_ext { * At which point we get the object handle in &drm_i915_gem_create_ext.handle, * along with the final object size in &drm_i915_gem_create_ext.size, which * should account for any rounding up, if required. + * + * Note that userspace has no means of knowing the current backing region + * for objects where @num_regions is larger than one. The kernel will only + * ensure that the priority order of the @regions array is honoured, either + * when initially placing the object, or when moving memory around due to + * memory pressure + * + * On Flat-CCS capable HW, compression is supported for the objects residing + * in I915_MEMORY_CLASS_DEVICE. When such objects (compressed) has other + * memory class in @regions and migrated (by I915, due to memory + * constrain) to the non I915_MEMORY_CLASS_DEVICE region, then I915 needs to + * decompress the content. But I915 dosen't have the required information to + * decompress the userspace compressed objects. + * + * So I915 supports Flat-CCS, only on the objects which can reside only on + * I915_MEMORY_CLASS_DEVICE regions. */ struct drm_i915_gem_create_ext_memory_regions { /** @base: Extension link. See struct i915_user_extension. */ -- 2.20.1

4 6

← Newer
1
...
35
36
37
38
39
40
41
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2022