[Bug 89785] GPU Fault 147 and Ring Stalls and Tests Fail in Pillars of Eternity

https://bugs.freedesktop.org/show_bug.cgi?id=89785

--- Comment #12 from Michel Dänzer michel@daenzer.net --- Comment on attachment 114780 --> https://bugs.freedesktop.org/attachment.cgi?id=114780 Fix for bug described in commet 4

Review of attachment 114780: -----------------------------------------------------------------

I think it would be better if SI_KILL could be fixed not to clobber VCC in the first place, e.g. by using the 64-bit encoding of the v_cmp(x)_lt_f32[0] instruction. But failing that, this looks good.

[0] BTW, it's currently using v_cmpx_le_f32, but I think that's incorrect, as the comment says "Clear this thread from the exec mask if the operand is negative".