https://bugs.freedesktop.org/show_bug.cgi?id=93758
Bug ID: 93758 Summary: mpv + st/va: add motion adaptive deinterlacing v2 = segfault/assert Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: adf.lists@gmail.com QA Contact: dri-devel@lists.freedesktop.org
Created attachment 121110 --> https://bugs.freedesktop.org/attachment.cgi?id=121110&action=edit segfault
Testing st/va: add motion adaptive deinterlacing v2 on tonga.
Release or git mpv segfaults or asserts (mesa --enable-debug).
mpv --hwdec=vaapi --vo=vaapi --vf=vavpp:deint=motion-adaptive ...
https://bugs.freedesktop.org/show_bug.cgi?id=93758
--- Comment #1 from Andy Furniss adf.lists@gmail.com --- Created attachment 121111 --> https://bugs.freedesktop.org/attachment.cgi?id=121111&action=edit assert
https://bugs.freedesktop.org/show_bug.cgi?id=93758
--- Comment #2 from Christian König deathsimple@vodafone.de --- Created attachment 121120 --> https://bugs.freedesktop.org/attachment.cgi?id=121120&action=edit Possible fix
Hi Andy,
stupid typo, does the attached patch fix the issue?
https://bugs.freedesktop.org/show_bug.cgi?id=93758
--- Comment #3 from Andy Furniss adf.lists@gmail.com --- (In reply to Christian König from comment #2)
Created attachment 121120 [details] [review] Possible fix
Hi Andy,
stupid typo, does the attached patch fix the issue?
Yes that fixes it thanks.
I can see there are more artifacts than with vdpau m/a deint - I was expecting them to use the same underlying code and so have the same artifacts?
https://bugs.freedesktop.org/show_bug.cgi?id=93758
--- Comment #4 from Andy Furniss adf.lists@gmail.com --- (In reply to Andy Furniss from comment #3)
I can see there are more artifacts than with vdpau m/a deint - I was expecting them to use the same underlying code and so have the same artifacts?
After looking at more samples it seems that sometimes parts of one of the fields ends up with old content being displayed/not updated.
This is more than a few extra artifacts - it's buggy. With vdpau there were artifacts, but you wouldn't notice them watching normally (would need to pause/slow mo). Given the right input this is instantly noticeably corrupt.
https://bugs.freedesktop.org/show_bug.cgi?id=93758
Christian König deathsimple@vodafone.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Christian König deathsimple@vodafone.de --- (In reply to Andy Furniss from comment #4)
(In reply to Andy Furniss from comment #3)
I can see there are more artifacts than with vdpau m/a deint - I was expecting them to use the same underlying code and so have the same artifacts?
After looking at more samples it seems that sometimes parts of one of the fields ends up with old content being displayed/not updated.
This is more than a few extra artifacts - it's buggy. With vdpau there were artifacts, but you wouldn't notice them watching normally (would need to pause/slow mo). Given the right input this is instantly noticeably corrupt.
Really interesting. I can't see of hand how this could happen.
The only possibility is that the input bitstream somehow gets corrupted sometimes and because of that UVD fails to decode the field in question. But that would affect normal playback as well.
Anyway, please open up a new bug report for this. Clearly a separate issue.
dri-devel@lists.freedesktop.org