dri-devel February 2013

dri-devel@lists.freedesktop.org

130 participants
696 discussions

Re: [git pull] drm merge for 3.9-rc1
by Sedat Dilek 05 Mar '13

05 Mar '13

Hi, I am seeing this also on Linux-Next. /var/log/kern.log:Feb 27 22:52:35 fambox kernel: [ 28.202381] [drm:intel_dp_aux_wait_done] *ERROR* dp aux hw did not signal timeout (has irq: 1)! /var/log/kern.log:Feb 27 22:52:35 fambox kernel: [ 28.210588] [drm:intel_dp_aux_wait_done] *ERROR* dp aux hw did not signal timeout (has irq: 1)! /var/log/kern.log.1:Feb 22 07:36:04 fambox kernel: [ 27.408280] [drm:intel_dp_aux_wait_done] *ERROR* dp aux hw did not signal timeout (has irq: 1)! This seems to be hard reproducible... Laptop-LCD... Sandybridge Mobile-GT2. Is there a way to force the error? Possible patch see [1]. - Sedat - [1] https://patchwork.kernel.org/patch/2192721/

4 10

[Bug 52491] New: radeon massive screen corruption BARTS HD6870
by bugzilla-daemon＠bugzilla.kernel.org 05 Mar '13

05 Mar '13

https://bugzilla.kernel.org/show_bug.cgi?id=52491 Summary: radeon massive screen corruption BARTS HD6870 Product: Drivers Version: 2.5 Kernel Version: 3.8-rc Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) AssignedTo: drivers_video-dri(a)kernel-bugs.osdl.org ReportedBy: maxijac(a)free.fr Regression: No Created an attachment (id=90801) --> (https://bugzilla.kernel.org/attachment.cgi?id=90801) return to desktop after bad rendering Hi, I'm experiencing a major rendering corruption with linux 3.8 and my HD 6870. software: latest kernel from linus as of 2013-08-01 latest mesa git as of 2013-08-01 latest llvm from tstellar git as of 2013-08-01 latest DDX from git as of 2013-08-01 libdrm 2.4.40 Symptoms: I triggered this several times running Heroes of Newerth. When a match starts, sometimes The textures are all black, or sometimes my cursor is missing. (It looks like my LLVM-enabled for the glsl compiler builds of mesa trigger the black textures more often) When this happens, quitting the game and returning to my desktop, everything is garbled, things do not refresh correctly. See screenshot. keeping the same userland and just downgrading to linux 3.7 solves everything. Nothing gets added to dmesg... I don't have much time for bisecting this, I'll try asap but it won't be before some days, so if someone has similar hardware, please try to reproduce it. HoN is free to play and natively runs on linux. (http://www.heroesofnewerth.com) -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.

1 19

[PATCH v17 0/7] of: add display helper
by Steffen Trumtrar 05 Mar '13

05 Mar '13

Hi! This is basically just a resend of v16 that was rebased onto v3.8-rc4 and has two new "tested-by"s from Rob and Leela. The patches were tested with: - v15 on Tegra by Thierry - sh-mobile-lcdcfb by Laurent - MX53QSB by Marek - Exynos: smdk5250 by Leela - AM335X EVM & AM335X EVM-SK by Afzal - tilcdc lcd-panel by Rob - imx6q: sabrelite, sabresd by Philipp and me - imx53: tqma53/mba53 by me Changes since v16: - rebased from 3.7 to 3.8-rc4 Changes since v15: - move include/linux/{videomode,display_timing}.h to include/video - move include/linux/of_{videomode,display_timing}.h to include/video - reimplement flags: add VESA flags and data flags - let pixelclock in struct videomode be unsigned long - rename of_display_timings_exists to of_display_timings_exist - revise logging/error messages: replace __func__ with np->full_name - rename pixelclk-inverted to pixelclk-active - revise comments in code Changes since v14: - fix "const struct *" warning (reported by: Leela Krishna Amudala <l.krishna(a)samsung.com>) - return -EINVAL when htotal or vtotal are zero - remove unreachable code in of_get_display_timings - include headers in .c files and not implicit in .h - sort includes alphabetically - fix lower/uppercase in binding documentation - rebase onto v3.7-rc7 Changes since v13: - fix "const struct *" warning (reported by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com>) - prevent division by zero in fb_videomode_from_videomode Changes since v12: - rename struct display_timing to via_display_timing in via subsystem - fix refreshrate calculation - fix "const struct *" warnings (reported by: Manjunathappa, Prakash <prakash.pm(a)ti.com>) - some CodingStyle fixes - rewrite parts of commit messages and display-timings.txt - let display_timing_get_value get all values instead of just typical Changes since v11: - make pointers const where applicable - add reviewed-by Laurent Pinchart Changes since v10: - fix function name (drm_)display_mode_from_videomode - add acked-by, reviewed-by, tested-by Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Changes since v8: - fix memory leaks - change API to be more consistent (foo_from_bar(struct bar, struct foo)) - include headers were necessary - misc minor bugfixes Changes since v7: - move of_xxx to drivers/video - remove non-binding documentation from display-timings.txt - squash display_timings and videomode in one patch - misc minor fixes Changes since v6: - get rid of some empty lines etc. - move functions to their subsystems - split of_ from non-of_ functions - add at least some kerneldoc to some functions Changes since v5: - removed all display stuff and just describe timings Changes since v4: - refactored functions Changes since v3: - print error messages - free alloced memory - general cleanup Changes since v2: - use hardware-near property-names - provide a videomode structure - allow ranges for all properties (<min,typ,max>) - functions to get display_mode or fb_videomode Regards Steffen Steffen Trumtrar (7): viafb: rename display_timing to via_display_timing video: add display_timing and videomode video: add of helper for display timings/videomode fbmon: add videomode helpers fbmon: add of_videomode helpers drm_modes: add videomode helpers drm_modes: add of_videomode helpers .../devicetree/bindings/video/display-timing.txt | 109 +++++++++ drivers/gpu/drm/drm_modes.c | 70 ++++++ drivers/video/Kconfig | 21 ++ drivers/video/Makefile | 4 + drivers/video/display_timing.c | 24 ++ drivers/video/fbmon.c | 94 ++++++++ drivers/video/of_display_timing.c | 239 ++++++++++++++++++++ drivers/video/of_videomode.c | 54 +++++ drivers/video/via/hw.c | 6 +- drivers/video/via/hw.h | 2 +- drivers/video/via/lcd.c | 2 +- drivers/video/via/share.h | 2 +- drivers/video/via/via_modesetting.c | 8 +- drivers/video/via/via_modesetting.h | 6 +- drivers/video/videomode.c | 39 ++++ include/drm/drmP.h | 9 + include/linux/fb.h | 8 + include/video/display_timing.h | 124 ++++++++++ include/video/of_display_timing.h | 20 ++ include/video/of_videomode.h | 18 ++ include/video/videomode.h | 48 ++++ 21 files changed, 894 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt create mode 100644 drivers/video/display_timing.c create mode 100644 drivers/video/of_display_timing.c create mode 100644 drivers/video/of_videomode.c create mode 100644 drivers/video/videomode.c create mode 100644 include/video/display_timing.h create mode 100644 include/video/of_display_timing.h create mode 100644 include/video/of_videomode.h create mode 100644 include/video/videomode.h -- 1.7.10.4

4 14

[PATCH] ARM: dts: moving dt binding documents for video devices to common place
by Rahul Sharma 04 Mar '13

04 Mar '13

Binding Documents for drm-devices are placed in Documentation/devicetree/bindings/drm/*. But these devices are common for v4l framework, hence moved to a common place at Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to associate them with exynos soc series. Signed-off-by: Rahul Sharma <rahul.sharma(a)samsung.com> --- It is base on for-next branch of git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git .../devicetree/bindings/drm/exynos/hdmi.txt | 22 ---------------------- .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------ .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------ .../devicetree/bindings/drm/exynos/mixer.txt | 15 --------------- .../devicetree/bindings/video/exynos_hdmi.txt | 22 ++++++++++++++++++++++ .../devicetree/bindings/video/exynos_hdmiddc.txt | 12 ++++++++++++ .../devicetree/bindings/video/exynos_hdmiphy.txt | 12 ++++++++++++ .../devicetree/bindings/video/exynos_mixer.txt | 15 +++++++++++++++ 8 files changed, 61 insertions(+), 61 deletions(-) delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmi.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/mixer.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmi.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiddc.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiphy.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_mixer.txt diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt deleted file mode 100644 index 589edee..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt +++ /dev/null @@ -1,22 +0,0 @@ -Device-Tree bindings for drm hdmi driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmi". -- reg: physical base address of the hdmi and length of memory mapped - region. -- interrupts: interrupt number to the cpu. -- hpd-gpio: following information about the hotplug gpio pin. - a) phandle of the gpio controller node. - b) pin number within the gpio controller. - c) pin function mode. - d) optional flags and pull up/down. - e) drive strength. - -Example: - - hdmi { - compatible = "samsung,exynos5-hdmi"; - reg = <0x14530000 0x100000>; - interrupts = <0 95 0>; - hpd-gpio = <&gpx3 7 0xf 1 3>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt deleted file mode 100644 index fa166d9..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt +++ /dev/null @@ -1,12 +0,0 @@ -Device-Tree bindings for hdmiddc driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmiddc". -- reg: I2C address of the hdmiddc device. - -Example: - - hdmiddc { - compatible = "samsung,exynos5-hdmiddc"; - reg = <0x50>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt deleted file mode 100644 index 858f4f9..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt +++ /dev/null @@ -1,12 +0,0 @@ -Device-Tree bindings for hdmiphy driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmiphy". -- reg: I2C address of the hdmiphy device. - -Example: - - hdmiphy { - compatible = "samsung,exynos5-hdmiphy"; - reg = <0x38>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/mixer.txt b/Documentation/devicetree/bindings/drm/exynos/mixer.txt deleted file mode 100644 index 9b2ea03..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/mixer.txt +++ /dev/null @@ -1,15 +0,0 @@ -Device-Tree bindings for mixer driver - -Required properties: -- compatible: value should be "samsung,exynos5-mixer". -- reg: physical base address of the mixer and length of memory mapped - region. -- interrupts: interrupt number to the cpu. - -Example: - - mixer { - compatible = "samsung,exynos5-mixer"; - reg = <0x14450000 0x10000>; - interrupts = <0 94 0>; - }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt new file mode 100644 index 0000000..589edee --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt @@ -0,0 +1,22 @@ +Device-Tree bindings for drm hdmi driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmi". +- reg: physical base address of the hdmi and length of memory mapped + region. +- interrupts: interrupt number to the cpu. +- hpd-gpio: following information about the hotplug gpio pin. + a) phandle of the gpio controller node. + b) pin number within the gpio controller. + c) pin function mode. + d) optional flags and pull up/down. + e) drive strength. + +Example: + + hdmi { + compatible = "samsung,exynos5-hdmi"; + reg = <0x14530000 0x100000>; + interrupts = <0 95 0>; + hpd-gpio = <&gpx3 7 0xf 1 3>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt new file mode 100644 index 0000000..fa166d9 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt @@ -0,0 +1,12 @@ +Device-Tree bindings for hdmiddc driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmiddc". +- reg: I2C address of the hdmiddc device. + +Example: + + hdmiddc { + compatible = "samsung,exynos5-hdmiddc"; + reg = <0x50>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt new file mode 100644 index 0000000..858f4f9 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt @@ -0,0 +1,12 @@ +Device-Tree bindings for hdmiphy driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmiphy". +- reg: I2C address of the hdmiphy device. + +Example: + + hdmiphy { + compatible = "samsung,exynos5-hdmiphy"; + reg = <0x38>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt new file mode 100644 index 0000000..9b2ea03 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt @@ -0,0 +1,15 @@ +Device-Tree bindings for mixer driver + +Required properties: +- compatible: value should be "samsung,exynos5-mixer". +- reg: physical base address of the mixer and length of memory mapped + region. +- interrupts: interrupt number to the cpu. + +Example: + + mixer { + compatible = "samsung,exynos5-mixer"; + reg = <0x14450000 0x10000>; + interrupts = <0 94 0>; + }; -- 1.8.0

2 1

A patch referencing this bug report has been merged...
by Jani Nikula 03 Mar '13

03 Mar '13

Hi Florian, all - First, thanks for your work on adding the bugzilla comments when patches referencing bugs get merged. I find it useful. Recently however there was a comment about a commit referencing a commit referencing the bug report. Turns out the comment was missing one level of indirection, it was really about a commit referencing a commit referencing a commit referencing the bug [1]. Do we really need go that far, or is that a bug in your scripts? I think three levels of indirection is more noise than signal; two might be still be okay. What do others think? BR, Jani. [1] https://bugs.freedesktop.org/show_bug.cgi?id=52424#c56

3 2

[Bug 52549] New: libdrm 2.4.37 compilation fails if ETIME not defined
by bugzilla-daemon＠freedesktop.org 03 Mar '13

03 Mar '13

https://bugs.freedesktop.org/show_bug.cgi?id=52549 Bug #: 52549 Summary: libdrm 2.4.37 compilation fails if ETIME not defined Classification: Unclassified Product: DRI Version: XOrg CVS Platform: All OS/Version: BSD (Others) Status: NEW Severity: normal Priority: medium Component: libdrm AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: davshao(a)gmail.com For operating systems such as DragonFly BSD, ETIME may not be defined, let alone POSIX STREAMS implemented. libdrm 2.4.37 in current pkgsrc failed to compile on DragonFly BSD 3.1-DEVEL i386 and x86_64 until a patch was added to define ETIME if it was not already defined: ETIME is not defined on DragonFly BSD, work around it. --- intel/intel_bufmgr_gem.c.orig 2012-07-02 15:22:14.326942000 +0000 +++ intel/intel_bufmgr_gem.c @@ -54,6 +54,9 @@ #include <stdbool.h> #include "errno.h" +#ifndef ETIME +#define ETIME ETIMEDOUT +#endif #include "libdrm_lists.h" #include "intel_bufmgr.h" #include "intel_bufmgr_priv.h" -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 3

[Bug 56634] New: r600g: fix abysmal performance in Reaction Quake : Huge slowdown
by bugzilla-daemon＠freedesktop.org 02 Mar '13

02 Mar '13

https://bugs.freedesktop.org/show_bug.cgi?id=56634 Priority: medium Bug ID: 56634 Assignee: dri-devel(a)lists.freedesktop.org Summary: r600g: fix abysmal performance in Reaction Quake : Huge slowdown Severity: normal Classification: Unclassified OS: All Reporter: maxijac(a)free.fr Hardware: Other Status: NEW Version: unspecified Component: Drivers/Gallium/r600 Product: Mesa http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa58644855e44830e0b91dc627… Huge slowdown in Unigine-heaven (from ~25 fps to ~3 fps) -- You are receiving this mail because: You are the assignee for the bug.

1 7

[Bug 60890] New: Radeon HD 5700: GPU lockup in World in Conflict
by bugzilla-daemon＠freedesktop.org 01 Mar '13

01 Mar '13

https://bugs.freedesktop.org/show_bug.cgi?id=60890 Priority: medium Bug ID: 60890 Assignee: dri-devel(a)lists.freedesktop.org Summary: Radeon HD 5700: GPU lockup in World in Conflict Severity: normal Classification: Unclassified OS: All Reporter: stefandoesinger(a)gmx.at Hardware: Other Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa World in Conflict (running in Wine) causes GPU lockups on my Radeon HD 5770. This is a regression caused by 974b482acaf62ced1e8981761a8bda252bd51fe1: 974b482acaf62ced1e8981761a8bda252bd51fe1 is the first bad commit commit 974b482acaf62ced1e8981761a8bda252bd51fe1 Author: Jerome Glisse <jglisse(a)redhat.com> Date: Fri Feb 8 16:02:32 2013 -0500 r600g: fix lockup when hyperz & alpha test are enabled together. v3 :040000 040000 dda64e4a96123c0d2710354ce341b6e37a77e222 5e753aadebef5a00d66753b3b1c216d4ea483567 M src The corresponding dmesg lines are: [30865.977733] radeon 0000:01:00.0: GPU lockup CP stall for more than 10000msec [30865.977742] radeon 0000:01:00.0: GPU lockup (waiting for 0x00000000007f1db2 last fence id 0x00000000007f1dad) [30865.978802] radeon 0000:01:00.0: Saved 759 dwords of commands on ring 0. [30865.978809] radeon 0000:01:00.0: GPU softreset [30865.978815] radeon 0000:01:00.0: GRBM_STATUS=0xF4002828 [30865.978820] radeon 0000:01:00.0: GRBM_STATUS_SE0=0xC0000005 [30865.978825] radeon 0000:01:00.0: GRBM_STATUS_SE1=0x00000007 [30865.978830] radeon 0000:01:00.0: SRBM_STATUS=0x200000C0 [30865.978834] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [30865.978840] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x40040000 [30865.978845] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00048002 [30865.978851] radeon 0000:01:00.0: R_008680_CP_STAT = 0x80268643 [30865.983269] radeon 0000:01:00.0: GRBM_SOFT_RESET=0x00007F6B [30865.983375] radeon 0000:01:00.0: GRBM_STATUS=0x00003828 [30865.983379] radeon 0000:01:00.0: GRBM_STATUS_SE0=0x00000007 [30865.983382] radeon 0000:01:00.0: GRBM_STATUS_SE1=0x00000007 [30865.983386] radeon 0000:01:00.0: SRBM_STATUS=0x200000C0 [30865.983390] radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 [30865.983394] radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00000000 [30865.983397] radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00000000 [30865.983401] radeon 0000:01:00.0: R_008680_CP_STAT = 0x00000000 [30866.000901] radeon 0000:01:00.0: GPU reset succeeded, trying to resume [30866.087667] [drm] probing gen 2 caps for device 8086:d138 = 2/0 [30866.087672] [drm] PCIE gen 2 link speeds already enabled [30866.089405] [drm] PCIE GART of 512M enabled (table at 0x0000000000040000). [30866.089528] radeon 0000:01:00.0: WB enabled [30866.089531] radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xffff8802352efc00 [30866.106118] [drm] ring test on 0 succeeded in 0 usecs [30866.112724] [drm] ib test on ring 0 succeeded in 0 usecs The game is executing the builtin benchmark in windowed mode, resolution 800x600, medium presets. -- You are receiving this mail because: You are the assignee for the bug.

1 4

[PATCH] drm/edid: kernel-doc minimal cleanup
by Nishanth Menon 01 Mar '13

01 Mar '13

Some basic cleanups for kernel-doc errors or missing documentation parameters. Warnings generated by ./scripts/kernel-doc drivers/gpu/drm/drm_edid.c >Kerr Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie <airlied(a)linux.ie> Cc: Dave Airlie <airlied(a)redhat.com> Cc: Adam Jackson <ajax(a)redhat.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Nishanth Menon <nm(a)ti.com> --- It does seem the drm_edid.c could do with some amount of documentation cleanup, but I have stayed with the bare minimum. the above error is based off: master de1a226 Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux from: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git defconfig used: omap2plus_defconfig Disclaimer: I am no drm expert, and I tried to use my best judgement about what the meaning of the parameters might be, hope it helps. drivers/gpu/drm/drm_edid.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index c194f4e..f604c5f 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. - * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * drm_do_probe_ddc_edid() - Get EDID information via I2C. + * @adapter: i2c device adaptor + * @buf: EDID data buffer to be filled + * @block: EDID block to get + * @len: EDID data buffer length * * Try to fetch EDID information by calling i2c driver function. + * Return 0 on success or -1 on failure. */ static int drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf, @@ -1128,10 +1128,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc() - Probe DDC presence + * @adapter: i2c device adaptor * - * \param adapter : i2c device adaptor - * \return 1 on success + * returns 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1455,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: connector corresponding to the HDMI/DP sink + * @edid: EDID data * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -2000,6 +2002,7 @@ do_established_modes(struct detailed_timing *timing, void *c) /** * add_established_modes - get est. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2065,7 @@ do_standard_modes(struct detailed_timing *timing, void *c) /** * add_standard_modes - get std. modes from EDID and add them + * @connector: connector corresponding to the HDMI/DP sink * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2192,7 +2196,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) } } -/* +/** * add_detailed_modes - Add modes from detailed timings * @connector: attached connector * @edid: EDID block to scan @@ -2231,7 +2235,8 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #define EDID_CEA_VCDB_QS (1 << 6) /** - * Search EDID for CEA extension block. + * drm_find_cea_extension() - Search EDID for CEA extension block. + * @edid: EDID block to scan */ u8 *drm_find_cea_extension(struct edid *edid) { @@ -2604,6 +2609,7 @@ EXPORT_SYMBOL(drm_detect_hdmi_monitor); /** * drm_detect_monitor_audio - check monitor audio capability + * @edid: monitor EDID information * * Monitor should have CEA extension block. * If monitor has 'basic audio', but no CEA audio blocks, it's 'basic @@ -2649,6 +2655,7 @@ EXPORT_SYMBOL(drm_detect_monitor_audio); /** * drm_rgb_quant_range_selectable - is RGB quantization range selectable? + * @edid: EDID data * * Check whether the monitor reports the RGB quantization range selection * as supported. The AVI infoframe can then be used to inform the monitor -- 1.7.9.5

2 3

[Bug 60995] New: Account request for libdrm
by bugzilla-daemon＠freedesktop.org 01 Mar '13

01 Mar '13

https://bugs.freedesktop.org/show_bug.cgi?id=60995 Priority: medium Bug ID: 60995 Assignee: dri-devel(a)lists.freedesktop.org Summary: Account request for libdrm Severity: normal Classification: Unclassified OS: All Reporter: dh.herrmann(a)gmail.com Hardware: Other Status: NEW Version: unspecified Component: libdrm Product: DRI Created attachment 74973 --> https://bugs.freedesktop.org/attachment.cgi?id=74973&action=edit SSH public key Hi I'd like to get an fdo account with access to the libdrm repository so I can continue my work on the drm manpages. Name: David Herrmann Email: dh.herrmann(a)gmail.com Account: dvdhrm SSH and GPG public keys are attached. Thanks David -- You are receiving this mail because: You are the assignee for the bug.

1 2

← Newer
1
...
44
45
46
47
48
49
50
...
70
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2013