dri-devel February 2013

dri-devel@lists.freedesktop.org

130 participants
696 discussions

[Bug 26345] [845G] CPU/GPU incoherency
by bugzilla-daemon＠freedesktop.org 27 Feb '13

27 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=26345 --- Comment #155 from Chris Wilson <chris(a)chris-wilson.co.uk> --- (In reply to comment #154) > These fixes are in the latest 3.8 kernel. Have the GPU hangs been fixed in > earlier versions of the kernel? The sna fixes work with any KMS/GEM (i.e. 2.6.29+) kernel. The kernel w/a is being backported by Julien Cristau for the debian kernel. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 26345] [845G] CPU/GPU incoherency
by bugzilla-daemon＠freedesktop.org 26 Feb '13

26 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=26345 --- Comment #154 from Trey Ramsay <tramsay(a)linux.vnet.ibm.com> --- These fixes are in the latest 3.8 kernel. Have the GPU hangs been fixed in earlier versions of the kernel? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 61470] Driver does not turn on LCD backlight on resume
by bugzilla-daemon＠freedesktop.org 26 Feb '13

26 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=61470 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|eich(a)pdx.freedesktop.org |dri-devel(a)lists.freedesktop | |.org QA Contact|xorg-team(a)lists.x.org | Product|xorg |DRI Component|Driver/radeonhd |DRM/Radeon --- Comment #1 from Alex Deucher <agd5f(a)yahoo.com> --- Please attach your xorg log and dmesg output. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/exynos: hdmi: move mode_fixup to drm common hdmi
by Rahul Sharma 26 Feb '13

26 Feb '13

Currently, mode_fixup code doesn't consider the limitations of mixer as it is implemented inside the hdmi driver. Following fix, moves the mode_fixup to common drm hdmi driver. To check the mode support, it calls both, mixer and hdmi check_timing callbacks for a given resolution mode. This patch is dependent on https://patchwork.kernel.org/patch/2176021/. Signed-off-by: Rahul Sharma <rahul.sharma(a)samsung.com> --- It is based on exynos-drm-next-todo branch at git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 40 ++++++++++++++++++++++++--- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 3 -- drivers/gpu/drm/exynos/exynos_hdmi.c | 47 -------------------------------- 3 files changed, 36 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c index d7db69b..5dc956b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c @@ -205,13 +205,45 @@ static void drm_hdmi_mode_fixup(struct device *subdrv_dev, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) { - struct drm_hdmi_context *ctx = to_context(subdrv_dev); + struct drm_display_mode *m; + int mode_ok; DRM_DEBUG_KMS("%s\n", __FILE__); - if (hdmi_ops && hdmi_ops->mode_fixup) - hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector, mode, - adjusted_mode); + drm_mode_set_crtcinfo(adjusted_mode, 0); + + mode_ok = drm_hdmi_check_timing(subdrv_dev, adjusted_mode); + + /* just return if user desired mode exists. */ + if (mode_ok == 0) + return; + + /* + * otherwise, find the most suitable mode among modes and change it + * to adjusted_mode. + */ + list_for_each_entry(m, &connector->modes, head) { + mode_ok = drm_hdmi_check_timing(subdrv_dev, m); + + if (mode_ok == 0) { + struct drm_mode_object base; + struct list_head head; + + DRM_INFO("desired mode doesn't exist so\n"); + DRM_INFO("use the most suitable mode among modes.\n"); + + DRM_DEBUG_KMS("Adjusted Mode: [%d]x[%d] [%d]Hz\n", + m->hdisplay, m->vdisplay, m->vrefresh); + + /* preserve display mode header while copying. */ + head = adjusted_mode->head; + base = adjusted_mode->base; + memcpy(adjusted_mode, m, sizeof(*m)); + adjusted_mode->head = head; + adjusted_mode->base = base; + break; + } + } } static void drm_hdmi_mode_set(struct device *subdrv_dev, void *mode) diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.h b/drivers/gpu/drm/exynos/exynos_drm_hdmi.h index 844addb..fd2ff9f 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.h +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.h @@ -36,9 +36,6 @@ struct exynos_hdmi_ops { int (*power_on)(void *ctx, int mode); /* manager */ - void (*mode_fixup)(void *ctx, struct drm_connector *connector, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode); void (*mode_set)(void *ctx, struct drm_display_mode *mode); void (*get_max_resol)(void *ctx, unsigned int *width, unsigned int *height); diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index d8d78a6..a5ca2cc 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1431,52 +1431,6 @@ static void hdmi_conf_apply(struct hdmi_context *hdata) hdmi_regs_dump(hdata, "start"); } -static void hdmi_mode_fixup(void *ctx, struct drm_connector *connector, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - struct drm_display_mode *m; - struct hdmi_context *hdata = ctx; - int index; - - DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__); - - drm_mode_set_crtcinfo(adjusted_mode, 0); - - index = hdmi_find_phy_conf(hdata, adjusted_mode->clock * 1000); - - /* just return if user desired mode exists. */ - if (index >= 0) - return; - - /* - * otherwise, find the most suitable mode among modes and change it - * to adjusted_mode. - */ - list_for_each_entry(m, &connector->modes, head) { - index = hdmi_find_phy_conf(hdata, m->clock * 1000); - - if (index >= 0) { - struct drm_mode_object base; - struct list_head head; - - DRM_INFO("desired mode doesn't exist so\n"); - DRM_INFO("use the most suitable mode among modes.\n"); - - DRM_DEBUG_KMS("Adjusted Mode: [%d]x[%d] [%d]Hz\n", - m->hdisplay, m->vdisplay, m->vrefresh); - - /* preserve display mode header while copying. */ - head = adjusted_mode->head; - base = adjusted_mode->base; - memcpy(adjusted_mode, m, sizeof(*m)); - adjusted_mode->head = head; - adjusted_mode->base = base; - break; - } - } -} - static void hdmi_set_reg(u8 *reg_pair, int num_bytes, u32 value) { int i; @@ -1810,7 +1764,6 @@ static struct exynos_hdmi_ops hdmi_ops = { .check_timing = hdmi_check_timing, /* manager */ - .mode_fixup = hdmi_mode_fixup, .mode_set = hdmi_mode_set, .get_max_resol = hdmi_get_max_resol, .commit = hdmi_commit, -- 1.8.0

1 0

[Bug 30167] New: Heroes of Newerth: Setting shader quality to medium results in corrupt rendering
by bugzilla-daemon＠freedesktop.org 26 Feb '13

26 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=30167 Summary: Heroes of Newerth: Setting shader quality to medium results in corrupt rendering Product: Mesa Version: git Platform: Other URL: http://www.heroesofnewerth.com/ OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: sa(a)whiz.se Created an attachment (id=38673) --> (https://bugs.freedesktop.org/attachment.cgi?id=38673) Screenshot on medium setting In the game Heroes of Newerth, turning the setting "Shader Quality" to medium or high results in corrupt rendering of water. This seems to be a regression from the glsl2 merge, but it seems fine on llvmpipe, so I'm guessing the bug is specific to r300g. I _think_ it's possible to reproduce this bug without buying the game, by only registering and then either starting a practice game or running the tutorial. If not, I'll see about getting some trial invites. The rest of the effects in the game seems to be working fine. System environment: -- system architecture: 32-bit -- Linux distribution: Debian unstable -- GPU: RV570 -- Model: Asus EAX1950Pro 256MB -- Display connector: DVI -- xf86-video-ati: e9928fe036e9382fd7bc353f3f05531445f08977 -- xserver: 1.8.99.904 (1.9.0 RC 5) -- mesa: 6f839eb631511925505093be4d0509ac14f5675b -- drm: 23287f05cf2443ddf9e028e29beb5bd30979c6cf -- kernel: 2.6.35.4 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 26

[PATCH] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo
by Jingoo Han 26 Feb '13

26 Feb '13

VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH, because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync. Signed-off-by: Jingoo Han <jg1.han(a)samsung.com> Cc: Steffen Trumtrar <s.trumtrar(a)pengutronix.de> --- drivers/video/fbmon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 94ad0f7..7f67099 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm, fbmode->vmode = 0; if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) fbmode->sync |= FB_SYNC_HOR_HIGH_ACT; - if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) + if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH) fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) fbmode->vmode |= FB_VMODE_INTERLACED; -- 1.7.2.5

2 1

[Bug 61351] New: [r300g, bisected] some piglit tests fails with blit-based TexImage and TexSubImage
by bugzilla-daemon＠freedesktop.org 26 Feb '13

26 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=61351 Priority: medium Bug ID: 61351 Keywords: regression Assignee: dri-devel(a)lists.freedesktop.org Summary: [r300g, bisected] some piglit tests fails with blit-based TexImage and TexSubImage Severity: normal Classification: Unclassified OS: All Reporter: pavel.ondracka(a)email.cz Hardware: Other Status: NEW Version: git Component: Drivers/Gallium/r300 Product: Mesa ./bin/fp-indirections2 -auto r300: DRM version: 2.24.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2 r300: GART size: 509 MB, VRAM size: 256 MB r300: AA compression RAM: YES, Z compression RAM: YES, HiZ RAM: YES Max TEX instructions / TEX indirections: 512 / 511 Probe at (0,0) Expected: 0.640625 0.171875 0.390625 Observed: 0.235294 0.360784 0.517647 Failure in dim = 3, samples = 1 PIGLIT: {'result': 'fail' } ./bin/texwrap -fbo -auto 3D GL_RGBA8 proj bordercolor r300: DRM version: 2.24.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2 r300: GART size: 509 MB, VRAM size: 256 MB r300: AA compression RAM: YES, Z compression RAM: YES, HiZ RAM: YES Using TEXTURE_3D. Using projective mapping. Testing the border color only. Testing GL_RGBA8, projected, border color only Fail with NEAREST and CLAMP_TO_BORDER at (125,66) @ 10,10 Expected: 255 0 0 204 Observed: 0 0 0 0 Fail with NEAREST and MIRROR_CLAMP_TO_BORDER_EXT at (279,42) @ 2,2 Expected: 255 153 76 51 Observed: 0 0 0 0 Fail with LINEAR and CLAMP at (6,125) @ 0,0 Expected: 82 172 95 204 Observed: 20 172 96 153 Fail with LINEAR and CLAMP_TO_BORDER at (125,155) @ 10,10 Expected: 255 0 0 204 Observed: 1 7 4 6 Fail with LINEAR and MIRROR_CLAMP_EXT at (184,125) @ 0,0 Expected: 82 210 114 165 Observed: 20 172 96 153 Fail with LINEAR and MIRROR_CLAMP_TO_BORDER_EXT at (279,131) @ 2,2 Expected: 255 153 76 51 Observed: 0 4 2 3 PIGLIT:subtest {'GL_RGBA8, projected, border color only' : 'fail'} PIGLIT: {'result': 'fail' } ./bin/texwrap -fbo -auto 3D GL_RGBA8 bordercolor r300: DRM version: 2.24.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2 r300: GART size: 509 MB, VRAM size: 256 MB r300: AA compression RAM: YES, Z compression RAM: YES, HiZ RAM: YES Using TEXTURE_3D. Testing the border color only. Testing GL_RGBA8, border color only Fail with NEAREST and CLAMP_TO_BORDER at (125,66) @ 10,10 Expected: 255 0 0 204 Observed: 0 0 0 0 Fail with NEAREST and MIRROR_CLAMP_TO_BORDER_EXT at (279,42) @ 2,2 Expected: 255 153 76 51 Observed: 0 0 0 0 Fail with LINEAR and CLAMP at (6,125) @ 0,0 Expected: 82 172 95 204 Observed: 20 172 96 153 Fail with LINEAR and CLAMP_TO_BORDER at (125,155) @ 10,10 Expected: 255 0 0 204 Observed: 1 7 4 6 Fail with LINEAR and MIRROR_CLAMP_EXT at (184,125) @ 0,0 Expected: 82 210 114 165 Observed: 20 172 96 153 Fail with LINEAR and MIRROR_CLAMP_TO_BORDER_EXT at (279,131) @ 2,2 Expected: 255 153 76 51 Observed: 0 4 2 3 PIGLIT:subtest {'GL_RGBA8, border color only' : 'fail'} PIGLIT: {'result': 'fail' } first bad commit: commit 0a1479c829ed34a65e60c6619a8164e1b079aaee Author: Marek Olšák <maraeo(a)gmail.com> Date: Thu Feb 14 01:03:55 2013 +0100 st/mesa: implement blit-based TexImage and TexSubImage ... GPU:RV530 Mesa: 0d760a8160bbbd65a8b101fafb16fabd976ae0c9 Kernel: 3.7.3-101.fc17.i686 -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 61386] i855 GPU hang with AoE2 under Wine
by bugzilla-daemon＠freedesktop.org 25 Feb '13

25 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=61386 --- Comment #5 from Chris Wilson <chris(a)chris-wilson.co.uk> --- Those errors look consistent. So something is definitely off in the GPU state for that command. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 61386] i855 GPU hang with AoE2 under Wine
by bugzilla-daemon＠freedesktop.org 25 Feb '13

25 Feb '13

https://bugs.freedesktop.org/show_bug.cgi?id=61386 --- Comment #4 from Bruno <bonbons67(a)internet.lu> --- Created attachment 75523 --> https://bugs.freedesktop.org/attachment.cgi?id=75523&action=edit Third error state, this time under linux-3.8 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/radeon: Remove redundant NULL check before kfree
by Syam Sidhardhan 25 Feb '13

25 Feb '13

kfree on NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan <s.syam(a)samsung.com> --- drivers/gpu/drm/radeon/radeon_connectors.c | 6 ++---- drivers/gpu/drm/radeon/radeon_pm.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 2399f25..57828e6 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -643,8 +643,7 @@ static void radeon_connector_destroy(struct drm_connector *connector) { struct radeon_connector *radeon_connector = to_radeon_connector(connector); - if (radeon_connector->edid) - kfree(radeon_connector->edid); + kfree(radeon_connector->edid); kfree(radeon_connector->con_priv); drm_sysfs_connector_remove(connector); drm_connector_cleanup(connector); @@ -1209,8 +1208,7 @@ static void radeon_dp_connector_destroy(struct drm_connector *connector) struct radeon_connector *radeon_connector = to_radeon_connector(connector); struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv; - if (radeon_connector->edid) - kfree(radeon_connector->edid); + kfree(radeon_connector->edid); if (radeon_dig_connector->dp_i2c_bus) radeon_i2c_destroy(radeon_dig_connector->dp_i2c_bus); kfree(radeon_connector->con_priv); diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c index 338fd6a..2a51611 100644 --- a/drivers/gpu/drm/radeon/radeon_pm.c +++ b/drivers/gpu/drm/radeon/radeon_pm.c @@ -662,8 +662,7 @@ void radeon_pm_fini(struct radeon_device *rdev) device_remove_file(rdev->dev, &dev_attr_power_method); } - if (rdev->pm.power_state) - kfree(rdev->pm.power_state); + kfree(rdev->pm.power_state); radeon_hwmon_fini(rdev); } -- 1.7.9.5

2 1

← Newer
1
...
47
48
49
50
51
52
53
...
70
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2013