dri-devel May 2013

dri-devel@lists.freedesktop.org

116 participants
705 discussions

[PATCH 0/7] drm/i915: fbdev mode restoration improvements v2
by ville.syrjala＠linux.intel.com 03 Jun '13

03 Jun '13

Another attempt at restoring the fbdev mode. Changes from v1: - Cursors and sprites are disabled permanently (well, until someone explicitly re-enabls them). This was actually already the case for the old video overlay. - Since the disabling is now permanent, all extra planes can be disabled before the crtc modeset/set_base is performed so there should be no extra blinking of the planes I still left the new fbdev_restore_mode hook in place because I was too lazy to figure out if I could just disable planes/cursors from drm_fb_helper directly (i915 would be fine, but other drivers could have issues with it), and even with i915 we still have to disable the old video overlay, which is driven via some custom API, and hence can't be disabled from the common code.

4 16

[PATCH] drm: fix a use-after-free when GPU acceleration disabled
by Huacai Chen 03 Jun '13

03 Jun '13

When GPU acceleration is disabled, drm_vblank_cleanup() will free the vblank-related data, such as vblank_refcount, vblank_inmodeset, etc. But we found that drm_vblank_post_modeset() may be called after the cleanup, which use vblank_refcount and vblank_inmodeset. And this will cause a kernel panic. Fix this by return immediately if dev->num_crtcs is zero. This is the same thing that drm_vblank_pre_modeset() does. Call trace of a drm_vblank_post_modeset() after drm_vblank_cleanup(): [ 62.628906] [<ffffffff804868d0>] drm_vblank_post_modeset+0x34/0xb4 [ 62.628906] [<ffffffff804c7008>] atombios_crtc_dpms+0xb4/0x174 [ 62.628906] [<ffffffff804c70e0>] atombios_crtc_commit+0x18/0x38 [ 62.628906] [<ffffffff8047f038>] drm_crtc_helper_set_mode+0x304/0x3cc [ 62.628906] [<ffffffff8047f92c>] drm_crtc_helper_set_config+0x6d8/0x988 [ 62.628906] [<ffffffff8047dd40>] drm_fb_helper_set_par+0x94/0x104 [ 62.628906] [<ffffffff80439d14>] fbcon_init+0x424/0x57c [ 62.628906] [<ffffffff8046a638>] visual_init+0xb8/0x118 [ 62.628906] [<ffffffff8046b9f8>] take_over_console+0x238/0x384 [ 62.628906] [<ffffffff80436df8>] fbcon_takeover+0x7c/0xdc [ 62.628906] [<ffffffff8024fa20>] notifier_call_chain+0x44/0x94 [ 62.628906] [<ffffffff8024fcbc>] __blocking_notifier_call_chain+0x48/0x68 [ 62.628906] [<ffffffff8042d990>] register_framebuffer+0x228/0x260 [ 62.628906] [<ffffffff8047e010>] drm_fb_helper_single_fb_probe+0x260/0x314 [ 62.628906] [<ffffffff8047e2c4>] drm_fb_helper_initial_config+0x200/0x234 [ 62.628906] [<ffffffff804e5560>] radeon_fbdev_init+0xd4/0xf4 [ 62.628906] [<ffffffff804e0e08>] radeon_modeset_init+0x9bc/0xa18 [ 62.628906] [<ffffffff804bfc14>] radeon_driver_load_kms+0xdc/0x12c [ 62.628906] [<ffffffff8048b548>] drm_get_pci_dev+0x148/0x238 [ 62.628906] [<ffffffff80423564>] local_pci_probe+0x5c/0xd0 [ 62.628906] [<ffffffff80241ac4>] work_for_cpu_fn+0x1c/0x30 [ 62.628906] [<ffffffff802427c8>] process_one_work+0x274/0x3bc [ 62.628906] [<ffffffff80242934>] process_scheduled_works+0x24/0x44 [ 62.628906] [<ffffffff8024515c>] worker_thread+0x31c/0x3f4 [ 62.628906] [<ffffffff802497a8>] kthread+0x88/0x90 [ 62.628906] [<ffffffff80206794>] kernel_thread_helper+0x10/0x18 Signed-off-by: Huacai Chen <chenhc(a)lemote.com> Signed-off-by: Binbin Zhou <zhoubb(a)lemote.com> Cc: <stable(a)vger.kernel.org> --- drivers/gpu/drm/drm_irq.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index c798eea..c7a1348 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -981,7 +981,7 @@ EXPORT_SYMBOL(drm_vblank_off); */ void drm_vblank_pre_modeset(struct drm_device *dev, int crtc) { - /* vblank is not initialized (IRQ not installed ?) */ + /* vblank is not initialized (IRQ not installed ?), or has been freed */ if (!dev->num_crtcs) return; /* @@ -1003,6 +1003,10 @@ void drm_vblank_post_modeset(struct drm_device *dev, int crtc) { unsigned long irqflags; + /* vblank is not initialized (IRQ not installed ?), or has been freed */ + if (!dev->num_crtcs) + return; + if (dev->vblank_inmodeset[crtc]) { spin_lock_irqsave(&dev->vbl_lock, irqflags); dev->vblank_disable_allowed = 1; -- 1.7.7.3

4 4

[PATCH 00/15] Linux-3.10 ARM randconfig fixes
by Arnd Bergmann 31 May '13

31 May '13

Hi subsystem maintainers, These are a few patches left over from doing randconfig tests a couple of weeks ago. Please apply them directly into your trees unless you see problems. All patches can theoretically be seen as bug fixes for 3.10, but they are not critical, so applying them for 3.11 is fine as well. Arnd Arnd Bergmann (15): irqdomain: export irq_domain_add_simple mtd: omap2: allow bulding as a module drm/nouveau: use mdelay instead of large udelay constants [SCSI] nsp32: use mdelay instead of large udelay constants hwrng: bcm2835: fix MODULE_LICENSE tag cpuidle: calxeda: select ARM_CPU_SUSPEND cpufreq: spear needs cpufreq table thermal: cpu_cooling: fix stub function drm: always provide debugfs function prototypes drm/tilcd: select BACKLIGHT_LCD_SUPPORT iwlegacy: il_pm_ops is only provided for PM_SLEEP [media] davinci: vpfe_capture needs i2c [media] omap3isp: include linux/mm_types.h clk: tegra: provide tegra_periph_reset_assert alternative OF: remove #ifdef from linux/of_platform.h drivers/char/hw_random/bcm2835-rng.c | 2 +- drivers/cpufreq/Kconfig.arm | 1 + drivers/cpuidle/Kconfig | 1 + drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c | 3 ++- drivers/gpu/drm/tilcdc/Kconfig | 1 + drivers/media/platform/davinci/Kconfig | 3 +++ drivers/media/platform/omap3isp/ispqueue.h | 1 + drivers/mtd/nand/Kconfig | 2 +- drivers/net/wireless/iwlegacy/common.h | 6 +++--- drivers/scsi/nsp32.c | 2 +- include/drm/drmP.h | 3 +-- include/linux/clk/tegra.h | 5 +++++ include/linux/cpu_cooling.h | 4 ++-- include/linux/of_platform.h | 14 +++----------- kernel/irq/irqdomain.c | 1 + 15 files changed, 27 insertions(+), 22 deletions(-) Cc: "James E.J. Bottomley" <JBottomley(a)parallels.com> Cc: Artem Bityutskiy <artem.bityutskiy(a)linux.intel.com> Cc: Dave Airlie <airlied(a)redhat.com> Cc: David Woodhouse <dwmw2(a)infradead.org> Cc: Herbert Xu <herbert(a)gondor.apana.org.au> Cc: John W. Linville <linville(a)tuxdriver.com> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab(a)redhat.com> Cc: Rafael J. Wysocki <rjw(a)sisk.pl> Cc: Rob Clark <robdclark(a)gmail.com> Cc: Rob Herring <rob.herring(a)calxeda.com> Cc: Russell King <rmk+kernel(a)arm.linux.org.uk> Cc: Stephen Warren <swarren(a)wwwdotorg.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Viresh Kumar <viresh.kumar(a)linaro.org> Cc: cpufreq(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linux-mtd(a)lists.infradead.org Cc: linux-pm(a)vger.kernel.org Cc: linux-rpi-kernel(a)lists.infradead.org Cc: linux-scsi(a)vger.kernel.org -- 1.8.1.2

3 4

[PATCH] drm/mgag200: Add missing write to index before accessing data register
by Christopher Harvey 31 May '13

31 May '13

This is a bug fix for some versions of g200se cards while doing mode-setting. Signed-off-by: Christopher Harvey <charvey(a)matrox.com> Tested-by: Julia Lemire <jlemire(a)matrox.com> Acked-by: Julia Lemire <jlemire(a)matrox.com>Julia Lemire <jlemire(a)matrox.com> --- drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index deed0bd..5b1a9e7 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1034,13 +1034,14 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc, else hi_pri_lvl = 5; - WREG8(0x1fde, 0x06); - WREG8(0x1fdf, hi_pri_lvl); + WREG8(MGAREG_CRTCEXT_INDEX, 0x06); + WREG8(MGAREG_CRTCEXT_DATA, hi_pri_lvl); } else { + WREG8(MGAREG_CRTCEXT_INDEX, 0x06); if (mdev->reg_1e24 >= 0x01) - WREG8(0x1fdf, 0x03); + WREG8(MGAREG_CRTCEXT_DATA, 0x03); else - WREG8(0x1fdf, 0x04); + WREG8(MGAREG_CRTCEXT_DATA, 0x04); } } return 0; -- 1.8.1.5

1 1

[Bug 65193] New: [bisected] r600g, can't launch Gnome Shell and KDE since mesa updated to 5de41575a127eb8a6a0fe5c71a73b372f9b89f53
by bugzilla-daemon＠freedesktop.org 31 May '13

31 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=65193 Priority: medium Bug ID: 65193 Assignee: dri-devel(a)lists.freedesktop.org Summary: [bisected] r600g, can't launch Gnome Shell and KDE since mesa updated to 5de41575a127eb8a6a0fe5c71a73b372f9b89f53 Severity: critical Classification: Unclassified OS: All Reporter: alexandre.f.demers(a)gmail.com Hardware: All Status: NEW Version: git Component: Drivers/Gallium/r600 Product: Mesa I haven't been able to log in Gnome Shell or KDE lately since I updated mesa from git. Using XFCE and doing some tests, I've found out glxgears returns an assertion error when launch. glxgears fails with the following error: sb/sb_expr.cpp:455:fold_alu_op2: Assertion `v0 && v1 && n.dst[0]' failed. line 6: 15521 Trace/breakpoint trap (core dumped) $1 Bisecting ended up point to culprit commit: commit 5de41575a127eb8a6a0fe5c71a73b372f9b89f53 Author: Vadim Girlin <vadimgirlin(a)gmail.com> Date: Mon May 27 14:23:47 2013 +0400 r600g/sb: improve folding for SETcc Signed-off-by: Vadim Girlin <vadimgirlin(a)gmail.com> :040000 040000 96a6fd8851d84f62896ecfba6c4a7df5a7963325 ade9a1e6d7fd56ed8cf413a2138c38011f1b9827 M src Using latest drm, ddx from git on a Radeon HD6950 Cayman. -- You are receiving this mail because: You are the assignee for the bug.

1 9

[PATCHv2 0/7] Miscellaneous fixes to host1x
by Arto Merilainen 31 May '13

31 May '13

This patch series fixes two issues in the host1x driver: First, the command buffer validation routine had vulnerabilities that were not detected in earlier testing. Second, the return codes of some functions were misleading or completely missing. This caused the driver to give wrong return codes also to the userspace. The series is based on top of 3.10rc3. I have tested the patch series on cardhu by running host1x and gr2d test cases (available at [0]). I would appreciate any help in testing/reviewing these patches. Changes from v1: * Rebased on top of 3.10rc3 * Split firewall fixes to smaller patches * Reworked no-reloc case in firewall code. Fix in v1 was not sufficient in all cases * Dropped patch "Fix syncpoint wait return value" as it is not critical and discussion on it has not yet settled. * Fixed style and whitespace issues [0] https://gitorious.org/linux-host1x/libdrm-host1x Arto Merilainen (5): gpu: host1x: Check reloc table before usage gpu: host1x: Copy gathers before verification gpu: host1x: Fix memory access in syncpt request gpu: host1x: Fix client_managed type gpu: host1x: Rework CPU syncpoint increment Terje Bergstrom (2): gpu: host1x: Check INCR opcode correctly gpu: host1x: Don't reset firewall between gathers drivers/gpu/host1x/dev.h | 8 +-- drivers/gpu/host1x/drm/drm.c | 3 +- drivers/gpu/host1x/drm/gr2d.c | 2 +- drivers/gpu/host1x/hw/cdma_hw.c | 2 +- drivers/gpu/host1x/hw/syncpt_hw.c | 12 ++-- drivers/gpu/host1x/job.c | 135 +++++++++++++++++--------------------- drivers/gpu/host1x/syncpt.c | 26 +++----- drivers/gpu/host1x/syncpt.h | 13 ++-- 8 files changed, 85 insertions(+), 116 deletions(-) -- 1.8.1.5

4 11

[PATCH] MAINTAINERS: update path for drm tegra driver
by Ying Xue 31 May '13

31 May '13

Since 4231c6b01af9f0f3eeca4b8d0d87125d78233b41 commit, drm tegra driver was moved to host1x, however, its correspding entry in MAINTAINERS is not updated in time. Signed-off-by: Ying Xue <ying.xue(a)windriver.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7714c3c..d672968 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2702,7 +2702,7 @@ L: dri-devel(a)lists.freedesktop.org L: linux-tegra(a)vger.kernel.org T: git git://gitorious.org/thierryreding/linux.git S: Maintained -F: drivers/gpu/drm/tegra/ +F: drivers/gpu/host1x/drm/ F: Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt DSBR100 USB FM RADIO DRIVER -- 1.7.9.5

1 0

[PATCH v3 0/9] Clean up write-combining MTRR addition
by Andy Lutomirski 31 May '13

31 May '13

A fair number of drivers (mostly graphics) add write-combining MTRRs. Most ignore errors and most add the MTRR even on PAT systems which don't need to use MTRRs. This series adds new functions arch_phys_wc_{add,del} that, on PAT-less x86 systems with MTRRs, add MTRRs and report errors, and that do nothing otherwise. (Other architectures, if any, with a similar mechanism could implement them.) I've only tested the radeon driver, since I don't have test hardware easily available for the other drivers. Benefits include: - Simpler code - No more complaints about MTRR conflict warnings on PAT systems - Eventual unexporting of the MTRR API? This series eliminates about half of the mtrr_add calls in drivers/. Note: this series breaks and then fixes dritests from libdrm. The breakage is probably irrelevant for any practical purpose, and fixing it will be a bit complicated due to header file breakage that's only fixed in patch 8. Daniel, can you check that patch 1 is still okay? Changes from v2: - There's a new API phys_wc_to_mtrr_index (x86-only) to support drmGetMap - Minor cleanups to patche 1 and 5. - Patch 9 is new Changes from v1: - Helpers renamed - Lots of bugs fixed Andy Lutomirski (9): Add arch_phys_wc_{add,del} to manipulate WC MTRRs if needed drm (ast,cirrus,mgag200,nouveau,savage,vmwgfx): Remove drm_mtrr_{add,del} drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs drm,agpgart: Use pgprot_writecombine for AGP maps and make the MTRR optional i915: Use arch_phys_wc_{add,del} radeon: Switch to arch_phys_wc_add and add a missing ..._del uvesafb: Clean up MTRR code drm: Remove mtrr_add and mtrr_del fallback hack for non-MTRR systems drm: Don't leak phys_wc "handles" to userspace Andy Lutomirski (9): Add arch_phys_wc_{add,del} to manipulate WC MTRRs if needed drm (ast,cirrus,mgag200,nouveau,savage,vmwgfx): Remove drm_mtrr_{add,del} drm: Update drm_addmap and drm_mmap to use PAT WC instead of MTRRs drm,agpgart: Use pgprot_writecombine for AGP maps and make the MTRR optional i915: Use arch_phys_wc_{add,del} radeon: Switch to arch_phys_wc_add and add a missing ..._del uvesafb: Clean up MTRR code drm: Remove mtrr_add and mtrr_del fallback hack for non-MTRR systems drm: Don't leak phys_wc "handles" to userspace Documentation/fb/uvesafb.txt | 16 +++----- arch/x86/include/asm/io.h | 7 ++++ arch/x86/include/asm/mtrr.h | 10 ++++- arch/x86/kernel/cpu/mtrr/main.c | 71 ++++++++++++++++++++++++++++++++++ drivers/char/agp/frontend.c | 8 ++-- drivers/gpu/drm/ast/ast_ttm.c | 13 ++----- drivers/gpu/drm/cirrus/cirrus_ttm.c | 15 ++----- drivers/gpu/drm/drm_bufs.c | 26 +++++++++---- drivers/gpu/drm/drm_ioctl.c | 15 ++++++- drivers/gpu/drm/drm_pci.c | 8 ++-- drivers/gpu/drm/drm_stub.c | 10 +---- drivers/gpu/drm/drm_vm.c | 22 +++++------ drivers/gpu/drm/i915/i915_dma.c | 42 ++------------------ drivers/gpu/drm/mgag200/mgag200_ttm.c | 14 ++----- drivers/gpu/drm/nouveau/nouveau_ttm.c | 13 ++----- drivers/gpu/drm/radeon/radeon_object.c | 5 ++- drivers/gpu/drm/savage/savage_bci.c | 43 +++++++------------- drivers/gpu/drm/savage/savage_drv.h | 5 +-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 ++--- drivers/video/uvesafb.c | 70 ++++++++------------------------- include/drm/drmP.h | 34 +--------------- include/drm/drm_os_linux.h | 16 -------- include/linux/io.h | 25 ++++++++++++ include/video/uvesafb.h | 1 + 24 files changed, 230 insertions(+), 269 deletions(-) -- 1.8.1.4

4 19

[git pull] drm fixes
by Dave Airlie 31 May '13

31 May '13

Hi Linus, one qxl 32-bit warning fix, the rest is a bunch of radeon fixes from Alex for some issues we've been seeing. Dave. The following changes since commit c89b65e7fffef745bdd36c372aa0dea778fecbab: qxl: fix Kconfig deps - select FB_DEFERRED_IO (2013-05-28 17:03:37 +1000) are available in the git repository at: git://people.freedesktop.org/~airlied/linux drm-fixes for you to fetch changes up to 970fa986fadb1165cf38b45b70e98302a3bee497: drm/qxl: fix build warnings on 32-bit (2013-05-31 12:45:09 +1000) ---------------------------------------------------------------- Alex Deucher (4): drm/radeon: fix typo in cu_per_sh on verde drm/radeon: fix card_posted check for newer asics drm/radeon: don't check crtcs in card_posted() on cards without DCE drm/radeon: narrow scope of Apple re-POST hack Christian König (1): drm/radeon: UVD block on SUMO2 is the same as on SUMO Dave Airlie (2): Merge branch 'drm-fixes-3.10' of git://people.freedesktop.org/~agd5f/linux into drm-next drm/qxl: fix build warnings on 32-bit Kleber Sacilotto de Souza (1): radeon: use max_bus_speed to activate gen2 speeds drivers/gpu/drm/qxl/qxl_ioctl.c | 4 ++-- drivers/gpu/drm/qxl/qxl_kms.c | 9 +++++---- drivers/gpu/drm/radeon/evergreen.c | 10 +++------- drivers/gpu/drm/radeon/r600.c | 9 ++------- drivers/gpu/drm/radeon/radeon_device.c | 27 ++++++++++++++++----------- drivers/gpu/drm/radeon/rv770.c | 13 +++---------- drivers/gpu/drm/radeon/si.c | 2 +- 7 files changed, 32 insertions(+), 42 deletions(-)

1 0

X.org's GSoC 2013 projects
by Martin Peres 30 May '13

30 May '13

Hi everyone, On Monday, GSoC students were informed about which projects were selected to participate in the program. Here is a short overview of the students who have been selected to work with the X.org foundation: == DRM Render/Modeset Nodes == Student: David Herrmann Mentor: Dave Airlie (airlied) Blog: http://dvdhrm.wordpress.com/2013/05/29/drm-render-and-modeset-nodes/ == Add Xv support to Glamor == Student: Chuan He Mentors: Arthur Huillet (ahuillet) & Alex Deucher (agd5f) Blog: http://bigchuan.xanga.com/ == Reverse engineering NVidia's performance counters and exposing them via nv_perfmon == Student: Samuel Pitoiset (hakzsam) Mentor: Martin Peres (mupuf) Blog: http://hakzsam.wordpress.com/ <https://hakzsam.wordpress.com/> == Implementing GL_EXT_direct_state_access == Student: Dylan Noblesmith Mentor: Ian Romanick Proposal: http://www.cs.usm.maine.edu/~noblesmith/gsoc2013proposal-ext-direct-state-a… On a related note, Francisco Jerez (curro) has also been accepted to work on a TGSI backend for LLVM, mentored by Tom Stellar (tstellar). This effort will likely bring support for openCL to Nouveau and could also bring support to r300g, freedreno, etc... Proposal: http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-April/060917.html The project list looks pretty interesting, I hope the results will be just as good :) Martin (AKA mupuf)

1 0

← Newer
1
...
47
48
49
50
51
52
53
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2013