dri-devel May 2013

dri-devel@lists.freedesktop.org

116 participants
705 discussions

drm/exynos: make overlay data to be updated to valid hw
by Inki Dae 28 May '13

28 May '13

This patch makes sure that overlay data are updated to real hardware enabled when framebuffer is released. For this, this patch checks if crtc and encoder are valid or not, and then makes it waiting for signal synchroniztion to only valid encoder. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 9 ++++++--- drivers/gpu/drm/exynos/exynos_drm_encoder.h | 2 +- drivers/gpu/drm/exynos/exynos_drm_fb.c | 13 +++++++++++-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index c63721f..9a6e3fd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -220,18 +220,21 @@ static void exynos_drm_encoder_commit(struct drm_encoder *encoder) exynos_encoder->dpms = DRM_MODE_DPMS_ON; } -void exynos_drm_encoder_complete_scanout(struct drm_framebuffer *fb) +void exynos_drm_encoder_complete_scanout(struct drm_crtc *crtc) { struct exynos_drm_encoder *exynos_encoder; struct exynos_drm_manager_ops *ops; - struct drm_device *dev = fb->dev; + struct drm_device *dev = crtc->dev; struct drm_encoder *encoder; /* * make sure that overlay data are updated to real hardware - * for all encoders. + * for valid encoders. */ list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) { + if (encoder->crtc != crtc) + continue; + exynos_encoder = to_exynos_encoder(encoder); ops = exynos_encoder->manager->ops; diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.h b/drivers/gpu/drm/exynos/exynos_drm_encoder.h index 89e2fb0..e8dee1c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.h +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.h @@ -32,6 +32,6 @@ void exynos_drm_encoder_plane_mode_set(struct drm_encoder *encoder, void *data); void exynos_drm_encoder_plane_commit(struct drm_encoder *encoder, void *data); void exynos_drm_encoder_plane_enable(struct drm_encoder *encoder, void *data); void exynos_drm_encoder_plane_disable(struct drm_encoder *encoder, void *data); -void exynos_drm_encoder_complete_scanout(struct drm_framebuffer *fb); +void exynos_drm_encoder_complete_scanout(struct drm_crtc *crtc); #endif diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 0e04f4e..1fc7ae6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -68,12 +68,21 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, static void exynos_drm_fb_destroy(struct drm_framebuffer *fb) { struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); + struct drm_device *dev = fb->dev; + struct drm_crtc *crtc; unsigned int i; DRM_DEBUG_KMS("%s\n", __FILE__); - /* make sure that overlay data are updated before relesing fb. */ - exynos_drm_encoder_complete_scanout(fb); + list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) { + if (crtc->fb == fb) { + /* + * make sure that overlay data are updated before + * relesing fb. + */ + exynos_drm_encoder_complete_scanout(crtc); + } + } drm_framebuffer_cleanup(fb); -- 1.7.5.4

1 1

[PATCH -next] drm/i915: fix error return code in init_pipe_control()
by Wei Yongjun 28 May '13

28 May '13

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> Fix to return -ENOMEM in the kmap() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- drivers/gpu/drm/i915/intel_ringbuffer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 5698fae..9b97cf6 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -464,9 +464,11 @@ init_pipe_control(struct intel_ring_buffer *ring) goto err_unref; pc->gtt_offset = obj->gtt_offset; - pc->cpu_page = kmap(sg_page(obj->pages->sgl)); - if (pc->cpu_page == NULL) + pc->cpu_page = kmap(sg_page(obj->pages->sgl)); + if (pc->cpu_page == NULL) { + ret = -ENOMEM; goto err_unpin; + } DRM_DEBUG_DRIVER("%s pipe control offset: 0x%08x\n", ring->name, pc->gtt_offset);

3 2

[Bug 62889] New: ColorTiling results in glitches on Radeon HD 7970 + Glamor
by bugzilla-daemon＠freedesktop.org 28 May '13

28 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=62889 Priority: medium Bug ID: 62889 Assignee: dri-devel(a)lists.freedesktop.org Summary: ColorTiling results in glitches on Radeon HD 7970 + Glamor Severity: normal Classification: Unclassified OS: Linux (All) Reporter: kallisti5(a)unixzen.com Hardware: x86-64 (AMD64) Status: NEW Version: git Component: Drivers/Gallium/radeonsi Product: Mesa Versions tried Stable: LLVM 3.2 + Mesa 9.1.1 + kernel 3.8.4 Mainline LLVM 3.3-devel + mesa 9.2-devel + kernel 3.8.4 Gnome Desktop. Attempting to use Glamor on the Radeon HD 7970 results in odd screen artifacts. Cursor is not effected however. worked with agd5f in irc without any luck -- You are receiving this mail because: You are the assignee for the bug.

1 24

[Bug 52174] New: radeonsi enable GLSL 1.3 by default
by bugzilla-daemon＠freedesktop.org 28 May '13

28 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=52174 Bug #: 52174 Summary: radeonsi enable GLSL 1.3 by default Classification: Unclassified Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: medium Component: Drivers/DRI/R600 AssignedTo: dri-devel(a)lists.freedesktop.org ReportedBy: neotheuser(a)ymail.com GLSL 1.3 has now been static to the r600g driver. Shouldn't this be done for radeonsi as well? case PIPE_CAP_GLSL_FEATURE_LEVEL: return debug_get_bool_option("R600_GLSL130", FALSE) ? 130 : 120; to case PIPE_CAP_GLSL_FEATURE_LEVEL: return 130; Thanks! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

1 3

[PULL] drm-intel-fixes
by Daniel Vetter 28 May '13

28 May '13

Hi Dave, A few fixes, nothing shocking: - More Haswell pci ids. Includes a pile of marketing spare ids (which despite the spare moniker show up all over the place). - Fix a regression in handling modeset failures, resulting in black screens on 3 pipe setups when we've run out of pch plls (Chris). - Fix up the setcrtc semantics to unconditionally enable the outputs. Juding from git digging that has (kinda) always been the case and neatly fixes a few long-standing (i.e. forever) bug reports (Imre). - jiffies_timeout + 1 patches from Imre. They partially fix spurious wait_event failures in the interrupt-driven dp aux/i2c code. The other part is a core patch for the wait_event macros going in through -mm. A few patches more than strictly required since Imre is pushing for a general solution in 3.11. Cheers, Daniel The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://people.freedesktop.org/~danvet/drm-intel drm-intel-fixes for you to fetch changes up to 3598706b52cb45ba0a9e8aa99ce5ac59140f2b8b: drm/i915: avoid premature DP AUX timeouts (2013-05-22 13:51:26 +0200) ---------------------------------------------------------------- Chris Wilson (1): drm/i915: Propagate errors back from fb set-base Imre Deak (5): drm/i915: force full modeset if the connector is in DPMS OFF mode drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration drm/i915: use msecs_to_jiffies_timeout instead of open coding the same drm/i915: avoid premature timeouts in __wait_seqno() drm/i915: avoid premature DP AUX timeouts Rodrigo Vivi (1): drm/i915: Adding more reserved PCI IDs for Haswell. drivers/gpu/drm/i915/i915_drv.c | 46 +++++++++++++++++++++++-------- drivers/gpu/drm/i915/i915_drv.h | 15 +++++++++++ drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 49 ++++++++++++++++++++++------------ drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_i2c.c | 5 ++-- 6 files changed, 87 insertions(+), 32 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

1 1

[PATCH 1/2] drm/exynos: fix WINDOWS_NR checking to vidi driver
by Inki Dae 28 May '13

28 May '13

This patch just checks if win_data array range is valid or not correctly. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 24376c1..11a016d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -282,7 +282,7 @@ static void vidi_win_mode_set(struct device *dev, if (win == DEFAULT_ZPOS) win = ctx->default_win; - if (win < 0 || win > WINDOWS_NR) + if (win < 0 || win >= WINDOWS_NR) return; offset = overlay->fb_x * (overlay->bpp >> 3); @@ -332,7 +332,7 @@ static void vidi_win_commit(struct device *dev, int zpos) if (win == DEFAULT_ZPOS) win = ctx->default_win; - if (win < 0 || win > WINDOWS_NR) + if (win < 0 || win >= WINDOWS_NR) return; win_data = &ctx->win_data[win]; @@ -356,7 +356,7 @@ static void vidi_win_disable(struct device *dev, int zpos) if (win == DEFAULT_ZPOS) win = ctx->default_win; - if (win < 0 || win > WINDOWS_NR) + if (win < 0 || win >= WINDOWS_NR) return; win_data = &ctx->win_data[win]; -- 1.7.5.4

1 0

[git pull] drm fixes
by Dave Airlie 28 May '13

28 May '13

Hi Linus, this is mostly exynos and intel fixes, along with some vblank patches I lost from Rob a few months ago that make wayland work better on lots of GPUs, also a qxl kconfig fix. Dave. The following changes since commit b91fd4d5aad0c1124654341814067ca3f59490fc: Merge tag 'pci-v3.10-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci (2013-05-23 13:50:53 -0700) are available in the git repository at: git://people.freedesktop.org/~airlied/linux.git drm-fixes for you to fetch changes up to c89b65e7fffef745bdd36c372aa0dea778fecbab: qxl: fix Kconfig deps - select FB_DEFERRED_IO (2013-05-28 17:03:37 +1000) ---------------------------------------------------------------- Andrew Jones (1): qxl: fix Kconfig deps - select FB_DEFERRED_IO Chris Wilson (1): drm/i915: Propagate errors back from fb set-base Dave Airlie (3): Merge remote-tracking branch 'pfdo/drm-fixes' into drm-next Merge branch 'exynos-drm-fixes' of git://git.kernel.org/.../daeinki/drm-exynos into drm-next Merge branch 'drm-intel-fixes' of git://people.freedesktop.org/~danvet/drm-intel into drm-next Imre Deak (5): drm/i915: force full modeset if the connector is in DPMS OFF mode drm/i915: add msecs_to_jiffies_timeout to guarantee minimum duration drm/i915: use msecs_to_jiffies_timeout instead of open coding the same drm/i915: avoid premature timeouts in __wait_seqno() drm/i915: avoid premature DP AUX timeouts Inki Dae (1): drm/exynos: wait for the completion of pending page flip Lars-Peter Clausen (1): drm/exynos: exynos_hdmi: Pass correct pointer to free_irq() Rob Clark (6): drm/nouveau: use drm_send_vblank_event() helper drm/radeon: use drm_send_vblank_event() helper drm/shmob: use drm_send_vblank_event() helper drm/imx: use drm_send_vblank_event() helper drm/exynos: page flip fixes drm/exynos: use drm_send_vblank_event() helper Rodrigo Vivi (1): drm/i915: Adding more reserved PCI IDs for Haswell. Sachin Kamat (2): drm/exynos: exynos_drm_fbdev: Fix incorrect usage of IS_ERR_OR_NULL drm/exynos: exynos_drm_ipp: Fix incorrect usage of IS_ERR_OR_NULL Seung-Woo Kim (4): drm/exynos: cleanup device pointer usages drm/exynos: fix build warnings from ipp fimc drm/exynos: remove unnecessary devm_kfree drm/exynos: replace request_threaded_irq with devm function drivers/gpu/drm/exynos/exynos_drm_crtc.c | 27 ++++++++++------ drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12 +++---- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 10 +++--- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 6 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ++----- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 2 +- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 18 +++++------ drivers/gpu/drm/exynos/exynos_drm_rotator.c | 13 ++------ drivers/gpu/drm/exynos/exynos_drm_vidi.c | 4 +-- drivers/gpu/drm/exynos/exynos_hdmi.c | 21 +++++-------- drivers/gpu/drm/exynos/exynos_mixer.c | 14 ++++----- drivers/gpu/drm/i915/i915_drv.c | 46 ++++++++++++++++++++------- drivers/gpu/drm/i915/i915_drv.h | 15 +++++++++ drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 49 +++++++++++++++++++---------- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_i2c.c | 5 +-- drivers/gpu/drm/nouveau/nouveau_display.c | 13 ++------ drivers/gpu/drm/qxl/Kconfig | 1 + drivers/gpu/drm/radeon/radeon_display.c | 13 ++------ drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 19 +++-------- drivers/staging/imx-drm/ipuv3-crtc.c | 21 ++----------- 23 files changed, 163 insertions(+), 164 deletions(-)

1 0

[PATCH v2 1/3] drm/fb-helper: Don't clobber the display palette when fbdev isn't bound
by ville.syrjala＠linux.intel.com 27 May '13

27 May '13

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Perform the drm_fb_helper_is_bound() check to avoid clobbering the display palette of some other KMS client. While at it, fix up the locking by grabbing all modeset locks for the duration of the fb_setcmap operation. v2: Make a note of the locking changes in the commit message Reviewed-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/drm_fb_helper.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index b78cbe7..1b6ca23 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -626,12 +626,19 @@ static int setcolreg(struct drm_crtc *crtc, u16 red, u16 green, int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info) { struct drm_fb_helper *fb_helper = info->par; + struct drm_device *dev = fb_helper->dev; struct drm_crtc_helper_funcs *crtc_funcs; u16 *red, *green, *blue, *transp; struct drm_crtc *crtc; int i, j, rc = 0; int start; + drm_modeset_lock_all(dev); + if (!drm_fb_helper_is_bound(fb_helper)) { + drm_modeset_unlock_all(dev); + return -EBUSY; + } + for (i = 0; i < fb_helper->crtc_count; i++) { crtc = fb_helper->crtc_info[i].mode_set.crtc; crtc_funcs = crtc->helper_private; @@ -654,10 +661,12 @@ int drm_fb_helper_setcmap(struct fb_cmap *cmap, struct fb_info *info) rc = setcolreg(crtc, hred, hgreen, hblue, start++, info); if (rc) - return rc; + goto out; } crtc_funcs->load_lut(crtc); } + out: + drm_modeset_unlock_all(dev); return rc; } EXPORT_SYMBOL(drm_fb_helper_setcmap); -- 1.8.1.5

2 3

picking efifb driver over dri driver
by Christopher Harvey 27 May '13

27 May '13

I'm looking for the mechanism in the kernel that makes the decision to load the efifb driver over a dri one. Any tips? I've got a machine here that loads efifb and prevents dri drivers from loading. thanks, Chris

3 2

[Bug 65016] New: [radeonsi] X server segfaults at startup with mesa-9.1*
by bugzilla-daemon＠freedesktop.org 27 May '13

27 May '13

https://bugs.freedesktop.org/show_bug.cgi?id=65016 Priority: medium Bug ID: 65016 Assignee: dri-devel(a)lists.freedesktop.org Summary: [radeonsi] X server segfaults at startup with mesa-9.1* Severity: normal Classification: Unclassified OS: All Reporter: alexander(a)tsoy.me Hardware: Other Status: NEW Version: 9.1 Component: Drivers/Gallium/radeonsi Product: Mesa X server segfaults at startup whith mesa 9.1*. No problems with Git snapshots of mesa (these are the only versions of mesa which works on my system). I'll attach two backtraces below: 1. llvm and mesa was compiled with debugging support. Unfortunately this trace is incomplete =/ 2. llvm was compiled without debugging support, mesa was compiled whith debugging support. This trace is complete, but lacks a lot of debugging info. Hardware: 01:00.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI Cape Verde PRO [Radeon HD 7750] Subsystem: Giga-byte Technology Device 2260 Kernel driver in use: radeon Kernel modules: radeon Software: - mesa 9.1.3, also tried earlier minor versions - llvm 3.3_rc2, llvm Git - xorg-server-1.13.4 - xf86-video-ati-7.1.0 - glamor Git - linux 3.8.12 -- You are receiving this mail because: You are the assignee for the bug.

1 5

← Newer
1
...
49
50
51
52
53
54
55
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2013