dri-devel September 2014

dri-devel@lists.freedesktop.org

173 participants
1045 discussions

[GIT PULL FOR v3.18] DRM core change
by Laurent Pinchart 15 Sep '14

15 Sep '14

Hi Dave, The following changes since commit 98faa78ce7f1f986e11e7805d31b409782a6d2d4: Merge tag 'topic/drm-header-rework-2014-09-12' of git://anongit.freedesktop.org/drm-intel into drm-next (2014-09-13 07:01:49 +1000) are available in the git repository at: git://linuxtv.org/pinchartl/fbdev.git drm/next/core for you to fetch changes up to 41e58cca2f8d99fe3d5cf60ad1a59cf94b00cf7a: drm/gem: Fix kerneldoc typo (2014-09-15 12:30:21 +0300) ---------------------------------------------------------------- Laurent Pinchart (1): drm/gem: Fix kerneldoc typo drivers/gpu/drm/drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Regards, Laurent Pinchart

2 3

[PATCH] drm: Fixup locking for universal cursor planes
by Daniel Vetter 15 Sep '14

15 Sep '14

Bunch of things amiss: - Updating crtc->cursor_x/y was done without any locking. Spotted by David Herrmann. - Dereferencing crtc->cursor->fb was using the wrong lock, should take the crtc lock. - Grabbing _all_ modeset locks torpedoes the reason why we added fine-grained locks originally: Cursor updates shouldn't stall on background stuff like probing outputs. Best is to just grab the crtc lock around everything and drop all the other locking. The only issue is that we can't switch planes between crtcs with that, so make sure that never happens when someone uses universal plane helpers. This shouldn't be a possible regression ever since legacy ioctls also only grabbed the crtc lock, so switching crtcs was never possible for the underlying plane object. And i915 (the only user of universal cursors thus far) has fixed cursor->crtc links. Cc: David Herrmann <dh.herrmann(a)gmail.com> Cc: Pallavi G<pallavi.g(a)intel.com> Cc: Matt Roper <matthew.d.roper(a)intel.com> Reviewed-by: Matt Roper <matthew.d.roper(a)intel.com> Tested-by: Matt Roper <matthew.d.roper(a)intel.com> Reviewed-by: David Herrmann <dh.herrmann(a)gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_crtc.c | 51 ++++++++++++++++++++++++++++++---------------- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 2ec08e9269bd..4b8a262a8eb2 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -2262,21 +2262,19 @@ out: * * src_{x,y,w,h} are provided in 16.16 fixed point format */ -static int setplane_internal(struct drm_plane *plane, - struct drm_crtc *crtc, - struct drm_framebuffer *fb, - int32_t crtc_x, int32_t crtc_y, - uint32_t crtc_w, uint32_t crtc_h, - /* src_{x,y,w,h} values are 16.16 fixed point */ - uint32_t src_x, uint32_t src_y, - uint32_t src_w, uint32_t src_h) +static int __setplane_internal(struct drm_plane *plane, + struct drm_crtc *crtc, + struct drm_framebuffer *fb, + int32_t crtc_x, int32_t crtc_y, + uint32_t crtc_w, uint32_t crtc_h, + /* src_{x,y,w,h} values are 16.16 fixed point */ + uint32_t src_x, uint32_t src_y, + uint32_t src_w, uint32_t src_h) { - struct drm_device *dev = plane->dev; int ret = 0; unsigned int fb_width, fb_height; int i; - drm_modeset_lock_all(dev); /* No fb means shut it down */ if (!fb) { plane->old_fb = plane->fb; @@ -2344,10 +2342,28 @@ out: if (plane->old_fb) drm_framebuffer_unreference(plane->old_fb); plane->old_fb = NULL; - drm_modeset_unlock_all(dev); return ret; +} +static int setplane_internal(struct drm_plane *plane, + struct drm_crtc *crtc, + struct drm_framebuffer *fb, + int32_t crtc_x, int32_t crtc_y, + uint32_t crtc_w, uint32_t crtc_h, + /* src_{x,y,w,h} values are 16.16 fixed point */ + uint32_t src_x, uint32_t src_y, + uint32_t src_w, uint32_t src_h) +{ + int ret; + + drm_modeset_lock_all(plane->dev); + ret = __setplane_internal(plane, crtc, fb, + crtc_x, crtc_y, crtc_w, crtc_h, + src_x, src_y, src_w, src_h); + drm_modeset_unlock_all(plane->dev); + + return ret; } /** @@ -2713,6 +2729,7 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, int ret = 0; BUG_ON(!crtc->cursor); + WARN_ON(crtc->cursor->crtc != crtc && crtc->cursor->crtc != NULL); /* * Obtain fb we'll be using (either new or existing) and take an extra @@ -2732,11 +2749,9 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, fb = NULL; } } else { - mutex_lock(&dev->mode_config.mutex); fb = crtc->cursor->fb; if (fb) drm_framebuffer_reference(fb); - mutex_unlock(&dev->mode_config.mutex); } if (req->flags & DRM_MODE_CURSOR_MOVE) { @@ -2758,7 +2773,7 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc, * setplane_internal will take care of deref'ing either the old or new * framebuffer depending on success. */ - ret = setplane_internal(crtc->cursor, crtc, fb, + ret = __setplane_internal(crtc->cursor, crtc, fb, crtc_x, crtc_y, crtc_w, crtc_h, 0, 0, src_w, src_h); @@ -2794,10 +2809,12 @@ static int drm_mode_cursor_common(struct drm_device *dev, * If this crtc has a universal cursor plane, call that plane's update * handler rather than using legacy cursor handlers. */ - if (crtc->cursor) - return drm_mode_cursor_universal(crtc, req, file_priv); - drm_modeset_lock_crtc(crtc); + if (crtc->cursor) { + ret = drm_mode_cursor_universal(crtc, req, file_priv); + goto out; + } + if (req->flags & DRM_MODE_CURSOR_BO) { if (!crtc->funcs->cursor_set && !crtc->funcs->cursor_set2) { ret = -ENXIO; -- 2.0.1

1 0

Re: [PATCH v2] drm/ast: Improve mode matching
by Egbert Eich 15 Sep '14

15 Sep '14

Hi YC, you should probably be a bit more verbose in your changelog entry. As subject something like: Add reduced blanking modes for wide screen mode As text: Add reduced blanking modes, improve mode matching to identify these modes by their sync polarities. Y.C. Chen writes: > From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> > > Signed-off-by: Egbert Eich <eich(a)suse.com> > Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> > > v2: Add two pass mode selection, first try to match sync polarities and refresh > if this fails, try matching refresh only. Suggested by: Egbert Eich <eich(a)suse.com> > @@ -99,6 +104,8 @@ static struct ast_vbios_dclk_info dclk_table[] = { > {0x25, 0x65, 0x80}, /* 16: VCLK88.75 */ > {0x77, 0x58, 0x80}, /* 17: VCLK119 */ > {0x32, 0x67, 0x80}, /* 18: VCLK85_5 */ > + {0x6a, 0x6d, 0x80}, /* 19: VCLK97_75 */ Weren't you going to put this line into a separate patch - as it fixes a 'run off the end of the list' bug? > + {0x3b, 0x2c, 0x81}, /* 1A: VCLK118_25 */ > }; > > static struct ast_vbios_stdtable vbios_stdtable[] = { > @@ -245,8 +252,10 @@ static struct ast_vbios_enhtable res_1360x768[] = { I've tested your patches, so with the above changes: Tested-by: Egbert Eich <eich(a)suse.com> Cheers, Egbert.

3 2

[PULL] topic/core-stuff
by Daniel Vetter 15 Sep '14

15 Sep '14

Hi Dave, Here's the updated topic/core-stuff pull request with the two patches already merged into drm-fixes dropped. Cheers, Daniel The following changes since commit edbaae5a5cab89de0e64b8c03ebd9a8d5d266550: Merge tag 'topic/vblank-rework-2014-09-12' of git://anongit.freedesktop.org/drm-intel into drm-next (2014-09-12 19:04:53 +1000) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/topic/core-stuff-2014-09-15 for you to fetch changes up to d0fa1af40e784aaf7ebb7ba8a17b229bb3fa4c21: drm: Drop modeset locking from crtc init function (2014-09-15 08:56:30 +0200) ---------------------------------------------------------------- Chris Wilson (1): drm: Include task->name and master status in debugfs clients info Clint Taylor (2): drm/edid: Reduce horizontal timings for pixel replicated modes drm/i915/hdmi: Enable pipe pixel replication for SD interlaced modes Daniel Vetter (1): drm: Drop modeset locking from crtc init function Julia Lawall (1): drm: use c99 initializers in structures Laurent Pinchart (1): drm/gem: Fix kerneldoc typo Randy Dunlap (1): drm: fix drm_modeset_lock.h kernel-doc notation drivers/gpu/drm/drm_crtc.c | 5 -- drivers/gpu/drm/drm_edid.c | 117 +++++++++++++++++++------------------- drivers/gpu/drm/drm_gem.c | 2 +- drivers/gpu/drm/drm_info.c | 27 +++++++-- drivers/gpu/drm/i915/intel_hdmi.c | 15 ++++- drivers/gpu/drm/sti/sti_vtac.c | 12 +++- include/drm/drm_modeset_lock.h | 4 +- 7 files changed, 107 insertions(+), 75 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

1 0

[PATCH 00/16] R-Car Display Unit DT bindings
by Laurent Pinchart 15 Sep '14

15 Sep '14

Hello, This patch series documents and implements DT bindings support for the R-Car Display Unit (DU). Unlike the previous attempt that tried to create a new model for composite display devices and failed to get any real traction from DRM developers, the approach taken here focuses on DT bindings without requiring core changes outside of the DU driver. Aside of the usual boring core properties (compatible, reg, interrupts and clocks), the proposed bindings use the OF graph bindings to model connections between the DU output video ports and the on-board and off-board components. As such they do not depend on any particular implementation or implementation philosophy. The series starts by documenting DT bindings for the devices present on the Marzen, Lager and Koelsch boards not already supported in the mainline kernel (01/16 to 05/16) and for the DU (06/16). It then reworks the rcar_du platform data to ease implementation of the DT bindings (07/16). The next step is to implement support for the DU DT bindings in the R-Car DU DRM driver (08/16). Finally the remaining patches add the DU DT nodes for all supported SoCs (09/16 to 11/16), remove DU platform data from the DT-based board files (12/16 and 13/16) and describe the on-board devices connected to the DU outputs for the Marzen, Lager and Koelsch boards (14/16 to 16/16). Cc: devicetree(a)vger.kernel.org Cc: linux-fbdev(a)vger.kernel.org Laurent Pinchart (16): devicetree: Add vendor prefix "mitsubishi" to vendor-prefixes.txt devicetree: Add vendor prefix "thine" to vendor-prefixes.txt video: Add DT binding documentation for VGA connector video: Add ADV7123 DT bindings documentation video: Add THC63LVDM83D DT bindings documentation video: Add DT bindings for the R-Car Display Unit drm/rcar-du: Use struct videomode in platform data drm/rcar-du: Add OF support ARM: shmobile: r8a7779: Add DU node to device tree ARM: shmobile: r8a7790: Add DU node to device tree ARM: shmobile: r8a7791: Add DU node to device tree ARM: shmobile: lager-reference: Remove DU platform device ARM: shmobile: koelsch-reference: Remove DU platform device ARM: shmobile: marzen: Enable DU device in DT ARM: shmobile: lager: Enable DU device in DT ARM: shmobile: koelsch: Enable DU device in DT .../devicetree/bindings/vendor-prefixes.txt | 2 + .../devicetree/bindings/video/adi,adv7123.txt | 50 +++++ .../devicetree/bindings/video/renesas,du.txt | 84 ++++++++ .../devicetree/bindings/video/thine,thc63lvdm83d | 50 +++++ .../devicetree/bindings/video/vga-connector.txt | 28 +++ arch/arm/boot/dts/r8a7779-marzen.dts | 106 ++++++++++ arch/arm/boot/dts/r8a7779.dtsi | 24 +++ arch/arm/boot/dts/r8a7790-lager.dts | 78 ++++++- arch/arm/boot/dts/r8a7790.dtsi | 39 ++++ arch/arm/boot/dts/r8a7791-koelsch.dts | 43 +++- arch/arm/boot/dts/r8a7791.dtsi | 30 +++ arch/arm/mach-shmobile/board-koelsch-reference.c | 74 ------- arch/arm/mach-shmobile/board-koelsch.c | 19 +- arch/arm/mach-shmobile/board-lager-reference.c | 81 -------- arch/arm/mach-shmobile/board-lager.c | 19 +- arch/arm/mach-shmobile/board-marzen.c | 19 +- drivers/gpu/drm/rcar-du/Kconfig | 1 + drivers/gpu/drm/rcar-du/rcar_du_drv.c | 170 ++++++++------- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 + drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 11 +- drivers/gpu/drm/rcar-du/rcar_du_encoder.h | 3 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 231 +++++++++++++++++++-- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 43 ++-- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.h | 3 +- include/linux/platform_data/rcar-du.h | 4 +- 25 files changed, 904 insertions(+), 310 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/adi,adv7123.txt create mode 100644 Documentation/devicetree/bindings/video/renesas,du.txt create mode 100644 Documentation/devicetree/bindings/video/thine,thc63lvdm83d create mode 100644 Documentation/devicetree/bindings/video/vga-connector.txt -- Regards, Laurent Pinchart

4 21

Question on UAPI for fences
by Christian König 15 Sep '14

15 Sep '14

Hello everyone, to allow concurrent buffer access by different engines beyond the multiple readers/single writer model that we currently use in radeon and other drivers we need some kind of synchonization object exposed to userspace. My initial patch set for this used (or rather abused) zero sized GEM buffers as fence handles. This is obviously isn't the best way of doing this (to much overhead, rather ugly etc...), Jerome commented on this accordingly. So what should a driver expose instead? Android sync points? Something else? Please discuss and/or advise, Christian.

7 18

[PATCH] nouveau: bump driver patchlevel to 1.2.1
by Maarten Lankhorst 15 Sep '14

15 Sep '14

Allows userspace to detect shared fences are supported. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> --- drivers/gpu/drm/nouveau/nouveau_drm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Dave, can you include this in drm-next? It should allow me to optimize nouveau's vdpau decoding a bit. diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.h b/drivers/gpu/drm/nouveau/nouveau_drm.h index b02b02452c85..8ae36f265fb8 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.h +++ b/drivers/gpu/drm/nouveau/nouveau_drm.h @@ -10,7 +10,7 @@ #define DRIVER_MAJOR 1 #define DRIVER_MINOR 2 -#define DRIVER_PATCHLEVEL 0 +#define DRIVER_PATCHLEVEL 1 /* * 1.1.1: @@ -26,6 +26,8 @@ * 1.2.0: * - object api exposed to userspace * - fermi,kepler,maxwell zbc + * 1.2.1: + * - allow concurrent access to bo's mapped read/write. */ #include <nvif/client.h> -- 2.0.4

1 0

[Bug 83835] Multi Stream Transport (MST) 1.2 Support
by bugzilla-daemon＠freedesktop.org 15 Sep '14

15 Sep '14

https://bugs.freedesktop.org/show_bug.cgi?id=83835 Alex Deucher <agd5f(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Assignee|xorg-driver-ati(a)lists.x.org |dri-devel(a)lists.freedesktop | |.org QA Contact|xorg-team(a)lists.x.org | Product|xorg |DRI Component|Driver/Radeon |DRM/Radeon --- Comment #1 from Alex Deucher <agd5f(a)yahoo.com> --- MST support is not implemented yet. Dave started hacking on it, but as far as I know, it's not working yet: http://cgit.freedesktop.org/~airlied/linux/log/?h=radeon-mst-hacks -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 73338] Fan speed in idle at 40% with radeonsi and at 18% with catalyst
by bugzilla-daemon＠freedesktop.org 14 Sep '14

14 Sep '14

https://bugs.freedesktop.org/show_bug.cgi?id=73338 --- Comment #35 from Martin Peres <martin.peres(a)ensi-bourges.fr> --- (In reply to comment #31) > A quick update - I was finally able to retrieve all needed data from fglrx > (via some ADL SDK overdrive6 tinkering). It seems there is a lot of work > (e.g. there is a feature for setting series of pairs > temperature<->fanspeed), but at least I figured out the purpose of used > registers and data values (I hope). Those are called trip points ;) Well done! > > So I'll try to come up with basic functionality and hwmon interface this > week. Have fun ;) -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 73338] Fan speed in idle at 40% with radeonsi and at 18% with catalyst
by bugzilla-daemon＠freedesktop.org 14 Sep '14

14 Sep '14

https://bugs.freedesktop.org/show_bug.cgi?id=73338 --- Comment #34 from Anton L. <antonl1911(a)gmail.com> --- Created attachment 106260 --> https://bugs.freedesktop.org/attachment.cgi?id=106260&action=edit mmiotrace dump for radeon 7850 Here is mmiotrace dump for my radeon 7850, in single-CPU mode. -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2014