dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH 1/2] drm/crtc_helper/set_config: Remove redundant handling when set->fb is NULL
by Liu Ying 14 Jan '16

14 Jan '16

We've done sanity NULL pointer check on set->fb at the beginning of drm_crtc_helper_set_config() and bailed out if necessary, thus any later on check or case handling is redundant. Signed-off-by: Liu Ying <gnuiyl(a)gmail.com> --- drivers/gpu/drm/drm_crtc_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index ef53475..cd3fbc1 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -541,8 +541,6 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) if (set->crtc->primary->fb == NULL) { DRM_DEBUG_KMS("crtc has no fb, full mode set\n"); mode_changed = true; - } else if (set->fb == NULL) { - mode_changed = true; } else if (set->fb->pixel_format != set->crtc->primary->fb->pixel_format) { mode_changed = true; -- 2.5.0

2 2

[Bug 91865] [r600g] GPU hang in 'gsraytrace' - NI/Turks (6670)
by bugzilla-daemon＠freedesktop.org 14 Jan '16

14 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=91865 Lukáš Krejza <gryffus(a)hkfree.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.freedesktop.or | |g/show_bug.cgi?id=93706 -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH 0/7] drm/exynos/hdmi: add Exynos5433 support
by Andrzej Hajda 14 Jan '16

14 Jan '16

Hi Inki, Krzysztof, This patchset adds support for Exynos 5433 HDMI. There are also few preparation/cleanup patches. All patches except one touch only exynos-drm. Sixth patch adds binding properties for Exynos5433 HDMI, Krzysztof could you look at it. The patchset is based on exynos-drm-next. Regards Andrzej Andrzej Hajda (7): drm/exynos/hdmi: clock code re-factoring drm/exynos/hdmi: constify global variables drm/exynos/hdmi: use array specifier for HDMI-PHY configurations drm/exynos/hdmi: code cleanup drm/exynos/hdmi: stop programming registers with default values dt-bindings: exynos_hdmi: add bindings for Exynos5433 variant drm/exynos/hdmi: add Exynos5433 support .../devicetree/bindings/video/exynos_hdmi.txt | 27 +- drivers/gpu/drm/exynos/exynos_hdmi.c | 454 +++++++++++++++------ drivers/gpu/drm/exynos/regs-hdmi.h | 9 +- 3 files changed, 352 insertions(+), 138 deletions(-) -- 1.9.1

3 14

[PATCH v7 1/2] Documentation: bridge: Add documentation for ps8640 DT properties
by Jitao Shi 14 Jan '16

14 Jan '16

Add documentation for DT properties supported by ps8640 DSI-eDP converter. Signed-off-by: Jitao Shi <jitao.shi(a)mediatek.com> Acked-by: Rob Herring <robh(a)kernel.org> Reviewed-by: Philipp Zabel <p.zabel(a)pengutronix.de> --- Change since v6: - No change --- .../devicetree/bindings/display/bridge/ps8640.txt | 43 ++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt diff --git a/Documentation/devicetree/bindings/display/bridge/ps8640.txt b/Documentation/devicetree/bindings/display/bridge/ps8640.txt new file mode 100644 index 0000000..a3e0971 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ps8640.txt @@ -0,0 +1,43 @@ +ps8640-bridge bindings + +Required properties: + - compatible: "parade,ps8640" + - reg: first page address of the bridge. + - sleep-gpios: OF device-tree gpio specification for PD_ pin. + - reset-gpios: OF device-tree gpio specification for reset pin. + - mode-sel-gpios: OF device-tree gpio specification for mode-sel pin. + - vdd12-supply: OF device-tree regulator specification for 1.2V power. + - vdd33-supply: OF device-tree regulator specification for 3.3V power. + - ports: The device node can contain video interface port nodes per + the video-interfaces bind[1]. For port@0,set the reg = <0> as + ps8640 dsi in and port@1,set the reg = <1> as ps8640 eDP out. + +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + edp-bridge@18 { + compatible = "parade,ps8640"; + reg = <0x18>; + sleep-gpios = <&pio 116 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 115 GPIO_ACTIVE_HIGH>; + mode-sel-gpios = <&pio 92 GPIO_ACTIVE_HIGH>; + vdd12-supply = <&ps8640_fixed_1v2>; + vdd33-supply = <&mt6397_vgp2_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + ps8640_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + port@1 { + reg = <1>; + ps8640_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + }; -- 1.7.9.5

5 5

[PATCH] drm: avoid uninitialized timestamp use in wait_vblank
by Arnd Bergmann 13 Jan '16

13 Jan '16

gcc warns about the timestamp in drm_wait_vblank being possibly used without an initialization: drivers/gpu/drm/drm_irq.c: In function 'drm_wait_vblank': drivers/gpu/drm/drm_irq.c:1755:28: warning: 'now.tv_usec' may be used uninitialized in this function [-Wmaybe-uninitialized] vblwait->reply.tval_usec = now.tv_usec; drivers/gpu/drm/drm_irq.c:1754:27: warning: 'now.tv_sec' may be used uninitialized in this function [-Wmaybe-uninitialized] vblwait->reply.tval_sec = now.tv_sec; This can happen if drm_vblank_count_and_time() returns 0 in its error path. To sanitize the error case, I'm changing that function to return a zero timestamp when it fails. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Fixes: e6ae8687a87b ("drm: idiot-proof vblank") --- I'm going through the maybe-unused warnings in randconfig builds, this one is apparently not a false positive, although it only happens if something else has already gone wrong. diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index d12a4efa651b..d32ff169fdb8 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -939,8 +939,10 @@ u32 drm_vblank_count_and_time(struct drm_device *dev, unsigned int pipe, int count = DRM_TIMESTAMP_MAXRETRIES; u32 cur_vblank; - if (WARN_ON(pipe >= dev->num_crtcs)) + if (WARN_ON(pipe >= dev->num_crtcs)) { + *vblanktime = (struct timeval) { 0 }; return 0; + } /* * Vblank timestamps are read lockless. To ensure consistency the vblank

1 0

[pull] radeon and amdgpu drm-next-4.5
by Alex Deucher 13 Jan '16

13 Jan '16

Hi Dave, A few more misc things for radeon and amdgpu for 4.5: - TTM fixes for imported buffers - amdgpu fixes to avoid -ENOMEM in CS ioctl - CZ UVD and VCE clock force options for debugging video issues - A couple of ACP prerequisites - Misc fixes The following changes since commit 57b4f7e68720e8a9f5e6e9e61446ec36822e4c57: Merge branch 'linux-4.5' of git://github.com/skeggsb/linux into drm-next (2016-01-11 11:48:18 +1000) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-next-4.5 for you to fetch changes up to d8e0cae645504a787b05abfb91afee8cd7fa1701: drm/amdgpu: validate duplicates first (2016-01-13 12:22:59 -0500) ---------------------------------------------------------------- Alex Deucher (6): drm/amdgpu/cgs: add an interface to access PCI resources drm/amdgpu: add irq domain support drm/amdgpu/cz: add code to enable forcing UVD clocks drm/amdgpu/cz: add code to enable forcing VCE clocks drm/amdgpu/cz: force uvd clocks when sclks are forced drm/amdgpu/cz: force vce clocks when sclks are forced Christian König (5): drm/ttm: fix adding foreign BOs to the LRU during init v2 drm/ttm: fix adding foreign BOs to the swap LRU drm/ttm: add ttm_bo_move_to_lru_tail function v2 drm/amdgpu: move VM page tables to the LRU end on CS v2 drm/amdgpu: validate duplicates first Chunming Zhou (1): drm/amdgpu: fix lost sync_to if scheduler is enabled. Geliang Tang (2): drm/amdgpu: use kobj_to_dev() drm/radeon: use kobj_to_dev() Rex Zhu (1): drm/amd/powerplay: fix static checker warning for return meaningless value. drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 36 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 11 +- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 108 +++++++- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 27 ++ drivers/gpu/drm/amd/amdgpu/cik_ih.c | 6 + drivers/gpu/drm/amd/amdgpu/cz_dpm.c | 273 ++++++++++++++++++++- drivers/gpu/drm/amd/amdgpu/cz_dpm.h | 2 + drivers/gpu/drm/amd/amdgpu/cz_ih.c | 7 + drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 + drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 7 + drivers/gpu/drm/amd/include/cgs_common.h | 34 +++ .../gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 6 +- drivers/gpu/drm/radeon/radeon_pm.c | 2 +- drivers/gpu/drm/ttm/ttm_bo.c | 31 ++- include/drm/ttm/ttm_bo_api.h | 10 + 19 files changed, 564 insertions(+), 21 deletions(-)

1 0

[PATCH] x86: Add an explicit barrier() to clflushopt()
by Chris Wilson 13 Jan '16

13 Jan '16

During testing we observed that the last cacheline was not being flushed from a mb() for (addr = addr & -clflush_size; addr < end; addr += clflush_size) clflushopt(); mb() loop (where the initial addr and end were not cacheline aligned). Changing the loop from addr < end to addr <= end, or replacing the clflushopt() with clflush() both fixed the testcase. Hinting that GCC was miscompling the assembly within the loop and specifically the alternative within clflushopt() was confusing the loop optimizer. Adding a barrier() into clflushopt() is enough for GCC to dtrt, but solving why GCC is not seeing the constraints from the alternative_io() would be smarter... Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92501 Testcase: gem_tiled_partial_pwrite_pread/read Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Ross Zwisler <ross.zwisler(a)linux.intel.com> Cc: H. Peter Anvin <hpa(a)linux.intel.com> Cc: Imre Deak <imre.deak(a)intel.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: dri-devel(a)lists.freedesktop.org --- arch/x86/include/asm/special_insns.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h index 2270e41b32fd..0c7aedbf8930 100644 --- a/arch/x86/include/asm/special_insns.h +++ b/arch/x86/include/asm/special_insns.h @@ -199,6 +199,11 @@ static inline void clflushopt(volatile void *__p) ".byte 0x66; clflush %P0", X86_FEATURE_CLFLUSHOPT, "+m" (*(volatile char __force *)__p)); + /* GCC (4.9.1 and 5.2.1 at least) appears to be very confused when + * meeting this alternative() and demonstrably miscompiles loops + * iterating over clflushopts. + */ + barrier(); } static inline void clwb(volatile void *__p) -- 2.6.1

6 28

[PATCH 1/5] drm/ttm: fix adding foreign BOs to the LRU during init v2
by Christian König 13 Jan '16

13 Jan '16

From: Christian König <christian.koenig(a)amd.com> If we import a BO with an external reservation object we don't reserve/unreserve it. So we never add it to the LRU causing a possible deny of service. v2: fix typo in commit message Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 745e996..a98a5d5 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -1170,9 +1170,15 @@ int ttm_bo_init(struct ttm_bo_device *bdev, if (likely(!ret)) ret = ttm_bo_validate(bo, placement, interruptible, false); - if (!resv) + if (!resv) { ttm_bo_unreserve(bo); + } else if (!(bo->mem.placement & TTM_PL_FLAG_NO_EVICT)) { + spin_lock(&bo->glob->lru_lock); + ttm_bo_add_to_lru(bo); + spin_unlock(&bo->glob->lru_lock); + } + if (unlikely(ret)) ttm_bo_unref(&bo); -- 2.5.0

3 8

[PATCH v2 00/16] omapdrm: Implement dma_buf import
by Laurent Pinchart 13 Jan '16

13 Jan '16

Hello, This patch series implements support for dma_buf import in the omapdrm driver. The patches are based on top of the latest drm-next branch and can be found in my git tree at git://linuxtv.org/pinchartl/fbdev.git omapdrm/dmabuf-import The first two patches are unrelated fixes and enhancements, but I've included them in the series to avoid merge conflicts. The next 13 patches are miscellaneous fixes, cleanups and refactoring to prepare for patch 16/16 that implements dma_buf import. The code has been successfully tested with the vivid driver as an exporter, using a hacked version that uses uncached CPU mappings in vivid when filling the buffers. vivid is a test driver that generates a test pattern using the CPU with cached mappings by default, resulting in corruption on the screen due to missing cache handling. As the problem doesn't occur when sharing buffers not touched by the CPU or touched through uncached mappings only, it will be addressed separately. Changes since v1: - Added patch 11/16 ("drm: omapdrm: gem: Fix GEM object destroy in error path") - Drop the dma-buf reexport check, reexport is handled by the DRM core - Make the OMAP_BO_USER_MASK definition private Laurent Pinchart (16): drm: omapdrm: Fix plane state free in plane reset handler drm: omapdrm: Make fbdev emulation optional drm: omapdrm: gem: Remove unused function prototypes drm: omapdrm: gem: Remove forward declarations drm: omapdrm: gem: Group functions by purpose drm: omapdrm: gem: Move global usergart variable to omap_drm_private drm: omapdrm: gem: Remove omap_drm_private has_dmm field drm: omapdrm: gem: Mask out private flags passed from userspace drm: omapdrm: gem: Clean up GEM objects memory flags drm: omapdrm: gem: Free the correct memory object drm: omapdrm: gem: Fix GEM object destroy in error path drm: omapdrm: gem: Don't free mmap offset twice drm: omapdrm: gem: Simplify error handling when creating GEM object drm: omapdrm: gem: Remove check for impossible condition drm: omapdrm: gem: Refactor GEM object allocation drm: omapdrm: gem: Implement dma_buf import drivers/gpu/drm/omapdrm/Makefile | 3 +- drivers/gpu/drm/omapdrm/omap_debugfs.c | 4 + drivers/gpu/drm/omapdrm/omap_drv.c | 17 +- drivers/gpu/drm/omapdrm/omap_drv.h | 16 +- drivers/gpu/drm/omapdrm/omap_fbdev.c | 6 +- drivers/gpu/drm/omapdrm/omap_gem.c | 501 +++++++++++++++++++----------- drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 53 +++- drivers/gpu/drm/omapdrm/omap_plane.c | 55 ++-- 8 files changed, 421 insertions(+), 234 deletions(-) -- Regards, Laurent Pinchart

2 18

[PATCH] uapi: use __u8 from linux/types.h
by Gleb Fotengauer-Malinovskiy 13 Jan '16

13 Jan '16

Kernel headers should use linux/types.h based definitions. Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm(a)altlinux.org> --- include/uapi/linux/virtio_gpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h index 7a63faa..4b04ead 100644 --- a/include/uapi/linux/virtio_gpu.h +++ b/include/uapi/linux/virtio_gpu.h @@ -287,7 +287,7 @@ struct virtio_gpu_get_capset { /* VIRTIO_GPU_RESP_OK_CAPSET */ struct virtio_gpu_resp_capset { struct virtio_gpu_ctrl_hdr hdr; - uint8_t capset_data[]; + __u8 capset_data[]; }; #define VIRTIO_GPU_EVENT_DISPLAY (1 << 0) -- glebfm

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016