dri-devel January 2016

dri-devel@lists.freedesktop.org

194 participants
1200 discussions

[PATCH] etnaviv: etnaviv_drv: Remove owner assignment from platform_driver
by Fabio Estevam 12 Jan '16

12 Jan '16

This platform_driver does not need to set an owner as it will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 5c89ebb..e885898 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -668,7 +668,6 @@ static struct platform_driver etnaviv_platform_driver = { .probe = etnaviv_pdev_probe, .remove = etnaviv_pdev_remove, .driver = { - .owner = THIS_MODULE, .name = "etnaviv", .of_match_table = dt_match, }, -- 1.9.1

2 1

[PATCH] drm: Release driver references to handle before making it available again
by Chris Wilson 12 Jan '16

12 Jan '16

When userspace closes a handle, we remove it from the file->object_idr and then tell the driver to drop its references to that file/handle. However, as the file/handle is already available again for reuse, it may be reallocated back to userspace and active on a new object before the driver has had a chance to drop the old file/handle references. Whilst calling back into the driver, we have to drop the file->table_lock spinlock and so to prevent reusing the closed handle we mark that handle as stale in the idr, perform the callback and then remove the handle. It is then possible for a lookup on that handle to return an error object and so all callers of idr_find(file->object_idr) need to check against IS_ERR_OR_NULL() instead. Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: dri-devel(a)lists.freedesktop.org Cc: David Airlie <airlied(a)linux.ie> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: Russell King <linux+etnaviv(a)arm.linux.org.uk> Cc: Christian Gmeiner <christian.gmeiner(a)gmail.com> Cc: Daniel Vetter <daniel.vetter(a)intel.com> Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Rob Clark <robdclark(a)gmail.com> Cc: Eric Anholt <eric(a)anholt.net> Cc: Dan Carpenter <dan.carpenter(a)oracle.com> Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/drm_gem.c | 11 +++++++---- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- drivers/gpu/drm/vc4/vc4_gem.c | 2 +- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 2e8c77e71e1f..c56a0b49d829 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -294,18 +294,21 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle) spin_lock(&filp->table_lock); /* Check if we currently have a reference on the object */ - obj = idr_find(&filp->object_idr, handle); - if (obj == NULL) { + obj = idr_replace(&filp->object_idr, ERR_PTR(-ENOENT), handle); + if (IS_ERR(obj)) { spin_unlock(&filp->table_lock); return -EINVAL; } dev = obj->dev; + spin_unlock(&filp->table_lock); /* Release reference and decrement refcount. */ + drm_gem_object_release_handle(handle, obj, filp); + + spin_lock(&filp->table_lock); idr_remove(&filp->object_idr, handle); spin_unlock(&filp->table_lock); - drm_gem_object_release_handle(handle, obj, filp); return 0; } EXPORT_SYMBOL(drm_gem_handle_delete); @@ -597,7 +600,7 @@ drm_gem_object_lookup(struct drm_device *dev, struct drm_file *filp, /* Check if we currently have a reference on the object */ obj = idr_find(&filp->object_idr, handle); - if (obj == NULL) { + if (IS_ERR_OR_NULL(obj)) { spin_unlock(&filp->table_lock); return NULL; } diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index 1aba01a999df..77b549cb1301 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -78,7 +78,7 @@ static int submit_lookup_objects(struct etnaviv_gem_submit *submit, * all under single table_lock just hit object_idr directly: */ obj = idr_find(&file->object_idr, bo->handle); - if (!obj) { + if (IS_ERR_OR_NULL(obj)) { DRM_ERROR("invalid handle %u at index %u\n", bo->handle, i); ret = -EINVAL; diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index dccb517361b3..500bcff9ad48 100644 --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c @@ -106,7 +106,7 @@ eb_lookup_vmas(struct eb_vmas *eb, * or create the VMA without using GFP_ATOMIC */ for (i = 0; i < args->buffer_count; i++) { obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle)); - if (obj == NULL) { + if (IS_ERR_OR_NULL(obj)) { spin_unlock(&file->table_lock); DRM_DEBUG("Invalid object handle %d at index %d\n", exec[i].handle, i); diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 6d7cd3fe21e7..c6d7abd53d20 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -90,7 +90,7 @@ static int submit_lookup_objects(struct msm_gem_submit *submit, * all under single table_lock just hit object_idr directly: */ obj = idr_find(&file->object_idr, submit_bo.handle); - if (!obj) { + if (IS_ERR_OR_NULL(obj)) { DRM_ERROR("invalid handle %u at index %u\n", submit_bo.handle, i); ret = -EINVAL; goto out_unlock; diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index 48ce30a6f4b5..9138702a1c67 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -494,7 +494,7 @@ vc4_cl_lookup_bos(struct drm_device *dev, for (i = 0; i < exec->bo_count; i++) { struct drm_gem_object *bo = idr_find(&file_priv->object_idr, handles[i]); - if (!bo) { + if (IS_ERR_OR_NULL(bo)) { DRM_ERROR("Failed to look up GEM BO %d: %d\n", i, handles[i]); ret = -EINVAL; -- 2.7.0.rc3

2 7

[PATCH v2 0/3] drm/exynos: introduce generic zpos property
by Marek Szyprowski 12 Jan '16

12 Jan '16

Hello all, This patch series is a continuation of rework of blending support in Exynos DRM driver. Some background can be found here: http://www.spinics.net/lists/dri-devel/msg96969.html Daniel Vetter suggested that zpos property should be made generic, with well-defined semantics. This patchset is my proposal for such generic zpos property: - added zpos properties to drm core and plane state structures, - added helpers for normalizing zpos properties of given set of planes, - well defined semantics: planes are sorted by zpos values and then plane id value if zpos equals. Patches are based on top of latest exynos-drm-next branch. Best regards Marek Szyprowski Samsung R&D Institute Poland Changelog: v2: - dropped 2 fixes for Exynos DRM, which got merged in meantime - added more comments and kernel docs for core functions as suggested by Daniel Vetter - reworked initialization of zpos properties (moved assiging property class to common code), now the code in the driver is even simpler - while reworking of intialization of zpos property code, did the same change to generic rotation property v1: http://www.spinics.net/lists/dri-devel/msg97709.html - initial version Patch summary: Marek Szyprowski (3): drm: add generic zpos property drm/exynos: use generic code for managing zpos plane property drm: simplify initialization of rotation property Documentation/DocBook/gpu.tmpl | 14 ++++- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 10 ++-- drivers/gpu/drm/drm_atomic.c | 4 ++ drivers/gpu/drm/drm_atomic_helper.c | 45 +++++++++++++++ drivers/gpu/drm/drm_crtc.c | 73 +++++++++++++++++++++++-- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - drivers/gpu/drm/exynos/exynos_drm_plane.c | 66 +++++----------------- drivers/gpu/drm/exynos/exynos_mixer.c | 19 ++++++- drivers/gpu/drm/i915/intel_display.c | 6 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 3 +- drivers/gpu/drm/omapdrm/omap_drv.c | 3 +- include/drm/drm_atomic_helper.h | 2 + include/drm/drm_crtc.h | 16 +++++- 13 files changed, 182 insertions(+), 80 deletions(-) -- 1.9.2

2 7

[PATCH] drm/exynos: do not free pended event at postclose callback
by Inki Dae 12 Jan '16

12 Jan '16

These events will be freed by drm_events_release of DRM core so it doesn't need to free these events in SoC specific driver. This patch removes relevant codes from Exynos DRM driver. Signed-off-by: Inki Dae <inki.dae(a)samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 57c0e7d..59041d7 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -340,20 +340,9 @@ static void exynos_drm_preclose(struct drm_device *dev, static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file) { - struct drm_pending_event *e, *et; - unsigned long flags; - if (!file->driver_priv) return; - spin_lock_irqsave(&dev->event_lock, flags); - /* Release all events handled by page flip handler but not freed. */ - list_for_each_entry_safe(e, et, &file->event_list, link) { - list_del(&e->link); - e->destroy(e); - } - spin_unlock_irqrestore(&dev->event_lock, flags); - kfree(file->driver_priv); file->driver_priv = NULL; } -- 1.9.1

3 5

[Bug 93663] Stuck on screen blanking/dmps/monitor turned off/on
by bugzilla-daemon＠freedesktop.org 12 Jan '16

12 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=93663 --- Comment #4 from jody.frankowski(a)gmail.com --- I thought it might be, because I also noticed that if I boot with the monitor turned off, and then turn it on, the screen will never turn on. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 93653] Crash while using GALLIUM_HUD
by bugzilla-daemon＠freedesktop.org 12 Jan '16

12 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=93653 Bug ID: 93653 Summary: Crash while using GALLIUM_HUD Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: dex+fdobugzilla(a)dragonslave.de Created attachment 120933 --> https://bugs.freedesktop.org/attachment.cgi?id=120933&action=edit crash with GALLIUM_HUD While trying to gather further information to fix #80419 I used GALLIUM_HUD="fps,cpu,ps-invocations+hs-invocations+ds-invocations+cs-invocations;num-compilations+num-shaders-created,draw-calls,buffer-wait-time;num-cs-flushes,num-bytes-moved;VRAM-usage+GTT-usage,GPU-load,temperature,shader-clock+memory-clock". After some minutes the application crashed. See attached trace. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 93658] Distortions on the right of the monitor
by bugzilla-daemon＠freedesktop.org 12 Jan '16

12 Jan '16

1 0

[Bug 93663] Stuck on screen blanking/dmps/monitor turned off/on
by bugzilla-daemon＠freedesktop.org 12 Jan '16

12 Jan '16

https://bugs.freedesktop.org/show_bug.cgi?id=93663 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Driver/AMDgpu |DRM/AMDgpu Assignee|xorg-driver-ati(a)lists.x.org |dri-devel(a)lists.freedesktop | |.org Product|xorg |DRI QA Contact|xorg-team(a)lists.x.org | --- Comment #3 from Michel Dänzer <michel(a)daenzer.net> --- Unless it works with the modesetting driver, it's probably a kernel driver issue. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v11 0/4] Allow USB devices to remain runtime-suspended when sleeping
by Tomeu Vizoso 11 Jan '16

11 Jan '16

Hi, this is v11 of an attempt to make it easier for devices to remain in runtime PM when the system goes to sleep, mainly to reduce the time spent resuming devices. For this, we interpret the absence of all PM callback implementations as it being safe to do direct_complete, so their ancestors aren't prevented from remaining runtime-suspended. Additionally, the prepare() callback of USB devices will return 1 if runtime PM is enabled and the current wakeup settings are correct. With these changes, a uvcvideo device (for example) stays in runtime suspend when the system goes to sleep and is left in that state when the system resumes, not delaying it unnecessarily. Thanks, Tomeu Changes in v11: - Move calls to dev_pm_domain_set() out from &dev->power.lock as that isn't needed for dev->pm_domain. Changes in v10: - Remove superfluous call to pm_runtime_enabled() as suggested by Alan Changes in v9: - Add docs noting the need for the device lock to be held before calling device_is_bound() - Add docs noting the need for the device lock to be held before calling dev_pm_domain_set() - Move to CONFIG_PM_SLEEP as suggested by Rafael and Ulf. - Rename from device_check_pm_callbacks to device_pm_check_callbacks to follow with the naming convention of existing API. - Re-add calling to device_pm_check_callbacks from device registration and when updating the PM domain of a device. Changes in v8: - Add device_is_bound() - Add dev_pm_domain_set() and update code to use it - Move no_pm_callbacks field into CONFIG_PM_SLEEP - Call device_check_pm_callbacks only after a device is bound or unbound Changes in v7: - Reduce indentation by adding a label in device_prepare() Changes in v6: - Add stub for !CONFIG_PM. - Move implementation of device_check_pm_callbacks to power/main.c as it doesn't belong to CONFIG_PM_SLEEP. - Take dev->power.lock before modifying flag. Changes in v5: - Check for all dev_pm_ops instances associated to a device, updating a no_pm_callbacks flag at the times when that could change. Tomeu Vizoso (4): device core: add device_is_bound() PM / Domains: add setter for dev.pm_domain PM / sleep: Go direct_complete if driver has no callbacks USB / PM: Allow USB devices to remain runtime-suspended when sleeping arch/arm/mach-omap2/omap_device.c | 7 ++++--- drivers/acpi/acpi_lpss.c | 5 +++-- drivers/acpi/device_pm.c | 5 +++-- drivers/base/dd.c | 21 +++++++++++++++++++-- drivers/base/power/clock_ops.c | 5 +++-- drivers/base/power/common.c | 24 ++++++++++++++++++++++++ drivers/base/power/domain.c | 8 ++++++-- drivers/base/power/main.c | 35 +++++++++++++++++++++++++++++++++++ drivers/base/power/power.h | 3 +++ drivers/gpu/vga/vga_switcheroo.c | 10 +++++----- drivers/misc/mei/pci-me.c | 5 +++-- drivers/misc/mei/pci-txe.c | 5 +++-- drivers/usb/core/port.c | 6 ++++++ drivers/usb/core/usb.c | 8 +++++++- include/linux/device.h | 2 ++ include/linux/pm.h | 1 + include/linux/pm_domain.h | 3 +++ 17 files changed, 130 insertions(+), 23 deletions(-) -- 2.5.0

7 12

[Bug 108261] New: [regression] [bisected] radeon HDMI audio broken for HD 5450 (cedar)
by bugzilla-daemon＠bugzilla.kernel.org 11 Jan '16

11 Jan '16

https://bugzilla.kernel.org/show_bug.cgi?id=108261 Bug ID: 108261 Summary: [regression] [bisected] radeon HDMI audio broken for HD 5450 (cedar) Product: Drivers Version: 2.5 Kernel Version: 4.0 and later Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: cvoeten(a)gmail.com Regression: No summary: HDMI audio on radeon HD5450 not working since kernel 4.0; bisected to b20932dd62f77a96124ec8f0c7ad0908b5584526; fails to revert under 4.3 so couldn't test further. On two machines, my HD 5450 will not play HDMI audio any more since kernel 4.0, even though the same set-up works with kernel 3.18.24. Instead of working audio, I get 9 repetitions of the below message in my syslog: sound hdaudioC1D0: HDMI ATI/AMD: no speaker allocation for ELD Bisecting reveals: b20932dd62f77a96124ec8f0c7ad0908b5584526 is the first bad commit commit b20932dd62f77a96124ec8f0c7ad0908b5584526 Author: Alex Deucher <alexander.deucher(a)amd.com> Date: Fri Feb 27 10:51:40 2015 -0500 drm/radeon/audio: update EDID derived fields in modeset We don't necessarily have an EDID at this point when audio detect gets called. Ideally we'd update these fields in detect, but that requires a larger rework of the display detect code. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> :040000 040000 062dd016364d978dc778f63fd4593b8dfd05e90e 85a53112b2d7d747481f6dbb60b1a5e25de8f0b5 M drivers which looks very much like it could indeed be the culprit. Unfortunately, I cannot revert this patch on the latest kernel (4.3), so I cannot test whether this is indeed the definitive problem. Thank you for your time. Please let me know if there is anything I can report or test for you. $ zgrep -i radeon /proc/config.gz CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8168e-2.fw radeon/CEDAR_me.bin radeon/CEDAR_pfp.bin radeon/CEDAR_rlc.bin radeon/CYPRESS_uvd.bin radeon/CEDAR_smc.bin" CONFIG_DRM_RADEON=y # CONFIG_DRM_RADEON_UMS is not set # CONFIG_FB_RADEON is not set -- You are receiving this mail because: You are watching the assignee of the bug.

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2016