dri-devel February 2016

dri-devel@lists.freedesktop.org

180 participants
1240 discussions

RE: [drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod'
by Lazare, Jordan 04 Feb '16

04 Feb '16

Hi Dave, I have a small fix to the following patch in the drm-fixes-mst branch to resolve a 32-bit compile error. I've attached the patch separately and also squashed it into the previous change. Thanks, Jordan commit 6d3d3d07381401ac6b89dfd429002c9d6ffda5e3 Author: Harry Wentland <harry.wentland(a)amd.com> Date: Fri Jan 22 17:07:25 2016 -0500 drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil -----Original Message----- From: Wentland, Harry Sent: Thursday, February 04, 2016 11:40 AM To: Lazare, Jordan Subject: FW: [drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod' -----Original Message----- From: kbuild test robot [mailto:fengguang.wu@intel.com] Sent: February 4, 2016 8:34 AM To: Wentland, Harry <Harry.Wentland(a)amd.com> Cc: kbuild-all(a)01.org; Dave Airlie <airlied(a)redhat.com>; Deucher, Alexander <Alexander.Deucher(a)amd.com> Subject: [drm:drm-fixes-mst 5/9] include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod' tree: git://people.freedesktop.org/~airlied/linux.git drm-fixes-mst head: 18ddcd63d22663841b8f61ee52733736bf3a4c7e commit: 275e06c063ea920c4b89ee293b1975080f887b00 [5/9] drm/dp/mst: Calculate MST PBN with 31.32 fixed point config: arm-exynos_defconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/m… -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 275e06c063ea920c4b89ee293b1975080f887b00 # save the attached .config to linux build tree make.cross ARCH=arm All errors (new ones prefixed by >>): drivers/built-in.o: In function `drm_fixp_from_fraction': >> include/drm/drm_fixed.h:159: undefined reference to `__aeabi_uldivmod' include/drm/drm_fixed.h:160: undefined reference to `__aeabi_uldivmod' vim +159 include/drm/drm_fixed.h 210a0b9e Alex Deucher 2013-03-22 143 if (shift > DRM_FIXED_POINT) 210a0b9e Alex Deucher 2013-03-22 144 return result >> (shift - DRM_FIXED_POINT); 210a0b9e Alex Deucher 2013-03-22 145 210a0b9e Alex Deucher 2013-03-22 146 return result; 210a0b9e Alex Deucher 2013-03-22 147 } 210a0b9e Alex Deucher 2013-03-22 148 6d3d3d07 Harry Wentland 2016-01-22 149 static inline s64 drm_fixp_from_fraction(s64 a, s64 b) 6d3d3d07 Harry Wentland 2016-01-22 150 { 6d3d3d07 Harry Wentland 2016-01-22 151 s64 res; 6d3d3d07 Harry Wentland 2016-01-22 152 bool a_neg = a < 0; 6d3d3d07 Harry Wentland 2016-01-22 153 bool b_neg = b < 0; 6d3d3d07 Harry Wentland 2016-01-22 154 u64 a_abs = a_neg ? -a : a; 6d3d3d07 Harry Wentland 2016-01-22 155 u64 b_abs = b_neg ? -b : b; 6d3d3d07 Harry Wentland 2016-01-22 156 u64 rem; 6d3d3d07 Harry Wentland 2016-01-22 157 6d3d3d07 Harry Wentland 2016-01-22 158 /* determine integer part */ 6d3d3d07 Harry Wentland 2016-01-22 @159 u64 res_abs = a_abs / b_abs; 6d3d3d07 Harry Wentland 2016-01-22 160 rem = a_abs % b_abs; 6d3d3d07 Harry Wentland 2016-01-22 161 6d3d3d07 Harry Wentland 2016-01-22 162 /* determine fractional part */ 6d3d3d07 Harry Wentland 2016-01-22 163 { 6d3d3d07 Harry Wentland 2016-01-22 164 u32 i = DRM_FIXED_POINT; 6d3d3d07 Harry Wentland 2016-01-22 165 6d3d3d07 Harry Wentland 2016-01-22 166 do { 6d3d3d07 Harry Wentland 2016-01-22 167 rem <<= 1; :::::: The code at line 159 was first introduced by commit :::::: 6d3d3d07381401ac6b89dfd429002c9d6ffda5e3 drm: Add drm_fixp_from_fraction and drm_fixp2int_ceil :::::: TO: Harry Wentland <harry.wentland(a)amd.com> :::::: CC: Dave Airlie <airlied(a)redhat.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH 0/5] vc4 fixes for 4.5
by Eric Anholt 04 Feb '16

04 Feb '16

Here's a series of fixes for vc4 from writing igt testcases while debugging X window dragging. Eric Anholt (5): drm/vc4: Validate that WAIT_BO padding is cleared. drm/vc4: Fix the clear color for the first tile rendered. drm/vc4: Return an ERR_PTR from BO creation instead of NULL. drm/vc4: Fix -ERESTARTSYS error return from BO waits. drm/vc4: Drop error message on seqno wait timeouts. drivers/gpu/drm/vc4/vc4_bo.c | 16 ++++++++-------- drivers/gpu/drm/vc4/vc4_gem.c | 14 ++++++-------- drivers/gpu/drm/vc4/vc4_irq.c | 2 +- drivers/gpu/drm/vc4/vc4_render_cl.c | 22 +++++++++++----------- drivers/gpu/drm/vc4/vc4_validate.c | 4 ++-- 5 files changed, 28 insertions(+), 30 deletions(-) -- 2.7.0

1 5

[PATCH libdrm] android: enable building static version of libdrm
by Rob Herring 04 Feb '16

04 Feb '16

From: Sumit Semwal <sumit.semwal(a)linaro.org> Android needs libdrm built statically for recovery; enable that as well. Signed-off-by: Sumit Semwal <sumit.semwal(a)linaro.org> Signed-off-by: Rob Herring <robh(a)kernel.org> Cc: Chih-Wei Huang <cwhuang(a)linux.org.tw> Cc: Emil Velikov <emil.l.velikov(a)gmail.com> --- I posted this to mesa-dev, but I guess libdrm patches are supposed to go to dri-devel. Rob Android.mk | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Android.mk b/Android.mk index 90cdcb3..1d8cd65 100644 --- a/Android.mk +++ b/Android.mk @@ -27,6 +27,8 @@ include $(CLEAR_VARS) # Import variables LIBDRM_{,H_,INCLUDE_H_,INCLUDE_VMWGFX_H_}FILES include $(LOCAL_PATH)/Makefile.sources +#static library for the device (recovery) +include $(CLEAR_VARS) LOCAL_MODULE := libdrm LOCAL_MODULE_TAGS := optional @@ -41,7 +43,24 @@ LOCAL_C_INCLUDES := \ LOCAL_CFLAGS := \ -DHAVE_VISIBILITY=1 \ -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1 +include $(BUILD_STATIC_LIBRARY) + +# Shared library for the device +include $(CLEAR_VARS) +LOCAL_MODULE := libdrm +LOCAL_MODULE_TAGS := optional +LOCAL_SRC_FILES := $(LIBDRM_FILES) +LOCAL_EXPORT_C_INCLUDE_DIRS := \ + $(LOCAL_PATH) \ + $(LOCAL_PATH)/include/drm + +LOCAL_C_INCLUDES := \ + $(LOCAL_PATH)/include/drm + +LOCAL_CFLAGS := \ + -DHAVE_VISIBILITY=1 \ + -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1 include $(BUILD_SHARED_LIBRARY) include $(call all-makefiles-under,$(LOCAL_PATH)) -- 2.5.0

2 2

[PATCH] amdgpu: fix for submition with no ibs
by Alex Deucher 04 Feb '16

04 Feb '16

From: Ken Wang <Qingqing.Wang(a)amd.com> Avoid a crash if no IBs are specified. Signed-off-by: Ken Wang <Qingqing.Wang(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> --- amdgpu/amdgpu_cs.c | 8 ++++++++ amdgpu/amdgpu_internal.h | 1 + 2 files changed, 9 insertions(+) diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index b4f41b0..fb5b3a8 100644 --- a/amdgpu/amdgpu_cs.c +++ b/amdgpu/amdgpu_cs.c @@ -190,6 +190,10 @@ static int amdgpu_cs_submit_one(amdgpu_context_handle context, return -EINVAL; if (ibs_request->number_of_ibs > AMDGPU_CS_MAX_IBS_PER_SUBMIT) return -EINVAL; + if (ibs_request->number_of_ibs == 0) { + ibs_request->seq_no = AMDGPU_NULL_SUBMIT_SEQ; + return 0; + } user_fence = (ibs_request->fence_info.handle != NULL); size = ibs_request->number_of_ibs + (user_fence ? 2 : 1) + 1; @@ -422,6 +426,10 @@ int amdgpu_cs_query_fence_status(struct amdgpu_cs_fence *fence, return -EINVAL; if (fence->ring >= AMDGPU_CS_MAX_RINGS) return -EINVAL; + if (fence->fence == AMDGPU_NULL_SUBMIT_SEQ) { + *expired = true; + return 0; + } *expired = false; diff --git a/amdgpu/amdgpu_internal.h b/amdgpu/amdgpu_internal.h index 557ba1f..4f039b6 100644 --- a/amdgpu/amdgpu_internal.h +++ b/amdgpu/amdgpu_internal.h @@ -44,6 +44,7 @@ #define ROUND_DOWN(x, y) ((x) & ~__round_mask(x, y)) #define AMDGPU_INVALID_VA_ADDRESS 0xffffffffffffffff +#define AMDGPU_NULL_SUBMIT_SEQ 0 struct amdgpu_bo_va_hole { struct list_head list; -- 2.5.0

1 0

[PATCH 1/7] tests/amdgpu: make amdgpu_sdma_test_exec_cs() generic (v2)
by Alex Deucher 04 Feb '16

04 Feb '16

Share with upcoming CP tests. v2: drop unnecessary forward declaration Reviewed-by: Ken Wang <Qingqing.Wang(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- tests/amdgpu/basic_tests.c | 51 +++++++++++++++++++++++++--------------------- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c index fa0ed12..df5f5bc 100644 --- a/tests/amdgpu/basic_tests.c +++ b/tests/amdgpu/basic_tests.c @@ -542,11 +542,12 @@ static void amdgpu_command_submission_compute(void) * pm4_src, resources, ib_info, and ibs_request * submit command stream described in ibs_request and wait for this IB accomplished */ -static void amdgpu_sdma_test_exec_cs(amdgpu_context_handle context_handle, - int instance, int pm4_dw, uint32_t *pm4_src, - int res_cnt, amdgpu_bo_handle *resources, - struct amdgpu_cs_ib_info *ib_info, - struct amdgpu_cs_request *ibs_request) +static void amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, + unsigned ip_type, + int instance, int pm4_dw, uint32_t *pm4_src, + int res_cnt, amdgpu_bo_handle *resources, + struct amdgpu_cs_ib_info *ib_info, + struct amdgpu_cs_request *ibs_request) { int r; uint32_t expired; @@ -579,7 +580,7 @@ static void amdgpu_sdma_test_exec_cs(amdgpu_context_handle context_handle, ib_info->ib_mc_address = ib_result_mc_address; ib_info->size = pm4_dw; - ibs_request->ip_type = AMDGPU_HW_IP_DMA; + ibs_request->ip_type = ip_type; ibs_request->ring = instance; ibs_request->number_of_ibs = 1; ibs_request->ibs = ib_info; @@ -601,7 +602,7 @@ static void amdgpu_sdma_test_exec_cs(amdgpu_context_handle context_handle, r = amdgpu_bo_list_destroy(ibs_request->resources); CU_ASSERT_EQUAL(r, 0); - fence_status.ip_type = AMDGPU_HW_IP_DMA; + fence_status.ip_type = ip_type; fence_status.ring = ibs_request->ring; fence_status.context = context_handle; fence_status.fence = ibs_request->seq_no; @@ -676,10 +677,11 @@ static void amdgpu_command_submission_sdma_write_linear(void) while(j++ < sdma_write_length) pm4[i++] = 0xdeadbeaf; - amdgpu_sdma_test_exec_cs(context_handle, 0, - i, pm4, - 1, resources, - ib_info, ibs_request); + amdgpu_test_exec_cs_helper(context_handle, + AMDGPU_HW_IP_DMA, 0, + i, pm4, + 1, resources, + ib_info, ibs_request); /* verify if SDMA test result meets with expected */ i = 0; @@ -759,10 +761,11 @@ static void amdgpu_command_submission_sdma_const_fill(void) pm4[i++] = 0xdeadbeaf; pm4[i++] = sdma_write_length; - amdgpu_sdma_test_exec_cs(context_handle, 0, - i, pm4, - 1, resources, - ib_info, ibs_request); + amdgpu_test_exec_cs_helper(context_handle, + AMDGPU_HW_IP_DMA, 0, + i, pm4, + 1, resources, + ib_info, ibs_request); /* verify if SDMA test result meets with expected */ i = 0; @@ -860,10 +863,11 @@ static void amdgpu_command_submission_sdma_copy_linear(void) pm4[i++] = (0xffffffff00000000 & bo2_mc) >> 32; - amdgpu_sdma_test_exec_cs(context_handle, 0, - i, pm4, - 2, resources, - ib_info, ibs_request); + amdgpu_test_exec_cs_helper(context_handle, + AMDGPU_HW_IP_DMA, 0, + i, pm4, + 2, resources, + ib_info, ibs_request); /* verify if SDMA test result meets with expected */ i = 0; @@ -954,10 +958,11 @@ static void amdgpu_userptr_test(void) while (j++ < sdma_write_length) pm4[i++] = 0xdeadbeaf; - amdgpu_sdma_test_exec_cs(context_handle, 0, - i, pm4, - 1, &handle, - ib_info, ibs_request); + amdgpu_test_exec_cs_helper(context_handle, + AMDGPU_HW_IP_DMA, 0, + i, pm4, + 1, &handle, + ib_info, ibs_request); i = 0; while (i < sdma_write_length) { CU_ASSERT_EQUAL(((int*)ptr)[i++], 0xdeadbeaf); -- 2.5.0

1 0

[PATCH 0/8] Enable Gen 7 Observation Architecture
by Robert Bragg 04 Feb '16

04 Feb '16

Compared to the last revision, this is just rebased on drm-intel-nightly Robert Bragg (8): drm/i915: Add i915 perf infrastructure drm/i915: rename OACONTROL GEN7_OACONTROL drm/i915: Add 'render basic' Haswell OA unit config drm/i915: Add i915 perf event for Haswell OA unit drm/i915: advertise available metrics via sysfs drm/i915: Add dev.i915.perf_event_paranoid sysctl option drm/i915: add oa_event_min_timer_exponent sysctl drm/i915: Add more Haswell OA metric sets drivers/gpu/drm/i915/Makefile | 4 + drivers/gpu/drm/i915/i915_cmd_parser.c | 4 +- drivers/gpu/drm/i915/i915_dma.c | 7 + drivers/gpu/drm/i915/i915_drv.h | 154 ++++ drivers/gpu/drm/i915/i915_gem_context.c | 23 +- drivers/gpu/drm/i915/i915_oa_hsw.c | 658 ++++++++++++++++ drivers/gpu/drm/i915/i915_oa_hsw.h | 38 + drivers/gpu/drm/i915/i915_perf.c | 1283 +++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 340 +++++++- include/uapi/drm/i915_drm.h | 121 +++ 10 files changed, 2625 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_oa_hsw.c create mode 100644 drivers/gpu/drm/i915/i915_oa_hsw.h create mode 100644 drivers/gpu/drm/i915/i915_perf.c -- 2.7.0

2 11

[PULL] drm-intel-fixes
by Jani Nikula 04 Feb '16

04 Feb '16

Hi Dave - Intel fixes for 4.5. BR, Jani. The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2016-02-04 for you to fetch changes up to f2e305108faba0c85eb4ba4066599decb675117e: drm/i915: refine qemu south bridge detection (2016-01-29 09:15:03 +0200) ---------------------------------------------------------------- Andreas Ziegler (1): drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Francisco Jerez (1): drm/i915: Make sure DC writes are coherent on flush. Gerd Hoffmann (1): drm/i915: refine qemu south bridge detection Jani Nikula (1): drm/i915/dp: fall back to 18 bpp when sink capability is unknown Ville Syrjälä (2): drm/i915: Don't reject primary plane windowing with color keying enabled on SKL+ drm/i915: Fix NULL plane->fb oops on SKL drivers/gpu/drm/i915/Kconfig | 1 - drivers/gpu/drm/i915/i915_drv.c | 4 +++- drivers/gpu/drm/i915/intel_display.c | 33 ++++++++++++++++++++++----------- drivers/gpu/drm/i915/intel_lrc.c | 1 + drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++ 5 files changed, 28 insertions(+), 13 deletions(-) -- Jani Nikula, Intel Open Source Technology Center

1 0

[Bug 92790] Radeon.mst error
by bugzilla-daemon＠freedesktop.org 03 Feb '16

03 Feb '16

https://bugs.freedesktop.org/show_bug.cgi?id=92790 --- Comment #3 from aello(a)riseup.net --- I have tried with arch kernel 4.4.1, also same issue -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2 0/3] drm: adv7511: edid read fixes
by Wolfram Sang 03 Feb '16

03 Feb '16

So, here is my V2 of this series. Changes: * Added tags. Thanks to Laurent and Lars-Peter for review and to Archit for testing. Much appreciated! * rephrased the comment and commit message in patch 1 to be hopefully less confusing :) No code changes! Thanks, Wolfram Wolfram Sang (3): drm: adv7511: really enable interrupts for EDID detection drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile drm: adv7511: it's HPD, not HDP drivers/gpu/drm/i2c/adv7511.c | 48 ++++++++++++++++++++++++++----------------- drivers/gpu/drm/i2c/adv7511.h | 12 +++++------ 2 files changed, 35 insertions(+), 25 deletions(-) -- 2.1.4

2 7

[PATCH 1/3] drm: add helper to check for wc memory support
by Oded Gabbay 03 Feb '16

03 Feb '16

From: Dave Airlie <airlied(a)redhat.com> Signed-off-by: Dave Airlie <airlied(a)redhat.com> Signed-off-by: Oded Gabbay <oded.gabbay(a)gmail.com> --- include/drm/drm_cache.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h index 7bfb063..461a055 100644 --- a/include/drm/drm_cache.h +++ b/include/drm/drm_cache.h @@ -35,4 +35,13 @@ void drm_clflush_pages(struct page *pages[], unsigned long num_pages); +static inline bool drm_arch_can_wc_memory(void) +{ +#if defined(CONFIG_PPC) && !defined(CONFIG_NOT_COHERENT_CACHE) + return false; +#else + return true; +#endif +} + #endif -- 2.5.0

4 11

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2016