dri-devel May 2016

dri-devel@lists.freedesktop.org

212 participants
1404 discussions

[Bug 95198] Shadow of Mordor beta has missing geometry with gl 4.3
by bugzilla-daemon＠freedesktop.org 09 May '16

09 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95198 Bug ID: 95198 Summary: Shadow of Mordor beta has missing geometry with gl 4.3 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel(a)lists.freedesktop.org Reporter: ernstp(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 123332 --> https://bugs.freedesktop.org/attachment.cgi?id=123332&action=edit screenshot.png The public version of Shadow of Mordor worked fine for me, so I don't think this is a dupe of #92059. However there's a beta (v1.1?) that supports compute shaders and GL 4.3. If I run it with MESA_GL_VERSION_OVERRIDE=4.3 MESA_GLSL_VERSION_OVERRIDE=430 and set texture quality to Medium, I get missing geometry as the attached picture. I'm trying to apitrace it but unfortunately the error doesn't appear when running under apitrace. Also, glretrace refuses to work with forced gl-versions? I either get: MESA_GL_VERSION_OVERRIDE=4.3 MESA_GLSL_VERSION_OVERRIDE=430 glretrace ShadowOfMordor.2.trace error: context mismatch: expected OpenGL 1.0, but got OpenGL 4.3 core Or: glretrace ShadowOfMordor.2.trace error: xlib: BadMatch (invalid parameter attributes) error: xlib: BadMatch (invalid parameter attributes) error: failed to create OpenGL 4.3 core context. -- You are receiving this mail because: You are the assignee for the bug.

1 17

re: drm/ttm: Refuse to fault (prime-) imported pages
by Dan Carpenter 09 May '16

09 May '16

Hello Thomas Hellstrom, The patch 667a50db0477: "drm/ttm: Refuse to fault (prime-) imported pages" from Jan 3, 2014, leads to the following static checker warning: drivers/gpu/drm/ttm/ttm_bo_vm.c:205 ttm_bo_vm_fault() error: we previously assumed 'ttm' could be null (see line 200) drivers/gpu/drm/ttm/ttm_bo_vm.c 133 /* 134 * Refuse to fault imported pages. This should be handled 135 * (if at all) by redirecting mmap to the exporter. 136 */ 137 if (bo->ttm && (bo->ttm->page_flags & TTM_PAGE_FLAG_SG)) { ^^^^^^^ New check for NULL. Is this really needed? 138 retval = VM_FAULT_SIGBUS; 139 goto out_unlock; 140 } [ snip ] 188 /* 189 * Make a local vma copy to modify the page_prot member 190 * and vm_flags if necessary. The vma parameter is protected 191 * by mmap_sem in write mode. 192 */ 193 cvma = *vma; 194 cvma.vm_page_prot = vm_get_page_prot(cvma.vm_flags); 195 196 if (bo->mem.bus.is_iomem) { 197 cvma.vm_page_prot = ttm_io_prot(bo->mem.placement, 198 cvma.vm_page_prot); 199 } else { 200 ttm = bo->ttm; ^^^^^^^^^^^^^ 201 cvma.vm_page_prot = ttm_io_prot(bo->mem.placement, 202 cvma.vm_page_prot); 203 204 /* Allocate all page at once, most common usage */ 205 if (ttm->bdev->driver->ttm_tt_populate(ttm)) { ^^^^^^^^^ Old unchecked dereference. 206 retval = VM_FAULT_OOM; 207 goto out_io_unlock; 208 } 209 } 210 regards, dan carpenter

1 0

[PATCH] drm/amdgpu/gfx7: fix pipeline sync
by Alex Deucher 09 May '16

09 May '16

From: Chunming Zhou <David1.Zhou(a)amd.com> Need to wait on the fence as well. Signed-off-by: Chunming Zhou <David1.Zhou(a)amd.com> Reviewed-by: Monk Liu <monk.liu(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 92d8061..f4068f7 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c @@ -3054,6 +3054,19 @@ static int gfx_v7_0_cp_resume(struct amdgpu_device *adev) static void gfx_v7_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) { int usepfp = (ring->type == AMDGPU_RING_TYPE_GFX); + uint32_t seq = ring->fence_drv.sync_seq; + uint64_t addr = ring->fence_drv.gpu_addr; + + amdgpu_ring_write(ring, PACKET3(PACKET3_WAIT_REG_MEM, 5)); + amdgpu_ring_write(ring, (WAIT_REG_MEM_MEM_SPACE(1) | /* memory */ + WAIT_REG_MEM_FUNCTION(3) | /* equal */ + WAIT_REG_MEM_ENGINE(usepfp))); /* pfp or me */ + amdgpu_ring_write(ring, addr & 0xfffffffc); + amdgpu_ring_write(ring, upper_32_bits(addr) & 0xffffffff); + amdgpu_ring_write(ring, seq); + amdgpu_ring_write(ring, 0xffffffff); + amdgpu_ring_write(ring, 4); /* poll interval */ + if (usepfp) { /* synce CE with ME to prevent CE fetch CEIB before context switch done */ amdgpu_ring_write(ring, PACKET3(PACKET3_SWITCH_BUFFER, 0)); @@ -3081,18 +3094,6 @@ static void gfx_v7_0_ring_emit_vm_flush(struct amdgpu_ring *ring, unsigned vm_id, uint64_t pd_addr) { int usepfp = (ring->type == AMDGPU_RING_TYPE_GFX); - uint32_t seq = ring->fence_drv.sync_seq; - uint64_t addr = ring->fence_drv.gpu_addr; - - amdgpu_ring_write(ring, PACKET3(PACKET3_WAIT_REG_MEM, 5)); - amdgpu_ring_write(ring, (WAIT_REG_MEM_MEM_SPACE(1) | /* memory */ - WAIT_REG_MEM_FUNCTION(3) | /* equal */ - WAIT_REG_MEM_ENGINE(usepfp))); /* pfp or me */ - amdgpu_ring_write(ring, addr & 0xfffffffc); - amdgpu_ring_write(ring, upper_32_bits(addr) & 0xffffffff); - amdgpu_ring_write(ring, seq); - amdgpu_ring_write(ring, 0xffffffff); - amdgpu_ring_write(ring, 4); /* poll interval */ amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3)); amdgpu_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) | -- 2.5.5

1 5

[PATCH 1/3] drm: Drop crtc argument from __drm_atomic_helper_crtc_destroy_state
by Daniel Vetter 09 May '16

09 May '16

It's unused, and really this helper should only look at the state structure and nothing else. v2: Rebase on top of rockchip changes v3: Drop unrelated hunk, spotted by Laurent. Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Thierry Reding <thierry.reding(a)gmail.com> Cc: Eric Anholt <eric(a)anholt.net> Cc: Mark Yao <mark.yao(a)rock-chips.com> Acked-by: Thierry Reding <thierry.reding(a)gmail.com> Acked-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Acked-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- drivers/gpu/drm/drm_atomic_helper.c | 8 +++----- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/tegra/dc.c | 4 ++-- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- include/drm/drm_atomic_helper.h | 3 +-- 7 files changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index 8df0aaf98725..cf23a755f777 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -430,7 +430,7 @@ static void atmel_hlcdc_crtc_destroy_state(struct drm_crtc *crtc, struct atmel_hlcdc_crtc_state *state; state = drm_crtc_state_to_atmel_hlcdc_crtc_state(s); - __drm_atomic_helper_crtc_destroy_state(crtc, s); + __drm_atomic_helper_crtc_destroy_state(s); kfree(state); } diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 997fd21e5388..137bb51269c2 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2511,7 +2511,7 @@ EXPORT_SYMBOL(drm_atomic_helper_connector_dpms); void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc) { if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc, crtc->state); + __drm_atomic_helper_crtc_destroy_state(crtc->state); kfree(crtc->state); crtc->state = kzalloc(sizeof(*crtc->state), GFP_KERNEL); @@ -2576,15 +2576,13 @@ EXPORT_SYMBOL(drm_atomic_helper_crtc_duplicate_state); /** * __drm_atomic_helper_crtc_destroy_state - release CRTC state - * @crtc: CRTC object * @state: CRTC state object to release * * Releases all resources stored in the CRTC state without actually freeing * the memory of the CRTC state. This is useful for drivers that subclass the * CRTC state. */ -void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, - struct drm_crtc_state *state) +void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state) { drm_property_unreference_blob(state->mode_blob); drm_property_unreference_blob(state->degamma_lut); @@ -2604,7 +2602,7 @@ EXPORT_SYMBOL(__drm_atomic_helper_crtc_destroy_state); void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state) { - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); kfree(state); } EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state); diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 6ba676f81bae..e880ed680bee 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12915,7 +12915,7 @@ verify_crtc_state(struct drm_crtc *crtc, bool active; old_state = old_crtc_state->state; - __drm_atomic_helper_crtc_destroy_state(crtc, old_crtc_state); + __drm_atomic_helper_crtc_destroy_state(old_crtc_state); pipe_config = to_intel_crtc_state(old_crtc_state); memset(pipe_config, 0, sizeof(*pipe_config)); pipe_config->base.crtc = crtc; @@ -15751,7 +15751,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev) struct intel_crtc_state *crtc_state = crtc->config; int pixclk = 0; - __drm_atomic_helper_crtc_destroy_state(&crtc->base, &crtc_state->base); + __drm_atomic_helper_crtc_destroy_state(&crtc_state->base); memset(crtc_state, 0, sizeof(*crtc_state)); crtc_state->base.crtc = &crtc->base; diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index bf55cda356ba..80d0f95820c4 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1065,7 +1065,7 @@ static void vop_crtc_destroy_state(struct drm_crtc *crtc, { struct rockchip_crtc_state *s = to_rockchip_crtc_state(state); - __drm_atomic_helper_crtc_destroy_state(crtc, &s->base); + __drm_atomic_helper_crtc_destroy_state(&s->base); kfree(s); } diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 3b85a31b625d..39902bbfb3ce 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -998,7 +998,7 @@ static void tegra_crtc_reset(struct drm_crtc *crtc) struct tegra_dc_state *state; if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc, crtc->state); + __drm_atomic_helper_crtc_destroy_state(crtc->state); kfree(crtc->state); crtc->state = NULL; @@ -1034,7 +1034,7 @@ tegra_crtc_atomic_duplicate_state(struct drm_crtc *crtc) static void tegra_crtc_atomic_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state) { - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); kfree(state); } diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 231356f42a04..904d0754ad78 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -650,7 +650,7 @@ static void vc4_crtc_destroy_state(struct drm_crtc *crtc, } - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); } static const struct drm_crtc_funcs vc4_crtc_funcs = { diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h index 03642878bc51..5abbe1259a2a 100644 --- a/include/drm/drm_atomic_helper.h +++ b/include/drm/drm_atomic_helper.h @@ -117,8 +117,7 @@ void __drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc, struct drm_crtc_state *state); struct drm_crtc_state * drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc); -void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, - struct drm_crtc_state *state); +void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state); void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state); -- 2.8.1

2 3

[Bug 95328] System hangs for ~60 seconds on switching monitor modes with amdgpu since Linux 4.5
by bugzilla-daemon＠freedesktop.org 09 May '16

09 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=95328 Bug ID: 95328 Summary: System hangs for ~60 seconds on switching monitor modes with amdgpu since Linux 4.5 Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: guido-xorgbugs(a)unknownsite.de Starting with Linux 4.5, the whole system will hang for about 60 seconds every time the monitor configuration is changed. The system will be completely unresponsive during this time, not even reacting to NumLock toggle on the keyboard. The system stays responsive to pings from another machine, though, and a music player app in the background keeps up it audio output. This happens once during kernel bootup, once during the startup of the display manager, once during startup of my desktop environment (which sets up a multi-monitor configuration), every time my desktop environment enables or disables screen blanking for inactivity and every time I make any changes to the monitor configuration using xrandr or by connecting or disconnecting or switching on or off any monitors on DisplayPort. In dmesg, I get this output afterwards: [ 1.123899] Non-volatile memory driver v1.3 [ 1.124084] Linux agpgart interface v0.103 [ 1.124252] [drm] Initialized drm 1.1.0 20060810 [ 1.124365] [drm] radeon kernel modesetting enabled. [ 1.124541] [drm] amdgpu kernel modesetting enabled. [ 1.124865] [drm] initializing kernel modesetting (TONGA 0x1002:0x6938 0x174B:0xE308 0xF1). [ 1.125044] [drm] register mmio base: 0xF8600000 [ 1.125144] [drm] register mmio size: 262144 [ 1.125246] [drm] doorbell mmio base: 0xD0000000 [ 1.125346] [drm] doorbell mmio size: 2097152 [ 1.125450] [drm] probing gen 2 caps for device 8086:3c04 = 7a7103/e [ 1.125552] [drm] probing mlw for device 8086:3c04 = 7a7103 [ 1.125673] amdgpu 0000:01:00.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0xffff [ 1.125863] ATOM BIOS: E308 [ 1.126112] amdgpu 0000:01:00.0: VRAM: 4096M 0x0000000000000000 - 0x00000000FFFFFFFF (4096M used) [ 1.126287] amdgpu 0000:01:00.0: GTT: 4096M 0x0000000100000000 - 0x00000001FFFFFFFF [ 1.126461] [drm] Detected VRAM RAM=4096M, BAR=256M [ 1.126561] [drm] RAM width 256bits DDR [ 1.126737] [TTM] Zone kernel: Available graphics memory: 16457442 kiB [ 1.126841] [TTM] Zone dma32: Available graphics memory: 2097152 kiB [ 1.126943] [TTM] Initializing pool allocator [ 1.127047] [TTM] Initializing DMA pool allocator [ 1.127164] [drm] amdgpu: 4096M of VRAM memory ready [ 1.127264] [drm] amdgpu: 4096M of GTT memory ready. [ 1.127375] [drm] GART: num cpu pages 1048576, num gpu pages 1048576 [ 1.131949] [drm] PCIE GART of 4096M enabled (table at 0x0000000000040000). [ 1.132041] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 1.132117] [drm] Driver supports precise vblank timestamp query. [ 1.132217] amdgpu 0000:01:00.0: amdgpu: using MSI. [ 1.132308] [drm] amdgpu: irq initialized. [ 1.132386] Can't find requested voltage id in vdd_dep_on_sclk table! [ 1.134523] amdgpu: powerplay initialized [ 1.135051] [drm] AMDGPU Display Connectors [ 1.135126] [drm] Connector 0: [ 1.135199] [drm] DP-1 [ 1.135271] [drm] HPD4 [ 1.135344] [drm] DDC: 0x4868 0x4868 0x4869 0x4869 0x486a 0x486a 0x486b 0x486b [ 1.135465] [drm] Encoders: [ 1.135538] [drm] DFP1: INTERNAL_UNIPHY1 [ 1.135611] [drm] Connector 1: [ 1.135728] [drm] HDMI-A-1 [ 1.135800] [drm] HPD5 [ 1.135872] [drm] DDC: 0x4870 0x4870 0x4871 0x4871 0x4872 0x4872 0x4873 0x4873 [ 1.135994] [drm] Encoders: [ 1.136066] [drm] DFP2: INTERNAL_UNIPHY1 [ 1.136139] [drm] Connector 2: [ 1.136212] [drm] DVI-D-1 [ 1.136284] [drm] HPD1 [ 1.136356] [drm] DDC: 0x4878 0x4878 0x4879 0x4879 0x487a 0x487a 0x487b 0x487b [ 1.136478] [drm] Encoders: [ 1.136550] [drm] DFP3: INTERNAL_UNIPHY [ 1.136623] [drm] Connector 3: [ 1.136696] [drm] DVI-I-1 [ 1.136768] [drm] HPD6 [ 1.136840] [drm] DDC: 0x487c 0x487c 0x487d 0x487d 0x487e 0x487e 0x487f 0x487f [ 1.136962] [drm] Encoders: [ 1.137034] [drm] DFP4: INTERNAL_UNIPHY2 [ 1.137107] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 1.137278] amdgpu 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000100000008, cpu addr 0xffff8808197c6008 [ 1.137596] amdgpu 0000:01:00.0: fence driver on ring 1 use gpu addr 0x0000000100000018, cpu addr 0xffff8808197c6018 [ 1.137914] amdgpu 0000:01:00.0: fence driver on ring 2 use gpu addr 0x0000000100000028, cpu addr 0xffff8808197c6028 [ 1.138248] amdgpu 0000:01:00.0: fence driver on ring 3 use gpu addr 0x0000000100000038, cpu addr 0xffff8808197c6038 [ 1.138577] amdgpu 0000:01:00.0: fence driver on ring 4 use gpu addr 0x0000000100000048, cpu addr 0xffff8808197c6048 [ 1.138878] amdgpu 0000:01:00.0: fence driver on ring 5 use gpu addr 0x0000000100000058, cpu addr 0xffff8808197c6058 [ 1.139186] amdgpu 0000:01:00.0: fence driver on ring 6 use gpu addr 0x0000000100000068, cpu addr 0xffff8808197c6068 [ 1.139475] amdgpu 0000:01:00.0: fence driver on ring 7 use gpu addr 0x0000000100000078, cpu addr 0xffff8808197c6078 [ 1.139795] amdgpu 0000:01:00.0: fence driver on ring 8 use gpu addr 0x0000000100000088, cpu addr 0xffff8808197c6088 [ 1.140138] amdgpu 0000:01:00.0: fence driver on ring 9 use gpu addr 0x0000000100000098, cpu addr 0xffff8808197c6098 [ 1.140383] amdgpu 0000:01:00.0: fence driver on ring 10 use gpu addr 0x00000001000000a8, cpu addr 0xffff8808197c60a8 [ 1.140569] [drm] Found UVD firmware Version: 1.52 Family ID: 10 [ 1.141226] amdgpu 0000:01:00.0: fence driver on ring 11 use gpu addr 0x000000000088f7b0, cpu addr 0xffffc90005c4e7b0 [ 1.141358] [drm] Found VCE firmware Version: 48.0 Binary ID: 3 [ 1.141599] amdgpu 0000:01:00.0: fence driver on ring 12 use gpu addr 0x00000001000000c8, cpu addr 0xffff8808197c60c8 [ 1.141877] amdgpu 0000:01:00.0: fence driver on ring 13 use gpu addr 0x00000001000000d8, cpu addr 0xffff8808197c60d8 [ 1.219919] [drm] ring test on 0 succeeded in 12 usecs [ 1.220208] [drm] ring test on 1 succeeded in 22 usecs [ 1.220303] [drm] ring test on 2 succeeded in 4 usecs [ 1.220398] [drm] ring test on 3 succeeded in 4 usecs [ 1.220493] [drm] ring test on 4 succeeded in 4 usecs [ 1.220588] [drm] ring test on 5 succeeded in 4 usecs [ 1.220683] [drm] ring test on 6 succeeded in 4 usecs [ 1.220778] [drm] ring test on 7 succeeded in 4 usecs [ 1.220872] [drm] ring test on 8 succeeded in 4 usecs [ 1.220990] [drm] ring test on 9 succeeded in 9 usecs [ 1.221091] [drm] ring test on 10 succeeded in 7 usecs [ 1.266843] [drm] ring test on 11 succeeded in 3 usecs [ 1.286783] [drm] UVD initialized successfully. [ 1.505200] [drm] ring test on 12 succeeded in 27 usecs [ 1.505300] [drm] ring test on 13 succeeded in 5 usecs [ 1.505387] [drm] VCE initialized successfully. [ 1.652922] [drm] fb mappable at 0xC0BAA000 [ 1.653000] [drm] vram apper at 0xC0000000 [ 1.653076] [drm] size 14745600 [ 1.653151] [drm] fb depth is 24 [ 1.653227] [drm] pitch is 10240 [ 1.653458] fbcon: amdgpudrmfb (fb0) is primary device [ 1.829490] Failed to send Message. [ 2.179278] Failed to send Previous Message. (The last two messages get repeated about 4 times a second at this point.) [ 70.107528] Console: switching to colour frame buffer device 320x90 [ 70.295522] amdgpu 0000:01:00.0: fb0: amdgpudrmfb frame buffer device [ 70.306857] [drm] ib test on ring 0 succeeded in 0 usecs [ 70.307785] [drm] ib test on ring 1 succeeded in 0 usecs [ 70.308631] [drm] ib test on ring 2 succeeded in 0 usecs [ 70.309472] [drm] ib test on ring 3 succeeded in 0 usecs [ 70.310296] [drm] ib test on ring 4 succeeded in 0 usecs [ 70.311151] [drm] ib test on ring 5 succeeded in 0 usecs [ 70.311951] [drm] ib test on ring 6 succeeded in 0 usecs [ 70.312754] [drm] ib test on ring 7 succeeded in 0 usecs [ 70.313504] [drm] ib test on ring 8 succeeded in 0 usecs [ 70.314306] [drm] ib test on ring 9 succeeded in 0 usecs [ 70.315073] [drm] ib test on ring 10 succeeded in 0 usecs [ 70.336416] [drm] ib test on ring 11 succeeded [ 70.357077] [drm] ib test on ring 12 succeeded [ 70.545569] Failed to send Previous Message. [ 70.734245] Failed to send Message. [ 70.922837] Failed to send Previous Message. [ 71.111567] Failed to send Message. [ 71.488476] Failed to send Previous Message. [ 71.677079] Failed to send Message. [ 72.052880] Failed to send Previous Message. [ 72.241706] Failed to send Message. [ 72.242405] [drm] Initialized amdgpu 3.1.0 20150101 for 0000:01:00.0 on minor 0 The system will continue after this point. The system clock has not lost any time. This is with CONFIG_DRM_AMD_POWERPLAY enabled. I haven't yet tested without that setting. -- You are receiving this mail because: You are the assignee for the bug.

1 8

[PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change
by Lyude 09 May '16

09 May '16

If an MST device is disconnected while the machine is suspended, the number of connectors will change as well after we call intel_dp_mst_resume(). This means that any previous atomic state we had before suspending is no longer valid, since it'll still be pointing to missing connectors. We need to check for this before committing the state, otherwise we'll kernel panic on resume whenever if any MST display was disconnected before we started resuming: BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 IP: [<ffffffffa01588ef>] drm_atomic_helper_check_modeset+0x29f/0xb40 [drm_kms_helper] Call Trace: [<ffffffffa02354f4>] intel_atomic_check+0x34/0x1180 [i915] [<ffffffff810e6c3f>] ? mark_held_locks+0x6f/0xa0 [<ffffffff810e6d99>] ? trace_hardirqs_on_caller+0x129/0x1b0 [<ffffffffa00ff1d2>] drm_atomic_check_only+0x192/0x620 [drm] [<ffffffff813ee001>] ? pci_pm_thaw+0x21/0x90 [<ffffffffa00ff677>] drm_atomic_commit+0x17/0x60 [drm] [<ffffffffa023e0ad>] intel_display_resume+0xbd/0x160 [i915] [<ffffffff813ee070>] ? pci_pm_thaw+0x90/0x90 [<ffffffffa01b60d8>] i915_drm_resume+0xd8/0x160 [i915] [<ffffffffa01b6185>] i915_pm_resume+0x25/0x30 [i915] [<ffffffff813ee0d4>] pci_pm_resume+0x64/0xa0 [<ffffffff814d9ea0>] dpm_run_callback+0x90/0x190 [<ffffffff814da455>] device_resume+0xd5/0x1f0 [<ffffffff814da58d>] async_resume+0x1d/0x50 [<ffffffff810b6718>] async_run_entry_fn+0x48/0x150 [<ffffffff810acc19>] process_one_work+0x1e9/0x5c0 [<ffffffff810acb96>] ? process_one_work+0x166/0x5c0 [<ffffffff810ad038>] worker_thread+0x48/0x4e0 [<ffffffff810acff0>] ? process_one_work+0x5c0/0x5c0 [<ffffffff810b3794>] kthread+0xe4/0x100 [<ffffffff81742672>] ret_from_fork+0x22/0x50 [<ffffffff810b36b0>] ? kthread_create_on_node+0x200/0x200 Changes since v1: - Move drm_atomic_state_free() call down so we're holding the appropriate locks when destroying the atomic state Cc: stable(a)vger.kernel.org Signed-off-by: Lyude <cpaul(a)redhat.com> --- drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 0f29ef6..d68efc7 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -15934,6 +15934,18 @@ void intel_display_resume(struct drm_device *dev) retry: ret = drm_modeset_lock_all_ctx(dev, &ctx); + /* + * With MST, the number of connectors can change between suspend and + * resume, which means that the state we want to restore might now be + * impossible to use since it'll be pointing to non-existant + * connectors. + */ + if (ret == 0 && + state->num_connector != dev->mode_config.num_connector) { + drm_atomic_state_free(state); + state = NULL; + } + if (ret == 0 && !setup) { setup = true; -- 2.5.5

3 4

[PATCH 1/3] drm: Drop crtc argument from __drm_atomic_helper_crtc_destroy_state
by Daniel Vetter 09 May '16

09 May '16

It's unused, and really this helper should only look at the state structure and nothing else. v2: Rebase on top of rockchip changes Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Thierry Reding <thierry.reding(a)gmail.com> Cc: Eric Anholt <eric(a)anholt.net> Cc: Mark Yao <mark.yao(a)rock-chips.com> Acked-by: Thierry Reding <thierry.reding(a)gmail.com> Acked-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- drivers/gpu/drm/drm_atomic_helper.c | 8 +++----- drivers/gpu/drm/drm_crtc.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- drivers/gpu/drm/tegra/dc.c | 4 ++-- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- include/drm/drm_atomic_helper.h | 3 +-- 8 files changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index 8df0aaf98725..cf23a755f777 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -430,7 +430,7 @@ static void atmel_hlcdc_crtc_destroy_state(struct drm_crtc *crtc, struct atmel_hlcdc_crtc_state *state; state = drm_crtc_state_to_atmel_hlcdc_crtc_state(s); - __drm_atomic_helper_crtc_destroy_state(crtc, s); + __drm_atomic_helper_crtc_destroy_state(s); kfree(state); } diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 997fd21e5388..137bb51269c2 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2511,7 +2511,7 @@ EXPORT_SYMBOL(drm_atomic_helper_connector_dpms); void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc) { if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc, crtc->state); + __drm_atomic_helper_crtc_destroy_state(crtc->state); kfree(crtc->state); crtc->state = kzalloc(sizeof(*crtc->state), GFP_KERNEL); @@ -2576,15 +2576,13 @@ EXPORT_SYMBOL(drm_atomic_helper_crtc_duplicate_state); /** * __drm_atomic_helper_crtc_destroy_state - release CRTC state - * @crtc: CRTC object * @state: CRTC state object to release * * Releases all resources stored in the CRTC state without actually freeing * the memory of the CRTC state. This is useful for drivers that subclass the * CRTC state. */ -void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, - struct drm_crtc_state *state) +void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state) { drm_property_unreference_blob(state->mode_blob); drm_property_unreference_blob(state->degamma_lut); @@ -2604,7 +2602,7 @@ EXPORT_SYMBOL(__drm_atomic_helper_crtc_destroy_state); void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state) { - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); kfree(state); } EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state); diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 1e7692a10c83..cde9b5af7553 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -897,7 +897,7 @@ int drm_connector_init(struct drm_device *dev, struct ida *connector_ida = &drm_connector_enum_list[connector_type].ida; - drm_modeset_lock_all(dev); + mutex_lock(&config->mutex); ret = drm_mode_object_get_reg(dev, &connector->base, DRM_MODE_OBJECT_CONNECTOR, @@ -967,7 +967,7 @@ out_put: drm_mode_object_unregister(dev, &connector->base); out_unlock: - drm_modeset_unlock_all(dev); + mutex_unlock(&config->mutex); return ret; } diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 45c218db86be..699f8d979986 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -12910,7 +12910,7 @@ verify_crtc_state(struct drm_crtc *crtc, bool active; old_state = old_crtc_state->state; - __drm_atomic_helper_crtc_destroy_state(crtc, old_crtc_state); + __drm_atomic_helper_crtc_destroy_state(old_crtc_state); pipe_config = to_intel_crtc_state(old_crtc_state); memset(pipe_config, 0, sizeof(*pipe_config)); pipe_config->base.crtc = crtc; @@ -15746,7 +15746,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev) struct intel_crtc_state *crtc_state = crtc->config; int pixclk = 0; - __drm_atomic_helper_crtc_destroy_state(&crtc->base, &crtc_state->base); + __drm_atomic_helper_crtc_destroy_state(&crtc_state->base); memset(crtc_state, 0, sizeof(*crtc_state)); crtc_state->base.crtc = &crtc->base; diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index bf55cda356ba..80d0f95820c4 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1065,7 +1065,7 @@ static void vop_crtc_destroy_state(struct drm_crtc *crtc, { struct rockchip_crtc_state *s = to_rockchip_crtc_state(state); - __drm_atomic_helper_crtc_destroy_state(crtc, &s->base); + __drm_atomic_helper_crtc_destroy_state(&s->base); kfree(s); } diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 3b85a31b625d..39902bbfb3ce 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -998,7 +998,7 @@ static void tegra_crtc_reset(struct drm_crtc *crtc) struct tegra_dc_state *state; if (crtc->state) - __drm_atomic_helper_crtc_destroy_state(crtc, crtc->state); + __drm_atomic_helper_crtc_destroy_state(crtc->state); kfree(crtc->state); crtc->state = NULL; @@ -1034,7 +1034,7 @@ tegra_crtc_atomic_duplicate_state(struct drm_crtc *crtc) static void tegra_crtc_atomic_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state) { - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); kfree(state); } diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 231356f42a04..904d0754ad78 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -650,7 +650,7 @@ static void vc4_crtc_destroy_state(struct drm_crtc *crtc, } - __drm_atomic_helper_crtc_destroy_state(crtc, state); + __drm_atomic_helper_crtc_destroy_state(state); } static const struct drm_crtc_funcs vc4_crtc_funcs = { diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h index 03642878bc51..5abbe1259a2a 100644 --- a/include/drm/drm_atomic_helper.h +++ b/include/drm/drm_atomic_helper.h @@ -117,8 +117,7 @@ void __drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc, struct drm_crtc_state *state); struct drm_crtc_state * drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc); -void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, - struct drm_crtc_state *state); +void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state); void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state); -- 2.8.1

3 6

[PATCH 0/6] drm/exynos: add pipeline clock support
by Andrzej Hajda 09 May '16

09 May '16

Hi Inki, In case of some pipielines there is need to set clock in one component by driver of another component, for example: 1. Decon and Mixer driver must enable HDMI-PHY clock before configuration. 2. DP driver must enable DP clock provided by FIMD. This set of patches provide more generic solution for such problem than currently present clock_enable callback. More details in particular patches. The patchset is based on recently sent patchset with HDMI/DECON path fixes[1]. [1]: http://permalink.gmane.org/gmane.comp.video.dri.devel/149714 Regards Andrzej Andrzej Hajda (6): drm/exynos: add helper to get crtc from pipe drm/exynos: add support for pipeline clock to the framework drm/exynos/hdmi: expose HDMI-PHY clock as pipeline clock drm/exynos/decon5433: enable HDMI-PHY before configuring DECON drm/exynos/mixer: enable HDMI-PHY before configuring MIXER drm/exynos: convert clock_enable crtc callback to pipeline clock drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++ drivers/gpu/drm/exynos/exynos_dp_core.c | 8 +--- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 10 ++-- drivers/gpu/drm/exynos/exynos_drm_drv.h | 25 ++++++++-- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 27 ++++++----- drivers/gpu/drm/exynos/exynos_hdmi.c | 67 +++++++++++++++++++-------- drivers/gpu/drm/exynos/exynos_mixer.c | 4 ++ 7 files changed, 95 insertions(+), 50 deletions(-) -- 1.9.1

2 8

[Bug 47363] Connecting DVI-0 Display-Port-0 and HDMI-0 only 2 of those can be enabled once
by bugzilla-daemon＠freedesktop.org 09 May '16

09 May '16

https://bugs.freedesktop.org/show_bug.cgi?id=47363 Tomáš Chvátal <tomas.chvatal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Tomáš Chvátal <tomas.chvatal(a)gmail.com> --- Missed the request back then for the needinfo. Can't reproduce now. -> Worksforme/invalid i guess. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2 0/4] drm: DP++ adaptor support (v2)
by ville.syrjala＠linux.intel.com 09 May '16

09 May '16

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Here's a respin of my DP++ adaptor support series [1]. Pardon for taking forever with this. Presumably we want to get this into stable to fix the regression from HDMI 12bpc support. I've tried to account for a bunch of Paulo's review comments I also tried to make the helper a bit easier to use by having the caller pass the adaptor type to the helper functions, and so the need for most adaptor type checks in driver code is eliminated. I still left some checks in i915, but those are there just to do the type 1 DVI vs. none detectio, and to suppress the debug output when no adaptor is detected. I also redid the detection logic a bit to ease future LSPCON enabling. I had to rebase a bunch of stuff due to VBT shuffling. I also noticed that my BSW still wasn't detecting type 1 DVI adaptors, which I managed to "fix" by having the VBT check also accept HDMI type dvo_ports as DP++ ports, which sucks a bit but should hopefully be robust enough. I felt that things changed a bit too much in the end for me to hang on to the r-bs unfortunately, so I didn't actually pick them up. So if people aren't too fed up with this, I'd appreciate them having a a second look. Series available here: git://github.com/vsyrjala/linux.git dp_dual_mode_3 [1] https://lists.freedesktop.org/archives/dri-devel/2016-February/101494.html Ville Syrjälä (4): drm: Add helper for DP++ adaptors drm/i915: Respect DP++ adaptor TMDS clock limit drm/i915: Enable/disable TMDS output buffers in DP++ adaptor as needed drm/i915: Determine DP++ type 1 DVI adaptor presence based on VBT drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_dp_dual_mode_helper.c | 356 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_bios.c | 36 +++ drivers/gpu/drm/i915/intel_ddi.c | 12 + drivers/gpu/drm/i915/intel_drv.h | 6 + drivers/gpu/drm/i915/intel_hdmi.c | 100 ++++++++- drivers/gpu/drm/i915/intel_vbt_defs.h | 13 ++ include/drm/drm_dp_dual_mode_helper.h | 83 +++++++ 9 files changed, 600 insertions(+), 9 deletions(-) create mode 100644 drivers/gpu/drm/drm_dp_dual_mode_helper.c create mode 100644 include/drm/drm_dp_dual_mode_helper.h -- 2.7.4

4 18

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2016