dri-devel March 2018

dri-devel@lists.freedesktop.org

263 participants
1856 discussions

New KFD ioctls: taking the skeletons out of the closet
by Felix Kuehling 12 Mar '18

12 Mar '18

Hi all, Christian raised two potential issues in a recent KFD upstreaming code review that are related to the KFD ioctl APIs: 1. behaviour of -ERESTARTSYS 2. transactional nature of KFD ioctl definitions, or lack thereof I appreciate constructive feedback, but I also want to encourage an open-minded rather than a dogmatic approach to API definitions. So let me take all the skeletons out of my closet and get these APIs reviewed in the appropriate forum before we commit to them upstream. See the end of this email for reference. The controversial part at this point is kfd_ioctl_map_memory_to_gpu. If any of the other APIs raise concerns or questions, please ask. Because of the HSA programming model, KFD memory management APIs are synchronous. There is no pipelining. Command submission to GPUs through user mode queues does not involve KFD. This means KFD doesn't know what memory is used by the GPUs and when it's used. That means, when the map_memory_to_gpu ioctl returns to user mode, all memory mapping operations are complete and the memory can be used by the CPUs or GPUs immediately. HSA also uses a shared virtual memory model, so typically memory gets mapped on multiple GPUs and CPUs at the same virtual address. The point of contention seems to be the ability to map memory to multiple GPUs in a single ioctl and the behaviour in failure cases. I'll discuss two main failure cases: 1: Failure after all mappings have been dispatched via SDMA, but a signal interrupts the wait for completion and we return -ERESTARTSYS. Documentation/kernel-hacking/hacking.rst only says "[...] you should be prepared to process the restart, e.g. if you're in the middle of manipulating some data structure." I think we do that by ensuring that memory that's already mapped won't be mapped again. So the restart will become a no-op and just end up waiting for all the previous mappings to complete. Christian has a stricter requirement, and I'd like to know where that comes from: "An interrupted IOCTL should never have a visible effect." 2: Failure to map on some but not all GPUs. This comes down to the question, do all ioctl APIs or system calls in general need to be transactional? As a counter example I'd give incomplete read or write system calls that return how much was actually read or written. Our current implementation of map_memory_to_gpu doesn't do this, but it could be modified to return to user mode how many of the mappings, or which mappings specifically failed or succeeded. I'd like to know whether such behaviour is acceptable. The alternative would be to break multi-GPU mappings, and the final wait for completion, into multiple ioctl calls. That would result in additional system call overhead. I'd argue that the end result is the same for user mode, so I don't see why I'd use multiple ioctls over a single one. I'm looking forward to your feedback. Thanks, Felix Reference: After the last rework, these are the ioctls I'm hoping to upstream in my current patch series (with annotations): /* Acquire a VM from a DRM render node FD for use by KFD on a specific device * * @drm_fd: DRM render node file descriptor * @gpu_id: device identifier (used throughout the KFD API) */ struct kfd_ioctl_acquire_vm_args { __u32 drm_fd; /* to KFD */ __u32 gpu_id; /* to KFD */ }; /* Allocation flags: memory types */ #define KFD_IOC_ALLOC_MEM_FLAGS_VRAM (1 << 0) #define KFD_IOC_ALLOC_MEM_FLAGS_GTT (1 << 1) #define KFD_IOC_ALLOC_MEM_FLAGS_USERPTR (1 << 2) #define KFD_IOC_ALLOC_MEM_FLAGS_DOORBELL (1 << 3) /* Allocation flags: attributes/access options */ #define KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE (1 << 31) #define KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE (1 << 30) #define KFD_IOC_ALLOC_MEM_FLAGS_PUBLIC (1 << 29) #define KFD_IOC_ALLOC_MEM_FLAGS_NO_SUBSTITUTE (1 << 28) #define KFD_IOC_ALLOC_MEM_FLAGS_AQL_QUEUE_MEM (1 << 27) #define KFD_IOC_ALLOC_MEM_FLAGS_COHERENT (1 << 26) /* Allocate memory for later SVM (shared virtual memory) mapping. * * @va_addr: virtual address of the memory to be allocated * all later mappings on all GPUs will use this address * @size: size in bytes * @handle: buffer handle returned to user mode, used to refer to * this allocation for mapping, unmapping and freeing * @mmap_offset: for CPU-mapping the allocation by mmapping a render node * for userptrs this is overloaded to specify the CPU address * @gpu_id: device identifier * @flags: memory type and attributes. See KFD_IOC_ALLOC_MEM_FLAGS above */ struct kfd_ioctl_alloc_memory_of_gpu_args { __u64 va_addr; /* to KFD */ __u64 size; /* to KFD */ __u64 handle; /* from KFD */ __u64 mmap_offset; /* to KFD (userptr), from KFD (mmap offset) */ __u32 gpu_id; /* to KFD */ __u32 flags; }; /* Free memory allocated with kfd_ioctl_alloc_memory_of_gpu * * @handle: memory handle returned by alloc */ struct kfd_ioctl_free_memory_of_gpu_args { __u64 handle; /* to KFD */ }; /* Map memory to one of more GPUs * * @handle: memory handle returned by alloc * @device_ids_array_ptr: array of gpu_ids * @device_ids_array_size: size of the gpu_ids array */ struct kfd_ioctl_map_memory_to_gpu_args { __u64 handle; /* to KFD */ __u64 device_ids_array_ptr; /* to KFD */ __u32 device_ids_array_size; /* to KFD */ __u32 pad; }; /* Unmap memory from one or more GPUs * * same arguments as for mapping */ struct kfd_ioctl_unmap_memory_from_gpu_args { __u64 handle; /* to KFD */ __u64 device_ids_array_ptr; /* to KFD */ __u32 device_ids_array_size; /* to KFD */ __u32 pad; }; -- F e l i x K u e h l i n g PMTS Software Development Engineer | Vertical Workstation/Compute 1 Commerce Valley Dr. East, Markham, ON L3T 7X6 Canada (O) +1(289)695-1597 _ _ _ _____ _____ / \ | \ / | | _ \ \ _ | / A \ | \M/ | | |D) ) /|_| | /_/ \_\ |_| |_| |_____/ |__/ \| facebook.com/AMD | amd.com

6 10

[Bug 105426] [regression] Mesa-18.0rc4 - black screen in some Valve games when run under Wine
by bugzilla-daemon＠freedesktop.org 12 Mar '18

12 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105426 --- Comment #5 from Józef Kucia <joseph.kucia(a)gmail.com> --- error: declarations for shader output `gl_BackSecondaryColor` are in gl_PerVertex and gl_PerVertex It looks like the same problem as bug 104668 and bug 104777. 4195eed961ccfe404ae81b9112189fc93a254ded fixes the problem. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 197925] New: [amdgpu_dc][carrizo] multiple monitor handling errors
by bugzilla-daemon＠bugzilla.kernel.org 12 Mar '18

12 Mar '18

https://bugzilla.kernel.org/show_bug.cgi?id=197925 Bug ID: 197925 Summary: [amdgpu_dc][carrizo] multiple monitor handling errors Product: Drivers Version: 2.5 Kernel Version: 4.14+ (4.15 - git) Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: kwkaess(a)gmx.com Regression: No Created attachment 260721 --> https://bugzilla.kernel.org/attachment.cgi?id=260721&action=edit pertinent dmesg output Not necessarily a bug, since I am running experimental features, but figured I would get the ball rolling. Running current kernel (commit 1deab8ce2c91e3b16563b7a7ea150f82334262ec) compiled with the following configuration flags: CONFIG_DRM_AMD_DC=y CONFIG_DRM_AMD_DC_PRE_VEGA=y CONFIG_DRM_AMD_DC_FBC=y CONFIG_HSA_AMD=m On the following hardware: Toshiba L55D-C with AMD A10-8700P With: Fedora 27 Workstation on top This generates a dmesg error on boot: [ 5.350313] [drm:hwss_wait_for_blank_complete [amdgpu]] *ERROR* DC: failed to blank crtc! It also has multiple non-desirable behaviors (which may be gnome- or Fedora-related...) 1) Fails to turn off backlight upon internal monitor shut-off. 2) Fails to turn on external monitor upon resume from idle. This can be remedied by forcing the monitor back on via twiddling of other settings. 3) Fails to turn on either external or internal monitor upon resume from sleep - this one isn't easily remedied, due to no visual feedback. I am attaching pertinent dmesg lines (dmesg | grep -e amdgpu -e drm -e kfd) > dmesg.txt) -- You are receiving this mail because: You are watching the assignee of the bug.

1 16

[PATCH] drm/vmwgfx: Use kasprintf
by Himanshu Jha 12 Mar '18

12 Mar '18

Use kasprintf instead of combination of kmalloc and sprintf. Also, remove the local variables used for storing the string length as they are not required now. Signed-off-by: Himanshu Jha <himanshujha199640(a)gmail.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c index 9700099..cdff992 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c @@ -328,7 +328,7 @@ int vmw_host_get_guestinfo(const char *guest_info_param, { struct rpc_channel channel; char *msg, *reply = NULL; - size_t msg_len, reply_len = 0; + size_t reply_len = 0; int ret = 0; @@ -338,15 +338,12 @@ int vmw_host_get_guestinfo(const char *guest_info_param, if (!guest_info_param || !length) return -EINVAL; - msg_len = strlen(guest_info_param) + strlen("info-get ") + 1; - msg = kzalloc(msg_len, GFP_KERNEL); + msg = kasprintf(GFP_KERNEL, "info-get %s", guest_info_param); if (!msg) { DRM_ERROR("Cannot allocate memory to get %s", guest_info_param); return -ENOMEM; } - sprintf(msg, "info-get %s", guest_info_param); - if (vmw_open_channel(&channel, RPCI_PROTOCOL_NUM) || vmw_send_msg(&channel, msg) || vmw_recv_msg(&channel, (void *) &reply, &reply_len) || @@ -388,7 +385,6 @@ int vmw_host_log(const char *log) { struct rpc_channel channel; char *msg; - int msg_len; int ret = 0; @@ -398,15 +394,12 @@ int vmw_host_log(const char *log) if (!log) return ret; - msg_len = strlen(log) + strlen("log ") + 1; - msg = kzalloc(msg_len, GFP_KERNEL); + msg = kasprintf(GFP_KERNEL, "log %s", log); if (!msg) { DRM_ERROR("Cannot allocate memory for log message\n"); return -ENOMEM; } - sprintf(msg, "log %s", log); - if (vmw_open_channel(&channel, RPCI_PROTOCOL_NUM) || vmw_send_msg(&channel, msg) || vmw_close_channel(&channel)) { -- 2.7.4

2 1

[PATCH 00/10] Switch Versatile and RealView to DRM
by Linus Walleij 12 Mar '18

12 Mar '18

The ARM Versatile and RealView platforms have enough support merged for v4.17/next that we can fully switch them all over to using the DRM PL111 driver instead of the old fbdev driver. Integrator and Versatile Express will follow. The device trees are augmented with the proper VGA bridges instead of "panels" that were never correct, the maximum memory bandwidth is augmented and these platforms can now in many cases support 1024x768 in 16bpp instead of only 640x480 with 32bpp. If the board has the IB1 or IB2 daughterboard mounted, the daughterboard display will take precedence over the VGA connector. The IB1 daughterboard which connects a number of various displays does not need any separate device tree: it will be autodetected. For the Versatile CP with the IB2 daughterboard we need to add a new device tree, as it has a system controller we need to access and a few other features we may want to make use of in the future. (It already has proper device tree bindings in place.) This has been tested on: - RealView PM11MPCore - RealView PB1176 - Versatile AB with and without the IB2 daughterboard - All applicable QEMU models: RealView EB, RealView PBA8, RealView PBX-A9 and Versatile AB. I'm planning to send this as two pull requests: one for the DTS changes and one for the defconfig changes. Linus Walleij (10): ARM: dts: Augment VGA connector bridge on PB11MPcore ARM: dts: Augment VGA connector bridge on PB1176 ARM: dts: Augment VGA connector bridge on Realview EB ARM: dts: Augment VGA connector bridge on Realview PBX ARM: dts: Add Versatile IB2 device tree ARM: dts: Augment panel setting for Versatile ARM: defconfig: Update RealView defconfig ARM: defconfig: Switch RealView boards to use P111 DRM ARM: defconfig: Update Versatile defconfig ARM: defconfig: Configure Versatile boards to use PL111 DRM arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/arm-realview-eb.dtsi | 64 +++++++++++++++--------- arch/arm/boot/dts/arm-realview-pb1176.dts | 66 ++++++++++++++---------- arch/arm/boot/dts/arm-realview-pb11mp.dts | 78 +++++++++++++++++++---------- arch/arm/boot/dts/arm-realview-pbx.dtsi | 82 ++++++++++++++++++++---------- arch/arm/boot/dts/versatile-ab-ib2.dts | 26 ++++++++++ arch/arm/boot/dts/versatile-ab.dts | 83 ++++++++++++++++++++++++++++++- arch/arm/configs/realview_defconfig | 21 ++++---- arch/arm/configs/versatile_defconfig | 18 ++++--- 9 files changed, 317 insertions(+), 122 deletions(-) create mode 100644 arch/arm/boot/dts/versatile-ab-ib2.dts -- 2.14.3

3 15

[Bug 199089] New: nouveau 0000:65:00.0: disp: outp 01:0006;0f84: link rate unsupported by sink (displayport monitor flickering)
by bugzilla-daemon＠bugzilla.kernel.org 12 Mar '18

12 Mar '18

https://bugzilla.kernel.org/show_bug.cgi?id=199089 Bug ID: 199089 Summary: nouveau 0000:65:00.0: disp: outp 01:0006;0f84: link rate unsupported by sink (displayport monitor flickering) Product: Drivers Version: 2.5 Kernel Version: 4.13.0-36-generic Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: naisanza(a)gmail.com Regression: No Monitor: LG 34" 34UM94-P GPU: Nvidia GTX 1080 Ti The flickering happens erratically and too often to be able to type anything to the console I found the relative error from the dp.c file, but have no idea what else is needed: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/nouveau/nvkm/… -- You are receiving this mail because: You are watching the assignee of the bug.

1 1

[Bug 105426] [regression] Mesa-18.0rc4 - black screen in some Valve games when run under Wine
by bugzilla-daemon＠freedesktop.org 12 Mar '18

12 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105426 --- Comment #4 from Emil Velikov <emil.l.velikov(a)gmail.com> --- Bisecting the issue to the offending commit would be a good move. A small shader test [1] for piglit will also be a nice move. Thus one can easily reproduce and + ensure it doesn't happen in the future ;-) [1] Simple example test https://cgit.freedesktop.org/piglit/tree/tests/shaders/glsl-algebraic-rcp-s… -- You are receiving this mail because: You are the assignee for the bug.

1 0

[drm:drm-next 8/10] htmldocs: drivers/gpu/drm/drm_vblank.c:1252: warning: Function parameter or member 'dev' not described in 'drm_vblank_restore'
by kbuild test robot 12 Mar '18

12 Mar '18

tree: git://people.freedesktop.org/~airlied/linux.git drm-next head: 128ccceaba8656573b8b0f86d3ab6e38094cc754 commit: f073d78eeb8efd85718e611c15f9a78647751dea [8/10] Merge tag 'drm-intel-next-2018-02-21' of git://anongit.freedesktop.org/drm/drm-intel into drm-next reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.prev_bssid' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2259: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2259: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:950: warning: Function parameter or member 'rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:584: warning: Function parameter or member 'msdu' not described in 'sta_info' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:142: warning: Function parameter or member 'request_key' not described in 'gpio_irq_chip' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.sign' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.realbits' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.storagebits' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.shift' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.repeat' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.endianness' not described in 'iio_chan_spec' include/linux/iio/hw-consumer.h:1: warning: no structured comments found include/linux/device.h:294: warning: Function parameter or member 'coredump' not described in 'device_driver' include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/mtd/rawnand.h:709: warning: Function parameter or member 'timings.sdr' not described in 'nand_data_interface' include/linux/mtd/rawnand.h:774: warning: Function parameter or member 'buf' not described in 'nand_op_data_instr' include/linux/mtd/rawnand.h:774: warning: Function parameter or member 'buf.in' not described in 'nand_op_data_instr' include/linux/mtd/rawnand.h:774: warning: Function parameter or member 'buf.out' not described in 'nand_op_data_instr' include/linux/mtd/rawnand.h:820: warning: Function parameter or member 'ctx' not described in 'nand_op_instr' include/linux/mtd/rawnand.h:820: warning: Function parameter or member 'ctx.cmd' not described in 'nand_op_instr' include/linux/mtd/rawnand.h:820: warning: Function parameter or member 'ctx.addr' not described in 'nand_op_instr' include/linux/mtd/rawnand.h:820: warning: Function parameter or member 'ctx.data' not described in 'nand_op_instr' include/linux/mtd/rawnand.h:820: warning: Function parameter or member 'ctx.waitrdy' not described in 'nand_op_instr' include/linux/mtd/rawnand.h:967: warning: Function parameter or member 'ctx' not described in 'nand_op_parser_pattern_elem' include/linux/mtd/rawnand.h:967: warning: Function parameter or member 'ctx.addr' not described in 'nand_op_parser_pattern_elem' include/linux/mtd/rawnand.h:967: warning: Function parameter or member 'ctx.data' not described in 'nand_op_parser_pattern_elem' include/linux/mtd/rawnand.h:1281: warning: Function parameter or member 'manufacturer.desc' not described in 'nand_chip' include/linux/mtd/rawnand.h:1281: warning: Function parameter or member 'manufacturer.priv' not described in 'nand_chip' include/linux/regulator/driver.h:221: warning: Function parameter or member 'resume_early' not described in 'regulator_ops' drivers/regulator/core.c:4299: warning: Excess function parameter 'state' description in 'regulator_suspend_late' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver' include/drm/drm_drv.h:609: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver' include/drm/drm_vblank.h:60: warning: Incorrect use of kernel-doc format: Documentation Makefile scripts source @event.base: DRM event base class. include/drm/drm_vblank.h:65: warning: Incorrect use of kernel-doc format: Documentation Makefile scripts source @event.vbl: include/drm/drm_vblank.h:75: warning: Incorrect use of kernel-doc format: Documentation Makefile scripts source @event.seq: Event payload for the MODE_QUEUEU_SEQUENCE IOCTL. include/drm/drm_vblank.h:79: warning: Function parameter or member 'event.base' not described in 'drm_pending_vblank_event' include/drm/drm_vblank.h:79: warning: Function parameter or member 'event.vbl' not described in 'drm_pending_vblank_event' include/drm/drm_vblank.h:79: warning: Function parameter or member 'event.seq' not described in 'drm_pending_vblank_event' >> drivers/gpu/drm/drm_vblank.c:1252: warning: Function parameter or member 'dev' not described in 'drm_vblank_restore' >> drivers/gpu/drm/drm_vblank.c:1252: warning: Function parameter or member 'pipe' not described in 'drm_vblank_restore' >> drivers/gpu/drm/drm_vblank.c:1295: warning: Function parameter or member 'crtc' not described in 'drm_crtc_vblank_restore' drivers/gpu/drm/drm_prime.c:342: warning: Function parameter or member 'attach' not described in 'drm_gem_unmap_dma_buf' drivers/gpu/drm/drm_prime.c:342: warning: Function parameter or member 'sgt' not described in 'drm_gem_unmap_dma_buf' drivers/gpu/drm/drm_prime.c:342: warning: Function parameter or member 'dir' not described in 'drm_gem_unmap_dma_buf' drivers/gpu/drm/drm_prime.c:438: warning: Function parameter or member 'dma_buf' not described in 'drm_gem_dmabuf_kmap_atomic' drivers/gpu/drm/drm_prime.c:438: warning: Function parameter or member 'page_num' not described in 'drm_gem_dmabuf_kmap_atomic' drivers/gpu/drm/drm_prime.c:450: warning: Function parameter or member 'dma_buf' not described in 'drm_gem_dmabuf_kunmap_atomic' drivers/gpu/drm/drm_prime.c:450: warning: Function parameter or member 'page_num' not described in 'drm_gem_dmabuf_kunmap_atomic' drivers/gpu/drm/drm_prime.c:450: warning: Function parameter or member 'addr' not described in 'drm_gem_dmabuf_kunmap_atomic' drivers/gpu/drm/drm_prime.c:461: warning: Function parameter or member 'dma_buf' not described in 'drm_gem_dmabuf_kmap' drivers/gpu/drm/drm_prime.c:461: warning: Function parameter or member 'page_num' not described in 'drm_gem_dmabuf_kmap' drivers/gpu/drm/drm_prime.c:473: warning: Function parameter or member 'dma_buf' not described in 'drm_gem_dmabuf_kunmap' drivers/gpu/drm/drm_prime.c:473: warning: Function parameter or member 'page_num' not described in 'drm_gem_dmabuf_kunmap' drivers/gpu/drm/drm_prime.c:473: warning: Function parameter or member 'addr' not described in 'drm_gem_dmabuf_kunmap' drivers/gpu/drm/i915/intel_dpio_phy.c:150: warning: Incorrect use of kernel-doc format: Documentation Makefile scripts source @channel.port: which port maps to this channel. drivers/gpu/drm/tve200/tve200_drv.c:1: warning: no structured comments found include/linux/skbuff.h:846: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'skb_mstamp' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'head_frag' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member '__unused' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'pfmemalloc' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'csum_valid' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'csum_level' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'offload_fwd_mark' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'offload_mr_fwd_mark' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:846: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff' include/net/sock.h:234: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_portpair' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_cookie' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_listener' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common' include/net/sock.h:234: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common' include/net/sock.h:487: warning: Function parameter or member 'sk_backlog.rmem_alloc' not described in 'sock' include/net/sock.h:487: warning: Function parameter or member 'sk_backlog.len' not described in 'sock' include/net/sock.h:487: warning: Function parameter or member 'sk_backlog.head' not described in 'sock' include/net/sock.h:487: warning: Function parameter or member 'sk_backlog.tail' not described in 'sock' include/net/sock.h:487: warning: Function parameter or member 'sk_wq_raw' not described in 'sock' include/net/sock.h:487: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock' include/linux/netdevice.h:1940: warning: Function parameter or member 'adj_list.upper' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'adj_list.lower' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'gso_partial_features' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'switchdev_ops' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'name_assign_type' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'mpls_ptr' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'xdp_prog' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member '____cacheline_aligned_in_smp' not described in 'net_device' include/linux/netdevice.h:1940: warning: Function parameter or member 'qdisc_hash' not described in 'net_device' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state' include/linux/rcupdate.h:570: ERROR: Unexpected indentation. include/linux/rcupdate.h:574: ERROR: Unexpected indentation. include/linux/rcupdate.h:578: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/rcupdate.h:580: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/rcupdate.h:580: WARNING: Inline literal start-string without end-string. kernel/time/timer.c:1259: ERROR: Unexpected indentation. kernel/time/timer.c:1261: ERROR: Unexpected indentation. kernel/time/timer.c:1262: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:110: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:113: ERROR: Unexpected indentation. include/linux/wait.h:115: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:1113: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:327: WARNING: Inline literal start-string without end-string. drivers/video/fbdev/core/modedb.c:647: WARNING: Inline strong start-string without end-string. drivers/video/fbdev/core/modedb.c:647: WARNING: Inline strong start-string without end-string. drivers/video/fbdev/core/modedb.c:647: WARNING: Inline strong start-string without end-string. drivers/video/fbdev/core/modedb.c:647: WARNING: Inline strong start-string without end-string. include/linux/iio/iio.h:191: ERROR: Unexpected indentation. include/linux/iio/iio.h:192: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/iio/iio.h:198: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/ata/libata-core.c:5920: ERROR: Unknown target name: "hw". drivers/message/fusion/mptbase.c:5052: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1901: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/mtd/rawnand.h:805: ERROR: Unexpected indentation. include/linux/mtd/rawnand.h:1391: WARNING: Inline strong start-string without end-string. include/linux/mtd/rawnand.h:1393: WARNING: Inline strong start-string without end-string. include/linux/regulator/driver.h:273: ERROR: Unknown target name: "regulator_regmap_x_voltage". Documentation/driver-api/slimbus.rst:93: WARNING: Title underline too short. vim +1252 drivers/gpu/drm/drm_vblank.c 3ed4351a Daniel Vetter 2017-05-31 1239 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1240 /** d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1241 * drm_vblank_restore - estimated vblanks using timestamps and update it. d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1242 * d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1243 * Power manamement features can cause frame counter resets between vblank d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1244 * disable and enable. Drivers can then use this function in their d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1245 * &drm_crtc_funcs.enable_vblank implementation to estimate the vblanks since d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1246 * the last &drm_crtc_funcs.disable_vblank. d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1247 * d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1248 * This function is the legacy version of drm_crtc_vblank_restore(). d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1249 */ d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1250 void drm_vblank_restore(struct drm_device *dev, unsigned int pipe) d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1251 { d0bb96b4 Dhinakaran Pandiyan 2018-02-02 @1252 ktime_t t_vblank; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1253 struct drm_vblank_crtc *vblank; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1254 int framedur_ns; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1255 u64 diff_ns; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1256 u32 cur_vblank, diff = 1; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1257 int count = DRM_TIMESTAMP_MAXRETRIES; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1258 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1259 if (WARN_ON(pipe >= dev->num_crtcs)) d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1260 return; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1261 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1262 assert_spin_locked(&dev->vbl_lock); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1263 assert_spin_locked(&dev->vblank_time_lock); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1264 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1265 vblank = &dev->vblank[pipe]; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1266 WARN_ONCE((drm_debug & DRM_UT_VBL) && !vblank->framedur_ns, d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1267 "Cannot compute missed vblanks without frame duration\n"); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1268 framedur_ns = vblank->framedur_ns; d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1269 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1270 do { d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1271 cur_vblank = __get_vblank_counter(dev, pipe); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1272 drm_get_last_vbltimestamp(dev, pipe, &t_vblank, false); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1273 } while (cur_vblank != __get_vblank_counter(dev, pipe) && --count > 0); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1274 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1275 diff_ns = ktime_to_ns(ktime_sub(t_vblank, vblank->time)); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1276 if (framedur_ns) d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1277 diff = DIV_ROUND_CLOSEST_ULL(diff_ns, framedur_ns); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1278 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1279 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1280 DRM_DEBUG_VBL("missed %d vblanks in %lld ns, frame duration=%d ns, hw_diff=%d\n", d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1281 diff, diff_ns, framedur_ns, cur_vblank - vblank->last); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1282 store_vblank(dev, pipe, diff, t_vblank, cur_vblank); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1283 } d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1284 EXPORT_SYMBOL(drm_vblank_restore); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1285 d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1286 /** d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1287 * drm_crtc_vblank_restore - estimate vblanks using timestamps and update it. d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1288 * Power manamement features can cause frame counter resets between vblank d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1289 * disable and enable. Drivers can then use this function in their d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1290 * &drm_crtc_funcs.enable_vblank implementation to estimate the vblanks since d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1291 * the last &drm_crtc_funcs.disable_vblank. d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1292 */ d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1293 void drm_crtc_vblank_restore(struct drm_crtc *crtc) d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1294 { d0bb96b4 Dhinakaran Pandiyan 2018-02-02 @1295 drm_vblank_restore(crtc->dev, drm_crtc_index(crtc)); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1296 } d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1297 EXPORT_SYMBOL(drm_crtc_vblank_restore); d0bb96b4 Dhinakaran Pandiyan 2018-02-02 1298 :::::: The code at line 1252 was first introduced by commit :::::: d0bb96b4be69feea97f16de5306c35e280658931 drm/vblank: Restoring vblank counts after device PM events. :::::: TO: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com> :::::: CC: Rodrigo Vivi <rodrigo.vivi(a)intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

3 2

[Bug 100759] [r600] System freeze on resume from sleep on battery with DPM enabled and linux 4.10
by bugzilla-daemon＠freedesktop.org 12 Mar '18

12 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=100759 Bug ID: 100759 Summary: [r600] System freeze on resume from sleep on battery with DPM enabled and linux 4.10 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: nicolamori(a)aol.com Created attachment 130983 --> https://bugs.freedesktop.org/attachment.cgi?id=130983&action=edit journalctl log for failed resume Since linux 4.10.1 my system freezes every time when resuming from sleep (suspend to ram) while on battery. The screen either remains black or displays garbage, and the only thing to do is a hard poweroff. The problem does not show up when either: - running on AC or - using linux 4.9 (tested with 4.9.11) or - DPM is not enabled (radeon.dpm=0) I checked journalctl but it does not contain anything useful. I attach the last part of the log, starting from the suspend request; it seems nothing from the failed resume process is logged. System details: - Archlinux x86_64 - Mobility Radeon HD 3470 - Plasma desktop 5.9.4 -- You are receiving this mail because: You are the assignee for the bug.

1 7

[PATCH v2 0/2] drm/panel: Add support for Raydium RM68200 panel
by Philippe Cornu 12 Mar '18

12 Mar '18

The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD panel connected using a MIPI-DSI video interface. Version 2: - Add Rob Herring Reviewed-by on dt-bindings. - Update Kconfig & driver thanks to Thierry Reding comments: no more DRV_NAME, DRM_WARN_ONCE instead of DRV_NAME where applicable, use backlight_enable/disable() & devm_of_find_backlight(), no extra gpio reset to 0, no more msg if successful, use RM68200 instead of rm68200 where necessary. Version 1: - Initial commit Philippe Cornu (2): dt-bindings/display/panel: Add support for Raydium rm68200 dsi panel drm/panel: Add support for Raydium RM68200 panel driver .../bindings/display/panel/raydium,rm68200.txt | 25 ++ drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-raydium-rm68200.c | 437 +++++++++++++++++++++ 4 files changed, 471 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm68200.txt create mode 100755 drivers/gpu/drm/panel/panel-raydium-rm68200.c -- 2.15.1

3 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2018