dri-devel March 2018

dri-devel@lists.freedesktop.org

263 participants
1856 discussions

[Bug 105359] kms_frontbuffer_tracking - FBC disabled
by bugzilla-daemon＠freedesktop.org 06 Mar '18

06 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105359 Marta Löfstedt <marta.lofstedt(a)intel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|intel-gfx-bugs(a)lists.freede | |sktop.org | Component|DRM/Intel |IGT Assignee|intel-gfx-bugs(a)lists.freede |dri-devel(a)lists.freedesktop |sktop.org |.org --- Comment #3 from Marta Löfstedt <marta.lofstedt(a)intel.com> --- Sent up an igt patch that will skip the test if FBC was disabled by previous error. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 105353] Textures flickering in Civilizations VI
by bugzilla-daemon＠freedesktop.org 06 Mar '18

06 Mar '18

1 0

[PATCH] drm: of: simplify component probe code
by Baruch Siach 06 Mar '18

06 Mar '18

Use positive logic for better readability. This also eliminates one of_node_put() call, making the code shorter. Signed-off-by: Baruch Siach <baruch(a)tkos.co.il> --- drivers/gpu/drm/drm_of.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 4c191c050e7d..fa354d14127b 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -122,12 +122,10 @@ int drm_of_component_probe(struct device *dev, if (!port) break; - if (!of_device_is_available(port->parent)) { - of_node_put(port); - continue; - } + if (of_device_is_available(port->parent)) + drm_of_component_match_add(dev, &match, compare_of, + port); - drm_of_component_match_add(dev, &match, compare_of, port); of_node_put(port); } -- 2.16.1

3 2

Re: [PATCH v4 15/38] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel
by Marek Szyprowski 06 Mar '18

06 Mar '18

Hi All, This is the patch, which introduces the issue I've pointed here: https://lists.freedesktop.org/archives/dri-devel/2018-March/167794.html On 2018-03-05 23:23, Enric Balletbo i Serra wrote: > From: Lin Huang <hl(a)rock-chips.com> > > When panel is shut down, we should make sure edp can be disabled to avoid > undefined behavior. > > Cc: Stéphane Marchesin <marcheu(a)chromium.org> > Signed-off-by: Lin Huang <hl(a)rock-chips.com> > Signed-off-by: zain wang <wzz(a)rock-chips.com> > Signed-off-by: Sean Paul <seanpaul(a)chromium.org> > Signed-off-by: Thierry Escande <thierry.escande(a)collabora.com> > Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo(a)collabora.com> > --- > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 92fb9a072cb6..9b7d530ad24c 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1160,6 +1160,12 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) > > pm_runtime_get_sync(dp->dev); > > + ret = clk_prepare_enable(dp->clock); > + if (ret < 0) { > + DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret); > + goto out_dp_clk_pre; > + } > + > if (dp->plat_data->power_on) > dp->plat_data->power_on(dp->plat_data); > > @@ -1191,6 +1197,8 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) > phy_power_off(dp->phy); > if (dp->plat_data->power_off) > dp->plat_data->power_off(dp->plat_data); > + clk_disable_unprepare(dp->clock); > +out_dp_clk_pre: > pm_runtime_put_sync(dp->dev); > > return ret; > @@ -1234,10 +1242,13 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) > > disable_irq(dp->irq); > phy_power_off(dp->phy); > + analogix_dp_set_analog_power_down(dp, POWER_ALL, 1); In case of Exynos DP, external PHY is used to power the DP block, so no register access should be performed after phy_power_off(). Please move analogix_dp_set_analog_power_down() before phy_power_off(). > > if (dp->plat_data->power_off) > dp->plat_data->power_off(dp->plat_data); > > + clk_disable_unprepare(dp->clock); > + > pm_runtime_put_sync(dp->dev); > > ret = analogix_dp_prepare_panel(dp, false, true); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

2 1

[PATCH] dma-buf/reservation: should keep the new fence in add_shared_inplace
by Monk Liu 06 Mar '18

06 Mar '18

Change-Id: If6a979ba9fd6c923b82212f35f07a9ff31c86767 Signed-off-by: Monk Liu <Monk.Liu(a)amd.com> --- drivers/dma-buf/reservation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c index 314eb10..29b7e45 100644 --- a/drivers/dma-buf/reservation.c +++ b/drivers/dma-buf/reservation.c @@ -118,7 +118,7 @@ reservation_object_add_shared_inplace(struct reservation_object *obj, old_fence = rcu_dereference_protected(fobj->shared[i], reservation_object_held(obj)); - if (old_fence->context == fence->context) { + if (dma_fence_is_later(fence, old_fence)) { /* memory barrier is added by write_seqcount_begin */ RCU_INIT_POINTER(fobj->shared[i], fence); write_seqcount_end(&obj->seq); -- 2.7.4

4 4

[Bug 105021] suspend / rx550 / extremely slow after 2nd thaw
by bugzilla-daemon＠freedesktop.org 06 Mar '18

06 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105021 --- Comment #28 from arne_woerner(a)yahoo.com --- linux kernel 4.15.7-1-MANJARO with mesa 17.3.6-1 still does not like 20180119-2 polaris12 firmware... -arne -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] dma-buf/reservation: should keep later one in add fence(v3)
by Monk Liu 06 Mar '18

06 Mar '18

v2: still check context first to avoid warning from dma_fence_is_later apply this fix in add_shared_replace as well v3: use a bool falg to indict if fence is need to insert to new slot and ignore it if it is an eld fence compared with the one with the same context in old->shared Change-Id: If6a979ba9fd6c923b82212f35f07a9ff31c86767 Signed-off-by: Monk Liu <Monk.Liu(a)amd.com> --- drivers/dma-buf/reservation.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c index 314eb10..a7d0598 100644 --- a/drivers/dma-buf/reservation.c +++ b/drivers/dma-buf/reservation.c @@ -118,7 +118,8 @@ reservation_object_add_shared_inplace(struct reservation_object *obj, old_fence = rcu_dereference_protected(fobj->shared[i], reservation_object_held(obj)); - if (old_fence->context == fence->context) { + if (old_fence->context == fence->context && + dma_fence_is_later(fence, old_fence)) { /* memory barrier is added by write_seqcount_begin */ RCU_INIT_POINTER(fobj->shared[i], fence); write_seqcount_end(&obj->seq); @@ -158,6 +159,7 @@ reservation_object_add_shared_replace(struct reservation_object *obj, struct dma_fence *fence) { unsigned i, j, k; + bool wrong_fence = false; dma_fence_get(fence); @@ -179,15 +181,29 @@ reservation_object_add_shared_replace(struct reservation_object *obj, check = rcu_dereference_protected(old->shared[i], reservation_object_held(obj)); - if (check->context == fence->context || - dma_fence_is_signaled(check)) + if (dma_fence_is_signaled(check)) { + /* put check to tail of fobj if signaled */ RCU_INIT_POINTER(fobj->shared[--k], check); - else + } else if (check->context == fence->context) { + if (dma_fence_is_later(fence, check)) { + /* put check to tail of fobj if it is deprecated */ + RCU_INIT_POINTER(fobj->shared[--k], check); + } else { + /* this is a wrong operation that add an eld fence */ + wrong_fence = true; + RCU_INIT_POINTER(fobj->shared[j++], check); + } + } else { + /* add fence to new slot */ RCU_INIT_POINTER(fobj->shared[j++], check); + } } + fobj->shared_count = j; - RCU_INIT_POINTER(fobj->shared[fobj->shared_count], fence); - fobj->shared_count++; + if (!wrong_fence) { + RCU_INIT_POINTER(fobj->shared[fobj->shared_count], fence); + fobj->shared_count++; + } done: preempt_disable(); -- 2.7.4

3 2

[PATCH] drm: simple_kms_helper: Fix .mode_valid() documentation
by Linus Walleij 06 Mar '18

06 Mar '18

This fixes up the .mode_valid() vtable entry documentation by copyediting the documentation from the .mode_valid() documentation in the drm_modeset_helper_vtables.h file. Fixes: 40275dc4edb4 ("drm: simple_kms_helper: Add mode_valid() callback support") Suggested-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- include/drm/drm_simple_kms_helper.h | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_kms_helper.h index d9e4c3c3f009..0d700a869cc8 100644 --- a/include/drm/drm_simple_kms_helper.h +++ b/include/drm/drm_simple_kms_helper.h @@ -24,9 +24,30 @@ struct drm_simple_display_pipe_funcs { /** * @mode_valid: * - * This function is called to filter out valid modes from the - * suggestions suggested by the bridge or display. This optional - * hook is passed in when initializing the pipeline. + * This callback is used to check if a specific mode is valid in the + * crtc used in this simple display pipe. This should be implemented + * if the display pipe has some sort of restriction in the modes + * it can display. For example, a given display pipe may be responsible + * to set a clock value. If the clock can not produce all the values + * for the available modes then this callback can be used to restrict + * the number of modes to only the ones that can be displayed. Another + * reason can be bandwidth mitigation: the memory port on the display + * controller can have bandwidth limitations not allowing pixel data + * to be fetched at any rate. + * + * This hook is used by the probe helpers to filter the mode list in + * drm_helper_probe_single_connector_modes(), and it is used by the + * atomic helpers to validate modes supplied by userspace in + * drm_atomic_helper_check_modeset(). + * + * This function is optional. + * + * NOTE: + * + * Since this function is both called from the check phase of an atomic + * commit, and the mode validation in the probe paths it is not allowed + * to look at anything else but the passed-in mode, and validate it + * against configuration-invariant hardware constraints. * * RETURNS: * -- 2.14.3

2 1

[PATCH 0/4] drm/tilcdc: Add DRM panel support and use it for am335x-evm
by Jyri Sarha 06 Mar '18

06 Mar '18

The first patch adds support for drm panels to tilcdc. The second is just for convenience. The third adds support for am335x-evm's panel to panel-simple driver. The third changes am335x-evm's dts file to use panel-simple instead of tilcdc's bundled dpi-panel support. After the review I will pick the tilcdc patches, but how about the panel-simple, who will take it? There is no hurry with the dts patch. We can even wait with it until the next release, when everything certainly ready for it. The evm works just fine with the old tilcdc bundled panel support and we probably have to keep it around indefinately for backward compatibility. Best regards, Jyri Jyri Sarha (4): drm/tilcdc: Add support for drm panels drm/tilcdc: tilcdc_panel: Rename device from "panel" to "tilcdc-panel" drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel arch/arm/boot/dts/am335x-evm.dts | 44 +++++++++++++------------------- drivers/gpu/drm/panel/panel-simple.c | 26 +++++++++++++++++++ drivers/gpu/drm/tilcdc/Kconfig | 2 ++ drivers/gpu/drm/tilcdc/tilcdc_external.c | 29 ++++++++++++++------- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- 5 files changed, 67 insertions(+), 36 deletions(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

3 9

[PATCH 0/4] drm/msm: Avoid subclassing of drm_atomic_state
by Rob Clark 06 Mar '18

06 Mar '18

Re-spin of Archit's original RFC. I've added a modeset lock to the private object, making it operate in a way more consistent with other objects, and avoiding the need for the locking dance in the driver. Possibly we could split up mixer state from smp/hwpipe state into separate private objects. In that case, the purpose would be mainly to split the locking, so having the modeset lock per object in drm core works out nicely for that. The remainder of the patchset is Archit's original patchset, with the now redundant locking removed, and rebased onto msm-next. >From original cover-letter: It's been recommended that we use drm_private_objs embedded in drm_atomic_state to hold shared resources instead of subclassing drm_atomic_state. This will also help us in getting one step closer to using the atomic commit helpers instead of the msm_atomic_commit() funcs in msm_atomic.c Archit Taneja (3): drm/msm/mdp5: Add global state as a private atomic object drm/msm/mdp5: Use the new private_obj state drm/msm: Don't subclass drm_atomic_state anymore Rob Clark (1): drm/atomic: integrate modeset lock with private objects drivers/gpu/drm/drm_atomic.c | 9 ++- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 101 ++++++++++++++++++++--------- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 26 ++++---- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c | 20 +++--- drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 17 +++-- drivers/gpu/drm/msm/msm_atomic.c | 31 --------- drivers/gpu/drm/msm/msm_drv.c | 3 - drivers/gpu/drm/msm/msm_kms.h | 14 ---- include/drm/drm_atomic.h | 5 ++ 10 files changed, 126 insertions(+), 112 deletions(-) -- 2.14.3

4 19

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2018