dri-devel March 2018

dri-devel@lists.freedesktop.org

263 participants
1856 discussions

[PATCH v4 00/38] DRM Rockchip rk3399 (Kevin)
by Enric Balletbo i Serra 05 Mar '18

05 Mar '18

Hi, This patchset includes cleanups, improvements, and bug fixes for Rockchip DRM driver and PSR support. This new version is the same as before but rebased on top of drm-misc-next plus the Marek patches that fixes Chromebook2 Peach-Pit [1] and the latest series of Rockchip rk3399 eDP support [2]. [1] https://www.spinics.net/lists/dri-devel/msg167804.html [2] https://www.spinics.net/lists/dri-devel/msg167770.html Regards, Enric Changes in v4: - Rebased all on top of drm-misc-next - Removed the following patches as are already applied. [PATCH v3 01/43] drm/rockchip: Get rid of unnecessary struct fields [PATCH v3 02/43] drm/rockchip: support prime import sg table [PATCH v3 03/43] drm/rockchip: Respect page offset for PRIME mmap calls - Removed the following patches as now are part of another patchset [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind [PATCH v3 33/43] drm/panel: simple: Change mode for Sharp lq123p1jx31 Changes in v3: - Addressed some of the comments from Sean on the v2 Changes in v2: - A few patches have been replaced by newer and cleaner versions from the ChromeOS kernel gerrit, especially about disallowing PSR for the whole atomic commit. Douglas Anderson (4): drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner drm/bridge: analogix_dp: Properly log AUX CH errors drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip drm/bridge: analogix_dp: Split the platform-specific poweron in two parts Kristian H. Kristensen (1): drm/rockchip: Disable PSR on input events Lin Huang (6): drm/bridge: analogix_dp: Move enable video into config_video() drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel drm/bridge: analogix_dp: Extend hpd check time to 100ms drm/bridge: analogix_dp: Check dpcd write/read status drm/bridge: analogix_dp: Reset aux channel if an error occurred Mark Yao (1): drm/rockchip: pre dither down when output bpc is 8bit Sean Paul (2): drm/rockchip: Don't use atomic constructs for psr drm/rockchip: Remove analogix psr worker Tomasz Figa (7): drm/rockchip: analogix_dp: Do not call Analogix code before bind drm/rockchip: Cancel PSR enable work before changing the state drm/rockchip: psr: Avoid redundant calls to .set() callback drm/rockchip: psr: Sanitize semantics of allow/disallow API drm/rockchip: Disable PSR from reboot notifier drm/rockchip: Disallow PSR for the whole atomic commit drm/rockchip: psr: Remove flush by CRTC Yakir Yang (1): drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR zain wang (16): drm/bridge: analogix_dp: set psr activate/deactivate when enable/disable bridge drm/bridge: analogix_dp: Don't change psr while bridge is disabled drm/rockchip: add mutex vop lock drm/bridge: analogix_dp: add fast link train for eDP drm/rockchip: Only wait for panel ACK on PSR entry drm/bridge: analogix_dp: Don't use fast link training when panel just powered up drm/bridge: analogix_dp: Retry bridge enable when it failed drm/bridge: analogix_dp: Wait for HPD signal before configuring link drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip drm/rockchip: Restore psr->state when enable/disable psr failed drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll drm/bridge: analogix_dp: Fix timeout of video streamclk config drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1 drm/bridge: analogix_dp: Move fast link training detect to set_bridge drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 452 ++++++++++++++++----- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 14 +- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 274 ++++++++----- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h | 7 + drivers/gpu/drm/exynos/exynos_dp.c | 2 +- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 73 ++-- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 61 ++- drivers/gpu/drm/rockchip/rockchip_drm_psr.c | 361 ++++++++++------ drivers/gpu/drm/rockchip/rockchip_drm_psr.h | 7 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 47 ++- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + include/drm/bridge/analogix_dp.h | 5 +- 15 files changed, 915 insertions(+), 395 deletions(-) -- 2.16.1

1 0

[ANNOUNCE] libdrm 2.4.91
by robdclark＠gmail.com 05 Mar '18

05 Mar '18

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Andrey Grodzovsky (1): amdgpu: Fix mistake in initial hole size calculation. Christian König (3): amdgpu: mostly revert "use the high VA range if possible v2" amdgpu: add AMDGPU_VA_RANGE_HIGH amdgpu: fix "add AMDGPU_VA_RANGE_HIGH" Chunming Zhou (1): test/amdgpu: disable bo eviction test by default Eric Engestrom (1): meson: add configuration summary Heiko Becker (1): *-symbol-check: Don't hard-code nm executable Igor Gnatenko (1): meson: do not use cairo/valgrind if disabled Jonathan Gray (1): meson/configure.ac: pthread-stubs not present on OpenBSD Marek Olšák (2): meson: bump the version number RELEASING: mention meson Michel Dänzer (1): tests/amdgpu: Fix misspellings of "suite" Rob Clark (2): freedreno: add interface to get buffer address bump version for release Rob Herring (4): android: revert making handle magic and version members const android: fix mis-named alloc_handle_t android: add helper to convert buffer_handle_t to gralloc_handle_t ptr android: fix gralloc_handle_create() problems Thierry Reding (2): drm/fourcc: Fix fourcc_mod_code() definition drm/tegra: Sanitize format modifiers git tag: libdrm-2.4.91 https://dri.freedesktop.org/libdrm/libdrm-2.4.91.tar.bz2 MD5: 23d87cda92700b710a37d9b8edaa9f54 libdrm-2.4.91.tar.bz2 SHA1: 44e42ce3cd41666e343ba393c73f6f1ad9fe1e74 libdrm-2.4.91.tar.bz2 SHA256: 634a0ed0cc1eff06f48674b1da81aafa661a9f001e7a4f43dde81076886dc800 libdrm-2.4.91.tar.bz2 SHA512: 07578c00c121ba37033db7172590e26d1545f81c242bbce2cfb7fb904bde504822c275d6468e5c5d20360d0046ae73d9b058aa0459ba35eb11927141cc998772 libdrm-2.4.91.tar.bz2 PGP: https://dri.freedesktop.org/libdrm/libdrm-2.4.91.tar.bz2.sig https://dri.freedesktop.org/libdrm/libdrm-2.4.91.tar.gz MD5: d31468ede12851d48f77d9c0eb030411 libdrm-2.4.91.tar.gz SHA1: 8b894394361e83ed6b39487d3172643bb5b0dbb4 libdrm-2.4.91.tar.gz SHA256: c8ea3343d5bfc356550f0b5632403359d050fa09cf05d61e96e73adba0c407a9 libdrm-2.4.91.tar.gz SHA512: 276cb0e0a6542a00ce5b9addc64b322bd25ceabdae2d86dda733bfe5d346bfbfc2a113d630c1a12761d31c7d4bda850bf3c26ed4b141f14e37fc8afbde6dbfc9 libdrm-2.4.91.tar.gz PGP: https://dri.freedesktop.org/libdrm/libdrm-2.4.91.tar.gz.sig -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJanbM5AAoJEBkcm5BVIrBFZqkP/icJEATztkiu8gjpdxqo9wzv zG5c1PPbOeWaUKWToNDS2eMO0bq0d7qecqQ2L3W3zJ89z0jE85u0TCfJo0SAwsot w1QXONMODMBlhWJrOAptrqTNkLsNMTFlbT5aOLxDbZzHs96dHu9agQ+ksYCvPswM uMaBRAPOwHveyA1ZuqRkSnaO6vmQxUT5QZm2Z6kpYJaucYIewmsusWVfCSDmI1ck 0xng1taOa5XNexhlNs6WVxNjzbsmqmYNVMJjcdbJdaCI6MXKTGn3Ond3xjYq03o9 hFemDYLpXUaA6AR2PnN376VzCHsoM80qk4ZLy7YAUbpQ2vgs7N7rM01ovLszjGB/ k4EcTlNYCdPmMlZSTpTXJyDsDRm/5w+cgjtvfmmXYCyi4e5x8gFUx25bzx9DG/tb yc/aSACJ734U+j5rJnHOJz9+dMP/ORhtaZfUr4Ba5H6xAZUROUNXQ06+f5yx+PDw Ctu4k7oS9SMc0fyPFOfVYJnSiHPrNLPJe1YIKIDRTEha7YAX5sF0CTbJDn+JQONV Gcsg4rupza1HZPy3qvzgnRGr1bBi3DNvQ2I8Y97DQB9DSi9jW+a5Uy6PDWsrkIEL lED8+c2h1rmWdztkLTb15+ZQpUcKoeOaBscEql5chceduITOnwZ9ClHdt3WW4Dcg 5T6PkgZVB3eZhRbzvNp1 =LiFX -----END PGP SIGNATURE-----

1 0

None
by Meghana Madhyastha 05 Mar '18

05 Mar '18

linux-spi(a)vger.kernel.org,Noralf Trønnes <noralf(a)tronnes.org>,Sean Paul <seanpaul(a)chromium.org>,kernel(a)martin.sperl.org Cc: Bcc: Subject: Re: [PATCH v2 0/2] Chunk splitting of spi transfers Reply-To: In-Reply-To: <f6dbf3ca-4c1b-90cc-c4af-8889f7407180(a)tronnes.org> On Sun, Mar 04, 2018 at 06:38:42PM +0100, Noralf Trønnes wrote: > > Den 02.03.2018 12.11, skrev Meghana Madhyastha: > >On Sun, Feb 25, 2018 at 02:19:10PM +0100, Lukas Wunner wrote: > >>[cc += linux-rpi-kernel(a)lists.infradead.org] > >> > >>On Sat, Feb 24, 2018 at 06:15:59PM +0000, Meghana Madhyastha wrote: > >>>I've added bcm2835_spi_transfer_one_message in spi-bcm2835. This calls > >>>spi_split_transfers_maxsize to split large chunks for spi dma transfers. > >>>I then removed chunk splitting in the tinydrm spi helper (as now the core > >>>is handling the chunk splitting). However, although the SPI HW should be > >>>able to accomodate up to 65535 bytes for dma transfers, the splitting of > >>>chunks to 65535 bytes results in a dma transfer time out error. However, > >>>when the chunks are split to < 64 bytes it seems to work fine. > >>Hm, that is really odd, how did you test this exactly, what did you > >>use as SPI slave? It contradicts our own experience, we're using > >>Micrel KSZ8851 Ethernet chips as SPI slave on spi0 of a BCM2837 > >>and can send/receive messages via DMA to the tune of several hundred > >>bytes without any issues. In fact, for messages < 96 bytes, DMA is > >>not used at all, so you've probably been using interrupt mode, > >>see the BCM2835_SPI_DMA_MIN_LENGTH macro in spi-bcm2835.c. > >Hi Lukas, > > > >I think you are right. I checked it and its not using the DMA mode which > >is why its working with 64 bytes. > >Noralf, that leaves us back to the > >initial time out problem. I've tried doing the message splitting in > >spi_sync as well as spi_pump_messages. Martin had explained that DMA > >will wait for > >the SPI HW to set the send_more_data line, but the SPI-HW itself will > >stop triggering it when SPI_LEN is 0 causing DMA to wait forever. I > >thought if we split it before itself, the SPI_LEN will not go to zero > >thus preventing this problem, however it didn't work and started > >hanging. So I'm a little uncertain as to how to proceed and debug what > >exactly has caused the time out due to the asynchronous methods. > > I did a quick test and at least this is working: > > int tinydrm_spi_transfer(struct spi_device *spi, u32 speed_hz, > struct spi_transfer *header, u8 bpw, const void *buf, > size_t len) > { > struct spi_transfer tr = { > .bits_per_word = bpw, > .speed_hz = speed_hz, > .tx_buf = buf, > .len = len, > }; > struct spi_message m; > size_t maxsize; > int ret; > > maxsize = tinydrm_spi_max_transfer_size(spi, 0); > > if (drm_debug & DRM_UT_DRIVER) > pr_debug("[drm:%s] bpw=%u, maxsize=%zu, transfers:\n", > __func__, bpw, maxsize); > > spi_message_init(&m); > m.spi = spi; > if (header) > spi_message_add_tail(header, &m); > spi_message_add_tail(&tr, &m); > > ret = spi_split_transfers_maxsize(spi->controller, &m, maxsize, > GFP_KERNEL); > if (ret) > return ret; > > tinydrm_dbg_spi_message(spi, &m); > > return spi_sync(spi, &m); > } > EXPORT_SYMBOL(tinydrm_spi_transfer); > > > Log: > [ 39.015644] [drm:mipi_dbi_fb_dirty [mipi_dbi]] Flushing [FB:36] x1=0, > x2=320, y1=0, y2=240 > > [ 39.018079] [drm:mipi_dbi_typec3_command [mipi_dbi]] cmd=2a, par=00 00 01 > 3f > [ 39.018129] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018152] tr(0): speed=10MHz, bpw=8, len=1, tx_buf=[2a] > [ 39.018231] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018248] tr(0): speed=10MHz, bpw=8, len=4, tx_buf=[00 00 01 3f] > > [ 39.018330] [drm:mipi_dbi_typec3_command [mipi_dbi]] cmd=2b, par=00 00 00 > ef > [ 39.018347] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018362] tr(0): speed=10MHz, bpw=8, len=1, tx_buf=[2b] > [ 39.018396] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018428] tr(0): speed=10MHz, bpw=8, len=4, tx_buf=[00 00 00 ef] > > [ 39.018487] [drm:mipi_dbi_typec3_command [mipi_dbi]] cmd=2c, len=153600 > [ 39.018502] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018517] tr(0): speed=10MHz, bpw=8, len=1, tx_buf=[2c] > [ 39.018565] [drm:tinydrm_spi_transfer] bpw=8, maxsize=65532, transfers: > [ 39.018594] tr(0): speed=48MHz, bpw=8, len=65532, tx_buf=[c6 18 c6 18 > c6 18 c6 18 c6 18 c6 18 c6 18 c6 18 ...] > [ 39.018608] tr(1): speed=48MHz, bpw=8, len=65532, tx_buf=[06 18 06 18 > 06 18 06 18 06 18 06 18 06 18 06 18 ...] > [ 39.018621] tr(2): speed=48MHz, bpw=8, len=22536, tx_buf=[10 82 10 82 > 10 82 10 82 10 82 10 82 18 e3 18 e3 ...] Hi Noralf, Yes this works but splitting in the spi subsystem doesn't seem to work. So this means that spi_split_transfers_maxsize is working. Should I just send in a patch with splitting done here in tinydrm? (I had thought we wanted to avoid splitting in the tinydrm helper). Thanks and regards, Meghana > > Noralf. > >

2 1

[Bug 105262] ttf fonts are invisible
by bugzilla-daemon＠freedesktop.org 05 Mar '18

05 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=105262 Bug ID: 105262 Summary: ttf fonts are invisible Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: public(a)sourcemage.org QA Contact: dri-devel(a)lists.freedesktop.org Created attachment 137622 --> https://bugs.freedesktop.org/attachment.cgi?id=137622&action=edit gvim main window as an example Video: Radeon 4650HD PRO Xorg: 1.19.6 Kernel: 4.15.6 Non-TTF fonts are rendered fine. Also, Firefox and LibreOffice can render TTF in their work areas, but not in gtk interface. Mesa 17.3.5 is unaffected. Attached screenshot illustrates the bug. -- You are receiving this mail because: You are the assignee for the bug.

1 16

[PATCH 1/5] drm/rcar-du: Use drm_mode_get_hv_timing() to populate plane clip rectangle
by Ville Syrjala 05 Mar '18

05 Mar '18

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. No functional changes as the code already uses crtc_state->mode to populate the clip, which is also what drm_mode_get_hv_timing() uses. Once everyone agrees on this we can move the clip handling into drm_atomic_helper_check_plane_state(). Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index 4a3d16cf3ed6..5687a94d4cb1 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c @@ -572,7 +572,7 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, { struct drm_device *dev = plane->dev; struct drm_crtc_state *crtc_state; - struct drm_rect clip; + struct drm_rect clip = {}; int ret; if (!state->crtc) { @@ -589,10 +589,9 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, if (IS_ERR(crtc_state)) return PTR_ERR(crtc_state); - clip.x1 = 0; - clip.y1 = 0; - clip.x2 = crtc_state->mode.hdisplay; - clip.y2 = crtc_state->mode.vdisplay; + if (crtc_state->enable) + drm_mode_get_hv_timing(&crtc_state->mode, + &clip.x2, &clip.y2); ret = drm_atomic_helper_check_plane_state(state, crtc_state, &clip, DRM_PLANE_HELPER_NO_SCALING, -- 2.13.6

10 21

[PATCH v2] drm/vc4: Advertise supported modifiers for planes
by Daniel Stone 05 Mar '18

05 Mar '18

The IN_FORMATS blob allows the kernel to advertise to userspace which format/modifier combinations are supported, per plane. Use this to advertise that we support both T_TILED and linear. v2: - Only advertise T_TILED for RGB (Eric) - Actually turn on allow_fb_modifiers (Eric) Signed-off-by: Daniel Stone <daniels(a)collabora.com> --- drivers/gpu/drm/vc4/vc4_kms.c | 3 ++- drivers/gpu/drm/vc4/vc4_plane.c | 34 +++++++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index 893312e4e2d7..062e7993f61b 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -187,7 +187,7 @@ static struct drm_framebuffer *vc4_fb_create(struct drm_device *dev, /* Make sure that the modifier in AddFB2 is consistent with the tiling * mode set through vc4_set_tiling_ioctl(). */ - if (mode_cmd.modifier[0] != tiling_ioctl) { + if (mode_cmd->modifier[0] != tiling_ioctl) { DRM_DEBUG_KMS("Mismatch between user-provided modifier and " "tiling ioctl\n"); return ERR_PTR(-EINVAL); @@ -224,6 +224,7 @@ int vc4_kms_load(struct drm_device *dev) dev->mode_config.funcs = &vc4_mode_funcs; dev->mode_config.preferred_depth = 24; dev->mode_config.async_page_flip = true; + dev->mode_config.allow_fb_modifiers = true; drm_mode_config_reset(dev); diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 2968b3ebb895..d769803ac3a5 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c @@ -863,6 +863,32 @@ vc4_update_plane(struct drm_plane *plane, ctx); } +static bool vc4_format_mod_supported(struct drm_plane *plane, + uint32_t format, + uint64_t modifier) +{ + /* Support T_TILING for RGB formats only. */ + switch (format) { + case DRM_FORMAT_XRGB8888: + case DRM_FORMAT_ARGB8888: + case DRM_FORMAT_ABGR8888: + case DRM_FORMAT_XBGR8888: + case DRM_FORMAT_RGB565: + case DRM_FORMAT_BGR565: + case DRM_FORMAT_ARGB1555: + case DRM_FORMAT_XRGB1555: + return true; + case DRM_FORMAT_YUV422: + case DRM_FORMAT_YVU422: + case DRM_FORMAT_YUV420: + case DRM_FORMAT_YVU420: + case DRM_FORMAT_NV12: + case DRM_FORMAT_NV16: + default: + return (modifier == DRM_FORMAT_MOD_LINEAR); + } +} + static const struct drm_plane_funcs vc4_plane_funcs = { .update_plane = vc4_update_plane, .disable_plane = drm_atomic_helper_disable_plane, @@ -871,6 +897,7 @@ static const struct drm_plane_funcs vc4_plane_funcs = { .reset = vc4_plane_reset, .atomic_duplicate_state = vc4_plane_duplicate_state, .atomic_destroy_state = vc4_plane_destroy_state, + .format_mod_supported = vc4_format_mod_supported, }; struct drm_plane *vc4_plane_init(struct drm_device *dev, @@ -882,6 +909,11 @@ struct drm_plane *vc4_plane_init(struct drm_device *dev, u32 num_formats = 0; int ret = 0; unsigned i; + static const uint64_t modifiers[] = { + DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED, + DRM_FORMAT_MOD_LINEAR, + DRM_FORMAT_MOD_INVALID + }; vc4_plane = devm_kzalloc(dev->dev, sizeof(*vc4_plane), GFP_KERNEL); @@ -902,7 +934,7 @@ struct drm_plane *vc4_plane_init(struct drm_device *dev, ret = drm_universal_plane_init(dev, plane, 0, &vc4_plane_funcs, formats, num_formats, - NULL, type, NULL); + modifiers, type, NULL); drm_plane_helper_add(plane, &vc4_plane_helper_funcs); -- 2.13.2

2 1

[PATCH] drm: vc4_hdmi: Replace long udelay with usleep_range
by Stefan Wahren 05 Mar '18

05 Mar '18

Since we aren't in atomic context replace this long udelay with a usleep_range. Signed-off-by: Stefan Wahren <stefan.wahren(a)i2se.com> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 984501e..1a6db29 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -681,7 +681,7 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder) drift & ~VC4_HDMI_FIFO_CTL_RECENTER); HDMI_WRITE(VC4_HDMI_FIFO_CTL, drift | VC4_HDMI_FIFO_CTL_RECENTER); - udelay(1000); + usleep_range(1000, 1100); HDMI_WRITE(VC4_HDMI_FIFO_CTL, drift & ~VC4_HDMI_FIFO_CTL_RECENTER); HDMI_WRITE(VC4_HDMI_FIFO_CTL, -- 2.7.4

2 1

[PATCH] drm/bridge/synopsys: dw-hdmi: Fix memleak in __dw_hdmi_remove
by Jeffy Chen 05 Mar '18

05 Mar '18

The platform_device_register_full() will allocate dma_mask for hdmi->audio, so we should free before platform_device_unregister(). Reported by kmemleak: unreferenced object 0xffffffc0ef70ff00 (size 128): comm "kworker/4:1", pid 123, jiffies 4294670080 (age 189.604s) hex dump (first 32 bytes): ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000021946f44>] kmemleak_alloc+0x58/0x8c [<000000009c43890d>] kmem_cache_alloc_memcg_trace+0x18c/0x25c [<000000000e17cd06>] platform_device_register_full+0x64/0x108 [<00000000418a0882>] __dw_hdmi_probe+0xb9c/0xcc0 [<00000000e0b720fd>] dw_hdmi_bind+0x30/0x88 [<000000009af347f6>] dw_hdmi_rockchip_bind+0x260/0x2e8 Signed-off-by: Jeffy Chen <jeffy.chen(a)rock-chips.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index f9802399cc0d..d9afdc59d4f4 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2567,8 +2567,10 @@ __dw_hdmi_probe(struct platform_device *pdev, static void __dw_hdmi_remove(struct dw_hdmi *hdmi) { - if (hdmi->audio && !IS_ERR(hdmi->audio)) + if (hdmi->audio && !IS_ERR(hdmi->audio)) { + kfree(hdmi->audio->dev.dma_mask); platform_device_unregister(hdmi->audio); + } if (!IS_ERR(hdmi->cec)) platform_device_unregister(hdmi->cec); -- 2.11.0

2 1

[PATCH v2 0/3] Add R-Car V3M (R8A77970) support to the R-Car LVDS driver
by Sergei Shtylyov 05 Mar '18

05 Mar '18

Hello! Here's the set of 2 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo plus Laurent Picnahrt's patches creating the R-Car LVDS bridge driver posted recently. The purpose of these patches is to add the R-Car V3M (R8A77970) support to the R-Car LVDS driver. [1/2] DT: display: renesas,lvds: document R8A77970 bindings [2/2] drm: rcar-du: lvds: add R8A77970 support MBR, Sergei

2 3

[Bug 104608] [r600, RV635] Removing radeon module results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258
by bugzilla-daemon＠freedesktop.org 05 Mar '18

05 Mar '18

https://bugs.freedesktop.org/show_bug.cgi?id=104608 Bug ID: 104608 Summary: [r600, RV635] Removing radeon module results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258 Product: DRI Version: unspecified Hardware: All OS: Linux (All) Status: NEW Severity: critical Priority: medium Component: DRM/Radeon Assignee: dri-devel(a)lists.freedesktop.org Reporter: vedran(a)miletic.net (Reported to Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1534012) Description of problem: Removing radeon module using modprobe -r results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258 Version-Release number of selected component (if applicable): 4.14.13-300.fc27.x86_64 How reproducible: Didn't try. Steps to Reproduce: 1. sudo modprobe -r radeon 2. 3. Actual results: [115942.917095] BUG: unable to handle kernel NULL pointer dereference at 0000000000000258 [115942.917144] IP: mutex_lock+0x1d/0x40 [115942.917174] PGD 0 P4D 0 [115942.917207] Oops: 0002 [#1] SMP PTI [115942.917238] Modules linked in: tun ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ip_set nfnetlink ebtable_nat ebtable_broute bridge stp llc ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_raw iptable_security ebtable_filter ebtables ip6table_filter ip6_tables snd_hda_codec_realtek snd_hda_codec_generic sunrpc snd_hda_codec_hdmi ppdev snd_hda_intel iTCO_wdt iTCO_vendor_support snd_hda_codec snd_hda_core coretemp snd_hwdep snd_pcm i2c_i801 snd_timer snd parport_pc lpc_ich soundcore parport asus_atk0110 shpchp acpi_cpufreq xfs libcrc32c ata_generic pata_acpi amdkfd amd_iommu_v2 radeon(-) serio_raw r8169 firewire_ohci i2c_algo_bit firewire_core [115942.917377] pata_marvell mii crc_itu_t drm_kms_helper ttm drm [115942.917417] CPU: 0 PID: 6778 Comm: modprobe Not tainted 4.14.13-300.fc27.x86_64 #1 [115942.917488] Hardware name: System manufacturer System Product Name/P5QL-EM, BIOS 0802 05/12/2010 [115942.917558] task: ffff96b09a4b3c00 task.stack: ffffb500c13b4000 [115942.917610] RIP: 0010:mutex_lock+0x1d/0x40 [115942.917659] RSP: 0018:ffffb500c13b7cf0 EFLAGS: 00010246 [115942.917710] RAX: 0000000000000000 RBX: 0000000000000258 RCX: 000000010020000f [115942.917779] RDX: ffff96b09a4b3c00 RSI: ffff96b095a0ef20 RDI: 0000000000000258 [115942.917849] RBP: ffffb500c13b7cf8 R08: ffff96b093a19a80 R09: 000000010020000f [115942.917918] R10: ffffb500c13b7cc8 R11: 0000000000000000 R12: 0000000000000258 [115942.917987] R13: ffff96b095a0ef20 R14: ffffffffc0625210 R15: ffff96b09a50f100 [115942.918064] FS: 00007faa7058c0c0(0000) GS:ffff96b09fc00000(0000) knlGS:0000000000000000 [115942.918065] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [115942.918065] CR2: 0000000000000258 CR3: 0000000050256000 CR4: 00000000000006f0 [115942.918065] Call Trace: [115942.918065] drm_mode_object_unregister+0x23/0x50 [drm] [115942.918065] drm_framebuffer_unregister_private+0x1a/0x20 [drm] [115942.918065] radeon_fbdev_fini+0x56/0x80 [radeon] [115942.918065] radeon_modeset_fini+0x72/0xb0 [radeon] [115942.918065] radeon_driver_unload_kms+0x43/0x80 [radeon] [115942.918065] drm_dev_unregister+0x43/0xf0 [drm] [115942.918065] drm_put_dev+0x32/0x70 [drm] [115942.918065] radeon_pci_remove+0x15/0x20 [radeon] [115942.918065] pci_device_remove+0x39/0xb0 [115942.918065] device_release_driver_internal+0x158/0x210 [115942.918065] driver_detach+0x38/0x70 [115942.918065] bus_remove_driver+0x59/0xd0 [115942.918065] driver_unregister+0x2c/0x40 [115942.918065] pci_unregister_driver+0x22/0xb0 [115942.918065] radeon_exit+0x15/0x6f [radeon] [115942.918065] SyS_delete_module+0x1a8/0x2b0 [115942.918065] ? exit_to_usermode_loop+0x8f/0xb0 [115942.918065] entry_SYSCALL_64_fastpath+0x20/0x83 [115942.918065] RIP: 0033:0x7faa6fa54077 [115942.918065] RSP: 002b:00007ffd42b9ccc8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0 [115942.918065] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007faa6fa54077 [115942.918065] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 0000559fc225dd98 [115942.918065] RBP: 0000000000000000 R08: 00007ffd42b9bc71 R09: 0000000000000000 [115942.918065] R10: 00007faa6face100 R11: 0000000000000206 R12: 0000559fc225dd30 [115942.918065] R13: 00007ffd42b9bce0 R14: 0000559fc225dd98 R15: 00007ffd42b9e0b0 [115942.918065] Code: ff 5d c3 90 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90 55 48 89 e5 53 48 89 fb e8 ce e2 ff ff 65 48 8b 14 25 00 5c 01 00 31 c0 <f0> 48 0f b1 13 48 85 c0 74 08 48 89 df e8 b1 ff ff ff 5b 5d c3 [115942.918065] RIP: mutex_lock+0x1d/0x40 RSP: ffffb500c13b7cf0 [115942.918065] CR2: 0000000000000258 [115942.920031] ---[ end trace c2bf9af6c48b5a97 ]--- Expected results: No error. Additional info: 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] RV635 [Radeon HD 3650/3750/4570/4580] [1002:9598] -- You are receiving this mail because: You are the assignee for the bug.

1 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2018