dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH 0/2] drm/amdgpu: Clean-up TTM BO ref-counting interface
by Thomas Zimmermann 31 Jul '18

31 Jul '18

This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. v2: * use prefix drm/amdgpu Thomas Zimmermann (2): drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.18.0

2 3

[PATCH 1/2] drm/amd: Replace ttm_bo_reference with ttm_bo_get
by Thomas Zimmermann 31 Jul '18

31 Jul '18

The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index b12526ce1a9d..f54d30186fd6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c @@ -823,7 +823,7 @@ struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo) if (bo == NULL) return NULL; - ttm_bo_reference(&bo->tbo); + ttm_bo_get(&bo->tbo); return bo; } -- 2.18.0

2 2

[PATCH] drm/mgag200: Replace ttm_bo_unref with ttm_bo_put
by Thomas Zimmermann 31 Jul '18

31 Jul '18

The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer. The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/mgag200/mgag200_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 780f983b0294..880047000ccf 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c @@ -33,7 +33,7 @@ int mgag200_framebuffer_init(struct drm_device *dev, struct drm_gem_object *obj) { int ret; - + drm_helper_mode_fill_fb_struct(dev, &gfb->base, mode_cmd); gfb->obj = obj; ret = drm_framebuffer_init(dev, &gfb->base, &mga_fb_funcs); @@ -333,7 +333,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo) return; tbo = &((*bo)->bo); - ttm_bo_unref(&tbo); + ttm_bo_put(tbo); *bo = NULL; } -- 2.18.0

1 0

[PATCH 0/2] Clean-up TTM BO ref-counting interface
by Thomas Zimmermann 31 Jul '18

31 Jul '18

This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): Replace ttm_bo_reference with ttm_bo_get drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++++------- drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 11 +++++++---- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 7 +++---- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 24 ++++++++++++++++-------- drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 21 ++++++++++++++------- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 9 ++++++--- 6 files changed, 50 insertions(+), 33 deletions(-) -- 2.18.0

1 2

[PATCH 0/2] Clean-up TTM BOref-counting interface
by Thomas Zimmermann 31 Jul '18

31 Jul '18

This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): drm/virtio: Replace ttm_bo_reference with ttm_bo_get drm/virtio: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/virtio/virtgpu_drv.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.18.0

1 2

[PATCH 1/2] drm/radeon: Replace ttm_bo_reference with ttm_bo_get
by Thomas Zimmermann 31 Jul '18

31 Jul '18

The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/radeon/radeon_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index edbb4cd519fd..1a9d4f547024 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -307,7 +307,7 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo) if (bo == NULL) return NULL; - ttm_bo_reference(&bo->tbo); + ttm_bo_get(&bo->tbo); return bo; } -- 2.18.0

1 1

[PATCH 1/2] drm/nouveau: Replace ttm_bo_reference with ttm_bo_get
by Thomas Zimmermann 31 Jul '18

31 Jul '18

The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/nouveau/nouveau_bo.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.h b/drivers/gpu/drm/nouveau/nouveau_bo.h index 73c48440d4d7..3920134cb132 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.h +++ b/drivers/gpu/drm/nouveau/nouveau_bo.h @@ -61,7 +61,12 @@ nouveau_bo_ref(struct nouveau_bo *ref, struct nouveau_bo **pnvbo) return -EINVAL; prev = *pnvbo; - *pnvbo = ref ? nouveau_bo(ttm_bo_reference(&ref->bo)) : NULL; + if (ref) { + ttm_bo_get(&ref->bo); + *pnvbo = nouveau_bo(&ref->bo); + } else { + *pnvbo = NULL; + } if (prev) { struct ttm_buffer_object *bo = &prev->bo; -- 2.18.0

1 1

[PATCH] drm/ast: Replace ttm_bo_unref with ttm_bo_put
by Thomas Zimmermann 31 Jul '18

31 Jul '18

The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer. The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/ast/ast_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index dac355812adc..ff83cd56e6a8 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -644,7 +644,7 @@ static void ast_bo_unref(struct ast_bo **bo) return; tbo = &((*bo)->bo); - ttm_bo_unref(&tbo); + ttm_bo_put(tbo); *bo = NULL; } -- 2.18.0

1 0

[PATCH v2] drm/nouveau: Fix potential memory access error in nouveau_debugfs_pstate_get()
by Lyude Paul 31 Jul '18

31 Jul '18

nouveau_debugfs(drm) will never be NULL, because we're taking the value of the potentially null device pointer and adding to it so it isn't 0x0. So, check if drm is NULL instead. Signed-off-by: Lyude Paul <lyude(a)redhat.com> Cc: Karol Herbst <karolherbst(a)gmail.com> --- Forgot to hit :w before committing, whoops! drivers/gpu/drm/nouveau/nouveau_debugfs.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c index 963a4dba8213..8e758c4cb4fd 100644 --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c @@ -50,13 +50,15 @@ static int nouveau_debugfs_pstate_get(struct seq_file *m, void *data) { struct drm_device *drm = m->private; - struct nouveau_debugfs *debugfs = nouveau_debugfs(drm); - struct nvif_object *ctrl = &debugfs->ctrl; + struct nouveau_debugfs *debugfs; + struct nvif_object *ctrl; struct nvif_control_pstate_info_v0 info = {}; int ret, i; - if (!debugfs) + if (!drm) return -ENODEV; + debugfs = nouveau_debugfs(drm); + ctrl = &debugfs->ctrl; ret = nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_INFO, &info, sizeof(info)); if (ret) -- 2.17.1

1 0

[PATCH v3.1 00/10] arm64: allwinner: Add A64 DE2 HDMI support
by Icenowy Zheng 30 Jul '18

30 Jul '18

Allwinner A64 has display engine pipeline like other Allwinner SOC's A83T/H3/H5. A64 behaviour similar to Allwinner A83T where Mixer0 => TCON0 => LVDS/RGB/MIPI-DSI Mixer1 => TCON1 => HDMI as per Display System Block Diagram from the A64 user manual. This is third patch-set followed with previous RFC[1], first and second series[2][3] and merely concentrated on HDMI pipeline through TCON1 and rest will add eventually. I just rebased and slightly re-integrated the patchset according to the requirments of the maintainer, and added the mixer0->tcon0 pipeline. The further maintainship of the patchset still needs to be discussed between I and Jagan. --Icenowy Icenowy Zheng (1): dt-bindings: sun4i-drm: add HDMI VCC supply property for sun8i-dw-hdmi Jagan Teki (8): clk: sunxi-ng: a64: Add minimal rate for video PLLs dt-bindings: display: Add compatible for A64 DE2 display pipeline drm/sun4i: Add support for A64 mixers drm/sun4i: Add support for A64 display engine dt-bindings: display: Add compatible for A64 HDMI dt-bindings: clock: sun50i-a64-ccu: Add PLL_VIDEO[0-1] macros arm64: dts: allwinner: a64: Add display pipeline arm64: dts: allwinner: a64: Enable HDMI output on A64 boards w/ HDMI Jernej Skrabec (1): drm/sun4i: Add support for HDMI voltage regulator .../bindings/display/sunxi/sun4i-drm.txt | 9 + .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 34 ++++ .../dts/allwinner/sun50i-a64-nanopi-a64.dts | 34 ++++ .../dts/allwinner/sun50i-a64-olinuxino.dts | 34 ++++ .../dts/allwinner/sun50i-a64-orangepi-win.dts | 34 ++++ .../boot/dts/allwinner/sun50i-a64-pine64.dts | 34 ++++ .../allwinner/sun50i-a64-sopine-baseboard.dts | 34 ++++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 169 ++++++++++++++++++ drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 46 ++--- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 17 +- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 2 + drivers/gpu/drm/sun4i/sun8i_mixer.c | 24 +++ include/dt-bindings/clock/sun50i-a64-ccu.h | 2 + 14 files changed, 451 insertions(+), 23 deletions(-) -- 2.18.0

5 28

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018