dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[PATCH] drm/scheduler: only kill entity if last user is killed
by Christian König 30 Jul '18

30 Jul '18

Note which task is using the entity and only kill it if the last user of the entity is killed. This should prevent problems when entities are leaked to child processes. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 +++++- include/drm/gpu_scheduler.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 3f2fc5e8242a..f563e4fbb4b6 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -275,6 +275,7 @@ static void drm_sched_entity_kill_jobs_cb(struct dma_fence *f, long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout) { struct drm_gpu_scheduler *sched; + struct task_struct *last_user; long ret = timeout; sched = entity->rq->sched; @@ -295,7 +296,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout) /* For killed process disable any more IBs enqueue right now */ - if ((current->flags & PF_EXITING) && (current->exit_code == SIGKILL)) + last_user = cmpxchg(&entity->last_user, current->group_leader, NULL); + if ((!last_user || last_user == current->group_leader) && + (current->flags & PF_EXITING) && (current->exit_code == SIGKILL)) drm_sched_entity_set_rq(entity, NULL); return ret; @@ -541,6 +544,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job, trace_drm_sched_job(sched_job, entity); + WRITE_ONCE(entity->last_user, current->group_leader); first = spsc_queue_push(&entity->job_queue, &sched_job->queue_node); /* first job wakes up scheduler */ diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 091b9afcd184..64016446a103 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -85,6 +85,7 @@ struct drm_sched_entity { struct dma_fence_cb cb; atomic_t *guilty; struct dma_fence *last_scheduled; + struct task_struct *last_user; }; /** -- 2.14.1

3 2

[Bug 105308] X log ballooning in size with "drmmode_wait_vblank failed for scanout update" and "get vblank counter failed"
by bugzilla-daemon＠freedesktop.org 30 Jul '18

30 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=105308 Bug ID: 105308 Summary: X log ballooning in size with "drmmode_wait_vblank failed for scanout update" and "get vblank counter failed" Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: rah(a)settrans.net Created attachment 137717 --> https://bugs.freedesktop.org/attachment.cgi?id=137717&action=edit First 3900 lines of Xorg log Hi, My X log is on occassion filling up my hard disk, reaching a size of 18G with mostly repeats of two lines. The X server is working and running fine; I'm typing this on it now. The first indication that there is a problem is seeing "No space left on device". It looks like the woes begin with this line: [ 668.860] (WW) AMDGPU(0): flip queue failed in amdgpu_scanout_flip: Invalid argument, TearFree inactive until next modeset The kernel also reported this although I've no idea when in relation to other events: [57903.995504] [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* amdgpu_cs_list_validate(validated) failed. [57903.995539] [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed to process the buffer list -22! [58014.990950] [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* amdgpu_cs_list_validate(validated) failed. [58014.990998] [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed to process the buffer list -22! rah@lotus:~/store-f$ ls -lh Xorg.0.log -rw-r--r-- 1 rah rah 18G Mar 1 09:52 Xorg.0.log rah@lotus:~/store-f$ grep "drmmode_wait_vblank failed for scanout update" Xorg.0.log | head -n 1 [ 668.860] (WW) AMDGPU(0): drmmode_wait_vblank failed for scanout update: Invalid argument rah@lotus:~/store-f$ grep "get vblank counter failed" Xorg.0.log | head -n 1 [ 10749.146] (WW) AMDGPU(0): get vblank counter failed: Invalid argument rah@lotus:~/store-f$ wc -l Xorg.0.log 203212490 Xorg.0.log rah@lotus:~/store-f$ egrep -vc "(drmmode_wait_vblank failed for scanout update|get vblank counter failed)" Xorg.0.log 1509 rah@lotus:~/store-f$ grep -c "drmmode_wait_vblank failed for scanout update" Xorg.0.log 200689290 rah@lotus:~/store-f$ grep -c "get vblank counter failed" Xorg.0.log 2521692 I'll attach the first 3900 lines of the Xorg log and the kernel log. Thanks, Bob -- You are receiving this mail because: You are the assignee for the bug.

1 16

[PATCH] drm/mediatek: Replace drm_dev_unref with drm_dev_put
by Thomas Zimmermann 30 Jul '18

30 Jul '18

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a2ca90fc403c..5d024a154e1a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -341,7 +341,7 @@ static int mtk_drm_bind(struct device *dev) err_deinit: mtk_drm_kms_deinit(drm); err_free: - drm_dev_unref(drm); + drm_dev_put(drm); return ret; } @@ -350,7 +350,7 @@ static void mtk_drm_unbind(struct device *dev) struct mtk_drm_private *private = dev_get_drvdata(dev); drm_dev_unregister(private->drm); - drm_dev_unref(private->drm); + drm_dev_put(private->drm); private->drm = NULL; } @@ -504,7 +504,7 @@ static int mtk_drm_remove(struct platform_device *pdev) drm_dev_unregister(drm); mtk_drm_kms_deinit(drm); - drm_dev_unref(drm); + drm_dev_put(drm); component_master_del(&pdev->dev, &mtk_drm_ops); pm_runtime_disable(&pdev->dev); -- 2.18.0

3 2

[PATCH] drm/kms/plane: Avoiding redundant checks in case of EDEADLK retries
by Satendra Singh Thakur 30 Jul '18

30 Jul '18

1. Currently, if modeset_lock is re-tried many times in case of EDEADLK error, then this will be the code flow retry: ret = drm_modeset_lock(); if (ret)-->this is true goto out; out: if (fb) if (plane->old_fb) if (ret == -EDEADLK) goto retry; It can be observed that checks on fb, old_fb are redundant in retry-case. If we keep if (ret == -EDEADLK) right after the out label, that will avoid redundant checks. It won't affect normal scenario (non-retry case). 2. Moved NULL assignment inside if statement related to NULL check Signed-off-by: Satendra Singh Thakur <satendra.t(a)samsung.com> --- drivers/gpu/drm/drm_plane.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 0350544..ed42cd4 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -658,9 +658,10 @@ static int __setplane_internal(struct drm_plane *plane, } out: - if (plane->old_fb) + if (plane->old_fb) { drm_framebuffer_put(plane->old_fb); - plane->old_fb = NULL; + plane->old_fb = NULL; + } return ret; } @@ -1097,17 +1098,17 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, } out: - if (fb) - drm_framebuffer_put(fb); - if (plane->old_fb) - drm_framebuffer_put(plane->old_fb); - plane->old_fb = NULL; - if (ret == -EDEADLK) { ret = drm_modeset_backoff(&ctx); if (!ret) goto retry; } + if (fb) + drm_framebuffer_put(fb); + if (plane->old_fb) { + drm_framebuffer_put(plane->old_fb); + plane->old_fb = NULL; + } drm_modeset_drop_locks(&ctx); drm_modeset_acquire_fini(&ctx); -- 2.7.4

2 1

[PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()
by Souptick Joarder 30 Jul '18

30 Jul '18

convert drm_atomic_helper_suspend/resume() to use drm_mode_config_helper_suspend/resume(). Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com> Signed-off-by: Ajit Negi <ajitn.linux(a)gmail.com> --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index a2ca90f..1fcda2de 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -520,29 +520,24 @@ static int mtk_drm_sys_suspend(struct device *dev) { struct mtk_drm_private *private = dev_get_drvdata(dev); struct drm_device *drm = private->drm; + int ret; - drm_kms_helper_poll_disable(drm); - - private->suspend_state = drm_atomic_helper_suspend(drm); - if (IS_ERR(private->suspend_state)) { - drm_kms_helper_poll_enable(drm); - return PTR_ERR(private->suspend_state); - } - + ret = drm_mode_config_helper_suspend(drm); DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n"); - return 0; + + return ret; } static int mtk_drm_sys_resume(struct device *dev) { struct mtk_drm_private *private = dev_get_drvdata(dev); struct drm_device *drm = private->drm; + int ret; - drm_atomic_helper_resume(drm, private->suspend_state); - drm_kms_helper_poll_enable(drm); - + ret = drm_mode_config_helper_resume(drm); DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n"); - return 0; + + return ret; } #endif -- 1.9.1

2 3

[PATCH v2] gpu: drm: virtio: code cleanup
by Souptick Joarder 30 Jul '18

30 Jul '18

The fault handler code is commented since v4.2. If there is no plan to enable the fault handler code in future, we can remove this dead code. Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com> --- v2: corrected subject line drivers/gpu/drm/virtio/virtgpu_ttm.c | 36 +----------------------------------- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c index 11f8ae5..b6f021c 100644 --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c @@ -106,29 +106,6 @@ static void virtio_gpu_ttm_global_fini(struct virtio_gpu_device *vgdev) } } -#if 0 -/* - * Hmm, seems to not do anything useful. Leftover debug hack? - * Something like printing pagefaults to kernel log? - */ -static struct vm_operations_struct virtio_gpu_ttm_vm_ops; -static const struct vm_operations_struct *ttm_vm_ops; - -static int virtio_gpu_ttm_fault(struct vm_fault *vmf) -{ - struct ttm_buffer_object *bo; - struct virtio_gpu_device *vgdev; - int r; - - bo = (struct ttm_buffer_object *)vmf->vma->vm_private_data; - if (bo == NULL) - return VM_FAULT_NOPAGE; - vgdev = virtio_gpu_get_vgdev(bo->bdev); - r = ttm_vm_ops->fault(vmf); - return r; -} -#endif - int virtio_gpu_mmap(struct file *filp, struct vm_area_struct *vma) { struct drm_file *file_priv; @@ -143,19 +120,8 @@ int virtio_gpu_mmap(struct file *filp, struct vm_area_struct *vma) return -EINVAL; } r = ttm_bo_mmap(filp, vma, &vgdev->mman.bdev); -#if 0 - if (unlikely(r != 0)) - return r; - if (unlikely(ttm_vm_ops == NULL)) { - ttm_vm_ops = vma->vm_ops; - virtio_gpu_ttm_vm_ops = *ttm_vm_ops; - virtio_gpu_ttm_vm_ops.fault = &virtio_gpu_ttm_fault; - } - vma->vm_ops = &virtio_gpu_ttm_vm_ops; - return 0; -#else + return r; -#endif } static int virtio_gpu_invalidate_caches(struct ttm_bo_device *bdev, -- 1.9.1

1 3

[PATCH] drm/panel: simple: Support simple VGA panels
by Linus Walleij 29 Jul '18

29 Jul '18

The need to support some straight-forward VGA panels that are not adhering to any standard like DPI arise in the ARM RTSM VE Real-Time Systems Model Virtual Executive. This emulator (which is not QEMU) does not model any bridge or panel other than displaying whatever the user defines that they have. Currently a fake "DPI panel" is used for this with the old FBDEV driver, but this is wrong as it is not conforming to any MIPI DPI standards. However the resolution chosen there is standard VGA, and we can cover this with the simple panel by simply adding the most common VGA resolutions as a kind of "simple panel". In difference from other cases where "simple panel" might be hiding something more complex (such as a panel driver or bridge) this case is actually applicable, since we are running inside a simulation with no real hardware on the output. Cc: devicetree(a)vger.kernel.org Cc: Sudeep Holla <sudeep.holla(a)arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi(a)arm.com> Cc: Liviu Dudau <liviu.dudau(a)arm.com> Cc: Robin Murphy <robin.murphy(a)arm.com> Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- .../display/panel/video-graphics-array.txt | 21 ++++++ drivers/gpu/drm/panel/panel-simple.c | 66 +++++++++++++++++++ 2 files changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/video-graphics-array.txt diff --git a/Documentation/devicetree/bindings/display/panel/video-graphics-array.txt b/Documentation/devicetree/bindings/display/panel/video-graphics-array.txt new file mode 100644 index 000000000000..193d24ebe052 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/video-graphics-array.txt @@ -0,0 +1,21 @@ +Video Graphics Array + +This binding is for simple panels using the standardized VGA resolutions +defined by de facto standards beginning with the IBM PS/2 in 1987. + +Required properties: +- compatible: should be "video-graphics-array" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. + +Example: + +panel { + compatible = "video-graphics-array"; + port { + vga_panel_in: endpoint { + remote-endpoint = <&foo>; + }; + }; +}; diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index cbf1ab404ee7..db4db5a3f75e 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2069,6 +2069,69 @@ static const struct panel_desc winstar_wf35ltiacd = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, }; +static const struct drm_display_mode video_graphics_array_modes[] = { + { + /* + * This is the most standardized "vanilla" VGA mode there is: + * 640x480 @ 60 Hz + */ + .clock = 27175, + .hdisplay = 640, + .hsync_start = 640 + 16, + .hsync_end = 640 + 16 + 96, + .htotal = 640 + 16 + 96 + 48, + .vdisplay = 480, + .vsync_start = 480 + 10, + .vsync_end = 480 + 10 + 2, + .vtotal = 480 + 10 + 2 + 33, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, + }, + { + /* SVGA 800x600 @60 Hz */ + .clock = 40000, + .hdisplay = 800, + .hsync_start = 800 + 40, + .hsync_end = 800 + 40 + 128, + .htotal = 800 + 40 + 128 + 88, + .vdisplay = 600, + .vsync_start = 600 + 1, + .vsync_end = 600 + 1 + 4, + .vtotal = 600 + 1 + 4 + 23, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, + }, + { + /* XGA 1024x768 @60 Hz */ + .clock = 65000, + .hdisplay = 1024, + .hsync_start = 1024 + 24, + .hsync_end = 1024 + 24 + 136, + .htotal = 1024 + 24 + 136 + 160, + .vdisplay = 768, + .vsync_start = 768 + 3, + .vsync_end = 768 + 3 + 6, + .vtotal = 768 + 3 + 6 + 29, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, + }, +}; + +static const struct panel_desc video_graphics_array = { + .modes = video_graphics_array_modes, + .num_modes = ARRAY_SIZE(video_graphics_array_modes), + .bpc = 8, + /* + * Some typical 4:3 aspect ratio VGA monitor surely has these dimensions + * of 40x30 mm. + */ + .size = { + .width = 400, + .height = 300, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am-480272h3tmqw-t01h", @@ -2286,6 +2349,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "winstar,wf35ltiacd", .data = &winstar_wf35ltiacd, + }, { + .compatible = "video-graphics-array", + .data = &video_graphics_array, }, { /* sentinel */ } -- 2.17.0

4 6

[Bug 200677] New: 4.17.10 stable patch causes AMDGPU driver soft-lockup when using Dolphin Emulator with Vulkan driver
by bugzilla-daemon＠bugzilla.kernel.org 29 Jul '18

29 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=200677 Bug ID: 200677 Summary: 4.17.10 stable patch causes AMDGPU driver soft-lockup when using Dolphin Emulator with Vulkan driver Product: Drivers Version: 2.5 Kernel Version: 4.17.10 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: kyle.devir(a)mykolab.com Regression: No Created attachment 277587 --> https://bugzilla.kernel.org/attachment.cgi?id=277587&action=edit Kernel error output ~ "GPU fault detected" Commit in question: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id… Attached error output from journalctl and commit in question match nicely. Soft lockup didn't happen with previous .9 stable patch. I could still REISUB with SysRQ, so that's good. I first tried bisecting Dolphin, thinking there was an issue there. -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[pull] drm/msm: msm-next for 4.19
by Rob Clark 28 Jul '18

28 Jul '18

Hi Dave, A bit larger this time around, due to introduction of "dpu1" support for the display controller in sdm845 and beyond. This has been on list and undergoing refactoring since Feb (going from ~110kloc to ~30kloc), and all my review complaints have been addressed, so I'd be happy to see this upstream so further feature work can procede on top of upstream. Also includes the gpu coredump support, which should be useful for debugging gpu crashes. And various other misc fixes and such. The following changes since commit 500775074f88d9cf5416bed2ca19592812d62c41: Merge branch 'drm-next-4.19' of git://people.freedesktop.org/~agd5f/linux into drm-next (2018-07-20 14:54:31 +1000) are available in the Git repository at: git://people.freedesktop.org/~robclark/linux drm-msm-next-2018-07-28 for you to fetch changes up to 1062d4d87e6a80e55732e71c3416986426335733: dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU (2018-07-27 14:48:06 -0400) ---------------------------------------------------------------- Abhinav Kumar (2): drm/msm/dsi: set encoder mode for DRM bridge explicitly drm/msm: higher values of pclk can exceed 32 bits when multiplied by a factor Arnd Bergmann (2): drm/msm/gpu: avoid deprecated do_gettimeofday drm/msm: mark PM functions as __maybe_unused Carsten Behling (1): drm/msm/mdp5: negative x/y in cursor move Chandan Uddaraju (2): drm/msm/dsi: adjust dsi timing for dual dsi mode drm/msm/dsi: Use one connector for dual DSI mode Daniel Mack (2): drm/msm: call drm_atomic_helper_suspend() and drm_atomic_helper_resume() drm/msm/adreno: Add power management functions for system sleep Gustavo A. R. Silva (1): drm/msm: Replace PTR_RET with PTR_ERR_OR_ZERO Jeykumar Sankaran (10): drm: add msm compressed format modifiers drm/msm: enable zpos normalization drm/msm: #define MDP version numbers drm/msm: Use labels for unwinding in the error path drm/msm: #define MAX_<OBJECT> in msm_drv.h drm/msm: Add .commit() callback to msm_kms functions drm/msm: Add pm_suspend/resume callbacks to msm_kms drm/msm: Add SDM845 DPU support dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU Jordan Crouse (19): drm/msm/gpu: Increase the pm runtime autosuspend for 5xx include: Move ascii85 functions from i915 to linux/ascii85.h drm: drm_printer: Add printer for devcoredump drm: Add drm_puts() to complement drm_printf() drm: Add a -puts() function for the seq_file printer drm: Add puts callback for the coredump printer drm/msm/gpu: Capture the state of the GPU drm/msm/gpu: Convert the GPU show function to use the GPU state drm/msm/gpu: Rearrange the code that collects the task during a hang drm/msm/gpu: Capture the GPU state on a GPU hang drm/msm/adreno: Convert the show/crash file format drm/msm/adreno: Add ringbuffer data to the GPU state drm/msm/adreno: Add a5xx specific registers for the GPU state drm/msm/gpu: Add the buffer objects from the submit to the crash dump drm/msm/disp/dpu: Remove unused code from drm_encoder.c drm/msm/disp/dpu: Remove unused code from drm_crtc.c drm/msm/disp/dpu: Remove dpu_kms_utils drm/msm/disp/dpu: Remove unused functions from dpu_formats.c drm/msm/disp/dpu: Mark a handful of functions as static Rajesh Yadav (3): drm/msm/dsi: initialize postdiv_lock before use for 10nm pll drm/msm/mdp5: subclass msm_mdss for mdp5 drm/msm: rework vblank event handling in dpu_crtc Rob Clark (1): drm/msm/mdp5: fix missing CTL flush Sean Paul (5): drm/msm: Move wait_for_vblanks into mdp complete_commit() hooks drm/msm: Clean up dangling atomic_wq drm/msm: dpu: Use 'vsync' instead of 'vsync_clk' in cmdmode encoder drm/msm: dpu: Use clock-names instead of assigned-clock-names drm/msm: dsi: Handle dual-channel for 6G as well Sibi Sankar (3): drm/msm/dsi: add dsi host helper functions support drm/msm/dsi: add implementation for helper functions drm/msm/dsi: replace version checks with helper functions vkorjani (1): drm: Add support for pps and compression mode command packet zhong jiang (1): drm/msm/dpu: fix mismatch in function argument. .../devicetree/bindings/display/msm/dpu.txt | 131 + .../devicetree/bindings/display/msm/dsi.txt | 16 + Documentation/gpu/msm-crash-dump.rst | 96 + drivers/gpu/drm/drm_mipi_dsi.c | 2 + drivers/gpu/drm/drm_print.c | 111 + drivers/gpu/drm/i915/i915_gpu_error.c | 34 +- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile | 31 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 30 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 22 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 242 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 187 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 11 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 479 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 153 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 637 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 133 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2138 +++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 423 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 2393 +++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h | 103 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2498 ++++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 177 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 430 ++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 905 +++++++ .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 922 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 1173 +++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 88 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 155 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h | 53 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 511 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 804 +++++++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 168 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c | 323 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h | 139 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 540 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 218 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 1183 +++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 257 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 349 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 261 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 122 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 465 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 250 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 136 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 753 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 424 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 398 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h | 202 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c | 368 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h | 348 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 275 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 128 + drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h | 56 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 203 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 57 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c | 66 + drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h | 59 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1345 +++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 290 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 245 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1963 +++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 175 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 249 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h | 225 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 1079 +++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 199 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 1007 ++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 384 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h | 94 + drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h | 1376 +++++++++++ drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 51 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 12 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 + drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 154 +- drivers/gpu/drm/msm/dsi/dsi.c | 3 + drivers/gpu/drm/msm/dsi/dsi.h | 23 +- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 56 +- drivers/gpu/drm/msm/dsi/dsi_cfg.h | 12 + drivers/gpu/drm/msm/dsi/dsi_host.c | 429 ++-- drivers/gpu/drm/msm/dsi/dsi_manager.c | 125 +- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 2 + drivers/gpu/drm/msm/msm_atomic.c | 7 +- drivers/gpu/drm/msm/msm_debugfs.c | 93 +- drivers/gpu/drm/msm/msm_drv.c | 230 +- drivers/gpu/drm/msm/msm_drv.h | 97 +- drivers/gpu/drm/msm/msm_gpu.c | 145 +- drivers/gpu/drm/msm/msm_gpu.h | 68 +- drivers/gpu/drm/msm/msm_kms.h | 29 +- include/drm/drm_print.h | 71 + include/linux/ascii85.h | 38 + include/uapi/drm/drm_fourcc.h | 13 + include/video/mipi_display.h | 3 + 96 files changed, 32751 insertions(+), 524 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt create mode 100644 Documentation/gpu/msm-crash-dump.rst create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c create mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h create mode 100644 drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h create mode 100644 include/linux/ascii85.h

1 0

[PATCH] drm/vkms: Fix connector leak at the module removal
by Rodrigo Siqueira 28 Jul '18

28 Jul '18

Currently, vkms shows an error message if the following steps occur: (1) load vkms, (2) perform any specific operation in the vkms (e.g., run an IGT test), and (3) unload the module. The following error message emerges: [drm:drm_mode_config_cleanup [drm]] *ERROR* connector Virtual-1 leaked! This commit fixes this error by calling drm_atomic_helper_shutdown() before drm_mode_config_cleanup, which turns off the whole display pipeline and remove a reference related to any connector. Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo(a)gmail.com> --- drivers/gpu/drm/vkms/vkms_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 37aa2ef33b21..6e728b825259 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -44,6 +44,7 @@ static void vkms_release(struct drm_device *dev) struct vkms_device *vkms = container_of(dev, struct vkms_device, drm); platform_device_unregister(vkms->platform); + drm_atomic_helper_shutdown(&vkms->drm); drm_mode_config_cleanup(&vkms->drm); drm_dev_fini(&vkms->drm); } -- 2.18.0

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018