dri-devel July 2018

dri-devel@lists.freedesktop.org

277 participants
1883 discussions

[Bug 107402] [Intel GFX CI][BAT] igt@amdgpu_amd_basic@userptr - incomplete - general protection fault: 0000 [#1] PREEMPT SMP PTI, __mmu_notifier_release
by bugzilla-daemon＠freedesktop.org 27 Jul '18

27 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=107402 --- Comment #6 from Martin Peres <martin.peres(a)free.fr> --- Our KASAN runs do not currently run AMDGPU tests. This should be fixed by the next run (triggered manually). -- You are receiving this mail because: You are the assignee for the bug.

1 0

27 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=107402 --- Comment #5 from Chris Wilson <chris(a)chris-wilson.co.uk> --- RBX: 6b6b6b6b6b6b6b6b == POISON_FREE -- You are receiving this mail because: You are the assignee for the bug.

1 0

27 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=107402 --- Comment #4 from Michel Dänzer <michel(a)daenzer.net> --- (In reply to Chris Wilson from comment #2) > Use after free by amdgpu.ko How do you know it's a use-after-free? Can you provide more information about that, e.g. from KASAN? -- You are receiving this mail because: You are the assignee for the bug.

1 0

27 Jul '18

https://bugs.freedesktop.org/show_bug.cgi?id=107402 Martin Peres <martin.peres(a)free.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|DRM/Intel |DRM/AMDgpu Summary|[CI][BAT] |[Intel GFX CI][BAT] |igt@amdgpu_amd_basic@userpt |igt@amdgpu_amd_basic@userpt |r - incomplete - general |r - incomplete - general |protection fault: 0000 [#1] |protection fault: 0000 [#1] |PREEMPT SMP PTI, |PREEMPT SMP PTI, |__mmu_notifier_release |__mmu_notifier_release Assignee|intel-gfx-bugs(a)lists.freede |dri-devel(a)lists.freedesktop |sktop.org |.org QA Contact|intel-gfx-bugs(a)lists.freede | |sktop.org | --- Comment #3 from Martin Peres <martin.peres(a)free.fr> --- Thanks Chris, moving the failure to AMDGpu! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/kms/atomic: Used existing func for checking fb geometry
by Satendra Singh Thakur 27 Jul '18

27 Jul '18

1.In the func drm_atomic_plane_check, the fb geometry checking code can be replaced by func drm_framebuffer_check_src_coords, this will remove several redundant lines of code. 2. Currently, in the func drm_atomic_plane_check; there are 3 if statements in the beginning with total 5 conditions. these conditions are crtc is NULL but fb is non-NULL if (state->crtc && !state->fb) crtc is non-NULL but fb is NULL if (state->fb && !state->crtc) crtc is NULL (and fb is also NULL) if (!state->crtc) The same code can be re-written using 2 if statements and 4 conditions. first we check whether crtc and fb both are NULL if (!state->crtc && !state->fb) then we check either crtc or fb is NULL if (!state->crtc || !state->fb) Signed-off-by: Satendra Singh Thakur <satendra.t(a)samsung.com> --- drivers/gpu/drm/drm_atomic.c | 37 +++++++++---------------------------- 1 file changed, 9 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 895741e..1cddab8 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -909,22 +909,16 @@ plane_switching_crtc(struct drm_atomic_state *state, static int drm_atomic_plane_check(struct drm_plane *plane, struct drm_plane_state *state) { - unsigned int fb_width, fb_height; int ret; - /* either *both* CRTC and FB must be set, or neither */ - if (state->crtc && !state->fb) { - DRM_DEBUG_ATOMIC("CRTC set but no FB\n"); - return -EINVAL; - } else if (state->fb && !state->crtc) { - DRM_DEBUG_ATOMIC("FB set but no CRTC\n"); - return -EINVAL; - } - /* if disabled, we don't care about the rest of the state: */ - if (!state->crtc) + if (!state->crtc && !state->fb) return 0; - + /* both CRTC and FB must be set*/ + if (!state->crtc || !state->fb) { + DRM_DEBUG_ATOMIC("Either no CRTC or no FB\n"); + return -EINVAL; + } /* Check whether this plane is usable on this CRTC */ if (!(plane->possible_crtcs & drm_crtc_mask(state->crtc))) { DRM_DEBUG_ATOMIC("Invalid crtc for plane\n"); @@ -954,24 +948,11 @@ static int drm_atomic_plane_check(struct drm_plane *plane, return -ERANGE; } - fb_width = state->fb->width << 16; - fb_height = state->fb->height << 16; - /* Make sure source coordinates are inside the fb. */ - if (state->src_w > fb_width || - state->src_x > fb_width - state->src_w || - state->src_h > fb_height || - state->src_y > fb_height - state->src_h) { - DRM_DEBUG_ATOMIC("Invalid source coordinates " - "%u.%06ux%u.%06u+%u.%06u+%u.%06u (fb %ux%u)\n", - state->src_w >> 16, ((state->src_w & 0xffff) * 15625) >> 10, - state->src_h >> 16, ((state->src_h & 0xffff) * 15625) >> 10, - state->src_x >> 16, ((state->src_x & 0xffff) * 15625) >> 10, - state->src_y >> 16, ((state->src_y & 0xffff) * 15625) >> 10, - state->fb->width, state->fb->height); + ret = drm_framebuffer_check_src_coords(state->src_x, state->src_y, + state->src_w, state->src_h, state->fb); + if (ret) return -ENOSPC; - } - if (plane_switching_crtc(state->state, plane, state)) { DRM_DEBUG_ATOMIC("[PLANE:%d:%s] switching CRTC directly\n", plane->base.id, plane->name); -- 2.7.4

2 3

linux-next: manual merge of the drm tree with the v4l-dvb tree
by Stephen Rothwell 27 Jul '18

27 Jul '18

Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/ipu-v3/ipu-cpmem.c between commit: 343b23a7c6b6 ("media: gpu: ipu-v3: Allow negative offsets for interlaced scanning") from the v4l-dvb tree and commit: 4e3c5d7e05be ("gpu: ipu-v3: Allow negative offsets for interlaced scanning") from the drm tree. I fixed it up (I just used the drm tree version) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell

3 2

[Bug 200661] New: AMD Radeon R9 390 freezes/crashing with white stripes/blocks
by bugzilla-daemon＠bugzilla.kernel.org 27 Jul '18

27 Jul '18

https://bugzilla.kernel.org/show_bug.cgi?id=200661 Bug ID: 200661 Summary: AMD Radeon R9 390 freezes/crashing with white stripes/blocks Product: Drivers Version: 2.5 Kernel Version: 4.17.10 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: blocking Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: francois5537(a)gmail.com Regression: No After upgrading to 4.17.10 my screen freezes and is showing white stripes (memory fault?). The issue doesn't show up on 4.17.9 or any lower kernel version. When the screen freezes, the audio continues to play in the background. A few seconds later however the system just seem to stop completely. Boot flags: rw radeon.cik_support=0 radeon.dpm=0 amdgpu.cik_support=1 amdgpu.dc=1 amdgpu.dpm=1 scsi_mod.use_blk_mq=1 pcie_aspm=force I'm using the latest linux-firmware and running Arch Linux. In the journal I'm unable to find any weird stuff, but I'm happy to provide it if needed. Thanks. -- You are receiving this mail because: You are watching the assignee of the bug.

1 6

[PULL] drm-misc-fixes
by Maarten Lankhorst 27 Jul '18

27 Jul '18

drm-misc-fixes-2018-07-27: drm-misc-fixes pull request for v4.18-rc7: - Small fixes to drm_atomic_helper_async_check(). (bbrezillon) - Fix error handling in drm_legacy_addctx(). (Nicholas) - Handle register reset on hotplug in adv7511. (seanpaul) The following changes since commit 3156b53c2e2fadafa1a16412a8791b38f94b5bdc: drm/sun4i: link in front-end code if needed (2018-07-09 09:54:33 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2018-07-27 for you to fetch changes up to a6a00918d4ad8718c3ccde38c02cec17f116b2fd: drm/vc4: Reset ->{x, y}_scaling[1] when dealing with uniplanar formats (2018-07-25 21:15:24 +0200) ---------------------------------------------------------------- drm-misc-fixes pull request for v4.18-rc7: - Small fixes to drm_atomic_helper_async_check(). (bbrezillon) - Fix error handling in drm_legacy_addctx(). (Nicholas) - Handle register reset on hotplug in adv7511. (seanpaul) ---------------------------------------------------------------- Boris Brezillon (3): drm/atomic: Check old_plane_state->crtc in drm_atomic_helper_async_check() drm/atomic: Initialize variables in drm_atomic_helper_async_check() to make gcc happy drm/vc4: Reset ->{x, y}_scaling[1] when dealing with uniplanar formats Nicholas Mc Guire (1): drm: re-enable error handling Sean Paul (1): drm/bridge: adv7511: Reset registers on hotplug drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 12 ++++++++++++ drivers/gpu/drm/drm_atomic_helper.c | 8 +++++--- drivers/gpu/drm/drm_context.c | 2 +- drivers/gpu/drm/vc4/vc4_plane.c | 3 +++ 4 files changed, 21 insertions(+), 4 deletions(-)

1 0

[BUG] video: fbdev: broadsheetfb: Possible null function pointers
by bai 27 Jul '18

27 Jul '18

In Linux-4.16, drivers/video/fbdev/broadsheetfb.c, 158. static void broadsheet_mmio_send_cmdargs(...) { ...... 163. par->board->mmio_write(...); ...... 166. par->board->mmio_write(...); 167. } For x86 kernel configuration, I find that there is no assignment of the function pointer ".mmio_write" in the kernel code. So calling the function pointer in lines 163 and 166 may cause a null pointer dereference. In this file, there are many calls to this function pointer... Best wishes, Jia-Ju Bai

3 3

[RESEND PATCH] drm/bridge/synopsys: remove commented-out flag in Makefile
by Masahiro Yamada 27 Jul '18

27 Jul '18

Please do not comment out unneeded code. Remove. Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- drivers/gpu/drm/bridge/synopsys/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/Makefile b/drivers/gpu/drm/bridge/synopsys/Makefile index 5dad97d..3e1b1e3 100644 --- a/drivers/gpu/drm/bridge/synopsys/Makefile +++ b/drivers/gpu/drm/bridge/synopsys/Makefile @@ -1,5 +1,3 @@ -#ccflags-y := -Iinclude/drm - obj-$(CONFIG_DRM_DW_HDMI) += dw-hdmi.o obj-$(CONFIG_DRM_DW_HDMI_AHB_AUDIO) += dw-hdmi-ahb-audio.o obj-$(CONFIG_DRM_DW_HDMI_I2S_AUDIO) += dw-hdmi-i2s-audio.o -- 2.7.4

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2018