dri-devel October 2019

dri-devel@lists.freedesktop.org

359 participants
1833 discussions

RE: drm/edid: Select DMT timing if EDID's display feature not support GTF
by Lee, Shawn C 07 Oct '19

07 Oct '19

On Tue, Aug 19, 2019, Ville Syrjälä wrote: >On Tue, Aug 06, 2019 at 07:30:21PM +0800, Lee Shawn C wrote: >> Refer to EDID 1.3 spec, display FEATURE (byte 18h) bit #0 said >> "If this bit is set to 1, the display supports timings based on the >> GTF standard using default GTF parameter values". >> >> And EDID 1.4 spec shows "If bit 0 is set to 0, then the display >> is noncontinuous frequency (multi-mode) and is only specified to accept >> the video timing formats that are listed in BASE EDID and certain >> EXTENSION Blocks. >> >> When display feature did not support CVT or GFT2 and monitor's EDID version >> greater than or equal to "1.2". DRM driver would select GTF as default >> for standard timing calculation. It may generated some video timing >> that can't display properly by external monitor. >> >> For example. When driver retrieved "0xD1 0xFC" (FHD, 120Hz) and >> "0xD1 0xE8" (FHD, 100Hz) from "Standard Timings". GTF formula >> would generate video timing like below. It already over monitor's >> spec to cause black screen issue. >> "1920x1080" 120 368881 1920 2072 2288 2656 1080 1081 1084 1157 0x0 0x6 >> "1920x1080" 100 301992 1920 2072 2280 2640 1080 1081 1084 1144 0x0 0x6 >> >> Cc: Jani Nikula <jani.nikula(a)intel.com> >> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> >> Cc: Adam Jackson <ajax(a)redhat.com> >> Cc: Cooper Chiou <cooper.chiou(a)intel.com> >> Signed-off-by: Lee Shawn C <shawn.c.lee(a)intel.com> >> --- >> drivers/gpu/drm/drm_edid.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 82a4ceed3fcf..f6a3d2d993c7 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -2089,7 +2089,9 @@ static int standard_timing_level(struct edid *edid) >> return LEVEL_CVT; >> if (drm_gtf2_hbreak(edid)) >> return LEVEL_GTF2; >> - return LEVEL_GTF; >> + if (edid->revision == 3 && (edid->features & DRM_EDID_FEATURE_DEFAULT_GTF)) >> + return LEVEL_GTF; > >While the oldest EDID spec I have is 1.3, sources on the interwebs >suggest that older revisions already had the "default GTF" flag here. >So I think we can omit the revision check. > I'm sorry I miss this comment and already push pathc v2. Thanks! >> + >> } >> return LEVEL_DMT; >> } >> -- >> 2.17.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel(a)lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel

1 0

[PATCH v5 0/7] backlight: gpio: simplify the driver
by Bartosz Golaszewski 07 Oct '19

07 Oct '19

From: Bartosz Golaszewski <bgolaszewski(a)baylibre.com> While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures to ecovec24. Patch 2/7 unifies much of the code for both pdata and non-pdata cases. Patches 3-4/7 remove unused platform data fields. Last three patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars v3 -> v4: - rebased on top of v5.4-rc1 - removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling") - added patch 7/7 v4 ->V5: - in patch 7/7: added a comment replacing the name of the function being pulled into probe() Bartosz Golaszewski (7): backlight: gpio: remove unneeded include sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull gpio_backlight_initial_power_state() into probe arch/sh/boards/mach-ecovec24/setup.c | 33 ++++-- drivers/video/backlight/gpio_backlight.c | 108 +++++-------------- include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 53 insertions(+), 91 deletions(-) -- 2.23.0

1 0

[PATCH v3 0/6] drm/lima: simplify driver by using more drm helpers
by Qiang Yu 07 Oct '19

07 Oct '19

By using shared drm helpers: 1. drm_gem_objects_lookup 2. drm_gem_(un)lock_reservations 3. drm_gem_shmem_helpers we can simplify lima driver a lot and benifit from updates to these functions. drm_gem_objects_lookup need a refine in order to be used by lima. Note: 1. changes to panfrost and v3d are just compile tested. 2. patch series is based on drm-misc-next branch v2: Add drm_gem_objects_lookup_user and use it for driver which pass user GEM handles in contious array. v3: improve commit comment. Qiang Yu (6): drm/gem: refine drm_gem_objects_lookup drm/v3d: use drm_gem_objects_lookup_user drm/lima: use drm_gem_objects_lookup drm/lima: use drm_gem_shmem_helpers drm/lima: use drm_gem_(un)lock_reservations drm/lima: add __GFP_NOWARN flag to all dma_alloc_wc drivers/gpu/drm/drm_gem.c | 57 ++++-- drivers/gpu/drm/lima/Kconfig | 1 + drivers/gpu/drm/lima/Makefile | 4 +- drivers/gpu/drm/lima/lima_device.c | 2 +- drivers/gpu/drm/lima/lima_drv.c | 27 +-- drivers/gpu/drm/lima/lima_gem.c | 254 ++++++++++-------------- drivers/gpu/drm/lima/lima_gem.h | 32 ++- drivers/gpu/drm/lima/lima_gem_prime.c | 46 ----- drivers/gpu/drm/lima/lima_gem_prime.h | 13 -- drivers/gpu/drm/lima/lima_mmu.c | 1 - drivers/gpu/drm/lima/lima_object.c | 119 ----------- drivers/gpu/drm/lima/lima_object.h | 35 ---- drivers/gpu/drm/lima/lima_sched.c | 6 +- drivers/gpu/drm/lima/lima_vm.c | 87 ++++---- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +- drivers/gpu/drm/v3d/v3d_gem.c | 49 +---- include/drm/drm_gem.h | 4 +- 17 files changed, 239 insertions(+), 504 deletions(-) delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.c delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.h delete mode 100644 drivers/gpu/drm/lima/lima_object.c delete mode 100644 drivers/gpu/drm/lima/lima_object.h -- 2.17.1

1 6

[PATCH 4.9 01/47] drm/bridge: tc358767: Increase AUX transfer length limit
by Greg Kroah-Hartman 06 Oct '19

06 Oct '19

From: Andrey Smirnov <andrew.smirnov(a)gmail.com> [ Upstream commit e0655feaec62d5139b6b13a7b1bbb1ab8f1c2d83 ] According to the datasheet tc358767 can transfer up to 16 bytes via its AUX channel, so the artificial limit of 8 appears to be too low. However only up to 15-bytes seem to be actually supported and trying to use 16-byte transfers results in transfers failing sporadically (with bogus status in case of I2C transfers), so limit it to 15. Signed-off-by: Andrey Smirnov <andrew.smirnov(a)gmail.com> Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrey Gusakov <andrey.gusakov(a)cogentembedded.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Cory Tusar <cory.tusar(a)zii.aero> Cc: Chris Healy <cphealy(a)gmail.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-9-andrew… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 80993a8734e08..8b6f8fac92e89 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -300,7 +300,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) { struct tc_data *tc = aux_to_tc(aux); - size_t size = min_t(size_t, 8, msg->size); + size_t size = min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES - 1, msg->size); u8 request = msg->request & ~DP_AUX_I2C_MOT; u8 *buf = msg->buffer; u32 tmp = 0; -- 2.20.1

1 0

[PATCH 4.14 04/68] drm/bridge: tc358767: Increase AUX transfer length limit
by Greg Kroah-Hartman 06 Oct '19

06 Oct '19

From: Andrey Smirnov <andrew.smirnov(a)gmail.com> [ Upstream commit e0655feaec62d5139b6b13a7b1bbb1ab8f1c2d83 ] According to the datasheet tc358767 can transfer up to 16 bytes via its AUX channel, so the artificial limit of 8 appears to be too low. However only up to 15-bytes seem to be actually supported and trying to use 16-byte transfers results in transfers failing sporadically (with bogus status in case of I2C transfers), so limit it to 15. Signed-off-by: Andrey Smirnov <andrew.smirnov(a)gmail.com> Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrey Gusakov <andrey.gusakov(a)cogentembedded.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Cory Tusar <cory.tusar(a)zii.aero> Cc: Chris Healy <cphealy(a)gmail.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-9-andrew… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 9705ca197b90d..cefa2c1685ba4 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -300,7 +300,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) { struct tc_data *tc = aux_to_tc(aux); - size_t size = min_t(size_t, 8, msg->size); + size_t size = min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES - 1, msg->size); u8 request = msg->request & ~DP_AUX_I2C_MOT; u8 *buf = msg->buffer; u32 tmp = 0; -- 2.20.1

1 0

[PATCH 5.2 027/137] drm/bridge: tc358767: Increase AUX transfer length limit
by Greg Kroah-Hartman 06 Oct '19

06 Oct '19

From: Andrey Smirnov <andrew.smirnov(a)gmail.com> [ Upstream commit e0655feaec62d5139b6b13a7b1bbb1ab8f1c2d83 ] According to the datasheet tc358767 can transfer up to 16 bytes via its AUX channel, so the artificial limit of 8 appears to be too low. However only up to 15-bytes seem to be actually supported and trying to use 16-byte transfers results in transfers failing sporadically (with bogus status in case of I2C transfers), so limit it to 15. Signed-off-by: Andrey Smirnov <andrew.smirnov(a)gmail.com> Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrey Gusakov <andrey.gusakov(a)cogentembedded.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Cory Tusar <cory.tusar(a)zii.aero> Cc: Chris Healy <cphealy(a)gmail.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-9-andrew… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index f59a51e19dab0..d515c7cebb9c4 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -293,7 +293,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) { struct tc_data *tc = aux_to_tc(aux); - size_t size = min_t(size_t, 8, msg->size); + size_t size = min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES - 1, msg->size); u8 request = msg->request & ~DP_AUX_I2C_MOT; u8 *buf = msg->buffer; u32 tmp = 0; -- 2.20.1

1 0

[PATCH 4.19 003/106] drm/bridge: tc358767: Increase AUX transfer length limit
by Greg Kroah-Hartman 06 Oct '19

06 Oct '19

From: Andrey Smirnov <andrew.smirnov(a)gmail.com> [ Upstream commit e0655feaec62d5139b6b13a7b1bbb1ab8f1c2d83 ] According to the datasheet tc358767 can transfer up to 16 bytes via its AUX channel, so the artificial limit of 8 appears to be too low. However only up to 15-bytes seem to be actually supported and trying to use 16-byte transfers results in transfers failing sporadically (with bogus status in case of I2C transfers), so limit it to 15. Signed-off-by: Andrey Smirnov <andrew.smirnov(a)gmail.com> Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrey Gusakov <andrey.gusakov(a)cogentembedded.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Cory Tusar <cory.tusar(a)zii.aero> Cc: Chris Healy <cphealy(a)gmail.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-9-andrew… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index aaca5248da070..d728b6cf61096 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -302,7 +302,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) { struct tc_data *tc = aux_to_tc(aux); - size_t size = min_t(size_t, 8, msg->size); + size_t size = min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES - 1, msg->size); u8 request = msg->request & ~DP_AUX_I2C_MOT; u8 *buf = msg->buffer; u32 tmp = 0; -- 2.20.1

1 0

[PATCH 5.3 003/166] drm/bridge: tc358767: Increase AUX transfer length limit
by Greg Kroah-Hartman 06 Oct '19

06 Oct '19

From: Andrey Smirnov <andrew.smirnov(a)gmail.com> [ Upstream commit e0655feaec62d5139b6b13a7b1bbb1ab8f1c2d83 ] According to the datasheet tc358767 can transfer up to 16 bytes via its AUX channel, so the artificial limit of 8 appears to be too low. However only up to 15-bytes seem to be actually supported and trying to use 16-byte transfers results in transfers failing sporadically (with bogus status in case of I2C transfers), so limit it to 15. Signed-off-by: Andrey Smirnov <andrew.smirnov(a)gmail.com> Reviewed-by: Andrzej Hajda <a.hajda(a)samsung.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Cc: Andrey Gusakov <andrey.gusakov(a)cogentembedded.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Cory Tusar <cory.tusar(a)zii.aero> Cc: Chris Healy <cphealy(a)gmail.com> Cc: Lucas Stach <l.stach(a)pengutronix.de> Cc: dri-devel(a)lists.freedesktop.org Cc: linux-kernel(a)vger.kernel.org Signed-off-by: Andrzej Hajda <a.hajda(a)samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-9-andrew… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 13ade28a36a8a..b3a7d5f1250c8 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -313,7 +313,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) { struct tc_data *tc = aux_to_tc(aux); - size_t size = min_t(size_t, 8, msg->size); + size_t size = min_t(size_t, DP_AUX_MAX_PAYLOAD_BYTES - 1, msg->size); u8 request = msg->request & ~DP_AUX_I2C_MOT; u8 *buf = msg->buffer; u32 tmp = 0; -- 2.20.1

1 0

[PATCH v19 0/2] PS8640 MIPI-to-eDP bridge
by Ulrich Hecht 06 Oct '19

06 Oct '19

Hi! This driver seems to have fallen by the wayside because, while otherwise fine, it has a firmware update feature that requires a blob that is not in the linux-firmware repo.[1] Whatever the cause for that may be, the update code is entirely optional (my chip works fine with whatever firmware is currently installed), so I have removed it in order to get this merged after all. I have also followed various trivial API changes that have piled up since 2016; see the individual patches for details. I'm using this driver on an Acer Chromebook R13 ("Elm"); see https://github.com/uli/kernel/tree/elm-working-5.4. CU Uli [1] https://patchwork.kernel.org/patch/9427543/ Jitao Shi (2): Documentation: bridge: Add documentation for ps8640 DT properties drm/bridge: Add I2C based driver for ps8640 bridge .../devicetree/bindings/display/bridge/ps8640.txt | 44 ++ drivers/gpu/drm/bridge/Kconfig | 12 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/parade-ps8640.c | 672 +++++++++++++++++++++ 4 files changed, 729 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt create mode 100644 drivers/gpu/drm/bridge/parade-ps8640.c -- 2.7.4

2 4

[drm-tip:drm-tip 548/565] drivers/gpu/drm/i915/gem/i915_gem_context.c:813:29: sparse: sparse: incorrect type in argument 1 (different address spaces)
by kbuild test robot 06 Oct '19

06 Oct '19

tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: f99065c68952afc90504325a19125d95e6b84abc commit: a4e7ccdac38ec8335d9e4e2656c1a041c77feae1 [548/565] drm/i915: Move context management under GEM reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-42-g38eda53-dirty git checkout a4e7ccdac38ec8335d9e4e2656c1a041c77feae1 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/gem/i915_gem_context.c:813:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct i915_address_space *vm @@ got struct i915_addresstruct i915_address_space *vm @@ >> drivers/gpu/drm/i915/gem/i915_gem_context.c:813:29: sparse: expected struct i915_address_space *vm >> drivers/gpu/drm/i915/gem/i915_gem_context.c:813:29: sparse: got struct i915_address_space [noderef] <asn:4> *vm drivers/gpu/drm/i915/gem/i915_gem_context.c:1748:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct i915_gem_engines *e @@ got struct i915_gem_enstruct i915_gem_engines *e @@ drivers/gpu/drm/i915/gem/i915_gem_context.c:1748:25: sparse: expected struct i915_gem_engines *e drivers/gpu/drm/i915/gem/i915_gem_context.c:1748:25: sparse: got struct i915_gem_engines [noderef] <asn:4> *engines drivers/gpu/drm/i915/gem/i915_gem_context.c:1783:15: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct i915_gem_engines *clone @@ got struct i915_gem_enstruct i915_gem_engines *clone @@ drivers/gpu/drm/i915/gem/i915_gem_context.c:1783:15: sparse: expected struct i915_gem_engines *clone drivers/gpu/drm/i915/gem/i915_gem_context.c:1783:15: sparse: got struct i915_gem_engines [noderef] <asn:4> *engines >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:773:51: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct i915_address_space *[assigned] vm @@ got struct struct i915_address_space *[assigned] vm @@ >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:773:51: sparse: expected struct i915_address_space *[assigned] vm >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:773:51: sparse: got struct i915_address_space [noderef] <asn:4> *vm >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:780:64: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct i915_address_space *vm @@ got struct i915_addresstruct i915_address_space *vm @@ >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:780:64: sparse: expected struct i915_address_space *vm drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:780:64: sparse: got struct i915_address_space [noderef] <asn:4> *vm >> drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c:1694:25: sparse: sparse: dereference of noderef expression vim +813 drivers/gpu/drm/i915/gem/i915_gem_context.c 85fddf0b002719 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-09 801 cde5f7edd511b1 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-30 802 static int get_ppgtt(struct drm_i915_file_private *file_priv, cde5f7edd511b1 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-30 803 struct i915_gem_context *ctx, e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 804 struct drm_i915_gem_context_param *args) e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 805 { e568ac3874be7d drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-06-11 806 struct i915_address_space *vm; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 807 int ret; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 808 a4e7ccdac38ec8 drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-10-04 809 if (!rcu_access_pointer(ctx->vm)) e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 810 return -ENODEV; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 811 a4e7ccdac38ec8 drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-10-04 812 rcu_read_lock(); e568ac3874be7d drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-06-11 @813 vm = i915_vm_get(ctx->vm); a4e7ccdac38ec8 drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-10-04 814 rcu_read_unlock(); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 815 e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 816 ret = mutex_lock_interruptible(&file_priv->vm_idr_lock); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 817 if (ret) e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 818 goto err_put; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 819 e568ac3874be7d drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-06-11 820 ret = idr_alloc(&file_priv->vm_idr, vm, 0, 0, GFP_KERNEL); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 821 GEM_BUG_ON(!ret); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 822 if (ret < 0) e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 823 goto err_unlock; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 824 2850748ef8763a drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-10-04 825 i915_vm_open(vm); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 826 e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 827 args->size = 0; 1f2b4a7edbc3b8 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-04-25 828 args->value = ret; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 829 e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 830 ret = 0; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 831 err_unlock: e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 832 mutex_unlock(&file_priv->vm_idr_lock); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 833 err_put: e568ac3874be7d drivers/gpu/drm/i915/gem/i915_gem_context.c Chris Wilson 2019-06-11 834 i915_vm_put(vm); e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 835 return ret; e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 836 } e0695db7298ec2 drivers/gpu/drm/i915/i915_gem_context.c Chris Wilson 2019-03-22 837 :::::: The code at line 813 was first introduced by commit :::::: e568ac3874be7dcef3da0cc3bd6b91ca9dd14aa0 drm/i915: Pull kref into i915_address_space :::::: TO: Chris Wilson <chris(a)chris-wilson.co.uk> :::::: CC: Chris Wilson <chris(a)chris-wilson.co.uk> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2019