dri-devel October 2019

dri-devel@lists.freedesktop.org

359 participants
1833 discussions

[PATCH] drm/amdgpu: fix memory leak
by Nirmoy Das 04 Oct '19

04 Oct '19

In amdgpu_bo_list_ioctl when idr_alloc fails don't return without freeing bo list entry. Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO lists in CS ioctl v3") Signed-off-by: Nirmoy Das <nirmoy.das(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c index 7bcf86c61999..c3e5ea544857 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c @@ -284,7 +284,7 @@ int amdgpu_bo_list_ioctl(struct drm_device *dev, void *data, mutex_unlock(&fpriv->bo_list_lock); if (r < 0) { amdgpu_bo_list_put(list); - return r; + goto error_free; } handle = r; -- 2.23.0

3 6

[PATCH 2/2] drm: bridge: adv7511: Extend list of audio sample rates
by Bogdan Togorean 04 Oct '19

04 Oct '19

ADV7511 support sample rates up to 192kHz. CTS and N parameters should be computed accordingly so this commit extend the list up to maximum supported sample rate. Signed-off-by: Bogdan Togorean <bogdan.togorean(a)analog.com> --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c index 96be7b005c50..f376ed7eb9da 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -27,6 +27,18 @@ static void adv7511_calc_cts_n(unsigned int f_tmds, unsigned int fs, case 48000: *n = 6144; break; + case 88200: + *n = 12544; + break; + case 96000: + *n = 12288; + break; + case 176400: + *n = 25088; + break; + case 192000: + *n = 24576; + break; } *cts = ((f_tmds * *n) / (128 * fs)) * 1000; -- 2.23.0

1 0

[PATCH] backlight: pwm_bl: Add missing curly branches in else branch
by Matthias Kaehlcke 04 Oct '19

04 Oct '19

Add curly braces to an 'else' branch in pwm_backlight_update_status() to match the corresponding 'if' branch. Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- drivers/video/backlight/pwm_bl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 746eebc411df..130abff2705f 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -125,8 +125,9 @@ static int pwm_backlight_update_status(struct backlight_device *bl) state.duty_cycle = compute_duty_cycle(pb, brightness); pwm_apply_state(pb->pwm, &state); pwm_backlight_power_on(pb); - } else + } else { pwm_backlight_power_off(pb); + } if (pb->notify_after) pb->notify_after(pb->dev, brightness); -- 2.23.0.444.g18eeb5a265-goog

2 1

[Bug 111902] too much trees
by bugzilla-daemon＠freedesktop.org 04 Oct '19

04 Oct '19

https://bugs.freedesktop.org/show_bug.cgi?id=111902 Bug ID: 111902 Summary: too much trees Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) URL: http://mu.ac.in/portal/ OS: Windows (All) Status: ASSIGNED Keywords: bisected Severity: normal Priority: high Component: General Assignee: dri-devel(a)lists.freedesktop.org Reporter: nanditapillai1999(a)gmail.com Created attachment 145632 --> https://bugs.freedesktop.org/attachment.cgi?id=145632&action=edit too much trees -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 111900] clutterrerddd
by bugzilla-daemon＠freedesktop.org 04 Oct '19

04 Oct '19

1 0

Re: [PATCH] dt-bindings: display: renesas: Add r8a774b1 support
by Laurent Pinchart 04 Oct '19

04 Oct '19

Hi Biju, Thank you for the patch. On Mon, Sep 30, 2019 at 10:28:51AM +0100, Biju Das wrote: > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Biju Das <biju.das(a)bp.renesas.com> I really like how your RZ patches are simple, they're painless to review, it's all very pleasurable :-) Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> And applied to my tree. > --- > Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > index db68041..819f3e3 100644 > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > @@ -13,6 +13,7 @@ Required properties: > > - compatible : Shall contain one or more of > - "renesas,r8a774a1-hdmi" for R8A774A1 (RZ/G2M) compatible HDMI TX > + - "renesas,r8a774b1-hdmi" for R8A774B1 (RZ/G2N) compatible HDMI TX > - "renesas,r8a7795-hdmi" for R8A7795 (R-Car H3) compatible HDMI TX > - "renesas,r8a7796-hdmi" for R8A7796 (R-Car M3-W) compatible HDMI TX > - "renesas,r8a77965-hdmi" for R8A77965 (R-Car M3-N) compatible HDMI TX -- Regards, Laurent Pinchart

2 1

Re: [PATCH v1 2/2] drm/panel: simple: add display timings for logic technologies displays
by Rob Herring 04 Oct '19

04 Oct '19

On Fri, Sep 20, 2019 at 09:54:11AM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> > > Add display timings for the following 3 display panels manufactured by > Logic Technologies Limited: > > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display > 7" Parallel [1] > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" > Parallel [2] > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display > 10.1" LVDS [3] > > Those panels may also be distributed by Endrich Bauelemente Vertriebs > GmbH [4]. > > [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-80… > [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800… > [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-128… > [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30 > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 65 ++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 28fa6ba7b767..42bd0de25167 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2034,6 +2034,62 @@ static const struct panel_desc lg_lp129qe = { > }, > }; > > +static const struct display_timing logictechno_lt161010_2nh_timing = { > + .pixelclock = { 26400000, 33300000, 46800000 }, > + .hactive = { 800, 800, 800 }, > + .hfront_porch = { 16, 210, 354 }, > + .hback_porch = { 46, 46, 46 }, > + .hsync_len = { 1, 20, 40 }, > + .vactive = { 480, 480, 480 }, > + .vfront_porch = { 7, 22, 147 }, > + .vback_porch = { 23, 23, 23 }, > + .vsync_len = { 1, 10, 20 }, > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > +}; > + > +static const struct panel_desc logictechno_lt161010_2nh = { > + .timings = &logictechno_lt161010_2nh_timing, > + .num_timings = 1, > + .size = { > + .width = 154, > + .height = 86, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, > +}; > + > +static const struct display_timing logictechno_lt170410_2whc_timing = { > + .pixelclock = { 68900000, 71100000, 7340000 }, > + .hactive = { 1280, 1280, 1280 }, > + .hfront_porch = { 23, 60, 71 }, > + .hback_porch = { 23, 60, 71 }, > + .hsync_len = { 15, 40, 47 }, > + .vactive = { 800, 800, 800 }, > + .vfront_porch = { 5, 7, 10 }, > + .vback_porch = { 5, 7, 10 }, > + .vsync_len = { 6, 9, 12 }, > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > +}; > + > +static const struct panel_desc logictechno_lt170410_2whc = { > + .timings = &logictechno_lt170410_2whc_timing, > + .num_timings = 1, > + .size = { > + .width = 217, > + .height = 136, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, > +}; > + > static const struct drm_display_mode mitsubishi_aa070mc01_mode = { > .clock = 30400, > .hdisplay = 800, > @@ -3264,6 +3320,15 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "lg,lp129qe", > .data = &lg_lp129qe, > + }, { > + .compatible = "logictechno,lt161010-2nhc", > + .data = &logictechno_lt161010_2nh, > + }, { > + .compatible = "logictechno,lt161010-2nhr", > + .data = &logictechno_lt161010_2nh, > + }, { > + .compatible = "logictechno,lt170410-2whc", > + .data = &logictechno_lt170410_2whc, The vendor prefix wasn't documented, but the compatible string and rest already are? Rob

2 3

[PATCH] drm/bridge: sii902x: Variable status in sii902x_connector_detect() could be uninitialized if regmap_read() fails
by Yizhuo 04 Oct '19

04 Oct '19

In function sii902x_connector_detect(), variable "status" could be initialized if regmap_read() fails. However, "status" is used to decide the return value, which is potentially unsafe. Signed-off-by: Yizhuo <yzhai003(a)ucr.edu> --- drivers/gpu/drm/bridge/sii902x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 38f75ac580df..afce64f51ff2 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bridge/sii902x.c @@ -246,7 +246,7 @@ static enum drm_connector_status sii902x_connector_detect(struct drm_connector *connector, bool force) { struct sii902x *sii902x = connector_to_sii902x(connector); - unsigned int status; + unsigned int status = 0; mutex_lock(&sii902x->mutex); -- 2.17.1

2 1

Re: [PATCH 0/4] Add RZ/G2N DU support
by Laurent Pinchart 04 Oct '19

04 Oct '19

Hi Biju, Thank you for the patches; On Mon, Sep 30, 2019 at 10:15:01AM +0100, Biju Das wrote: > This patch series aims to add binding/driver support for > R8A774B1(a.k.a RZ/G2N) DU (which is very similar to the R8A77965 DU); > it has one RGB output, one LVDS output and one HDMI output. > > Biju Das (4): > dt-bindings: display: renesas: du: Document the r8a774b1 bindings > drm: rcar-du: Add R8A774B1 support > dt-bindings: display: renesas: lvds: Document r8a774b1 bindings > drm: rcar-du: lvds: Add r8a774b1 support For the whole series, Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> and applied to my tree. > .../bindings/display/bridge/renesas,lvds.txt | 1 + > .../devicetree/bindings/display/renesas,du.txt | 2 ++ > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 30 ++++++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 + > 4 files changed, 34 insertions(+) -- Regards, Laurent Pinchart

1 0

RE: [PATCH 0/4] Add RZ/G2N DU support
by Biju Das 04 Oct '19

04 Oct '19

Hi Laurent, Are you happy with this patch? Please let me know. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=180271 regards, Biju > Subject: [PATCH 0/4] Add RZ/G2N DU support > > This patch series aims to add binding/driver support for R8A774B1(a.k.a > RZ/G2N) DU (which is very similar to the R8A77965 DU); it has one RGB > output, one LVDS output and one HDMI output. > > Biju Das (4): > dt-bindings: display: renesas: du: Document the r8a774b1 bindings > drm: rcar-du: Add R8A774B1 support > dt-bindings: display: renesas: lvds: Document r8a774b1 bindings > drm: rcar-du: lvds: Add r8a774b1 support > > .../bindings/display/bridge/renesas,lvds.txt | 1 + > .../devicetree/bindings/display/renesas,du.txt | 2 ++ > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 30 > ++++++++++++++++++++++ > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 + > 4 files changed, 34 insertions(+) > > -- > 2.7.4

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2019