dri-devel October 2019

dri-devel@lists.freedesktop.org

359 participants
1833 discussions

[PATCH] drm/i810: Prevent underflow in ioctl
by Dan Carpenter 04 Oct '19

04 Oct '19

The "used" variables here come from the user in the ioctl and it can be negative. It could result in an out of bounds write. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/i810/i810_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 2a77823b8e9a..e66c38332df4 100644 --- a/drivers/gpu/drm/i810/i810_dma.c +++ b/drivers/gpu/drm/i810/i810_dma.c @@ -728,7 +728,7 @… [View More]

2 2

drm_sched with panfrost crash on T820
by Neil Armstrong 04 Oct '19

04 Oct '19

Hi Christian, In v5.3, running dEQP triggers the following kernel crash : [ 20.224982] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000038 [...] [ 20.291064] Hardware name: Khadas VIM2 (DT) [ 20.295217] Workqueue: events drm_sched_job_timedout [...] [ 20.304867] pc : drm_sched_increase_karma+0x5c/0xf0 [ 20.309696] lr : drm_sched_increase_karma+0x44/0xf0 [...] [ 20.396720] Call trace: [ 20.399138] drm_sched_increase_karma+0x5c/0xf0 [ 20.403623] … [View More] panfrost_job_timedout+0x12c/0x1e0 [ 20.408021] drm_sched_job_timedout+0x48/0xa0 [ 20.412336] process_one_work+0x1e0/0x320 [ 20.416300] worker_thread+0x40/0x450 [ 20.419924] kthread+0x124/0x128 [ 20.423116] ret_from_fork+0x10/0x18 [ 20.426653] Code: f9400001 540001c0 f9400a83 f9402402 (f9401c64) [ 20.432690] ---[ end trace bd02f890139096a7 ]--- Which never happens, at all, on v5.2. I did a (very) long (7 days, ~100runs) bisect run using our LAVA lab (thanks tomeu !), but bisecting was not easy since the bad commit landed on drm-misc-next after v5.1-rc6, and then v5.2-rc1 was backmerged into drm-misc-next at: [1] 374ed5429346 Merge drm/drm-next into drm-misc-next Thus bisecting between [1] ang v5.2-rc1 leads to commit based on v5.2-rc1... where panfrost was not enabled in the Khadas VIM2 DT. Anyway, I managed to identify 3 possibly breaking commits : [2] 290764af7e36 drm/sched: Keep s_fence->parent pointer [3] 5918045c4ed4 drm/scheduler: rework job destruction [4] a5343b8a2ca5 drm/scheduler: Add flag to hint the release of guilty job. But [1] and [2] doesn't crash the same way : [ 16.257912] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000060 [...] [ 16.308307] CPU: 4 PID: 80 Comm: kworker/4:1 Not tainted 5.1.0-rc2-01185-g290764af7e36-dirty #378 [ 16.317099] Hardware name: Khadas VIM2 (DT) [...]) [ 16.330907] pc : refcount_sub_and_test_checked+0x4/0xb0 [ 16.336078] lr : refcount_dec_and_test_checked+0x14/0x20 [...] [ 16.423533] Process kworker/4:1 (pid: 80, stack limit = 0x(____ptrval____)) [ 16.430431] Call trace: [ 16.432851] refcount_sub_and_test_checked+0x4/0xb0 [ 16.437681] drm_sched_job_cleanup+0x24/0x58 [ 16.441908] panfrost_job_free+0x14/0x28 [ 16.445787] drm_sched_job_timedout+0x6c/0xa0 [ 16.450102] process_one_work+0x1e0/0x320 [ 16.454067] worker_thread+0x40/0x450 [ 16.457690] kthread+0x124/0x128 [ 16.460882] ret_from_fork+0x10/0x18 [ 16.464421] Code: 52800000 d65f03c0 d503201f aa0103e3 (b9400021) [ 16.470456] ---[ end trace 39a67412ee1b64b5 ]--- and [3] fails like on v5.3 (in drm_sched_increase_karma): [ 33.830080] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000038 [...] [ 33.871946] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 33.877450] Modules linked in: [ 33.880474] CPU: 6 PID: 81 Comm: kworker/6:1 Not tainted 5.1.0-rc2-01186-ga5343b8a2ca5-dirty #380 [ 33.889265] Hardware name: Khadas VIM2 (DT) [ 33.893419] Workqueue: events drm_sched_job_timedout [...] [ 33.903069] pc : drm_sched_increase_karma+0x5c/0xf0 [ 33.907898] lr : drm_sched_increase_karma+0x44/0xf0 [...] [ 33.994924] Process kworker/6:1 (pid: 81, stack limit = 0x(____ptrval____)) [ 34.001822] Call trace: [ 34.004242] drm_sched_increase_karma+0x5c/0xf0 [ 34.008726] panfrost_job_timedout+0x12c/0x1e0 [ 34.013122] drm_sched_job_timedout+0x48/0xa0 [ 34.017438] process_one_work+0x1e0/0x320 [ 34.021402] worker_thread+0x40/0x450 [ 34.025026] kthread+0x124/0x128 [ 34.028218] ret_from_fork+0x10/0x18 [ 34.031755] Code: f9400001 540001c0 f9400a83 f9402402 (f9401c64) [ 34.037792] ---[ end trace be3fd6f77f4df267 ]--- When I revert [3] on [1], i get the same crash as [2], meaning the commit [3] masks the failure [2] introduced. Do you know how to solve this ? Thanks, Neil [View Less]

5 20

Re: linux-next: Tree for Oct 4 (amdgpu)
by Randy Dunlap 04 Oct '19

04 Oct '19

On 10/3/19 10:59 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20191003: > on x86_64: CONFIG_DRM_AMDGPU=y # CONFIG_DRM_AMDGPU_SI is not set # CONFIG_DRM_AMDGPU_CIK is not set CONFIG_DRM_AMDGPU_USERPTR=y CONFIG_DRM_AMDGPU_GART_DEBUGFS=y ld: drivers/gpu/drm/amd/amdkfd/kfd_device.o:(.rodata+0xf60): undefined reference to `gfx_v7_kfd2kgd' -- ~Randy

2 1

[PATCH v3] drm/fourcc: Add Arm 16x16 block modifier
by Ayan Halder 04 Oct '19

04 Oct '19

From: Raymond Smith <raymond.smith(a)arm.com> Add the DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED modifier to denote the 16x16 block u-interleaved format used in Arm Utgard and Midgard GPUs. Changes from v1:- 1. Reserved the upper four bits (out of the 56 bits assigned to each vendor) to denote the category of Arm specific modifiers. Currently, we have two categories ie AFBC and MISC. Changes from v2:- 1. Preserved Ray's authorship 2. Cleanups/changes suggested by Brian 3. Added r-bs … [View More]

1 1

[PATCH 1/2] drm: bridge: adv7511: Enable SPDIF DAI
by Bogdan Togorean 04 Oct '19

04 Oct '19

ADV7511 support I2S or SPDIF as audio input interfaces. This commit enable support for SPDIF. Signed-off-by: Bogdan Togorean <bogdan.togorean(a)analog.com> --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c index a428185be2c1..96be7b005c50 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/… [View More]

2 1

[PATCH][next] drm/amdgpu: remove redundant variable r and redundant return statement
by Colin King 04 Oct '19

04 Oct '19

From: Colin Ian King <colin.king(a)canonical.com> There is a return statement that is not reachable and a variable that is not used. Remove them. Addresses-Coverity: ("Structurally dead code") Fixes: de7b45babd9b ("drm/amdgpu: cleanup creating BOs at fixed location (v2)") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/… [View More]

3 2

[PATCH][next] drm/amdgpu: fix uninitialized variable pasid_mapping_needed
by Colin King 04 Oct '19

04 Oct '19

From: Colin Ian King <colin.king(a)canonical.com> The boolean variable pasid_mapping_needed is not initialized and there are code paths that do not assign it any value before it is is read later. Fix this by initializing pasid_mapping_needed to false. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/amd/amdgpu/… [View More]

3 2

[PATCH] drm/amd/display: Make some functions static
by zhengbin 04 Oct '19

04 Oct '19

Fix sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:32:6: warning: symbol 'lp_write_i2c' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:42:6: warning: symbol 'lp_read_i2c' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:52:6: warning: symbol 'lp_write_dpcd' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/… [View More]

2 1

[PATCH v3] drm/amd/display: fix struct init in update_bounding_box
by Raul E Rangel 04 Oct '19

04 Oct '19

dcn20_resource.c:2636:9: error: missing braces around initializer [-Werror=missing-braces] struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; ^ Fixes: 7ed4e6352c16f ("drm/amd/display: Add DCN2 HW Sequencer and Resource") Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> --- Changes in v3: - Use memset Changes in v2: - Use {{0}} instead of {} drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +++- 1 file changed, 3 insertions(+)… [View More]

2 1

[PATCH] drm/amdgpu: Fix build error when !CONFIG_PERF_EVENTS
by Huacai Chen 04 Oct '19

04 Oct '19

In previous release amdgpu_pmu.o is only built when CONFIG_PERF_EVENTS is selected. But after commit 64f55e629237e4752db1 ("drm/amdgpu: Add RAS EEPROM table.") it is duplicated in amdgpu-y. This change causes a build error when !CONFIG_PERF_EVENTS, so fix it. Fixes: 64f55e629237e4752db1 ("drm/amdgpu: Add RAS EEPROM table.") Cc: Andrey Grodzovsky <andrey.grodzovsky(a)amd.com> Cc: Luben Tuikov <Luben.Tuikov(a)amd.com> Signed-off-by: Huacai Chen <chenhc(a)lemote.com> --- … [View More]

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2019