dri-devel August 2019

dri-devel@lists.freedesktop.org

318 participants
2338 discussions

[Bug 102372] [dc] [kabini] Errors during startup - X doesn't start
by bugzilla-daemon＠freedesktop.org 20 Aug '19

20 Aug '19

https://bugs.freedesktop.org/show_bug.cgi?id=102372 Bug ID: 102372 Summary: [dc] [kabini] Errors during startup - X doesn't start Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: mike(a)fireburn.co.uk Created attachment 133715 --> https://bugs.freedesktop.org/attachment.cgi?id=133715&action=edit Dmesg Logs filled with errors, managed to SSH in and capture the dmesg before rebooting -- You are receiving this mail because: You are the assignee for the bug.

1 15

[PATCH AUTOSEL 4.14 10/12] drm/ast: Fixed reboot test may cause system hanged
by Sasha Levin 20 Aug '19

20 Aug '19

From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> [ Upstream commit 05b439711f6ff8700e8660f97a1179650778b9cb ] There is another thread still access standard VGA I/O while loading drm driver. Disable standard VGA I/O decode to avoid this issue. Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> Reviewed-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Signed-off-by: Dave Airlie <airlied(a)redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/1523410059-18415-1-git-send-e… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/ast/ast_main.c | 5 ++++- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/ast/ast_post.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 373700c05a00f..224fa1ef87ff9 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -131,8 +131,8 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post) /* Enable extended register access */ - ast_enable_mmio(dev); ast_open_key(ast); + ast_enable_mmio(dev); /* Find out whether P2A works or whether to use device-tree */ ast_detect_config_mode(dev, &scu_rev); @@ -576,6 +576,9 @@ void ast_driver_unload(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; + /* enable standard VGA decode */ + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x04); + ast_release_firmware(dev); kfree(ast->dp501_fw_addr); ast_mode_fini(dev); diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 343867b182dd8..a09fafa270822 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -600,7 +600,7 @@ static int ast_crtc_mode_set(struct drm_crtc *crtc, return -EINVAL; ast_open_key(ast); - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); ast_set_std_reg(crtc, adjusted_mode, &vbios_mode); ast_set_crtc_reg(crtc, adjusted_mode, &vbios_mode); diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c index f7d421359d564..c1d1ac51d1c20 100644 --- a/drivers/gpu/drm/ast/ast_post.c +++ b/drivers/gpu/drm/ast/ast_post.c @@ -46,7 +46,7 @@ void ast_enable_mmio(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); } -- 2.20.1

1 0

[PATCH AUTOSEL 4.19 24/27] drm/ast: Fixed reboot test may cause system hanged
by Sasha Levin 20 Aug '19

20 Aug '19

From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> [ Upstream commit 05b439711f6ff8700e8660f97a1179650778b9cb ] There is another thread still access standard VGA I/O while loading drm driver. Disable standard VGA I/O decode to avoid this issue. Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> Reviewed-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Signed-off-by: Dave Airlie <airlied(a)redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/1523410059-18415-1-git-send-e… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/ast/ast_main.c | 5 ++++- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/ast/ast_post.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 373700c05a00f..224fa1ef87ff9 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -131,8 +131,8 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post) /* Enable extended register access */ - ast_enable_mmio(dev); ast_open_key(ast); + ast_enable_mmio(dev); /* Find out whether P2A works or whether to use device-tree */ ast_detect_config_mode(dev, &scu_rev); @@ -576,6 +576,9 @@ void ast_driver_unload(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; + /* enable standard VGA decode */ + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x04); + ast_release_firmware(dev); kfree(ast->dp501_fw_addr); ast_mode_fini(dev); diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 8bb355d5d43d8..9d92d2d2fcfc7 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -600,7 +600,7 @@ static int ast_crtc_mode_set(struct drm_crtc *crtc, return -EINVAL; ast_open_key(ast); - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); ast_set_std_reg(crtc, adjusted_mode, &vbios_mode); ast_set_crtc_reg(crtc, adjusted_mode, &vbios_mode); diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c index f7d421359d564..c1d1ac51d1c20 100644 --- a/drivers/gpu/drm/ast/ast_post.c +++ b/drivers/gpu/drm/ast/ast_post.c @@ -46,7 +46,7 @@ void ast_enable_mmio(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); } -- 2.20.1

1 0

[PATCH AUTOSEL 5.2 41/44] drm/ast: Fixed reboot test may cause system hanged
by Sasha Levin 20 Aug '19

20 Aug '19

From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> [ Upstream commit 05b439711f6ff8700e8660f97a1179650778b9cb ] There is another thread still access standard VGA I/O while loading drm driver. Disable standard VGA I/O decode to avoid this issue. Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> Reviewed-by: Benjamin Herrenschmidt <benh(a)kernel.crashing.org> Signed-off-by: Dave Airlie <airlied(a)redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/1523410059-18415-1-git-send-e… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/ast/ast_main.c | 5 ++++- drivers/gpu/drm/ast/ast_mode.c | 2 +- drivers/gpu/drm/ast/ast_post.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 2854399856ba0..4aebe21e6ad9f 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -131,8 +131,8 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post) /* Enable extended register access */ - ast_enable_mmio(dev); ast_open_key(ast); + ast_enable_mmio(dev); /* Find out whether P2A works or whether to use device-tree */ ast_detect_config_mode(dev, &scu_rev); @@ -576,6 +576,9 @@ void ast_driver_unload(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; + /* enable standard VGA decode */ + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x04); + ast_release_firmware(dev); kfree(ast->dp501_fw_addr); ast_mode_fini(dev); diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 97fed0627d1c8..74da15a3341a8 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -601,7 +601,7 @@ static int ast_crtc_mode_set(struct drm_crtc *crtc, return -EINVAL; ast_open_key(ast); - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); ast_set_std_reg(crtc, adjusted_mode, &vbios_mode); ast_set_crtc_reg(crtc, adjusted_mode, &vbios_mode); diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c index f7d421359d564..c1d1ac51d1c20 100644 --- a/drivers/gpu/drm/ast/ast_post.c +++ b/drivers/gpu/drm/ast/ast_post.c @@ -46,7 +46,7 @@ void ast_enable_mmio(struct drm_device *dev) { struct ast_private *ast = dev->dev_private; - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); + ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06); } -- 2.20.1

1 0

[PATCH AUTOSEL 5.2 40/44] drm/scheduler: use job count instead of peek
by Sasha Levin 20 Aug '19

20 Aug '19

From: Christian König <christian.koenig(a)amd.com> [ Upstream commit e1b4ce25dbc93ab0cb8ed0f236a3b9ff7b03802c ] The spsc_queue_peek function is accessing queue->head which belongs to the consumer thread and shouldn't be accessed by the producer This is fixing a rare race condition when destroying entities. Signed-off-by: Christian König <christian.koenig(a)amd.com> Acked-by: Andrey Grodzovsky <andrey.grodzovsky(a)amd.com> Reviewed-by: Monk.liu(a)amd.com Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/scheduler/sched_entity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index 35ddbec1375ae..671c90f34ede6 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -95,7 +95,7 @@ static bool drm_sched_entity_is_idle(struct drm_sched_entity *entity) rmb(); /* for list_empty to work without lock */ if (list_empty(&entity->list) || - spsc_queue_peek(&entity->job_queue) == NULL) + spsc_queue_count(&entity->job_queue) == 0) return true; return false; @@ -281,7 +281,7 @@ void drm_sched_entity_fini(struct drm_sched_entity *entity) /* Consumption of existing IBs wasn't completed. Forcefully * remove them here. */ - if (spsc_queue_peek(&entity->job_queue)) { + if (spsc_queue_count(&entity->job_queue)) { if (sched) { /* Park the kernel for a moment to make sure it isn't processing * our enity. -- 2.20.1

1 0

[PATCH 0/3] dt-bindings for lima support on HiKey
by John Stultz 20 Aug '19

20 Aug '19

Peter sent a patchset out back in April to enable Lima support on HiKey, but there's not been much action on it since since. I've been carrying the patchset in my tree, and figured I'd send out just these three dt-bindings changes just so hopefully they can go in and the dependent driver changes can be more easily pushed later on. thanks -john Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Peter Griffin <peter.griffin(a)linaro.org> Cc: dri-devel(a)lists.freedesktop.org Cc: devicetree(a)vger.kernel.org Peter Griffin (3): dt-bindings: gpu: mali-utgard: add hisilicon,hi6220-mali compatible dt-bindings: reset: hisilicon: Update compatible documentation dt-bindings: reset: hisilicon: Add ao reset controller Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 5 +++++ .../devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 1 + include/dt-bindings/reset/hisi,hi6220-resets.h | 7 +++++++ 3 files changed, 13 insertions(+) -- 2.17.1

2 4

[PATCH v6 0/3] drm/i915: Enable HDCP 1.4 and 2.2 on Gen12+
by Ramalingam C 20 Aug '19

20 Aug '19

Enabling the HDCP1.4 and 2.2 on TGL by supporting the HW block movement from DDI into transcoder. v6: Extending the I915-MEI HDCP interface to include the transcoder. For register programming, transcoder is used instead of PIPE. Just readability improvement pipe and transcoder definition is moved into i915_drm.h Rebased. Ramalingam C (3): drm/i915: enum transcoder and pipe are moved into i915_drm.h misc/mei_hdcp: Adding the transcoder detail in payload input drm/i915: Enable HDCP 1.4 and 2.2 on Gen12+ drivers/gpu/drm/i915/display/intel_display.h | 44 ------ drivers/gpu/drm/i915/display/intel_dp.c | 3 + drivers/gpu/drm/i915/display/intel_hdcp.c | 158 +++++++++++++------ drivers/gpu/drm/i915/display/intel_hdcp.h | 2 + drivers/gpu/drm/i915/display/intel_hdmi.c | 12 +- drivers/gpu/drm/i915/i915_reg.h | 124 +++++++++++++-- drivers/misc/mei/hdcp/mei_hdcp.c | 27 ++++ drivers/misc/mei/hdcp/mei_hdcp.h | 15 +- include/drm/i915_drm.h | 46 ++++++ include/drm/i915_mei_hdcp_interface.h | 2 + 10 files changed, 324 insertions(+), 109 deletions(-) -- 2.20.1

3 9

[PATCH] dmabuf: Mark up onstack timer for selftests
by Chris Wilson 20 Aug '19

20 Aug '19

The dma-fence selftest uses an on-stack timer that requires explicit annotation for debugobjects. Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/dma-buf/st-dma-fence.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c index 6fbae6bf6576..e593064341c8 100644 --- a/drivers/dma-buf/st-dma-fence.c +++ b/drivers/dma-buf/st-dma-fence.c @@ -373,7 +373,7 @@ static int test_wait_timeout(void *arg) struct wait_timer wt; int err = -EINVAL; - timer_setup(&wt.timer, wait_timer, 0); + timer_setup_on_stack(&wt.timer, wait_timer, 0); wt.f = mock_fence(); if (!wt.f) @@ -399,6 +399,7 @@ static int test_wait_timeout(void *arg) err = 0; err_free: del_timer_sync(&wt.timer); + destroy_timer_on_stack(&wt.timer); dma_fence_signal(wt.f); dma_fence_put(wt.f); return err; -- 2.23.0.rc1

1 0

[PATCH 0/2] Fix module name clash with omapdrm and DRM panel modules
by Laurent Pinchart 20 Aug '19

20 Aug '19

Hello, The patch series "[PATCH v4 0/9] DRM panel drivers for omapdrm" added new DRM panel drivers for a set of panels used on OMAP platforms, with the omapdrm and omapfb2 drivers. Both those drivers contain omap-specific panel drivers, which the new DRM panel drivers aims to replace for omapdrm. The new drivers use the same module name as the old ones (with one exception), resulting in module name clashes. This needs to be fixed separately for omapfb2 and omapdrm. For omapfb2, we can disable the omapfb2-specific panel drivers in Kconfig when the standard drivers are enabled. As omapfb2 and omapdrm are mutually exclusive, the DRM panel drivers are not useful with omapfb2 in any case. This is done in patch 1/2. For omapdrm, we can simply drop the omapdrm-specific panel drivers, as the new drivers replace them. This is done in patch 2/2, which was already part of the larger omapdrm patch series "[PATCH 00/60] drm/omap: Replace custom display drivers with drm_bridge and drm_panel". Laurent Pinchart (2): video: omapfb2: Make standard and custom panel drivers mutually exclusive drm/omap: displays: Remove unused panel drivers drivers/gpu/drm/omapdrm/displays/Kconfig | 38 - drivers/gpu/drm/omapdrm/displays/Makefile | 6 - .../displays/panel-lgphilips-lb035q02.c | 251 ------ .../omapdrm/displays/panel-nec-nl8048hl11.c | 271 ------- .../displays/panel-sharp-ls037v7dw01.c | 262 ------ .../omapdrm/displays/panel-sony-acx565akm.c | 755 ------------------ .../omapdrm/displays/panel-tpo-td028ttec1.c | 390 --------- .../omapdrm/displays/panel-tpo-td043mtea1.c | 513 ------------ .../gpu/drm/omapdrm/dss/omapdss-boot-init.c | 7 - .../video/fbdev/omap2/omapfb/displays/Kconfig | 5 + 10 files changed, 5 insertions(+), 2493 deletions(-) delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c -- Regards, Laurent Pinchart

5 14

[Bug 111441] sajal
by bugzilla-daemon＠freedesktop.org 20 Aug '19

20 Aug '19

https://bugs.freedesktop.org/show_bug.cgi?id=111441 Bug ID: 111441 Summary: sajal Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: sajal.verma(a)cotechsolutions.in Created attachment 145105 --> https://bugs.freedesktop.org/attachment.cgi?id=145105&action=edit readme 1. 2. 3. -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2019