dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming
by bugzilla-daemon＠freedesktop.org 23 Sep '19

23 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #105 from Rodney A Morris <rodamorris(a)gmail.com> --- Created attachment 145462 --> https://bugs.freedesktop.org/attachment.cgi?id=145462&action=edit dmesg from Stellaris crash 2019-09-20 I had another lockup on Friday while playing Stellaris again. This time I had the debug kernel running and the mesa debug packages installed. I do not plan to post dmesg and journalctl dumps for future crashes unless the logs indicate a new problem, or I can obtain more information than I previously provided. Like the crash I reported for Hearts of Iron IV, this Stellaris crash seems to be caused by a circular lock dependency. If someone believes my problems are caused by faulty hardware, please let me know. As an FYI, this problem does not seem to manifest under Windows 10, playing the same game. Card: Sapphire Radeon Vega 64 OS Info: /:-------------:\ :-------------------:: -------------------------------- :-----------/shhOHbmp---:\ OS: Fedora release 30 (Thirty) x86_64 /-----------omMMMNNNMMD ---: Kernel: 5.2.15-200.fc30.x86_64 :-----------sMMMMNMNMP. ---: Uptime: 1 day, 22 hours, 37 mins :-----------:MMMdP------- ---\ Packages: 2211 (rpm), 30 (flatpak) ,------------:MMMd-------- ---: Shell: bash 5.0.7 :------------:MMMd------- .---: Resolution: 2560x1440 :---- oNMMMMMMMMMNho .----: DE: GNOME 3.32.2 :-- .+shhhMMMmhhy++ .------/ WM: Mutter :- -------:MMMd--------------: WM Theme: Adwaita :- --------/MMMd-------------; Theme: Adapta-Nokto-Eta [GTK2/3] :- ------/hMMMy------------: Icons: Adwaita [GTK2/3] :-- :dMNdhhdNMMNo------------; Terminal: tilix :---:sdNMMMMNds:------------: CPU: Intel i7-6850K (12) @ 4.000GHz :------:://:-------------:: GPU: AMD ATI Radeon RX Vega 56/64 :---------------------:// Memory: 3097MiB / 32084MiB Mesa info: OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.1.6 Game being played: Stellaris through steam for Linux Native or Wine: Native Crash Type: Screen goes black suddenly while music continues plays for less than a minute; music begins to loop; and computer reboots. Full dmesg attached. Pertinent part of dmesg with debug kernel: [ 2383.732727] perf: interrupt took too long (2502 > 2500), lowering kernel.perf_event_max_sample_rate to 79000 [ 2923.530873] [drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out or interrupted! [ 2928.651952] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring page1 timeout, signaled seq=51954680, emitted seq=51954682 [ 2928.652090] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* Process information: process pid 0 thread pid 0 [ 2928.652098] amdgpu 0000:06:00.0: GPU reset begin! [ 2928.661852] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout, signaled seq=734676, emitted seq=734677 [ 2928.661898] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* Process information: process stellaris pid 5395 thread stellaris:cs0 pid 5397 [ 2928.661901] amdgpu 0000:06:00.0: GPU reset begin! [ 2928.661997] ====================================================== [ 2928.661999] WARNING: possible circular locking dependency detected [ 2928.662003] 5.2.15-200.fc30.x86_64+debug #1 Not tainted [ 2928.662005] ------------------------------------------------------ [ 2928.662007] kworker/10:2/974 is trying to acquire lock: [ 2928.662010] 00000000d514cf70 (&(&ring->fence_drv.lock)->rlock){-.-.}, at: dma_fence_remove_callback+0x1a/0x60 [ 2928.662021] but task is already holding lock: [ 2928.662023] 00000000e6ce7c0d (&(&sched->job_list_lock)->rlock){-.-.}, at: drm_sched_stop+0x34/0x130 [gpu_sched] [ 2928.662031] which lock already depends on the new lock. [ 2928.662033] the existing dependency chain (in reverse order) is: [ 2928.662035] -> #1 (&(&sched->job_list_lock)->rlock){-.-.}: [ 2928.662044] _raw_spin_lock_irqsave+0x49/0x83 [ 2928.662049] drm_sched_process_job+0x4d/0x180 [gpu_sched] [ 2928.662052] dma_fence_signal+0x111/0x1a0 [ 2928.662128] amdgpu_fence_process+0xa3/0x100 [amdgpu] [ 2928.662223] sdma_v4_0_process_trap_irq+0x8d/0xa0 [amdgpu] [ 2928.662310] amdgpu_irq_dispatch+0xc0/0x250 [amdgpu] [ 2928.662398] amdgpu_ih_process+0x8d/0x110 [amdgpu] [ 2928.662482] amdgpu_irq_handler+0x1b/0x50 [amdgpu] [ 2928.662487] __handle_irq_event_percpu+0x3f/0x290 [ 2928.662491] handle_irq_event_percpu+0x31/0x80 [ 2928.662495] handle_irq_event+0x34/0x51 [ 2928.662498] handle_edge_irq+0x83/0x1a0 [ 2928.662502] handle_irq+0x1c/0x30 [ 2928.662507] do_IRQ+0x61/0x120 [ 2928.662511] ret_from_intr+0x0/0x22 [ 2928.662517] cpuidle_enter_state+0xc9/0x450 [ 2928.662519] cpuidle_enter+0x29/0x40 [ 2928.662524] do_idle+0x1ec/0x280 [ 2928.662528] cpu_startup_entry+0x19/0x20 [ 2928.662531] start_secondary+0x189/0x1e0 [ 2928.662537] secondary_startup_64+0xa4/0xb0 [ 2928.662539] -> #0 (&(&ring->fence_drv.lock)->rlock){-.-.}: [ 2928.662548] lock_acquire+0xa2/0x1b0 [ 2928.662551] _raw_spin_lock_irqsave+0x49/0x83 [ 2928.662555] dma_fence_remove_callback+0x1a/0x60 [ 2928.662560] drm_sched_stop+0x59/0x130 [gpu_sched] [ 2928.662709] amdgpu_device_pre_asic_reset+0x41/0x20c [amdgpu] [ 2928.662866] amdgpu_device_gpu_recover+0x77/0x788 [amdgpu] [ 2928.663007] amdgpu_job_timedout+0x109/0x130 [amdgpu] [ 2928.663018] drm_sched_job_timedout+0x40/0x70 [gpu_sched] [ 2928.663024] process_one_work+0x272/0x5e0 [ 2928.663029] worker_thread+0x50/0x3b0 [ 2928.663037] kthread+0x108/0x140 [ 2928.663045] ret_from_fork+0x3a/0x50 [ 2928.663048] other info that might help us debug this: [ 2928.663051] Possible unsafe locking scenario: [ 2928.663055] CPU0 CPU1 [ 2928.663059] ---- ---- [ 2928.663062] lock(&(&sched->job_list_lock)->rlock); [ 2928.663068] lock(&(&ring->fence_drv.lock)->rlock); [ 2928.663072] lock(&(&sched->job_list_lock)->rlock); [ 2928.663076] lock(&(&ring->fence_drv.lock)->rlock); [ 2928.663080] *** DEADLOCK *** [ 2928.663085] 5 locks held by kworker/10:2/974: [ 2928.663090] #0: 0000000057c9a435 ((wq_completion)events){+.+.}, at: process_one_work+0x1e9/0x5e0 [ 2928.663100] #1: 00000000aadd5dda ((work_completion)(&(&sched->work_tdr)->work)){+.+.}, at: process_one_work+0x1e9/0x5e0 [ 2928.663108] #2: 0000000007db378b (&adev->lock_reset){+.+.}, at: amdgpu_device_lock_adev+0x17/0x39 [amdgpu] [ 2928.663261] #3: 000000001e0a2926 (&dqm->lock_hidden){+.+.}, at: kgd2kfd_pre_reset+0x30/0x60 [amdgpu] [ 2928.663392] #4: 00000000e6ce7c0d (&(&sched->job_list_lock)->rlock){-.-.}, at: drm_sched_stop+0x34/0x130 [gpu_sched] [ 2928.663403] stack backtrace: [ 2928.663409] CPU: 10 PID: 974 Comm: kworker/10:2 Not tainted 5.2.15-200.fc30.x86_64+debug #1 [ 2928.663413] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./X99 Taichi, BIOS P1.80 04/06/2018 [ 2928.663423] Workqueue: events drm_sched_job_timedout [gpu_sched] [ 2928.663428] Call Trace: [ 2928.663442] dump_stack+0x85/0xc0 [ 2928.663453] print_circular_bug.cold+0x15c/0x195 [ 2928.663462] __lock_acquire+0x167c/0x1c90 [ 2928.663475] lock_acquire+0xa2/0x1b0 [ 2928.663482] ? dma_fence_remove_callback+0x1a/0x60 [ 2928.663494] _raw_spin_lock_irqsave+0x49/0x83 [ 2928.663499] ? dma_fence_remove_callback+0x1a/0x60 [ 2928.663506] dma_fence_remove_callback+0x1a/0x60 [ 2928.663515] drm_sched_stop+0x59/0x130 [gpu_sched] [ 2928.663663] amdgpu_device_pre_asic_reset+0x41/0x20c [amdgpu] [ 2928.663818] amdgpu_device_gpu_recover+0x77/0x788 [amdgpu] [ 2928.663960] amdgpu_job_timedout+0x109/0x130 [amdgpu] [ 2928.663974] drm_sched_job_timedout+0x40/0x70 [gpu_sched] [ 2928.663981] process_one_work+0x272/0x5e0 [ 2928.663991] worker_thread+0x50/0x3b0 [ 2928.664000] kthread+0x108/0x140 [ 2928.664005] ? process_one_work+0x5e0/0x5e0 [ 2928.664011] ? kthread_park+0x80/0x80 [ 2928.664021] ret_from_fork+0x3a/0x50 [ 2928.681831] pcieport 0000:00:03.0: AER: Uncorrected (Non-Fatal) error received: 0000:00:03.0 [ 2928.681846] pcieport 0000:00:03.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) [ 2928.681851] pcieport 0000:00:03.0: AER: device [8086:6f08] error status/mask=00004000/00000000 [ 2928.681857] pcieport 0000:00:03.0: AER: [14] CmpltTO (First) [ 2928.681963] pcieport 0000:00:03.0: AER: Device recovery failed [ 2933.771664] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:47:crtc-0] flip_done timed out [ 2938.890758] [drm:amdgpu_dm_atomic_check [amdgpu]] *ERROR* [CRTC:47:crtc-0] hw_done or flip_done timed out [ 2939.118467] pcieport 0000:00:03.0: AER: Uncorrected (Non-Fatal) error received: 0000:00:03.0 [ 2939.118475] pcieport 0000:00:03.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) [ 2939.118477] pcieport 0000:00:03.0: AER: device [8086:6f08] error status/mask=00004000/00000000 [ 2939.118479] pcieport 0000:00:03.0: AER: [14] CmpltTO (First) [ 2939.118536] pcieport 0000:00:03.0: AER: Device recovery failed [ 2939.141034] pcieport 0000:00:03.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:03.0 [ 2939.369014] pcieport 0000:00:03.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) [ 2939.369018] pcieport 0000:00:03.0: AER: device [8086:6f08] error status/mask=00004000/00000000 [ 2939.369021] pcieport 0000:00:03.0: AER: [14] CmpltTO (First) [ 2939.369072] pcieport 0000:00:03.0: AER: Device recovery failed [ 2939.369075] pcieport 0000:00:03.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:03.0 [ 2939.597051] pcieport 0000:00:03.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) [ 2939.597055] pcieport 0000:00:03.0: AER: device [8086:6f08] error status/mask=00004000/00000000 [ 2939.597057] pcieport 0000:00:03.0: AER: [14] CmpltTO (First) [ 2939.597103] pcieport 0000:00:03.0: AER: Device recovery failed [ 2939.597106] pcieport 0000:00:03.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:03.0 systemd logs: Nothing interesting appears in the logs, not even the information from dmesg. I'm unsure if systemd captured anything from the crash. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming
by bugzilla-daemon＠freedesktop.org 23 Sep '19

23 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #104 from Rodney A Morris <rodamorris(a)gmail.com> --- (In reply to Mauro Gaspari from comment #103) > (In reply to Rodney A Morris from comment #101) > > (In reply to Rodney A Morris from comment #99) > > > Created attachment 145366 [details] > > > apitrace of Hearts of Iron IV hard lock > > > > > > Apitrace from hard lock playing Hearts of Iron IV without Steam. The replay > > > from this trace will hard lock the computer, though inconsistently. I've > > > replayed the trace three times. The replay hard locked computer one time. > > > > neofetch from hardlock: > > > > /:-------------:\ > > :-------------------:: -------------------------------- > > :-----------/shhOHbmp---:\ OS: Fedora release 30 (Thirty) x86_64 > > /-----------omMMMNNNMMD ---: Kernel: 5.2.13-200.fc30.x86_64 > > :-----------sMMMMNMNMP. ---: Uptime: 25 mins > > :-----------:MMMdP------- ---\ Packages: 2202 (rpm), 27 (flatpak) > > ,------------:MMMd-------- ---: Shell: bash 5.0.7 > > :------------:MMMd------- .---: Resolution: 2560x1440 > > :---- oNMMMMMMMMMNho .----: DE: GNOME 3.32.2 > > :-- .+shhhMMMmhhy++ .------/ WM: GNOME Shell > > :- -------:MMMd--------------: WM Theme: Adwaita > > :- --------/MMMd-------------; Theme: Adapta-Nokto-Eta [GTK2/3] > > :- ------/hMMMy------------: Icons: Adwaita [GTK2/3] > > :-- :dMNdhhdNMMNo------------; Terminal: tilix > > :---:sdNMMMMNds:------------: CPU: Intel i7-6850K (12) @ 4.000GHz > > :------:://:-------------:: GPU: AMD ATI Radeon RX Vega 56/64 > > :---------------------:// Memory: 2478MiB / 32084MiB > > > > OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.1.6 > > > > Note: hard lock replayed occurred when the Discord flatpak is also running. > > I also noticed some errors that pointed to discord in my logs. In my case > discord was installed via .deb package. > Could you please try and disable hardware acceleration in discord settings - > appearance menu? Please let me know if it helps or changes anything. > Thanks! I have disabled hardware acceleration in discord settings to see if that improves my experience and report back my results. I am doubtful that it will help much. At least on the 5.2.11 kernel, I had lockups with or without discord running. Discord running just seemed to make the problem appear more consistently. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/vkms: Fix an undefined reference error in vkms_composer_worker
by zhong jiang 23 Sep '19

23 Sep '19

From: YueHaibing <yuehaibing(a)huawei.com> I hit the following error when compile the kernel. drivers/gpu/drm/vkms/vkms_composer.o: In function `vkms_composer_worker': vkms_composer.c:(.text+0x5e4): undefined reference to `crc32_le' make: *** [vmlinux] Error 1 Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> Signed-off-by: zhong jiang <zhongjiang(a)huawei.com> --- drivers/gpu/drm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index e67c194..285d649 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -257,6 +257,7 @@ config DRM_VKMS tristate "Virtual KMS (EXPERIMENTAL)" depends on DRM select DRM_KMS_HELPER + select CRC32 default n help Virtual Kernel Mode-Setting (VKMS) is used for testing or for -- 1.7.12.4

1 1

[PATCH AUTOSEL 4.9 57/60] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)
by Sasha Levin 22 Sep '19

22 Sep '19

From: Ahzo <Ahzo(a)tutanota.com> [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan <evan.quan(a)amd.com> Signed-off-by: Ahzo <Ahzo(a)tutanota.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 3907439417e76..c0db3b57dfe58 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -3739,6 +3739,11 @@ int smu7_program_display_gap(struct pp_hwmgr *hwmgr) data->frame_time_x2 = frame_time_in_us * 2 / 100; + if (data->frame_time_x2 < 280) { + pr_debug("%s: enforce minimal VBITimeout: %d -> 280\n", __func__, data->frame_time_x2); + data->frame_time_x2 = 280; + } + display_gap2 = pre_vbi_time_in_us * (ref_clock / 100); cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCG_DISPLAY_GAP_CNTL2, display_gap2); -- 2.20.1

1 0

[PATCH AUTOSEL 4.14 86/89] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)
by Sasha Levin 22 Sep '19

22 Sep '19

From: Ahzo <Ahzo(a)tutanota.com> [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan <evan.quan(a)amd.com> Signed-off-by: Ahzo <Ahzo(a)tutanota.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 336fdd8c7db08..61141bc3edfe9 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -3972,6 +3972,11 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr) data->frame_time_x2 = frame_time_in_us * 2 / 100; + if (data->frame_time_x2 < 280) { + pr_debug("%s: enforce minimal VBITimeout: %d -> 280\n", __func__, data->frame_time_x2); + data->frame_time_x2 = 280; + } + display_gap2 = pre_vbi_time_in_us * (ref_clock / 100); cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCG_DISPLAY_GAP_CNTL2, display_gap2); -- 2.20.1

1 0

[PATCH AUTOSEL 4.19 124/128] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)
by Sasha Levin 22 Sep '19

22 Sep '19

From: Ahzo <Ahzo(a)tutanota.com> [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan <evan.quan(a)amd.com> Signed-off-by: Ahzo <Ahzo(a)tutanota.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index b52ccab428a9e..c7c505095402d 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -4052,6 +4052,11 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr) data->frame_time_x2 = frame_time_in_us * 2 / 100; + if (data->frame_time_x2 < 280) { + pr_debug("%s: enforce minimal VBITimeout: %d -> 280\n", __func__, data->frame_time_x2); + data->frame_time_x2 = 280; + } + display_gap2 = pre_vbi_time_in_us * (ref_clock / 100); cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCG_DISPLAY_GAP_CNTL2, display_gap2); -- 2.20.1

1 0

[PATCH AUTOSEL 5.2 177/185] drm: fix module name in edid_firmware log message
by Sasha Levin 22 Sep '19

22 Sep '19

From: Jani Nikula <jani.nikula(a)intel.com> [ Upstream commit ade925995b172f1d7410d1c665b2f47c5e99bef0 ] The module is drm_kms_helper, not drm_kms_firmware. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204549 Reported-by: Göran Uddeborg <goeran(a)uddeborg.se> Fixes: ac6c35a4d8c7 ("drm: add backwards compatibility support for drm_kms_helper.edid_firmware") Reviewed-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190821094312.5514-1-jani.ni… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c index 9c5ae825c5078..69917ecd4af67 100644 --- a/drivers/gpu/drm/drm_kms_helper_common.c +++ b/drivers/gpu/drm/drm_kms_helper_common.c @@ -39,7 +39,7 @@ MODULE_LICENSE("GPL and additional rights"); /* Backward compatibility for drm_kms_helper.edid_firmware */ static int edid_firmware_set(const char *val, const struct kernel_param *kp) { - DRM_NOTE("drm_kms_firmware.edid_firmware is deprecated, please use drm.edid_firmware instead.\n"); + DRM_NOTE("drm_kms_helper.edid_firmware is deprecated, please use drm.edid_firmware instead.\n"); return __drm_set_edid_firmware_path(val); } -- 2.20.1

1 0

[PATCH AUTOSEL 5.2 175/185] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)
by Sasha Levin 22 Sep '19

22 Sep '19

From: Ahzo <Ahzo(a)tutanota.com> [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan <evan.quan(a)amd.com> Signed-off-by: Ahzo <Ahzo(a)tutanota.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 048757e8f4949..d1919d343cce4 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -4064,6 +4064,11 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr) data->frame_time_x2 = frame_time_in_us * 2 / 100; + if (data->frame_time_x2 < 280) { + pr_debug("%s: enforce minimal VBITimeout: %d -> 280\n", __func__, data->frame_time_x2); + data->frame_time_x2 = 280; + } + display_gap2 = pre_vbi_time_in_us * (ref_clock / 100); cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCG_DISPLAY_GAP_CNTL2, display_gap2); -- 2.20.1

1 0

Re: [PATCH v6 2/2] drm/bridge: Add NWL MIPI DSI host controller support (fwd)
by Julia Lawall 22 Sep '19

22 Sep '19

Hello, Color_format is unsigned, so it won't be less than 0 on line 272. julia ---------- Forwarded message ---------- Date: Mon, 23 Sep 2019 02:29:34 +0800 From: kbuild test robot <lkp(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: Re: [PATCH v6 2/2] drm/bridge: Add NWL MIPI DSI host controller support CC: kbuild-all(a)01.org In-Reply-To: <c0ac0b203fb65ae7efd1b9b54664b491ca2fb157.1569170717.git.agx(a)sigxcpu.org> References: <c0ac0b203fb65ae7efd1b9b54664b491ca2fb157.1569170717.git.agx(a)sigxcpu.org> TO: "Guido Günther" <agx(a)sigxcpu.org> CC: Hi "Guido, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Guido-G-nther/drm-bridge-Add-NWL-M… :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> Reported-by: Julia Lawall <julia.lawall(a)lip6.fr> >> drivers/gpu/drm/bridge/nwl-dsi.c:272:5-17: WARNING: Unsigned expression compared with zero: color_format < 0 # https://github.com/0day-ci/linux/commit/060069512cb50e3218b55005b6cc92b82e0… git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 060069512cb50e3218b55005b6cc92b82e0a7856 vim +272 drivers/gpu/drm/bridge/nwl-dsi.c 060069512cb50e Guido Günther 2019-09-22 245 060069512cb50e Guido Günther 2019-09-22 246 static int nwl_dsi_config_dpi(struct nwl_dsi *dsi) 060069512cb50e Guido Günther 2019-09-22 247 { 060069512cb50e Guido Günther 2019-09-22 248 u32 color_format, mode; 060069512cb50e Guido Günther 2019-09-22 249 bool burst_mode; 060069512cb50e Guido Günther 2019-09-22 250 int hfront_porch, hback_porch, vfront_porch, vback_porch; 060069512cb50e Guido Günther 2019-09-22 251 int hsync_len, vsync_len; 060069512cb50e Guido Günther 2019-09-22 252 060069512cb50e Guido Günther 2019-09-22 253 hfront_porch = dsi->mode.hsync_start - dsi->mode.hdisplay; 060069512cb50e Guido Günther 2019-09-22 254 hsync_len = dsi->mode.hsync_end - dsi->mode.hsync_start; 060069512cb50e Guido Günther 2019-09-22 255 hback_porch = dsi->mode.htotal - dsi->mode.hsync_end; 060069512cb50e Guido Günther 2019-09-22 256 060069512cb50e Guido Günther 2019-09-22 257 vfront_porch = dsi->mode.vsync_start - dsi->mode.vdisplay; 060069512cb50e Guido Günther 2019-09-22 258 vsync_len = dsi->mode.vsync_end - dsi->mode.vsync_start; 060069512cb50e Guido Günther 2019-09-22 259 vback_porch = dsi->mode.vtotal - dsi->mode.vsync_end; 060069512cb50e Guido Günther 2019-09-22 260 060069512cb50e Guido Günther 2019-09-22 261 DRM_DEV_DEBUG_DRIVER(dsi->dev, "hfront_porch = %d\n", hfront_porch); 060069512cb50e Guido Günther 2019-09-22 262 DRM_DEV_DEBUG_DRIVER(dsi->dev, "hback_porch = %d\n", hback_porch); 060069512cb50e Guido Günther 2019-09-22 263 DRM_DEV_DEBUG_DRIVER(dsi->dev, "hsync_len = %d\n", hsync_len); 060069512cb50e Guido Günther 2019-09-22 264 DRM_DEV_DEBUG_DRIVER(dsi->dev, "hdisplay = %d\n", dsi->mode.hdisplay); 060069512cb50e Guido Günther 2019-09-22 265 DRM_DEV_DEBUG_DRIVER(dsi->dev, "vfront_porch = %d\n", vfront_porch); 060069512cb50e Guido Günther 2019-09-22 266 DRM_DEV_DEBUG_DRIVER(dsi->dev, "vback_porch = %d\n", vback_porch); 060069512cb50e Guido Günther 2019-09-22 267 DRM_DEV_DEBUG_DRIVER(dsi->dev, "vsync_len = %d\n", vsync_len); 060069512cb50e Guido Günther 2019-09-22 268 DRM_DEV_DEBUG_DRIVER(dsi->dev, "vactive = %d\n", dsi->mode.vdisplay); 060069512cb50e Guido Günther 2019-09-22 269 DRM_DEV_DEBUG_DRIVER(dsi->dev, "clock = %d kHz\n", dsi->mode.clock); 060069512cb50e Guido Günther 2019-09-22 270 060069512cb50e Guido Günther 2019-09-22 271 color_format = nwl_dsi_get_dpi_pixel_format(dsi->format); 060069512cb50e Guido Günther 2019-09-22 @272 if (color_format < 0) { 060069512cb50e Guido Günther 2019-09-22 273 DRM_DEV_ERROR(dsi->dev, "Invalid color format 0x%x\n", 060069512cb50e Guido Günther 2019-09-22 274 dsi->format); 060069512cb50e Guido Günther 2019-09-22 275 return color_format; 060069512cb50e Guido Günther 2019-09-22 276 } 060069512cb50e Guido Günther 2019-09-22 277 DRM_DEV_DEBUG_DRIVER(dsi->dev, "pixel fmt = %d\n", dsi->format); 060069512cb50e Guido Günther 2019-09-22 278 060069512cb50e Guido Günther 2019-09-22 279 nwl_dsi_write(dsi, NWL_DSI_INTERFACE_COLOR_CODING, NWL_DSI_DPI_24_BIT); 060069512cb50e Guido Günther 2019-09-22 280 nwl_dsi_write(dsi, NWL_DSI_PIXEL_FORMAT, color_format); 060069512cb50e Guido Günther 2019-09-22 281 /* 060069512cb50e Guido Günther 2019-09-22 282 * Adjusting input polarity based on the video mode results in 060069512cb50e Guido Günther 2019-09-22 283 * a black screen so always pick active low: 060069512cb50e Guido Günther 2019-09-22 284 */ 060069512cb50e Guido Günther 2019-09-22 285 nwl_dsi_write(dsi, NWL_DSI_VSYNC_POLARITY, 060069512cb50e Guido Günther 2019-09-22 286 NWL_DSI_VSYNC_POLARITY_ACTIVE_LOW); 060069512cb50e Guido Günther 2019-09-22 287 nwl_dsi_write(dsi, NWL_DSI_HSYNC_POLARITY, 060069512cb50e Guido Günther 2019-09-22 288 NWL_DSI_HSYNC_POLARITY_ACTIVE_LOW); 060069512cb50e Guido Günther 2019-09-22 289 060069512cb50e Guido Günther 2019-09-22 290 burst_mode = (dsi->dsi_mode_flags & MIPI_DSI_MODE_VIDEO_BURST) && 060069512cb50e Guido Günther 2019-09-22 291 !(dsi->dsi_mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE); 060069512cb50e Guido Günther 2019-09-22 292 060069512cb50e Guido Günther 2019-09-22 293 if (burst_mode) { 060069512cb50e Guido Günther 2019-09-22 294 nwl_dsi_write(dsi, NWL_DSI_VIDEO_MODE, NWL_DSI_VM_BURST_MODE); 060069512cb50e Guido Günther 2019-09-22 295 nwl_dsi_write(dsi, NWL_DSI_PIXEL_FIFO_SEND_LEVEL, 256); 060069512cb50e Guido Günther 2019-09-22 296 } else { 060069512cb50e Guido Günther 2019-09-22 297 mode = ((dsi->dsi_mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) ? 060069512cb50e Guido Günther 2019-09-22 298 NWL_DSI_VM_BURST_MODE_WITH_SYNC_PULSES : 060069512cb50e Guido Günther 2019-09-22 299 NWL_DSI_VM_NON_BURST_MODE_WITH_SYNC_EVENTS); 060069512cb50e Guido Günther 2019-09-22 300 nwl_dsi_write(dsi, NWL_DSI_VIDEO_MODE, mode); 060069512cb50e Guido Günther 2019-09-22 301 nwl_dsi_write(dsi, NWL_DSI_PIXEL_FIFO_SEND_LEVEL, 060069512cb50e Guido Günther 2019-09-22 302 dsi->mode.hdisplay); 060069512cb50e Guido Günther 2019-09-22 303 } 060069512cb50e Guido Günther 2019-09-22 304 060069512cb50e Guido Günther 2019-09-22 305 nwl_dsi_write(dsi, NWL_DSI_HFP, hfront_porch); 060069512cb50e Guido Günther 2019-09-22 306 nwl_dsi_write(dsi, NWL_DSI_HBP, hback_porch); 060069512cb50e Guido Günther 2019-09-22 307 nwl_dsi_write(dsi, NWL_DSI_HSA, hsync_len); 060069512cb50e Guido Günther 2019-09-22 308 060069512cb50e Guido Günther 2019-09-22 309 nwl_dsi_write(dsi, NWL_DSI_ENABLE_MULT_PKTS, 0x0); 060069512cb50e Guido Günther 2019-09-22 310 nwl_dsi_write(dsi, NWL_DSI_BLLP_MODE, 0x1); 060069512cb50e Guido Günther 2019-09-22 311 nwl_dsi_write(dsi, NWL_DSI_USE_NULL_PKT_BLLP, 0x0); 060069512cb50e Guido Günther 2019-09-22 312 nwl_dsi_write(dsi, NWL_DSI_VC, 0x0); 060069512cb50e Guido Günther 2019-09-22 313 060069512cb50e Guido Günther 2019-09-22 314 nwl_dsi_write(dsi, NWL_DSI_PIXEL_PAYLOAD_SIZE, dsi->mode.hdisplay); 060069512cb50e Guido Günther 2019-09-22 315 nwl_dsi_write(dsi, NWL_DSI_VACTIVE, dsi->mode.vdisplay - 1); 060069512cb50e Guido Günther 2019-09-22 316 nwl_dsi_write(dsi, NWL_DSI_VBP, vback_porch); 060069512cb50e Guido Günther 2019-09-22 317 nwl_dsi_write(dsi, NWL_DSI_VFP, vfront_porch); 060069512cb50e Guido Günther 2019-09-22 318 060069512cb50e Guido Günther 2019-09-22 319 return 0; 060069512cb50e Guido Günther 2019-09-22 320 } 060069512cb50e Guido Günther 2019-09-22 321 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH AUTOSEL 5.3 195/203] drm: fix module name in edid_firmware log message
by Sasha Levin 22 Sep '19

22 Sep '19

From: Jani Nikula <jani.nikula(a)intel.com> [ Upstream commit ade925995b172f1d7410d1c665b2f47c5e99bef0 ] The module is drm_kms_helper, not drm_kms_firmware. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204549 Reported-by: Göran Uddeborg <goeran(a)uddeborg.se> Fixes: ac6c35a4d8c7 ("drm: add backwards compatibility support for drm_kms_helper.edid_firmware") Reviewed-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190821094312.5514-1-jani.ni… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c index d9a5ac81949e2..221a8528c9937 100644 --- a/drivers/gpu/drm/drm_kms_helper_common.c +++ b/drivers/gpu/drm/drm_kms_helper_common.c @@ -40,7 +40,7 @@ MODULE_LICENSE("GPL and additional rights"); /* Backward compatibility for drm_kms_helper.edid_firmware */ static int edid_firmware_set(const char *val, const struct kernel_param *kp) { - DRM_NOTE("drm_kms_firmware.edid_firmware is deprecated, please use drm.edid_firmware instead.\n"); + DRM_NOTE("drm_kms_helper.edid_firmware is deprecated, please use drm.edid_firmware instead.\n"); return __drm_set_edid_firmware_path(val); } -- 2.20.1

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019