dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH AUTOSEL 5.3 193/203] drm/amd/powerplay/smu7: enforce minimal VBITimeout (v2)
by Sasha Levin 22 Sep '19

22 Sep '19

From: Ahzo <Ahzo(a)tutanota.com> [ Upstream commit f659bb6dae58c113805f92822e4c16ddd3156b79 ] This fixes screen corruption/flickering on 75 Hz displays. v2: make print statement debug only (Alex) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102646 Reviewed-by: Evan Quan <evan.quan(a)amd.com> Signed-off-by: Ahzo <Ahzo(a)tutanota.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 487aeee1cf8a5..3c1084de5d59f 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -4068,6 +4068,11 @@ static int smu7_program_display_gap(struct pp_hwmgr *hwmgr) data->frame_time_x2 = frame_time_in_us * 2 / 100; + if (data->frame_time_x2 < 280) { + pr_debug("%s: enforce minimal VBITimeout: %d -> 280\n", __func__, data->frame_time_x2); + data->frame_time_x2 = 280; + } + display_gap2 = pre_vbi_time_in_us * (ref_clock / 100); cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, ixCG_DISPLAY_GAP_CNTL2, display_gap2); -- 2.20.1

1 0

[RFC v3 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework
by Brendan Higgins 21 Sep '19

21 Sep '19

This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM and does not require tests to be written in userspace running on a host kernel. Additionally, KUnit is fast: From invocation to completion KUnit can run several dozen tests in under a second. Currently, the entire KUnit test suite for KUnit runs in under a second from the initial invocation (build time excluded). KUnit is heavily inspired by JUnit, Python's unittest.mock, and Googletest/Googlemock for C++. KUnit provides facilities for defining unit test cases, grouping related test cases into test suites, providing common infrastructure for running tests, mocking, spying, and much more. ## What's so special about unit testing? A unit test is supposed to test a single unit of code in isolation, hence the name. There should be no dependencies outside the control of the test; this means no external dependencies, which makes tests orders of magnitudes faster. Likewise, since there are no external dependencies, there are no hoops to jump through to run the tests. Additionally, this makes unit tests deterministic: a failing unit test always indicates a problem. Finally, because unit tests necessarily have finer granularity, they are able to test all code paths easily solving the classic problem of difficulty in exercising error handling code. ## Is KUnit trying to replace other testing frameworks for the kernel? No. Most existing tests for the Linux kernel are end-to-end tests, which have their place. A well tested system has lots of unit tests, a reasonable number of integration tests, and some end-to-end tests. KUnit is just trying to address the unit test space which is currently not being addressed. ## More information on KUnit There is a bunch of documentation near the end of this patch set that describes how to use KUnit and best practices for writing unit tests. For convenience I am hosting the compiled docs here: https://google.github.io/kunit-docs/third_party/kernel/docs/ Additionally for convenience, I have applied these patches to a branch: https://kunit.googlesource.com/linux/+/kunit/rfc/4.19/v3 The repo may be cloned with: git clone https://kunit.googlesource.com/linux This patchset is on the kunit/rfc/4.19/v3 branch. ## Changes Since Last Version - Changed namespace prefix from `test_*` to `kunit_*` as requested by Shuah. - Started converting/cleaning up the device tree unittest to use KUnit. - Started adding KUnit expectations with custom messages. -- 2.20.0.rc0.387.gc7a69e6b6c-goog

11 113

[PATCH] drm/tegra: vic: Use devm_platform_ioremap_resource() in vic_probe()
by Markus Elfring 21 Sep '19

21 Sep '19

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 21 Sep 2019 20:51:52 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/tegra/vic.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c index cd0399fd8c63..bc72d326588b 100644 --- a/drivers/gpu/drm/tegra/vic.c +++ b/drivers/gpu/drm/tegra/vic.c @@ -370,7 +370,6 @@ static int vic_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct host1x_syncpt **syncpts; - struct resource *regs; struct vic *vic; int err; @@ -384,13 +383,7 @@ static int vic_probe(struct platform_device *pdev) if (!syncpts) return -ENOMEM; - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!regs) { - dev_err(&pdev->dev, "failed to get registers\n"); - return -ENXIO; - } - - vic->regs = devm_ioremap_resource(dev, regs); + vic->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(vic->regs)) return PTR_ERR(vic->regs); -- 2.23.0

1 0

[PATCH v3] drm: panel-lvds: Potential Oops in probe error handling
by Dan Carpenter 21 Sep '19

21 Sep '19

The "lvds->backlight" pointer could be NULL in situations where of_parse_phandle() returns NULL. This code is cleaner if we use the managed devm_of_find_backlight() so the clean up is automatic. Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- v3: Use devm_of_find_backlight(). This version is quite a bit more ambitious, and I haven't tested it so please review carefully. v2: Use backlight_put() drivers/gpu/drm/panel/panel-lvds.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index ad47cc95459e..bf5fcc3e5379 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -197,7 +197,6 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) static int panel_lvds_probe(struct platform_device *pdev) { struct panel_lvds *lvds; - struct device_node *np; int ret; lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL); @@ -243,14 +242,9 @@ static int panel_lvds_probe(struct platform_device *pdev) return ret; } - np = of_parse_phandle(lvds->dev->of_node, "backlight", 0); - if (np) { - lvds->backlight = of_find_backlight_by_node(np); - of_node_put(np); - - if (!lvds->backlight) - return -EPROBE_DEFER; - } + lvds->backlight = devm_of_find_backlight(lvds->dev); + if (IS_ERR(lvds->backlight)) + return PTR_ERR(lvds->backlight); /* * TODO: Handle all power supplies specified in the DT node in a generic @@ -266,14 +260,10 @@ static int panel_lvds_probe(struct platform_device *pdev) ret = drm_panel_add(&lvds->panel); if (ret < 0) - goto error; + return ret; dev_set_drvdata(lvds->dev, lvds); return 0; - -error: - put_device(&lvds->backlight->dev); - return ret; } static int panel_lvds_remove(struct platform_device *pdev) @@ -284,9 +274,6 @@ static int panel_lvds_remove(struct platform_device *pdev) panel_lvds_disable(&lvds->panel); - if (lvds->backlight) - put_device(&lvds->backlight->dev); - return 0; } -- 2.20.1

2 1

[GIT PULL] Please pull hmm related changes
by Jason Gunthorpe 21 Sep '19

21 Sep '19

Hi Linus, Continuing on the cleanup theme from last merge window, here is another set of hmm and closely related patches that are largely cleanups and bug fixes without any particularly notable functional change. The diffstat below covers a wide section of the kernel, but a lot of this is caused by Christoph's series to revise the page walker API. After discussion we opted to put that series into this tree to avoid conflicts/etc. Otherwise this is a pleasant reduction in LOC. Although we continue to try to get reviews, we once again have not got too many Acks from core mm people. However the users of these APIs have again contributed a fair number of acks, reviews and tests. I am aware of no conflicts this cycle, however Andrew has several smaller patches queued waiting on changes in here. Included is a branch shared with rdma.git fixing up ODP enough to allow the get/put transformation. For next merge window I already see there are patches posted to add a test suite for hmm_range_fault() and fix bugs, I am working on a series to harmonize the mmu notifier & interval tree pattern, and also to get ODP using hmm_range_fault(). I think we will need to do this tree at least one more time. Thanks, Jason The following changes since commit 27b7fb1ab7bfad45f5702ff0c78a4822a41b1456: RDMA/mlx5: Fix MR npages calculation for IB_ACCESS_HUGETLB (2019-08-20 13:44:43 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus-hmm for you to fetch changes up to 62974fc389b364d8af70e044836362222bd3ae53: libnvdimm: Enable unit test infrastructure compile checks (2019-09-07 04:28:05 -0300) ---------------------------------------------------------------- hmm related patches for 5.4 This is more cleanup and consolidation of the hmm APIs and the very strongly related mmu_notifier interfaces. Many places across the tree using these interfaces are touched in the process. Beyond that a cleanup to the page walker API and a few memremap related changes round out the series: - General improvement of hmm_range_fault() and related APIs, more documentation, bug fixes from testing, API simplification & consolidation, and unused API removal - Simplify the hmm related kconfigs to HMM_MIRROR and DEVICE_PRIVATE, and make them internal kconfig selects - Hoist a lot of code related to mmu notifier attachment out of drivers by using a refcount get/put attachment idiom and remove the convoluted mmu_notifier_unregister_no_release() and related APIs. - General API improvement for the migrate_vma API and revision of its only user in nouveau - Annotate mmu_notifiers with lockdep and sleeping region debugging Two series unrelated to HMM or mmu_notifiers came along due to dependencies: - Allow pagemap's memremap_pages family of APIs to work without providing a struct device - Make walk_page_range() and related use a constant structure for function pointers ---------------------------------------------------------------- Christoph Hellwig (35): nouveau: return -EBUSY when hmm_range_wait_until_valid fails mm/hmm: remove the legacy hmm_pfn_* APIs mm/hmm: replace the block argument to hmm_range_fault with a flags value mm/hmm: merge hmm_range_snapshot into hmm_range_fault amdgpu: remove -EAGAIN handling for hmm_range_fault amdgpu: don't initialize range->list in amdgpu_hmm_init_range nouveau: pass struct nouveau_svmm to nouveau_range_fault mm/hmm: remove the unused vma argument to hmm_range_dma_unmap mm/hmm: remove superfluous arguments from hmm_range_register mm/hmm: remove the page_shift member from struct hmm_range mm/hmm: remove the mask variable in hmm_vma_walk_hugetlb_entry mm/hmm: don't abuse pte_index() in hmm_vma_handle_pmd mm/hmm: only define hmm_vma_walk_pud if needed mm/hmm: cleanup the hmm_vma_handle_pmd stub mm/hmm: cleanup the hmm_vma_walk_hugetlb_entry stub mm/hmm: allow HMM_MIRROR on all architectures with MMU mm/hmm: make HMM_MIRROR an implicit option mm: turn migrate_vma upside down nouveau: reset dma_nr in nouveau_dmem_migrate_alloc_and_copy nouveau: factor out device memory address calculation nouveau: factor out dmem fence completion nouveau: remove a few function stubs nouveau: simplify nouveau_dmem_migrate_to_ram nouveau: simplify nouveau_dmem_migrate_vma mm: remove the unused MIGRATE_PFN_ERROR flag mm: remove the unused MIGRATE_PFN_DEVICE flag mm: remove CONFIG_MIGRATE_VMA_HELPER resource: add a not device managed request_free_mem_region variant memremap: remove the dev field in struct dev_pagemap memremap: don't use a separate devm action for devmap_managed_enable_get memremap: provide a not device managed memremap_pages mm/mmu_notifiers: remove the __mmu_notifier_invalidate_range_start/end exports mm: split out a new pagewalk.h header from mm.h pagewalk: separate function pointers from iterator data pagewalk: use lockdep_assert_held for locking validation Dan Williams (1): libnvdimm: Enable unit test infrastructure compile checks Daniel Vetter (6): mm/mmu_notifiers: check if mmu notifier callbacks are allowed to fail mm/mmu_notifiers: add a lockdep map for invalidate_range_start/end mm/mmu_notifiers: prime lockdep mm/mmu_notifiers: annotate with might_sleep() kernel.h: Add non_block_start/end() mm, notifier: Catch sleeping/blocking for !blockable Jason Gunthorpe (27): mm/hmm: comment on VM_FAULT_RETRY semantics in handle_mm_fault mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller mm/mmu_notifiers: do not speculatively allocate a mmu_notifier_mm mm/mmu_notifiers: add a get/put scheme for the registration misc/sgi-gru: use mmu_notifier_get/put for struct gru_mm_struct hmm: use mmu_notifier_get/put for 'struct hmm' drm/radeon: use mmu_notifier_get/put for struct radeon_mn drm/amdkfd: fix a use after free race with mmu_notifer unregister drm/amdkfd: use mmu_notifier_put Merge 'notifier_get_put' into hmm.git RDMA/odp: Use the common interval tree library instead of generic RDMA/odp: Iterate over the whole rbtree directly RDMA/odp: Make it clearer when a umem is an implicit ODP umem RMDA/odp: Consolidate umem_odp initialization RDMA/odp: Make the three ways to create a umem_odp clear RDMA/odp: Split creating a umem_odp from ib_umem_get RDMA/odp: Provide ib_umem_odp_release() to undo the allocs RDMA/odp: Check for overflow when computing the umem_odp end RDMA/odp: Use kvcalloc for the dma_list and page_list RDMA/mlx5: Use ib_umem_start instead of umem.address RDMA/mlx5: Use odp instead of mr->umem in pagefault_mr Merge branch 'odp_fixes' into hmm.git RDMA/odp: use mmu_notifier_get/put for 'struct ib_ucontext_per_mm' RDMA/odp: remove ib_ucontext from ib_umem mm/mmu_notifiers: remove unregister_no_release csky: add missing brackets in a macro for tlb.h drm/radeon: guard against calling an unpaired radeon_mn_unregister() Moni Shoua (1): RDMA/core: Make invalidate_range a device operation Ralph Campbell (6): mm/hmm: replace hmm_update with mmu_notifier_range mm/hmm: a few more C style and comment clean ups mm/hmm: remove hugetlbfs check in hmm_vma_walk_pmd mm/hmm: remove hmm_range vma mm/hmm: hmm_range_fault() NULL pointer bug mm/hmm: hmm_range_fault() infinite loop Yang, Philip (1): mm/hmm: fix hmm_range_fault()'s handling of swapped out pages Documentation/vm/hmm.rst | 73 +---- arch/csky/include/asm/tlb.h | 8 +- arch/openrisc/kernel/dma.c | 23 +- arch/powerpc/mm/book3s64/subpage_prot.c | 12 +- arch/s390/mm/gmap.c | 35 +-- drivers/gpu/drm/amd/amdgpu/Kconfig | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 15 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 31 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 - drivers/gpu/drm/amd/amdkfd/kfd_process.c | 88 +++--- drivers/gpu/drm/nouveau/Kconfig | 5 +- drivers/gpu/drm/nouveau/nouveau_dmem.c | 456 +++++++++------------------ drivers/gpu/drm/nouveau/nouveau_dmem.h | 11 - drivers/gpu/drm/nouveau/nouveau_drm.c | 3 + drivers/gpu/drm/nouveau/nouveau_svm.c | 23 +- drivers/gpu/drm/radeon/radeon.h | 3 - drivers/gpu/drm/radeon/radeon_device.c | 2 - drivers/gpu/drm/radeon/radeon_drv.c | 2 + drivers/gpu/drm/radeon/radeon_mn.c | 156 +++------ drivers/infiniband/Kconfig | 1 + drivers/infiniband/core/device.c | 1 + drivers/infiniband/core/umem.c | 54 +--- drivers/infiniband/core/umem_odp.c | 524 +++++++++++++++---------------- drivers/infiniband/core/uverbs_cmd.c | 5 - drivers/infiniband/core/uverbs_main.c | 1 + drivers/infiniband/hw/mlx5/main.c | 9 - drivers/infiniband/hw/mlx5/mem.c | 13 - drivers/infiniband/hw/mlx5/mr.c | 38 ++- drivers/infiniband/hw/mlx5/odp.c | 88 +++--- drivers/misc/sgi-gru/grufile.c | 1 + drivers/misc/sgi-gru/grutables.h | 2 - drivers/misc/sgi-gru/grutlbpurge.c | 84 ++--- drivers/nvdimm/Kconfig | 12 + drivers/nvdimm/Makefile | 4 + fs/proc/task_mmu.c | 80 ++--- include/linux/hmm.h | 125 ++------ include/linux/ioport.h | 2 + include/linux/kernel.h | 23 +- include/linux/memremap.h | 3 +- include/linux/migrate.h | 120 ++----- include/linux/mm.h | 46 --- include/linux/mm_types.h | 6 - include/linux/mmu_notifier.h | 59 +++- include/linux/pagewalk.h | 66 ++++ include/linux/sched.h | 4 + include/rdma/ib_umem.h | 2 +- include/rdma/ib_umem_odp.h | 58 ++-- include/rdma/ib_verbs.h | 7 +- kernel/fork.c | 1 - kernel/resource.c | 45 ++- kernel/sched/core.c | 19 +- mm/Kconfig | 20 +- mm/hmm.c | 490 +++++++++-------------------- mm/madvise.c | 42 +-- mm/memcontrol.c | 25 +- mm/mempolicy.c | 17 +- mm/memremap.c | 105 ++++--- mm/migrate.c | 276 ++++++++-------- mm/mincore.c | 17 +- mm/mmu_notifier.c | 263 ++++++++++++---- mm/mprotect.c | 26 +- mm/page_alloc.c | 2 +- mm/pagewalk.c | 126 ++++---- tools/testing/nvdimm/test/iomap.c | 1 - 65 files changed, 1684 insertions(+), 2184 deletions(-) create mode 100644 include/linux/pagewalk.h

2 1

[Bug 111759] [navi10] computer hang ring sdma1 timeout
by bugzilla-daemon＠freedesktop.org 21 Sep '19

21 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=111759 Bug ID: 111759 Summary: [navi10] computer hang ring sdma1 timeout Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: not set Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: kingoipo(a)gmail.com Using the soon-to-be linux 5.4.0-rc1 (574cc4539762561d96b456dbc0544d8898bd4c6e) with oibaf's ppa for DRI, I get the following messages in my kernel.log: Sep 20 18:12:19 oipo-X570-AORUS-ELITE kernel: [23162.876229] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma1 timeout, signaled seq=140067, emitted seq=140070 Sep 20 18:12:19 oipo-X570-AORUS-ELITE kernel: [23162.876310] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* Process information: process GPU Process pid 16418 thread firefox:cs0 pid 16498 Sep 20 18:12:19 oipo-X570-AORUS-ELITE kernel: [23162.876312] [drm] GPU recovery disabled. Music stops playing, desktop becomes completely unresponsive except for mouse. Mouse can be moved normally. Hardware: Radeon RX 5700 -- You are receiving this mail because: You are the assignee for the bug.

1 3

[PATCH] UNCLEAN: fix semicolon.cocci warnings
by Julia Lawall 21 Sep '19

21 Sep '19

From: kbuild test robot <lkp(a)intel.com> Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 841b04751dc0 ("UNCLEAN: add HDMI TX driver") CC: Lucas Stach <l.stach(a)pengutronix.de> Signed-off-by: kbuild test robot <lkp(a)intel.com> Signed-off-by: Julia Lawall <julia.lawall(a)lip6.fr> --- tree: git://git.infradead.org/users/ezequielg/linux hantro-vpu-postproc-for-5.5-2 head: 54ed616fb9016b89b7bcdb9c8c8bd5f0532c0def commit: 841b04751dc0a67ccbdc07b44655d9ad35e61ae7 [358/511] UNCLEAN: add HDMI TX driver :::::: branch date: 5 hours ago :::::: commit date: 3 days ago util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/bridge/cdn-hdp/mailbox-if/util.c +++ b/drivers/gpu/drm/bridge/cdn-hdp/mailbox-if/util.c @@ -148,7 +148,7 @@ u32 internal_vmkmsg(volatile u8 *dest, i if (size > 0) { internal_itobe(va_arg(vl, int), dest, size); dest += size; - len += size;; + len += size; } else { memcpy((void *)dest, va_arg(vl, void *), -size); dest -= size; @@ -214,7 +214,7 @@ void internal_vreadmsg(state_struct *sta default: pr_warn("Warning. Unsupported variable size.\n"); memcpy(ptr, src, size); - }; + } src += size; } else {

1 0

[PATCH] UNCLEAN: fix semicolon.cocci warnings
by Julia Lawall 21 Sep '19

21 Sep '19

From: kbuild test robot <lkp(a)intel.com> Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 841b04751dc0 ("UNCLEAN: add HDMI TX driver") CC: Lucas Stach <l.stach(a)pengutronix.de> Signed-off-by: kbuild test robot <lkp(a)intel.com> Signed-off-by: Julia Lawall <julia.lawall(a)lip6.fr> --- tree: git://git.infradead.org/users/ezequielg/linux hantro-vpu-postproc-for-5.5-2 head: 54ed616fb9016b89b7bcdb9c8c8bd5f0532c0def commit: 841b04751dc0a67ccbdc07b44655d9ad35e61ae7 [358/511] UNCLEAN: add HDMI TX driver :::::: branch date: 5 hours ago :::::: commit date: 3 days ago API_DPTX.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/gpu/drm/bridge/cdn-hdp/mailbox-if/API_DPTX.c +++ b/drivers/gpu/drm/bridge/cdn-hdp/mailbox-if/API_DPTX.c @@ -606,7 +606,7 @@ CDN_API_STATUS CDN_API_DPTX_Set_VIC(stat break; default: colorDepth = BCS_8; - }; + } DP_FRAMER_PXL_REPR_Param = (pxlencformat << 8) + colorDepth; @@ -629,7 +629,7 @@ CDN_API_STATUS CDN_API_DPTX_Set_VIC(stat break; default: tempForMisc = 0; - }; + } switch (bitsPerPixel) { case 6: @@ -654,7 +654,7 @@ CDN_API_STATUS CDN_API_DPTX_Set_VIC(stat default: tempForMisc2 = 1; - }; + } oddEvenV_Total = vic_table[vicMode][V_TOTAL] % 2; oddEvenV_Total = 1 - oddEvenV_Total;

1 0

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming
by bugzilla-daemon＠freedesktop.org 21 Sep '19

21 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #103 from Mauro Gaspari <ilvipero(a)gmx.com> --- (In reply to Rodney A Morris from comment #101) > (In reply to Rodney A Morris from comment #99) > > Created attachment 145366 [details] > > apitrace of Hearts of Iron IV hard lock > > > > Apitrace from hard lock playing Hearts of Iron IV without Steam. The replay > > from this trace will hard lock the computer, though inconsistently. I've > > replayed the trace three times. The replay hard locked computer one time. > > neofetch from hardlock: > > /:-------------:\ > :-------------------:: -------------------------------- > :-----------/shhOHbmp---:\ OS: Fedora release 30 (Thirty) x86_64 > /-----------omMMMNNNMMD ---: Kernel: 5.2.13-200.fc30.x86_64 > :-----------sMMMMNMNMP. ---: Uptime: 25 mins > :-----------:MMMdP------- ---\ Packages: 2202 (rpm), 27 (flatpak) > ,------------:MMMd-------- ---: Shell: bash 5.0.7 > :------------:MMMd------- .---: Resolution: 2560x1440 > :---- oNMMMMMMMMMNho .----: DE: GNOME 3.32.2 > :-- .+shhhMMMmhhy++ .------/ WM: GNOME Shell > :- -------:MMMd--------------: WM Theme: Adwaita > :- --------/MMMd-------------; Theme: Adapta-Nokto-Eta [GTK2/3] > :- ------/hMMMy------------: Icons: Adwaita [GTK2/3] > :-- :dMNdhhdNMMNo------------; Terminal: tilix > :---:sdNMMMMNds:------------: CPU: Intel i7-6850K (12) @ 4.000GHz > :------:://:-------------:: GPU: AMD ATI Radeon RX Vega 56/64 > :---------------------:// Memory: 2478MiB / 32084MiB > > OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.1.6 > > Note: hard lock replayed occurred when the Discord flatpak is also running. I also noticed some errors that pointed to discord in my logs. In my case discord was installed via .deb package. Could you please try and disable hardware acceleration in discord settings - appearance menu? Please let me know if it helps or changes anything. Thanks! -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v16 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework
by Brendan Higgins 20 Sep '19

20 Sep '19

## TL;DR This revision addresses comments from Linus[1] and Randy[2], by moving top level `kunit/` directory to `lib/kunit/` and likewise moves top level Kconfig entry under lib/Kconfig.debug, so the KUnit submenu now shows up under the "Kernel Hacking" menu. As a consequence of this, I rewrote patch 06/18 (kbuild: enable building KUnit), and now needs to be re-acked/reviewed. ## Background This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM (however, KUnit still allows you to run tests on test machines or in VMs if you want[3]) and does not require tests to be written in userspace running on a host kernel. Additionally, KUnit is fast: From invocation to completion KUnit can run several dozen tests in about a second. Currently, the entire KUnit test suite for KUnit runs in under a second from the initial invocation (build time excluded). KUnit is heavily inspired by JUnit, Python's unittest.mock, and Googletest/Googlemock for C++. KUnit provides facilities for defining unit test cases, grouping related test cases into test suites, providing common infrastructure for running tests, mocking, spying, and much more. ### What's so special about unit testing? A unit test is supposed to test a single unit of code in isolation, hence the name. There should be no dependencies outside the control of the test; this means no external dependencies, which makes tests orders of magnitudes faster. Likewise, since there are no external dependencies, there are no hoops to jump through to run the tests. Additionally, this makes unit tests deterministic: a failing unit test always indicates a problem. Finally, because unit tests necessarily have finer granularity, they are able to test all code paths easily solving the classic problem of difficulty in exercising error handling code. ### Is KUnit trying to replace other testing frameworks for the kernel? No. Most existing tests for the Linux kernel are end-to-end tests, which have their place. A well tested system has lots of unit tests, a reasonable number of integration tests, and some end-to-end tests. KUnit is just trying to address the unit test space which is currently not being addressed. ### More information on KUnit There is a bunch of documentation near the end of this patch set that describes how to use KUnit and best practices for writing unit tests. For convenience I am hosting the compiled docs here[4]. Additionally for convenience, I have applied these patches to a branch[5]. The repo may be cloned with: git clone https://kunit.googlesource.com/linux This patchset is on the kunit/initial/v5.3/v16 branch. [1] https://www.lkml.org/lkml/2019/9/20/696 [2] https://www.lkml.org/lkml/2019/9/20/738 [3] https://google.github.io/kunit-docs/third_party/kernel/docs/usage.html#kuni… [4] https://google.github.io/kunit-docs/third_party/kernel/docs/ [5] https://kunit.googlesource.com/linux/+/kunit/initial/v5.3/v16 --- Avinash Kondareddy (1): kunit: test: add tests for KUnit managed resources Brendan Higgins (16): kunit: test: add KUnit test runner core kunit: test: add test resource management API kunit: test: add string_stream a std::stream like string builder kunit: test: add assertion printing library kunit: test: add the concept of expectations lib: enable building KUnit in lib/ kunit: test: add initial tests objtool: add kunit_try_catch_throw to the noreturn list kunit: test: add support for test abort kunit: test: add tests for kunit test abort kunit: test: add the concept of assertions kunit: defconfig: add defconfigs for building KUnit tests Documentation: kunit: add documentation for KUnit MAINTAINERS: add entry for KUnit the unit testing framework MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section kunit: fix failure to build without printk Felix Guo (1): kunit: tool: add Python wrappers for running KUnit tests Iurii Zaikin (1): kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kunit/api/index.rst | 16 + Documentation/dev-tools/kunit/api/test.rst | 11 + Documentation/dev-tools/kunit/faq.rst | 62 + Documentation/dev-tools/kunit/index.rst | 79 + Documentation/dev-tools/kunit/start.rst | 180 ++ Documentation/dev-tools/kunit/usage.rst | 576 +++++++ MAINTAINERS | 13 + arch/um/configs/kunit_defconfig | 3 + include/kunit/assert.h | 356 ++++ include/kunit/string-stream.h | 51 + include/kunit/test.h | 1490 +++++++++++++++++ include/kunit/try-catch.h | 75 + kernel/Makefile | 2 + kernel/sysctl-test.c | 392 +++++ lib/Kconfig.debug | 13 + lib/Makefile | 2 + lib/kunit/Kconfig | 38 + lib/kunit/Makefile | 9 + lib/kunit/assert.c | 141 ++ lib/kunit/example-test.c | 88 + lib/kunit/string-stream-test.c | 52 + lib/kunit/string-stream.c | 217 +++ lib/kunit/test-test.c | 331 ++++ lib/kunit/test.c | 478 ++++++ lib/kunit/try-catch.c | 118 ++ tools/objtool/check.c | 1 + tools/testing/kunit/.gitignore | 3 + tools/testing/kunit/configs/all_tests.config | 3 + tools/testing/kunit/kunit.py | 136 ++ tools/testing/kunit/kunit_config.py | 66 + tools/testing/kunit/kunit_kernel.py | 149 ++ tools/testing/kunit/kunit_parser.py | 310 ++++ tools/testing/kunit/kunit_tool_test.py | 206 +++ .../test_is_test_passed-all_passed.log | 32 + .../test_data/test_is_test_passed-crash.log | 69 + .../test_data/test_is_test_passed-failure.log | 36 + .../test_is_test_passed-no_tests_run.log | 75 + .../test_output_isolated_correctly.log | 106 ++ .../test_data/test_read_from_file.kconfig | 17 + 40 files changed, 6003 insertions(+) create mode 100644 Documentation/dev-tools/kunit/api/index.rst create mode 100644 Documentation/dev-tools/kunit/api/test.rst create mode 100644 Documentation/dev-tools/kunit/faq.rst create mode 100644 Documentation/dev-tools/kunit/index.rst create mode 100644 Documentation/dev-tools/kunit/start.rst create mode 100644 Documentation/dev-tools/kunit/usage.rst create mode 100644 arch/um/configs/kunit_defconfig create mode 100644 include/kunit/assert.h create mode 100644 include/kunit/string-stream.h create mode 100644 include/kunit/test.h create mode 100644 include/kunit/try-catch.h create mode 100644 kernel/sysctl-test.c create mode 100644 lib/kunit/Kconfig create mode 100644 lib/kunit/Makefile create mode 100644 lib/kunit/assert.c create mode 100644 lib/kunit/example-test.c create mode 100644 lib/kunit/string-stream-test.c create mode 100644 lib/kunit/string-stream.c create mode 100644 lib/kunit/test-test.c create mode 100644 lib/kunit/test.c create mode 100644 lib/kunit/try-catch.c create mode 100644 tools/testing/kunit/.gitignore create mode 100644 tools/testing/kunit/configs/all_tests.config create mode 100755 tools/testing/kunit/kunit.py create mode 100644 tools/testing/kunit/kunit_config.py create mode 100644 tools/testing/kunit/kunit_kernel.py create mode 100644 tools/testing/kunit/kunit_parser.py create mode 100755 tools/testing/kunit/kunit_tool_test.py create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-all_passed.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-crash.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-failure.log create mode 100644 tools/testing/kunit/test_data/test_is_test_passed-no_tests_run.log create mode 100644 tools/testing/kunit/test_data/test_output_isolated_correctly.log create mode 100644 tools/testing/kunit/test_data/test_read_from_file.kconfig -- 2.23.0.351.gc4317032e6-goog

2 22

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019