dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

Re: linux-next: Tree for Sep 20 (amdgpu-2)
by Randy Dunlap 20 Sep '19

20 Sep '19

On 9/20/19 9:36 AM, Mark Brown wrote: > Hi all, > > News: There will likely be no more -next builds until Stephen returns on > the 30th, I *may* do some next week but it's more likely that I won't > and it certainly won't be every day. > > Changes since 20190919: > on x86_64: (1) where is function get_wm_urgent() defined? I cannot find it (i.e., grep cannot find it). ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function ‘calculate_wm_set_for_vlevel’: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:964:22: error: SSE register return with SSE disabled wm_set->urgent_ns = get_wm_urgent(dml, pipes, pipe_cnt) * 1000; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (2) drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c needs #include <linux/slab.h> for the kzalloc() and kfree() function calls. Thanks. -- ~Randy

1 0

[PATCH] drm/sun4i: Add missing pixel formats to the vi layer
by roman.stratiienko＠globallogic.com 20 Sep '19

20 Sep '19

From: Roman Stratiienko <roman.stratiienko(a)globallogic.com> According to Allwinner DE2.0 Specification REV 1.0, vi layer supports the following pixel formats: ABGR_8888, ARGB_8888, BGRA_8888, RGBA_8888 Signed-off-by: Roman Stratiienko <roman.stratiienko(a)globallogic.com> --- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index bd0e6a52d1d8..07c27e6a4b77 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c @@ -404,17 +404,21 @@ static const struct drm_plane_funcs sun8i_vi_layer_funcs = { static const u32 sun8i_vi_layer_formats[] = { DRM_FORMAT_ABGR1555, DRM_FORMAT_ABGR4444, + DRM_FORMAT_ABGR8888, DRM_FORMAT_ARGB1555, DRM_FORMAT_ARGB4444, + DRM_FORMAT_ARGB8888, DRM_FORMAT_BGR565, DRM_FORMAT_BGR888, DRM_FORMAT_BGRA5551, DRM_FORMAT_BGRA4444, + DRM_FORMAT_BGRA8888, DRM_FORMAT_BGRX8888, DRM_FORMAT_RGB565, DRM_FORMAT_RGB888, DRM_FORMAT_RGBA4444, DRM_FORMAT_RGBA5551, + DRM_FORMAT_RGBA8888, DRM_FORMAT_RGBX8888, DRM_FORMAT_XBGR8888, DRM_FORMAT_XRGB8888, -- 2.17.1

4 5

[PATCH] drm/sun4i: Use vi plane as primary
by roman.stratiienko＠globallogic.com 20 Sep '19

20 Sep '19

From: Roman Stratiienko <roman.stratiienko(a)globallogic.com> DE2.0 blender does not take into the account alpha channel of vi layer. Thus makes overlaying of this layer totally opaque. Using vi layer as bottom solves this issue. Tested on Android. Signed-off-by: Roman Stratiienko <roman.stratiienko(a)globallogic.com> --- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 33 ----------------------- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 36 +++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c index dd2a1c851939..25183badc85f 100644 --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c @@ -99,36 +99,6 @@ static int sun8i_ui_layer_update_coord(struct sun8i_mixer *mixer, int channel, insize = SUN8I_MIXER_SIZE(src_w, src_h); outsize = SUN8I_MIXER_SIZE(dst_w, dst_h); - if (plane->type == DRM_PLANE_TYPE_PRIMARY) { - bool interlaced = false; - u32 val; - - DRM_DEBUG_DRIVER("Primary layer, updating global size W: %u H: %u\n", - dst_w, dst_h); - regmap_write(mixer->engine.regs, - SUN8I_MIXER_GLOBAL_SIZE, - outsize); - regmap_write(mixer->engine.regs, - SUN8I_MIXER_BLEND_OUTSIZE(bld_base), outsize); - - if (state->crtc) - interlaced = state->crtc->state->adjusted_mode.flags - & DRM_MODE_FLAG_INTERLACE; - - if (interlaced) - val = SUN8I_MIXER_BLEND_OUTCTL_INTERLACED; - else - val = 0; - - regmap_update_bits(mixer->engine.regs, - SUN8I_MIXER_BLEND_OUTCTL(bld_base), - SUN8I_MIXER_BLEND_OUTCTL_INTERLACED, - val); - - DRM_DEBUG_DRIVER("Switching display mixer interlaced mode %s\n", - interlaced ? "on" : "off"); - } - /* Set height and width */ DRM_DEBUG_DRIVER("Layer source offset X: %d Y: %d\n", state->src.x1 >> 16, state->src.y1 >> 16); @@ -349,9 +319,6 @@ struct sun8i_ui_layer *sun8i_ui_layer_init_one(struct drm_device *drm, if (!layer) return ERR_PTR(-ENOMEM); - if (index == 0) - type = DRM_PLANE_TYPE_PRIMARY; - /* possible crtcs are set later */ ret = drm_universal_plane_init(drm, &layer->plane, 0, &sun8i_ui_layer_funcs, diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index 07c27e6a4b77..49c4074e164f 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c @@ -116,6 +116,36 @@ static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int channel, insize = SUN8I_MIXER_SIZE(src_w, src_h); outsize = SUN8I_MIXER_SIZE(dst_w, dst_h); + if (plane->type == DRM_PLANE_TYPE_PRIMARY) { + bool interlaced = false; + u32 val; + + DRM_DEBUG_DRIVER("Primary layer, updating global size W: %u H: %u\n", + dst_w, dst_h); + regmap_write(mixer->engine.regs, + SUN8I_MIXER_GLOBAL_SIZE, + outsize); + regmap_write(mixer->engine.regs, + SUN8I_MIXER_BLEND_OUTSIZE(bld_base), outsize); + + if (state->crtc) + interlaced = state->crtc->state->adjusted_mode.flags + & DRM_MODE_FLAG_INTERLACE; + + if (interlaced) + val = SUN8I_MIXER_BLEND_OUTCTL_INTERLACED; + else + val = 0; + + regmap_update_bits(mixer->engine.regs, + SUN8I_MIXER_BLEND_OUTCTL(bld_base), + SUN8I_MIXER_BLEND_OUTCTL_INTERLACED, + val); + + DRM_DEBUG_DRIVER("Switching display mixer interlaced mode %s\n", + interlaced ? "on" : "off"); + } + /* Set height and width */ DRM_DEBUG_DRIVER("Layer source offset X: %d Y: %d\n", (state->src.x1 >> 16) & ~(format->hsub - 1), @@ -445,6 +475,7 @@ struct sun8i_vi_layer *sun8i_vi_layer_init_one(struct drm_device *drm, struct sun8i_mixer *mixer, int index) { + enum drm_plane_type type = DRM_PLANE_TYPE_OVERLAY; struct sun8i_vi_layer *layer; unsigned int plane_cnt; int ret; @@ -453,12 +484,15 @@ struct sun8i_vi_layer *sun8i_vi_layer_init_one(struct drm_device *drm, if (!layer) return ERR_PTR(-ENOMEM); + if (index == 0) + type = DRM_PLANE_TYPE_PRIMARY; + /* possible crtcs are set later */ ret = drm_universal_plane_init(drm, &layer->plane, 0, &sun8i_vi_layer_funcs, sun8i_vi_layer_formats, ARRAY_SIZE(sun8i_vi_layer_formats), - NULL, DRM_PLANE_TYPE_OVERLAY, NULL); + NULL, type, NULL); if (ret) { dev_err(drm->dev, "Couldn't initialize layer\n"); return ERR_PTR(ret); -- 2.17.1

4 8

[PATCH] drm: Remove redundant of_device_is_available check
by megous＠megous.com 20 Sep '19

20 Sep '19

From: Ondrej Jirman <megous(a)megous.com> This check is already performed by of_graph_get_remote_node. No need to repeat it immediately after the call. Signed-off-by: Ondrej Jirman <megous(a)megous.com> --- drivers/gpu/drm/drm_of.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 43d89dd59c6b..0ca58803ba46 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, *panel = NULL; remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV; - if (!of_device_is_available(remote)) { - of_node_put(remote); - return -ENODEV; - } - if (panel) { *panel = of_drm_find_panel(remote); if (!IS_ERR(*panel)) ret = 0; else *panel = NULL; -- 2.23.0

2 1

Re: linux-next: Tree for Sep 20 (amd/display)
by Randy Dunlap 20 Sep '19

20 Sep '19

On 9/20/19 9:36 AM, Mark Brown wrote: > Hi all, > > News: There will likely be no more -next builds until Stephen returns on > the 30th, I *may* do some next week but it's more likely that I won't > and it certainly won't be every day. > > Changes since 20190919: > on i386: ld: drivers/gpu/drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.o: in function `dce11_pplib_apply_display_requirements': dce110_clk_mgr.c:(.text+0x2f0): undefined reference to `__divdi3' ld: dce110_clk_mgr.c:(.text+0x304): undefined reference to `__divdi3' -- ~Randy

1 0

[PATCH 00/12] drm/i915: YCbCr output fixes and prep work for YCbCr 4:4:4 output
by Ville Syrjala 20 Sep '19

20 Sep '19

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> I was playing around with YCbCr 4:4:4 output and noticed several things wrong in our code. So I fixed it all and tossed in the prep work for YCbCr 4:4:4 output on ilk+. Ville Syrjälä (12): drm/dp: Add definitons for MSA MISC bits drm/i915: Fix HSW+ DP MSA YCbCr colorspace indication drm/i915: Fix AVI infoframe quantization range for YCbCr output drm/i915: Extract intel_hdmi_limited_color_range() drm/i915: Never set limited_color_range=true for YCbCr output drm/i915: Switch to using DP_MSA_MISC_* defines drm/i915: Don't look at unrelated PIPECONF bits for interlaced readout drm/i915: Simplify intel_get_crtc_ycbcr_config() drm/i915: Add PIPECONF YCbCr 4:4:4 programming for HSW drm/i915: Document ILK+ pipe csc matrix better drm/i915: Set up ILK/SNB csc unit properly for YCbCr output drm/i915: Add PIPECONF YCbCr 4:4:4 programming for ILK-IVB drivers/gpu/drm/i915/display/intel_color.c | 51 ++++++-- drivers/gpu/drm/i915/display/intel_ddi.c | 28 +++-- drivers/gpu/drm/i915/display/intel_display.c | 120 ++++++++++++------- drivers/gpu/drm/i915/display/intel_dp.c | 10 ++ drivers/gpu/drm/i915/display/intel_hdmi.c | 61 +++++++--- drivers/gpu/drm/i915/i915_reg.h | 31 ++--- include/drm/drm_dp_helper.h | 42 +++++++ 7 files changed, 247 insertions(+), 96 deletions(-) -- 2.21.0

3 29

[drm-intel:drm-intel-next-queued 6/7] drivers/gpu/drm/i915/display/intel_color.c:1576 ilk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
by kbuild test robot 20 Sep '19

20 Sep '19

tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 4bb6a9d5d9a8289673c4cb0786d44be8a63c21db commit: 6b97b118d4d542c7bc25b725c6de3947fffb921b [6/7] drm/i915/display: Extract ilk_read_luts() If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> New smatch warnings: drivers/gpu/drm/i915/display/intel_color.c:1576 ilk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null) Old smatch warnings: drivers/gpu/drm/i915/display/intel_color.c:1535 i9xx_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null) vim +/blob +1576 drivers/gpu/drm/i915/display/intel_color.c 1558 1559 static struct drm_property_blob * 1560 ilk_read_lut_10(const struct intel_crtc_state *crtc_state) 1561 { 1562 struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc); 1563 struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); 1564 u32 lut_size = INTEL_INFO(dev_priv)->color.gamma_lut_size; 1565 enum pipe pipe = crtc->pipe; 1566 struct drm_property_blob *blob; 1567 struct drm_color_lut *blob_data; 1568 u32 i, val; 1569 1570 blob = drm_property_create_blob(&dev_priv->drm, 1571 sizeof(struct drm_color_lut) * lut_size, 1572 NULL); 1573 if (IS_ERR(blob)) 1574 return NULL; 1575 > 1576 blob_data = blob->data; 1577 1578 for (i = 0; i < lut_size; i++) { 1579 val = I915_READ(PREC_PALETTE(pipe, i)); 1580 1581 blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET( 1582 PREC_PALETTE_RED_MASK, val), 10); 1583 blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET( 1584 PREC_PALETTE_GREEN_MASK, val), 10); 1585 blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET( 1586 PREC_PALETTE_BLUE_MASK, val), 10); 1587 } 1588 1589 return blob; 1590 } 1591 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

[PATCH 1/6] drm/ttm: add on_alloc_stage and reservation into ttm_operation_ctx
by Roger He 20 Sep '19

20 Sep '19

on_alloc_stage: is this operation on allocation stage resv: reservation bo used of this operation Change-Id: I01ea482e8c7470014196eb218e2ff8913306eef0 Signed-off-by: Roger He <Hongbo.He(a)amd.com> --- include/drm/ttm/ttm_bo_api.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index 368eb02..25de597 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -263,6 +263,8 @@ struct ttm_bo_kmap_obj { * * @interruptible: Sleep interruptible if sleeping. * @no_wait_gpu: Return immediately if the GPU is busy. + * @on_alloc_stage: is this operation on allocation stage + * @resv: resvation bo used * * Context for TTM operations like changing buffer placement or general memory * allocation. @@ -270,6 +272,8 @@ struct ttm_bo_kmap_obj { struct ttm_operation_ctx { bool interruptible; bool no_wait_gpu; + bool on_alloc_stage; + struct reservation_object *resv; uint64_t bytes_moved; }; -- 2.7.4

6 20

[Bug 111747] [CI][DRMTIP] igt@ - incomplete - Jenkins gives up
by bugzilla-daemon＠freedesktop.org 20 Sep '19

20 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=111747 --- Comment #3 from Chris Wilson <chris(a)chris-wilson.co.uk> --- *** Bug 111518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] video/hdmi: Fix AVI bar unpack
by Ville Syrjala 20 Sep '19

20 Sep '19

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> The bar values are little endian, not big endian. The pack function did it right but the unpack got it wrong. Fix it. Cc: stable(a)vger.kernel.org Cc: linux-media(a)vger.kernel.org Cc: Martin Bugge <marbugge(a)cisco.com> Cc: Hans Verkuil <hans.verkuil(a)cisco.com> Cc: Thierry Reding <treding(a)nvidia.com> Cc: Mauro Carvalho Chehab <mchehab(a)osg.samsung.com> Fixes: 2c676f378edb ("[media] hdmi: added unpack and logging functions for InfoFrames") Signed-off-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> --- drivers/video/hdmi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index b939bc28d886..9c82e2a0a411 100644 --- a/drivers/video/hdmi.c +++ b/drivers/video/hdmi.c @@ -1576,12 +1576,12 @@ static int hdmi_avi_infoframe_unpack(struct hdmi_avi_infoframe *frame, if (ptr[0] & 0x10) frame->active_aspect = ptr[1] & 0xf; if (ptr[0] & 0x8) { - frame->top_bar = (ptr[5] << 8) + ptr[6]; - frame->bottom_bar = (ptr[7] << 8) + ptr[8]; + frame->top_bar = (ptr[6] << 8) | ptr[5]; + frame->bottom_bar = (ptr[8] << 8) | ptr[7]; } if (ptr[0] & 0x4) { - frame->left_bar = (ptr[9] << 8) + ptr[10]; - frame->right_bar = (ptr[11] << 8) + ptr[12]; + frame->left_bar = (ptr[10] << 8) | ptr[9]; + frame->right_bar = (ptr[12] << 8) | ptr[11]; } frame->scan_mode = ptr[0] & 0x3; -- 2.21.0

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019