dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH v6 0/7] drm/i915/dp: Support for DP HDR outputs
by Gwan-gyeong Mun 12 Sep '19

12 Sep '19

Support for HDR10 video was introduced in DisplayPort 1.4. On GLK+ platform, in order to use DisplayPort HDR10, we need to support BT.2020 colorimetry and HDR Static metadata. It implements the CTA-861-G standard for transport of static HDR metadata. It enables writing of HDR metadata infoframe SDP to the panel. The HDR Metadata will be provided by userspace compositors, based on blending policies and passed to the driver through a blob property. And It refactors, renames and extends a function which handled vsc sdp header and data block setup for supporting colorimetry format. And It attaches the colorspace connector property and HDR metadata property to a DisplayPort connector. These patches tested on below test environment. Test Environment: - Tested System: GLK and Gen11 platform. - Monitor: Dell UP2718Q 4K HDR Monitor. - In order to test DP HDR10, test environment uses patched Kodi-gbm, patched Media driver and HDR10 video. You can find these on below. [patched Kodi-gbm] - repo: https://github.com/Kwiboo/xbmc/tree/drmprime-hdr [download 4K HDR video file] - link: https://4kmedia.org/lg-new-york-hdr-uhd-4k-demo/ [Media Driver for GLK] - repo https://gitlab.freedesktop.org/emersion/intel-vaapi-driver master branch [Media Driver for ICL] - repo: https://github.com/harishkrupo/media-driver/tree/p010_composite v2: - Add a missed blank line after function declaration. - Remove useless parentheses. - Minor style fix. v3: - Remove not handled return values from intel_dp_setup_hdr_metadata_infoframe_sdp(). [Uma] - Add handling of different register size for HDMI_PACKET_TYPE_GAMUT_METADATA on hsw_dip_data_size() for each GEN platforms [Uma] - Add new colorimetry options for DP 1.4a spec. [Ville] - Separate set of colorimetry enum values for DP. [Ville] - In order to checking output format and output colorspace on intel_dp_needs_vsc_sdp(), it passes entire intel_crtc_state stucture.[Ville] - Remove a pointless variable. [Ville] v4: - Add additional comments to struct drm_prop_enum_list. - Polishing an enum string of struct drm_prop_enum_list. v5: - Change definitions of DRM_MODE_COLORIMETRYs to follow HDMI prefix and DP abbreviations. - Add missed variables on dp_colorspaces. - Fix typo. [Uma] v6: - Addressed review comments from Ilia and Ville Split drm_mode_create_colorspace_property() to DP and HDMI connector. Becasue between HDMI and DP have different colorspaces, it renames drm_mode_create_colorspace_property() function to drm_mode_create_hdmi_colorspace_property() function for HDMI connector. And it adds drm_mode_create_dp_colorspace_property() function for creating of DP colorspace property. In order to apply changed and added drm api, i915 driver has channged. Gwan-gyeong Mun (7): drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA drm: Add DisplayPort colorspace property drm/i915/dp: Attach colorspace property drm/i915: Add new GMP register size for GEN11 drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata drm/i915/dp: Attach HDR metadata property to DP connector drivers/gpu/drm/drm_connector.c | 110 ++++++++-- .../gpu/drm/i915/display/intel_connector.c | 21 +- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +- drivers/gpu/drm/i915/display/intel_display.h | 2 - .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/display/intel_dp.c | 193 ++++++++++++++++-- drivers/gpu/drm/i915/display/intel_dp.h | 7 + drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +- drivers/gpu/drm/i915/i915_reg.h | 1 + include/drm/drm_connector.h | 11 +- 10 files changed, 326 insertions(+), 42 deletions(-) -- 2.23.0

2 8

[PATCH v2 0/2] tc358767 test mode
by Andrey Smirnov 12 Sep '19

12 Sep '19

Everyone: This series is a couple of patches exposing TestCtl register of tc358767, which can be pretty handy when troubleshooting link problems. Changes since [v1]: - Debugfs moved into a standalone directory and is now created as a part of probe() - Added tstctl_lock to ensure mutual exclusion of tstctl code and bridge's enable/disable methods - tc_tstctl_set() changed to function only if bridge was previosly enabled - Added comment explaining data format expected by "tstctl" - Debugfs permission changed to reflect write-only nature of this feature - Original commit split into two - Minor formatting changes Thanks, Andrey Smirnov [v1] lore.kernel.org/r/20190826182524.5064-1-andrew.smirnov@gmail.com Andrey Smirnov (2): drm/bridge: tc358767: Introduce __tc_bridge_enable/disable() drm/bridge: tc358767: Expose test mode functionality via debugfs drivers/gpu/drm/bridge/tc358767.c | 184 ++++++++++++++++++++++++------ 1 file changed, 148 insertions(+), 36 deletions(-) -- 2.21.0

1 2

[RFC PATCH] gpu: no need to compile drm/ if CONFIG_DRM=n
by Qian Cai 12 Sep '19

12 Sep '19

The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need. Fixes: c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") --- drivers/gpu/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile index f17d01f076c7..a793b9ace34b 100644 --- a/drivers/gpu/Makefile +++ b/drivers/gpu/Makefile @@ -3,5 +3,6 @@ # taken to initialize them in the correct order. Link order is the only way # to ensure this currently. obj-$(CONFIG_TEGRA_HOST1X) += host1x/ -obj-y += drm/ vga/ +obj-$(CONFIG_DRM) += drm/ +obj-y += vga/ obj-$(CONFIG_IMX_IPUV3_CORE) += ipu-v3/ -- 2.20.1 (Apple Git-117)

3 3

[PULL] drm-intel-next-fixes
by Rodrigo Vivi 11 Sep '19

11 Sep '19

Hi Dave and Daniel, Here goes drm-intel-next-fixes-2019-09-11: Few fixes on GGTT and PPGTT around pin, locks, fence and vgpu. This also includes GVT fixes with two recent fixes: one for recent guest hang regression and another for guest reset fix. Thanks, Rodrigo. The following changes since commit 578d2342ec702e5fb8a77983fabb3754ae3e9660: Merge tag 'drm-next-5.4-2019-08-23' of git://people.freedesktop.org/~agd5f/linux into drm-next (2019-08-27 17:22:15 +1000) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-fixes-2019-09-11 for you to fetch changes up to 6e5c5272ca00809aae20817efb6f25881268b50b: drm/i915: Use NOEVICT for first pass on attemping to pin a GGTT mmap (2019-09-06 09:53:15 -0700) ---------------------------------------------------------------- Few fixes on GGTT and PPGTT around pin, locks, fence and vgpu. This also includes GVT fixes with two recent fixes: one for recent guest hang regression and another for guest reset fix. ---------------------------------------------------------------- Chris Wilson (3): drm/i915: Hold irq-off for the entire fake lock period drm/i915: Flush the existing fence before GGTT read/write drm/i915: Use NOEVICT for first pass on attemping to pin a GGTT mmap Rodrigo Vivi (1): Merge tag 'gvt-next-fixes-2019-09-06' of https://github.com/intel/gvt-linux into drm-intel-next-fixes Weinan Li (1): drm/i915/gvt: update RING_START reg of vGPU when the context is submitted to i915 Xiaolin Zhang (2): drm/i915/gvt: update vgpu workload head pointer correctly drm/i915: to make vgpu ppgtt notificaiton as atomic operation drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 28 ++++++++++++------- drivers/gpu/drm/i915/gt/intel_reset.c | 9 ++++--- drivers/gpu/drm/i915/gt/intel_timeline.c | 10 ++++--- drivers/gpu/drm/i915/gvt/scheduler.c | 45 ++++++++++++++++++++++--------- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gem.c | 23 +++++++++++----- drivers/gpu/drm/i915/i915_gem_gtt.c | 12 +++++---- drivers/gpu/drm/i915/i915_request.c | 9 ++++--- drivers/gpu/drm/i915/i915_vgpu.c | 1 + 10 files changed, 92 insertions(+), 48 deletions(-)

1 0

[PATCH 0/4] HMM tests and minor fixes
by Ralph Campbell 11 Sep '19

11 Sep '19

These changes are based on Jason's latest hmm branch. Patch 1 was previously posted here [1] but was dropped from the orginal series. Hopefully, the tests will reduce concerns about edge conditions. I'm sure more tests could be usefully added but I thought this was a good starting point. [1] https://lore.kernel.org/linux-mm/20190726005650.2566-6-rcampbell@nvidia.com/ Ralph Campbell (4): mm/hmm: make full use of walk_page_range() mm/hmm: allow snapshot of the special zero page mm/hmm: allow hmm_range_fault() of mmap(PROT_NONE) mm/hmm/test: add self tests for HMM MAINTAINERS | 3 + drivers/char/Kconfig | 11 + drivers/char/Makefile | 1 + drivers/char/hmm_dmirror.c | 1504 ++++++++++++++++++++++++ include/Kbuild | 1 + include/uapi/linux/hmm_dmirror.h | 74 ++ mm/hmm.c | 117 +- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 3 + tools/testing/selftests/vm/config | 3 + tools/testing/selftests/vm/hmm-tests.c | 1304 ++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 16 + tools/testing/selftests/vm/test_hmm.sh | 105 ++ 13 files changed, 3079 insertions(+), 64 deletions(-) create mode 100644 drivers/char/hmm_dmirror.c create mode 100644 include/uapi/linux/hmm_dmirror.h create mode 100644 tools/testing/selftests/vm/hmm-tests.c create mode 100755 tools/testing/selftests/vm/test_hmm.sh -- 2.20.1

1 4

[Bug 204817] New: IP resume fail after changing dpm states rapidly
by bugzilla-daemon＠bugzilla.kernel.org 11 Sep '19

11 Sep '19

https://bugzilla.kernel.org/show_bug.cgi?id=204817 Bug ID: 204817 Summary: IP resume fail after changing dpm states rapidly Product: Drivers Version: 2.5 Kernel Version: 5.3.0-050300rc8-generic Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: proje.pdf(a)outlook.com Regression: No Created attachment 284929 --> https://bugzilla.kernel.org/attachment.cgi?id=284929&action=edit full sudo dmesg log utku3@pop-os:~$ for i in IP ip;do eval "sudo dmesg|grep '$i block'";done [ 3049.134211] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <sdma_v3_0> failed -110 [ 3074.488873] [drm:amdgpu_device_ip_suspend_phase2 [amdgpu]] *ERROR* suspend of IP block <powerplay> failed -22 [ 3075.489943] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <sdma_v3_0> failed -110 [ 3261.622094] [drm:amdgpu_device_ip_suspend_phase2 [amdgpu]] *ERROR* suspend of IP block <powerplay> failed -22 [ 3341.385045] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <gfx_v8_0> failed -110 [ 3391.965201] [drm:amdgpu_device_ip_suspend_phase2 [amdgpu]] *ERROR* suspend of IP block <powerplay> failed -22 [ 2.102086] [drm] add ip block number 0 <vi_common> [ 2.102088] [drm] add ip block number 1 <gmc_v8_0> [ 2.102089] [drm] add ip block number 2 <cz_ih> [ 2.102090] [drm] add ip block number 3 <gfx_v8_0> [ 2.102091] [drm] add ip block number 4 <sdma_v3_0> [ 2.102092] [drm] add ip block number 5 <powerplay> [ 2.102093] [drm] add ip block number 6 <dm> [ 2.102094] [drm] add ip block number 7 <uvd_v6_0> [ 2.102095] [drm] add ip block number 8 <vce_v3_0> [ 2.102096] [drm] add ip block number 9 <acp_ip> [ 2.403182] [drm] add ip block number 0 <vi_common> [ 2.403183] [drm] add ip block number 1 <gmc_v8_0> [ 2.403184] [drm] add ip block number 2 <tonga_ih> [ 2.403185] [drm] add ip block number 3 <gfx_v8_0> [ 2.403185] [drm] add ip block number 4 <sdma_v3_0> [ 2.403186] [drm] add ip block number 5 <powerplay> [ 2.403187] [drm] add ip block number 6 <dm> [ 2.403188] [drm] add ip block number 7 <uvd_v6_0> [ 2.403189] [drm] add ip block number 8 <vce_v3_0> utku3@pop-os:~$ uname -a Linux pop-os 5.3.0-050300rc8-generic #201909082132 SMP Sun Sep 8 21:34:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Problem occurs when i set /sys/class/drm/card1/device/power_dpm_force_performance_level between low, high and auto quicker than a second or rarely by its own, i can't test the issues on kernels older than 5.3.0-rc1 because of #201077, GPU is RX 540 on Acer Aspire 5 A515-41G-T48Q full dmesg log is attached. -- You are receiving this mail because: You are watching the assignee of the bug.

1 0

[Regression] 5.3-rc8 suspending from X broken with amdgpu
by Gabriel C 11 Sep '19

11 Sep '19

Hello, I am testing latest rc8/Linus git tree on my new Acer Nitro 5 (AN515-43-R8BF) Laptop. The box has an Ryzen7 3750H APU+RX 560x hybrid GPU(s). Suspending ( closing the Lid ) from tty without X up is working fine, however with X running doing the same does not work. The display remains black. It seems to be triggered from .. dcn10_hw_sequencer.c:932 dcn10_verify_allow_pstate_change_high.cold+0xc/0x229 [amdgpu] The dmesg is way to big to post there so I uploaded it: dmesg: http://crazy.dev.frugalware.org/Nitro5/dmesg.one.txt lspci: http://crazy.dev.frugalware.org/Nitro5/lspci.nnvv.txt http://crazy.dev.frugalware.org/Nitro5/lspci.txt config: http://crazy.dev.frugalware.org/Nitro5/config.nitro5-5.3-r8git I didn't tested any other rcX kernels so I cannot tell if all are affected, but 5.2.x kernels are working fine on this box. The dirty state of the build is because this patch, which fixes the NVME device on that box: https://lkml.org/lkml/2019/9/11/569 If you need more infos please let me know. Also I can test any kind patches. Best Regards, Gabriel C

1 0

[PATCH v2 0/3] ast, mgag200: Map console BO while it's being displayed
by Thomas Zimmermann 11 Sep '19

11 Sep '19

(was: drm/vram-helper: Fix performance regression in fbdev) Generic fbdev emulation maps and unmaps the console BO for updating it's content from the shadow buffer. If this involves an actual mapping operation (instead of reusing an existing mapping), lots of debug messages may be printed, such as x86/PAT: Overlap at 0xd0000000-0xd1000000 x86/PAT: reserve_memtype added [mem 0xd0000000-0xd02fffff], track write-combining, req write-combining, ret write-combining x86/PAT: free_memtype request [mem 0xd0000000-0xd02fffff] as reported at [1]. Drivers using VRAM helpers may also see reduced performance as the mapping operations can create overhead. This patch set fixes the problem by adding a ref counter to the GEM VRAM buffers' kmap operation, and keeping the fbdev's console buffer mapped while the console is being displayed. These changes avoid the frequent mappings in the fbdev code. The drivers, ast and mgag200, map the console's buffer when it becomes visible and the fbdev code reuses this mapping. The original fbdev code in ast and mgag200 used the same strategy. [1] https://lists.freedesktop.org/archives/dri-devel/2019-September/234308.html v2: * fixed comment typos Thomas Zimmermann (3): drm/vram: Add kmap ref-counting to GEM VRAM objects drm/ast: Map fbdev framebuffer while it's being displayed drm/mgag200: Map fbdev framebuffer while it's being displayed drivers/gpu/drm/ast/ast_mode.c | 19 +++++++ drivers/gpu/drm/drm_gem_vram_helper.c | 74 +++++++++++++++++++------- drivers/gpu/drm/mgag200/mgag200_mode.c | 20 +++++++ include/drm/drm_gem_vram_helper.h | 19 +++++++ 4 files changed, 114 insertions(+), 18 deletions(-) -- 2.23.0

5 14

[PATCH v2] drm/qxl: get vga ioports
by Gerd Hoffmann 11 Sep '19

11 Sep '19

qxl has two modes: "native" (used by the drm driver) and "vga" (vga compatibility mode, typically used for boot display and firmware framebuffers). Accessing any vga ioport will switch the qxl device into vga mode. The qxl driver never does that, but other drivers accessing vga ports can trigger that too and therefore disturb qxl operation. So aquire the legacy vga ioports from vgaarb to avoid that. Reproducer: Boot kvm guest with both qxl and i915 vgpu, with qxl being first in pci scan order. v2: Skip this for secondary qxl cards which don't have vga mode in the first place (Frediano). Cc: Frediano Ziglio <fziglio(a)redhat.com> Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- drivers/gpu/drm/qxl/qxl_drv.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index b57a37543613..fcb48ac60598 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.c +++ b/drivers/gpu/drm/qxl/qxl_drv.c @@ -63,6 +63,11 @@ module_param_named(num_heads, qxl_num_crtc, int, 0400); static struct drm_driver qxl_driver; static struct pci_driver qxl_pci_driver; +static bool is_vga(struct pci_dev *pdev) +{ + return pdev->class == PCI_CLASS_DISPLAY_VGA << 8; +} + static int qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) { @@ -87,9 +92,17 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (ret) goto disable_pci; + if (is_vga(pdev)) { + ret = vga_get_interruptible(pdev, VGA_RSRC_LEGACY_IO); + if (ret) { + DRM_ERROR("can't get legacy vga ioports\n"); + goto disable_pci; + } + } + ret = qxl_device_init(qdev, &qxl_driver, pdev); if (ret) - goto disable_pci; + goto put_vga; ret = qxl_modeset_init(qdev); if (ret) @@ -109,6 +122,9 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) qxl_modeset_fini(qdev); unload: qxl_device_fini(qdev); +put_vga: + if (is_vga(pdev)) + vga_put(pdev, VGA_RSRC_LEGACY_IO); disable_pci: pci_disable_device(pdev); free_dev: @@ -126,6 +142,8 @@ qxl_pci_remove(struct pci_dev *pdev) qxl_modeset_fini(qdev); qxl_device_fini(qdev); + if (is_vga(pdev)) + vga_put(pdev, VGA_RSRC_LEGACY_IO); dev->dev_private = NULL; kfree(qdev); -- 2.18.1

3 3

[PULL] drm-intel-fixes
by Jani Nikula 11 Sep '19

11 Sep '19

Hi Dave & Daniel - A couple more fixes for v5.3, both cc: stable. drm-intel-fixes-2019-09-11: Final drm/i915 fixes for v5.3: - Fox DP MST high color depth regression - Fix GPU hangs on Vulkan compute workloads BR, Jani. The following changes since commit f74c2bb98776e2de508f4d607cd519873065118e: Linux 5.3-rc8 (2019-09-08 13:33:15 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-09-11 for you to fetch changes up to 2eb0964eec5f1d99f9eaf4963eee267acc72b615: drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ (2019-09-09 16:10:28 +0300) ---------------------------------------------------------------- Final drm/i915 fixes for v5.3: - Fox DP MST high color depth regression - Fix GPU hangs on Vulkan compute workloads ---------------------------------------------------------------- Chris Wilson (1): drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ Ville Syrjälä (1): drm/i915: Limit MST to <= 8bpc once again drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++++++++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ----- 2 files changed, 9 insertions(+), 6 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019