dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH] drm/i915/gvt: fix spelling mistake "resseting" -> "resetting"
by Colin King 11 Sep '19

11 Sep '19

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a gvt_dbg_core debug message. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index d5a6e4e3d0fd..ecfd91b1b12c 100644 --- a/drivers/gpu/drm/i915/gvt/vgpu.c +++ b/drivers/gpu/drm/i915/gvt/vgpu.c @@ -531,7 +531,7 @@ void intel_gvt_reset_vgpu_locked(struct intel_vgpu *vgpu, bool dmlr, intel_engine_mask_t resetting_eng = dmlr ? ALL_ENGINES : engine_mask; gvt_dbg_core("------------------------------------------\n"); - gvt_dbg_core("resseting vgpu%d, dmlr %d, engine_mask %08x\n", + gvt_dbg_core("resetting vgpu%d, dmlr %d, engine_mask %08x\n", vgpu->id, dmlr, engine_mask); vgpu->resetting_eng = resetting_eng; -- 2.20.1

1 0

[PATCH v2 0/4] Merge VRAM MM and GEM VRAM source files
by Thomas Zimmermann 11 Sep '19

11 Sep '19

VRAM MM and GEM VRAM are only used with each other. This patch set moves VRAM MM into GEM VRAM source files and cleans up the helper's public interface. Version 2 of the patch set doesn't contain functional changes. I'm reposting due to the rebasing onto the debugfs patches. v2: * updated for debugfs support * fixed typos in comments Thomas Zimmermann (4): drm/vram: Move VRAM memory manager to GEM VRAM implementation drm/vram: Have VRAM MM call GEM VRAM functions directly drm/vram: Unexport internal functions of VRAM MM drm/vram: Unconditonally set BO call-back functions Documentation/gpu/drm-mm.rst | 12 - drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/ast/ast_ttm.c | 3 +- drivers/gpu/drm/bochs/bochs.h | 1 - drivers/gpu/drm/bochs/bochs_mm.c | 3 +- drivers/gpu/drm/drm_gem_vram_helper.c | 406 +++++++++++++++--- drivers/gpu/drm/drm_vram_helper_common.c | 8 +- drivers/gpu/drm/drm_vram_mm_helper.c | 353 --------------- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 - drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 3 +- drivers/gpu/drm/mgag200/mgag200_drv.h | 1 - drivers/gpu/drm/mgag200/mgag200_ttm.c | 3 +- drivers/gpu/drm/vboxvideo/vbox_drv.h | 2 - drivers/gpu/drm/vboxvideo/vbox_ttm.c | 3 +- include/drm/drm_gem_vram_helper.h | 92 +++- include/drm/drm_vram_mm_helper.h | 109 ----- 18 files changed, 421 insertions(+), 584 deletions(-) delete mode 100644 drivers/gpu/drm/drm_vram_mm_helper.c delete mode 100644 include/drm/drm_vram_mm_helper.h -- 2.23.0

1 4

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'
by bugzilla-daemon＠freedesktop.org 11 Sep '19

11 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=107877 Michel Dänzer <michel(a)daenzer.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://routerlognnet.us/ | Status|CLOSED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'
by bugzilla-daemon＠freedesktop.org 11 Sep '19

11 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=107877 Brett P. Gardner <routerlognet(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED URL| |https://routerlognnet.us/ --- Comment #31 from Brett P. Gardner <routerlognet(a)gmail.com> --- If you are not able to complete the login process then you can call at 1-877-800-6576 or visit https://routerlognnet.us/. Our technical experts will resolve all the technical issues with Netgear Router Setup and www.routerlogin.net login. We are there for you 24*7 so you can contact us anytime. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v6 0/4] Add a generic driver for LED-based backlight
by Jean-Jacques Hiblot 10 Sep '19

10 Sep '19

This series aims to add a led-backlight driver, similar to pwm-backlight, but using a LED class device underneath. A few years ago (2015), Tomi Valkeinen posted a series implementing a backlight driver on top of a LED device: https://patchwork.kernel.org/patch/7293991/ https://patchwork.kernel.org/patch/7294001/ https://patchwork.kernel.org/patch/7293981/ The discussion stopped because Tomi lacked the time to work on it. changes in v6: - trim the list of included headers - remove useless definition of BKL_FULL_BRIGHTNESS changes in v5: - removed LED brightness scaling - disable sysfs the interface of the LEDs when used by the backlight device changes in v4: - fix dev_err() messages and commit logs following the advices of Pavel - cosmetic changes (indents, getting rid of "? 1 : 0" in led_match_led_node()) changes in v3: - dt binding: don't limit the brightness range to 0-255. Use the range of the underlying LEDs. as a side-effect, all LEDs must now have the same range - driver: Adapt to dt binding update. - driver: rework probe() for clarity and remove the remaining goto. changes in v2: - handle more than one LED. - don't make the backlight device a child of the LED controller. - make brightness-levels and default-brightness-level optional - removed the option to use a GPIO enable. - removed the option to use a regulator. It should be handled by the LED core - don't make any change to the LED core (not needed anymore) Jean-Jacques Hiblot (2): leds: Add managed API to get a LED from a device driver dt-bindings: backlight: Add led-backlight binding Tomi Valkeinen (2): leds: Add of_led_get() and led_put() backlight: add led-backlight driver .../bindings/leds/backlight/led-backlight.txt | 28 ++ drivers/leds/led-class.c | 92 +++++++ drivers/video/backlight/Kconfig | 7 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/led_bl.c | 260 ++++++++++++++++++ include/linux/leds.h | 6 + 6 files changed, 394 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt create mode 100644 drivers/video/backlight/led_bl.c -- 2.17.1

3 6

[PATCH v7 0/7] qcom: add OCMEM support
by Brian Masney 10 Sep '19

10 Sep '19

This patch series adds support for Qualcomm's On Chip MEMory (OCMEM) that is needed in order to support some a3xx and a4xx-based GPUs upstream. This is based on Rob Clark's patch series that he submitted in October 2015 and I am resubmitting updated patches with his permission. See the individual patches for the changelog. This was tested with the GPU on a LG Nexus 5 (hammerhead) phone and this will work on other msm8974-based systems. For a summary of what currently works upstream on the Nexus 5, see my status page at https://masneyb.github.io/nexus-5-upstream/. Changes since v6: - link to gmu-sram child node in device tree - add ranges property to ocmem example in adreno GMU example (patch 2) to match bindings in patch 1 See individual patches for changelogs for previous versions. Brian Masney (5): dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings dt-bindings: display: msm: gmu: add optional ocmem property soc: qcom: add OCMEM driver drm/msm/gpu: add ocmem init/cleanup functions ARM: qcom_defconfig: add ocmem support Rob Clark (2): firmware: qcom: scm: add OCMEM lock/unlock interface firmware: qcom: scm: add support to restore secure config to qcm_scm-32 .../devicetree/bindings/display/msm/gmu.txt | 51 +++ .../devicetree/bindings/sram/qcom,ocmem.yaml | 96 ++++ arch/arm/configs/qcom_defconfig | 1 + drivers/firmware/qcom_scm-32.c | 52 ++- drivers/firmware/qcom_scm-64.c | 12 + drivers/firmware/qcom_scm.c | 53 +++ drivers/firmware/qcom_scm.h | 9 + drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 28 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.h | 3 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 25 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.h | 3 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 40 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.h | 10 + drivers/soc/qcom/Kconfig | 10 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/ocmem.c | 433 ++++++++++++++++++ include/linux/qcom_scm.h | 26 ++ include/soc/qcom/ocmem.h | 62 +++ 19 files changed, 871 insertions(+), 45 deletions(-) create mode 100644 Documentation/devicetree/bindings/sram/qcom,ocmem.yaml create mode 100644 drivers/soc/qcom/ocmem.c create mode 100644 include/soc/qcom/ocmem.h -- 2.21.0

4 12

[PATCH v4 0/6] drm/i915/dp: Support for DP HDR outputs
by Gwan-gyeong Mun 10 Sep '19

10 Sep '19

Support for HDR10 video was introduced in DisplayPort 1.4. On GLK+ platform, in order to use DisplayPort HDR10, we need to support BT.2020 colorimetry and HDR Static metadata. It implements the CTA-861-G standard for transport of static HDR metadata. It enables writing of HDR metadata infoframe SDP to the panel. The HDR Metadata will be provided by userspace compositors, based on blending policies and passed to the driver through a blob property. And It refactors, renames and extends a function which handled vsc sdp header and data block setup for supporting colorimetry format. And It attaches the colorspace connector property and HDR metadata property to a DisplayPort connector. These patches tested on below test environment. Test Environment: - Tested System: GLK and Gen11 platform. - Monitor: Dell UP2718Q 4K HDR Monitor. - In order to test DP HDR10, test environment uses patched Kodi-gbm, patched Media driver and HDR10 video. You can find these on below. [patched Kodi-gbm] - repo: https://github.com/Kwiboo/xbmc/tree/drmprime-hdr [download 4K HDR video file] - link: https://4kmedia.org/lg-new-york-hdr-uhd-4k-demo/ [Media Driver for GLK] - repo https://gitlab.freedesktop.org/emersion/intel-vaapi-driver master branch [Media Driver for ICL] - repo: https://github.com/harishkrupo/media-driver/tree/p010_composite v2: - Add a missed blank line after function declaration. - Remove useless parentheses. - Minor style fix. v3: - Remove not handled return values from intel_dp_setup_hdr_metadata_infoframe_sdp(). [Uma] - Add handling of different register size for HDMI_PACKET_TYPE_GAMUT_METADATA on hsw_dip_data_size() for each GEN platforms [Uma] - Add new colorimetry options for DP 1.4a spec. [Ville] - Separate set of colorimetry enum values for DP. [Ville] - In order to checking output format and output colorspace on intel_dp_needs_vsc_sdp(), it passes entire intel_crtc_state stucture.[Ville] - Remove a pointless variable. [Ville] v4: - Add additional comments to struct drm_prop_enum_list. - Polishing an enum string of struct drm_prop_enum_list. Gwan-gyeong Mun (7): drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA drm: Add DisplayPort colorspace property drm/i915/dp: Attach colorspace property drm/i915: Add new GMP register size for GEN11 drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata drm/i915/dp: Attach HDR metadata property to DP connector drivers/gpu/drm/drm_connector.c | 46 +++++ drivers/gpu/drm/i915/display/intel_ddi.c | 10 +- drivers/gpu/drm/i915/display/intel_display.h | 2 - .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/display/intel_dp.c | 193 ++++++++++++++++-- drivers/gpu/drm/i915/display/intel_dp.h | 7 + drivers/gpu/drm/i915/display/intel_hdmi.c | 10 +- drivers/gpu/drm/i915/i915_reg.h | 1 + include/drm/drm_connector.h | 8 + 9 files changed, 259 insertions(+), 21 deletions(-) -- 2.23.0

5 22

Adreno crash on i.MX53 running 5.3-rc6
by Fabio Estevam 10 Sep '19

10 Sep '19

Hi, I am getting the following crash when booting the adreno driver on i.MX53 running a 5.3-rc6 kernel. Such error does not happen with 5.2 though. Before I start running a bisect, I am wondering if anyone has any ideas about this issue. Thanks, Fabio Estevam [ 2.083249] 8<--- cut here --- [ 2.086460] Unable to handle kernel paging request at virtual address 50001000 [ 2.094174] pgd = (ptrval) [ 2.096911] [50001000] *pgd=00000000 [ 2.100606] Internal error: Oops: 805 [#1] SMP ARM [ 2.105412] Modules linked in: [ 2.108487] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.3.0-rc6-00271-g9f159ae07f07 #4 [ 2.116411] Hardware name: Freescale i.MX53 (Device Tree Support) [ 2.122538] PC is at v7_dma_clean_range+0x20/0x38 [ 2.127254] LR is at __dma_page_cpu_to_dev+0x28/0x90 [ 2.132226] pc : [<c011c76c>] lr : [<c01181c4>] psr: 20000013 [ 2.138500] sp : d80b5a88 ip : de96c000 fp : d840ce6c [ 2.143732] r10: 00000000 r9 : 00000001 r8 : d843e010 [ 2.148964] r7 : 00000000 r6 : 00008000 r5 : ddb6c000 r4 : 00000000 [ 2.155500] r3 : 0000003f r2 : 00000040 r1 : 50008000 r0 : 50001000 [ 2.162037] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 2.169180] Control: 10c5387d Table: 70004019 DAC: 00000051 [ 2.174934] Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) [ 2.180949] Stack: (0xd80b5a88 to 0xd80b6000) [ 2.185319] 5a80: c011c7bc d8491780 d840ce6c d849b380 00000000 c011822c [ 2.193509] 5aa0: c0d01a18 c0118abc c0118a78 d84a0200 00000008 c1308908 d838e800 d849a4a8 [ 2.201697] 5ac0: d8491780 c06699b4 ffffffff ffffffff 00000000 d8491600 d80b5b20 d84a0200 [ 2.209886] 5ae0: d8491780 d8491600 d80b5b20 d8491600 d849a4a8 d84a0200 00000003 d84a0358 [ 2.218077] 5b00: c1308908 d8491600 d849a4a8 d8491780 d840ce6c c066a55c c1308908 c066a104 [ 2.226266] 5b20: 01001000 00000000 d84a0200 10700ac6 d849a480 d84a0200 00000000 d8491600 [ 2.234455] 5b40: 00000000 e0845000 c1308908 c066a72c d849a480 d840ce6c d840ce00 c1308908 [ 2.242643] 5b60: 00000000 c066b584 d849a488 d849a4a8 00000000 c1308908 d840ce6c c066ff40 [ 2.250832] 5b80: d849a488 d849a4a8 00000000 c1308908 00000000 d81b4000 00000000 e0845000 [ 2.259021] 5ba0: d838e800 c1308908 d8491600 10700ac6 d80b5bc8 d840ce00 d840ce6c 00000001 [ 2.267210] 5bc0: 00000000 e0845000 d838e800 c066ece4 01000000 00000000 10ff0000 00000000 [ 2.275399] 5be0: c1308908 00000001 d81b4000 00000000 01000000 00000000 00000001 10700ac6 [ 2.283587] 5c00: c0d6d564 d840ce00 d81b4010 00000001 d81b4000 c0d6d564 c1308908 d80b5c48 [ 2.291777] 5c20: d838e800 c061f9cc c1029dec d80b5c48 d838e800 00000000 00000000 c13e8788 [ 2.299965] 5c40: ffffffff c1308928 c102a234 00000000 01000000 00000000 10ff0000 00000000 [ 2.308154] 5c60: 00000001 00000000 a0000013 10700ac6 c13b7658 d840ce00 d838e800 d81b4000 [ 2.316343] 5c80: d840ce00 c1308908 00000002 d838f800 00000000 c0620514 00000001 10700ac6 [ 2.324531] 5ca0: d8496440 00000000 d81b4010 c1aa1c00 d838e800 c061e070 00000000 00000000 [ 2.332720] 5cc0: 00000000 c0d6c534 df56cf34 000000c8 00000000 10700ac6 d81b4010 00000000 [ 2.340909] 5ce0: 00000000 d8496440 d838e800 c103acd0 d8496280 00000000 c1380488 c06a3e10 [ 2.349097] 5d00: 00000000 00000000 ffffffff d838f800 d838e800 d843e010 d8496440 c1308908 [ 2.357286] 5d20: 00000000 d83f9640 c1380488 c0668554 00000006 00000007 c13804d4 d83f9640 [ 2.365475] 5d40: c1380488 c017ec18 d80c0000 c0c43e40 d843e010 d8496440 00000001 c0182a94 [ 2.373665] 5d60: 60000013 10700ac6 d843e010 d8496280 d8496400 00000018 d8496440 00000001 [ 2.381854] 5d80: c13804d4 d83f9640 c1380488 c06a4280 c1380488 00000000 c0d764f8 d8496440 [ 2.390044] 5da0: c1380488 d843e010 c0d764f8 c1308908 00000000 00000000 c13ef300 c06a44f0 [ 2.398232] 5dc0: c0d8a0dc dffcc6f0 d843e010 dffcc6f0 00000000 d843e010 00000000 c06680b8 [ 2.406421] 5de0: d84988c0 d83f9640 d84988c0 d84989a0 d8498230 10700ac6 00000001 d843e010 [ 2.414610] 5e00: 00000000 c137eec0 00000000 c137eec0 00000000 00000000 c13ef300 c06ac1a0 [ 2.422799] 5e20: d843e010 c1aa40dc c1aa40e0 00000000 c137eec0 c06aa014 d843e010 c137eec0 [ 2.430988] 5e40: c137eec0 c1308908 c13e9880 c13e85d4 00000000 c06aa368 c1308908 c13e9880 [ 2.439178] 5e60: c13e85d4 d843e010 00000000 c137eec0 c1308908 c13e9880 c13e85d4 c06aa618 [ 2.447367] 5e80: 00000000 c137eec0 d843e010 c06aa6a4 00000000 c137eec0 c06aa620 c06a844c [ 2.455556] 5ea0: d80888d4 d80888a4 d84914d0 10700ac6 d80888d4 c137eec0 d8494f00 c1380d28 [ 2.463745] 5ec0: 00000000 c06a946c c105f3d4 c1308908 00000000 c137eec0 c1308908 00000000 [ 2.471934] 5ee0: c125fdd0 c06ab304 c1308928 c1308908 00000000 c0103178 00000109 00000000 [ 2.480123] 5f00: dffffc6e dffffc00 c1126860 00000109 00000109 c014dc88 c11253ac c10607a0 [ 2.488312] 5f20: 00000000 00000006 00000006 00000000 c12adeec dffffc6e 00000000 10700ac6 [ 2.496501] 5f40: c1308f18 10700ac6 00000007 c13e9880 c13ef300 c1294850 c1308928 c12ae4c4 [ 2.504690] 5f60: 00000000 c12011f8 00000006 00000006 00000000 c120066c 00000000 00000109 [ 2.512878] 5f80: 00000000 00000000 c0c3bb28 00000000 00000000 00000000 00000000 00000000 [ 2.521066] 5fa0: 00000000 c0c3bb30 00000000 c01010b4 00000000 00000000 00000000 00000000 [ 2.529255] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 2.537443] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 2.545640] [<c011c76c>] (v7_dma_clean_range) from [<c01181c4>] (__dma_page_cpu_to_dev+0x28/0x90) [ 2.554526] [<c01181c4>] (__dma_page_cpu_to_dev) from [<c0118abc>] (arm_dma_sync_sg_for_device+0x44/0x64) [ 2.564121] [<c0118abc>] (arm_dma_sync_sg_for_device) from [<c06699b4>] (get_pages+0x1ac/0x214) [ 2.572834] [<c06699b4>] (get_pages) from [<c066a55c>] (msm_gem_get_and_pin_iova+0xb0/0x13c) [ 2.581284] [<c066a55c>] (msm_gem_get_and_pin_iova) from [<c066a72c>] (_msm_gem_kernel_new+0x38/0xa8) [ 2.590515] [<c066a72c>] (_msm_gem_kernel_new) from [<c066b584>] (msm_gem_kernel_new+0x24/0x2c) [ 2.599230] [<c066b584>] (msm_gem_kernel_new) from [<c066ff40>] (msm_ringbuffer_new+0x68/0x140) [ 2.607940] [<c066ff40>] (msm_ringbuffer_new) from [<c066ece4>] (msm_gpu_init+0x430/0x5fc) [ 2.616220] [<c066ece4>] (msm_gpu_init) from [<c061f9cc>] (adreno_gpu_init+0x16c/0x298) [ 2.624236] [<c061f9cc>] (adreno_gpu_init) from [<c0620514>] (a2xx_gpu_init+0x84/0x104) [ 2.632252] [<c0620514>] (a2xx_gpu_init) from [<c061e070>] (adreno_bind+0x190/0x274) [ 2.640018] [<c061e070>] (adreno_bind) from [<c06a3e10>] (component_bind_all+0xe8/0x22c) [ 2.648124] [<c06a3e10>] (component_bind_all) from [<c0668554>] (msm_drm_bind+0xf4/0x610) [ 2.656315] [<c0668554>] (msm_drm_bind) from [<c06a4280>] (try_to_bring_up_master+0x158/0x198) [ 2.664940] [<c06a4280>] (try_to_bring_up_master) from [<c06a44f0>] (component_master_add_with_match+0xb8/0xf8) [ 2.675042] [<c06a44f0>] (component_master_add_with_match) from [<c06680b8>] (msm_pdev_probe+0x214/0x28c) [ 2.684630] [<c06680b8>] (msm_pdev_probe) from [<c06ac1a0>] (platform_drv_probe+0x48/0x98) [ 2.692908] [<c06ac1a0>] (platform_drv_probe) from [<c06aa014>] (really_probe+0xec/0x2cc) [ 2.701099] [<c06aa014>] (really_probe) from [<c06aa368>] (driver_probe_device+0x5c/0x164) [ 2.709376] [<c06aa368>] (driver_probe_device) from [<c06aa618>] (device_driver_attach+0x58/0x60) [ 2.718259] [<c06aa618>] (device_driver_attach) from [<c06aa6a4>] (__driver_attach+0x84/0xc0) [ 2.726796] [<c06aa6a4>] (__driver_attach) from [<c06a844c>] (bus_for_each_dev+0x70/0xb4) [ 2.734985] [<c06a844c>] (bus_for_each_dev) from [<c06a946c>] (bus_add_driver+0x154/0x1e0) [ 2.743262] [<c06a946c>] (bus_add_driver) from [<c06ab304>] (driver_register+0x74/0x108) [ 2.751369] [<c06ab304>] (driver_register) from [<c0103178>] (do_one_initcall+0x80/0x32c) [ 2.759560] [<c0103178>] (do_one_initcall) from [<c12011f8>] (kernel_init_freeable+0x2e4/0x3c8) [ 2.768278] [<c12011f8>] (kernel_init_freeable) from [<c0c3bb30>] (kernel_init+0x8/0x114) [ 2.776469] [<c0c3bb30>] (kernel_init) from [<c01010b4>] (ret_from_fork+0x14/0x20) [ 2.784046] Exception stack(0xd80b5fb0 to 0xd80b5ff8) [ 2.789107] 5fa0: 00000000 00000000 00000000 00000000 [ 2.797295] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 2.805482] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 2.812111] Code: e1a02312 e2423001 e1c00003 e320f000 (ee070f3a) [ 2.818319] ---[ end trace cdc18b3504e6a4f8 ]---

4 13

[PATCH] drm: panel-lvds: Potential Oops in probe error handling
by Dan Carpenter 10 Sep '19

10 Sep '19

The "lvds->backlight" pointer could be NULl if of_parse_phandle() returns NULL. Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/panel/panel-lvds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index ad47cc95459e..3b4eb959e994 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev) return 0; error: - put_device(&lvds->backlight->dev); + if (lvds->backlight) + put_device(&lvds->backlight->dev); return ret; } -- 2.20.1

3 6

[PATCH] staging: android: ion: Replace strncpy() for stracpy()
by Adam Zerella 10 Sep '19

10 Sep '19

Using strncpy() does not always terminate the destination string. stracpy() is a alternative function that does, by using this new function we will no longer need to insert a null separator. Signed-off-by: Adam Zerella <adam.zerella(a)gmail.com> --- drivers/staging/android/ion/ion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index e6b1ca141b93..17901bd626be 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -433,8 +433,7 @@ static int ion_query_heaps(struct ion_heap_query *query) max_cnt = query->cnt; plist_for_each_entry(heap, &dev->heaps, node) { - strncpy(hdata.name, heap->name, MAX_HEAP_NAME); - hdata.name[sizeof(hdata.name) - 1] = '\0'; + stracpy(hdata.name, heap->name, MAX_HEAP_NAME); hdata.type = heap->type; hdata.heap_id = heap->id; -- 2.21.0

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019