dri-devel February 2020

dri-devel@lists.freedesktop.org

302 participants
679 discussions

[Bug 206383] New: [drm] [amdgpu] [TTM] memory leak/out of memory
by bugzilla-daemon＠bugzilla.kernel.org 03 Feb '20

03 Feb '20

https://bugzilla.kernel.org/show_bug.cgi?id=206383 Bug ID: 206383 Summary: [drm] [amdgpu] [TTM] memory leak/out of memory Product: Drivers Version: 2.5 Kernel Version: 5.5.0 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: info(a)aloisnespor.info Regression: No Created attachment 287053 --> https://bugzilla.kernel.org/attachment.cgi?id=287053&action=edit dmesg Hi all, i bought new computer with AMD Ryzen 5 3400G and try some 'older' (2015+) linux native games via native Steam or GOG. But mostly in all cases ended all with memory leak (out of memory) and freezing my computer. I try for example Cities:Skylines, Metro 2033 Redux, Metro: Last Light, Witcher 2 EE, but all ended with : [ 399.837627] [TTM] Failed to find memory space for buffer 0x0000000057dc96d3 eviction [ 399.837630] [TTM] No space for 0000000057dc96d3 (22457 pages, 89828K, 87M) [ 399.837631] [TTM] placement[0]=0x00060002 (1) [ 399.837632] [TTM] has_type: 1 [ 399.837632] [TTM] use_type: 1 [ 399.837633] [TTM] flags: 0x0000000A [ 399.837634] [TTM] gpu_offset: 0x00000000 [ 399.837634] [TTM] size: 786432 [ 399.837635] [TTM] available_caching: 0x00070000 [ 399.837640] [TTM] default_caching: 0x00010000 [ 399.837641] [TTM] 0x0000000000000400-0x0000000000000401: 1: used [ 399.837642] [TTM] 0x0000000000000401-0x0000000000000443: 66: used [ 399.837643] [TTM] 0x0000000000000443-0x0000000000000445: 2: used [ 399.837644] [TTM] 0x0000000000000445-0x0000000000000447: 2: used [ 399.837644] [TTM] 0x0000000000000447-0x0000000000000449: 2: used [ 399.837645] [TTM] 0x0000000000000449-0x000000000000044b: 2: used [ 399.837646] [TTM] 0x000000000000044b-0x000000000000044d: 2: used [ 399.837647] [TTM] 0x000000000000044d-0x000000000000044f: 2: used [ 399.837648] [TTM] 0x000000000000044f-0x0000000000000451: 2: used [ 399.837649] [TTM] 0x0000000000000451-0x0000000000000453: 2: used [ 399.837649] [TTM] 0x0000000000000453-0x0000000000000455: 2: used [ 399.837650] [TTM] 0x0000000000000455-0x0000000000000456: 1: used [ 399.837651] [TTM] 0x0000000000000456-0x0000000000000556: 256: used [ 399.837651] [TTM] 0x0000000000000556-0x0000000000000557: 1: used [ 399.837652] [TTM] 0x0000000000000557-0x0000000000000558: 1: used [ 399.837653] [TTM] 0x0000000000000558-0x0000000000000559: 1: used [ 399.837653] [TTM] 0x0000000000000559-0x000000000000055a: 1: used [ 399.837654] [TTM] 0x000000000000055a-0x000000000000055b: 1: used [ 399.837654] [TTM] 0x000000000000055b-0x000000000000055c: 1: used [ 399.837655] [TTM] 0x000000000000055c-0x000000000000055d: 1: used [ 399.837656] [TTM] 0x000000000000055d-0x000000000000055e: 1: used [ 399.837656] [TTM] 0x000000000000055e-0x0000000000000560: 2: used [ 399.837657] [TTM] 0x0000000000000560-0x0000000000000561: 1: used [ 399.837658] [TTM] 0x0000000000000561-0x0000000000000562: 1: used [ 399.837659] [TTM] 0x0000000000000562-0x0000000000000563: 1: used [ 399.837659] [TTM] 0x0000000000000563-0x0000000000000565: 2: used [ 399.837660] [TTM] 0x0000000000000565-0x0000000000000665: 256: used [ 399.837661] [TTM] 0x0000000000000665-0x0000000000000766: 257: used [ 399.837661] [TTM] 0x0000000000000766-0x0000000000000767: 1: used [ 399.837662] [TTM] 0x0000000000000767-0x0000000000000800: 153: free [ 399.837663] [TTM] 0x0000000000000800-0x0000000000000900: 256: used [ 399.837663] [TTM] 0x0000000000000900-0x0000000000000cca: 970: used [ 399.837664] [TTM] 0x0000000000000cca-0x0000000000040000: 258870: free [ 399.837665] [TTM] total: 261120, used 2097 free 259023 [ 399.837669] [TTM] man size:786432 pages, gtt available:1900 pages, usage:3064MB [ 399.837734] [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Not enough memory for command submission! My configuration: AMD Ryzen 3400G, 16GB RAM (tested by memtest86+, so should be no problem here), HP m01-F000 series with newest BIOS AGESA 1.0.0.4. Kernel linux-zen 5.5.zen1-1, linux-firmware-20200122.1eb2408, mesa-19.3.3,libdrm-2.4.100 lspci, dmesg you can see in attachment I see, i am not alone, who have this problem: https://bbs.archlinux.org/viewtopic.php?pid=1885581 Maybe is that bug of mesa, i dont know...but i begin here. Thanks! -- You are receiving this mail because: You are watching the assignee of the bug.

1 5

[PATCH 00/26] drm/i915: Pimp DP DFP handling
by Ville Syrjala 03 Feb '20

03 Feb '20

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Attempt to deal with DP downstream facing ports (DFP) more thoroughly. This involves reading more of the port caps and dealing with various clock/bpc limitations. Also we try to hook up the DP dual mode dongles into the mix (unfortunately I've not yet seen a DP++ DFP that would pass the dual mode adapter register i2c accesses through). And we try to enable YCbCr 444->420 conversion for HDMI DFPs which could allow some 4k displays to actually use 4k on pre-icl hardware (which doesn't have native 420 output), assuming we don't run into some other hardware limits. It's a bit on the large side but since it looks like other people are poking around the same area I figured I'd post the entire thing. Entire series available here: git://github.com/vsyrjala/linux.git dp_downstream_ports_5 Ville Syrjälä (26): drm/i915: Nuke pre-production GLK HDMI w/a 1139 drm/i915: Limit display Wa_1405510057 to gen11 drm/i915: Drop WaDDIIOTimeout:glk drm/i915: Add glk to intel_detect_preproduction_hw() drm/dp: Include the AUX CH name in the debug messages drm/i915/lspcon: Do not send infoframes to non-HDMI sinks drm/dp: Define protocol converter DPCD registers drm/dp: Define more downstream facing port caps drm/i915: Reworkd DFP max bpc handling drm/dp: Add helpers to identify downstream facing port types drm/dp: Pimp drm_dp_downstream_max_bpc() drm/dp: Redo drm_dp_downstream_max_clock() as drm_dp_downstream_max_dotclock() drm/i915: Reworkd DP DFP clock handling drm/i915: Dump downstream facing port caps drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock() drm/i915: Deal with TMDS DFP clock limits drm/i915: Configure DP 1.3+ protocol converted HDMI mode drm/dp: Add drm_dp_downstream_mode() drm/i915: Handle downstream facing ports w/o EDID drm/i915: Extract intel_hdmi_has_audio() drm/i915: DP->HDMI TMDS clock limits vs. deep color drm/dp: Add helpers for DFP YCbCr 4:2:0 handling drm/i915: Do YCbCr 444->420 conversion via DP protocol converters drm/i915: Decouple DP++ from the HDMI code drm/i915: Try to probe DP++ dongles on DP++ downstream facing ports drm/i915: Try to frob the TMDS buffer enable knob on DP++ dongles on DP DFPs drivers/gpu/drm/drm_dp_helper.c | 409 +++++++++++++++--- drivers/gpu/drm/drm_edid.c | 21 + drivers/gpu/drm/i915/display/intel_ddi.c | 23 +- .../drm/i915/display/intel_display_types.h | 22 +- drivers/gpu/drm/i915/display/intel_dp.c | 367 ++++++++++++++-- drivers/gpu/drm/i915/display/intel_dp.h | 1 + drivers/gpu/drm/i915/display/intel_hdmi.c | 181 ++++---- drivers/gpu/drm/i915/display/intel_hdmi.h | 11 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/intel_pm.c | 10 - include/drm/drm_dp_helper.h | 63 ++- include/drm/drm_edid.h | 4 + 14 files changed, 904 insertions(+), 215 deletions(-) -- 2.24.1

1 26

[PATCH 1/2] drm: Add a detailed DP HDMI branch info on debugfs
by Gwan-gyeong Mun 03 Feb '20

03 Feb '20

When DP downstream has HDMI branch, it checks below functionality and shows supports. It follows DP 1.4a spec; Table 2-161: Address Mapping within DPCD Receiver Capability Field (DPCD Addresses 00000h through 000FFh). Added flags for DP downstream: YCBCR422_PASS_THROUGH_SUPPORT, YCBCR420_PASS_THROUGH_SUPPORT, CONVERSION_FROM_YCBCR444_TO_YCBCR422_SUPPORT and CONVERSION_FROM_YCBCR444_TO_YCBCR420_SUPPORT. Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun(a)intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 19 +++++++++++++++++++ include/drm/drm_dp_helper.h | 5 +++++ 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 5a103e9b3c86..cb6dcfb13127 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -531,6 +531,25 @@ void drm_dp_downstream_debug(struct seq_file *m, if (bpc > 0) seq_printf(m, "\t\tMax bpc: %d\n", bpc); + + if (type == DP_DS_PORT_TYPE_HDMI) { + bool ycbcr422_passthru = port_cap[3] & + DP_DS_YCBCR422_PASSTHRU_SUPPORT; + bool ycbcr420_passthru = port_cap[3] & + DP_DS_YCBCR420_PASSTHRU_SUPPORT; + bool ycbcr422_convert = port_cap[3] & + DP_DS_CONV_YCBCR444_TO_YCBCR422_SUPPORT; + bool ycbcr420_convert = port_cap[3] & + DP_DS_CONV_YCBCR444_TO_YCBCR420_SUPPORT; + seq_printf(m, "\t\tHDMI YCbCr 4:2:2 pass-through support: %s\n", + ycbcr422_passthru ? "yes" : "no"); + seq_printf(m, "\t\tHDMI YCbCr 4:2:0 pass-through support: %s\n", + ycbcr420_passthru ? "yes" : "no"); + seq_printf(m, "\t\tHDMI YCbCr 4:4:4 to YCbCr 4:2:2 Convert support: %s\n", + ycbcr422_convert ? "yes" : "no"); + seq_printf(m, "\t\tHDMI YCbCr 4:4:4 to YCbCr 4:2:0 Convert support: %s\n", + ycbcr420_convert ? "yes" : "no"); + } } } EXPORT_SYMBOL(drm_dp_downstream_debug); diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 262faf9e5e94..d61eadaba769 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -391,6 +391,11 @@ # define DP_DS_10BPC 1 # define DP_DS_12BPC 2 # define DP_DS_16BPC 3 +/* offset 3 for HDMI */ +# define DP_DS_YCBCR422_PASSTHRU_SUPPORT (1 << 1) /* 1.4 */ +# define DP_DS_YCBCR420_PASSTHRU_SUPPORT (1 << 2) +# define DP_DS_CONV_YCBCR444_TO_YCBCR422_SUPPORT (1 << 3) +# define DP_DS_CONV_YCBCR444_TO_YCBCR420_SUPPORT (1 << 4) #define DP_MAX_DOWNSTREAM_PORTS 0x10 -- 2.24.1

2 2

KASAN: use-after-free Read in vgem_gem_dumb_create
by syzbot 03 Feb '20

03 Feb '20

Hello, syzbot found the following crash on: HEAD commit: 39bed42d Merge tag 'for-linus-hmm' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=179465bee00000 kernel config: https://syzkaller.appspot.com/x/.config?x=2646535f8818ae25 dashboard link: https://syzkaller.appspot.com/bug?extid=0dc4444774d419e916c8 compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16251279e00000 The bug was bisected to: commit 7611750784664db46d0db95631e322aeb263dde7 Author: Alex Deucher <alexander.deucher(a)amd.com> Date: Wed Jun 21 16:31:41 2017 +0000 drm/amdgpu: use kernel is_power_of_2 rather than local version bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11628df1e00000 final crash: https://syzkaller.appspot.com/x/report.txt?x=13628df1e00000 console output: https://syzkaller.appspot.com/x/log.txt?x=15628df1e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+0dc4444774d419e916c8(a)syzkaller.appspotmail.com Fixes: 761175078466 ("drm/amdgpu: use kernel is_power_of_2 rather than local version") ================================================================== BUG: KASAN: use-after-free in vgem_gem_dumb_create+0x238/0x250 drivers/gpu/drm/vgem/vgem_drv.c:221 Read of size 8 at addr ffff88809fa67908 by task syz-executor.0/14871 CPU: 0 PID: 14871 Comm: syz-executor.0 Not tainted 5.5.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x197/0x210 lib/dump_stack.c:118 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374 __kasan_report.cold+0x1b/0x32 mm/kasan/report.c:506 kasan_report+0x12/0x20 mm/kasan/common.c:639 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:135 vgem_gem_dumb_create+0x238/0x250 drivers/gpu/drm/vgem/vgem_drv.c:221 drm_mode_create_dumb+0x282/0x310 drivers/gpu/drm/drm_dumb_buffers.c:94 drm_mode_create_dumb_ioctl+0x26/0x30 drivers/gpu/drm/drm_dumb_buffers.c:100 drm_ioctl_kernel+0x244/0x300 drivers/gpu/drm/drm_ioctl.c:786 drm_ioctl+0x54e/0xa60 drivers/gpu/drm/drm_ioctl.c:886 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl+0x123/0x180 fs/ioctl.c:747 __do_sys_ioctl fs/ioctl.c:756 [inline] __se_sys_ioctl fs/ioctl.c:754 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:754 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45b349 Code: ad b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f871af46c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f871af476d4 RCX: 000000000045b349 RDX: 0000000020000180 RSI: 00000000c02064b2 RDI: 0000000000000003 RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff R13: 0000000000000285 R14: 00000000004d14d0 R15: 000000000075bf2c Allocated by task 14871: save_stack+0x23/0x90 mm/kasan/common.c:72 set_track mm/kasan/common.c:80 [inline] __kasan_kmalloc mm/kasan/common.c:513 [inline] __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:486 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:527 kmem_cache_alloc_trace+0x158/0x790 mm/slab.c:3551 kmalloc include/linux/slab.h:556 [inline] kzalloc include/linux/slab.h:670 [inline] __vgem_gem_create+0x49/0x100 drivers/gpu/drm/vgem/vgem_drv.c:165 vgem_gem_create drivers/gpu/drm/vgem/vgem_drv.c:194 [inline] vgem_gem_dumb_create+0xd7/0x250 drivers/gpu/drm/vgem/vgem_drv.c:217 drm_mode_create_dumb+0x282/0x310 drivers/gpu/drm/drm_dumb_buffers.c:94 drm_mode_create_dumb_ioctl+0x26/0x30 drivers/gpu/drm/drm_dumb_buffers.c:100 drm_ioctl_kernel+0x244/0x300 drivers/gpu/drm/drm_ioctl.c:786 drm_ioctl+0x54e/0xa60 drivers/gpu/drm/drm_ioctl.c:886 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl+0x123/0x180 fs/ioctl.c:747 __do_sys_ioctl fs/ioctl.c:756 [inline] __se_sys_ioctl fs/ioctl.c:754 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:754 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe Freed by task 14871: save_stack+0x23/0x90 mm/kasan/common.c:72 set_track mm/kasan/common.c:80 [inline] kasan_set_free_info mm/kasan/common.c:335 [inline] __kasan_slab_free+0x102/0x150 mm/kasan/common.c:474 kasan_slab_free+0xe/0x10 mm/kasan/common.c:483 __cache_free mm/slab.c:3426 [inline] kfree+0x10a/0x2c0 mm/slab.c:3757 vgem_gem_free_object+0xbe/0xe0 drivers/gpu/drm/vgem/vgem_drv.c:68 drm_gem_object_free+0x100/0x220 drivers/gpu/drm/drm_gem.c:983 kref_put include/linux/kref.h:65 [inline] drm_gem_object_put_unlocked drivers/gpu/drm/drm_gem.c:1017 [inline] drm_gem_object_put_unlocked+0x196/0x1c0 drivers/gpu/drm/drm_gem.c:1002 vgem_gem_create drivers/gpu/drm/vgem/vgem_drv.c:199 [inline] vgem_gem_dumb_create+0x115/0x250 drivers/gpu/drm/vgem/vgem_drv.c:217 drm_mode_create_dumb+0x282/0x310 drivers/gpu/drm/drm_dumb_buffers.c:94 drm_mode_create_dumb_ioctl+0x26/0x30 drivers/gpu/drm/drm_dumb_buffers.c:100 drm_ioctl_kernel+0x244/0x300 drivers/gpu/drm/drm_ioctl.c:786 drm_ioctl+0x54e/0xa60 drivers/gpu/drm/drm_ioctl.c:886 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl+0x123/0x180 fs/ioctl.c:747 __do_sys_ioctl fs/ioctl.c:756 [inline] __se_sys_ioctl fs/ioctl.c:754 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:754 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe The buggy address belongs to the object at ffff88809fa67800 which belongs to the cache kmalloc-1k of size 1024 The buggy address is located 264 bytes inside of 1024-byte region [ffff88809fa67800, ffff88809fa67c00) The buggy address belongs to the page: page:ffffea00027e99c0 refcount:1 mapcount:0 mapping:ffff8880aa400c40 index:0x0 raw: 00fffe0000000200 ffffea0002293548 ffffea00023e1f08 ffff8880aa400c40 raw: 0000000000000000 ffff88809fa67000 0000000100000002 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffff88809fa67800: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff88809fa67880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >ffff88809fa67900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff88809fa67980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff88809fa67a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

4 5

[Regression 5.5-rc1] Extremely low GPU performance on NVIDIA Tegra20/30
by Dmitry Osipenko 03 Feb '20

03 Feb '20

Hello Thierry, Commit [1] introduced a severe GPU performance regression on Tegra20 and Tegra30 using. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… Interestingly the performance is okay on Tegra30 if CONFIG_TEGRA_HOST1X_FIREWALL=n, but that doesn't make difference for Tegra20. I was telling you about this problem on the #tegra IRC sometime ago and you asked to report it in a trackable form, so finally here it is. You could reproduce the problem by running [2] like this `grate/texture-filter -f -s` which should produce over 100 FPS for 720p display resolution and currently it's ~11 FPS. [2] https://github.com/grate-driver/grate/blob/master/tests/grate/texture-filte… Previously I was seeing some memory errors coming from Host1x DMA, but don't see any errors at all right now. I don't see anything done horribly wrong in the offending commit. Unfortunately I couldn't dedicate enough time to sit down and debug the problem thoroughly yet. Please let me know if you'll find a solution, I'll be happy to test it. Thanks in advance!

2 9

nouveau-fixes 5.6
by Ben Skeggs 03 Feb '20

03 Feb '20

Hey, Just a couple of fixes to Volta/Turing modesetting on some systems. Thanks, Ben. The following changes since commit c3463aed05abf06bd5ebaac12f2c015db298b98f: drm/nouveau/fb/gp102-: allow module to load even when scrubber binary is missing (2020-01-29 15:49:56 +1000) are available in the Git repository at: git://github.com/skeggsb/linux linux-5.6 for you to fetch changes up to 137c4ba7163ad9d5696b9fde78b1c0898a9c115b: drm/nouveau/kms/gv100-: avoid sending a core update until the first modeset (2020-02-03 21:36:54 +1000) ---------------------------------------------------------------- Ben Skeggs (3): drm/nouveau/disp/gv100-: halt NV_PDISP_FE_RM_INTR_STAT_CTRL_DISP_ERROR storms drm/nouveau/kms/gv100-: move window ownership setup into modesetting path drm/nouveau/kms/gv100-: avoid sending a core update until the first modeset drivers/gpu/drm/nouveau/dispnv50/core.h | 6 ++++++ drivers/gpu/drm/nouveau/dispnv50/corec37d.c | 23 ++++++++++++++++++----- drivers/gpu/drm/nouveau/dispnv50/corec57d.c | 9 ++++----- drivers/gpu/drm/nouveau/dispnv50/disp.c | 16 ++++++++++++++++ drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c | 6 ++++++ 5 files changed, 50 insertions(+), 10 deletions(-)

1 0

[PATCH 2/2] drm/i915/dp: Add checking of YCBCR420 Pass-through to YCBCR420 outputs.
by Gwan-gyeong Mun 03 Feb '20

03 Feb '20

When a DP downstream uses a DP to HDMI active converter, the active converter needs to support YCbCr420 Pass-through to enable DP YCbCr 4:2:0 outputs. Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun(a)intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 26 +++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index f4dede6253f8..824ed8096426 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2298,6 +2298,22 @@ intel_dp_compute_link_config(struct intel_encoder *encoder, return 0; } +static bool +intel_dp_downstream_is_hdmi_detailed_cap_info(struct intel_dp *intel_dp) +{ + int type = intel_dp->downstream_ports[0] & DP_DS_PORT_TYPE_MASK; + bool detailed_cap_info = intel_dp->dpcd[DP_DOWNSTREAMPORT_PRESENT] & + DP_DETAILED_CAP_INFO_AVAILABLE; + + return type == DP_DS_PORT_TYPE_HDMI && detailed_cap_info; +} + +static bool +intel_dp_downstream_supports_ycbcr_420_passthru(struct intel_dp *intel_dp) +{ + return intel_dp->downstream_ports[3] & DP_DS_YCBCR420_PASSTHRU_SUPPORT; +} + static int intel_dp_ycbcr420_config(struct intel_dp *intel_dp, struct drm_connector *connector, @@ -2314,6 +2330,16 @@ intel_dp_ycbcr420_config(struct intel_dp *intel_dp, !connector->ycbcr_420_allowed) return 0; + /* + * When a DP downstream uses a DP to HDMI active converter, + * the active converter needs to support YCbCr420 Pass-through. + */ + if (drm_dp_is_branch(intel_dp->dpcd)) { + if (intel_dp_downstream_is_hdmi_detailed_cap_info(intel_dp) && + !intel_dp_downstream_supports_ycbcr_420_passthru(intel_dp)) + return 0; + } + crtc_state->output_format = INTEL_OUTPUT_FORMAT_YCBCR420; /* YCBCR 420 output conversion needs a scaler */ -- 2.24.1

1 0

[PATCH 0/4] drm/vram: Check display modes against available VRAM
by Thomas Zimmermann 03 Feb '20

03 Feb '20

This adds drm_vram_helper_mode_valid(), which tests a display mode against the available video memory. It's a helper function to sort out display modes that cannot be used because of a lack of video memory. The ast driver already implemented this test for a while. The patchset converts ast over to the helper and adds the test to the over drivers that use VRAM helpers; except mgag200. I left out mgag200 as it doesn't have atomic modesetting yet and needs adjustments to memory management first. Thomas Zimmermann (4): drm/vram: Add helpers to validate a display mode's memory requirements drm/bochs: Implement struct drm_mode_config_funcs.mode_valid drm/hibmc: Implement struct drm_mode_config_funcs.mode_valid drm/vboxvideo: Implement struct drm_mode_config_funcs.mode_valid drivers/gpu/drm/ast/ast_main.c | 24 +------ drivers/gpu/drm/bochs/bochs_kms.c | 1 + drivers/gpu/drm/drm_gem_vram_helper.c | 76 +++++++++++++++++++++ drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 1 + drivers/gpu/drm/vboxvideo/vbox_mode.c | 1 + include/drm/drm_gem_vram_helper.h | 14 ++++ 6 files changed, 94 insertions(+), 23 deletions(-) -- 2.25.0

3 12

fbtft: 5 years in staging
by Noralf Trønnes 03 Feb '20

03 Feb '20

Hi, Since I'm the original author of fbtft I thought I'd highlight a couple of issues that's probably not well known. Right after fbtft was added, fbdev was closed for new drivers[1] and the fbdev maintainer wanted to remove fbtft as a consequence of that decision, but Greg KH said he'd keep fbtft drivers in staging "until a matching DRM driver is present in the tree"[2]. There are 2 issues wrt the goal of making a matching DRM driver (strictly speaking). One is impossible to do (policy), the other is unlikely to happen: 1. Device Tree 'init' property All fbtft drivers have controller setup code that matches one particular display panel. From the start of fbtft it was possible to override this using platform data. Later when Device Tree support was added, an 'init=' property to do the same was added. Example: init = <0x10000e5 0x78F0 0x1000001 0x0100 0x2000032 0x1000007 0x0133>; This translates to: register_write(0x00e5, 0x78F0); register_write(0x0001, 0x0100); mdelay(32); register_write(0x0007, 0x0133); AFAIU setting register values from DT is a no-go, so this functionality can't be replicated in a DRM driver. Many displays are made to work using this mechanism, in particular ili9341 based ones. 2. Parallel bus interface All fbtft drivers support both a SPI and a parallel bus interface through the fbtft helper module. Many (not all) controllers support more than one interface. The parallel bus support was added to fbtft in its early days when not many SPI displays were available (nowadays there's lots to choose from). fbtft uses bitbanging to drive the parallel interface so it's really slow, even more slow than SPI and SPI with DMA beats it thoroughly. I know there are people that use the paralell bus support, but I don't see much point in it unless we get a parallel bus subsystem that can use the dedicated hw on certain SoC's (Beaglebone, Pi). And those SOC's most likely have a parallel video/RGB bus as well, which IMO is a much better option for a panel. The following drivers have DRM counterparts that have the same panel setup code: - fb_hx8357d.c: drivers/gpu/drm/tiny/hx8357d.c - fb_ili9341.c: drivers/gpu/drm/tiny/mi0283qt.c - fb_st7735r.c: drivers/gpu/drm/tiny/st7735r.c - fb_ili9486.c: Patches are posted on dri-devel[3] But they don't support all panels based on that controller and they don't have parallel bus support. There is actually also another obstacle for conversion and that is, some of the displays (for which there is builtin driver support) might be impossible to source except as second hand. And it's not always obvious which panel is supported by a certain driver. At least the displays supported by these drivers are listed as discontinued on the fbtft wiki[4]: - fb_hx8340bn.c - fb_hx8347d.c - fb_ili9320 This one never made it from a prototype to an actual product, because it was too slow: - fb_watterott.c I have no plans to convert fbtft drivers myself, but I figured a 5 year anniversary was a good excuse for a status update. Noralf. [1] https://lkml.org/lkml/2015/9/24/253 [2] https://lkml.org/lkml/2016/11/23/146 [3] https://patchwork.freedesktop.org/series/72645/ [4] https://github.com/notro/fbtft/wiki/LCD-Modules#discontinued-products

3 3

[PATCH v3] drm/dp_mst: Fix W=1 warnings
by Benjamin Gaignard 03 Feb '20

03 Feb '20

Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard <benjamin.gaignard(a)st.com> --- CC: Jani Nikula <jani.nikula(a)linux.intel.com> changes in version 3: - remove the hunk that may conflict with c485e2c97dae ("drm/dp_mst: Refactor pdt setup/teardown, add more locking") changes in version 2: - fix indentations - when possible change functions prototype to void drivers/gpu/drm/drm_dp_mst_topology.c | 83 +++++++++++++---------------------- 1 file changed, 31 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 1437bc46368b..d5cb5688b5dd 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -674,7 +674,6 @@ static bool drm_dp_sideband_msg_build(struct drm_dp_sideband_msg_rx *msg, u8 *replybuf, u8 replybuflen, bool hdr) { int ret; - u8 crc4; if (hdr) { u8 hdrlen; @@ -716,8 +715,6 @@ static bool drm_dp_sideband_msg_build(struct drm_dp_sideband_msg_rx *msg, } if (msg->curchunk_idx >= msg->curchunk_len) { - /* do CRC */ - crc4 = drm_dp_msg_data_crc4(msg->chunk, msg->curchunk_len - 1); /* copy chunk into bigger msg */ memcpy(&msg->msg[msg->curlen], msg->chunk, msg->curchunk_len - 1); msg->curlen += msg->curchunk_len - 1; @@ -1014,7 +1011,7 @@ static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw, } } -static int build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes, u8 *bytes) +static void build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes, u8 *bytes) { struct drm_dp_sideband_msg_req_body req; @@ -1024,17 +1021,14 @@ static int build_dpcd_write(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 req.u.dpcd_write.num_bytes = num_bytes; req.u.dpcd_write.bytes = bytes; drm_dp_encode_sideband_req(&req, msg); - - return 0; } -static int build_link_address(struct drm_dp_sideband_msg_tx *msg) +static void build_link_address(struct drm_dp_sideband_msg_tx *msg) { struct drm_dp_sideband_msg_req_body req; req.req_type = DP_LINK_ADDRESS; drm_dp_encode_sideband_req(&req, msg); - return 0; } static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, int port_num) @@ -1048,7 +1042,7 @@ static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, int por return 0; } -static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_num, +static void build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_num, u8 vcpi, uint16_t pbn, u8 number_sdp_streams, u8 *sdp_stream_sink) @@ -1064,10 +1058,9 @@ static int build_allocate_payload(struct drm_dp_sideband_msg_tx *msg, int port_n number_sdp_streams); drm_dp_encode_sideband_req(&req, msg); msg->path_msg = true; - return 0; } -static int build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, +static void build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, int port_num, bool power_up) { struct drm_dp_sideband_msg_req_body req; @@ -1080,7 +1073,6 @@ static int build_power_updown_phy(struct drm_dp_sideband_msg_tx *msg, req.u.port_num.port_number = port_num; drm_dp_encode_sideband_req(&req, msg); msg->path_msg = true; - return 0; } static int drm_dp_mst_assign_payload_id(struct drm_dp_mst_topology_mgr *mgr, @@ -1746,14 +1738,13 @@ static u8 drm_dp_calculate_rad(struct drm_dp_mst_port *port, */ static bool drm_dp_port_setup_pdt(struct drm_dp_mst_port *port) { - int ret; u8 rad[6], lct; bool send_link = false; switch (port->pdt) { case DP_PEER_DEVICE_DP_LEGACY_CONV: case DP_PEER_DEVICE_SST_SINK: /* add i2c over sideband */ - ret = drm_dp_mst_register_i2c_bus(&port->aux); + drm_dp_mst_register_i2c_bus(&port->aux); break; case DP_PEER_DEVICE_MST_BRANCHING: lct = drm_dp_calculate_rad(port, rad); @@ -1823,25 +1814,20 @@ ssize_t drm_dp_mst_dpcd_write(struct drm_dp_aux *aux, static void drm_dp_check_mstb_guid(struct drm_dp_mst_branch *mstb, u8 *guid) { - int ret; - memcpy(mstb->guid, guid, 16); if (!drm_dp_validate_guid(mstb->mgr, mstb->guid)) { if (mstb->port_parent) { - ret = drm_dp_send_dpcd_write( - mstb->mgr, - mstb->port_parent, - DP_GUID, - 16, - mstb->guid); + drm_dp_send_dpcd_write(mstb->mgr, + mstb->port_parent, + DP_GUID, + 16, + mstb->guid); } else { - - ret = drm_dp_dpcd_write( - mstb->mgr->aux, - DP_GUID, - mstb->guid, - 16); + drm_dp_dpcd_write(mstb->mgr->aux, + DP_GUID, + mstb->guid, + 16); } } } @@ -2197,7 +2183,7 @@ static bool drm_dp_validate_guid(struct drm_dp_mst_topology_mgr *mgr, return false; } -static int build_dpcd_read(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes) +static void build_dpcd_read(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 offset, u8 num_bytes) { struct drm_dp_sideband_msg_req_body req; @@ -2206,8 +2192,6 @@ static int build_dpcd_read(struct drm_dp_sideband_msg_tx *msg, u8 port_num, u32 req.u.dpcd_read.dpcd_address = offset; req.u.dpcd_read.num_bytes = num_bytes; drm_dp_encode_sideband_req(&req, msg); - - return 0; } static int drm_dp_send_sideband_msg(struct drm_dp_mst_topology_mgr *mgr, @@ -2429,14 +2413,14 @@ static void drm_dp_send_link_address(struct drm_dp_mst_topology_mgr *mgr, { struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_link_address_ack_reply *reply; - int i, len, ret; + int i, ret; txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); if (!txmsg) return; txmsg->dst = mstb; - len = build_link_address(txmsg); + build_link_address(txmsg); mstb->link_address_sent = true; drm_dp_queue_down_tx(mgr, txmsg); @@ -2478,7 +2462,6 @@ drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr, { struct drm_dp_enum_path_resources_ack_reply *path_res; struct drm_dp_sideband_msg_tx *txmsg; - int len; int ret; txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); @@ -2486,7 +2469,7 @@ drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr, return -ENOMEM; txmsg->dst = mstb; - len = build_enum_path_resources(txmsg, port->port_num); + build_enum_path_resources(txmsg, port->port_num); drm_dp_queue_down_tx(mgr, txmsg); @@ -2569,7 +2552,7 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, { struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_mst_branch *mstb; - int len, ret, port_num; + int ret, port_num; u8 sinks[DRM_DP_MAX_SDP_STREAMS]; int i; @@ -2594,9 +2577,9 @@ static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr, sinks[i] = i; txmsg->dst = mstb; - len = build_allocate_payload(txmsg, port_num, - id, - pbn, port->num_sdp_streams, sinks); + build_allocate_payload(txmsg, port_num, + id, + pbn, port->num_sdp_streams, sinks); drm_dp_queue_down_tx(mgr, txmsg); @@ -2625,7 +2608,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, bool power_up) { struct drm_dp_sideband_msg_tx *txmsg; - int len, ret; + int ret; port = drm_dp_mst_topology_get_port_validated(mgr, port); if (!port) @@ -2638,7 +2621,7 @@ int drm_dp_send_power_updown_phy(struct drm_dp_mst_topology_mgr *mgr, } txmsg->dst = port->parent; - len = build_power_updown_phy(txmsg, port->port_num, power_up); + build_power_updown_phy(txmsg, port->port_num, power_up); drm_dp_queue_down_tx(mgr, txmsg); ret = drm_dp_mst_wait_tx_reply(port->parent, txmsg); @@ -2858,7 +2841,6 @@ static int drm_dp_send_dpcd_read(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, int offset, int size, u8 *bytes) { - int len; int ret = 0; struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_mst_branch *mstb; @@ -2873,7 +2855,7 @@ static int drm_dp_send_dpcd_read(struct drm_dp_mst_topology_mgr *mgr, goto fail_put; } - len = build_dpcd_read(txmsg, port->port_num, offset, size); + build_dpcd_read(txmsg, port->port_num, offset, size); txmsg->dst = port->parent; drm_dp_queue_down_tx(mgr, txmsg); @@ -2911,7 +2893,6 @@ static int drm_dp_send_dpcd_write(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port, int offset, int size, u8 *bytes) { - int len; int ret; struct drm_dp_sideband_msg_tx *txmsg; struct drm_dp_mst_branch *mstb; @@ -2926,7 +2907,7 @@ static int drm_dp_send_dpcd_write(struct drm_dp_mst_topology_mgr *mgr, goto fail_put; } - len = build_dpcd_write(txmsg, port->port_num, offset, size, bytes); + build_dpcd_write(txmsg, port->port_num, offset, size, bytes); txmsg->dst = mstb; drm_dp_queue_down_tx(mgr, txmsg); @@ -3149,7 +3130,7 @@ static bool drm_dp_get_one_sb_msg(struct drm_dp_mst_topology_mgr *mgr, bool up) { int len; u8 replyblock[32]; - int replylen, origlen, curreply; + int replylen, curreply; int ret; struct drm_dp_sideband_msg_rx *msg; int basereg = up ? DP_SIDEBAND_MSG_UP_REQ_BASE : DP_SIDEBAND_MSG_DOWN_REP_BASE; @@ -3169,7 +3150,6 @@ static bool drm_dp_get_one_sb_msg(struct drm_dp_mst_topology_mgr *mgr, bool up) } replylen = msg->curchunk_len + msg->curchunk_hdrlen; - origlen = replylen; replylen -= len; curreply = len; while (replylen > 0) { @@ -3961,17 +3941,16 @@ void drm_dp_mst_dump_topology(struct seq_file *m, mutex_lock(&mgr->lock); if (mgr->mst_primary) { u8 buf[DP_PAYLOAD_TABLE_SIZE]; - int ret; - ret = drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, buf, DP_RECEIVER_CAP_SIZE); + drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, buf, DP_RECEIVER_CAP_SIZE); seq_printf(m, "dpcd: %*ph\n", DP_RECEIVER_CAP_SIZE, buf); - ret = drm_dp_dpcd_read(mgr->aux, DP_FAUX_CAP, buf, 2); + drm_dp_dpcd_read(mgr->aux, DP_FAUX_CAP, buf, 2); seq_printf(m, "faux/mst: %*ph\n", 2, buf); - ret = drm_dp_dpcd_read(mgr->aux, DP_MSTM_CTRL, buf, 1); + drm_dp_dpcd_read(mgr->aux, DP_MSTM_CTRL, buf, 1); seq_printf(m, "mst ctrl: %*ph\n", 1, buf); /* dump the standard OUI branch header */ - ret = drm_dp_dpcd_read(mgr->aux, DP_BRANCH_OUI, buf, DP_BRANCH_OUI_HEADER_SIZE); + drm_dp_dpcd_read(mgr->aux, DP_BRANCH_OUI, buf, DP_BRANCH_OUI_HEADER_SIZE); seq_printf(m, "branch oui: %*phN devid: ", 3, buf); for (i = 0x3; i < 0x8 && buf[i]; i++) seq_printf(m, "%c", buf[i]); -- 2.15.0

7 13

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2020