dri-devel September 2020

dri-devel@lists.freedesktop.org

359 participants
868 discussions

[PATCH v4 0/1] drm: fix virtio-gpu + sev
by Gerd Hoffmann 08 Sep '20

08 Sep '20

virtio-gpu must make sure scatter list segments are not too big. Gerd Hoffmann (1): drm: allow limiting the scatter list size. include/drm/drm_prime.h | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 3 ++- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- drivers/gpu/drm/drm_prime.c | 13 ++++++++++--- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 ++- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem_prime.c | 2 +- drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +- drivers/gpu/drm/radeon/radeon_prime.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++-- drivers/gpu/drm/tegra/gem.c | 2 +- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- drivers/gpu/drm/xen/xen_drm_front_gem.c | 3 ++- 14 files changed, 29 insertions(+), 17 deletions(-) -- 2.27.0

2 6

[PATCH] video: fbdev: sis: fix null ptr dereference
by trix＠redhat.com 08 Sep '20

08 Sep '20

From: Tom Rix <trix(a)redhat.com> Clang static analysis reports this representative error init.c:2501:18: warning: Array access (from variable 'queuedata') results in a null pointer dereference templ |= ((queuedata[i] & 0xc0) << 3); This is the problem block of code if(ModeNo > 0x13) { ... if(SiS_Pr->ChipType == SIS_730) { queuedata = &FQBQData730[0]; } else { queuedata = &FQBQData[0]; } } else { } queuedata is not set in the else block Reviewing the old code, the arrays FQBQData730 and FQBQData were used directly. So hoist the setting of queuedata out of the if-else block. Fixes: 544393fe584d ("[PATCH] sisfb update") Signed-off-by: Tom Rix <trix(a)redhat.com> --- drivers/video/fbdev/sis/init.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index dfe3eb769638..fde27feae5d0 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -2428,6 +2428,11 @@ SiS_SetCRT1FIFO_630(struct SiS_Private *SiS_Pr, unsigned short ModeNo, i = 0; + if (SiS_Pr->ChipType == SIS_730) + queuedata = &FQBQData730[0]; + else + queuedata = &FQBQData[0]; + if(ModeNo > 0x13) { /* Get VCLK */ @@ -2445,12 +2450,6 @@ SiS_SetCRT1FIFO_630(struct SiS_Private *SiS_Pr, unsigned short ModeNo, /* Get half colordepth */ colorth = colortharray[(SiS_Pr->SiS_ModeType - ModeEGA)]; - if(SiS_Pr->ChipType == SIS_730) { - queuedata = &FQBQData730[0]; - } else { - queuedata = &FQBQData[0]; - } - do { templ = SiS_CalcDelay2(SiS_Pr, queuedata[i]) * VCLK * colorth; -- 2.18.1

2 1

[PATCH] omapfb: fix spelling mistake "propert" -> "property"
by Colin King 08 Sep '20

08 Sep '20

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/video/fbdev/omap2/omapfb/dss/venc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index 0b0ad20afd63..f560fa4d7786 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -787,7 +787,7 @@ static int venc_probe_of(struct platform_device *pdev) venc.type = OMAP_DSS_VENC_TYPE_SVIDEO; break; default: - dev_err(&pdev->dev, "bad channel propert '%d'\n", channels); + dev_err(&pdev->dev, "bad channel property '%d'\n", channels); r = -EINVAL; goto err; } -- 2.27.0

2 1

Re: [PATCH v4] video: fbdev: ssd1307fb: Added support to Column offset
by Bartlomiej Zolnierkiewicz 08 Sep '20

08 Sep '20

[ added dri-devel ML to Cc: ] On 7/27/20 10:40 PM, Rob Herring wrote: > On Fri, 24 Jul 2020 17:22:18 -0300, Rodrigo Alencar wrote: >> This patch provides support for displays like VGM128064B0W10, >> which requires a column offset of 2, i.e., its segments starts >> in SEG2 and ends in SEG129. >> >> Signed-off-by: Rodrigo Alencar <455.rodrigo.alencar(a)gmail.com> >> --- >> Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + >> drivers/video/fbdev/ssd1307fb.c | 8 ++++++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) >> > > Acked-by: Rob Herring <robh(a)kernel.org> Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

1 0

[PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error
by Colin King 08 Sep '20

08 Sep '20

From: Colin Ian King <colin.king(a)canonical.com> The pixclock is being set locally because it is being passed as a pass-by-value argument rather than pass-by-reference, so the computed pixclock is never being set in var->pixclock. Fix this by passing by reference. [This dates back to 2002, I found the offending commit from the git history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git ] Addresses-Coverity: ("Unused value") Fixes: 115f4504a64a ("Removed currcon and other console related code. Very little is now left.") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/video/fbdev/vga16fb.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c index a20eeb8308ff..52f273af6cae 100644 --- a/drivers/video/fbdev/vga16fb.c +++ b/drivers/video/fbdev/vga16fb.c @@ -243,7 +243,7 @@ static void vga16fb_update_fix(struct fb_info *info) } static void vga16fb_clock_chip(struct vga16fb_par *par, - unsigned int pixclock, + unsigned int *pixclock, const struct fb_info *info, int mul, int div) { @@ -259,14 +259,14 @@ static void vga16fb_clock_chip(struct vga16fb_par *par, { 0 /* bad */, 0x00, 0x00}}; int err; - pixclock = (pixclock * mul) / div; + *pixclock = (*pixclock * mul) / div; best = vgaclocks; - err = pixclock - best->pixclock; + err = *pixclock - best->pixclock; if (err < 0) err = -err; for (ptr = vgaclocks + 1; ptr->pixclock; ptr++) { int tmp; - tmp = pixclock - ptr->pixclock; + tmp = *pixclock - ptr->pixclock; if (tmp < 0) tmp = -tmp; if (tmp < err) { err = tmp; @@ -275,7 +275,7 @@ static void vga16fb_clock_chip(struct vga16fb_par *par, } par->misc |= best->misc; par->clkdiv = best->seq_clock_mode; - pixclock = (best->pixclock * div) / mul; + *pixclock = (best->pixclock * div) / mul; } #define FAIL(X) return -EINVAL @@ -497,10 +497,10 @@ static int vga16fb_check_var(struct fb_var_screeninfo *var, if (mode & MODE_8BPP) /* pixel clock == vga clock / 2 */ - vga16fb_clock_chip(par, var->pixclock, info, 1, 2); + vga16fb_clock_chip(par, &var->pixclock, info, 1, 2); else /* pixel clock == vga clock */ - vga16fb_clock_chip(par, var->pixclock, info, 1, 1); + vga16fb_clock_chip(par, &var->pixclock, info, 1, 1); var->red.offset = var->green.offset = var->blue.offset = var->transp.offset = 0; -- 2.27.0

2 1

[PATCH] fbdev: sm712fb: handle ioremap() errors in probe
by Evgeny Novikov 08 Sep '20

08 Sep '20

smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The patch fixes that exactly like for case 0x710/2. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov <novikov(a)ispras.ru> --- drivers/video/fbdev/sm712fb.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index 6a1b4a853d9e..0171b23fa211 100644 --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev, sfb->fb->fix.mmio_start = mmio_base; sfb->fb->fix.mmio_len = 0x00200000; sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size); + if (!sfb->dp_regs) { + dev_err(&pdev->dev, + "%s: unable to map memory mapped IO!\n", + sfb->fb->fix.id); + err = -ENOMEM; + goto failed_fb; + } + sfb->lfb = sfb->dp_regs + 0x00200000; sfb->mmio = (smtc_regbaseaddress = sfb->dp_regs + 0x000c0000); -- 2.16.4

2 1

Re: [PATCH 1/1] fbmem: add margin check to fb_check_caps()
by Bartlomiej Zolnierkiewicz 08 Sep '20

08 Sep '20

[ added dri-devel ML to Cc: ] On 7/7/20 9:47 PM, Dan Carpenter wrote: > On Tue, Jul 07, 2020 at 03:26:03PM -0400, George Kennedy wrote: >> A fb_ioctl() FBIOPUT_VSCREENINFO call with invalid xres setting >> or yres setting in struct fb_var_screeninfo will result in a >> KASAN: vmalloc-out-of-bounds failure in bitfill_aligned() as >> the margins are being cleared. The margins are cleared in >> chunks and if the xres setting or yres setting is a value of >> zero upto the chunk size, the failure will occur. >> >> Add a margin check to validate xres and yres settings. >> >> Signed-off-by: George Kennedy <george.kennedy(a)oracle.com> >> Suggested-by: Dan Carpenter <dan.carpenter(a)oracle.com> > > Suggested-by is perhaps a bit strong. Let's change that to: > > Reviewed-by: Dan Carpenter <dan.carpenter(a)oracle.com> Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

1 0

[PATCH 0/3] drm/qxl: fix stale mm entries on driver shutdown
by Gerd Hoffmann 08 Sep '20

08 Sep '20

Gerd Hoffmann (3): drm/qxl: use drmm_mode_config_init drm/qxl: release shadow on shutdown drm/qxl: handle shadow in primary destroy drivers/gpu/drm/qxl/qxl_display.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.27.0

2 4

[PATCH] backlight: tosa_lcd: Include the right header
by Linus Walleij 08 Sep '20

08 Sep '20

The Tosa backlight LCDE driver was converted to use GPIO descriptors in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83 ("video: backlight: tosa: Use GPIO lookup table") but still includes <linux/gpio.h> rather than <linux/gpio/consumer.h>. Fix it. Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Robert Jarzmik <robert.jarzmik(a)free.fr> Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org> --- drivers/video/backlight/tosa_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c index 113116d3585c..38765544345b 100644 --- a/drivers/video/backlight/tosa_lcd.c +++ b/drivers/video/backlight/tosa_lcd.c @@ -12,7 +12,7 @@ #include <linux/spi/spi.h> #include <linux/i2c.h> #include <linux/slab.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/delay.h> #include <linux/lcd.h> #include <linux/fb.h> -- 2.26.2

3 2

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset
by Nicolas Saenz Julienne 08 Sep '20

08 Sep '20

On Tue, 2020-09-08 at 11:43 +0200, Christoph Hellwig wrote: > And because I like replying to myself so much, here is a link to the > version with the arm cleanup patch applied. Unlike the previous two > attempts this has at least survived very basic sanity testing: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-ranges.2 > > Note that we'll still need to sort out the arm/keystone warnings from > the original patch. Do we have anyone on the CC list who knows that > platform a little better to figure out if the ifdef solution would work? Had to do the following to boot without errors: diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h index ef61a33c47bc..7dd88a0b6d0b 100644 --- a/include/linux/dma-direct.h +++ b/include/linux/dma-direct.h @@ -97,6 +97,9 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size, { dma_addr_t end = addr + size - 1; + if (addr == DMA_MAPPING_ERROR) + return false; + if (!dev->dma_mask) return false; diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index 90f1ecb6baaf..25809703a5bf 100644 --- a/kernel/dma/direct.c +++ b/kernel/dma/direct.c @@ -71,7 +71,12 @@ static gfp_t dma_direct_optimal_gfp_mask(struct device *dev, u64 dma_mask, static bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size) { - return phys_to_dma_direct(dev, phys) + size - 1 <= + dma_addr_t dma_addr = phys_to_dma_direct(dev, phys); + + if (dma_addr == DMA_MAPPING_ERROR) + return false; + + return dma_addr + size - 1 <= min_not_zero(dev->coherent_dma_mask, dev->bus_dma_limit); } Regards, Nicolas

1 0

← Newer
1
...
71
72
73
74
75
76
77
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2020