dri-devel October 2021

dri-devel@lists.freedesktop.org

347 participants
825 discussions

linux-next: build warning after merge of the drm tree
by Stephen Rothwell 28 Oct '21

28 Oct '21

Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: unmet direct dependencies detected for DRM_I915_WERROR Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y] Selected by [m]: - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m] WARNING: unmet direct dependencies detected for DRM_I915_WERROR Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y] Selected by [m]: - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m] WARNING: unmet direct dependencies detected for DRM_I915_WERROR Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y] Selected by [m]: - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && DRM_I915 [=m] Maybe introduced by commit 4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config") -- Cheers, Stephen Rothwell

3 7

[PATCH v3 0/6] drm: add per-connector hotplug events
by Simon Ser 28 Oct '21

28 Oct '21

When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set when sending HDCP property update uevents, see drm_sysfs_connector_status_event. This has been tested with a wlroots patch [1]. amdgpu and the probe-helper has been updated to use these new fine-grained uevents. Changes in v3: rebase [1]: https://github.com/swaywm/wlroots/pull/2959 Simon Ser (6): drm/sysfs: introduce drm_sysfs_connector_hotplug_event drm/probe-helper: add drm_kms_helper_connector_hotplug_event drm/connector: use drm_sysfs_connector_hotplug_event amdgpu: use drm_kms_helper_connector_hotplug_event drm/probe-helper: use drm_kms_helper_connector_hotplug_event i915/display/dp: send a more fine-grained link-status uevent .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++-- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +- drivers/gpu/drm/drm_connector.c | 2 +- drivers/gpu/drm/drm_probe_helper.c | 43 +++++++++++++++++-- drivers/gpu/drm/drm_sysfs.c | 25 +++++++++++ drivers/gpu/drm/i915/display/intel_dp.c | 2 + include/drm/drm_probe_helper.h | 1 + include/drm/drm_sysfs.h | 1 + 8 files changed, 75 insertions(+), 11 deletions(-) base-commit: f6632721cd6231e1bf28b5317dcc7543e43359f7 -- 2.33.1

7 23

[PULL] drm-misc-fixes
by Maxime Ripard 28 Oct '21

28 Oct '21

Hi Dave, Daniel, Here's the (hopefully) final drm-misc-fixes PR for 5.15 I'll have a look tomorrow morning to see if anything has been committed and send a PR if so. Maxime drm-misc-fixes-2021-10-28: One patch to fix the default screen orientation on the GPD Win3 The following changes since commit ee71fb6c4d99c51f2d82a32c503c872b7e40e7f7: drm/i915/selftests: Properly reset mock object propers for each test (2021-10-22 11:09:45 +0200) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-10-28 for you to fetch changes up to 61b1d445f3bfe4c3ba4335ceeb7e8ba688fd31e2: drm: panel-orientation-quirks: Add quirk for GPD Win3 (2021-10-26 20:57:10 +0200) ---------------------------------------------------------------- One patch to fix the default screen orientation on the GPD Win3 ---------------------------------------------------------------- Mario (1): drm: panel-orientation-quirks: Add quirk for GPD Win3 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+)

1 0

[PATCH v2] backlight: lp855x: Switch to atomic PWM API
by Maíra Canal 28 Oct '21

28 Oct '21

Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal <maira.canal(a)usp.br> Reported-by: kernel test robot <lkp(a)intel.com> --- V1 -> V2: Initializing variable and simplyfing conditional loop --- drivers/video/backlight/lp855x_bl.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index e94932c69f54..a895a8ca6d26 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -233,9 +233,8 @@ static int lp855x_configure(struct lp855x *lp) static void lp855x_pwm_ctrl(struct lp855x *lp, int br, int max_br) { - unsigned int period = lp->pdata->period_ns; - unsigned int duty = br * period / max_br; - struct pwm_device *pwm; + struct pwm_device *pwm = NULL; + struct pwm_state state; /* request pwm device with the consumer name */ if (!lp->pwm) { @@ -244,19 +243,15 @@ static void lp855x_pwm_ctrl(struct lp855x *lp, int br, int max_br) return; lp->pwm = pwm; - - /* - * FIXME: pwm_apply_args() should be removed when switching to - * the atomic PWM API. - */ - pwm_apply_args(pwm); } - pwm_config(lp->pwm, duty, period); - if (duty) - pwm_enable(lp->pwm); - else - pwm_disable(lp->pwm); + pwm_init_state(pwm, &state); + + state.period = lp->pdata->period_ns; + state.duty_cycle = br * state.period / max_br; + state.enabled = state.duty_cycle; + + pwm_apply_state(pwm, &state); } static int lp855x_bl_update_status(struct backlight_device *bl) -- 2.31.1

2 1

[PATCH] drm: Link CMA framebuffer helpers into KMS helper library
by Thomas Zimmermann 28 Oct '21

28 Oct '21

Linking the CMA frambuffer helpers into a CMA helper library in commit 4b2b5e142ff4 ("drm: Move GEM memory managers into modules") results in linker errors: arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.o: \ in function `drm_fb_cma_get_gem_obj': \ drivers/gpu/drm/drm_fb_cma_helper.c:46: undefined reference \ to `drm_gem_fb_get_obj' arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:46: \ undefined reference to `drm_gem_fb_get_obj' arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:46: \ undefined reference to `drm_gem_fb_get_obj' arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.o: in \ function `drm_fb_cma_sync_non_coherent': \ drivers/gpu/drm/drm_fb_cma_helper.c:133: undefined reference \ to `drm_atomic_helper_damage_iter_init' arm-linux-gnueabihf-ld: drivers/gpu/drm/drm_fb_cma_helper.c:135: \ undefined reference to `drm_atomic_helper_damage_iter_next' Link the CMA framebuffer helpers into the KMS helper library to fix the problem. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> Fixes: 4b2b5e142ff4 ("drm: Move GEM memory managers into modules") Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <mripard(a)kernel.org> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 7f6eb11b6aac..1c41156deb5f 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -34,7 +34,6 @@ drm-$(CONFIG_DRM_PRIVACY_SCREEN) += drm_privacy_screen.o drm_privacy_screen_x86. obj-$(CONFIG_DRM_DP_AUX_BUS) += drm_dp_aux_bus.o drm_cma_helper-y := drm_gem_cma_helper.o -drm_cma_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o obj-$(CONFIG_DRM_GEM_CMA_HELPER) += drm_cma_helper.o drm_shmem_helper-y := drm_gem_shmem_helper.o @@ -59,6 +58,7 @@ drm_kms_helper-y := drm_bridge_connector.o drm_crtc_helper.o drm_dp_helper.o \ drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fb_helper.o +drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o drm_kms_helper-$(CONFIG_DRM_DP_AUX_CHARDEV) += drm_dp_aux_dev.o drm_kms_helper-$(CONFIG_DRM_DP_CEC) += drm_dp_cec.o -- 2.33.1

2 2

linux-next: manual merge of the amdgpu tree with the drm tree
by Stephen Rothwell 28 Oct '21

28 Oct '21

Hi all, Today's linux-next merge of the amdgpu tree got conflicts in: drivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/drm_dp_mst_topology.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c between commits: d740e0bf8ed4 ("drm/amd/display: Add DP 2.0 MST DC Support") 41724ea273cd ("drm/amd/display: Add DP 2.0 MST DM Support") 00f965e700ef ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set") from the drm tree and commits: 6d23be5bc661 ("drm/amd/display: Add DP 2.0 MST DC Support") 39b3c728e5ca ("drm/amd/display: Add DP 2.0 MST DM Support") 8bc3824f0ee2 ("drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set") from the amdgpu tree. The conflicts between these different versions of the same patches, and some other changes in the amdgpu tree are just a mess today, do I have just dropped the amdgpu tree completely for today. -- Cheers, Stephen Rothwell

2 1

linux-next: manual merge of the drm-misc tree with Linus' tree
by Stephen Rothwell 28 Oct '21

28 Oct '21

Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/kmb/kmb_drv.c between commit: c026565fe9be ("drm/kmb: Enable alpha blended second plane") from Linus' tree and commit: 099afadc533f ("drm/kmb: Enable support for framebuffer console") from the drm-misc tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/gpu/drm/kmb/kmb_drv.c index 961ac6fb5fcf,7e1fda9f9a3d..000000000000 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@@ -172,10 -173,11 +173,11 @@@ static int kmb_setup_mode_config(struc ret = drmm_mode_config_init(drm); if (ret) return ret; - drm->mode_config.min_width = KMB_MIN_WIDTH; - drm->mode_config.min_height = KMB_MIN_HEIGHT; - drm->mode_config.max_width = KMB_MAX_WIDTH; - drm->mode_config.max_height = KMB_MAX_HEIGHT; + drm->mode_config.min_width = KMB_FB_MIN_WIDTH; + drm->mode_config.min_height = KMB_FB_MIN_HEIGHT; + drm->mode_config.max_width = KMB_FB_MAX_WIDTH; + drm->mode_config.max_height = KMB_FB_MAX_HEIGHT; + drm->mode_config.preferred_depth = 24; drm->mode_config.funcs = &kmb_mode_config_funcs; ret = kmb_setup_crtc(drm);

1 0

[pull] amdgpu drm-fixes-5.15
by Alex Deucher 28 Oct '21

28 Oct '21

Hi Dave, Daniel, Fixes for 5.15. The following changes since commit defbbcd99fa68cb7feed453662048baa87e9a441: Merge tag 'amd-drm-fixes-5.15-2021-10-21' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-10-27 10:01:21 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.15-2021-10-27 for you to fetch changes up to ad76744b041d8c87ef1c9adbb04fb7eaa20a179e: drm/amd/display: Fix deadlock when falling back to v2 from v3 (2021-10-27 22:04:50 -0400) ---------------------------------------------------------------- amd-drm-fixes-5.15-2021-10-27: amdgpu: - Display fixes for DCN 3.1 - Fix potential out of bounds write in debugfs ---------------------------------------------------------------- Michael Strauss (1): drm/amd/display: Fallback to clocks which meet requested voltage on DCN31 Nicholas Kazlauskas (1): drm/amd/display: Fix deadlock when falling back to v2 from v3 Patrik Jakobsson (1): drm/amdgpu: Fix even more out of bound writes from debugfs .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 18 +++++++++--------- .../drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 13 ++++++++++--- drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 6 ++---- 3 files changed, 21 insertions(+), 16 deletions(-)

1 0

[PATCH] video: use swap() to make code cleaner
by Yang Guang 28 Oct '21

28 Oct '21

Using swap() make it more readable. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: Yang Guang <yang.guang5(a)zte.com.cn> --- drivers/video/fbdev/sis/sis_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 266a5582f94d..742f62986b80 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -213,7 +213,7 @@ static void sisfb_search_mode(char *name, bool quiet) /* This does some fuzzy mode naming detection */ if(sscanf(strbuf1, "%u %u %u %u", &xres, &yres, &depth, &rate) == 4) { if((rate <= 32) || (depth > 32)) { - j = rate; rate = depth; depth = j; + swap(rate, depth); } sprintf(strbuf, "%ux%ux%u", xres, yres, depth); nameptr = strbuf; -- 2.30.2

1 0

[PATCH v3 0/4] ti-sn65dsi83 patches
by Alexander Stein 27 Oct '21

27 Oct '21

Changes in V3 of this set: * Do not require vcc-supply in bindings, making it purely optional * Move regulator enable/disable to sn65dsi83_atomic_pre_enable and sn65dsi83_atomic_disable Changes in V2 of this set: * Add patch from Laurent for fixing the binding regarding optional GPIO * Reorder patches so bindings are changed beforehand * Add small fixes from Sam's review Alexander Stein (3): drm/bridge: ti-sn65dsi83: Make enable GPIO optional dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings drm/bridge: ti-sn65dsi83: Add vcc supply regulator support Laurent Pinchart (1): dt-bindings: display: bridge: sn65dsi83: Make enable GPIO optional .../bindings/display/bridge/ti,sn65dsi83.yaml | 5 ++++- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 21 ++++++++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) -- 2.25.1

3 8

← Newer
1
...
23
24
25
26
27
28
29
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2021