dri-devel March 2021

dri-devel@lists.freedesktop.org

326 participants
867 discussions

[PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning
by Arnd Bergmann 24 Mar '21

24 Mar '21

From: Arnd Bergmann <arnd(a)arndb.de> When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds] Add an error check before the index is used, which helps with the warning, as well as any possible other error condition that may be triggered at runtime. The warning could be fixed by adding a Kconfig depedency on CONFIG_OF, but Liu Ying points out that the driver may hit the out-of-bounds problem at runtime anyway. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- v2: fix subject line expand patch description print mux number check upper bound as well --- drivers/gpu/drm/imx/imx-ldb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index dbfe39e2f7f6..40310327fa76 100644 --- a/drivers/gpu/drm/imx/imx-ldb.c +++ b/drivers/gpu/drm/imx/imx-ldb.c @@ -197,6 +197,12 @@ static void imx_ldb_encoder_enable(struct drm_encoder *encoder) int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN; int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); + if (mux < 0 || mux >= ARRAY_SIZE(ldb->clk_sel)) { + dev_warn(ldb->dev, "%s: invalid mux %d\n", + __func__, ERR_PTR(mux)); + return; + } + drm_panel_prepare(imx_ldb_ch->panel); if (dual) { @@ -255,6 +261,12 @@ imx_ldb_encoder_atomic_mode_set(struct drm_encoder *encoder, int mux = drm_of_encoder_active_port_id(imx_ldb_ch->child, encoder); u32 bus_format = imx_ldb_ch->bus_format; + if (mux < 0 || mux >= ARRAY_SIZE(ldb->clk_sel)) { + dev_warn(ldb->dev, "%s: invalid mux %d\n", + __func__, ERR_PTR(mux)); + return; + } + if (mode->clock > 170000) { dev_warn(ldb->dev, "%s: mode exceeds 170 MHz pixel clock\n", __func__); -- 2.29.2

4 11

linux-next: build warning after merge of the drm-intel-fixes tree
by Stephen Rothwell 24 Mar '21

24 Mar '21

Hi all, After merging the drm-intel-fixes tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/i915:22: /home/sfr/next/next/drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. Introduced by commit 8840e3bd981f ("drm/i915: Fix the GT fence revocation runtime PM logic") -- Cheers, Stephen Rothwell

1 0

[PATCH] drm/nouveau/bios/init: A typo fix
by Bhaskar Chowdhury 24 Mar '21

24 Mar '21

s/conditon/condition/ Signed-off-by: Bhaskar Chowdhury <unixbhaskar(a)gmail.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c index 9de74f41dcd2..142079403864 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c @@ -401,7 +401,7 @@ init_table_(struct nvbios_init *init, u16 offset, const char *name) #define init_macro_table(b) init_table_((b), 0x04, "macro table") #define init_condition_table(b) init_table_((b), 0x06, "condition table") #define init_io_condition_table(b) init_table_((b), 0x08, "io condition table") -#define init_io_flag_condition_table(b) init_table_((b), 0x0a, "io flag conditon table") +#define init_io_flag_condition_table(b) init_table_((b), 0x0a, "io flag condition table") #define init_function_table(b) init_table_((b), 0x0c, "function table") #define init_xlat_table(b) init_table_((b), 0x10, "xlat table"); -- 2.30.1

2 1

[pull] amdgpu drm-fixes-5.12
by Alex Deucher 24 Mar '21

24 Mar '21

Hi Dave, Daniel, Fixes for 5.12. The following changes since commit d27ce83fa4baa5cb908a42e9878564cad6ea0eb3: Merge tag 'du-fixes-20210316' of git://linuxtv.org/pinchartl/media into drm-fixes (2021-03-22 13:49:55 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.12-2021-03-24 for you to fetch changes up to 5c458585c0141754cdcbf25feebb547dd671b559: drm/amdgpu/display: restore AUX_DPHY_TX_CONTROL for DCN2.x (2021-03-24 00:30:57 -0400) ---------------------------------------------------------------- amd-drm-fixes-5.12-2021-03-24: amdgpu: - S0ix fixes - Add PCI ID - Polaris PCIe DPM fix - Display fix for high refresh rate monitors ---------------------------------------------------------------- Alex Deucher (11): drm/amdgpu: rework S3/S4/S0ix state handling drm/amdgpu: don't evict vram on APUs for suspend to ram (v4) drm/amdgpu: clean up non-DC suspend/resume handling drm/amdgpu: move s0ix check into amdgpu_device_ip_suspend_phase2 (v3) drm/amdgpu: re-enable suspend phase 2 for S0ix drm/amdgpu/swsmu: skip gfx cgpg on s0ix suspend drm/amdgpu: update comments about s0ix suspend/resume drm/amdgpu: drop S0ix checks around CG/PG in suspend drm/amdgpu: skip kfd suspend/resume for S0ix drm/amdgpu: Add additional Sienna Cichlid PCI ID drm/amdgpu/display: restore AUX_DPHY_TX_CONTROL for DCN2.x Kenneth Feng (1): drm/amd/pm: workaround for audio noise issue Pratik Vishwakarma (1): drm/amdgpu: skip CG/PG for gfx during S0ix Prike Liang (1): drm/amdgpu: fix the hibernation suspend with s0ix drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 132 ++++++--------------- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 89 ++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 31 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 9 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 9 +- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 9 +- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 15 ++- .../drm/amd/display/dc/dcn20/dcn20_link_encoder.c | 3 +- .../gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 54 +++++++++ .../gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 74 ++++++++++-- .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c | 24 ++++ .../gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c | 25 ++++ drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 +- 17 files changed, 365 insertions(+), 142 deletions(-)

1 0

[Bug 212397] New: Resume from suspend (S3) does not bring back video anymore
by bugzilla-daemon＠bugzilla.kernel.org 24 Mar '21

24 Mar '21

https://bugzilla.kernel.org/show_bug.cgi?id=212397 Bug ID: 212397 Summary: Resume from suspend (S3) does not bring back video anymore Product: Drivers Version: 2.5 Kernel Version: 5.11.7 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: amitshah(a)gmx.net Regression: No After updating from v5.10 to v5.11, resume from suspend is broken: I don't get video output at all. I have a ThinkPad T60, with RV515/M54 [Mobility Radeon X1400] GPU. I'm running Fedora 33 with gnome on X11 (not Wayland - Wayland display does not work on this GPU). Upon resume, dmesg shows me: Mär 22 18:30:57 trundl.on kernel: usb usb5: root hub lost power or was reset Mär 22 18:30:57 trundl.on kernel: ------------[ cut here ]------------ Mär 22 18:30:57 trundl.on kernel: ACPI: EC: event unblocked Mär 22 18:30:57 trundl.on kernel: WARNING: CPU: 0 PID: 7973 at include/drm/ttm/ttm_bo_api.h:615 radeon_bo_unpin+0x47/0x60 [radeon] Mär 22 18:30:57 trundl.on kernel: Modules linked in: uas usb_storage xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_nat_tftp nf> Mär 22 18:30:57 trundl.on kernel: platform_profile ledtrig_audio snd_timer snd rfkill soundcore acpi_cpufreq zram ip_tables xfs dm_c> Mär 22 18:30:57 trundl.on kernel: CPU: 0 PID: 7973 Comm: kworker/u4:13 Not tainted 5.11.7-200.fc33.x86_64 #1 Mär 22 18:30:57 trundl.on kernel: Hardware name: LENOVO 8743CTO/8743CTO, BIOS 7IET37WW (1.18 ) 04/01/2010 Mär 22 18:30:57 trundl.on kernel: Workqueue: events_unbound async_run_entry_fn Mär 22 18:30:57 trundl.on kernel: RIP: 0010:radeon_bo_unpin+0x47/0x60 [radeon] Mär 22 18:30:57 trundl.on kernel: Code: 8b 87 d8 01 00 00 48 8b 97 e0 02 00 00 48 c1 e0 0c 83 bf 14 02 00 00 02 74 08 48 29 82 48 2d > Mär 22 18:30:57 trundl.on kernel: RSP: 0018:ffffa13081cebd88 EFLAGS: 00010246 Mär 22 18:30:57 trundl.on kernel: RAX: 0000000000000000 RBX: ffff90d174bec000 RCX: 0000000000000004 Mär 22 18:30:57 trundl.on kernel: RDX: 00000000ffffffff RSI: 0000000000000000 RDI: ffff90d174bd6c00 Mär 22 18:30:57 trundl.on kernel: RBP: ffff90d141b8a0c8 R08: 0000000000000000 R09: ffffa13081cebd64 Mär 22 18:30:57 trundl.on kernel: R10: 000000000000000f R11: 0000000000000001 R12: ffff90d174bd6c00 Mär 22 18:30:57 trundl.on kernel: R13: ffff90d174f26000 R14: 0000000000000010 R15: 0000000000000000 Mär 22 18:30:57 trundl.on kernel: FS: 0000000000000000(0000) GS:ffff90d1fcc00000(0000) knlGS:0000000000000000 Mär 22 18:30:57 trundl.on kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Mär 22 18:30:57 trundl.on kernel: CR2: 00007fa1d4039ce6 CR3: 0000000075bcc000 CR4: 00000000000006f0 Mär 22 18:30:57 trundl.on kernel: Call Trace: Mär 22 18:30:57 trundl.on kernel: radeon_gart_table_vram_unpin+0x47/0xa0 [radeon] Mär 22 18:30:57 trundl.on kernel: rv515_resume+0x74/0xb0 [radeon] Mär 22 18:30:57 trundl.on kernel: usb usb2: root hub lost power or was reset Mär 22 18:30:57 trundl.on kernel: radeon_resume_kms+0x5c/0x350 [radeon] Mär 22 18:30:57 trundl.on kernel: ? pci_pm_poweroff_noirq+0x110/0x110 Mär 22 18:30:57 trundl.on kernel: dpm_run_callback+0x4c/0x120 Mär 22 18:30:57 trundl.on kernel: device_resume+0xa7/0x200 Mär 22 18:30:57 trundl.on kernel: async_resume+0x19/0x30 Mär 22 18:30:57 trundl.on kernel: async_run_entry_fn+0x39/0x160 Mär 22 18:30:57 trundl.on kernel: process_one_work+0x1ec/0x380 Mär 22 18:30:57 trundl.on kernel: worker_thread+0x53/0x3e0 Mär 22 18:30:57 trundl.on kernel: ? process_one_work+0x380/0x380 Mär 22 18:30:57 trundl.on kernel: kthread+0x11b/0x140 Mär 22 18:30:57 trundl.on kernel: ? __kthread_bind_mask+0x60/0x60 Mär 22 18:30:57 trundl.on kernel: ret_from_fork+0x22/0x30 Mär 22 18:30:57 trundl.on kernel: ---[ end trace ff7b7de1d8244926 ]--- Mär 22 18:30:57 trundl.on kernel: usb usb3: root hub lost power or was reset Mär 22 18:30:57 trundl.on kernel: usb usb4: root hub lost power or was reset Mär 22 18:30:57 trundl.on kernel: ------------[ cut here ]------------ Mär 22 18:30:57 trundl.on kernel: TPM returned invalid status Mär 22 18:30:57 trundl.on kernel: WARNING: CPU: 1 PID: 7956 at drivers/char/tpm/tpm_tis_core.c:205 tpm_tis_status+0x66/0x70 Mär 22 18:30:57 trundl.on kernel: Modules linked in: uas usb_storage xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_nat_tftp nf> Mär 22 18:30:57 trundl.on kernel: platform_profile ledtrig_audio snd_timer snd rfkill soundcore acpi_cpufreq zram ip_tables xfs dm_c> Mär 22 18:30:57 trundl.on kernel: CPU: 1 PID: 7956 Comm: systemd-sleep Tainted: G W 5.11.7-200.fc33.x86_64 #1 Mär 22 18:30:57 trundl.on kernel: Hardware name: LENOVO 8743CTO/8743CTO, BIOS 7IET37WW (1.18 ) 04/01/2010 Mär 22 18:30:57 trundl.on kernel: RIP: 0010:tpm_tis_status+0x66/0x70 Mär 22 18:30:57 trundl.on kernel: Code: 23 75 05 48 83 c4 10 c3 31 c0 80 3d 18 12 56 01 00 75 f0 48 c7 c7 ac 60 43 8c 88 44 24 07 c6 > Mär 22 18:30:57 trundl.on kernel: RSP: 0000:ffffa13083183b10 EFLAGS: 00010282 Mär 22 18:30:57 trundl.on kernel: RAX: 000000000000001b RBX: ffff90d1424a1000 RCX: ffff90d1fcd18ac8 Mär 22 18:30:57 trundl.on kernel: RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: ffff90d1fcd18ac0 Mär 22 18:30:57 trundl.on kernel: RBP: ffff90d1424a1000 R08: ffffffff8ca64ec0 R09: ffffa13083183ab0 Mär 22 18:30:57 trundl.on kernel: R10: 0000000000000001 R11: 000000002d2d2d2d R12: ffff90d14755b0e8 Mär 22 18:30:57 trundl.on kernel: R13: ffff90d14f80e000 R14: 0000000000000000 R15: ffffa13083183bca Mär 22 18:30:57 trundl.on kernel: FS: 00007fe97f326000(0000) GS:ffff90d1fcd00000(0000) knlGS:0000000000000000 Mär 22 18:30:57 trundl.on kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Mär 22 18:30:57 trundl.on kernel: CR2: 0000000000000000 CR3: 0000000075bcc000 CR4: 00000000000006e0 Mär 22 18:30:57 trundl.on kernel: Call Trace: Mär 22 18:30:57 trundl.on kernel: tpm_tis_send_data+0x2b/0x230 Mär 22 18:30:57 trundl.on kernel: tpm_tis_send_main+0x1e/0xe0 Mär 22 18:30:57 trundl.on kernel: tpm_transmit+0xd8/0x3d0 Mär 22 18:30:57 trundl.on kernel: tpm_transmit_cmd+0x25/0x90 Mär 22 18:30:57 trundl.on kernel: tpm1_do_selftest+0x88/0x130 Mär 22 18:30:57 trundl.on kernel: ? _cond_resched+0x16/0x40 Mär 22 18:30:57 trundl.on kernel: tpm_tis_resume+0x4d/0x120 Mär 22 18:30:57 trundl.on kernel: ? pnpacpi_resume+0x1b/0xa0 Mär 22 18:30:57 trundl.on kernel: ? pnp_bus_suspend+0x10/0x10 Mär 22 18:30:57 trundl.on kernel: pnp_bus_resume+0x63/0x90 Mär 22 18:30:57 trundl.on kernel: dpm_run_callback+0x4c/0x120 Mär 22 18:30:57 trundl.on kernel: device_resume+0xa7/0x200 Mär 22 18:30:57 trundl.on kernel: dpm_resume+0xce/0x2c0 Mär 22 18:30:57 trundl.on kernel: dpm_resume_end+0xd/0x20 Mär 22 18:30:57 trundl.on kernel: suspend_devices_and_enter+0x195/0x750 Mär 22 18:30:57 trundl.on kernel: pm_suspend.cold+0x329/0x374 Mär 22 18:30:57 trundl.on kernel: state_store+0x71/0xd0 Mär 22 18:30:57 trundl.on kernel: kernfs_fop_write_iter+0x124/0x1b0 Mär 22 18:30:57 trundl.on kernel: new_sync_write+0x108/0x180 Mär 22 18:30:57 trundl.on kernel: vfs_write+0x1bc/0x270 Mär 22 18:30:57 trundl.on kernel: ksys_write+0x4f/0xc0 Mär 22 18:30:57 trundl.on kernel: do_syscall_64+0x33/0x40 Mär 22 18:30:57 trundl.on kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 Mär 22 18:30:57 trundl.on kernel: RIP: 0033:0x7fe9802e24e7 Mär 22 18:30:57 trundl.on kernel: Code: 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 > Mär 22 18:30:57 trundl.on kernel: RSP: 002b:00007ffef4953358 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 Mär 22 18:30:57 trundl.on kernel: RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007fe9802e24e7 Mär 22 18:30:57 trundl.on kernel: RDX: 0000000000000004 RSI: 00007ffef4953440 RDI: 0000000000000004 Mär 22 18:30:57 trundl.on kernel: RBP: 00007ffef4953440 R08: 0000555f33e305e0 R09: 00007fe980332530 Mär 22 18:30:57 trundl.on kernel: R10: 00007fe980378fc0 R11: 0000000000000246 R12: 0000000000000004 Mär 22 18:30:57 trundl.on kernel: R13: 0000555f33e2c650 R14: 0000000000000004 R15: 00007fe9803b5720 Mär 22 18:30:57 trundl.on kernel: ---[ end trace ff7b7de1d8244927 ]--- Mär 22 18:30:57 trundl.on kernel: ata6: port disabled--ignoring Mär 22 18:30:57 trundl.on kernel: sd 0:0:0:0: [sda] Starting disk Mär 22 18:30:57 trundl.on kernel: [drm] radeon: 1 quad pipes, 1 z pipes initialized. Mär 22 18:30:57 trundl.on kernel: sd 0:0:0:0: [sda] Starting disk Mär 22 18:30:57 trundl.on kernel: new_sync_write+0x108/0x180 Mär 22 18:30:57 trundl.on kernel: vfs_write+0x1bc/0x270 Mär 22 18:30:57 trundl.on kernel: ksys_write+0x4f/0xc0 Mär 22 18:30:57 trundl.on kernel: do_syscall_64+0x33/0x40 Mär 22 18:30:57 trundl.on kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 Mär 22 18:30:57 trundl.on kernel: RIP: 0033:0x7fe9802e24e7 Mär 22 18:30:57 trundl.on kernel: Code: 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 > Mär 22 18:30:57 trundl.on kernel: RSP: 002b:00007ffef4953358 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 Mär 22 18:30:57 trundl.on kernel: RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007fe9802e24e7 Mär 22 18:30:57 trundl.on kernel: RDX: 0000000000000004 RSI: 00007ffef4953440 RDI: 0000000000000004 Mär 22 18:30:57 trundl.on kernel: RBP: 00007ffef4953440 R08: 0000555f33e305e0 R09: 00007fe980332530 Mär 22 18:30:57 trundl.on kernel: R10: 00007fe980378fc0 R11: 0000000000000246 R12: 0000000000000004 Mär 22 18:30:57 trundl.on kernel: R13: 0000555f33e2c650 R14: 0000000000000004 R15: 00007fe9803b5720 Mär 22 18:30:57 trundl.on kernel: R13: 0000555f33e2c650 R14: 0000000000000004 R15: 00007fe9803b5720 Mär 22 18:30:57 trundl.on kernel: ---[ end trace ff7b7de1d8244927 ]--- Mär 22 18:30:57 trundl.on kernel: ata6: port disabled--ignoring Mär 22 18:30:57 trundl.on kernel: sd 0:0:0:0: [sda] Starting disk Mär 22 18:30:57 trundl.on kernel: [drm] radeon: 1 quad pipes, 1 z pipes initialized. Mär 22 18:30:57 trundl.on kernel: [drm] PCIE GART of 512M enabled (table at 0x0000000000040000). Mär 22 18:30:57 trundl.on kernel: radeon 0000:01:00.0: WB enabled Mär 22 18:30:57 trundl.on kernel: radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000008000000 Mär 22 18:30:57 trundl.on kernel: [drm] radeon: ring at 0x0000000008001000 Mär 22 18:30:57 trundl.on kernel: tpm tpm0: tpm_try_transmit: send(): error -62 Mär 22 18:30:57 trundl.on kernel: ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd ef/10:03:00:00:00:a0 (SET FEATURES) filtered out Mär 22 18:30:57 trundl.on kernel: usb 5-2: reset full-speed USB device number 2 using uhci_hcd Mär 22 18:30:57 trundl.on kernel: ata1.00: NCQ Send/Recv Log not supported Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd ef/02:00:00:00:00:a0 (SET FEATURES) succeeded Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd f5/00:00:00:00:00:a0 (SECURITY FREEZE LOCK) filtered out Mär 22 18:30:57 trundl.on kernel: ata1.00: ACPI cmd ef/10:03:00:00:00:a0 (SET FEATURES) filtered out Mär 22 18:30:57 trundl.on kernel: ata1.00: NCQ Send/Recv Log not supported Mär 22 18:30:57 trundl.on kernel: ata1.00: configured for UDMA/133 Mär 22 18:30:57 trundl.on kernel: ata1.00: Enabling discard_zeroes_data Mär 22 18:30:57 trundl.on kernel: [drm:r100_ring_test [radeon]] *ERROR* radeon: ring test failed (scratch(0x15E8)=0xCAFEDEAD) Mär 22 18:30:57 trundl.on kernel: [drm:r100_cp_init [radeon]] *ERROR* radeon: cp isn't working (-22). Mär 22 18:30:57 trundl.on kernel: radeon 0000:01:00.0: failed initializing CP (-22). Mär 22 18:30:57 trundl.on gnome-shell[2048]: radeon: The kernel rejected CS, see dmesg for more information (-16). The 'The kernel rejected CS...' line is repeated multiple times. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 1

[PATCH 00/21] drm/msm/dpu: cleanup callbacks, resource manager
by Dmitry Baryshkov 24 Mar '21

24 Mar '21

In the DPU driver each and every component would provide callbacks, which are mostly static. Other components would use callbacks to receive functionality instead of calling functions directly. Drop (most) of this indirection, replacing with direct function calls. CTL and SSPP blocks are left unconverted for now. As we are at it, significant part of RM (resource manager) work is dedicated to allocating statically linked components. Each LM is tied to the single PP. Each MERGE_3D can be used by the specified pair of PPs. Each DSPP is also tied to single LM. So instead of allocating them through the RM, get them via static configuration.

2 23

[PATCH 0/4] drm/i915: missing workarounds and refactors
by Lucas De Marchi 24 Mar '21

24 Mar '21

Missing WAs and related refactors. Caz Yokoyama (2): drm/i915/gen12: Add recommended hardware tuning value drm/i915/icl: add Wa_22010271021 for all gen11 José Roberto de Souza (1): drm/i915: Move Wa_16011163337 to gen12_ctx_workarounds_init() Swathi Dhanavanthri (1): drm/i915: Add Wa_14011060649 drivers/gpu/drm/i915/gt/intel_workarounds.c | 97 ++++++++++++++------- drivers/gpu/drm/i915/i915_reg.h | 3 + 2 files changed, 67 insertions(+), 33 deletions(-) -- 2.31.0

1 4

[PATCH] dt-bindings: msm: Couple of spelling fixes
by Bhaskar Chowdhury 24 Mar '21

24 Mar '21

s/Subsytem/Subsystem/ s/contoller/controller/ Signed-off-by: Bhaskar Chowdhury <unixbhaskar(a)gmail.com> --- Documentation/devicetree/bindings/display/msm/dpu.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt index 551ae26f60da..586e6eac5b08 100644 --- a/Documentation/devicetree/bindings/display/msm/dpu.txt +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt @@ -2,14 +2,14 @@ Qualcomm Technologies, Inc. DPU KMS Description: -Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates +Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates sub-blocks like DPU display controller, DSI and DP interfaces etc. The DPU display controller is found in SDM845 SoC. MDSS: Required properties: - compatible: "qcom,sdm845-mdss", "qcom,sc7180-mdss" -- reg: physical base address and length of contoller's registers. +- reg: physical base address and length of controller's registers. - reg-names: register region names. The following region is required: * "mdss" - power-domains: a power domain consumer specifier according to -- 2.26.2

2 2

[PATCH] drm/ttm: stop warning on TT shrinker failure
by Christian König 24 Mar '21

24 Mar '21

Don't print a warning when we fail to allocate a page for swapping things out. Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/ttm/ttm_tt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 2f0833c98d2c..86fa3e82dacc 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -369,7 +369,7 @@ static unsigned long ttm_tt_shrinker_scan(struct shrinker *shrink, }; int ret; - ret = ttm_bo_swapout(&ctx, GFP_NOFS); + ret = ttm_bo_swapout(&ctx, GFP_KERNEL | __GFP_NOWARN); return ret < 0 ? SHRINK_EMPTY : ret; } @@ -389,10 +389,13 @@ static unsigned long ttm_tt_shrinker_count(struct shrinker *shrink, static int ttm_tt_debugfs_shrink_show(struct seq_file *m, void *data) { struct shrink_control sc = { .gfp_mask = GFP_KERNEL }; + unsigned int flags; fs_reclaim_acquire(GFP_KERNEL); + flags = memalloc_nofs_save(); seq_printf(m, "%lu/%lu\n", ttm_tt_shrinker_count(&mm_shrinker, &sc), ttm_tt_shrinker_scan(&mm_shrinker, &sc)); + memalloc_nofs_restore(flags); fs_reclaim_release(GFP_KERNEL); return 0; -- 2.25.1

7 36

[PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.
by Mark Yacoub 24 Mar '21

24 Mar '21

From: Mark Yacoub <markyacoub(a)google.com> On initializing the framebuffer, call drm_any_plane_has_format to do a check if the modifier is supported. drm_any_plane_has_format calls dm_plane_format_mod_supported which is extended to validate that the modifier is on the list of the plane's supported modifiers. The bug was caught using igt-gpu-tools test: kms_addfb_basic.addfb25-bad-modifier Tested on ChromeOS Zork by turning on the display, running an overlay test, and running a YT video. Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: Bas Nieuwenhuizen <bas(a)basnieuwenhuizen.nl> Signed-off-by: default avatarMark Yacoub <markyacoub(a)chromium.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 +++++++++++++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +++++++++ 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index afa5f8ad0f563..a947b5aa420d2 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -908,6 +908,19 @@ int amdgpu_display_gem_fb_verify_and_init( &amdgpu_fb_funcs); if (ret) goto err; + /* Verify that the modifier is supported. */ + if (!drm_any_plane_has_format(dev, mode_cmd->pixel_format, + mode_cmd->modifier[0])) { + struct drm_format_name_buf format_name; + drm_dbg_kms(dev, + "unsupported pixel format %s / modifier 0x%llx\n", + drm_get_format_name(mode_cmd->pixel_format, + &format_name), + mode_cmd->modifier[0]); + + ret = -EINVAL; + goto err; + } ret = amdgpu_display_framebuffer_init(dev, rfb, mode_cmd, obj); if (ret) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 961abf1cf040c..21314024a83ce 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3939,6 +3939,7 @@ static bool dm_plane_format_mod_supported(struct drm_plane *plane, { struct amdgpu_device *adev = drm_to_adev(plane->dev); const struct drm_format_info *info = drm_format_info(format); + int i; enum dm_micro_swizzle microtile = modifier_gfx9_swizzle_mode(modifier) & 3; @@ -3952,6 +3953,14 @@ static bool dm_plane_format_mod_supported(struct drm_plane *plane, if (modifier == DRM_FORMAT_MOD_LINEAR) return true; + /* Check that the modifier is on the list of the plane's supported modifiers. */ + for (i = 0; i < plane->modifier_count; i++) { + if (modifier == plane->modifiers[i]) + break; + } + if (i == plane->modifier_count) + return false; + /* * The arbitrary tiling support for multiplane formats has not been hooked * up. -- 2.30.1.766.gb4fecdf3b7-goog

6 11

← Newer
1
...
35
36
37
38
39
40
41
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2021