dri-devel March 2021

dri-devel@lists.freedesktop.org

326 participants
867 discussions

[PATCH v1] drm/tegra: dc: Don't set PLL clock to 0Hz
by Dmitry Osipenko 24 Mar '21

24 Mar '21

RGB output doesn't allow to change parent clock rate of the display and PCLK rate is set to 0Hz in this case. The tegra_dc_commit_state() shall not set the display clock to 0Hz since this change propagates to the parent clock. The DISP clock is defined as a NODIV clock by the tegra-clk driver and all NODIV clocks use the CLK_SET_RATE_PARENT flag. This bug stayed unnoticed because by default PLLP is used as the parent clock for the display controller and PLLP silently skips the erroneous 0Hz rate changes because it always has active child clocks that don't permit rate changes. The PLLP isn't acceptable for some devices that we want to upstream (like Samsung Galaxy Tab and ASUS TF700T) due to a display panel clock rate requirements that can't be fulfilled by using PLLP and then the bug pops up in this case since parent clock is set to 0Hz, killing the display output. Don't touch DC clock if pclk=0 in order to fix the problem. Signed-off-by: Dmitry Osipenko <digetx(a)gmail.com> --- drivers/gpu/drm/tegra/dc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 1399e4032701..4ecda4cdf345 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -1723,6 +1723,11 @@ static void tegra_dc_commit_state(struct tegra_dc *dc, dev_err(dc->dev, "failed to set clock rate to %lu Hz\n", state->pclk); + + err = clk_set_rate(dc->clk, state->pclk); + if (err < 0) + dev_err(dc->dev, "failed to set clock %pC to %lu Hz: %d\n", + dc->clk, state->pclk, err); } DRM_DEBUG_KMS("rate: %lu, div: %u\n", clk_get_rate(dc->clk), @@ -1733,11 +1738,6 @@ static void tegra_dc_commit_state(struct tegra_dc *dc, value = SHIFT_CLK_DIVIDER(state->div) | PIXEL_CLK_DIVIDER_PCD1; tegra_dc_writel(dc, value, DC_DISP_DISP_CLOCK_CONTROL); } - - err = clk_set_rate(dc->clk, state->pclk); - if (err < 0) - dev_err(dc->dev, "failed to set clock %pC to %lu Hz: %d\n", - dc->clk, state->pclk, err); } static void tegra_dc_stop(struct tegra_dc *dc) -- 2.29.2

2 1

[PATCH] amdgpu: fix gcc -Wrestrict warning
by Arnd Bergmann 24 Mar '21

24 Mar '21

From: Arnd Bergmann <arnd(a)arndb.de> gcc warns about an sprintf() that uses the same buffer as source and destination, which is undefined behavior in C99: drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function 'amdgpu_securedisplay_debugfs_write': drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:141:6: error: 'sprintf' argument 3 overlaps destination object 'i2c_output' [-Werror=restrict] 141 | sprintf(i2c_output, "%s 0x%X", i2c_output, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 142 | securedisplay_cmd->securedisplay_out_message.send_roi_crc.i2c_buf[i]); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:97:7: note: destination object referenced by 'restrict'-qualified argument 1 was declared here 97 | char i2c_output[256]; | ^~~~~~~~~~ Rewrite it to remember the current offset into the buffer instead. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c index 834440ab9ff7..69d7f6bff5d4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c @@ -136,9 +136,10 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __u ret = psp_securedisplay_invoke(psp, TA_SECUREDISPLAY_COMMAND__SEND_ROI_CRC); if (!ret) { if (securedisplay_cmd->status == TA_SECUREDISPLAY_STATUS__SUCCESS) { + int pos = 0; memset(i2c_output, 0, sizeof(i2c_output)); for (i = 0; i < TA_SECUREDISPLAY_I2C_BUFFER_SIZE; i++) - sprintf(i2c_output, "%s 0x%X", i2c_output, + pos += sprintf(i2c_output + pos, " 0x%X", securedisplay_cmd->securedisplay_out_message.send_roi_crc.i2c_buf[i]); dev_info(adev->dev, "SECUREDISPLAY: I2C buffer out put is :%s\n", i2c_output); } else { -- 2.29.2

4 5

Re: [PATCH v1] MAINTAINERS: Update Maintainers of DRM Bridge Drivers
by Laurent Pinchart 24 Mar '21

24 Mar '21

Hi Rob, On Wed, Mar 24, 2021 at 11:20:19AM +0100, Robert Foss wrote: > Add myself as co-maintainer of DRM Bridge Drivers. Repository > commit access has already been granted. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 > > Cc: Neil Armstrong <narmstrong(a)baylibre.com> > Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> > Cc: Jonas Karlman <jonas(a)kwiboo.se> > Cc: Andrzej Hajda <a.hajda(a)samsung.com> > Cc: Jernej Škrabec <jernej.skrabec(a)siol.net> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Signed-off-by: Robert Foss <robert.foss(a)linaro.org> Acked-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> and welcome :-) > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4b705ba51c54..16ace8f58649 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5902,6 +5902,7 @@ F: drivers/gpu/drm/atmel-hlcdc/ > DRM DRIVERS FOR BRIDGE CHIPS > M: Andrzej Hajda <a.hajda(a)samsung.com> > M: Neil Armstrong <narmstrong(a)baylibre.com> > +M: Robert Foss <robert.foss(a)linaro.org> > R: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> > R: Jonas Karlman <jonas(a)kwiboo.se> > R: Jernej Skrabec <jernej.skrabec(a)siol.net> -- Regards, Laurent Pinchart

1 0

[PATCH] video/fbdev: Fix a double free in hvfb_probe
by Lv Yunlong 24 Mar '21

24 Mar '21

In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) and return err when info->apertures is freed. In the error1 label of hvfb_probe, info->apertures will be freed twice by framebuffer_release(info). My patch sets info->apertures to NULL after it was freed to avoid double free. Signed-off-by: Lv Yunlong <lyl2019(a)mail.ustc.edu.cn> --- drivers/video/fbdev/hyperv_fb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c index c8b0ae676809..2fc9b507e73a 100644 --- a/drivers/video/fbdev/hyperv_fb.c +++ b/drivers/video/fbdev/hyperv_fb.c @@ -1032,6 +1032,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info) if (!pdev) { pr_err("Unable to find PCI Hyper-V video\n"); kfree(info->apertures); + info->apertures = NULL; return -ENODEV; } @@ -1130,6 +1131,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info) pci_dev_put(pdev); } kfree(info->apertures); + info->apertures = NULL; return 0; @@ -1142,6 +1144,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info) if (!gen2vm) pci_dev_put(pdev); kfree(info->apertures); + info->apertures = NULL; return -ENOMEM; } -- 2.25.1

4 3

Re: [PATCH v1] MAINTAINERS: Update Maintainers of DRM Bridge Drivers
by Neil Armstrong 24 Mar '21

24 Mar '21

Hi ! On 24/03/2021 11:20, Robert Foss wrote: > Add myself as co-maintainer of DRM Bridge Drivers. Repository > commit access has already been granted. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/338 > > Cc: Neil Armstrong <narmstrong(a)baylibre.com> > Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> > Cc: Jonas Karlman <jonas(a)kwiboo.se> > Cc: Andrzej Hajda <a.hajda(a)samsung.com> > Cc: Jernej Škrabec <jernej.skrabec(a)siol.net> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Signed-off-by: Robert Foss <robert.foss(a)linaro.org> + CC: dri-devel(a)lists.freedesktop.org > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4b705ba51c54..16ace8f58649 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5902,6 +5902,7 @@ F: drivers/gpu/drm/atmel-hlcdc/ > DRM DRIVERS FOR BRIDGE CHIPS > M: Andrzej Hajda <a.hajda(a)samsung.com> > M: Neil Armstrong <narmstrong(a)baylibre.com> > +M: Robert Foss <robert.foss(a)linaro.org> > R: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> > R: Jonas Karlman <jonas(a)kwiboo.se> > R: Jernej Skrabec <jernej.skrabec(a)siol.net> > Acked-by: Neil Armstrong <narmstrong(a)baylibre.com> Welcome to the team, help is needed ! Neil

1 0

[PATCH v4 0/4] drm: sun4i: dsi: Convert drm bridge
by Jagan Teki 24 Mar '21

24 Mar '21

This series convert Allwinner DSI controller to full functional drm bridge driver for supporting slave panel, bridges. Here, are the previous version changes[1]. Patch 1: use drm_of_find_panel_or_bridge API Patch 2: Adding DRM Bridge support Patch 3: Convert to bridge driver, that indeed drop encoder API's and support bridge API's Patch 4: Overlay patch for bridge enablement in BPI-M2M Note: Only nit on this series is kms hotplug, added Samuel Holland for reviews and comments as he is authorized the code before. [1] https://lkml.org/lkml/2021/2/14/173 Any inputs on this would be appreciated! Jagan. Jagan Teki (4): drm: sun4i: dsi: Use drm_of_find_panel_or_bridge drm: sun4i: dsi: Add bridge support drm: sun4i: dsi: Convert to bridge driver [DO NOT MERGE] ARM: dts: sun8i: bananapi-m2m: Enable S070WV20-CT16 panel arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 85 ++++++++++++++++ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 100 +++++++++++++------ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 8 +- 3 files changed, 160 insertions(+), 33 deletions(-) -- 2.25.1

4 14

[PATCH] i915_vma: Rename vma_lookup to i915_vma_lookup
by Liam Howlett 24 Mar '21

24 Mar '21

Use i915 prefix to avoid name collision with future vma_lookup() in mm. Signed-off-by: Liam R. Howlett <Liam.Howlett(a)Oracle.com> Reviewed-by: Matthew Wilcox (Oracle) <willy(a)infradead.org> --- drivers/gpu/drm/i915/i915_vma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index caa9b041616b..ee0028c697f6 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -230,7 +230,7 @@ vma_create(struct drm_i915_gem_object *obj, } static struct i915_vma * -vma_lookup(struct drm_i915_gem_object *obj, +i915_vma_lookup(struct drm_i915_gem_object *obj, struct i915_address_space *vm, const struct i915_ggtt_view *view) { @@ -278,7 +278,7 @@ i915_vma_instance(struct drm_i915_gem_object *obj, GEM_BUG_ON(!atomic_read(&vm->open)); spin_lock(&obj->vma.lock); - vma = vma_lookup(obj, vm, view); + vma = i915_vma_lookup(obj, vm, view); spin_unlock(&obj->vma.lock); /* vma_create() will resolve the race if another creates the vma */ -- 2.30.0

2 1

[PATCH v2 0/3] Fixes to bridge/panel and ingenic-drm
by Paul Cercueil 24 Mar '21

24 Mar '21

Hi, Here are three independent fixes. The first one addresses a use-after-free in bridge/panel.c; the second one addresses a use-after-free in the ingenic-drm driver; finally, the third one makes the ingenic-drm driver work again on older Ingenic SoCs. Changes from v1: - patch [1/3]: the connector is cleaned up only if it was initialized in the first place; - patch [2/3]: use __drmm_simple_encoder_alloc; - patch [3/3] is unmodified. Note to linux-stable guys: patch [v2 2/3] will only apply on the current drm-misc-next branch, to fix it for v5.11 and older kernels, use the V1 of that patch. Cheers, -Paul Paul Cercueil (3): drm: bridge/panel: Cleanup connector on bridge detach drm/ingenic: Register devm action to cleanup encoders drm/ingenic: Fix non-OSD mode drivers/gpu/drm/bridge/panel.c | 6 +++++ drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 27 ++++++++++++----------- 2 files changed, 20 insertions(+), 13 deletions(-) -- 2.29.2

3 14

[PATCH] drm/rockchip: Remove unused variable
by Maxime Ripard 24 Mar '21

24 Mar '21

Commit 977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update") added the old_state variable instead of what used to be a parameter, but it also removed the sole user of that variable in the vop_plane_atomic_update function leading to an usused variable. Remove it. Fixes: 977697e20b3d ("drm/atomic: Pass the full state to planes atomic disable and update") Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Maxime Ripard <maxime(a)cerno.tech> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 81c70d7a0471..64469439ddf2 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -879,8 +879,6 @@ static void vop_plane_atomic_disable(struct drm_plane *plane, static void vop_plane_atomic_update(struct drm_plane *plane, struct drm_atomic_state *state) { - struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, - plane); struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane); struct drm_crtc *crtc = new_state->crtc; -- 2.30.2

2 2

[PATCH] drm/malidp: Convert sysfs sprintf/snprintf family to sysfs_emit
by Tian Tao 24 Mar '21

24 Mar '21

Fix the following coccicheck warning: drivers/gpu//drm/arm/malidp_drv.c:658:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> --- drivers/gpu/drm/arm/malidp_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index d83c736..b4ad0f2 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -655,7 +655,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr, struct drm_device *drm = dev_get_drvdata(dev); struct malidp_drm *malidp = drm->dev_private; - return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id); + return sysfs_emit(buf, "%08x\n", malidp->core_id); } static DEVICE_ATTR_RO(core_id); -- 2.7.4

1 0

← Newer
1
...
36
37
38
39
40
41
42
...
87
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2021