dri-devel September 2021

dri-devel@lists.freedesktop.org

348 participants
817 discussions

intel display struct refactor
by Dave Airlie 06 Sep '21

06 Sep '21

I posted an intro set of patches to intel-gfx earlier, but I got a bit OCD and kept going here. https://cgit.freedesktop.org/~airlied/linux/log/?h=i915-display-struct-refa… Mainly looking to see if this is interesting enough refactor to get it landed, I realise it would be quite disruptive. I'd also like to see if I missed anything really obvious, I wasn't sure whether vbt/opregion were suitable and I may have left some stuff behind. Dave.

1 0

[PATCH v2 2/2] drm/amdpgu: Use VRAM domain in UVD IB test
by Pan, Xinhui 06 Sep '21

06 Sep '21

[AMD Official Use Only] Like vce/vcn does, visible VRAM is OK for ib test. While commit a11d9ff3ebe0 ("drm/amdgpu: use GTT for uvd_get_create/destory_msg") says VRAM is not mapped correctly in his platform which is likely an arm64. So lets change back to use VRAM on x86_64 platform. Signed-off-by: xinhui pan <xinhui.pan(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/… [View More]

2 1

[PATCH v4 00/17] Add MediaTek SoC DRM (vdosys1) support for mt8195
by Nancy.Lin 06 Sep '21

06 Sep '21

The hardware path of vdosys1 with DPTx output need to go through by several modules, such as, OVL_ADAPTOR and MERGE. Add DRM and these modules support by the patches below: Changes in v4: - use merge common driver for merge1~4. - refine ovl_adaptor rdma driver. - use ovl_adaptor ddp_comp function instead of ethdr. - modify for reviewer's comment in v3. Changes in v3: - modify for reviewer's comment in v2. - add vdosys1 2 pixels align limit. - add mixer odd offset support. Changes in v2: - … [View More]Merge PSEUDO_OVL and ETHDR into one DRM component. - Add mmsys config API for vdosys1 hardware setting. - Add mmsys reset control using linux reset framework. Signed-off-by: Nancy.Lin <nancy.lin(a)mediatek.com> This series are based on the following patch: [1] arm64: dts: Add Mediatek SoC MT8195 and evaluation board dts and Makefile https://patchwork.kernel.org/project/linux-mediatek/patch/20210601075350.31… [2] arm64: dts: mt8195: add IOMMU and smi nodes https://patchwork.kernel.org/project/linux-mediatek/patch/20210615173233.26… [3] [01/24] dt-bindings: mediatek: mt8195: Add binding for MM IOMMU https://patchwork.kernel.org/project/linux-mediatek/patch/20210630023504.18… [4] Add gce support for mt8195 https://patchwork.kernel.org/project/linux-mediatek/list/?series=515599 [5] Add MediaTek SoC DRM (vdosys0) support for mt8195 https://patchwork.kernel.org/project/linux-mediatek/list/?series=531695 [6] [v8,1/2] dt-bindings: reset: mt8195: add toprgu reset-controller header file https://patchwork.kernel.org/project/linux-mediatek/patch/20210806023606.16… Nancy.Lin (17): dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195 dt-bindings: mediatek: add vdosys1 MERGE property for mt8195 dt-bindings: mediatek: add ethdr definition for mt8195 dt-bindings: mediatek: Add #reset-cells to mmsys system controller dt-bindings: reset: mt8195: add vdosys1 reset control bit arm64: dts: mt8195: add display node for vdosys1 soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 soc: mediatek: add mtk-mmsys config API for mt8195 vdosys1 soc: mediatek: add cmdq support of mtk-mmsys config API for mt8195 vdosys1 soc: mediatek: mmsys: Add reset controller support for MT8195 vdosys1 soc: mediatek: add mtk-mutex support for mt8195 vdosys1 drm/mediatek: add display MDP RDMA support for MT8195 drm/mediatek: add display merge api support for MT8195 drm/mediatek: add ETHDR support for MT8195 drm/mediatek: add ovl_adaptor support for MT8195 drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support drm/mediatek: add mediatek-drm of vdosys1 support for MT8195 .../bindings/arm/mediatek/mediatek,mmsys.yaml | 3 + .../display/mediatek/mediatek,ethdr.yaml | 144 ++++++ .../display/mediatek/mediatek,mdp-rdma.yaml | 77 ++++ .../display/mediatek/mediatek,merge.yaml | 3 + arch/arm64/boot/dts/mediatek/mt8195.dtsi | 221 +++++++++ drivers/gpu/drm/mediatek/Makefile | 5 +- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 29 ++ drivers/gpu/drm/mediatek/mtk_disp_merge.c | 78 +++- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 406 +++++++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 25 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 3 +- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 15 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 377 +++++++++++++--- drivers/gpu/drm/mediatek/mtk_drm_drv.h | 9 +- drivers/gpu/drm/mediatek/mtk_ethdr.c | 424 ++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_ethdr.h | 25 ++ drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 306 +++++++++++++ drivers/gpu/drm/mediatek/mtk_mdp_rdma.h | 37 ++ drivers/soc/mediatek/mt8195-mmsys.h | 199 ++++++++ drivers/soc/mediatek/mtk-mmsys.c | 137 ++++++ drivers/soc/mediatek/mtk-mmsys.h | 11 + drivers/soc/mediatek/mtk-mutex.c | 270 ++++++----- include/dt-bindings/reset/mt8195-resets.h | 12 + include/linux/soc/mediatek/mtk-mmsys.h | 22 + 25 files changed, 2644 insertions(+), 195 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c create mode 100644 drivers/gpu/drm/mediatek/mtk_ethdr.c create mode 100644 drivers/gpu/drm/mediatek/mtk_ethdr.h create mode 100644 drivers/gpu/drm/mediatek/mtk_mdp_rdma.c create mode 100644 drivers/gpu/drm/mediatek/mtk_mdp_rdma.h -- 2.18.0 [View Less]

2 19

[PATCH v2 1/2] drm/ttm: Fix a deadlock if the target BO is not idle during swap
by Pan, Xinhui 06 Sep '21

06 Sep '21

[AMD Official Use Only] The ret value might be -EBUSY, caller will think lru lock is still locked but actually NOT. So return -ENOSPC instead. Otherwise we hit list corruption. ttm_bo_cleanup_refs might fail too if BO is not idle. If we return 0, caller(ttm_tt_populate -> ttm_global_swapout ->ttm_device_swapout) will be stuck as we actually did not free any BO memory. This usually happens when the fence is not signaled for a long time. Signed-off-by: xinhui pan <xinhui.pan(a)amd.com… [View More]

1 0

Subject: [PATCH v2 0/2] Fix a hung during memory pressure test
by Pan, Xinhui 06 Sep '21

06 Sep '21

[AMD Official Use Only] A long time ago, someone reports system got hung during memory test. In recent days, I am trying to look for or understand the potential deadlock in ttm/amdgpu code. This patchset aims to fix the deadlock during ttm populate. TTM has a parameter called pages_limit, when allocated GTT memory reaches this limit, swapout would be triggered. As ttm_bo_swapout does not return the correct retval, populate might get hung. UVD ib test uses GTT which might be insufficient. So … [View More]a gpu recovery would hung if populate hung. I have made one drm test which alloc two GTT BOs, submit gfx copy commands and free these BOs without waiting fence. What's more, these gfx copy commands will cause gfx ring hang. So gpu recovery would be triggered. Now here is one possible deadlock case. gpu_recovery -> stop drm scheduler -> asic reset -> ib test -> tt populate (uvd ib test) -> ttm_bo_swapout (BO A) // this always fails as the fence of BO A would not be signaled by schedluer or HW. Hit deadlock. I paste the drm test patch below. #modprobe ttm pages_limit=65536 #amdgpu_test -s 1 -t 4 --- tests/amdgpu/basic_tests.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c index dbf02fee..f85ed340 100644 --- a/tests/amdgpu/basic_tests.c +++ b/tests/amdgpu/basic_tests.c @@ -65,13 +65,16 @@ static void amdgpu_direct_gma_test(void); static void amdgpu_command_submission_write_linear_helper(unsigned ip_type); static void amdgpu_command_submission_const_fill_helper(unsigned ip_type); static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type); -static void amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, +static void _amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, unsigned ip_type, int instance, int pm4_dw, uint32_t *pm4_src, int res_cnt, amdgpu_bo_handle *resources, struct amdgpu_cs_ib_info *ib_info, - struct amdgpu_cs_request *ibs_request); + struct amdgpu_cs_request *ibs_request, int sync, int repeat); +#define amdgpu_test_exec_cs_helper(...) \ + _amdgpu_test_exec_cs_helper(__VA_ARGS__, 1, 1) + CU_TestInfo basic_tests[] = { { "Query Info Test", amdgpu_query_info_test }, { "Userptr Test", amdgpu_userptr_test }, @@ -1341,12 +1344,12 @@ static void amdgpu_command_submission_compute(void) * pm4_src, resources, ib_info, and ibs_request * submit command stream described in ibs_request and wait for this IB accomplished */ -static void amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, +static void _amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, unsigned ip_type, int instance, int pm4_dw, uint32_t *pm4_src, int res_cnt, amdgpu_bo_handle *resources, struct amdgpu_cs_ib_info *ib_info, - struct amdgpu_cs_request *ibs_request) + struct amdgpu_cs_request *ibs_request, int sync, int repeat) { int r; uint32_t expired; @@ -1395,12 +1398,15 @@ static void amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, CU_ASSERT_NOT_EQUAL(ibs_request, NULL); /* submit CS */ - r = amdgpu_cs_submit(context_handle, 0, ibs_request, 1); + while (repeat--) + r = amdgpu_cs_submit(context_handle, 0, ibs_request, 1); CU_ASSERT_EQUAL(r, 0); r = amdgpu_bo_list_destroy(ibs_request->resources); CU_ASSERT_EQUAL(r, 0); + if (!sync) + return; fence_status.ip_type = ip_type; fence_status.ip_instance = 0; fence_status.ring = ibs_request->ring; @@ -1667,7 +1673,7 @@ static void amdgpu_command_submission_sdma_const_fill(void) static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type) { - const int sdma_write_length = 1024; + const int sdma_write_length = (255) << 20; const int pm4_dw = 256; amdgpu_context_handle context_handle; amdgpu_bo_handle bo1, bo2; @@ -1715,8 +1721,6 @@ static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type) &bo1_va_handle); CU_ASSERT_EQUAL(r, 0); - /* set bo1 */ - memset((void*)bo1_cpu, 0xaa, sdma_write_length); /* allocate UC bo2 for sDMA use */ r = amdgpu_bo_alloc_and_map(device_handle, @@ -1727,8 +1731,6 @@ static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type) &bo2_va_handle); CU_ASSERT_EQUAL(r, 0); - /* clear bo2 */ - memset((void*)bo2_cpu, 0, sdma_write_length); resources[0] = bo1; resources[1] = bo2; @@ -1785,17 +1787,11 @@ static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type) } } - amdgpu_test_exec_cs_helper(context_handle, + _amdgpu_test_exec_cs_helper(context_handle, ip_type, ring_id, i, pm4, 2, resources, - ib_info, ibs_request); - - /* verify if SDMA test result meets with expected */ - i = 0; - while(i < sdma_write_length) { - CU_ASSERT_EQUAL(bo2_cpu[i++], 0xaa); - } + ib_info, ibs_request, 0, 100); r = amdgpu_bo_unmap_and_free(bo1, bo1_va_handle, bo1_mc, sdma_write_length); CU_ASSERT_EQUAL(r, 0); -- xinhui pan (2): drm/ttm: Fix a deadlock if the target BO is not idle during swap drm/amdpgu: Use VRAM domain in UVD IB test drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 8 ++++++++ drivers/gpu/drm/ttm/ttm_bo.c | 6 +++--- 2 files changed, 11 insertions(+), 3 deletions(-) -- 2.25.1 [View Less]

1 0

[PATCH v4 0/2] GPD Win Max display fixes
by Anisse Astier 05 Sep '21

05 Sep '21

This patch series is for making the GPD Win Max display usable with Linux. The GPD Win Max is a small laptop, and its eDP panel does not send an EDID over DPCD; the EDID is instead available in the intel opregion, in mailbox #5 [1] The second patch is just to fix the orientation of the panel. Changes since v1: - rebased on drm-tip - squashed patch 1 & 2 - picked up Reviewed-by from Hans de Goede (thanks for the review) Changes since v2: - rebased on drm-tip - updated commit message … [View More]

1 2

Re: Kernel 5.14.0 - invalid opcode: 0000 [#1] SMP NOPTI
by David Airlie 05 Sep '21

05 Sep '21

cc'ing lists/people On Sun, Sep 5, 2021 at 11:50 AM Andrew Falcon <bluestang2006(a)gmail.com> wrote: > > Hello, > > I am encountering a kernel panic with the error in the subject line using kernel 5.14.0 (final). Kernel 5.14.0-rc7 works without issue for me so looking back at the last amdgpu commits for 5.14.0 (final) not sure which one is at fault and causing the panic - https://cgit.freedesktop.org/drm/drm/tag/?h=drm-fixes-2021-08-27 > > I filed a kernel bug here - … [View More]https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1942684 with a full log attached in the report. I am not sure if a separate bug report is needed in drm kernel? I'm hoping I can get some advice on who needs to be aware of this bug or how to bring it to the right developer's attention... > > Below is the boot log and the specific error message: > > Sep 04 09:07:39 bluestang-pc kernel: [drm] initializing kernel modesetting (SIENNA_CICHLID 0x1002:0x73BF 0x1849:0x5201 0xC1). > Sep 04 09:07:39 bluestang-pc kernel: amdgpu 0000:2f:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported > Sep 04 09:07:39 bluestang-pc kernel: [drm] register mmio base: 0xFC900000 > Sep 04 09:07:39 bluestang-pc kernel: [drm] register mmio size: 1048576 > Sep 04 09:07:39 bluestang-pc kernel: invalid opcode: 0000 [#1] SMP NOPTI > Sep 04 09:07:39 bluestang-pc kernel: CPU: 1 PID: 533 Comm: systemd-udevd Not tainted 5.14.1-051401-generic #202109030936 > Sep 04 09:07:39 bluestang-pc kernel: Hardware name: Micro-Star International Co., Ltd. MS-7C84/MAG X570 TOMAHAWK WIFI (MS-7C84), BIOS 1.81 08/05/2021 > Sep 04 09:07:39 bluestang-pc kernel: RIP: 0010:amdgpu_discovery_reg_base_init+0x225/0x260 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: Code: 0f 85 d4 fe ff ff 48 83 45 c0 01 48 8b 45 c0 39 45 c8 0f 8f 55 fe ff ff 8b 45 b4 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b 48 c7 c7 e4 5a 61 c1 e8 9d 79 10 ff eb de 41 89 d0 48 c7 c7 > Sep 04 09:07:39 bluestang-pc kernel: RSP: 0018:ffffb883c1907928 EFLAGS: 00010202 > Sep 04 09:07:39 bluestang-pc kernel: RAX: 0000000000000008 RBX: ffff99558b89f128 RCX: 0000000000000006 > Sep 04 09:07:39 bluestang-pc kernel: RDX: ffffffffc1615b69 RSI: ffffffffc15c0428 RDI: 0000000000000000 > Sep 04 09:07:39 bluestang-pc kernel: RBP: ffffb883c1907978 R08: 0000000000000008 R09: 000000000000000b > Sep 04 09:07:39 bluestang-pc kernel: R10: ffff99558b89f120 R11: 0000000000000000 R12: ffff995587c00000 > Sep 04 09:07:39 bluestang-pc kernel: R13: 0000000000000019 R14: 0000000000000019 R15: ffff99558b89f120 > Sep 04 09:07:39 bluestang-pc kernel: FS: 00007f3d5b7138c0(0000) GS:ffff995c7ea40000(0000) knlGS:0000000000000000 > Sep 04 09:07:39 bluestang-pc kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > Sep 04 09:07:39 bluestang-pc kernel: CR2: 00007fc505b6c420 CR3: 0000000106d90000 CR4: 0000000000750ee0 > Sep 04 09:07:39 bluestang-pc kernel: PKRU: 55555554 > Sep 04 09:07:39 bluestang-pc kernel: Call Trace: > Sep 04 09:07:39 bluestang-pc kernel: nv_set_ip_blocks+0x8e/0xab0 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: amdgpu_device_ip_early_init+0x2b1/0x47f [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: ? amdgpu_device_get_job_timeout_settings+0x90/0x1cc [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: amdgpu_device_init.cold+0xc9/0x6d1 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: amdgpu_driver_load_kms+0x6d/0x310 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: amdgpu_pci_probe+0x11b/0x1a0 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: local_pci_probe+0x48/0x80 > Sep 04 09:07:39 bluestang-pc kernel: pci_device_probe+0x105/0x1d0 > Sep 04 09:07:39 bluestang-pc kernel: really_probe+0x1fe/0x400 > Sep 04 09:07:39 bluestang-pc kernel: __driver_probe_device+0x109/0x180 > Sep 04 09:07:39 bluestang-pc kernel: driver_probe_device+0x23/0x90 > Sep 04 09:07:39 bluestang-pc kernel: __driver_attach+0xac/0x1b0 > Sep 04 09:07:39 bluestang-pc kernel: ? __device_attach_driver+0xe0/0xe0 > Sep 04 09:07:39 bluestang-pc kernel: bus_for_each_dev+0x7e/0xc0 > Sep 04 09:07:39 bluestang-pc kernel: driver_attach+0x1e/0x20 > Sep 04 09:07:39 bluestang-pc kernel: bus_add_driver+0x135/0x1f0 > Sep 04 09:07:39 bluestang-pc kernel: driver_register+0x95/0xf0 > Sep 04 09:07:39 bluestang-pc kernel: __pci_register_driver+0x68/0x70 > Sep 04 09:07:39 bluestang-pc kernel: amdgpu_init+0x7c/0x1000 [amdgpu] > Sep 04 09:07:39 bluestang-pc kernel: ? 0xffffffffc0e95000 > Sep 04 09:07:39 bluestang-pc kernel: do_one_initcall+0x48/0x1d0 > Sep 04 09:07:39 bluestang-pc kernel: ? kmem_cache_alloc_trace+0x159/0x2c0 > Sep 04 09:07:39 bluestang-pc kernel: do_init_module+0x62/0x290 > Sep 04 09:07:39 bluestang-pc kernel: load_module+0xaa8/0xb40 > Sep 04 09:07:39 bluestang-pc kernel: __do_sys_finit_module+0xbf/0x120 > Sep 04 09:07:39 bluestang-pc kernel: __x64_sys_finit_module+0x18/0x20 > Sep 04 09:07:39 bluestang-pc kernel: do_syscall_64+0x5c/0xc0 > Sep 04 09:07:39 bluestang-pc kernel: ? exit_to_user_mode_prepare+0x37/0xb0 > Sep 04 09:07:39 bluestang-pc kernel: ? syscall_exit_to_user_mode+0x27/0x50 > Sep 04 09:07:39 bluestang-pc kernel: ? __x64_sys_newfstatat+0x1c/0x20 > Sep 04 09:07:39 bluestang-pc kernel: ? do_syscall_64+0x69/0xc0 > Sep 04 09:07:39 bluestang-pc kernel: ? do_syscall_64+0x69/0xc0 > Sep 04 09:07:39 bluestang-pc kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae > Sep 04 09:07:39 bluestang-pc kernel: RIP: 0033:0x7f3d5bbcbf6d > Sep 04 09:07:39 bluestang-pc kernel: Code: 28 0d 00 0f 05 eb a9 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d cb de 0c 00 f7 d8 64 89 01 48 > Sep 04 09:07:39 bluestang-pc kernel: RSP: 002b:00007fffa53a9048 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 > Sep 04 09:07:39 bluestang-pc kernel: RAX: ffffffffffffffda RBX: 000055866fe87bf0 RCX: 00007f3d5bbcbf6d > Sep 04 09:07:39 bluestang-pc kernel: RDX: 0000000000000000 RSI: 00007f3d5bd71e2d RDI: 000000000000001a > Sep 04 09:07:39 bluestang-pc kernel: RBP: 0000000000020000 R08: 0000000000000000 R09: 000055866e61889d > Sep 04 09:07:39 bluestang-pc kernel: R10: 000000000000001a R11: 0000000000000246 R12: 00007f3d5bd71e2d > Sep 04 09:07:39 bluestang-pc kernel: R13: 0000000000000000 R14: 000055866fd4d9e0 R15: 000055866fe87bf0 > Sep 04 09:07:39 bluestang-pc kernel: Modules linked in: snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec iwlmvm(+) snd_hda_core amd64_edac(-) snd_hwdep amdgpu(+) edac_mce_amd fjes(-) snd_pcm mac80211 snd_seq_midi snd_seq_midi_event kvm_amd iommu_v2 libarc4 gpu_sched snd_rawmidi drm_ttm_helper kvm btusb ttm btrtl iwlwifi snd_seq btbcm drm_kms_helper btintel crct10dif_pclmul ghash_clmulni_intel snd_seq_device bluetooth aesni_intel cec snd_timer rc_core ucsi_ccg i2c_algo_bit snd crypto_simd typec_ucsi fb_sys_fops cryptd syscopyarea joydev ecdh_generic sysfillrect rapl wmi_bmof typec ecc efi_pstore sysimgblt cfg80211 soundcore k10temp ccp mac_hid sch_fq_codel msr parport_pc ppdev lp parport drm ip_tables x_tables autofs4 hid_generic usbhid hid xhci_pci ahci r8169 nvme crc32_pclmul i2c_designware_pci xhci_pci_renesas i2c_piix4 libahci realtek nvme_core wmi > Sep 04 09:07:39 bluestang-pc kernel: ---[ end trace a2f802476d316123 ]--- > > [View Less]

1 0

[drm-intel:drm-intel-gt-next 1/1] drivers/gpu/drm/i915/i915_query.c:439:2: warning: comparison of integers of different signs: 'int' and 'unsigned int'
by kernel test robot 05 Sep '21

05 Sep '21

tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next head: d5ef86b38e4c2a65d5c1d64d8d0f3fcf58aa0884 commit: d5ef86b38e4c2a65d5c1d64d8d0f3fcf58aa0884 [1/1] drm/i915: Add pci ids and uapi for DG1 config: i386-randconfig-r002-20210903 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1104e3258b5064e7110cc297e2cec60ac9acfc0a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -… [View More]O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add drm-intel git://anongit.freedesktop.org/drm-intel git fetch --no-tags drm-intel drm-intel-gt-next git checkout d5ef86b38e4c2a65d5c1d64d8d0f3fcf58aa0884 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): include/linux/random.h:127:67: warning: unused parameter 'v' [-Wunused-parameter] static inline bool __must_check arch_get_random_int(unsigned int *v) ^ include/linux/random.h:131:74: warning: unused parameter 'v' [-Wunused-parameter] static inline bool __must_check arch_get_random_seed_long(unsigned long *v) ^ include/linux/random.h:135:72: warning: unused parameter 'v' [-Wunused-parameter] static inline bool __must_check arch_get_random_seed_int(unsigned int *v) ^ In file included from drivers/gpu/drm/i915/i915_query.c:9: In file included from drivers/gpu/drm/i915/i915_drv.h:84: In file included from drivers/gpu/drm/i915/gt/intel_engine.h:17: In file included from drivers/gpu/drm/i915/gt/intel_gt_types.h:18: In file included from drivers/gpu/drm/i915/gt/uc/intel_uc.h:9: drivers/gpu/drm/i915/gt/uc/intel_guc.h:180:59: warning: unused parameter 'guc' [-Wunused-parameter] static inline u32 intel_guc_ggtt_offset(struct intel_guc *guc, ^ In file included from drivers/gpu/drm/i915/i915_query.c:9: In file included from drivers/gpu/drm/i915/i915_drv.h:101: drivers/gpu/drm/i915/i915_gpu_error.h:276:43: warning: unused parameter 'gt' [-Wunused-parameter] i915_capture_error_state(struct intel_gt *gt, intel_engine_mask_t engine_mask) ^ drivers/gpu/drm/i915/i915_gpu_error.h:276:67: warning: unused parameter 'engine_mask' [-Wunused-parameter] i915_capture_error_state(struct intel_gt *gt, intel_engine_mask_t engine_mask) ^ drivers/gpu/drm/i915/i915_gpu_error.h:281:50: warning: unused parameter 'i915' [-Wunused-parameter] i915_gpu_coredump_alloc(struct drm_i915_private *i915, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:281:62: warning: unused parameter 'gfp' [-Wunused-parameter] i915_gpu_coredump_alloc(struct drm_i915_private *i915, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:287:42: warning: unused parameter 'gt' [-Wunused-parameter] intel_gt_coredump_alloc(struct intel_gt *gt, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:287:52: warning: unused parameter 'gfp' [-Wunused-parameter] intel_gt_coredump_alloc(struct intel_gt *gt, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:293:53: warning: unused parameter 'engine' [-Wunused-parameter] intel_engine_coredump_alloc(struct intel_engine_cs *engine, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:293:67: warning: unused parameter 'gfp' [-Wunused-parameter] intel_engine_coredump_alloc(struct intel_engine_cs *engine, gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:299:65: warning: unused parameter 'ee' [-Wunused-parameter] intel_engine_coredump_add_request(struct intel_engine_coredump *ee, ^ drivers/gpu/drm/i915/i915_gpu_error.h:300:28: warning: unused parameter 'rq' [-Wunused-parameter] struct i915_request *rq, ^ drivers/gpu/drm/i915/i915_gpu_error.h:301:13: warning: unused parameter 'gfp' [-Wunused-parameter] gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:307:61: warning: unused parameter 'ee' [-Wunused-parameter] intel_engine_coredump_add_vma(struct intel_engine_coredump *ee, ^ drivers/gpu/drm/i915/i915_gpu_error.h:308:43: warning: unused parameter 'capture' [-Wunused-parameter] struct intel_engine_capture_vma *capture, ^ drivers/gpu/drm/i915/i915_gpu_error.h:309:36: warning: unused parameter 'compress' [-Wunused-parameter] struct i915_vma_compress *compress) ^ drivers/gpu/drm/i915/i915_gpu_error.h:314:52: warning: unused parameter 'gt' [-Wunused-parameter] i915_vma_capture_prepare(struct intel_gt_coredump *gt) ^ drivers/gpu/drm/i915/i915_gpu_error.h:320:51: warning: unused parameter 'gt' [-Wunused-parameter] i915_vma_capture_finish(struct intel_gt_coredump *gt, ^ drivers/gpu/drm/i915/i915_gpu_error.h:321:30: warning: unused parameter 'compress' [-Wunused-parameter] struct i915_vma_compress *compress) ^ drivers/gpu/drm/i915/i915_gpu_error.h:326:50: warning: unused parameter 'error' [-Wunused-parameter] i915_error_state_store(struct i915_gpu_coredump *error) ^ drivers/gpu/drm/i915/i915_gpu_error.h:330:68: warning: unused parameter 'gpu' [-Wunused-parameter] static inline void i915_gpu_coredump_put(struct i915_gpu_coredump *gpu) ^ drivers/gpu/drm/i915/i915_gpu_error.h:335:49: warning: unused parameter 'i915' [-Wunused-parameter] i915_first_error_state(struct drm_i915_private *i915) ^ drivers/gpu/drm/i915/i915_gpu_error.h:340:68: warning: unused parameter 'i915' [-Wunused-parameter] static inline void i915_reset_error_state(struct drm_i915_private *i915) ^ drivers/gpu/drm/i915/i915_gpu_error.h:344:70: warning: unused parameter 'i915' [-Wunused-parameter] static inline void i915_disable_error_state(struct drm_i915_private *i915, ^ drivers/gpu/drm/i915/i915_gpu_error.h:345:14: warning: unused parameter 'err' [-Wunused-parameter] int err) ^ drivers/gpu/drm/i915/i915_query.c:21:25: warning: comparison of integers of different signs: '__s32' (aka 'int') and 'u32' (aka 'unsigned int') [-Wsign-compare] if (query_item->length < total_length) ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_query.c:143:15: warning: unused parameter 'user_regs_ptr' [-Wunused-parameter] u64 user_regs_ptr, ^ drivers/gpu/drm/i915/i915_query.c:216:25: warning: comparison of integers of different signs: '__s32' (aka 'int') and 'u32' (aka 'unsigned int') [-Wsign-compare] if (query_item->length < total_size) { ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~ drivers/gpu/drm/i915/i915_query.c:384:25: warning: comparison of integers of different signs: '__s32' (aka 'int') and 'size_t' (aka 'unsigned int') [-Wsign-compare] if (query_item->length < sizeof_perf_config_list(n_configs)) { ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/i915/i915_query.c:439:2: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare] for_each_memory_region(mr, i915, id) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_memory_region.h:46:18: note: expanded from macro 'for_each_memory_region' for (id = 0; id < ARRAY_SIZE((i915)->mm.regions); id++) \ ~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_query.c:453:16: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(query.rsvd); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_query.c:458:2: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare] for_each_memory_region(mr, i915, id) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_memory_region.h:46:18: note: expanded from macro 'for_each_memory_region' for (id = 0; id < ARRAY_SIZE((i915)->mm.regions); id++) \ ~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_query.c:488:75: warning: unused parameter 'file' [-Wunused-parameter] int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file) ^ 1706 warnings generated. vim +439 drivers/gpu/drm/i915/i915_query.c 4f6ccc74a85cbb Lionel Landwerlin 2019-10-14 421 710217292a6111 Abdiel Janulgue 2021-04-29 422 static int query_memregion_info(struct drm_i915_private *i915, 710217292a6111 Abdiel Janulgue 2021-04-29 423 struct drm_i915_query_item *query_item) 710217292a6111 Abdiel Janulgue 2021-04-29 424 { 710217292a6111 Abdiel Janulgue 2021-04-29 425 struct drm_i915_query_memory_regions __user *query_ptr = 710217292a6111 Abdiel Janulgue 2021-04-29 426 u64_to_user_ptr(query_item->data_ptr); 710217292a6111 Abdiel Janulgue 2021-04-29 427 struct drm_i915_memory_region_info __user *info_ptr = 710217292a6111 Abdiel Janulgue 2021-04-29 428 &query_ptr->regions[0]; 710217292a6111 Abdiel Janulgue 2021-04-29 429 struct drm_i915_memory_region_info info = { }; 710217292a6111 Abdiel Janulgue 2021-04-29 430 struct drm_i915_query_memory_regions query; 710217292a6111 Abdiel Janulgue 2021-04-29 431 struct intel_memory_region *mr; 710217292a6111 Abdiel Janulgue 2021-04-29 432 u32 total_length; 710217292a6111 Abdiel Janulgue 2021-04-29 433 int ret, id, i; 710217292a6111 Abdiel Janulgue 2021-04-29 434 710217292a6111 Abdiel Janulgue 2021-04-29 435 if (query_item->flags != 0) 710217292a6111 Abdiel Janulgue 2021-04-29 436 return -EINVAL; 710217292a6111 Abdiel Janulgue 2021-04-29 437 710217292a6111 Abdiel Janulgue 2021-04-29 438 total_length = sizeof(query); 710217292a6111 Abdiel Janulgue 2021-04-29 @439 for_each_memory_region(mr, i915, id) { 710217292a6111 Abdiel Janulgue 2021-04-29 440 if (mr->private) 710217292a6111 Abdiel Janulgue 2021-04-29 441 continue; 710217292a6111 Abdiel Janulgue 2021-04-29 442 710217292a6111 Abdiel Janulgue 2021-04-29 443 total_length += sizeof(info); 710217292a6111 Abdiel Janulgue 2021-04-29 444 } 710217292a6111 Abdiel Janulgue 2021-04-29 445 710217292a6111 Abdiel Janulgue 2021-04-29 446 ret = copy_query_item(&query, sizeof(query), total_length, query_item); 710217292a6111 Abdiel Janulgue 2021-04-29 447 if (ret != 0) 710217292a6111 Abdiel Janulgue 2021-04-29 448 return ret; 710217292a6111 Abdiel Janulgue 2021-04-29 449 710217292a6111 Abdiel Janulgue 2021-04-29 450 if (query.num_regions) 710217292a6111 Abdiel Janulgue 2021-04-29 451 return -EINVAL; 710217292a6111 Abdiel Janulgue 2021-04-29 452 710217292a6111 Abdiel Janulgue 2021-04-29 453 for (i = 0; i < ARRAY_SIZE(query.rsvd); i++) { 710217292a6111 Abdiel Janulgue 2021-04-29 454 if (query.rsvd[i]) 710217292a6111 Abdiel Janulgue 2021-04-29 455 return -EINVAL; 710217292a6111 Abdiel Janulgue 2021-04-29 456 } 710217292a6111 Abdiel Janulgue 2021-04-29 457 710217292a6111 Abdiel Janulgue 2021-04-29 458 for_each_memory_region(mr, i915, id) { 710217292a6111 Abdiel Janulgue 2021-04-29 459 if (mr->private) 710217292a6111 Abdiel Janulgue 2021-04-29 460 continue; 710217292a6111 Abdiel Janulgue 2021-04-29 461 710217292a6111 Abdiel Janulgue 2021-04-29 462 info.region.memory_class = mr->type; 710217292a6111 Abdiel Janulgue 2021-04-29 463 info.region.memory_instance = mr->instance; 710217292a6111 Abdiel Janulgue 2021-04-29 464 info.probed_size = mr->total; 710217292a6111 Abdiel Janulgue 2021-04-29 465 info.unallocated_size = mr->avail; 710217292a6111 Abdiel Janulgue 2021-04-29 466 710217292a6111 Abdiel Janulgue 2021-04-29 467 if (__copy_to_user(info_ptr, &info, sizeof(info))) 710217292a6111 Abdiel Janulgue 2021-04-29 468 return -EFAULT; 710217292a6111 Abdiel Janulgue 2021-04-29 469 710217292a6111 Abdiel Janulgue 2021-04-29 470 query.num_regions++; 710217292a6111 Abdiel Janulgue 2021-04-29 471 info_ptr++; 710217292a6111 Abdiel Janulgue 2021-04-29 472 } 710217292a6111 Abdiel Janulgue 2021-04-29 473 710217292a6111 Abdiel Janulgue 2021-04-29 474 if (__copy_to_user(query_ptr, &query, sizeof(query))) 710217292a6111 Abdiel Janulgue 2021-04-29 475 return -EFAULT; 710217292a6111 Abdiel Janulgue 2021-04-29 476 710217292a6111 Abdiel Janulgue 2021-04-29 477 return total_length; 710217292a6111 Abdiel Janulgue 2021-04-29 478 } 710217292a6111 Abdiel Janulgue 2021-04-29 479 :::::: The code at line 439 was first introduced by commit :::::: 710217292a61110a8ccf010cf6886d25e34bf024 drm/i915/query: Expose memory regions through the query uAPI :::::: TO: Abdiel Janulgue <abdiel.janulgue(a)linux.intel.com> :::::: CC: Matthew Auld <matthew.auld(a)intel.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [View Less]

1 0

[PATCH] drm/panel: otm8009a: add a 60 fps mode
by Raphael GALLAIS-POU - foss 05 Sep '21

05 Sep '21

This patch adds a 60 fps mode to the Orisetech OTM8009A panel. The 50 fps mode is left as preferred. Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou(a)foss.st.com> --- .../gpu/drm/panel/panel-orisetech-otm8009a.c | 85 ++++++++++++------- 1 file changed, 56 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c index f80b44a8a700..dfb43b1374e7 100644 --- a/drivers/gpu/drm/panel/panel-… [View More]orisetech-otm8009a.c +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c @@ -60,6 +60,9 @@ #define MCS_CMD2_ENA1 0xFF00 /* Enable Access Command2 "CMD2" */ #define MCS_CMD2_ENA2 0xFF80 /* Enable Access Orise Command2 */ +#define OTM8009A_HDISPLAY 480 +#define OTM8009A_VDISPLAY 800 + struct otm8009a { struct device *dev; struct drm_panel panel; @@ -70,19 +73,35 @@ struct otm8009a { bool enabled; }; -static const struct drm_display_mode default_mode = { - .clock = 29700, - .hdisplay = 480, - .hsync_start = 480 + 98, - .hsync_end = 480 + 98 + 32, - .htotal = 480 + 98 + 32 + 98, - .vdisplay = 800, - .vsync_start = 800 + 15, - .vsync_end = 800 + 15 + 10, - .vtotal = 800 + 15 + 10 + 14, - .flags = 0, - .width_mm = 52, - .height_mm = 86, +static const struct drm_display_mode modes[] = { + { /* 50 Hz, preferred */ + .clock = 29700, + .hdisplay = 480, + .hsync_start = 480 + 98, + .hsync_end = 480 + 98 + 32, + .htotal = 480 + 98 + 32 + 98, + .vdisplay = 800, + .vsync_start = 800 + 15, + .vsync_end = 800 + 15 + 10, + .vtotal = 800 + 15 + 10 + 14, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + .width_mm = 52, + .height_mm = 86, + }, + { /* 60 Hz */ + .clock = 33000, + .hdisplay = 480, + .hsync_start = 480 + 70, + .hsync_end = 480 + 70 + 32, + .htotal = 480 + 70 + 32 + 72, + .vdisplay = 800, + .vsync_start = 800 + 15, + .vsync_end = 800 + 15 + 10, + .vtotal = 800 + 15 + 10 + 16, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + .width_mm = 52, + .height_mm = 86, + }, }; static inline struct otm8009a *panel_to_otm8009a(struct drm_panel *panel) @@ -208,12 +227,11 @@ static int otm8009a_init_sequence(struct otm8009a *ctx) /* Default portrait 480x800 rgb24 */ dcs_write_seq(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x00); - ret = mipi_dsi_dcs_set_column_address(dsi, 0, - default_mode.hdisplay - 1); + ret = mipi_dsi_dcs_set_column_address(dsi, 0, OTM8009A_HDISPLAY - 1); if (ret) return ret; - ret = mipi_dsi_dcs_set_page_address(dsi, 0, default_mode.vdisplay - 1); + ret = mipi_dsi_dcs_set_page_address(dsi, 0, OTM8009A_VDISPLAY - 1); if (ret) return ret; @@ -337,24 +355,33 @@ static int otm8009a_get_modes(struct drm_panel *panel, struct drm_connector *connector) { struct drm_display_mode *mode; - - mode = drm_mode_duplicate(connector->dev, &default_mode); - if (!mode) { - dev_err(panel->dev, "failed to add mode %ux%u@%u\n", - default_mode.hdisplay, default_mode.vdisplay, - drm_mode_vrefresh(&default_mode)); - return -ENOMEM; + unsigned int num_modes = ARRAY_SIZE(modes); + unsigned int i; + + for (i = 0; i < num_modes; i++) { + mode = drm_mode_duplicate(connector->dev, &modes[i]); + if (!mode) { + dev_err(panel->dev, "failed to add mode %ux%u@%u\n", + modes[i].hdisplay, + modes[i].vdisplay, + drm_mode_vrefresh(&modes[i])); + return -ENOMEM; + } + + mode->type = DRM_MODE_TYPE_DRIVER; + + /* Setting first mode as preferred */ + if (!i) + mode->type |= DRM_MODE_TYPE_PREFERRED; + + drm_mode_set_name(mode); + drm_mode_probed_add(connector, mode); } - drm_mode_set_name(mode); - - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; - drm_mode_probed_add(connector, mode); - connector->display_info.width_mm = mode->width_mm; connector->display_info.height_mm = mode->height_mm; - return 1; + return num_modes; } static const struct drm_panel_funcs otm8009a_drm_funcs = { -- 2.17.1 [View Less]

2 1

[Bug 212469] New: plymouth animation freezes during shutdown
by bugzilla-daemon＠bugzilla.kernel.org 05 Sep '21

05 Sep '21

https://bugzilla.kernel.org/show_bug.cgi?id=212469 Bug ID: 212469 Summary: plymouth animation freezes during shutdown Product: Drivers Version: 2.5 Kernel Version: 5.11.6 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: low Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: … [View More]

1 13

← Newer
1
...
72
73
74
75
76
77
78
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2021