dri-devel March 2022

dri-devel@lists.freedesktop.org

370 participants
780 discussions

[PATCH] drm: mali-dp: check the return value of kzalloc()
by xkernel.wang＠foxmail.com 24 Mar '22

24 Mar '22

From: Xiaoke Wang <xkernel.wang(a)foxmail.com> kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Signed-off-by: Xiaoke Wang <xkernel.wang(a)foxmail.com> --- drivers/gpu/drm/arm/malidp_mw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index f5847a7..0720b21 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -70,7 +70,10 @@ static void malidp_mw_connector_reset(struct drm_connector *connector) __drm_atomic_helper_connector_destroy_state(connector->state); kfree(connector->state); - __drm_atomic_helper_connector_reset(connector, &mw_state->base); + connector->state = NULL; + + if (mw_state) + __drm_atomic_helper_connector_reset(connector, &mw_state->base); } static enum drm_connector_status --

2 1

[PATCH] fbdev: udlfb: properly check endpoint type
by Pavel Skripkin 24 Mar '22

24 Mar '22

syzbot reported warning in usb_submit_urb, which is caused by wrong endpoint type. This driver uses out bulk endpoint for communication, so let's check if this endpoint is present and bail out early if not. Fail log: usb 1-1: BOGUS urb xfer, pipe 3 != type 1 WARNING: CPU: 0 PID: 4822 at drivers/usb/core/urb.c:493 usb_submit_urb+0xd27/0x1540 drivers/usb/core/urb.c:493 Modules linked in: CPU: 0 PID: 4822 Comm: kworker/0:3 Tainted: G W 5.13.0-syzkaller #0 ... Workqueue: usb_hub_wq hub_event RIP: 0010:usb_submit_urb+0xd27/0x1540 drivers/usb/core/urb.c:493 ... Call Trace: dlfb_submit_urb+0x89/0x160 drivers/video/fbdev/udlfb.c:1969 dlfb_set_video_mode+0x21f0/0x2950 drivers/video/fbdev/udlfb.c:315 dlfb_ops_set_par+0x2a3/0x840 drivers/video/fbdev/udlfb.c:1110 dlfb_usb_probe.cold+0x113e/0x1f4a drivers/video/fbdev/udlfb.c:1732 usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396 Fixes: 88e58b1a42f8 ("Staging: add udlfb driver") Reported-and-tested-by: syzbot+53ce4a4246d0fe0fee34(a)syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin <paskripkin(a)gmail.com> --- drivers/video/fbdev/udlfb.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index b9cdd02c1000..2343c7955747 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1649,8 +1649,9 @@ static int dlfb_usb_probe(struct usb_interface *intf, const struct device_attribute *attr; struct dlfb_data *dlfb; struct fb_info *info; - int retval = -ENOMEM; + int retval; struct usb_device *usbdev = interface_to_usbdev(intf); + struct usb_endpoint_descriptor *out; /* usb initialization */ dlfb = kzalloc(sizeof(*dlfb), GFP_KERNEL); @@ -1664,6 +1665,12 @@ static int dlfb_usb_probe(struct usb_interface *intf, dlfb->udev = usb_get_dev(usbdev); usb_set_intfdata(intf, dlfb); + retval = usb_find_common_endpoints(intf->cur_altsetting, NULL, &out, NULL, NULL); + if (retval) { + dev_err(&intf->dev, "Device should have at lease 1 bulk endpoint!\n"); + goto error; + } + dev_dbg(&intf->dev, "console enable=%d\n", console); dev_dbg(&intf->dev, "fb_defio enable=%d\n", fb_defio); dev_dbg(&intf->dev, "shadow enable=%d\n", shadow); @@ -1673,6 +1680,7 @@ static int dlfb_usb_probe(struct usb_interface *intf, if (!dlfb_parse_vendor_descriptor(dlfb, intf)) { dev_err(&intf->dev, "firmware not recognized, incompatible device?\n"); + retval = -ENODEV; goto error; } @@ -1686,8 +1694,10 @@ static int dlfb_usb_probe(struct usb_interface *intf, /* allocates framebuffer driver structure, not framebuffer memory */ info = framebuffer_alloc(0, &dlfb->udev->dev); - if (!info) + if (!info) { + retval = -ENOMEM; goto error; + } dlfb->info = info; info->par = dlfb; -- 2.35.1

2 1

[PATCH] video: of: display_timing: Remove a redundant zeroing of memory
by Christophe JAILLET 24 Mar '22

24 Mar '22

of_parse_display_timing() already call memset(0) on its 2nd argument, so there is no need to clear it explicitly before calling this function. Use kmalloc() instead of kzalloc() to save a few cycles. Signed-off-by: Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> --- drivers/video/of_display_timing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index f93b6abbe258..bebd371c6b93 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -199,7 +199,7 @@ struct display_timings *of_get_display_timings(const struct device_node *np) struct display_timing *dt; int r; - dt = kzalloc(sizeof(*dt), GFP_KERNEL); + dt = kmalloc(sizeof(*dt), GFP_KERNEL); if (!dt) { pr_err("%pOF: could not allocate display_timing struct\n", np); -- 2.32.0

2 1

[v3] drm/edid: check basic audio support on CEA extension block
by Lee Shawn C 24 Mar '22

24 Mar '22

From: Cooper Chiou <cooper.chiou(a)intel.com> Tag code stored in bit7:5 for CTA block byte[3] is not the same as CEA extension block definition. Only check CEA block has basic audio support. v3: update commit message. Cc: stable(a)vger.kernel.org Cc: Jani Nikula <jani.nikula(a)intel.com> Cc: Shawn C Lee <shawn.c.lee(a)intel.com> Cc: intel-gfx <intel-gfx(a)lists.freedesktop.org> Signed-off-by: Cooper Chiou <cooper.chiou(a)intel.com> Signed-off-by: Lee Shawn C <shawn.c.lee(a)intel.com> Fixes: e28ad544f462 ("drm/edid: parse CEA blocks embedded in DisplayID") Reviewed-by: Jani Nikula <jani.nikula(a)intel.com> --- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 561f53831e29..f07af6786cec 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4859,7 +4859,8 @@ bool drm_detect_monitor_audio(struct edid *edid) if (!edid_ext) goto end; - has_audio = ((edid_ext[3] & EDID_BASIC_AUDIO) != 0); + has_audio = (edid_ext[0] == CEA_EXT && + (edid_ext[3] & EDID_BASIC_AUDIO) != 0); if (has_audio) { DRM_DEBUG_KMS("Monitor has basic audio support\n"); -- 2.17.1

1 0

RE: [Intel-gfx] [PATCH v5 13/19] drm/i915: Introduce new Tile 4 format
by Chery, Nanley G 24 Mar '22

24 Mar '22

Hi all, Found an error in this description.. > From: Stanislav Lisovskiy stanislav.lisovskiy(a)intel.com<mailto:stanislav.lisovskiy@intel.com> > > This tiling layout uses 4KB tiles in a row-major layout. It has the same > shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4). It > only differs from Tile Y at the 256B granularity in between. At this > granularity, Tile Y has a shape of 16B x 32 rows, but this tiling has a shape > of 64B x 8 rows. > 256B should be 512B (same feedback for the modifier description). Regards, Nanley > Reviewed-by: Imre Deak imre.deak(a)intel.com<mailto:imre.deak@intel.com> > Acked-by: Nanley Chery nanley.g.chery(a)intel.com<mailto:nanley.g.chery@intel.com> > Signed-off-by: Stanislav Lisovskiy stanislav.lisovskiy(a)intel.com<mailto:stanislav.lisovskiy@intel.com> > --- > include/uapi/drm/drm_fourcc.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index fc0c1454d275..b73fe6797fc3 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -572,6 +572,17 @@ extern "C" { > */ > #define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8) > > +/* > + * Intel Tile 4 layout > + * > + * This is a tiled layout using 4KB tiles in a row-major layout. It has the same > + * shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4). It > + * only differs from Tile Y at the 256B granularity in between. At this > + * granularity, Tile Y has a shape of 16B x 32 rows, but this tiling has a shape > + * of 64B x 8 rows. > + */ > +#define I915_FORMAT_MOD_4_TILED fourcc_mod_code(INTEL, 9) > + > /* > * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks > * >

1 0

Re: [RFC v3 5/8] dmabuf: Add gpu cgroup charge transfer function
by Michal Koutný 23 Mar '22

23 Mar '22

On Mon, Mar 21, 2022 at 04:54:26PM -0700, "T.J. Mercier" <tjmercier(a)google.com> wrote: > Since the charge is duplicated in two cgroups for a short period > before it is uncharged from the source cgroup I guess the situation > you're thinking about is a global (or common ancestor) limit? The common ancestor was on my mind (after the self-shortcut). > I can see how that would be a problem for transfers done this way and > an alternative would be to swap the order of the charge operations: > first uncharge, then try_charge. To be certain the uncharge is > reversible if the try_charge fails, I think I'd need either a mutex > used at all gpucg_*charge call sites or access to the gpucg_mutex, Yes, that'd provide safe conditions for such operations, although I'm not sure these special types of memory can afford global lock on their fast paths. > which implies adding transfer support to gpu.c as part of the gpucg_* > API itself and calling it here. Am I following correctly here? My idea was to provide a special API (apart from gpucp_{try_charge,uncharge}) to facilitate transfers... > This series doesn't actually add limit support just accounting, but > I'd like to get it right here. ...which could be implemented (or changed) depending on how the charging is realized internally. Michal

2 2

[GIT PULL] fbdev updates & fixes for v5.18-rc1
by Helge Deller 23 Mar '22

23 Mar '22

Hello Linus, please pull the latest fbdev updates and fixes for kernel 5.18-rc1. This patchset has been in linux-next without any reported problems and includes a lot of small fixes and code cleanups across many traditional fbdev drivers. Thanks! Helge ---------------------------------------------------------------- The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07: Linux 5.17-rc1 (2022-01-23 10:12:53 +0200) are available in the Git repository at: http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git tags/for-5.18/fbdev-1 for you to fetch changes up to e445c8b2aa2df0e49f6037886c32d54a5e3960b1: video: fbdev: kyro: make read-only array ODValues static const (2022-03-11 08:27:37 +0100) ---------------------------------------------------------------- fbdev fixes and updates for kernel v5.18-rc1 Lots of small fixes and code cleanups across most of the fbdev drivers. This includes conversions to use helper functions, const conversions, spelling fixes, help text updates, adding return value checks, small build fixes, and much more. ---------------------------------------------------------------- Arnd Bergmann (1): agp: define proper stubs for empty helpers Cai Huoqing (11): video: fbdev: au1200fb: Make use of dma_mmap_coherent() video: fbdev: omapfb: panel-lgphilips-lb035q02: Make use of the helper function dev_err_probe() video: fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe() video: fbdev: omapfb: panel-sharp-ls037v7dw01: Make use of the helper function dev_err_probe() video: fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe() video: fbdev: da8xx-fb: Make use of the helper function dev_err_probe() video: fbdev: pxa168fb: Make use of the helper function dev_err_probe() video: fbdev: pxa3xx-gcu: Make use of the helper function dev_err_probe() video: fbdev: ssd1307fb: Make use of the helper function dev_err_probe() video: fbdev: s3c-fb: Make use of the helper function dev_err_probe() video: fbdev: mmp: Make use of the helper function dev_err_probe() Changcheng Deng (1): video: fbmem: use swap() to make code cleaner in fb_rotate_logo() Chunyang Zhong (1): video: fbdev: ocfb: add const to of_device_id Colin Ian King (7): video: fbdev: aty128fb: make some arrays static const video: fbdev: mb862xx: remove redundant assignment to pointer ptr video: fbdev: via: Fix spelling mistake "bellow" -> "below" video: fbdev: atyfb: Remove assigned but never used variable statements video: fbdev: asiliantfb: remove redundant assignment to variable Ftarget video: fbdev: pxa168fb: Initialize pointers with NULL and not plain integer 0 video: fbdev: kyro: make read-only array ODValues static const Dan Carpenter (3): video: fbdev: savagefb: make a variable local video: fbdev: atmel_lcdfb: fix an error code in atmel_lcdfb_probe() video: fbdev: fbcvt.c: fix printing in fb_cvt_print_name() Evgeny Novikov (1): video: fbdev: w100fb: Reset global state Geert Uytterhoeven (4): video: fbdev: atari: Fix TT High video mode video: fbdev: atari: Convert to standard round_up() helper video: fbdev: atari: Remove unused atafb_setcolreg() video: fbdev: au1100fb: Spelling s/palette/palette/ George Kennedy (1): video: fbdev: cirrusfb: check pixclock to avoid divide by zero Greg Kroah-Hartman (1): video: fbdev: omapfb: use default_groups in kobj_type Guo Zhengkui (1): video: fbdev: omapfb: Use sysfs_emit() instead of snprintf() Haowen Bai (1): video: fbdev: offb: fix warning comparing pointer to 0 Helge Deller (1): video: fbdev: sm712fb: Fix crash in smtcfb_read() Jiasheng Jiang (1): video: fbdev: imxfb: Check for null res pointer Jing Yao (3): video: fbdev: omapfb: panel-dsi-cm: Use sysfs_emit() instead of snprintf() video: fbdev: omapfb: panel-tpo-td043mtea1: Use sysfs_emit() instead of snprintf() video: fbdev: udlfb: replace snprintf in show functions with sysfs_emit Krzysztof Kozlowski (1): video: fbdev: s3c-fb: drop unneeded MODULE_ALIAS Luca Weiss (2): backlight: qcom-wled: Add PM6150L compatible dt-bindings: simple-framebuffer: allow standalone compatible Miaoqian Lin (1): video: fbdev: omapfb: Add missing of_node_put() in dvic_probe_of Michael Schmitz (1): video: fbdev: atari: Atari 2 bpp (STe) palette bugfix Minghao Chi (1): video: fbdev: mach64_ct: remove redundant res variable Tim Gardner (1): video: fbdev: nvidiafb: Use strscpy() to prevent buffer overflow Wang Hai (1): video: fbdev: smscufx: Fix null-ptr-deref in ufx_usb_probe() Wei Ming Chen (1): video: fbdev: Fix wrong file path for pvr2fb.c in Kconfig help text Xiaoke Wang (1): video: fbdev: via: check the return value of kstrdup() Xu Wang (2): backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls video: fbdev: omapfb: Remove redundant 'flush_workqueue()' calls Yang Guang (2): video: fbdev: sis: use swap() to make code cleaner video: fbdev: omapfb: acx565akm: replace snprintf with sysfs_emit Yang Li (2): video: fbdev: pxa168fb: Remove unnecessary print function dev_err() video: fbdev: pxa3xx-gcu: Remove unnecessary print function dev_err() Yihao Han (1): video: fbdev: s3c-fb: fix platform_get_irq.cocci warning YueHaibing (1): video: fbdev: controlfb: Fix COMPILE_TEST build Z. Liu (1): video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen Zheyu Ma (1): video: fbdev: sm712fb: Fix crash in smtcfb_write() zhaoxiao (1): video: fbdev: s3c-fb: Use platform_get_irq() to get the interrupt .../bindings/display/simple-framebuffer.yaml | 12 +++-- arch/parisc/include/asm/agp.h | 4 +- arch/powerpc/include/asm/agp.h | 4 +- arch/sparc/include/asm/agp.h | 6 +-- drivers/video/backlight/lm3630a_bl.c | 1 - drivers/video/backlight/qcom-wled.c | 1 + drivers/video/fbdev/Kconfig | 2 +- drivers/video/fbdev/asiliantfb.c | 2 +- drivers/video/fbdev/atafb.c | 35 +++++--------- drivers/video/fbdev/atmel_lcdfb.c | 11 +++-- drivers/video/fbdev/aty/aty128fb.c | 10 ++-- drivers/video/fbdev/aty/mach64_ct.c | 4 +- drivers/video/fbdev/aty/mach64_gx.c | 2 - drivers/video/fbdev/au1100fb.c | 2 +- drivers/video/fbdev/au1100fb.h | 2 +- drivers/video/fbdev/au1200fb.c | 4 +- drivers/video/fbdev/cirrusfb.c | 16 +++---- drivers/video/fbdev/controlfb.c | 2 + drivers/video/fbdev/core/fbcvt.c | 53 +++++++++------------- drivers/video/fbdev/core/fbmem.c | 8 +--- drivers/video/fbdev/da8xx-fb.c | 7 ++- drivers/video/fbdev/imxfb.c | 2 + drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +- drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +- drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 3 +- drivers/video/fbdev/nvidia/nv_i2c.c | 2 +- drivers/video/fbdev/ocfb.c | 2 +- drivers/video/fbdev/offb.c | 2 +- drivers/video/fbdev/omap/lcd_ams_delta.c | 16 +++---- drivers/video/fbdev/omap/omapfb_main.c | 13 +++--- .../fbdev/omap2/omapfb/displays/connector-dvi.c | 1 + .../fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 8 ++-- .../omapfb/displays/panel-lgphilips-lb035q02.c | 7 ++- .../omapfb/displays/panel-sharp-ls037v7dw01.c | 7 ++- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 2 +- .../omap2/omapfb/displays/panel-tpo-td043mtea1.c | 7 ++- .../video/fbdev/omap2/omapfb/dss/display-sysfs.c | 3 +- .../video/fbdev/omap2/omapfb/dss/manager-sysfs.c | 3 +- .../video/fbdev/omap2/omapfb/dss/overlay-sysfs.c | 3 +- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 - drivers/video/fbdev/pxa168fb.c | 15 +++--- drivers/video/fbdev/pxa3xx-gcu.c | 10 ++-- drivers/video/fbdev/s3c-fb.c | 20 ++++---- drivers/video/fbdev/savage/savagefb.h | 1 - drivers/video/fbdev/savage/savagefb_driver.c | 7 +-- drivers/video/fbdev/sis/sis_main.c | 2 +- drivers/video/fbdev/sm712fb.c | 46 +++++-------------- drivers/video/fbdev/smscufx.c | 3 +- drivers/video/fbdev/ssd1307fb.c | 7 ++- drivers/video/fbdev/udlfb.c | 8 ++-- drivers/video/fbdev/via/lcd.c | 2 +- drivers/video/fbdev/via/viafbdev.c | 10 ++++ drivers/video/fbdev/w100fb.c | 15 ++++-- 54 files changed, 189 insertions(+), 233 deletions(-)

2 1

[PATCH v4 0/3] drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors
by Kieran Bingham 23 Mar '22

23 Mar '22

Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and provide IRQ based hotplug detect to identify when the connector is present. no-hpd is extended to be the default behaviour for non DisplayPort connectors. This series is based upon Sam Ravnborgs and Rob Clarks series [0] to support DRM_BRIDGE_STATE_OPS and NO_CONNECTOR support on the SN65DSI86, however some extra modifications have been made on the top of Sam's series to fix compile breakage and the NO_CONNECTOR support. A full branch with these changes is available at [1] As in v3, I have not taken ownership of the patches at [0], so it would be good to hear if Sam has any plans to revive or push this series. These patches are not expected to be integrated without [0]. [0] https://lore.kernel.org/all/20220206154405.1243333-1-sam@ravnborg.org/ [1] git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git branch: kbingham/drm-misc/next/sn65dsi86/hpd Kieran Bingham (1): drm/bridge: ti-sn65dsi86: Support hotplug detection Laurent Pinchart (2): drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode drm/bridge: ti-sn65dsi86: Implement bridge connector operations drivers/gpu/drm/bridge/ti-sn65dsi86.c | 191 ++++++++++++++++++++++++-- 1 file changed, 176 insertions(+), 15 deletions(-) -- 2.32.0

2 6

[PATCH] drm/amd/display: use NULL instead of using plain integer as pointer
by Haowen Bai 23 Mar '22

23 Mar '22

This fixes the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: warning: Using plain integer as NULL pointer Signed-off-by: Haowen Bai <baihaowen(a)meizu.com> --- drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c index ec636d0..ef75eb7 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c @@ -68,7 +68,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc, int sel = table_hash(mode, bpc, max_min); int table_size = 0; int index; - const struct qp_entry *table = 0L; + const struct qp_entry *table = NULL; // alias enum enum { min = DAL_MM_MIN, max = DAL_MM_MAX }; -- 2.7.4

2 1

[PATCH 00/22] drm: Review of mode copies
by Ville Syrjala 23 Mar '22

23 Mar '22

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> I might be taking this a bit too far, but the lack of consistency in our methods to copy drm_display_mode structs around is bugging me. The main worry is the embedded list head, which if clobbered could lead to list corruption. I'd also prefer to make sure even the valid list heads don't propagate between copies since that makes no sense. While going through some of the code I also spotted some very weird on stack copies being made for no reason at all. I elimininated a few of them here, but there could certainly be more lurking in the shadows. Cc: Abhinav Kumar <quic_abhinavk(a)quicinc.com> Cc: Alain Volmat <alain.volmat(a)foss.st.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: Andrzej Hajda <andrzej.hajda(a)intel.com> Cc: Aurabindo Pillai <aurabindo.pillai(a)amd.com> Cc: Chen Feng <puck.chen(a)hisilicon.com> Cc: Chun-Kuang Hu <chunkuang.hu(a)kernel.org> Cc: Emma Anholt <emma(a)anholt.net> Cc: freedreno(a)lists.freedesktop.org Cc: Harry Wentland <harry.wentland(a)amd.com> Cc: "Heiko Stübner" <heiko(a)sntech.de> Cc: Jernej Skrabec <jernej.skrabec(a)gmail.com> Cc: John Stultz <john.stultz(a)linaro.org> Cc: Jonas Karlman <jonas(a)kwiboo.se> Cc: Jyri Sarha <jyri.sarha(a)iki.fi> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Leo Li <sunpeng.li(a)amd.com> Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-arm-msm(a)vger.kernel.org Cc: linux-rockchip(a)lists.infradead.org Cc: Maxime Ripard <mripard(a)kernel.org> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Nikola Cornij <nikola.cornij(a)amd.com> Cc: Patrik Jakobsson <patrik.r.jakobsson(a)gmail.com> Cc: Philipp Zabel <p.zabel(a)pengutronix.de> Cc: Rob Clark <robdclark(a)gmail.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: Rodrigo Siqueira <Rodrigo.Siqueira(a)amd.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Sandy Huang <hjc(a)rock-chips.com> Cc: Sean Paul <sean(a)poorly.run> Cc: Thierry Reding <thierry.reding(a)gmail.com> Cc: Tian Tao <tiantao6(a)hisilicon.com> Cc: Tomi Valkeinen <tomba(a)kernel.org> Cc: Xinliang Liu <xinliang.liu(a)linaro.org> Cc: Xinwei Kong <kong.kongxinwei(a)hisilicon.com> Ville Syrjälä (22): drm: Add drm_mode_init() drm/amdgpu: Remove pointless on stack mode copies drm/amdgpu: Use drm_mode_init() for on-stack modes drm/amdgpu: Use drm_mode_copy() drm/radeon: Use drm_mode_copy() drm/bridge: Use drm_mode_copy() drm/gma500: Use drm_mode_copy() drm/hisilicon: Use drm_mode_init() for on-stack modes drm/imx: Use drm_mode_duplicate() drm/msm: Nuke weird on stack mode copy drm/msm: Use drm_mode_init() for on-stack modes drm/msm: Use drm_mode_copy() drm/mtk: Use drm_mode_init() for on-stack modes drm/rockchip: Use drm_mode_copy() drm/sti: Use drm_mode_copy() drm/tilcdc: Use drm_mode_copy() drm/vc4: Use drm_mode_copy() drm/i915: Use drm_mode_init() for on-stack modes drm/i915: Use drm_mode_copy() drm/panel: Use drm_mode_duplicate() drm: Use drm_mode_init() for on-stack modes drm: Use drm_mode_copy() .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 4 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 41 ++++++++++--------- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- drivers/gpu/drm/bridge/tc358767.c | 2 +- drivers/gpu/drm/drm_crtc_helper.c | 12 +++--- drivers/gpu/drm/drm_edid.c | 8 +++- drivers/gpu/drm/drm_modes.c | 21 +++++++++- drivers/gpu/drm/drm_vblank.c | 2 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 8 +--- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 20 +++++---- drivers/gpu/drm/imx/imx-ldb.c | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 ++-- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++--- drivers/gpu/drm/panel/panel-truly-nt35597.c | 3 +- .../gpu/drm/panel/panel-visionox-rm69299.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 4 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 +- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 2 +- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 5 +-- include/drm/drm_modes.h | 2 + 30 files changed, 105 insertions(+), 79 deletions(-) -- 2.34.1

15 56

← Newer
1
...
30
31
32
33
34
35
36
...
78
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2022