https://bugs.freedesktop.org/show_bug.cgi?id=100070
Bug ID: 100070 Summary: Rocket League: grass gets rendered incorrectly Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: gr.muench@gmail.com QA Contact: dri-devel@lists.freedesktop.org
Created attachment 130079 --> https://bugs.freedesktop.org/attachment.cgi?id=130079&action=edit grass in the main menu
The grass has some black lines in where it shouldnt be. Im on Radeon HD 7970. But looks like there are more people with the same problem: http://www.psyonix.com/forum/viewtopic.php?f=34&t=32544 https://www.reddit.com/r/RocketLeague/comments/51wvei/my_impressions_on_the_...
https://bugs.freedesktop.org/show_bug.cgi?id=100070
Gregor Münch gr.muench@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ttimo@ttimo.net
--- Comment #1 from Gregor Münch gr.muench@gmail.com --- No progress here in the last 3 months. Adding porter to CC list, maybe its a game specific bug, as it looks definitely different than the Windows version. However by looking at different youtube videos the game looks properly rendered on linux nvidia driver.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #2 from Nicolai Hähnle nhaehnle@gmail.com --- Could you provide an apitrace?
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #3 from Gregor Münch gr.muench@gmail.com --- Thanks for your response, I will try to provide the trace by the end of the week.
Im just curious, since Plagman can give you the steam key and the problem also exists on RX470 / RX480 according to the links provided above, which means it looks more like an general problem, wouldnt it speed up the process if yourself would just look into the problem?
However Im happy to deliver that trace for you.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #4 from Gregor Münch gr.muench@gmail.com --- Here you are: https://en.file-upload.net/download-12558010/RocketLeague.trace.7z.html
I have a very slow upload, so I compressed the file.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #5 from Ilia Mirkin imirkin@alum.mit.edu --- (In reply to Gregor Münch from comment #3)
Im just curious, since Plagman can give you the steam key and the problem also exists on RX470 / RX480 according to the links provided above, which means it looks more like an general problem, wouldnt it speed up the process if yourself would just look into the problem?
Ultimately the easiest way to reproduce issues is with apitrace or similar tool. Using it doesn't require knowing how to get to the relevant part of the game, or other necessary conditions to trigger the issue.
Farming out the apitrace collection to the bug reporters is one of the ways to reduce the workload on the developers (as there are ~infinite bug reporters, and a very finite number of developers).
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #6 from Gregor Münch gr.muench@gmail.com --- (In reply to Ilia Mirkin from comment #5)
Ultimately the easiest way to reproduce issues is with apitrace or similar tool. Using it doesn't require knowing how to get to the relevant part of the game, or other necessary conditions to trigger the issue.
Farming out the apitrace collection to the bug reporters is one of the ways to reduce the workload on the developers (as there are ~infinite bug reporters, and a very finite number of developers).
Thanks for the explanation. All this is true but:
-its a popular game, Top10 in Steam ranking, so Valve as AMD should have some interest seeing the game working as good as it does on nvidia -in this case, its seems it doesnt depend on the architecture, its a problem with GCN 1.0 - 4.0 and maybe Intel too, so it can be reproduced with any hardware -I cant imagine fixing those bugs is possible without testing the real game, in the end you still need the game to see the impact of your changes
However Im fine with whatever is best for you guys.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #7 from Nicolai Hähnle nhaehnle@gmail.com --- Hmm, I'm afraid that looks a bit tricky to analyze. I wonder if the game actually does something slightly different on NVidia cards? Would be nice if somebody could replay the trace on different hardware and see if the problem exists there as well.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #8 from Gregor Münch gr.muench@gmail.com --- As said, watching some youtube clips, Nvidia Linux: https://www.youtube.com/watch?v=Mjpj3ncO1lw AMD Windows: https://www.youtube.com/watch?v=Q8C_w7ouaNI
All show correct rendering.
Its of course something else if it takes another renderpath with mesa and amdgpu-pro.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #9 from Marek Olšák maraeo@gmail.com --- It might be a WQM vs KILL issue.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #10 from Marek Olšák maraeo@gmail.com --- I have a basic initial fix for the grass issue. It works as follows.
The GLSL discard call site sets a flag that the pixel should be killed, but doesn't kill the thread. The thread is killed at the end of the shader.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #11 from Gregor Münch gr.muench@gmail.com --- Thank you very much for fixing this! Its sad to see that our first guess was true and this is actually a game bug. Since TTimo is CCed already:
@Timothee Could you respond if a game fix is planned?
https://bugs.freedesktop.org/show_bug.cgi?id=100070
--- Comment #12 from Timothee Besset ttimo@ttimo.net --- No game fix is planned at this time.
Marek's addition of glsl_correct_derivatives_after_discard is generally a good thing for mesa compatibility with the broader GL driver ecosystem.
https://bugs.freedesktop.org/show_bug.cgi?id=100070
Gregor Münch gr.muench@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #13 from Gregor Münch gr.muench@gmail.com --- Finally its fixed. Thank you all involved! Also, I measured no performance difference. Please also send this to stable!
If someone wants the old behavior back: glsl_correct_derivatives_after_discard=false
Thanks for the response @Timothee
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org