dri-devel March 2022

dri-devel@lists.freedesktop.org

370 participants
780 discussions

Start a nNew thread

[PATCH 0/8] Some more bits for small BAR enabling
by Matthew Auld 07 Mar '22

07 Mar '22

The leftover bits around dealing with stolen-local memory + small BAR, plus some related fixes. -- 2.34.1

3 14

[PATCH v5 0/3] Update VMware maintainer entries
by Srivatsa S. Bhat 07 Mar '22

07 Mar '22

This series updates a few maintainer entries for VMware-maintained subsystems and cleans up references to VMware's private mailing lists to make it clear that they are effectively email-aliases to reach out to reviewers. Changes from v4->v5: - Add Alexey as reviewer for paravirt ops. Changes from v3->v4: - Remove Cc: stable(a)vger.kernel.org from patches 1 and 2. Changes from v1->v3: - Add Zack as the named maintainer for vmmouse driver - Use R: to denote email-aliases for VMware reviewers Regards, Srivatsa VMware Photon OS --- Srivatsa S. Bhat (VMware) (3): MAINTAINERS: Update maintainers for paravirt ops and VMware hypervisor interface MAINTAINERS: Add Zack as maintainer of vmmouse driver MAINTAINERS: Mark VMware mailing list entries as email aliases MAINTAINERS | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-)

1 2

[PATCH v12 0/6] Use drm_clflush* instead of clflush
by Michael Cheng 07 Mar '22

07 Mar '22

This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures. v2: s/PAGE_SIZE/sizeof(value) for Re-work intel_write_status_page and added more patches to convert additional clflush/clflushopt to use drm_clflush*. (Michael Cheng) v3: Drop invalidate_csb_entries and directly invoke drm_clflush_virt_ran v4: Remove extra memory barriers v5: s/cache_clflush_range/drm_clflush_virt_range v6: Fix up "Drop invalidate_csb_entries" to use correct parameters. Also added in arm64 support for drm_clflush_virt_range. v7: Re-order patches, and use correct macro for dcache flush for arm64. v8: Remove ifdef for asm/cacheflush. v9: Rebased v10: Replaced asm/cacheflush with linux/cacheflush v11: Correctly get the sizeof certian addresses. Also rebased to the latest. v12: Drop include of cacheflush.h and use caches_clean_inval_pou instead of dcache_clean_inval_poc, since it is not exported for other modules to use. Michael Cheng (6): drm: Add arch arm64 for drm_clflush_virt_range drm/i915/gt: Re-work intel_write_status_page drm/i915/gt: Drop invalidate_csb_entries drm/i915/gt: Re-work reset_csb drm/i915/: Re-work clflush_write32 drm/i915/gt: replace cache_clflush_range drivers/gpu/drm/drm_cache.c | 5 +++++ .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++----- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 +++++------ drivers/gpu/drm/i915/gt/intel_engine.h | 13 ++++-------- .../drm/i915/gt/intel_execlists_submission.c | 20 +++++++------------ drivers/gpu/drm/i915/gt/intel_gtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 8 files changed, 28 insertions(+), 36 deletions(-) -- 2.25.1

5 21

[PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()
by Dan Carpenter 07 Mar '22

07 Mar '22

Set the error code to -ENOMEM if drm_random_order() fails. Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c index fa997f89522b..6eba590afa9b 100644 --- a/drivers/gpu/drm/selftests/test-drm_buddy.c +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) } order = drm_random_order(mm.max_order + 1, &prng); - if (!order) + if (!order) { + err = -ENOMEM; goto out_fini; + } for (i = 0; i <= mm.max_order; ++i) { struct drm_buddy_block *block; -- 2.20.1

3 3

[PATCH 0/8] drm/vmwgfx: 3D on arm64 and large cursor support
by Zack Rusin 07 Mar '22

07 Mar '22

From: Zack Rusin <zackr(a)vmware.com> Series finishes 3D support on arm64 with vmwgfx. With this and changes that add svga3 pci id's to Mesa3D - OpenGL 4.3 and GLES 3.1 work smoothly on arm64. Most changes are not svga3 specific but rather could be classified as generic improvements. That's in particular true for support for curso mobs which enable large cursor support on both svga2 and svga3 and fixing initialization of drm_mode_fb_cmd2 struct. Martin Krastev (1): drm/vmwgfx: Add support for CursorMob and CursorBypass 4 Zack Rusin (7): drm/vmwgfx: Cleanup multimon initialization code drm/vmwgfx: Print capabilities early during the initialization drm/vmwgfx: Fix fencing on SVGAv3 drm/vmwgfx: Allow querying of the SVGA PCI id from the userspace drm/vmwgfx: Initialize drm_mode_fb_cmd2 drm/vmwgfx: Implement MSI/MSI-X support for IRQs drm/vmwgfx: Stop using surface dma commands on most configurations drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 20 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 23 +- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 28 +- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 27 +- drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 80 ++++- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 407 +++++++++++++++++++++----- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 28 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 36 ++- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 17 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 27 +- include/uapi/drm/vmwgfx_drm.h | 9 +- 13 files changed, 538 insertions(+), 168 deletions(-) -- 2.32.0

2 10

[PATCH v4 0/4] Update mdp clk to max supported value to support higher refresh rates
by Vinod Polimera 07 Mar '22

07 Mar '22

Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. Drop the assigned clock rate property and vote on the mdp clock as per calculated value during the usecase. Changes in v2: - Remove assigned-clock-rate property and set mdp clk during resume sequence. - Add fixes tag. Changes in v3: - Remove extra line after fixes tag.(Stephen Boyd) - Add similar changes for sc7180, sdm845 which uses opp table for voting mdp clk.(Stephen Boyd) - Drop patch: "drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table" Changes in v4: - Add similar change for sm8250.(Dmitry) Vinod Polimera (4): arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk arm64/dts/qcom/sm8250: remove assigned-clock-rate property for mdp clk arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 ++------- arch/arm64/boot/dts/qcom/sm8250.dtsi | 9 ++------- 4 files changed, 8 insertions(+), 28 deletions(-) -- 2.7.4

5 16

[PATCH v2] drm/mode: Improve drm_mode_fb_cmd2 documentation
by Geert Uytterhoeven 07 Mar '22

07 Mar '22

From: Geert Uytterhoeven <geert(a)linux-m68k.org> Fix various grammar mistakes in the kerneldoc comments documenting the drm_mode_fb_cmd2 structure: - s/is/are/, - s/8 bit/8-bit/. Signed-off-by: Geert Uytterhoeven <geert(a)linux-m68k.org> Acked-by: Sam Ravnborg <sam(a)ravnborg.org> --- v2: - Add Acked-by, - Rebase on top of commit a3574119826d9a4e ("drm: document struct drm_mode_fb_cmd2") in drm-next. --- include/uapi/drm/drm_mode.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 0a0d56a6158e6327..fa953309d9ce5775 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -675,11 +675,11 @@ struct drm_mode_fb_cmd { * fetch metadata about an existing frame-buffer. * * In case of planar formats, this struct allows up to 4 buffer objects with - * offsets and pitches per plane. The pitch and offset order is dictated by the - * format FourCC as defined by ``drm_fourcc.h``, e.g. NV12 is described as: + * offsets and pitches per plane. The pitch and offset order are dictated by + * the format FourCC as defined by ``drm_fourcc.h``, e.g. NV12 is described as: * - * YUV 4:2:0 image with a plane of 8 bit Y samples followed by an - * interleaved U/V plane containing 8 bit 2x2 subsampled colour difference + * YUV 4:2:0 image with a plane of 8-bit Y samples followed by an + * interleaved U/V plane containing 8-bit 2x2 subsampled colour difference * samples. * * So it would consist of a Y plane at ``offsets[0]`` and a UV plane at -- 2.25.1

2 1

Re: [PATCH 5.15 000/262] 5.15.27-rc1 review
by Naresh Kamboju 07 Mar '22

07 Mar '22

On Mon, 7 Mar 2022 at 15:07, Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> wrote: > > This is the start of the stable review cycle for the 5.15.27 release. > There are 262 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 09 Mar 2022 09:16:25 +0000. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.27-rc… > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y > and the diffstat can be found below. > > thanks, > > greg k-h Following build errors/warnings noticed on arm64. arch/arm64/net/bpf_jit_comp.c: In function 'build_insn': arch/arm64/net/bpf_jit_comp.c:791:21: error: implicit declaration of function 'bpf_pseudo_func' [-Werror=implicit-function-declaration] 791 | if (bpf_pseudo_func(insn)) | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors drivers/gpu/drm/mediatek/mtk_dsi.c: In function 'mtk_dsi_host_attach': drivers/gpu/drm/mediatek/mtk_dsi.c:858:28: error: implicit declaration of function 'devm_drm_of_get_bridge'; did you mean 'devm_drm_panel_bridge_add'? [-Werror=implicit-function-declaration] 858 | dsi->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); | ^~~~~~~~~~~~~~~~~~~~~~ | devm_drm_panel_bridge_add drivers/gpu/drm/mediatek/mtk_dsi.c:858:26: warning: assignment to 'struct drm_bridge *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 858 | dsi->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); | ^ cc1: some warnings being treated as errors Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> Build log [1]. -- Linaro LKFT https://lkft.linaro.org [1] https://builds.tuxbuild.com/263ZKyWWLLcPGRbiZwIEZw3wvXX/

2 2

Re: [PATCH RFC 0/3] MAP_POPULATE for device memory
by Jarkko Sakkinen 07 Mar '22

07 Mar '22

On Mon, Mar 07, 2022 at 07:56:53AM -0800, Christoph Hellwig wrote: > On Mon, Mar 07, 2022 at 03:29:35PM +0200, Jarkko Sakkinen wrote: > > So what would you suggest to sort out the issue? I'm happy to go with > > ioctl if nothing else is acceptable. > > PLenty of drivers treat all mmaps as if MAP_POPULATE was specified, > typically by using (io_)remap_pfn_range. If there any reason to only > optionally have the pre-fault semantics for sgx? If not this should > be really simple. And if we have a real need for it to be optional > we'll just need to find a sane way to pass that information to ->mmap. Dave, what if mmap() would just unconditionally EAUG after initialization? It's an option, yes. BR, Jarkko

1 0

RE: a null derefrence at [v7, 9/9] drm/omap: Add a 'right overlay' to plane state
by Weiguo Li 07 Mar '22

07 Mar '22

> > From: Benoit Parrot <bparrot(a)ti.com> > > If the drm_plane has a source width that's greater than the max width > supported by a single hw overlay, then we assign a 'r_overlay' to it in > omap_plane_atomic_check(). > > Both overlays should have the capabilities required to handle the source > framebuffer. The only parameters that vary between the left and right > hwoverlays are the src_w, crtc_w, src_x and crtc_x as we just even chop > the fb into left and right halves. > > We also take care of not creating odd width size when dealing with YUV > formats. > > Since both halves need to be 'appear' side by side the zpos is > recalculated when dealing with dual overlay cases so that the other > planes zpos is consistent. > > Depending on user space usage it is possible that on occasion the number > of requested planes exceeds the numbers of overlays required to display > them. In that case a failure would be returned for the plane that cannot > be handled at that time. It is up to user space to make sure the H/W > resource are not over-subscribed. > > Signed-off-by: Benoit Parrot <bparrot(a)ti.com> > Signed-off-by: Neil Armstrong <narmstrong(a)baylibre.com> > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 98 ++++++++++++++++++++- > drivers/gpu/drm/omapdrm/omap_fb.c | 33 ++++++- > drivers/gpu/drm/omapdrm/omap_fb.h | 4 +- > drivers/gpu/drm/omapdrm/omap_overlay.c | 23 ++++- > drivers/gpu/drm/omapdrm/omap_overlay.h | 3 +- > drivers/gpu/drm/omapdrm/omap_plane.c | 117 +++++++++++++++++++++++-- > drivers/gpu/drm/omapdrm/omap_plane.h | 1 + > 7 files changed, 267 insertions(+), 12 deletions(-) > > ... > > diff --git a/drivers/gpu/drm/omapdrm/omap_overlay.c b/drivers/gpu/drm/omapdrm/omap_overlay.c > index afb2b44fdf86..10730c9b2752 100644 > --- a/drivers/gpu/drm/omapdrm/omap_overlay.c > +++ b/drivers/gpu/drm/omapdrm/omap_overlay.c > @@ -67,12 +67,13 @@ omap_plane_find_free_overlay(struct drm_device *dev, struct drm_plane *hwoverlay > * next global overlay_map to be enabled when atomic transaction is valid. > */ > int omap_overlay_assign(struct drm_atomic_state *s, struct drm_plane *plane, > - u32 caps, u32 fourcc, struct omap_hw_overlay **overlay) > + u32 caps, u32 fourcc, struct omap_hw_overlay **overlay, > + struct omap_hw_overlay **r_overlay) > { > /* Get the global state of the current atomic transaction */ > struct omap_global_state *state = omap_get_global_state(s); > struct drm_plane **overlay_map = state->hwoverlay_to_plane; > - struct omap_hw_overlay *ovl; > + struct omap_hw_overlay *ovl, *r_ovl; > > ovl = omap_plane_find_free_overlay(s->dev, overlay_map, caps, fourcc); > if (!ovl) > @@ -81,8 +82,26 @@ int omap_overlay_assign(struct drm_atomic_state *s, struct drm_plane *plane, > overlay_map[ovl->idx] = plane; > *overlay = ovl; > > + if (r_overlay) { > + r_ovl = omap_plane_find_free_overlay(s->dev, overlay_map, > + caps, fourcc); > + if (!r_ovl) { > + overlay_map[r_ovl->idx] = NULL; Hi, a null derefrence "r_ovl->idx" when "r_ovl" is null, in inner if clause.

1 0

← Newer
1
...
60
61
62
63
64
65
66
...
78
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel March 2022